Re: [PATCH v5 0/6] bcm2835: auxiliar device support for spi

2015-09-10 Thread Noralf Trønnes
Den 09.09.2015 03:48, skrev Eric Anholt: ker...@martin.sperl.org writes: From: Martin Sperl The BCM2835 contains 3 auxiliar devices: * spi1 * spi2 * uart1 All of those 3 devices are enabled/disabled via a shared register, which is set by default to be disabled.

Re: [PATCH 3/3] staging: fbtft: use pr_fmt

2015-09-10 Thread Noralf Trønnes
10.09.2015 06:54, skrev Sudip Mukherjee: On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote: Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote: Instead of defining DRVNAME and using it in all calls to pr_* family

Re: [PATCH 3/3] staging: fbtft: use pr_fmt

2015-09-09 Thread Noralf Trønnes
Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote: Instead of defining DRVNAME and using it in all calls to pr_* family of macros lets start using pr_fmt. Signed-off-by: Sudip Mukherjee --- drivers/staging/fbtft/fbtft_device.c |

Re: [PATCH 3/3] staging: fbtft: use pr_fmt

2015-09-09 Thread Noralf Trønnes
Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote: Instead of defining DRVNAME and using it in all calls to pr_* family of macros lets start using pr_fmt. Signed-off-by: Sudip Mukherjee ---

Re: [PATCH 1/2] staging: fbtft: fix 9-bit SPI support detection

2015-08-25 Thread Noralf Trønnes
--- drivers/staging/fbtft/fbtft-core.c | 10 +++--- drivers/staging/fbtft/flexfb.c | 11 --- 2 files changed, 7 insertions(+), 14 deletions(-) Thanks Stefan. Both patches: Acked-by: Noralf Trønnes -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH RFC 2/2] staging: fbtft: fix 9-bit SPI support detection

2015-08-25 Thread Noralf Trønnes
Den 25.08.2015 19:34, skrev Stefan Wahren: Noralf Trønnes hat am 25. August 2015 um 00:00 geschrieben: Den 24.08.2015 20:33, skrev Stefan Wahren: Since bits_per_word isn't usually checked during SPI setup the 9-bit support must be checked manually. Signed-off-by: Stefan Wahren

Re: [PATCH RFC 2/2] staging: fbtft: fix 9-bit SPI support detection

2015-08-25 Thread Noralf Trønnes
Den 25.08.2015 19:34, skrev Stefan Wahren: Noralf Trønnes nor...@tronnes.org hat am 25. August 2015 um 00:00 geschrieben: Den 24.08.2015 20:33, skrev Stefan Wahren: Since bits_per_word isn't usually checked during SPI setup the 9-bit support must be checked manually. Signed-off-by: Stefan

Re: [PATCH 1/2] staging: fbtft: fix 9-bit SPI support detection

2015-08-25 Thread Noralf Trønnes
stefan.wah...@i2se.com --- drivers/staging/fbtft/fbtft-core.c | 10 +++--- drivers/staging/fbtft/flexfb.c | 11 --- 2 files changed, 7 insertions(+), 14 deletions(-) Thanks Stefan. Both patches: Acked-by: Noralf Trønnes nor...@tronnes.org -- To unsubscribe from this list

Re: [PATCH RFC 2/2] staging: fbtft: fix 9-bit SPI support detection

2015-08-24 Thread Noralf Trønnes
Den 24.08.2015 20:33, skrev Stefan Wahren: Since bits_per_word isn't usually checked during SPI setup the 9-bit support must be checked manually. Signed-off-by: Stefan Wahren --- drivers/staging/fbtft/fbtft-core.c |7 +++ drivers/staging/fbtft/flexfb.c |7 +++ 2 files

Re: [PATCH RFC 2/2] staging: fbtft: fix 9-bit SPI support detection

2015-08-24 Thread Noralf Trønnes
Den 24.08.2015 20:33, skrev Stefan Wahren: Since bits_per_word isn't usually checked during SPI setup the 9-bit support must be checked manually. Signed-off-by: Stefan Wahren stefan.wah...@i2se.com --- drivers/staging/fbtft/fbtft-core.c |7 +++ drivers/staging/fbtft/flexfb.c |

Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

2015-08-02 Thread Noralf Trønnes
chip controller simply defining a new flexfb_lcd_controller struct. Signed-off-by: Fabio Falzoi Acked-by: Noralf Trønnes --- Seems I wasn't clear enough, you could use my ack if you put struct flexfb_lcd_controller inside the driver and not in fbtft.h Noralf. -- To unsubscribe from this list

Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

2015-08-02 Thread Noralf Trønnes
chip controller simply defining a new flexfb_lcd_controller struct. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com Acked-by: Noralf Trønnes nor...@tronnes.org --- Seems I wasn't clear enough, you could use my ack if you put struct flexfb_lcd_controller inside the driver and not in fbtft.h

[PATCH] staging: fbtft: core: Don't set device platform_data

2015-07-30 Thread Noralf Trønnes
to freed memory. Signed-off-by: Noralf Trønnes --- drivers/staging/fbtft/fbtft-core.c | 12 +--- drivers/staging/fbtft/fbtft.h | 5 +++-- drivers/staging/fbtft/flexfb.c | 2 +- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c

[PATCH] staging: fbtft: core: Don't set device platform_data

2015-07-30 Thread Noralf Trønnes
. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft/fbtft-core.c | 12 +--- drivers/staging/fbtft/fbtft.h | 5 +++-- drivers/staging/fbtft/flexfb.c | 2 +- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c

Re: [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller

2015-07-23 Thread Noralf Trønnes
Den 14.07.2015 14:59, skrev Henri Chain: This is a driver chip for 240x160 4-bit greyscale LCDs. It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been tested. (It also has a 6800 or 8080-style parallel interface, but I have not included support for it.) Signed-off-by: Henri

Re: [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller

2015-07-23 Thread Noralf Trønnes
Den 15.07.2015 11:36, skrev Paul Bolle: On di, 2015-07-14 at 14:59 +0200, Henri Chain wrote: --- /dev/null +++ b/drivers/staging/fbtft/fb_uc1611.c +#define DRVNAME"fb_uc1611" +MODULE_ALIAS("spi:" DRVNAME); +MODULE_ALIAS("platform:" DRVNAME); +MODULE_ALIAS("spi:uc1611");

Re: [PATCH 06/10] Staging: fbtft: Use a helper function to set set_addr_win op

2015-07-23 Thread Noralf Trønnes
Den 15.07.2015 04:14, skrev Greg KH: On Tue, Jun 30, 2015 at 08:43:13AM +0200, Fabio Falzoi wrote: Use a helper function to choose which set_addr_win implementation to use, based on the value of the setaddrwin module parameter. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c

Re: [PATCH 03/10] Staging: fbtft: Use a struct to describe each LCD controller

2015-07-23 Thread Noralf Trønnes
ight = 160, + .init_seq = st7735r_init, + .init_seq_sz = ARRAY_SIZE(st7735r_init), + }, + { Can this be put on one line? }, { With the struct moved: Acked-by: Noralf Trønnes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller

2015-07-23 Thread Noralf Trønnes
Den 15.07.2015 11:36, skrev Paul Bolle: On di, 2015-07-14 at 14:59 +0200, Henri Chain wrote: --- /dev/null +++ b/drivers/staging/fbtft/fb_uc1611.c +#define DRVNAMEfb_uc1611 +MODULE_ALIAS(spi: DRVNAME); +MODULE_ALIAS(platform: DRVNAME); +MODULE_ALIAS(spi:uc1611);

Re: [PATCH 06/10] Staging: fbtft: Use a helper function to set set_addr_win op

2015-07-23 Thread Noralf Trønnes
Den 15.07.2015 04:14, skrev Greg KH: On Tue, Jun 30, 2015 at 08:43:13AM +0200, Fabio Falzoi wrote: Use a helper function to choose which set_addr_win implementation to use, based on the value of the setaddrwin module parameter. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com ---

Re: [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller

2015-07-23 Thread Noralf Trønnes
Den 14.07.2015 14:59, skrev Henri Chain: This is a driver chip for 240x160 4-bit greyscale LCDs. It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been tested. (It also has a 6800 or 8080-style parallel interface, but I have not included support for it.) Signed-off-by: Henri

Re: [PATCH 03/10] Staging: fbtft: Use a struct to describe each LCD controller

2015-07-23 Thread Noralf Trønnes
, + .height = 160, + .init_seq = st7735r_init, + .init_seq_sz = ARRAY_SIZE(st7735r_init), + }, + { Can this be put on one line? }, { With the struct moved: Acked-by: Noralf Trønnes nor...@tronnes.org -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-22 Thread Noralf Trønnes
Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-22 Thread Noralf Trønnes
Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-14 Thread Noralf Trønnes
Den 14.07.2015 06:50, skrev Stephen Warren: On 07/11/2015 09:26 AM, Noralf Trønnes wrote: Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-14 Thread Noralf Trønnes
Den 14.07.2015 06:50, skrev Stephen Warren: On 07/11/2015 09:26 AM, Noralf Trønnes wrote: Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-11 Thread Noralf Trønnes
Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-07-11 Thread Noralf Trønnes
Den 11.07.2015 06:09, skrev Stephen Warren: (Sorry for the slow reply; I was on vacation) On 06/18/2015 07:32 AM, Noralf Trønnes wrote: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-06-18 Thread Noralf Trønnes
Den 18.06.2015 15:32, skrev Noralf Trønnes: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-06-18 Thread Noralf Trønnes
Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-06-18 Thread Noralf Trønnes
Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. This basically looks OK, but a few

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-06-18 Thread Noralf Trønnes
Den 18.06.2015 15:32, skrev Noralf Trønnes: Den 18.06.2015 04:26, skrev Stephen Warren: On 06/12/2015 11:26 AM, Noralf Trønnes wrote: Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller

[PATCH v3] watchdog: bcm2835: Fix poweroff behaviour

2015-06-17 Thread Noralf Trønnes
this change in 19 Aug 2013 and was matched by the downstream commit: Changes for new NOOBS multi partition booting from gsh Signed-off-by: Noralf Trønnes --- v2: Fix typo in commit message v3: Only Raspberry Pi is supported so it's ok to just modify the poweroff function (Stephen Warrren) drivers

Re: [PATCH v2 2/3] watchdog: bcm2835: Add poweroff code for the Raspberry Pi

2015-06-17 Thread Noralf Trønnes
Den 17.06.2015 03:28, skrev Stephen Warren: On 06/16/2015 03:39 AM, Noralf Trønnes wrote: Den 16.06.2015 05:07, skrev Stephen Warren: On 06/13/2015 05:39 AM, Noralf Trønnes wrote: This adds a new poweroff function to the watchdog driver for the Raspberry Pi. Currently poweroff/halt results

Re: [PATCH v2 2/3] watchdog: bcm2835: Add poweroff code for the Raspberry Pi

2015-06-17 Thread Noralf Trønnes
Den 17.06.2015 03:28, skrev Stephen Warren: On 06/16/2015 03:39 AM, Noralf Trønnes wrote: Den 16.06.2015 05:07, skrev Stephen Warren: On 06/13/2015 05:39 AM, Noralf Trønnes wrote: This adds a new poweroff function to the watchdog driver for the Raspberry Pi. Currently poweroff/halt results

[PATCH v3] watchdog: bcm2835: Fix poweroff behaviour

2015-06-17 Thread Noralf Trønnes
this change in 19 Aug 2013 and was matched by the downstream commit: Changes for new NOOBS multi partition booting from gsh Signed-off-by: Noralf Trønnes nor...@tronnes.org --- v2: Fix typo in commit message v3: Only Raspberry Pi is supported so it's ok to just modify the poweroff function (Stephen

Re: [PATCH v2 2/3] watchdog: bcm2835: Add poweroff code for the Raspberry Pi

2015-06-16 Thread Noralf Trønnes
Den 16.06.2015 05:07, skrev Stephen Warren: On 06/13/2015 05:39 AM, Noralf Trønnes wrote: This adds a new poweroff function to the watchdog driver for the Raspberry Pi. Currently poweroff/halt results in a reboot. The Raspberry Pi firmware uses the RSTS register to know which partiton to boot

Re: [PATCH v2 2/3] watchdog: bcm2835: Add poweroff code for the Raspberry Pi

2015-06-16 Thread Noralf Trønnes
Den 16.06.2015 05:07, skrev Stephen Warren: On 06/13/2015 05:39 AM, Noralf Trønnes wrote: This adds a new poweroff function to the watchdog driver for the Raspberry Pi. Currently poweroff/halt results in a reboot. The Raspberry Pi firmware uses the RSTS register to know which partiton to boot

[PATCH v2 2/3] watchdog: bcm2835: Add poweroff code for the Raspberry Pi

2015-06-13 Thread Noralf Trønnes
partition used by the firmware to indicate halt. The firmware made this change in 19 Aug 2013 and was matched by the downstream commit: Changes for new NOOBS multi partition booting from gsh Signed-off-by: Noralf Trønnes Acked-by: Guenter Roeck --- drivers/watchdog/bcm2835_wdt.c | 38

[PATCH v2 1/3] dt-bindings: Add Raspberry Pi compatible string for watchdog

2015-06-13 Thread Noralf Trønnes
The Raspberry Pi has changed how its firmware detects a poweroff and needs special handling for this. Signed-off-by: Noralf Trønnes --- v2: Fix typo in commit message Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH v2 3/3] ARM: dts: bcm2835-rpi: Add "brcm,raspberrypi-pm-wdt" to wdt compatible

2015-06-13 Thread Noralf Trønnes
The Raspberry Pi uses a new value for halt in the PM_RSTS watchdog register. Expand the compatible string to cover this. Signed-off-by: Noralf Trønnes --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 arch/arm/boot/dts/bcm2835.dtsi | 2 +- 2 files changed, 5 insertions(+), 1 deletion

[PATCH v2 3/3] ARM: dts: bcm2835-rpi: Add brcm,raspberrypi-pm-wdt to wdt compatible

2015-06-13 Thread Noralf Trønnes
The Raspberry Pi uses a new value for halt in the PM_RSTS watchdog register. Expand the compatible string to cover this. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 arch/arm/boot/dts/bcm2835.dtsi | 2 +- 2 files changed, 5 insertions

[PATCH v2 2/3] watchdog: bcm2835: Add poweroff code for the Raspberry Pi

2015-06-13 Thread Noralf Trønnes
partition used by the firmware to indicate halt. The firmware made this change in 19 Aug 2013 and was matched by the downstream commit: Changes for new NOOBS multi partition booting from gsh Signed-off-by: Noralf Trønnes nor...@tronnes.org Acked-by: Guenter Roeck li...@roeck-us.net --- drivers

[PATCH v2 1/3] dt-bindings: Add Raspberry Pi compatible string for watchdog

2015-06-13 Thread Noralf Trønnes
The Raspberry Pi has changed how its firmware detects a poweroff and needs special handling for this. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- v2: Fix typo in commit message Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt | 3 ++- 1 file changed, 2 insertions

[PATCH] irqchip: bcm2835: Add FIQ support

2015-06-12 Thread Noralf Trønnes
Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. Signed-off-by: Noralf Trønnes --- arch/arm/mach-bcm/Kconfig | 1 + drivers/irqchip/irq-bcm2835.c | 53

[PATCH] irqchip: bcm2835: Add FIQ support

2015-06-12 Thread Noralf Trønnes
Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- arch/arm/mach-bcm/Kconfig | 1 + drivers/irqchip/irq-bcm2835.c | 53

[PATCH 2/3] watchdog: bcm2835: Add poweroff code for the Raspberry Pi

2015-06-09 Thread Noralf Trønnes
partition used by the firmware to indicate halt. The firmware made this change in 19 Aug 2013 and was matched by the downstream commit: Changes for new NOOBS multi partition booting from gsh Signed-off-by: Noralf Trønnes --- drivers/watchdog/bcm2835_wdt.c | 38

[PATCH 3/3] ARM: dts: bcm2835-rpi: Add "brcm,raspberrypi-pm-wdt" to wdt compatible

2015-06-09 Thread Noralf Trønnes
The Raspberry Pi uses a new value for halt in the PM_RSTS watchdog register. Expand the compatible string to cover this. Signed-off-by: Noralf Trønnes --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 arch/arm/boot/dts/bcm2835.dtsi | 2 +- 2 files changed, 5 insertions(+), 1 deletion

[PATCH 1/3] dt-bindings: Add Raspberry Pi compatible string for watchdog

2015-06-09 Thread Noralf Trønnes
The Raspberry Pi has changed how it's firmware detects a poweroff and needs special handling for this. Signed-off-by: Noralf Trønnes --- Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation

[PATCH 3/3] ARM: dts: bcm2835-rpi: Add brcm,raspberrypi-pm-wdt to wdt compatible

2015-06-09 Thread Noralf Trønnes
The Raspberry Pi uses a new value for halt in the PM_RSTS watchdog register. Expand the compatible string to cover this. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 arch/arm/boot/dts/bcm2835.dtsi | 2 +- 2 files changed, 5 insertions

[PATCH 1/3] dt-bindings: Add Raspberry Pi compatible string for watchdog

2015-06-09 Thread Noralf Trønnes
The Raspberry Pi has changed how it's firmware detects a poweroff and needs special handling for this. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 2/3] watchdog: bcm2835: Add poweroff code for the Raspberry Pi

2015-06-09 Thread Noralf Trønnes
partition used by the firmware to indicate halt. The firmware made this change in 19 Aug 2013 and was matched by the downstream commit: Changes for new NOOBS multi partition booting from gsh Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/watchdog/bcm2835_wdt.c | 38

Re: [PATCH v5 2/3] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-28 Thread Noralf Trønnes
Den 29.05.2015 02:07, skrev Eric Anholt: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. ... +/** + * rpi_firmware_property_list - Submit firmware property list + * @of_node: Pointer

Re: [PATCH 2/3 v4] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-28 Thread Noralf Trønnes
Den 29.05.2015 00:38, skrev Eric Anholt: Noralf Trønnes writes: Den 28.05.2015 20:33, skrev Eric Anholt: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. Signed-off-by: Eric Anholt

Re: [PATCH 2/3 v2] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-28 Thread Noralf Trønnes
Den 28.05.2015 23:17, skrev Stephen Warren: On 05/13/2015 01:00 PM, Eric Anholt wrote: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. ... Note that I don't think I've done what

Re: [PATCH 2/3 v4] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-28 Thread Noralf Trønnes
Den 28.05.2015 20:33, skrev Eric Anholt: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. Signed-off-by: Eric Anholt ... +static int rpi_firmware_probe(struct platform_device *pdev)

Re: [PATCH 2/3 v4] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-28 Thread Noralf Trønnes
Den 28.05.2015 23:28, skrev Stephen Warren: On 05/28/2015 12:33 PM, Eric Anholt wrote: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. ... +int rpi_firmware_property_list(struct

Re: [PATCH 2/3 v2] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-28 Thread Noralf Trønnes
Den 28.05.2015 23:17, skrev Stephen Warren: On 05/13/2015 01:00 PM, Eric Anholt wrote: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. ... Note that I don't think I've done what

Re: [PATCH 2/3 v4] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-28 Thread Noralf Trønnes
Den 29.05.2015 00:38, skrev Eric Anholt: Noralf Trønnes nor...@tronnes.org writes: Den 28.05.2015 20:33, skrev Eric Anholt: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. Signed

Re: [PATCH 2/3 v4] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-28 Thread Noralf Trønnes
Den 28.05.2015 23:28, skrev Stephen Warren: On 05/28/2015 12:33 PM, Eric Anholt wrote: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. ... +int rpi_firmware_property_list(struct

Re: [PATCH 2/3 v4] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-28 Thread Noralf Trønnes
Den 28.05.2015 20:33, skrev Eric Anholt: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. Signed-off-by: Eric Anholt e...@anholt.net ... +static int rpi_firmware_probe(struct

Re: [PATCH v5 2/3] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-28 Thread Noralf Trønnes
Den 29.05.2015 02:07, skrev Eric Anholt: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. ... +/** + * rpi_firmware_property_list - Submit firmware property list + * @of_node: Pointer

Re: [PATCH 2/3 v2] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-17 Thread Noralf Trønnes
Den 13.05.2015 21:00, skrev Eric Anholt: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. Signed-off-by: Eric Anholt --- [...] +/* + * Submits a single tag to the VPU firmware

Re: [PATCH 2/3 v2] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-17 Thread Noralf Trønnes
Den 13.05.2015 21:00, skrev Eric Anholt: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. Signed-off-by: Eric Anholt --- v2: Drop power-domains stuff for now since we don't have the

Re: [PATCH 1/3 v2] dt/bindings: Add binding for the Raspberry Pi firmware driver

2015-05-17 Thread Noralf Trønnes
Den 13.05.2015 21:00, skrev Eric Anholt: This driver will provide support for calls into the firmware that will be used by other drivers like cpufreq and vc4. Signed-off-by: Eric Anholt --- v2: Improve commit message, point to mailbox.txt for how mboxes work.

Re: [PATCH 1/3 v2] dt/bindings: Add binding for the Raspberry Pi firmware driver

2015-05-17 Thread Noralf Trønnes
Den 13.05.2015 21:00, skrev Eric Anholt: This driver will provide support for calls into the firmware that will be used by other drivers like cpufreq and vc4. Signed-off-by: Eric Anholt e...@anholt.net --- v2: Improve commit message, point to mailbox.txt for how mboxes work.

Re: [PATCH 2/3 v2] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-17 Thread Noralf Trønnes
Den 13.05.2015 21:00, skrev Eric Anholt: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. Signed-off-by: Eric Anholt e...@anholt.net --- v2: Drop power-domains stuff for now since we

Re: [PATCH 2/3 v2] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-17 Thread Noralf Trønnes
Den 13.05.2015 21:00, skrev Eric Anholt: This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. Signed-off-by: Eric Anholt e...@anholt.net --- [...] +/* + * Submits a single tag to the VPU

Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-12 Thread Noralf Trønnes
Hi, Den 18.04.2015 13:06, skrev Noralf Trønnes: Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry Pi repo. The work was done by Gellert Weisz. Tested using the bcm2835-mmc driver from the same repo. Signed-off

Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support

2015-05-12 Thread Noralf Trønnes
Den 05.05.2015 22:27, skrev Eric Anholt: From: Lubomir Rintel This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2 (despite being

Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support

2015-05-12 Thread Noralf Trønnes
Den 05.05.2015 22:27, skrev Eric Anholt: From: Lubomir Rintel lkund...@v3.sk This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2

Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-12 Thread Noralf Trønnes
Hi, Den 18.04.2015 13:06, skrev Noralf Trønnes: Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry Pi repo. The work was done by Gellert Weisz. Tested using the bcm2835-mmc driver from the same repo. Signed-off

Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support

2015-05-08 Thread Noralf Trønnes
Den 08.05.2015 10:33, skrev Alexander Stein: On Thursday 07 May 2015, 12:54:20 wrote Eric Anholt: Noralf Trønnes writes: Den 05.05.2015 22:27, skrev Eric Anholt: From: Lubomir Rintel This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit

Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support

2015-05-08 Thread Noralf Trønnes
Den 08.05.2015 10:33, skrev Alexander Stein: On Thursday 07 May 2015, 12:54:20 wrote Eric Anholt: Noralf Trønnes nor...@tronnes.org writes: Den 05.05.2015 22:27, skrev Eric Anholt: From: Lubomir Rintel lkund...@v3.sk This mailbox driver provides a single mailbox channel to write 32-bit

Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support

2015-05-07 Thread Noralf Trønnes
Den 05.05.2015 22:27, skrev Eric Anholt: From: Lubomir Rintel This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2 (despite being

Re: [PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support

2015-05-07 Thread Noralf Trønnes
Den 05.05.2015 22:27, skrev Eric Anholt: From: Lubomir Rintel lkund...@v3.sk This mailbox driver provides a single mailbox channel to write 32-bit values to the VPU and get a 32-bit response. The Raspberry Pi firmware uses this mailbox channel to implement firmware calls, while Roku 2

Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-06 Thread Noralf Trønnes
Den 01.05.2015 23:07, skrev Martin Sperl: Tests with the initial (and incomplete) version of the spi-bcm2835 driver with DMA transfer support show that the dma-engine works as expected with this patch. There is one one observation: On 18.04.2015, at 13:06, Noralf Trønnes wrote: +static

Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-06 Thread Noralf Trønnes
Den 01.05.2015 23:07, skrev Martin Sperl: Tests with the initial (and incomplete) version of the spi-bcm2835 driver with DMA transfer support show that the dma-engine works as expected with this patch. There is one one observation: On 18.04.2015, at 13:06, Noralf Trønnes nor...@tronnes.org

Re: [PATCH] ARM: bcm2835: Use 0x4 prefix for DMA bus addresses to SDRAM.

2015-05-05 Thread Noralf Trønnes
Den 05.05.2015 02:07, skrev Eric Anholt: Noralf Trønnes writes: Den 04.05.2015 21:33, skrev Eric Anholt: There exists a tiny MMU, configurable only by the VC (running the closed firmware), which maps from the ARM's physical addresses to bus addresses. These bus addresses determine

Re: [PATCH] ARM: bcm2835: Use 0x4 prefix for DMA bus addresses to SDRAM.

2015-05-05 Thread Noralf Trønnes
Den 05.05.2015 02:07, skrev Eric Anholt: Noralf Trønnes nor...@tronnes.org writes: Den 04.05.2015 21:33, skrev Eric Anholt: There exists a tiny MMU, configurable only by the VC (running the closed firmware), which maps from the ARM's physical addresses to bus addresses. These bus addresses

Re: [PATCH] ARM: bcm2835: Use 0x4 prefix for DMA bus addresses to SDRAM.

2015-05-04 Thread Noralf Trønnes
s was wrong. What I don't understand, is that mmc and spi works fine with a "wrong" bus address. It's only the framebuffer driver and the vchiq driver when using mailbox that fails. Tested-by: Noralf Trønnes Regards, Noralf Trønnes -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH] ARM: bcm2835: Use 0x4 prefix for DMA bus addresses to SDRAM.

2015-05-04 Thread Noralf Trønnes
, is that mmc and spi works fine with a wrong bus address. It's only the framebuffer driver and the vchiq driver when using mailbox that fails. Tested-by: Noralf Trønnes nor...@tronnes.org Regards, Noralf Trønnes -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-04-18 Thread Noralf Trønnes
Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry Pi repo. The work was done by Gellert Weisz. Tested using the bcm2835-mmc driver from the same repo. Signed-off-by: Noralf Trønnes --- Gellert Weisz has ended his

[PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-04-18 Thread Noralf Trønnes
Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry Pi repo. The work was done by Gellert Weisz. Tested using the bcm2835-mmc driver from the same repo. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- Gellert

Re: [PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-17 Thread Noralf Trønnes
Hi Stefan, Den 17.04.2015 19:08, skrev Stefan Wahren: Hi Noralf, Am 17.04.2015 um 00:09 schrieb Noralf Trønnes: Den 15.04.2015 21:00, skrev Stefan Wahren: Hi Noralf, Am 15.04.2015 um 11:56 schrieb Noralf Trønnes: Add slave transfer capability to BCM2835 dmaengine driver. This patch

Re: [PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-17 Thread Noralf Trønnes
Hi Stefan, Den 17.04.2015 19:08, skrev Stefan Wahren: Hi Noralf, Am 17.04.2015 um 00:09 schrieb Noralf Trønnes: Den 15.04.2015 21:00, skrev Stefan Wahren: Hi Noralf, Am 15.04.2015 um 11:56 schrieb Noralf Trønnes: Add slave transfer capability to BCM2835 dmaengine driver. This patch

Re: [PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-16 Thread Noralf Trønnes
Den 15.04.2015 21:00, skrev Stefan Wahren: Hi Noralf, Am 15.04.2015 um 11:56 schrieb Noralf Trønnes: Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry Pi repo. The work was done by Gellert Weisz. Tested

Re: [PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-16 Thread Noralf Trønnes
Den 16.04.2015 21:06, skrev Alexander Stein: Hi Stefan, On Wednesday 15 April 2015, 21:00:26 wrote Stefan Wahren: Am 15.04.2015 um 11:56 schrieb Noralf Trønnes: Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry

Re: [PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-16 Thread Noralf Trønnes
Den 16.04.2015 08:30, skrev Rogier Wolff: On Wed, Apr 15, 2015 at 08:53:07PM +0200, Noralf Trønnes wrote: A 16-bit register can't hold a value of 65536. Either the max value is 65535 or the register is 17-bits wide. It is common for hardware registers to have the value "0" mean 655

Re: [PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-16 Thread Noralf Trønnes
Den 16.04.2015 08:30, skrev Rogier Wolff: On Wed, Apr 15, 2015 at 08:53:07PM +0200, Noralf Trønnes wrote: A 16-bit register can't hold a value of 65536. Either the max value is 65535 or the register is 17-bits wide. It is common for hardware registers to have the value 0 mean 65536 in case

Re: [PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-16 Thread Noralf Trønnes
Den 16.04.2015 21:06, skrev Alexander Stein: Hi Stefan, On Wednesday 15 April 2015, 21:00:26 wrote Stefan Wahren: Am 15.04.2015 um 11:56 schrieb Noralf Trønnes: Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry

Re: [PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-16 Thread Noralf Trønnes
Den 15.04.2015 21:00, skrev Stefan Wahren: Hi Noralf, Am 15.04.2015 um 11:56 schrieb Noralf Trønnes: Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry Pi repo. The work was done by Gellert Weisz. Tested

Re: [PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-15 Thread Noralf Trønnes
Den 15.04.2015 16:37, skrev Martin Sperl: On 15.04.2015, at 11:56, Noralf Trønnes wrote: +#define MAX_LITE_TRANSFER (SZ_64K - 1) +#define MAX_NORMAL_TRANSFERSZ_1G ... + if (c->ch >= 8) /* LITE channel */ + max_size = MAX_LITE_TRANSFER; +

[PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-15 Thread Noralf Trønnes
Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry Pi repo. The work was done by Gellert Weisz. Tested with the bcm2835-mmc driver from the same repo. Signed-off-by: Noralf Trønnes --- Gellert Weisz has ended his

Re: [PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-15 Thread Noralf Trønnes
Den 15.04.2015 16:37, skrev Martin Sperl: On 15.04.2015, at 11:56, Noralf Trønnes nor...@tronnes.org wrote: +#define MAX_LITE_TRANSFER (SZ_64K - 1) +#define MAX_NORMAL_TRANSFERSZ_1G ... + if (c-ch = 8) /* LITE channel */ + max_size = MAX_LITE_TRANSFER

[PATCH] dmaengine: bcm2835: Add slave dma support

2015-04-15 Thread Noralf Trønnes
Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry Pi repo. The work was done by Gellert Weisz. Tested with the bcm2835-mmc driver from the same repo. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- Gellert

Re: [PATCH] Staging: fbtft: move externs to header file

2015-03-03 Thread Noralf Trønnes
Den 03.03.2015 11:19, skrev Drew Fustini: Move extern declartions from fbtft-core.c to fbtft header file. This resovles the warning from checkpatch.pl that "externs should be avoided in .c files". Signed-off-by: Drew Fustini --- drivers/staging/fbtft/fbtft-core.c | 5 -

Re: [PATCH] Staging: fbtft: move externs to header file

2015-03-03 Thread Noralf Trønnes
Den 03.03.2015 11:19, skrev Drew Fustini: Move extern declartions from fbtft-core.c to fbtft header file. This resovles the warning from checkpatch.pl that externs should be avoided in .c files. Signed-off-by: Drew Fustini pdp7p...@gmail.com --- drivers/staging/fbtft/fbtft-core.c | 5 -

Re: [PATCH] Staging: fbtft: fix space errors

2015-03-02 Thread Noralf Trønnes
Den 02.03.2015 20:21, skrev Andrey Skvortsov: On 02 Mar, Joe Perches wrote: On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote: On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote: If you're really going to change these, please remove the unnecessary \ line continuations indent

Re: [PATCH] Staging: fbtft: fix space errors

2015-03-02 Thread Noralf Trønnes
Den 02.03.2015 20:21, skrev Andrey Skvortsov: On 02 Mar, Joe Perches wrote: On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote: On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote: If you're really going to change these, please remove the unnecessary \ line continuations indent

<    3   4   5   6   7   8   9   >