[PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight dependency

2017-02-23 Thread Noralf Trønnes
BACKLIGHT_CLASS_DEVICE was selected in the last version of the tinydrm patchset to fix the backlight dependency, but the ifdef CONFIG_BACKLIGHT_CLASS_DEVICE was forgotten. Fix that. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- include/drm/tinydrm/tinydrm-helpers.

[PATCH 2/3] drm/tinydrm: mipi-dbi: Fix field width specifier warning

2017-02-23 Thread Noralf Trønnes
OMMAND(). There is no chance of overflow. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c index 2caecde..2d2

[PATCH 0/3] drm/tinydrm: Fix compiler warnings

2017-02-23 Thread Noralf Trønnes
T_DRIVER, fmt, ##__VA_ARGS__) ^~~ >> drivers/gpu/drm/tinydrm/mipi-dbi.c:671:2: note: in expansion of macro >> 'MIPI_DBI_DEBUG_COMMAND' MIPI_DBI_DEBUG_COMMAND(cmd, parameters, num); ^~~~~~ Noralf. Noralf Trønnes (3): drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used un

[PATCH 1/3] drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used uninitialized

2017-02-23 Thread Noralf Trønnes
); ^~ cmd can't be used uninitialized, but to satisfy the compiler, initialize it to zero. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

[PATCH v4 0/7] drm: Add support for tiny LCD displays

2017-02-11 Thread Noralf Trønnes
rm module to the driver using a helper macro: TINYDRM_DRM_DRIVER. - Remove dirtyfb() async code. - Added support for partial display updates. Noralf Trønnes (7): drm: Add DRM support for tiny LCD displays drm/tinydrm: Add helper functions drm/tinydrm: Add MIPI DBI support of: Add vendor prefix for M

[PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property

2017-02-11 Thread Noralf Trønnes
Display panels can be oriented many ways, especially in the embedded world. The rotation property is a way to describe this orientation. The counter clockwise direction is chosen because that's what fbdev and drm use. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Thierry

[PATCH v4 2/7] drm/tinydrm: Add helper functions

2017-02-11 Thread Noralf Trønnes
Add common functionality needed by many tinydrm drivers. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> Acked-by: Thierry Reding <tred...@nvidia.com> --- Changes since version 3: - Fix backlight dependency by selecting it -

[PATCH v4 4/7] of: Add vendor prefix for Multi-Inno

2017-02-11 Thread Noralf Trønnes
Multi-Inno Technology Co.,Ltd is a Hong Kong based company offering LCD, LCD module products and complete panel solutions. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 fil

[PATCH v4 1/7] drm: Add DRM support for tiny LCD displays

2017-02-11 Thread Noralf Trønnes
tinydrm provides helpers for very simple displays that can use CMA backed framebuffers and need flushing on changes. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> Acked-by: Thierry Reding <tred...@nvidia.com> --- Chang

[PATCH v4 7/7] drm/tinydrm: Add support for Multi-Inno MI0283QT display

2017-02-11 Thread Noralf Trønnes
Add driver to support the Multi-Inno MI0283QT display panel. It has an ILI9341 MIPI DBI compatible display controller. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Thierry Reding <tred...@nvidia.com> --- MAINTAINERS| 6 + drivers/gpu/drm/tin

[PATCH v4 6/7] dt-bindings: Add Multi-Inno MI0283QT binding

2017-02-11 Thread Noralf Trønnes
Add device-tree binding documentation for the MI0283QT display panel. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/display/multi-inno,mi0283qt.txt | 27 ++ 1 file changed, 27 insertions(+)

[PATCH v4 3/7] drm/tinydrm: Add MIPI DBI support

2017-02-11 Thread Noralf Trønnes
Add support for MIPI DBI compatible controllers. Interface type C option 1 and 3 are supported (SPI). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Thierry Reding <tred...@nvidia.com> --- Changes since version 3: - Use #if IS_ENABLED(CONFIG_SPI) instead of #ifd

Re: [PATCH v4 1/7] drm: Add DRM support for tiny LCD displays

2017-02-12 Thread Noralf Trønnes
Den 12.02.2017 12.05, skrev Andy Shevchenko: On Sat, Feb 11, 2017 at 8:48 PM, Noralf Trønnes <nor...@tronnes.org> wrote: tinydrm provides helpers for very simple displays that can use CMA backed framebuffers and need flushing on changes. +/** + * tinydrm_gem_cma_free_object - Free res

Re: [PATCH v4 2/7] drm/tinydrm: Add helper functions

2017-02-12 Thread Noralf Trønnes
Den 12.02.2017 12.50, skrev Andy Shevchenko: On Sat, Feb 11, 2017 at 8:48 PM, Noralf Trønnes <nor...@tronnes.org> wrote: Add common functionality needed by many tinydrm drivers. +int tinydrm_enable_backlight(struct backlight_device *backlight) +{ + unsigned int old_state; + i

Re: [PATCH v3 2/3] drm: simpledrm: add fbdev fallback support

2016-08-16 Thread Noralf Trønnes
Den 15.08.2016 08:48, skrev Daniel Vetter: On Sun, Aug 14, 2016 at 06:52:05PM +0200, Noralf Trønnes wrote: Create a simple fbdev device during SimpleDRM setup so legacy user-space and fbcon can use it. Original work by David Herrmann. Cc: dh.herrm...@gmail.com Signed-off-by: Noralf Trønnes

Re: [PATCH v3 1/3] drm: add SimpleDRM driver

2016-08-16 Thread Noralf Trønnes
Den 15.08.2016 08:59, skrev Daniel Vetter: On Sun, Aug 14, 2016 at 06:52:04PM +0200, Noralf Trønnes wrote: The SimpleDRM driver binds to simple-framebuffer devices and provides a DRM/KMS API. It provides only a single CRTC+encoder+connector combination plus one initial mode. Userspace can

Re: [PATCH 0/2] drm: add SimpleDRM driver

2016-08-04 Thread Noralf Trønnes
Den 04.08.2016 16:15, skrev Luc Verhaegen: On Thu, Aug 04, 2016 at 04:03:18PM +0200, Noralf Trønnes wrote: I have tested simpledrm on a Raspberry Pi B+ with U-boot setting up the framebuffer and producing this node: framebuffer@1e887000 { compatible = "s

Re: [PATCH 1/2] drm: add SimpleDRM driver

2016-08-04 Thread Noralf Trønnes
Den 04.08.2016 16:03, skrev Noralf Trønnes: The SimpleDRM driver binds to simple-framebuffer devices and provides a DRM/KMS API. It provides only a single CRTC+encoder+connector combination plus one initial mode. Userspace can create dumb-buffers which can be blit into the real framebuffer

[PATCH v2 2/3] drm: simpledrm: add fbdev fallback support

2016-08-05 Thread Noralf Trønnes
Create a simple fbdev device during SimpleDRM setup so legacy user-space and fbcon can use it. Original work by David Herrmann. Cc: dh.herrm...@gmail.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes from version 1: No changes Changes from previous version: -

[PATCH v2 1/3] drm: add SimpleDRM driver

2016-08-05 Thread Noralf Trønnes
simplefb.c. Cc: dh.herrm...@gmail.com Cc: l...@skynet.be Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes from version 1: - Move platform_set_drvdata() before drm_dev_register() - Remove drm_legacy_mmap() call. - Set mode_config.{min,max}_{width,height} to the actual dime

[PATCH v2 3/3] drm: simpledrm: honour remove_conflicting_framebuffers()

2016-08-05 Thread Noralf Trønnes
There is currently no non-fbdev mechanism in place to kick out simpledrm when the real hw-driver is probed. As a stop gap until that is in place, honour remove_conflicting_framebuffers() and delete the simple-framebuffer platform device when it's called. Signed-off-by: Noralf Trønnes <

[PATCH v2 0/3] drm: add SimpleDRM driver

2016-08-05 Thread Noralf Trønnes
s (sysfb) https://lists.freedesktop.org/archives/dri-devel/2013-February/035013.html Noralf Trønnes (3): drm: add SimpleDRM driver drm: simpledrm: add fbdev fallback support drm: simpledrm: honour remove_conflicting_framebuffers() drivers/gpu/drm/Kconfig | 2 + driver

[PATCH v4 2/5] drm/fb-helper: Add drm_fb_helper_set_suspend_lock()

2016-08-22 Thread Noralf Trønnes
driver. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_fb_helper.c | 57 + include/drm/drm_fb_helper.h | 9 +++ 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_he

[PATCH v4 0/5] drm: add SimpleDRM driver

2016-08-22 Thread Noralf Trønnes
edesktop.org/archives/dri-devel/2014-January/052584.html [2] https://lists.freedesktop.org/archives/dri-devel/2014-January/052594.html Noralf Trønnes (5): of: Add EXPORT_SYMBOL for of_chosen drm/fb-helper: Add drm_fb_helper_set_suspend_lock() drm: add SimpleDRM driver d

[PATCH v4 1/5] of: Add EXPORT_SYMBOL for of_chosen

2016-08-22 Thread Noralf Trønnes
Export of_chosen so drivers built as modules can get access to it. The simpledrm driver will use this and is compatible with simple-framebuffer which is a subnode of /chosen. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/of/base.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v4 3/5] drm: add SimpleDRM driver

2016-08-22 Thread Noralf Trønnes
simplefb.c. Cc: dh.herrm...@gmail.com Cc: l...@skynet.be Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes from version 3: - Reworked gem code to match udl - Dropped PRIME support - Dropped dirty_info_property, it's gone - Don't use drm_device.platformdev it's deprecated - Remove

[PATCH v4 4/5] drm: simpledrm: add fbdev fallback support

2016-08-22 Thread Noralf Trønnes
Create a simple fbdev device during SimpleDRM setup so legacy user-space and fbcon can use it. Original work by David Herrmann. Cc: dh.herrm...@gmail.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes from version 3: - Remove #ifdef CONFIG_DRM_FBDEV_EMULATION

[PATCH v4 5/5] drm: simpledrm: honour remove_conflicting_framebuffers()

2016-08-22 Thread Noralf Trønnes
There is currently no non-fbdev mechanism in place to kick out simpledrm when the real hw-driver is probed. As a stop gap until that is in place, honour remove_conflicting_framebuffers() and delete the simple-framebuffer platform device when it's called. Signed-off-by: Noralf Trønnes <

Re: [PATCH v2 4/6] staging: fbtft: Fix sparse warnings of incorrect type in assignment

2017-03-02 Thread Noralf Trønnes
Den 02.03.2017 14.04, skrev simran singhal: This patch fixes the following sparse warnings: drivers/staging/fbtft/fbtft-bus.c:166:36: warning: incorrect type in assignment (different base types) drivers/staging/fbtft/fbtft-bus.c:166:36:expected unsigned short [unsigned] [short]

Re: [PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight dependency

2017-02-26 Thread Noralf Trønnes
Den 23.02.2017 14.29, skrev Noralf Trønnes: BACKLIGHT_CLASS_DEVICE was selected in the last version of the tinydrm patchset to fix the backlight dependency, but the ifdef CONFIG_BACKLIGHT_CLASS_DEVICE was forgotten. Fix that. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> ---

[PATCH v3 3/7] i2c: bcm2835: Use dev_dbg logging on transfer errors

2016-09-28 Thread Noralf Trønnes
dev_err() on transfer error, so switch to dev_dbg() instead. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes: - use dev_dbg instead of dev_err_ratelimited drivers/i2c/busses/i2c-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/buss

[PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-09-28 Thread Noralf Trønnes
be cleared that way. Add the status value to the error value in case of TXW/RXR errors to distinguish them from the other S_LEN error. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 31 ++- 1 file changed, 22 insertions

[PATCH v3 1/7] i2c: bcm2835: Fix hang for writing messages larger than 16 bytes

2016-09-28 Thread Noralf Trønnes
when the FIFO contains at least one byte of data. TXW: is set during a write transfer and the FIFO is less than full. RXR: is set during a read transfer and the FIFO is or more full. Implementing the logic from the downstream i2c-bcm2708 driver solved the hang problem. Signed-off-by: Noralf

[PATCH v3 0/7] i2c: bcm2835: Bring in changes from downstream

2016-09-28 Thread Noralf Trønnes
for transfer errors - drop i2c2 disabling patch, vc4 uses it. Noralf. Noralf Trønnes (7): i2c: bcm2835: Fix hang for writing messages larger than 16 bytes i2c: bcm2835: Protect against unexpected TXW/RXR interrupts i2c: bcm2835: Use dev_dbg logging on transfer errors i2c: bcm2835: Can't

[PATCH v3 7/7] i2c: bcm2835: Add support for dynamic clock

2016-09-28 Thread Noralf Trønnes
Support a dynamic clock by reading the frequency and setting the divisor in the transfer function instead of during probe. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 51 +--- 1 file changed, 32 insertions(

[PATCH v3 4/7] i2c: bcm2835: Can't support I2C_M_IGNORE_NAK

2016-09-28 Thread Noralf Trønnes
ent. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c index 8cdb139..99857f8 100644 --- a/drivers/i2c/busses/i2c-bcm2835.c +++ b/dr

[PATCH v3 5/7] i2c: bcm2835: Add support for Repeated Start Condition

2016-09-28 Thread Noralf Trønnes
(eeprom) in parallel without problems. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 101 --- 1 file changed, 63 insertions(+), 38 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/buss

[PATCH v3 6/7] i2c: bcm2835: Support i2c-dev ioctl I2C_TIMEOUT

2016-09-28 Thread Noralf Trønnes
Use i2c_adapter->timeout for the completion timeout value. The core default is 1 second. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/dr

Re: [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-10-04 Thread Noralf Trønnes
Den 03.10.2016 21:42, skrev Eric Anholt: Noralf Trønnes <nor...@tronnes.org> writes: Den 29.09.2016 00:00, skrev Eric Anholt: Noralf Trønnes <nor...@tronnes.org> writes: If an unexpected TXW or RXR interrupt occurs (msg_buf_remaining == 0), the driver has no way to fill/dr

Re: [PATCH 2/3] i2c: bcm2835: Add support for combined write-read transfer

2016-09-21 Thread Noralf Trønnes
Den 20.09.2016 13:29, skrev ker...@martin.sperl.org: On 20.09.2016, at 12:56, Noralf Trønnes <nor...@tronnes.org> wrote: Den 20.09.2016 12:15, skrev Martin Sperl: On 20.09.2016 10:41, Noralf Trønnes wrote: Den 20.09.2016 09:19, skrev Martin Sperl: Hi Noralf! On 19.09.2016 17:26,

[PATCH 2/3] i2c: bcm2835: Add support for combined write-read transfer

2016-09-19 Thread Noralf Trønnes
to a DS1307 (rtc), MMA8451 (accel) and AT24C32 (eeprom) in parallel without problems. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 107 +++ 1 file changed, 98 insertions(+), 9 deletions(-) diff --git a/drive

[PATCH 3/3] i2c: bcm2835: Use ratelimited logging on transfer errors

2016-09-19 Thread Noralf Trønnes
of the log by using dev_err_ratelimited(). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c index b3ce565..dc0a5d5

[PATCH 1/3] i2c: bcm2835: Fix hang for writing messages larger than 16 bytes

2016-09-19 Thread Noralf Trønnes
when the FIFO contains at least one byte of data. TXW: is set during a write transfer and the FIFO is less than full. RXR: is set during a read transfer and the FIFO is or more full. Implementing the logic from the downstream i2c-bcm2708 driver solved the hang problem. Signed-off-by: Noralf

Re: [PATCH 1/3] i2c: bcm2835: Fix hang for writing messages larger than 16 bytes

2016-09-19 Thread Noralf Trønnes
Den 19.09.2016 18:51, skrev Eric Anholt: Noralf Trønnes <nor...@tronnes.org> writes: Writing messages larger than the FIFO size results in a hang, rendering the machine unusable. This is because the RXD status flag is set on the first interrupt which results in bcm2835_drain_rxfifo() st

Re: [PATCH 2/3] i2c: bcm2835: Add support for combined write-read transfer

2016-09-20 Thread Noralf Trønnes
Den 20.09.2016 09:19, skrev Martin Sperl: Hi Noralf! On 19.09.2016 17:26, Noralf Trønnes wrote: Some SMBus protocols use Repeated Start Condition to switch from write mode to read mode. Devices like MMA8451 won't work without it. When downstream implemented support for this in i2c-bcm2708

Re: [PATCH 2/3] i2c: bcm2835: Add support for combined write-read transfer

2016-09-20 Thread Noralf Trønnes
Den 20.09.2016 12:15, skrev Martin Sperl: On 20.09.2016 10:41, Noralf Trønnes wrote: Den 20.09.2016 09:19, skrev Martin Sperl: Hi Noralf! On 19.09.2016 17:26, Noralf Trønnes wrote: Some SMBus protocols use Repeated Start Condition to switch from write mode to read mode. Devices like

Re: [PATCH v4 5/5] drm: simpledrm: honour remove_conflicting_framebuffers()

2016-08-23 Thread Noralf Trønnes
Den 23.08.2016 20:01, skrev Daniel Vetter: On Tue, Aug 23, 2016 at 7:52 PM, Noralf Trønnes <nor...@tronnes.org> wrote: +static int sdrm_fbdev_event_notify(struct notifier_block *self, + unsigned long action, void *data) +{ + struct sdrm_device

Re: [PATCH v4 5/5] drm: simpledrm: honour remove_conflicting_framebuffers()

2016-08-23 Thread Noralf Trønnes
Den 23.08.2016 14:41, skrev Daniel Vetter: On Mon, Aug 22, 2016 at 10:25:25PM +0200, Noralf Trønnes wrote: There is currently no non-fbdev mechanism in place to kick out simpledrm when the real hw-driver is probed. As a stop gap until that is in place, honour remove_conflicting_framebuffers

Re: [PATCH v4 3/5] drm: add SimpleDRM driver

2016-08-25 Thread Noralf Trønnes
Den 25.08.2016 15:09, skrev Rob Herring: On Mon, Aug 22, 2016 at 3:25 PM, Noralf Trønnes <nor...@tronnes.org> wrote: The SimpleDRM driver binds to simple-framebuffer devices and provides a DRM/KMS API. It provides only a single CRTC+encoder+connector combination plus one initia

Re: [PATCH v4 3/5] drm: add SimpleDRM driver

2016-08-25 Thread Noralf Trønnes
Den 23.08.2016 08:17, skrev Daniel Vetter: On Mon, Aug 22, 2016 at 10:25:23PM +0200, Noralf Trønnes wrote: The SimpleDRM driver binds to simple-framebuffer devices and provides a DRM/KMS API. It provides only a single CRTC+encoder+connector combination plus one initial mode. Userspace can

[PATCH v2 3/8] i2c: bcm2835: Use ratelimited logging on transfer errors

2016-09-27 Thread Noralf Trønnes
of the log by using dev_err_ratelimited(). Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Eric Anholt <e...@anholt.net> --- drivers/i2c/busses/i2c-bcm2835.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2

[PATCH v2 8/8] ARM: bcm2835: Disable i2c2 in the Device Tree

2016-09-27 Thread Noralf Trønnes
hed display - use with caution. It is recommended to disable accesses by VideoCore by setting hdmi_ignore_edid=1 or hdmi_edid_file=1 in config.txt. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 1 file changed, 4 deletions(-) diff --git a

[PATCH v2 5/8] i2c: bcm2835: Add support for Repeated Start Condition

2016-09-27 Thread Noralf Trønnes
(eeprom) in parallel without problems. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 101 --- 1 file changed, 63 insertions(+), 38 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/buss

[PATCH v2 6/8] i2c: bcm2835: Support i2c-dev ioctl I2C_TIMEOUT

2016-09-27 Thread Noralf Trønnes
Use i2c_adapter->timeout for the completion timeout value. The core default is 1 second. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/dr

[PATCH v2 1/8] i2c: bcm2835: Fix hang for writing messages larger than 16 bytes

2016-09-27 Thread Noralf Trønnes
when the FIFO contains at least one byte of data. TXW: is set during a write transfer and the FIFO is less than full. RXR: is set during a read transfer and the FIFO is or more full. Implementing the logic from the downstream i2c-bcm2708 driver solved the hang problem. Signed-off-by: Noralf

[PATCH v2 0/8] i2c: bcm2835: Bring in changes from downstream

2016-09-27 Thread Noralf Trønnes
. Noralf Trønnes (8): i2c: bcm2835: Fix hang for writing messages larger than 16 bytes i2c: bcm2835: Protect against unexpected TXW/RXR interrupts i2c: bcm2835: Use ratelimited logging on transfer errors i2c: bcm2835: Can't support I2C_M_IGNORE_NAK i2c: bcm2835: Add support for Repeated

[PATCH v2 4/8] i2c: bcm2835: Can't support I2C_M_IGNORE_NAK

2016-09-27 Thread Noralf Trønnes
ent. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c index 370a322..4e08add 100644 --- a/drivers/i2c/busses/i2c-bcm2835.c +++ b/dr

[PATCH v2 2/8] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-09-27 Thread Noralf Trønnes
be cleared that way. Add the status value to the error value in case of TXW/RXR errors to distinguish them from the other S_LEN error. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 31 ++- 1 file changed, 22 insertions

[PATCH v2 7/8] i2c: bcm2835: Add support for dynamic clock

2016-09-27 Thread Noralf Trønnes
Support a dynamic clock by reading the frequency and setting the divisor in the transfer function instead of during probe. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/i2c/busses/i2c-bcm2835.c | 51 +--- 1 file changed, 32 insertions(

Re: [PATCH v3 7/7] i2c: bcm2835: Add support for dynamic clock

2016-09-28 Thread Noralf Trønnes
Den 28.09.2016 23:24, skrev Eric Anholt: Noralf Trønnes <nor...@tronnes.org> writes: Support a dynamic clock by reading the frequency and setting the divisor in the transfer function instead of during probe. Is this fixing some particular case you could note in the commit m

Re: [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-09-28 Thread Noralf Trønnes
Den 29.09.2016 00:00, skrev Eric Anholt: Noralf Trønnes <nor...@tronnes.org> writes: If an unexpected TXW or RXR interrupt occurs (msg_buf_remaining == 0), the driver has no way to fill/drain the FIFO to stop the interrupts. In this case the controller has to be disabled and the tr

Re: [PATCH v2 8/8] ARM: bcm2835: Disable i2c2 in the Device Tree

2016-09-27 Thread Noralf Trønnes
Den 27.09.2016 19:25, skrev Stefan Wahren: Noralf Trønnes <nor...@tronnes.org> hat am 27. September 2016 um 13:57 geschrieben: i2c2 is connected to the HDMI connector and is controlled by the firmware. Disable it to stay out of harms way. Until this point the commit message is okay, th

Re: [PATCH v2 3/8] i2c: bcm2835: Use ratelimited logging on transfer errors

2016-09-27 Thread Noralf Trønnes
Den 27.09.2016 15:01, skrev Martin Sperl: On 27 Sep 2016, at 13:57, Noralf Trønnes <nor...@tronnes.org> wrote: Writing to an AT24C32 generates on average 2x i2c transfer errors per 32-byte page write. Which amounts to a lot for a 4k write. This is due to the fact that the chip doesn't r

[PATCH v4 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-10-03 Thread Noralf Trønnes
be cleared that way. Add the status value to the error value in case of TXW/RXR errors to distinguish them from the other S_LEN error. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Eric Anholt <e...@anholt.net> --- Changes since v3: - Add comment about I2C_C_CL

[PATCH v4 4/7] i2c: bcm2835: Can't support I2C_M_IGNORE_NAK

2016-10-03 Thread Noralf Trønnes
ent. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Eric Anholt <e...@anholt.net> --- drivers/i2c/busses/i2c-bcm2835.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c index 54d510a..565ef69 10064

[PATCH v4 7/7] i2c: bcm2835: Add support for dynamic clock

2016-10-03 Thread Noralf Trønnes
Support a dynamic clock by reading the frequency and setting the divisor in the transfer function instead of during probe. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Martin Sperl <ker...@martin.sperl.org> --- drivers/i2c/busses/i2c-bc

[PATCH v4 6/7] i2c: bcm2835: Support i2c-dev ioctl I2C_TIMEOUT

2016-10-03 Thread Noralf Trønnes
Use i2c_adapter->timeout for the completion timeout value. The core default is 1 second. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Eric Anholt <e...@anholt.net> --- drivers/i2c/busses/i2c-bcm2835.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH v4 3/7] i2c: bcm2835: Use dev_dbg logging on transfer errors

2016-10-03 Thread Noralf Trønnes
dev_err() on transfer error, so switch to dev_dbg() instead. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Eric Anholt <e...@anholt.net> --- drivers/i2c/busses/i2c-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c

[PATCH v4 0/7] i2c: bcm2835: Bring in changes from downstream

2016-10-03 Thread Noralf Trønnes
I2C_C_CLEAR on error Noralf. Noralf Trønnes (7): i2c: bcm2835: Fix hang for writing messages larger than 16 bytes i2c: bcm2835: Protect against unexpected TXW/RXR interrupts i2c: bcm2835: Use dev_dbg logging on transfer errors i2c: bcm2835: Can't support I2C_M_IGNORE_NAK i2c: bcm2835: Add

[PATCH v4 1/7] i2c: bcm2835: Fix hang for writing messages larger than 16 bytes

2016-10-03 Thread Noralf Trønnes
when the FIFO contains at least one byte of data. TXW: is set during a write transfer and the FIFO is less than full. RXR: is set during a read transfer and the FIFO is or more full. Implementing the logic from the downstream i2c-bcm2708 driver solved the hang problem. Signed-off-by: Noralf

[PATCH v4 5/7] i2c: bcm2835: Add support for Repeated Start Condition

2016-10-03 Thread Noralf Trønnes
(eeprom) in parallel without problems. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Eric Anholt <e...@anholt.net> --- drivers/i2c/busses/i2c-bcm2835.c | 101 --- 1 file changed, 63 insertions(+), 38 deletions(-) diff --git a/driver

Re: [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-10-02 Thread Noralf Trønnes
Den 29.09.2016 07:37, skrev Stefan Wahren: Noralf Trønnes <nor...@tronnes.org> hat am 29. September 2016 um 00:22 geschrieben: Den 29.09.2016 00:00, skrev Eric Anholt: Noralf Trønnes <nor...@tronnes.org> writes: If an unexpected TXW or RXR interrupt occurs (msg_buf_re

Re: [RFC PATCH 3/3] staging: remove fbtft

2016-11-23 Thread Noralf Trønnes
NERS b/MAINTAINERS index 772330b38212..466a86a3b2fc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4839,12 +4839,6 @@ S: Supported F:Documentation/fault-injection/ F:lib/fault-inject.c -FBTFT Framebuffer drivers -M: Thomas Petazzoni <thomas.petazz...@free-electrons.com> -M

Re: [PATCH v3 0/5] fbtft: make it work with DMA enabled SPI

2017-01-11 Thread Noralf Trønnes
rkfun for Intel Edison) OLED displays at their maximum speed (25MHz and 10MHz). Noralf, are you okay with this version of series? Yes, Greg applies them without my ack, unless it touches core stuff. Series: Acked-by: Noralf Trønnes <nor...@tronnes.org> Since v2: - fix kbuild bot warni

Re: [PATCH v2 3/6] staging: fbtft: fallback to usual allocation when DMA fails

2017-01-03 Thread Noralf Trønnes
Den 03.01.2017 17:12, skrev Andy Shevchenko: On Mon, 2017-01-02 at 13:35 +0200, Andy Shevchenko wrote: Fall back to usual allocation method if DMA coherent allocation fails. SPI framework will map and use DMA mapped memory when possible. Locally I have re-done DMA approach and thus this

Re: [PATCH v2 5/6] staging: fbtft: fb_ssd1306: Support smaller screen sizes

2017-01-03 Thread Noralf Trønnes
and 6: Acked-by: Noralf Trønnes <nor...@tronnes.org> drivers/staging/fbtft/fb_ssd1306.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/staging/fbtft/fb_ssd1306.c b/drivers/staging/fbtft/fb_ssd1306.c index 80fc57029fee..bede2d5a5571 100644 --- a/drivers/s

Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask

2017-01-03 Thread Noralf Trønnes
Den 03.01.2017 14:58, skrev Andy Shevchenko: On Tue, 2017-01-03 at 12:51 +0200, Andy Shevchenko wrote: On Mon, 2017-01-02 at 19:14 +0100, Noralf Trønnes wrote: Den 02.01.2017 12:35, skrev Andy Shevchenko: Usually it's not consumer's business to override resources passed from provider

Re: [PATCH v2 1/6] staging: fbtft: convert fbtft_reset() to be non-atomic

2017-01-03 Thread Noralf Trønnes
if (par->gpio.reset == -1) return; + + might_sleep(); gpio_set_value_cansleep() already does might_sleep(). So with that removed: Reviewed-by: Noralf Trønnes <nor...@tronnes.org> + fbtft_par_dbg(DEBUG_RESET, par, "%s()\n", __func__); -

Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask

2017-01-02 Thread Noralf Trønnes
Den 02.01.2017 12:35, skrev Andy Shevchenko: Usually it's not consumer's business to override resources passed from provider, in particularly DMA coherent mask. Signed-off-by: Andy Shevchenko --- drivers/staging/fbtft/fbtft-core.c | 1 - 1 file changed, 1

Re: [PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property

2017-04-12 Thread Noralf Trønnes
Den 11.04.2017 07.29, skrev Laurent Pinchart: Hi Noralf, On Saturday 11 Feb 2017 19:48:56 Noralf Trønnes wrote: Display panels can be oriented many ways, especially in the embedded world. The rotation property is a way to describe this orientation. The counter clockwise direction is chosen

Re: [PATCH v4 1/7] drm: Add DRM support for tiny LCD displays

2017-03-08 Thread Noralf Trønnes
Den 07.03.2017 23.21, skrev Daniel Vetter: On Sat, Feb 11, 2017 at 07:48:52PM +0100, Noralf Trønnes wrote: +const struct file_operations tinydrm_fops = { + .owner = THIS_MODULE, + .open = drm_open, + .release= drm_release, + .unlocked_ioctl

Re: [PATCH] tinydrm: repaper: add CONFIG_THERMAL dependency

2017-07-29 Thread Noralf Trønnes
Den 27.07.2017 11.58, skrev Arnd Bergmann: The new RePaper driver uses the thermal subsystem, and fails to link when it is built-in but thermal is a loadable module: drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_probe': repaper.c:(.text+0x540): undefined reference to

Re: [PATCH v2 1/4] drm/tinydrm: remove call to mipi_dbi_init() from mipi_dbi_spi_init()

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: This removes the call to mipi_dbi_init() from mipi_dbi_spi_init() so that drivers can have a driver-specific implementation if needed. Also fixed order of @dc parameter in the doc comment. Suggested-by: Noralf Trønnes <nor...@tronnes.org> Sign

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.26, skrev David Lechner: On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 18.24, skrev David Lechner: On 08/02/2017 08:03 AM, Noralf Trønnes wrote: Please use tinydrm_xrgb_to_gray8(). I considered this, but is seems excessive to loop through the entire fb twice just to make a 4x6 cursor blink. Yes, you're right about that. Can you change

Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access

2017-08-02 Thread Noralf Trønnes
Den 01.08.2017 22.14, skrev David Lechner: If we return here and import_attach is true, then dma_buf_end_cpu_access() will not be called balance dma_buf_begin_cpu_access(). Fix by setting ret instead of returning. Signed-off-by: David Lechner <da...@lechnology.com> --- Reviewed-by:

Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown.

2017-08-02 Thread Noralf Trønnes
ev, vc4->hang_state); - - vc4_bo_cache_destroy(dev); } I don't have a display connected, but there's no crashing anymore. Tested-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Noralf Trønnes <nor...@tronnes.org>

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread Noralf Trønnes
Den 02.08.2017 00.11, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the EV3 LCD display. Signed-off-by: David Lechner --- .../devicetree/bindings/display/st7586.txt

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread Noralf Trønnes
Den 02.08.2017 00.26, skrev David Lechner: On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread Noralf Trønnes
Den 03.08.2017 19.11, skrev Andy Shevchenko: On Thu, Aug 3, 2017 at 8:09 PM, Andy Shevchenko wrote: On Thu, Aug 3, 2017 at 6:18 PM, David Lechner wrote: The particular display I have is this one:

Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access

2017-08-04 Thread Noralf Trønnes
Den 04.08.2017 00.41, skrev David Lechner: On 08/01/2017 03:14 PM, David Lechner wrote: If we return here and import_attach is true, then dma_buf_end_cpu_access() will not be called balance dma_buf_begin_cpu_access(). Fix by setting ret instead of returning. Signed-off-by: David Lechner

Re: [PATCH v3 2/6] drm/tinydrm: generalize tinydrm_xrgb8888_to_gray8()

2017-08-04 Thread Noralf Trønnes
Den 04.08.2017 00.33, skrev David Lechner: This adds parameters for vaddr and clip to tinydrm_xrgb_to_gray8() to make it more generic. dma_buf_{begin,end}_cpu_access() are moved out to the repaper driver. Signed-off-by: David Lechner ---

Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.

2017-08-03 Thread Noralf Trønnes
> --- Acked-by: Noralf Trønnes <nor...@tronnes.org> drivers/gpu/drm/vc4/vc4_dsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 13481bb6322f..d1e0dc908048 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c +++ b/drivers

Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload.

2017-08-03 Thread Noralf Trønnes
Den 02.08.2017 22.32, skrev Eric Anholt: The clocks are enabled/disabled at encoder enable/disable time, not at component load. Fixes a WARN_ON at boot if V3D fails to probe. Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") Signed-off-by: Eric Anholt <e...@anholt.net> ---

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

2017-08-04 Thread Noralf Trønnes
Den 04.08.2017 00.33, skrev David Lechner: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel I am working with is an integral part of the LEGO MINDSTORMS EV3. Is this display available outside of

Re: [PATCH v4 3/5] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-11 Thread Noralf Trønnes
Den 09.08.2017 19.59, skrev Noralf Trønnes: Den 07.08.2017 19.39, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner <

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

2017-08-04 Thread Noralf Trønnes
Hi Laurent, Den 04.08.2017 16.54, skrev Laurent Pinchart: Hi David, Thank you for the patch. On Thursday 03 Aug 2017 17:33:47 David Lechner wrote: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

2017-08-04 Thread Noralf Trønnes
Den 04.08.2017 18.51, skrev David Lechner: On 08/04/2017 04:48 AM, Noralf Trønnes wrote: Den 04.08.2017 00.33, skrev David Lechner: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel I am working

Re: [PATCH v3 4/6] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-05 Thread Noralf Trønnes
Den 04.08.2017 00.33, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner --- MAINTAINERS

Re: [PATCH v3 4/6] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-05 Thread Noralf Trønnes
Den 05.08.2017 20.19, skrev Noralf Trønnes: Den 04.08.2017 00.33, skrev David Lechner: LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner <

<    1   2   3   4   5   6   7   8   9   >