RE: [PATCH 05/15] habanalabs/gaudi: add NIC Ethernet support

2020-09-14 Thread Omer Shpigelman
On Thu, Sep 10, 2020 at 11:03 PM Jakub Kicinski wrote: > On Thu, 10 Sep 2020 19:11:16 +0300 Oded Gabbay wrote: > > +module_param(nic_rx_poll, int, 0444); > MODULE_PARM_DESC(nic_rx_poll, > > + "Enable NIC Rx polling mode (0 = no, 1 = yes, default no)"); > > If your chip does not support IRQ

RE: [PATCH 12/15] habanalabs/gaudi: add debugfs entries for the NIC

2020-09-14 Thread Omer Shpigelman
On Thu, Sep 10, 2020 at 11:31 PM Jakub Kicinski wrote: > On Thu, 10 Sep 2020 23:17:59 +0300 Oded Gabbay wrote: > > > Doesn't seem like this one shows any more information than can be > > > queried with ethtool, right? > > correct, it just displays it in a format that is much more readable > >

RE: [PATCH] habanalabs: add comments on INFO IOCTL

2019-07-16 Thread Omer Shpigelman
From: Oded Gabbay Sent: Tuesday, 16 July 2019 12:02 > This patch adds some in-code documentation on the different opcodes of > the INFO IOCTL. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH] habanalabs: add debug print when rejecting CS

2019-07-18 Thread Omer Shpigelman
me the CS) > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH] habanalabs: cap simulator timeout

2019-07-18 Thread Omer Shpigelman
unnecessary. > > This patch caps the maximum timeout of the simulator to 10 seconds, which > is our largest timeout in the code. That is more then enough for anything the > simulator is doing. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

[PATCH] habanalabs: handle MMU cache invalidation timeout

2020-05-24 Thread Omer Shpigelman
MMU cache invalidation timeout indicates that the device is unstable and therefore unusable. Hence in such case do hard reset and return an error to the user if was called from ioctl. In addition, change the print to error level and rephrase its text. Signed-off-by: Omer Shpigelman --- drivers

RE: [PATCH] habanalabs: correctly cast u64 to void*

2020-05-31 Thread Omer Shpigelman
On Sun, May 31, 2020 at 12:16 PM, Oded Gabbay wrote: > Use the u64_to_user_ptr(x) kernel macro to correctly cast u64 to void* > > Reported-by: kbuild test robot > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH] habanalabs: don't reset device when getting VRHOT

2019-07-22 Thread Omer Shpigelman
omatically when > reaching 125 degrees. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH] habanalabs: power management through sysfs is only for GOYA

2019-07-22 Thread Omer Shpigelman
> to make the properties appear in sysfs only for GOYA cards. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

[PATCH 2/2] habanalabs: improve security in Debug IOCTL

2019-08-06 Thread Omer Shpigelman
This patch improves the security in the Debug IOCTL. It adds checks that: - The register index value is in the allowed range for all opcodes. - The event types number is in the allowed range in SPMU enable. - The events number is in the allowed range in SPMU disable. Signed-off-by: Omer

[PATCH 1/2] habanalabs: use default structure for user input in Debug IOCTL

2019-08-06 Thread Omer Shpigelman
structure. Note that in contrary to the input structure, the user can provide an output structure with changing size or no size at all. Therefore the user output structure validation is already done in the Debug logic later on. Signed-off-by: Omer Shpigelman --- drivers/misc/habanalabs

RE: [PATCH 1/2] habanalabs: add uapi to retrieve device utilization

2019-09-02 Thread Omer Shpigelman
; over the last period of 100-1000ms. The return value is 0-100, representing as > percentage the total utilization rate. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH 2/2] habanalabs: add uapi to retrieve aggregate H/W events

2019-09-02 Thread Omer Shpigelman
ndling function. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH] habanalabs: display card name as sensors header

2019-09-02 Thread Omer Shpigelman
g on the device. If the F/W is old > and doesn't supply a card name, a default card name is displayed as the > sensors group name. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH 1/2] habanalabs: stop using the acronym KMD

2019-09-02 Thread Omer Shpigelman
r", etc. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH 2/2] habanalabs: show correct id in error print

2019-09-02 Thread Omer Shpigelman
From: Oded Gabbay Sent: Monday, 2 September 2019 10:50 > If the initialization of a device failed, the driver prints an error message > with > the id of the device. The device index on the file system is that id divided > by > 2. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

[PATCH 2/2] habanalabs: handle large memory on MMU

2019-10-10 Thread Omer Shpigelman
This patch changes the allocation of the host memory pages array to use vmalloc if needed. This in order to support mapping of large memory chunks. Signed-off-by: Omer Shpigelman --- drivers/misc/habanalabs/memory.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git

[PATCH 1/2] habanalabs: support vmalloc memory mapping

2019-10-10 Thread Omer Shpigelman
This patch adds support in mapping of vmalloc memory. In contrary to user memory, vmalloc memory is already pinned and has no vm_area structure. Therefore a new capability was needed in order to map this memory. Mapping vmalloc memory is needed for Gaudi ASIC. Signed-off-by: Omer Shpigelman

RE: [PATCH 1/2] habanalabs: support vmalloc memory mapping

2019-10-10 Thread Omer Shpigelman
On Thu, Oct 10, 2019 at 5:10 PM Christoph Hellwig wrote: > On Thu, Oct 10, 2019 at 02:06:22PM +0000, Omer Shpigelman wrote: > > This patch adds support in mapping of vmalloc memory. > > In contrary to user memory, vmalloc memory is already pinned and has > > no vm_area struc

[PATCH v2 2/2] habanalabs: handle large memory on MMU

2019-10-22 Thread Omer Shpigelman
This patch changes the allocation of the host memory pages array to use vmalloc if needed. This in order to support mapping of large memory chunks. Signed-off-by: Omer Shpigelman --- drivers/misc/habanalabs/memory.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git

[PATCH v2 1/2] habanalabs: support kernel memory mapping

2019-10-22 Thread Omer Shpigelman
In contrary to user memory, kernel memory is already pinned and has no vm_area structure. Therefore we need a new code path to map this memory. This is a pre-requisite patch for upstreaming future ASIC support Signed-off-by: Omer Shpigelman --- Changes in v2: - use a boolean parameter

RE: [PATCH v2 1/2] habanalabs: support kernel memory mapping

2019-10-23 Thread Omer Shpigelman
On Thu, Oct 23, 2019 at 12:21 PM Christoph Hellwig wrote: > On Tue, Oct 22, 2019 at 06:30:35AM +0000, Omer Shpigelman wrote: > > Changes in v2: > > - use a boolean parameter to indicate for kernel address rather than > >calling is_vmalloc_addr, as kernel and user

RE: [PATCH 2/3] habanalabs: create common folder

2020-07-15 Thread Omer Shpigelman
ff-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH 3/3] habanalabs: update hl_boot_if.h from firmware

2020-07-15 Thread Omer Shpigelman
On Mon, Jul 13, 2020 at 06:54 PM, Oded Gabbay wrote: > Update the boot interface file from the latest version from firmware. > Defines for secure boot were added. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

[PATCH] habanalabs: check if CoreSight is supported

2020-05-10 Thread Omer Shpigelman
Coresight is not supported on simulator, therefore add a boolean for checking that (currently used by un-upstreamed code). Signed-off-by: Omer Shpigelman --- drivers/misc/habanalabs/goya/goya.c | 1 + drivers/misc/habanalabs/habanalabs.h | 2 ++ 2 files changed, 3 insertions(+) diff --git

[PATCH] habanalabs: remove unused hash

2020-07-07 Thread Omer Shpigelman
Remove an old hash that is not in use anymore. Signed-off-by: Omer Shpigelman --- drivers/misc/habanalabs/habanalabs.h | 2 -- drivers/misc/habanalabs/mmu.c| 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/misc/habanalabs/habanalabs.h b/drivers/misc/habanalabs/habanalabs.h

[PATCH] habanalbas: rephrase error message

2020-07-04 Thread Omer Shpigelman
Rephrase F/W error message to make it more understandable to ordinary users. Signed-off-by: Omer Shpigelman --- drivers/misc/habanalabs/firmware_if.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs

RE: [PATCH 1/2] habanalabs: block WREG_BULK packet on PDMA

2020-07-05 Thread Omer Shpigelman
ed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH 2/2] habanalabs: set clock gating per engine

2020-07-05 Thread Omer Shpigelman
gt; Each bit represents a different engine, according to gaudi_engine_id enum. > > See debugfs documentation for more details. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH 1/7] habanalabs: remove rate limiters from GAUDI

2020-06-18 Thread Omer Shpigelman
On Tue, Jun 16, 2020 at 9:13 AM, Oded Gabbay wrote: > We no longer need to initialize the rate limiters in GAUDI A1. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH 5/7] uapi/habanalabs: fix some comments

2020-06-18 Thread Omer Shpigelman
On Tue, Jun 16, 2020 at 09:13 AM, Oded Gabbay wrote: > MAP/UNMAP are done also for device memory. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

RE: [PATCH 6/7] habanalabs: align armcp_packet structure to 8 bytes

2020-06-18 Thread Omer Shpigelman
tly align > the structure to 8 bytes. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman