[PATCH] PCI/AER: Clear uncorrectable error status for device

2018-09-18 Thread Oza Pawandeep
in err.c Clear the status while resuming, after reset_link was successful. Signed-off-by: Oza Pawandeep diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/qat_common/adf_aer.c index da8a2d3..61ded36 100644 --- a/drivers/crypto/qat/qat_common/adf_aer.c +++ b/drivers

[PATCH] PCI/AER: Clear uncorrectable error status for device

2018-09-18 Thread Oza Pawandeep
in err.c Clear the status while resuming, after reset_link was successful. Signed-off-by: Oza Pawandeep diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/qat_common/adf_aer.c index da8a2d3..61ded36 100644 --- a/drivers/crypto/qat/qat_common/adf_aer.c +++ b/drivers

[PATCH v2 0/6] Fix issues and cleanup for ERR_FATAL and ERR_NONFATAL

2018-06-22 Thread Oza Pawandeep
patch where no more need of handling pci_channel_io_frozen in pcie_portdrv_slot_reset() Oza Pawandeep (6): PCI/AER: Take severity mask into account while clearing error bits PCI/AER: Clear uncorrectable fatal error status bits PCI/ERR: Cleanup ERR_FATAL of error broadcast PCI/AER: Clear

[PATCH v2 0/6] Fix issues and cleanup for ERR_FATAL and ERR_NONFATAL

2018-06-22 Thread Oza Pawandeep
patch where no more need of handling pci_channel_io_frozen in pcie_portdrv_slot_reset() Oza Pawandeep (6): PCI/AER: Take severity mask into account while clearing error bits PCI/AER: Clear uncorrectable fatal error status bits PCI/ERR: Cleanup ERR_FATAL of error broadcast PCI/AER: Clear

[PATCH v2 5/6] PCI/AER: Fix correctable status bits clearing in device register

2018-06-22 Thread Oza Pawandeep
In case of correctable error Device Status Register sets Correctable Error Detected, which should be cleared after handling the error Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index d2d6868..a42b071 100644 --- a/drivers/pci/pcie/aer.c +++ b

[PATCH v2 5/6] PCI/AER: Fix correctable status bits clearing in device register

2018-06-22 Thread Oza Pawandeep
In case of correctable error Device Status Register sets Correctable Error Detected, which should be cleared after handling the error Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index d2d6868..a42b071 100644 --- a/drivers/pci/pcie/aer.c +++ b

[PATCH v2 3/6] PCI/ERR: Cleanup ERR_FATAL of error broadcast

2018-06-22 Thread Oza Pawandeep
ERR_FATAL is handled by resetting the Link in software, skipping the driver pci_error_handlers callbacks, removing the devices from the PCI subsystem, and re-enumerating, so now no more ERR_FATAL handling is required inside pci_broadcast_error_message() Signed-off-by: Oza Pawandeep diff --git

[PATCH v2 3/6] PCI/ERR: Cleanup ERR_FATAL of error broadcast

2018-06-22 Thread Oza Pawandeep
ERR_FATAL is handled by resetting the Link in software, skipping the driver pci_error_handlers callbacks, removing the devices from the PCI subsystem, and re-enumerating, so now no more ERR_FATAL handling is required inside pci_broadcast_error_message() Signed-off-by: Oza Pawandeep diff --git

[PATCH v2 6/6] PCI/PORTDRV: Remove ERR_FATAL handling from pcie_portdrv_slot_reset()

2018-06-22 Thread Oza Pawandeep
, inside broadcast_error_message(), which means that pcie_portdrv_slot_reset() is never called for RP, and now since the all the devices are removed under this downstream link, we can safely get rid of ERR_FATAL handling code in pcie_portdrv_slot_reset(). Signed-off-by: Oza Pawandeep diff --git

[PATCH v2 1/6] PCI/AER: Take severity mask into account while clearing error bits

2018-06-22 Thread Oza Pawandeep
-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index a2e8838..d6cb1f0 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -360,13 +360,16 @@ EXPORT_SYMBOL_GPL(pci_disable_pcie_error_reporting); int pci_cleanup_aer_uncorrect_error_status(struct

[PATCH v2 1/6] PCI/AER: Take severity mask into account while clearing error bits

2018-06-22 Thread Oza Pawandeep
-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index a2e8838..d6cb1f0 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -360,13 +360,16 @@ EXPORT_SYMBOL_GPL(pci_disable_pcie_error_reporting); int pci_cleanup_aer_uncorrect_error_status(struct

[PATCH v2 6/6] PCI/PORTDRV: Remove ERR_FATAL handling from pcie_portdrv_slot_reset()

2018-06-22 Thread Oza Pawandeep
, inside broadcast_error_message(), which means that pcie_portdrv_slot_reset() is never called for RP, and now since the all the devices are removed under this downstream link, we can safely get rid of ERR_FATAL handling code in pcie_portdrv_slot_reset(). Signed-off-by: Oza Pawandeep diff --git

[PATCH v2 2/6] PCI/AER: Clear uncorrectable fatal error status bits

2018-06-22 Thread Oza Pawandeep
During ERR_FATAL handling, AER calls pci_cleanup_aer_uncorrect_error_status which should handle pci_channel_io_frozen case in order to determine if it has to clear fatal bits. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index d6cb1f0..e9c115d 100644

[PATCH v2 2/6] PCI/AER: Clear uncorrectable fatal error status bits

2018-06-22 Thread Oza Pawandeep
During ERR_FATAL handling, AER calls pci_cleanup_aer_uncorrect_error_status which should handle pci_channel_io_frozen case in order to determine if it has to clear fatal bits. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index d6cb1f0..e9c115d 100644

[PATCH v2 4/6] PCI/AER: Clear device error status bits during ERR_FATAL and ERR_NONFATAL

2018-06-22 Thread Oza Pawandeep
In both ERR_FATAL and ERR_NONFATA cases the device error status bits needs to be cleared. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index e9c115d..d2d6868 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -357,6 +357,17 @@ int

[PATCH v2 4/6] PCI/AER: Clear device error status bits during ERR_FATAL and ERR_NONFATAL

2018-06-22 Thread Oza Pawandeep
In both ERR_FATAL and ERR_NONFATA cases the device error status bits needs to be cleared. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index e9c115d..d2d6868 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -357,6 +357,17 @@ int

[PATCH NEXT 5/6] PCI/AER: Clear correctable status bits in device register

2018-06-07 Thread Oza Pawandeep
In case of correctable error Device Status Register sets Correctable Error Detected, which should be cleared after handling the error Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index 95e9828..0e4e99a 100644 --- a/drivers

[PATCH NEXT 2/6] PCI/AER: Clear uncorrectable fatal error status bits

2018-06-07 Thread Oza Pawandeep
During ERR_FATAL handling, AER calls pci_cleanup_aer_uncorrect_error_status which should handle pci_channel_io_frozen case in order to determine if it has to clear fatal bits or nonfatal bits. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer

[PATCH NEXT 5/6] PCI/AER: Clear correctable status bits in device register

2018-06-07 Thread Oza Pawandeep
In case of correctable error Device Status Register sets Correctable Error Detected, which should be cleared after handling the error Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index 95e9828..0e4e99a 100644 --- a/drivers

[PATCH NEXT 2/6] PCI/AER: Clear uncorrectable fatal error status bits

2018-06-07 Thread Oza Pawandeep
During ERR_FATAL handling, AER calls pci_cleanup_aer_uncorrect_error_status which should handle pci_channel_io_frozen case in order to determine if it has to clear fatal bits or nonfatal bits. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer

[PATCH NEXT 6/6] PCI/PORTDRV: Remove ERR_FATAL handling from pcie_portdrv_slot_reset()

2018-06-07 Thread Oza Pawandeep
We are handling ERR_FATAL by resetting the Link in software,skipping the driver pci_error_handlers callbacks, removing the devices from the PCI subsystem, and re-enumerating, as a result of that, no more calling pcie_portdrv_slot_reset in ERR_FATAL case. Signed-off-by: Oza Pawandeep diff --git

[PATCH NEXT 4/6] PCI/AER: Clear device status error bits during ERR_FATAL and ERR_NONFATAL

2018-06-07 Thread Oza Pawandeep
We are handling ERR_FATAL by resetting the Link in software,skipping the driver pci_error_handlers callbacks, removing the devices from the PCI subsystem, and re-enumerating, the device status has to be cleared, which fixes BUG existed before. Signed-off-by: Oza Pawandeep diff --git a/drivers

[PATCH NEXT 3/6] PCI/ERR: Cleanup ERR_FATAL of error broadcast

2018-06-07 Thread Oza Pawandeep
ERR_FATAL is handled by resetting the Link in software, skipping the driver pci_error_handlers callbacks, removing the devices from the PCI subsystem, and re-enumerating, so now no more ERR_FATAL handling is required inside pci_broadcast_error_message() Signed-off-by: Oza Pawandeep diff --git

[PATCH NEXT 6/6] PCI/PORTDRV: Remove ERR_FATAL handling from pcie_portdrv_slot_reset()

2018-06-07 Thread Oza Pawandeep
We are handling ERR_FATAL by resetting the Link in software,skipping the driver pci_error_handlers callbacks, removing the devices from the PCI subsystem, and re-enumerating, as a result of that, no more calling pcie_portdrv_slot_reset in ERR_FATAL case. Signed-off-by: Oza Pawandeep diff --git

[PATCH NEXT 4/6] PCI/AER: Clear device status error bits during ERR_FATAL and ERR_NONFATAL

2018-06-07 Thread Oza Pawandeep
We are handling ERR_FATAL by resetting the Link in software,skipping the driver pci_error_handlers callbacks, removing the devices from the PCI subsystem, and re-enumerating, the device status has to be cleared, which fixes BUG existed before. Signed-off-by: Oza Pawandeep diff --git a/drivers

[PATCH NEXT 3/6] PCI/ERR: Cleanup ERR_FATAL of error broadcast

2018-06-07 Thread Oza Pawandeep
ERR_FATAL is handled by resetting the Link in software, skipping the driver pci_error_handlers callbacks, removing the devices from the PCI subsystem, and re-enumerating, so now no more ERR_FATAL handling is required inside pci_broadcast_error_message() Signed-off-by: Oza Pawandeep diff --git

[PATCH NEXT 1/6] PCI/AER: Take mask into account while clearing error bits

2018-06-07 Thread Oza Pawandeep
PCIe ERR_NONFATAL and ERR_FATAL are uncorrectable errors, and clearing uncorrectable error bits should take error mask into account. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c index 377e576..8cbc62b 100644 --- a/drivers/pci/pcie/aer

[PATCH NEXT 1/6] PCI/AER: Take mask into account while clearing error bits

2018-06-07 Thread Oza Pawandeep
PCIe ERR_NONFATAL and ERR_FATAL are uncorrectable errors, and clearing uncorrectable error bits should take error mask into account. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c index 377e576..8cbc62b 100644 --- a/drivers/pci/pcie/aer

[PATCH v17 4/9] PCI/AER: Factor out error reporting to drivers/pci/pcie/err.c

2018-05-17 Thread Oza Pawandeep
of pci_uevent_ers() to match. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> [bhelgaas: in reset_link(), initialize "driver" even if CONFIG_PCIEAER is unset, update pci_uevent_ers() #ifdef wrapper] Signed-off-by: Bjorn Helgaas <helg...@kernel.org> diff --git a/driv

[PATCH v17 1/9] PCI: Add generic pcie_wait_for_link() interface

2018-05-17 Thread Oza Pawandeep
Clients such as hotplug and Downstream Port Containment (DPC) both need to wait until a link becomes active or inactive. Add a generic pcie_wait_link_active() interface and use it instead of duplicating the code. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Signed-off-by: Bjorn H

[PATCH v17 4/9] PCI/AER: Factor out error reporting to drivers/pci/pcie/err.c

2018-05-17 Thread Oza Pawandeep
of pci_uevent_ers() to match. Signed-off-by: Oza Pawandeep [bhelgaas: in reset_link(), initialize "driver" even if CONFIG_PCIEAER is unset, update pci_uevent_ers() #ifdef wrapper] Signed-off-by: Bjorn Helgaas diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c ind

[PATCH v17 1/9] PCI: Add generic pcie_wait_for_link() interface

2018-05-17 Thread Oza Pawandeep
Clients such as hotplug and Downstream Port Containment (DPC) both need to wait until a link becomes active or inactive. Add a generic pcie_wait_link_active() interface and use it instead of duplicating the code. Signed-off-by: Oza Pawandeep Signed-off-by: Bjorn Helgaas Reviewed-by: Keith

[PATCH v17 3/9] PCI/AER: Rename error recovery interfaces to generic PCI naming

2018-05-17 Thread Oza Pawandeep
Rename error recovery interfaces with "pcie_" prefix so they can be made non-static. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> [bhelgaas: move declaration to later patch, leave functions static] Signed-off-by: Bjorn Helgaas <helg...@kernel.org> Reviewed-by:

[PATCH v17 3/9] PCI/AER: Rename error recovery interfaces to generic PCI naming

2018-05-17 Thread Oza Pawandeep
Rename error recovery interfaces with "pcie_" prefix so they can be made non-static. Signed-off-by: Oza Pawandeep [bhelgaas: move declaration to later patch, leave functions static] Signed-off-by: Bjorn Helgaas Reviewed-by: Keith Busch diff --git a/drivers/pci/pcie/aer/aerdrv

[PATCH v17 0/9] Address error and recovery for AER and DPC

2018-05-17 Thread Oza Pawandeep
> pci_find_dpc_dev made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (9): PCI: Unify wait for link active into generic PCI pci-error-recovery: Add AER_FATAL handling PCI/AER: Handle ERRR_F

[PATCH v17 0/9] Address error and recovery for AER and DPC

2018-05-17 Thread Oza Pawandeep
> pci_find_dpc_dev made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (9): PCI: Unify wait for link active into generic PCI pci-error-recovery: Add AER_FATAL handling PCI/AER: Handle ERRR_F

[PATCH v17 2/9] PCI/AER: Handle ERR_FATAL with removal and re-enumeration of devices

2018-05-17 Thread Oza Pawandeep
before the driver .remove() calls, while with AER, the reset happens *after* the .remove() calls. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> [bhelgaas: changelog, squash doc patch into this] Signed-off-by: Bjorn Helgaas <helg...@kernel.org> Reviewed-by: Keith Busch <keith.

[PATCH v17 2/9] PCI/AER: Handle ERR_FATAL with removal and re-enumeration of devices

2018-05-17 Thread Oza Pawandeep
before the driver .remove() calls, while with AER, the reset happens *after* the .remove() calls. Signed-off-by: Oza Pawandeep [bhelgaas: changelog, squash doc patch into this] Signed-off-by: Bjorn Helgaas Reviewed-by: Keith Busch diff --git a/Documentation/PCI/pci-error-recovery.txt b

[PATCH v17 8/9] PCI/AER: Pass service type to pcie_do_fatal_recovery()

2018-05-17 Thread Oza Pawandeep
Pass the service type to pcie_do_fatal_recovery() instead of assuming AER. We will make DPC also use pcie_do_fatal_recovery(), and it needs to do things a little differently for AER and DPC. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> [bhelgaas: split to separate patch] Sign

[PATCH v17 8/9] PCI/AER: Pass service type to pcie_do_fatal_recovery()

2018-05-17 Thread Oza Pawandeep
Pass the service type to pcie_do_fatal_recovery() instead of assuming AER. We will make DPC also use pcie_do_fatal_recovery(), and it needs to do things a little differently for AER and DPC. Signed-off-by: Oza Pawandeep [bhelgaas: split to separate patch] Signed-off-by: Bjorn Helgaas diff

[PATCH v17 5/9] PCI/portdrv: Add generic pcie_port_find_service()

2018-05-17 Thread Oza Pawandeep
Add generic pcie_port_find_service() routine. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Signed-off-by: Bjorn Helgaas <helg...@kernel.org> Reviewed-by: Keith Busch <keith.bu...@intel.com> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_co

[PATCH v17 5/9] PCI/portdrv: Add generic pcie_port_find_service()

2018-05-17 Thread Oza Pawandeep
Add generic pcie_port_find_service() routine. Signed-off-by: Oza Pawandeep Signed-off-by: Bjorn Helgaas Reviewed-by: Keith Busch diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index 4fa1ee4..fdfc474 100644 --- a/drivers/pci/pcie/aer/aerdrv_core.c +++ b

[PATCH v17 6/9] PCI/portdrv: Add generic pcie_port_find_device()

2018-05-17 Thread Oza Pawandeep
Add generic pcie_port_find_device() routine. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Signed-off-by: Bjorn Helgaas <helg...@kernel.org> Reviewed-by: Keith Busch <keith.bu...@intel.com> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index ba6c9

[PATCH v17 6/9] PCI/portdrv: Add generic pcie_port_find_device()

2018-05-17 Thread Oza Pawandeep
Add generic pcie_port_find_device() routine. Signed-off-by: Oza Pawandeep Signed-off-by: Bjorn Helgaas Reviewed-by: Keith Busch diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index ba6c963..896608a 100644 --- a/drivers/pci/pcie/portdrv.h +++ b/drivers/pci/pcie/portdrv.h

[PATCH v17 9/9] PCI/DPC: Use the generic pcie_do_fatal_recovery() path

2018-05-17 Thread Oza Pawandeep
reset is done automatically by hardware, so we really only have to wait for the Link to be inactive, then release the Port from DPC. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> [bhelgaas: changelog, DPC_FATAL is not a bitfield, can be sequential] Signed-off-by: Bjorn Helgaas <helg...@k

[PATCH v17 9/9] PCI/DPC: Use the generic pcie_do_fatal_recovery() path

2018-05-17 Thread Oza Pawandeep
reset is done automatically by hardware, so we really only have to wait for the Link to be inactive, then release the Port from DPC. Signed-off-by: Oza Pawandeep [bhelgaas: changelog, DPC_FATAL is not a bitfield, can be sequential] Signed-off-by: Bjorn Helgaas diff --git a/drivers/pci/pcie/dpc.c b

[PATCH v17 7/9] PCI/DPC: Disable ERR_NONFATAL handling by DPC

2018-05-17 Thread Oza Pawandeep
with different usage of their pci_error_handlers callbacks and .probe() and .remove() methods based on whether the platform has DPC support. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> [bhelgaas: changelog] Signed-off-by: Bjorn Helgaas <helg...@kernel.org> diff --git a/drivers/pci/

[PATCH v17 7/9] PCI/DPC: Disable ERR_NONFATAL handling by DPC

2018-05-17 Thread Oza Pawandeep
with different usage of their pci_error_handlers callbacks and .probe() and .remove() methods based on whether the platform has DPC support. Signed-off-by: Oza Pawandeep [bhelgaas: changelog] Signed-off-by: Bjorn Helgaas diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index 80ec384..361903f

[PATCH v16 8/9] PCI/DPC: Unify and plumb error handling into DPC

2018-05-11 Thread Oza Pawandeep
DPC driver implements link_reset callback, and calls pci_do_fatal_recovery(). Which follows standard path of ERR_FATAL recovery. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 5e8857a..6af7595 100644 --- a/drivers/pci/pci.h

[PATCH v16 6/9] PCI/PORTDRV: Implement generic find service

2018-05-11 Thread Oza Pawandeep
This patch implements generic pcie_port_find_service() routine. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Reviewed-by: Keith Busch <keith.bu...@intel.com> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index 4fa1ee4..fdfc474 100644 -

[PATCH v16 8/9] PCI/DPC: Unify and plumb error handling into DPC

2018-05-11 Thread Oza Pawandeep
DPC driver implements link_reset callback, and calls pci_do_fatal_recovery(). Which follows standard path of ERR_FATAL recovery. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 5e8857a..6af7595 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h

[PATCH v16 6/9] PCI/PORTDRV: Implement generic find service

2018-05-11 Thread Oza Pawandeep
This patch implements generic pcie_port_find_service() routine. Signed-off-by: Oza Pawandeep Reviewed-by: Keith Busch diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index 4fa1ee4..fdfc474 100644 --- a/drivers/pci/pcie/aer/aerdrv_core.c +++ b/drivers/pci

[PATCH v16 4/9] PCI/AER: Rename error recovery to generic PCI naming

2018-05-11 Thread Oza Pawandeep
This patch renames error recovery to generic name with pcie prefix Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Reviewed-by: Keith Busch <keith.bu...@intel.com> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index cec9d8c..5e8857a 100644 --- a/drivers/pci/pci.h +++ b/drive

[PATCH v16 4/9] PCI/AER: Rename error recovery to generic PCI naming

2018-05-11 Thread Oza Pawandeep
This patch renames error recovery to generic name with pcie prefix Signed-off-by: Oza Pawandeep Reviewed-by: Keith Busch diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index cec9d8c..5e8857a 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -353,6 +353,10 @@ static inline

[PATCH v16 3/9] PCI/AER: Handle ERR_FATAL with removal and re-enumeration of devices

2018-05-11 Thread Oza Pawandeep
merate please refer to Documentation/PCI/pci-error-recovery.txt for more details. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Reviewed-by: Keith Busch <keith.bu...@intel.com> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index 0ea5a

[PATCH v16 5/9] PCI/AER: Factor out error reporting from AER

2018-05-11 Thread Oza Pawandeep
This patch factors out error reporting callbacks, which are currently tightly coupled with AER. DPC should be able to register callbacks and attempt recovery when DPC trigger event occurs. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/pcie/Makefile b/drive

[PATCH v16 3/9] PCI/AER: Handle ERR_FATAL with removal and re-enumeration of devices

2018-05-11 Thread Oza Pawandeep
merate please refer to Documentation/PCI/pci-error-recovery.txt for more details. Signed-off-by: Oza Pawandeep Reviewed-by: Keith Busch diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index 0ea5acc..649dd1f 100644 --- a/drivers/pci/pcie/aer/aerdrv_core.c

[PATCH v16 5/9] PCI/AER: Factor out error reporting from AER

2018-05-11 Thread Oza Pawandeep
This patch factors out error reporting callbacks, which are currently tightly coupled with AER. DPC should be able to register callbacks and attempt recovery when DPC trigger event occurs. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/Makefile b/drivers/pci/pcie/Makefile index

[PATCH v16 2/9] pci-error-recovery: Add AER_FATAL handling

2018-05-11 Thread Oza Pawandeep
It adds description on AER_FATAL error handling. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/Documentation/PCI/pci-error-recovery.txt b/Documentation/PCI/pci-error-recovery.txt index 0b6bb3e..688b691 100644 --- a/Documentation/PCI/pci-error-recovery.txt +++ b/Documen

[PATCH v16 2/9] pci-error-recovery: Add AER_FATAL handling

2018-05-11 Thread Oza Pawandeep
It adds description on AER_FATAL error handling. Signed-off-by: Oza Pawandeep diff --git a/Documentation/PCI/pci-error-recovery.txt b/Documentation/PCI/pci-error-recovery.txt index 0b6bb3e..688b691 100644 --- a/Documentation/PCI/pci-error-recovery.txt +++ b/Documentation/PCI/pci-error

[PATCH v16 0/9] Address error and recovery for AER and DPC

2018-05-11 Thread Oza Pawandeep
t; pci_find_dpc_dev made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (9): PCI: Unify wait for link active into generic PCI pci-error-recovery: Add AER_FATAL handling PCI/AE

[PATCH v16 0/9] Address error and recovery for AER and DPC

2018-05-11 Thread Oza Pawandeep
t; pci_find_dpc_dev made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (9): PCI: Unify wait for link active into generic PCI pci-error-recovery: Add AER_FATAL handling PCI/AE

[PATCH v16 1/9] PCI: Unify wait for link active into generic PCI

2018-05-11 Thread Oza Pawandeep
Clients such as HP, DPC are using pcie_wait_link_active(), which waits till the link becomes active or inactive. Made generic function and moved it to drivers/pci/pci.c Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Reviewed-by: Keith Busch <keith.bu...@intel.com> diff --git a

[PATCH v16 9/9] PCI/DPC: Disable ERR_NONFATAL and enable ERR_FATAL for DPC

2018-05-11 Thread Oza Pawandeep
This patch disables ERR_NONFATAL trigger for DPC, so now DPC handles only ERR_FATAL. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index 5680c13..358b4324 100644 --- a/drivers/pci/pcie/dpc.c +++ b/drivers/pci/pcie/dpc.c @@

[PATCH v16 9/9] PCI/DPC: Disable ERR_NONFATAL and enable ERR_FATAL for DPC

2018-05-11 Thread Oza Pawandeep
This patch disables ERR_NONFATAL trigger for DPC, so now DPC handles only ERR_FATAL. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index 5680c13..358b4324 100644 --- a/drivers/pci/pcie/dpc.c +++ b/drivers/pci/pcie/dpc.c @@ -273,7 +273,7 @@ static int

[PATCH v16 1/9] PCI: Unify wait for link active into generic PCI

2018-05-11 Thread Oza Pawandeep
Clients such as HP, DPC are using pcie_wait_link_active(), which waits till the link becomes active or inactive. Made generic function and moved it to drivers/pci/pci.c Signed-off-by: Oza Pawandeep Reviewed-by: Keith Busch diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug

[PATCH v16 7/9] PCI/PORTDRV: Implement generic find device

2018-05-11 Thread Oza Pawandeep
This patch implements generic pcie_port_find_device() routine. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Reviewed-by: Keith Busch <keith.bu...@intel.com> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index ba6c963..896608a 100644 --- a/drivers/pci/pc

[PATCH v16 7/9] PCI/PORTDRV: Implement generic find device

2018-05-11 Thread Oza Pawandeep
This patch implements generic pcie_port_find_device() routine. Signed-off-by: Oza Pawandeep Reviewed-by: Keith Busch diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index ba6c963..896608a 100644 --- a/drivers/pci/pcie/portdrv.h +++ b/drivers/pci/pcie/portdrv.h @@ -114,4

[PATCH v15 5/9] PCI/AER: Factor out error reporting from AER

2018-05-02 Thread Oza Pawandeep
This patch factors out error reporting callbacks, which are currently tightly coupled with AER. DPC should be able to register callbacks and attempt recovery when DPC trigger event occurs. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/pcie/Makefile b/drive

[PATCH v15 5/9] PCI/AER: Factor out error reporting from AER

2018-05-02 Thread Oza Pawandeep
This patch factors out error reporting callbacks, which are currently tightly coupled with AER. DPC should be able to register callbacks and attempt recovery when DPC trigger event occurs. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/Makefile b/drivers/pci/pcie/Makefile index

[PATCH v15 6/9] PCI/PORTDRV: Implement generic find service

2018-05-02 Thread Oza Pawandeep
This patch implements generic pcie_port_find_service() routine. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Reviewed-by: Keith Busch <keith.bu...@intel.com> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index 51515d1..a525296 100644 -

[PATCH v15 6/9] PCI/PORTDRV: Implement generic find service

2018-05-02 Thread Oza Pawandeep
This patch implements generic pcie_port_find_service() routine. Signed-off-by: Oza Pawandeep Reviewed-by: Keith Busch diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index 51515d1..a525296 100644 --- a/drivers/pci/pcie/aer/aerdrv_core.c +++ b/drivers/pci

[PATCH v15 7/9] PCI/PORTDRV: Implement generic find device

2018-05-02 Thread Oza Pawandeep
This patch implements generic pcie_port_find_device() routine. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Reviewed-by: Keith Busch <keith.bu...@intel.com> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index ba6c963..896608a 100644 --- a/drivers/pci/pc

[PATCH v15 7/9] PCI/PORTDRV: Implement generic find device

2018-05-02 Thread Oza Pawandeep
This patch implements generic pcie_port_find_device() routine. Signed-off-by: Oza Pawandeep Reviewed-by: Keith Busch diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index ba6c963..896608a 100644 --- a/drivers/pci/pcie/portdrv.h +++ b/drivers/pci/pcie/portdrv.h @@ -114,4

[PATCH v15 8/9] PCI/DPC: Unify and plumb error handling into DPC

2018-05-02 Thread Oza Pawandeep
Current DPC driver does not do recovery, e.g. calling end-point's driver's callbacks, which sanitize the sw. DPC driver implements link_reset callback, and calls pci_do_recovery(). Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie

[PATCH v15 8/9] PCI/DPC: Unify and plumb error handling into DPC

2018-05-02 Thread Oza Pawandeep
Current DPC driver does not do recovery, e.g. calling end-point's driver's callbacks, which sanitize the sw. DPC driver implements link_reset callback, and calls pci_do_recovery(). Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index 80ec384..aed7c9f

[PATCH v15 2/9] pci-error-recovery: Add AER_FATAL handling

2018-05-02 Thread Oza Pawandeep
It adds description on AER_FATAL error handling. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/Documentation/PCI/pci-error-recovery.txt b/Documentation/PCI/pci-error-recovery.txt index 0b6bb3e..688b691 100644 --- a/Documentation/PCI/pci-error-recovery.txt +++ b/Documen

[PATCH v15 9/9] PCI/DPC: Disable ERR_NONFATAL and enable ERR_FATAL for DPC

2018-05-02 Thread Oza Pawandeep
This patch disables ERR_NONFATAL trigger for DPC, so now DPC handles only ERR_FATAL. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index aed7c9f..6966e00 100644 --- a/drivers/pci/pcie/dpc.c +++ b/drivers/pci/pcie/dpc.c @@

[PATCH v15 2/9] pci-error-recovery: Add AER_FATAL handling

2018-05-02 Thread Oza Pawandeep
It adds description on AER_FATAL error handling. Signed-off-by: Oza Pawandeep diff --git a/Documentation/PCI/pci-error-recovery.txt b/Documentation/PCI/pci-error-recovery.txt index 0b6bb3e..688b691 100644 --- a/Documentation/PCI/pci-error-recovery.txt +++ b/Documentation/PCI/pci-error

[PATCH v15 9/9] PCI/DPC: Disable ERR_NONFATAL and enable ERR_FATAL for DPC

2018-05-02 Thread Oza Pawandeep
This patch disables ERR_NONFATAL trigger for DPC, so now DPC handles only ERR_FATAL. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index aed7c9f..6966e00 100644 --- a/drivers/pci/pcie/dpc.c +++ b/drivers/pci/pcie/dpc.c @@ -263,7 +263,7 @@ static int

[PATCH v15 1/9] PCI: Unify wait for link active into generic PCI

2018-05-02 Thread Oza Pawandeep
Clients such as HP, DPC are using pcie_wait_link_active(), which waits till the link becomes active or inactive. Made generic function and moved it to drivers/pci/pci.c Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/h

[PATCH v15 1/9] PCI: Unify wait for link active into generic PCI

2018-05-02 Thread Oza Pawandeep
Clients such as HP, DPC are using pcie_wait_link_active(), which waits till the link becomes active or inactive. Made generic function and moved it to drivers/pci/pci.c Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 18a42f8

[PATCH v15 3/9] PCI/AER: Handle ERR_FATAL with removal and re-enumeration of devices

2018-05-02 Thread Oza Pawandeep
merate please refer to Documentation/PCI/pci-error-recovery.txt for more details. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c index 779b387..206f590 100644 --- a/drivers/pci/pcie/aer/aerdrv.c +++ b/drivers/

[PATCH v15 0/9] Address error and recovery for AER and DPC

2018-05-02 Thread Oza Pawandeep
v made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (9): PCI: Unify wait for link active into generic PCI pci-error-recovery: Add AER_FATAL handling PCI/AER: Handle ERRR_FATAL with removal

[PATCH v15 3/9] PCI/AER: Handle ERR_FATAL with removal and re-enumeration of devices

2018-05-02 Thread Oza Pawandeep
merate please refer to Documentation/PCI/pci-error-recovery.txt for more details. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c index 779b387..206f590 100644 --- a/drivers/pci/pcie/aer/aerdrv.c +++ b/drivers/pci/pcie/aer/aerdrv.c @@ -330,6 +

[PATCH v15 0/9] Address error and recovery for AER and DPC

2018-05-02 Thread Oza Pawandeep
v made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (9): PCI: Unify wait for link active into generic PCI pci-error-recovery: Add AER_FATAL handling PCI/AER: Handle ERRR_FATAL with removal

[PATCH v15 4/9] PCI/AER: Rename error recovery to generic PCI naming

2018-05-02 Thread Oza Pawandeep
This patch renames error recovery to generic name with pcie prefix Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Reviewed-by: Keith Busch <keith.bu...@intel.com> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index cec9d8c..22a9589 100644 --- a/drivers/pci/pci.h +++ b/drive

[PATCH v15 4/9] PCI/AER: Rename error recovery to generic PCI naming

2018-05-02 Thread Oza Pawandeep
This patch renames error recovery to generic name with pcie prefix Signed-off-by: Oza Pawandeep Reviewed-by: Keith Busch diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index cec9d8c..22a9589 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -353,6 +353,9 @@ static inline

[PATCH v14 4/9] PCI/PORTDRV: Implement generic find device

2018-04-23 Thread Oza Pawandeep
This patch implements generic pcie_port_find_device() routine. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index 419bdf3..06f4e11d 100644 --- a/drivers/pci/pcie/portdrv.h +++ b/drivers/pci/pcie/portdrv.h @@ -81,4

[PATCH v14 4/9] PCI/PORTDRV: Implement generic find device

2018-04-23 Thread Oza Pawandeep
This patch implements generic pcie_port_find_device() routine. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index 419bdf3..06f4e11d 100644 --- a/drivers/pci/pcie/portdrv.h +++ b/drivers/pci/pcie/portdrv.h @@ -81,4 +81,6 @@ static inline void

[PATCH v14 2/9] PCI/AER: Factor out error reporting from AER

2018-04-23 Thread Oza Pawandeep
This patch factors out error reporting callbacks, which are currently tightly coupled with AER. DPC should be able to register callbacks and attempt recovery when DPC trigger event occurs. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> Reviewed-by: Keith Busch <keith.bu...@intel.c

[PATCH v14 2/9] PCI/AER: Factor out error reporting from AER

2018-04-23 Thread Oza Pawandeep
This patch factors out error reporting callbacks, which are currently tightly coupled with AER. DPC should be able to register callbacks and attempt recovery when DPC trigger event occurs. Signed-off-by: Oza Pawandeep Reviewed-by: Keith Busch diff --git a/drivers/pci/pcie/Makefile b/drivers

[PATCH v14 6/9] PCI: Unify wait for link active into generic PCI

2018-04-23 Thread Oza Pawandeep
Clients such as HP, DPC are using pcie_wait_link_active(), which waits till the link becomes active or inactive. Made generic function and moved it to drivers/pci/pci.c Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/h

[PATCH v14 6/9] PCI: Unify wait for link active into generic PCI

2018-04-23 Thread Oza Pawandeep
Clients such as HP, DPC are using pcie_wait_link_active(), which waits till the link becomes active or inactive. Made generic function and moved it to drivers/pci/pci.c Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 18a42f8

[PATCH v14 8/9] PCI/AER/DPC: Align FATAL error handling for AER and DPC

2018-04-23 Thread Oza Pawandeep
to both AER and DPC, so that we have unified error handling from error agents (SW) point of view. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c index da8331f..b2eaa3f 100644 --- a/drivers/pci/pcie/aer/aerdrv.c

[PATCH v14 8/9] PCI/AER/DPC: Align FATAL error handling for AER and DPC

2018-04-23 Thread Oza Pawandeep
to both AER and DPC, so that we have unified error handling from error agents (SW) point of view. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c index da8331f..b2eaa3f 100644 --- a/drivers/pci/pcie/aer/aerdrv.c +++ b/drivers/pci/pcie/aer

[PATCH v14 7/9] PCI/DPC: Disable ERR_NONFATAL and enable ERR_FATAL for DPC

2018-04-23 Thread Oza Pawandeep
This patch disables ERR_NONFATAL trigger for DPC, so now DPC handles only ERR_FATAL. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/drivers/pci/pcie/pcie-dpc.c b/drivers/pci/pcie/pcie-dpc.c index 6baed85..cd15862 100644 --- a/drivers/pci/pcie/pcie-dpc.c +++ b/drivers/pc

[PATCH v14 7/9] PCI/DPC: Disable ERR_NONFATAL and enable ERR_FATAL for DPC

2018-04-23 Thread Oza Pawandeep
This patch disables ERR_NONFATAL trigger for DPC, so now DPC handles only ERR_FATAL. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/pcie-dpc.c b/drivers/pci/pcie/pcie-dpc.c index 6baed85..cd15862 100644 --- a/drivers/pci/pcie/pcie-dpc.c +++ b/drivers/pci/pcie/pcie-dpc.c @@ -283,7

[PATCH v14 9/9] pci-error-recovery: Add AER_FATAL handling

2018-04-23 Thread Oza Pawandeep
It adds description on AER_FATAL error handling. Signed-off-by: Oza Pawandeep <p...@codeaurora.org> diff --git a/Documentation/PCI/pci-error-recovery.txt b/Documentation/PCI/pci-error-recovery.txt index 0b6bb3e..688b691 100644 --- a/Documentation/PCI/pci-error-recovery.txt +++ b/Documen

[PATCH v14 9/9] pci-error-recovery: Add AER_FATAL handling

2018-04-23 Thread Oza Pawandeep
It adds description on AER_FATAL error handling. Signed-off-by: Oza Pawandeep diff --git a/Documentation/PCI/pci-error-recovery.txt b/Documentation/PCI/pci-error-recovery.txt index 0b6bb3e..688b691 100644 --- a/Documentation/PCI/pci-error-recovery.txt +++ b/Documentation/PCI/pci-error

  1   2   3   4   5   >