RE: [PATCH v3 3/8] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system

> > +static int initialize_mem_bw_imc(void) > > +{ > > + int imc, j; > > + > > + imcs = num_of_imcs(); > > + if (imcs < 0) > > I think this condition should be "<=". Pls check. Thank you for pointing it out. It makes sense to change it to "<=". Will fix it in next version. > > +

RE: [PATCH v3 4/8] selftests/resctrl: Add callback to start a benchmark

> > +static int > > +measure_vals(struct resctrl_val_param *param, unsigned long > > +*bw_resc_start) { > > + unsigned long bw_imc, bw_resc, bw_resc_end; > > + int ret; > > + > > + /* > > +* Measure memory bandwidth from resctrl and from > > +* another source which is perf imc value

RE: [PATCH v3 3/8] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system

> > +static int initialize_mem_bw_imc(void) > > +{ > > + int imc, j; > > + > > + imcs = num_of_imcs(); > > + if (imcs < 0) > > I think this condition should be "<=". Pls check. Thank you for pointing it out. It makes sense to change it to "<=". Will fix it in next version. > > +

RE: [PATCH v3 4/8] selftests/resctrl: Add callback to start a benchmark

> > +static int > > +measure_vals(struct resctrl_val_param *param, unsigned long > > +*bw_resc_start) { > > + unsigned long bw_imc, bw_resc, bw_resc_end; > > + int ret; > > + > > + /* > > +* Measure memory bandwidth from resctrl and from > > +* another source which is perf imc value