Re: [Xen-devel] [PATCH 1/3] x86/boot: add acpi rsdp address to setup_header

> kernel. > > For this purpose expand the struct setup_header to hold the physical > address of the RSDP address. Being zero means it isn't specified and > has to be located the legacy way (searching through low memory or > EBDA). > > Signed-off-by: Juergen Gross Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote: > The life-cycle of a PCI device in Xen pciback is complex and is constrained > by the generic PCI locking mechanism. > > - It starts with the device being bound to us, for which we do a function > reset (done via SysFS so the PCI

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote: > The life-cycle of a PCI device in Xen pciback is complex and is constrained > by the generic PCI locking mechanism. > > - It starts with the device being bound to us, for which we do a function > reset (done via SysFS so the PCI

Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device

On Wed, Sep 06, 2017 at 12:18:03PM +0200, Juergen Gross wrote: > On 05/09/17 09:28, Vincent Legout wrote: > > Hello, > > > > Sorry for such a long delay. I'm still interested in having this patch > > merged. > > > > I've tried to make the patch more generic and move it to xenbus as > > discussed

Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device

On Wed, Sep 06, 2017 at 12:18:03PM +0200, Juergen Gross wrote: > On 05/09/17 09:28, Vincent Legout wrote: > > Hello, > > > > Sorry for such a long delay. I'm still interested in having this patch > > merged. > > > > I've tried to make the patch more generic and move it to xenbus as > > discussed

Re: [Xen-devel] [PATCH 1/1] xen-blkback: stop blkback thread of every queue in xen_blkif_disconnect

On Fri, Aug 18, 2017 at 06:24:06PM +0100, Roger Pau Monné wrote: > On Fri, Aug 18, 2017 at 10:29:15AM -0400, annie li wrote: > > > > On 8/18/2017 5:14 AM, Roger Pau Monné wrote: > > > On Thu, Aug 17, 2017 at 06:43:46PM -0400, Annie Li wrote: > > > > If there i

Re: [Xen-devel] [PATCH 1/1] xen-blkback: stop blkback thread of every queue in xen_blkif_disconnect

On Fri, Aug 18, 2017 at 06:24:06PM +0100, Roger Pau Monné wrote: > On Fri, Aug 18, 2017 at 10:29:15AM -0400, annie li wrote: > > > > On 8/18/2017 5:14 AM, Roger Pau Monné wrote: > > > On Thu, Aug 17, 2017 at 06:43:46PM -0400, Annie Li wrote: > > > > If there i

Re: [Xen-devel] [PATCH 1/1] xen-blkback: stop blkback thread of every queue in xen_blkif_disconnect

On Fri, Aug 18, 2017 at 10:29:15AM -0400, annie li wrote: > > On 8/18/2017 5:14 AM, Roger Pau Monné wrote: > > On Thu, Aug 17, 2017 at 06:43:46PM -0400, Annie Li wrote: > > > If there is inflight I/O in any non-last queue, blkback returns -EBUSY > > > directly, and n

Re: [Xen-devel] [PATCH 1/1] xen-blkback: stop blkback thread of every queue in xen_blkif_disconnect

On Fri, Aug 18, 2017 at 10:29:15AM -0400, annie li wrote: > > On 8/18/2017 5:14 AM, Roger Pau Monné wrote: > > On Thu, Aug 17, 2017 at 06:43:46PM -0400, Annie Li wrote: > > > If there is inflight I/O in any non-last queue, blkback returns -EBUSY > > > directly, and n

Re: [PATCH 1/1] xen-blkback: stop blkback thread of every queue in xen_blkif_disconnect

On Thu, Aug 17, 2017 at 06:43:46PM -0400, Annie Li wrote: > If there is inflight I/O in any non-last queue, blkback returns -EBUSY > directly, and never stops thread of remaining queue and processs them. When > removing vbd device with lots of disk I/O load, some queues with inflight > I/O still

Re: [PATCH 1/1] xen-blkback: stop blkback thread of every queue in xen_blkif_disconnect

On Thu, Aug 17, 2017 at 06:43:46PM -0400, Annie Li wrote: > If there is inflight I/O in any non-last queue, blkback returns -EBUSY > directly, and never stops thread of remaining queue and processs them. When > removing vbd device with lots of disk I/O load, some queues with inflight > I/O still

Re: [PATCH] xen-blkfront: use a right index when checking requests

Eduardo Valentin <edu...@amazon.com> > Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> > Cc: Juergen Gross <jgr...@suse.com> > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > Cc: Roger Pau Monne <roger@citrix.com> > Cc: xen-de...@lists.xenproject.org > Cc: sta...@vger.kernel.org Reviewed-by: Roger Pau Monné <roger@citrix.com> Thanks, Roger.

Re: [PATCH] xen-blkfront: use a right index when checking requests

/core' of > git://git.kernel.dk/linux-block") > Fixes: 3fc9d690936f ("Merge branch 'for-4.8/drivers' of > git://git.kernel.dk/linux-block") > Signed-off-by: Munehisa Kamata > Reviewed-by: Thomas Friebel > Reviewed-by: Eduardo Valentin > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Konrad Rzeszutek Wilk > Cc: Roger Pau Monne > Cc: xen-de...@lists.xenproject.org > Cc: sta...@vger.kernel.org Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device

On Wed, Jul 05, 2017 at 03:30:00PM +0200, Vincent Legout wrote: > On Wed, Jul 05, 2017 at 06:53:25AM -0600, Jan Beulich wrote : > > >>> On 05.07.17 at 14:37, wrote: > > > On Wed, Jul 05, 2017 at 02:17:24AM -0600, Jan Beulich wrote : > > >> >>> On 05.07.17 at 10:08,

Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device

On Wed, Jul 05, 2017 at 03:30:00PM +0200, Vincent Legout wrote: > On Wed, Jul 05, 2017 at 06:53:25AM -0600, Jan Beulich wrote : > > >>> On 05.07.17 at 14:37, wrote: > > > On Wed, Jul 05, 2017 at 02:17:24AM -0600, Jan Beulich wrote : > > >> >>> On 05.07.17 at 10:08, wrote: > > >> > Without the

Re: [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device

On Tue, Jul 04, 2017 at 01:48:32PM +0200, Vincent Legout wrote: > Devices are not unmounted inside a domU after a xl block-detach. > > After xl block-detach, blkfront_closing() is called with state == > XenbusStateConnected, it detects that the device is still in use and > only switches state to

Re: [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device

On Tue, Jul 04, 2017 at 01:48:32PM +0200, Vincent Legout wrote: > Devices are not unmounted inside a domU after a xl block-detach. > > After xl block-detach, blkfront_closing() is called with state == > XenbusStateConnected, it detects that the device is still in use and > only switches state to

Re: [PATCH v2 1/1] xen/blkfront: always allocate grants first from per-queue persistent grants

> > Signed-off-by: Dongli Zhang <dongli.zh...@oracle.com> Acked-by: Roger Pau Monné <roger@citrix.com> Thanks.

Re: [PATCH v2 1/1] xen/blkfront: always allocate grants first from per-queue persistent grants

> Signed-off-by: Dongli Zhang Acked-by: Roger Pau Monné Thanks.

Re: [PATCH 1/1] xen/blkfront: always allocate grants first from per-queue persistent grants

On Wed, Jun 28, 2017 at 12:43:03PM +0800, Dongli Zhang wrote: > This patch partially reverts 3df0e50 ("xen/blkfront: pseudo support for > multi hardware queues/rings"). The xen-blkfront queue/ring might hang due > to grants allocation failure in the situation when gnttab_free_head is > almost

Re: [PATCH 1/1] xen/blkfront: always allocate grants first from per-queue persistent grants

On Wed, Jun 28, 2017 at 12:43:03PM +0800, Dongli Zhang wrote: > This patch partially reverts 3df0e50 ("xen/blkfront: pseudo support for > multi hardware queues/rings"). The xen-blkfront queue/ring might hang due > to grants allocation failure in the situation when gnttab_free_head is > almost

Re: [Xen-devel] [PATCH v4 07/18] xen/pvcalls: implement socket command

On Thu, Jun 22, 2017 at 11:29:44AM -0700, Stefano Stabellini wrote: > On Thu, 22 Jun 2017, Roger Pau Monné wrote: > > On Wed, Jun 21, 2017 at 01:16:56PM -0700, Stefano Stabellini wrote: > > > On Tue, 20 Jun 2017, Roger Pau Monné wrote: > > > > On Thu, Jun 15, 201

Re: [Xen-devel] [PATCH v4 07/18] xen/pvcalls: implement socket command

On Thu, Jun 22, 2017 at 11:29:44AM -0700, Stefano Stabellini wrote: > On Thu, 22 Jun 2017, Roger Pau Monné wrote: > > On Wed, Jun 21, 2017 at 01:16:56PM -0700, Stefano Stabellini wrote: > > > On Tue, 20 Jun 2017, Roger Pau Monné wrote: > > > > On Thu, Jun 15, 201

Re: [Xen-devel] [PATCH v4 07/18] xen/pvcalls: implement socket command

On Wed, Jun 21, 2017 at 01:16:56PM -0700, Stefano Stabellini wrote: > On Tue, 20 Jun 2017, Roger Pau Monné wrote: > > On Thu, Jun 15, 2017 at 12:09:36PM -0700, Stefano Stabellini wrote: > > > Just reply with success to the other end for now. Delay the allocation > > > o

Re: [Xen-devel] [PATCH v4 07/18] xen/pvcalls: implement socket command

On Wed, Jun 21, 2017 at 01:16:56PM -0700, Stefano Stabellini wrote: > On Tue, 20 Jun 2017, Roger Pau Monné wrote: > > On Thu, Jun 15, 2017 at 12:09:36PM -0700, Stefano Stabellini wrote: > > > Just reply with success to the other end for now. Delay the allocation > > > o

Re: [Xen-devel] [PATCH v4 07/18] xen/pvcalls: implement socket command

On Thu, Jun 15, 2017 at 12:09:36PM -0700, Stefano Stabellini wrote: > Just reply with success to the other end for now. Delay the allocation > of the actual socket to bind and/or connect. > > Signed-off-by: Stefano Stabellini > CC: boris.ostrov...@oracle.com > CC:

Re: [Xen-devel] [PATCH v4 07/18] xen/pvcalls: implement socket command

On Thu, Jun 15, 2017 at 12:09:36PM -0700, Stefano Stabellini wrote: > Just reply with success to the other end for now. Delay the allocation > of the actual socket to bind and/or connect. > > Signed-off-by: Stefano Stabellini > CC: boris.ostrov...@oracle.com > CC: jgr...@suse.com > --- >

Re: [PATCH 0/3] xen/blkback: several fixes of resource management

oss (3): > xen/blkback: fix disconnect while I/Os in flight > xen/blkback: don't free be structure too early > xen/blkback: don't use xen_blkif_get() in xen-blkback kthread All 3: Acked-by: Roger Pau Monné <roger@citrix.com> The comment reported by Dietmar in patch #1 would be nice to fix. Roger.

Re: [PATCH 0/3] xen/blkback: several fixes of resource management

oss (3): > xen/blkback: fix disconnect while I/Os in flight > xen/blkback: don't free be structure too early > xen/blkback: don't use xen_blkif_get() in xen-blkback kthread All 3: Acked-by: Roger Pau Monné The comment reported by Dietmar in patch #1 would be nice to fix. Roger.

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

og...@deltatee.com> > Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> > Cc: Juergen Gross <jgr...@suse.com> > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > Cc: "Roger Pau Monné" <roger@citrix.com> > --- > drivers/block/xen-bl

Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

c: Boris Ostrovsky > Cc: Juergen Gross > Cc: Konrad Rzeszutek Wilk > Cc: "Roger Pau Monné" > --- > drivers/block/xen-blkfront.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/drivers/block/xen-blkfront.c b/d

Re: [PATCH] xen/blkback: fix disconnect while I/Os in flight

r...@suse.com> > Tested-by: Steven Haigh <net...@crc.id.au> Acked-by: Roger Pau Monné <roger@citrix.com> TBH, it seems like all this accounting in blkback could be improved quite a lot. Right now this is just a complete caos. Thanks, Roger.

Re: [PATCH] xen/blkback: fix disconnect while I/Os in flight

nnect(): when it > returned early with -EBUSY for another ring than 0 it would call > xen_blkif_put() again for already handled rings on a subsequent call. > This will lead to inconsistencies in the refcnt handling. > > Cc: sta...@vger.kernel.org > Signed-off-by: Juergen Gross > Tested

Re: [PATCH 08/11] xen-blkfront: remove bio splitting.

On Fri, Apr 21, 2017 at 04:36:20AM -0700, Christoph Hellwig wrote: > Btw, I really don't understand why this code even looks at bios over > just requeueing the request. Can someone explain that bit to me? This was done because Linux could migrate from a host supporting indirect descriptors to a

Re: [PATCH 08/11] xen-blkfront: remove bio splitting.

On Fri, Apr 21, 2017 at 04:36:20AM -0700, Christoph Hellwig wrote: > Btw, I really don't understand why this code even looks at bios over > just requeueing the request. Can someone explain that bit to me? This was done because Linux could migrate from a host supporting indirect descriptors to a

Re: [PATCH 08/11] xen-blkfront: remove bio splitting.

f-by: NeilBrown <ne...@suse.com> Acked-by: Roger Pau Monné <roger@citrix.com> > --- > drivers/block/xen-blkfront.c | 54 > ++ > 1 file changed, 3 insertions(+), 51 deletions(-) Nice!

Re: [PATCH 08/11] xen-blkfront: remove bio splitting.

f-by: NeilBrown Acked-by: Roger Pau Monné > --- > drivers/block/xen-blkfront.c | 54 > ++ > 1 file changed, 3 insertions(+), 51 deletions(-) Nice!

Re: [Xen-devel] [PATCH 0/7] Xen transport for 9pfs frontend driver

On Tue, Mar 07, 2017 at 10:27:05AM -0800, Stefano Stabellini wrote: > On Tue, 7 Mar 2017, Roger Pau Monné wrote: > > On Mon, Mar 06, 2017 at 12:00:41PM -0800, Stefano Stabellini wrote: > > > Hi all, > > > > > > This patch series implements a new transport

Re: [Xen-devel] [PATCH 0/7] Xen transport for 9pfs frontend driver

On Tue, Mar 07, 2017 at 10:27:05AM -0800, Stefano Stabellini wrote: > On Tue, 7 Mar 2017, Roger Pau Monné wrote: > > On Mon, Mar 06, 2017 at 12:00:41PM -0800, Stefano Stabellini wrote: > > > Hi all, > > > > > > This patch series implements a new transport

Re: [Xen-devel] [PATCH 0/7] Xen transport for 9pfs frontend driver

On Mon, Mar 06, 2017 at 12:00:41PM -0800, Stefano Stabellini wrote: > Hi all, > > This patch series implements a new transport for 9pfs, aimed at Xen > systems. > > The transport is based on a traditional Xen frontend and backend drivers > pair. This patch series implements the frontend, which

Re: [Xen-devel] [PATCH 0/7] Xen transport for 9pfs frontend driver

On Mon, Mar 06, 2017 at 12:00:41PM -0800, Stefano Stabellini wrote: > Hi all, > > This patch series implements a new transport for 9pfs, aimed at Xen > systems. > > The transport is based on a traditional Xen frontend and backend drivers > pair. This patch series implements the frontend, which

Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

>> Dmitry, do we have special events for AC (un)plug? What is the best >> approach in your opinion? > > Not route them through input as they not input events would be the best. > Is my patch good enough for this or would you recommend doing it another way? > I'd look into hooking up power_supply

Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

>> Dmitry, do we have special events for AC (un)plug? What is the best >> approach in your opinion? > > Not route them through input as they not input events would be the best. > Is my patch good enough for this or would you recommend doing it another way? > I'd look into hooking up power_supply

Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

gmail.com> wrote: > > On Fri, Feb 10, 2017 at 7:48 PM, Pau Espin Pedrol <pespin.s...@gmail.com> > wrote: >> Otherwise those are printed several times when (un)plugging the AC >> connector. > > If we have a user space tool that supports them better not to ignore. > > -- > With Best Regards, > Andy Shevchenko > >

Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

10, 2017 at 7:48 PM, Pau Espin Pedrol > wrote: >> Otherwise those are printed several times when (un)plugging the AC >> connector. > > If we have a user space tool that supports them better not to ignore. > > -- > With Best Regards, > Andy Shevchenko > >

[PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

Otherwise those are printed several times when (un)plugging the AC connector. Signed-off-by: Pau Espin Pedrol <pespin.s...@gmail.com> --- drivers/platform/x86/eeepc-laptop.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86

[PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

Otherwise those are printed several times when (un)plugging the AC connector. Signed-off-by: Pau Espin Pedrol --- drivers/platform/x86/eeepc-laptop.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c index

Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

On Thu, Feb 02, 2017 at 11:30:19AM -0500, Boris Ostrovsky wrote: > On 02/02/2017 10:35 AM, Roger Pau Monné wrote: > > On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: > >> Make sure they don't use these devices since they are not emulated > >>

Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

On Thu, Feb 02, 2017 at 11:30:19AM -0500, Boris Ostrovsky wrote: > On 02/02/2017 10:35 AM, Roger Pau Monné wrote: > > On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: > >> Make sure they don't use these devices since they are not emulated > >>

Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: > Make sure they don't use these devices since they are not emulated > for unprivileged PVH guest. This description seems weird for what it's actually done. AFAICT you are not really preventing the guest from using the PIC or the IO

Re: [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: > Make sure they don't use these devices since they are not emulated > for unprivileged PVH guest. This description seems weird for what it's actually done. AFAICT you are not really preventing the guest from using the PIC or the IO

Re: [PATCH 2/3] xen: modify xenstore watch event interface

rad.w...@oracle.com > Cc: roger@citrix.com > Cc: wei.l...@citrix.com > Cc: paul.durr...@citrix.com > Cc: net...@vger.kernel.org > > Signed-off-by: Juergen Gross <jgr...@suse.com> blkback changes: Reviewed-by: Roger Pau Monné <roger@citrix.com> Thanks, Roger.

Re: [PATCH 2/3] xen: modify xenstore watch event interface

rad.w...@oracle.com > Cc: roger@citrix.com > Cc: wei.l...@citrix.com > Cc: paul.durr...@citrix.com > Cc: net...@vger.kernel.org > > Signed-off-by: Juergen Gross blkback changes: Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH] xen/blkback: use rb_entry()

On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > > To make the code clearer, use rb_entry() instead of container_of() to > > deal with rbtree. > > That is OK but I think 'container_of' is more clear. > >

Re: [PATCH] xen/blkback: use rb_entry()

On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > > To make the code clearer, use rb_entry() instead of container_of() to > > deal with rbtree. > > That is OK but I think 'container_of' is more clear. > >

Re: [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

On Wed, Oct 26, 2016 at 10:50:21AM -0400, Boris Ostrovsky wrote: > On 10/26/2016 06:42 AM, Roger Pau Monné wrote: > > On Fri, Oct 14, 2016 at 02:05:15PM -0400, Boris Ostrovsky wrote: > >> Make sure they don't use these devices since they are not emulated > >>

Re: [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

On Wed, Oct 26, 2016 at 10:50:21AM -0400, Boris Ostrovsky wrote: > On 10/26/2016 06:42 AM, Roger Pau Monné wrote: > > On Fri, Oct 14, 2016 at 02:05:15PM -0400, Boris Ostrovsky wrote: > >> Make sure they don't use these devices since they are not emulated > >>

Re: [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

On Fri, Oct 14, 2016 at 02:05:15PM -0400, Boris Ostrovsky wrote: > Make sure they don't use these devices since they are not emulated > for unprivileged PVH guest. > > Also don't initialize hypercall page for them in init_hvm_pv_info() > since this has already been done. > > Signed-off-by: Boris

Re: [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

On Fri, Oct 14, 2016 at 02:05:15PM -0400, Boris Ostrovsky wrote: > Make sure they don't use these devices since they are not emulated > for unprivileged PVH guest. > > Also don't initialize hypercall page for them in init_hvm_pv_info() > since this has already been done. > > Signed-off-by: Boris

Re: [PATCH 0096/1285] Replace numeric parameter like 0444 with macro

onding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng@intel.com> > Signed-off-by: Baole Ni <baolex...@intel.co

Re: [PATCH 0096/1285] Replace numeric parameter like 0444 with macro

onding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni Acked-by: Roger Pau Monné

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On Thu, Jul 28, 2016 at 07:05:05AM +0800, Bob Liu wrote: > > On 07/27/2016 10:24 PM, Roger Pau Monné wrote: > > On Wed, Jul 27, 2016 at 07:21:05PM +0800, Bob Liu wrote: > >> > >> On 07/27/2016 06:59 PM, Roger Pau Monné wrote: > >>> On Wed, Jul 2

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On Thu, Jul 28, 2016 at 07:05:05AM +0800, Bob Liu wrote: > > On 07/27/2016 10:24 PM, Roger Pau Monné wrote: > > On Wed, Jul 27, 2016 at 07:21:05PM +0800, Bob Liu wrote: > >> > >> On 07/27/2016 06:59 PM, Roger Pau Monné wrote: > >>> On Wed, Jul 2

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On Wed, Jul 27, 2016 at 07:21:05PM +0800, Bob Liu wrote: > > On 07/27/2016 06:59 PM, Roger Pau Monné wrote: > > On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: > > [...] > >> +static ssize_t dynamic_reconfig_device(struct blkfront_info

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On Wed, Jul 27, 2016 at 07:21:05PM +0800, Bob Liu wrote: > > On 07/27/2016 06:59 PM, Roger Pau Monné wrote: > > On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: > > [...] > >> +static ssize_t dynamic_reconfig_device(struct blkfront_info

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: [...] > +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t > count) > +{ > + /* > + * Prevent new requests even to software request queue. > + */ > + blk_mq_freeze_queue(info->rq); > + > + /* >

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: [...] > +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t > count) > +{ > + /* > + * Prevent new requests even to software request queue. > + */ > + blk_mq_freeze_queue(info->rq); > + > + /* >

Re: [PATCH v2 2/3] xen-blkfront: introduce blkif_set_queue_limits()

bob@oracle.com> Acked-by: Roger Pau Monné <roger@citrix.com> Roger.

Re: [PATCH v2 2/3] xen-blkfront: introduce blkif_set_queue_limits()

On Tue, Jul 26, 2016 at 01:19:36PM +0800, Bob Liu wrote: > blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not > as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits > with initial correct values. > > Signed-off-by: Bob Liu Acke

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On Wed, Jul 27, 2016 at 05:12:22PM +0800, Bob Liu wrote: > > On 07/27/2016 04:07 PM, Roger Pau Monné wrote: > ..[snip].. > >> @@ -2443,6 +2674,22 @@ static void blkfront_connect(struct blkfront_info > >> *info) > >>return; > >>} > &

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On Wed, Jul 27, 2016 at 05:12:22PM +0800, Bob Liu wrote: > > On 07/27/2016 04:07 PM, Roger Pau Monné wrote: > ..[snip].. > >> @@ -2443,6 +2674,22 @@ static void blkfront_connect(struct blkfront_info > >> *info) > >>return; > >>} > &

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

Hello, Thanks for the fixes. On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: > The current VBD layer reserves buffer space for each attached device based on > three statically configured settings which are read at boot time. > * max_indirect_segs: Maximum amount of segments. > *

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

Hello, Thanks for the fixes. On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: > The current VBD layer reserves buffer space for each attached device based on > three statically configured settings which are read at boot time. > * max_indirect_segs: Maximum amount of segments. > *

Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Tue, Jul 26, 2016 at 04:58:10PM +0800, Bob Liu wrote: > > On 07/26/2016 04:44 PM, Roger Pau Monné wrote: > > On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote: > >> The current VBD layer reserves buffer space for each attached device based > >> on &g

Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Tue, Jul 26, 2016 at 04:58:10PM +0800, Bob Liu wrote: > > On 07/26/2016 04:44 PM, Roger Pau Monné wrote: > > On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote: > >> The current VBD layer reserves buffer space for each attached device based > >> on &g

Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote: > The current VBD layer reserves buffer space for each attached device based on > three statically configured settings which are read at boot time. > * max_indirect_segs: Maximum amount of segments. > * max_ring_page_order: Maximum order

Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote: > The current VBD layer reserves buffer space for each attached device based on > three statically configured settings which are read at boot time. > * max_indirect_segs: Maximum amount of segments. > * max_ring_page_order: Maximum order

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote: > > On 07/25/2016 06:53 PM, Roger Pau Monné wrote: > ..[snip..] > >>>> * We get the device lock and blk_mq_freeze_queue() in > >>>> dynamic_reconfig_device(), > >>>>and then h

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote: > > On 07/25/2016 06:53 PM, Roger Pau Monné wrote: > ..[snip..] > >>>> * We get the device lock and blk_mq_freeze_queue() in > >>>> dynamic_reconfig_device(), > >>>>and then h

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Mon, Jul 25, 2016 at 06:29:22PM +0800, Bob Liu wrote: > > On 07/25/2016 05:20 PM, Roger Pau Monné wrote: > > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > >>> On Fri, Jul 2

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Mon, Jul 25, 2016 at 06:29:22PM +0800, Bob Liu wrote: > > On 07/25/2016 05:20 PM, Roger Pau Monné wrote: > > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > >>> On Fri, Jul 2

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: > > On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > >>> On Fri, Jul 2

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: > > On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > >>> On Fri, Jul 2

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > > On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > > On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > >>> On Thu, Jul 2

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > > On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > > On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > >>> On Thu, Jul 2

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: > > On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > > On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: > >> > >> On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > ..[snip].. > >>>>

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: > > On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > > On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: > >> > >> On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > ..[snip].. > >>>>

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: > > On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > > On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: > >> The current VBD layer reserves buffer space for each attached device based > >> on &g

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: > > On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > > On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: > >> The current VBD layer reserves buffer space for each attached device based > >> on &g

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: > The current VBD layer reserves buffer space for each attached device based on > three statically configured settings which are read at boot time. > * max_indirect_segs: Maximum amount of segments. > * max_ring_page_order: Maximum order

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: > The current VBD layer reserves buffer space for each attached device based on > three statically configured settings which are read at boot time. > * max_indirect_segs: Maximum amount of segments. > * max_ring_page_order: Maximum order

Re: [PATCH 2/3] xen-blkfront: introduce blkif_set_queue_limits()

On Fri, Jul 15, 2016 at 05:31:48PM +0800, Bob Liu wrote: > blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not > as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits > with initial correct values. Hm, great, and as usual in Linux there isn't

Re: [PATCH 2/3] xen-blkfront: introduce blkif_set_queue_limits()

On Fri, Jul 15, 2016 at 05:31:48PM +0800, Bob Liu wrote: > blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not > as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits > with initial correct values. Hm, great, and as usual in Linux there isn't

Re: [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity

On Fri, Jul 15, 2016 at 05:31:47PM +0800, Bob Liu wrote: > Two places didn't get updated when 64KB page granularity was introduced, this > patch fix them. > > Signed-off-by: Bob Liu <bob@oracle.com> Acked-by: Roger Pau Monné <roger@citrix.com>

Re: [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity

On Fri, Jul 15, 2016 at 05:31:47PM +0800, Bob Liu wrote: > Two places didn't get updated when 64KB page granularity was introduced, this > patch fix them. > > Signed-off-by: Bob Liu Acked-by: Roger Pau Monné

Re: [PATCH] xen-blkfront: avoid NULL de-reference in CDROM ioctl handling

On Thu, Jul 07, 2016 at 03:42:02AM -0600, Jan Beulich wrote: > >>> On 07.07.16 at 11:32, wrote: > > On Thu, Jul 07, 2016 at 01:40:54AM -0600, Jan Beulich wrote: > >> The ioctl can be called prior to full device setup having completed. > >> > >> Signed-off-by: Jan Beulich

Re: [PATCH] xen-blkfront: avoid NULL de-reference in CDROM ioctl handling

On Thu, Jul 07, 2016 at 03:42:02AM -0600, Jan Beulich wrote: > >>> On 07.07.16 at 11:32, wrote: > > On Thu, Jul 07, 2016 at 01:40:54AM -0600, Jan Beulich wrote: > >> The ioctl can be called prior to full device setup having completed. > >> > >> Signed-off-by: Jan Beulich > >> --- > >>

Re: [PATCH] xen-blkback: constify instance of "struct attribute_group"

On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: > The functions such get passed to have been taking pointers to const > since at least 2.6.16. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Acked-by: Roger Pau Monné <roger@citrix.com> Although t

Re: [PATCH] xen-blkback: constify instance of "struct attribute_group"

On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: > The functions such get passed to have been taking pointers to const > since at least 2.6.16. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Although the wording in the commit message looks weird to

Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible

On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote: > ... as being the simpler variant. > > Signed-off-by: Jan Beulich > --- > drivers/block/xen-blkfront.c |7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > ---

<    1   2   3   4   5   6   7   8   9   10   >