Signed-off-by: Roger Pau Monné roger@citrix.com
Cc: Huang Ying ying.hu...@intel.com
Cc: Konrad Rzeszutek Wilk kon...@kernel.org
---
include/linux/llist.h | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/include/linux/llist.h b/include/linux
Change foreach_grant iterator to a safe version, that allows freeing
the element while iterating. Also move the free code in
free_persistent_gnts to prevent freeing the element before the rb_next
call.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Roger Pau Monné roger
Use llist_for_each_entry_safe in blkif_free. Previously grants where
freed while iterating the list, which lead to dereferences when trying
to fetch the next item.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Roger Pau Monné roger@citrix.com
Cc: Konrad Rzeszutek Wilk kon
Signed-off-by: Roger Pau Monné
Cc: linux-kernel@vger.kernel.org
Cc: Konrad Rzeszutek Wilk
---
drivers/block/xen-blkfront.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index df21b05..860f76d 100644
konrad.w...@oracle.com
Signed-off-by: Roger Pau Monné roger@citrix.com
Cc: linux-kernel@vger.kernel.org
Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com
---
drivers/block/xen-blkfront.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b
Implement a safe version of llist_for_each_entry, and use it in
blkif_free. Previously grants where freed while iterating the list,
which lead to dereferences when trying to fetch the next item.
Reported-by: Dan Carpenter
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de
Change foreach_grant iterator to a safe version, that allows freeing
the element while iterating. Also move the free code in
free_persistent_gnts to prevent freeing the element before the rb_next
call.
Reported-by: Dan Carpenter
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen
Change foreach_grant iterator to a safe version, that allows freeing
the element while iterating. Also move the free code in
free_persistent_gnts to prevent freeing the element before the rb_next
call.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Roger Pau Monné roger
Implement a safe version of llist_for_each_entry, and use it in
blkif_free. Previously grants where freed while iterating the list,
which lead to dereferences when trying to fetch the next item.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Roger Pau Monné roger
Move the code that frees persistent grants from the red-black tree
to a function. This will make it easier for other consumers to move
this to a common place.
Signed-off-by: Roger Pau Monné
---
drivers/block/xen-blkback/blkback.c | 68 +++
1 files changed, 37
Free the page allocated for the persistent grant.
Signed-off-by: Roger Pau Monné
---
drivers/block/xen-blkfront.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index f1de806..96e9b00 100644
--- a/drivers
Free the page allocated for the persistent grant.
Signed-off-by: Roger Pau Monné roger@citrix.com
---
drivers/block/xen-blkfront.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index f1de806..96e9b00
Move the code that frees persistent grants from the red-black tree
to a function. This will make it easier for other consumers to move
this to a common place.
Signed-off-by: Roger Pau Monné roger@citrix.com
---
drivers/block/xen-blkback/blkback.c | 68 +++
1
On 02/11/12 18:05, Konrad Rzeszutek Wilk wrote:
> On Fri, Nov 02, 2012 at 04:43:04PM +0100, Roger Pau Monne wrote:
>> This patch contains fixes for persistent grants implementation v2:
>>
>> * handle == 0 is a valid handle, so initialize grants in blkback
>
ke sure we don't try to
access segments that have not been set.
Signed-off-by: Roger Pau Monne
Cc:
Cc:
---
drivers/block/xen-blkback/blkback.c | 15 +--
drivers/block/xen-blkback/xenbus.c |2 +-
drivers/block/xen-blkfront.c|3 ++-
3 files changed, 12 insertions(+), 8 dele
segments that have not been set.
Signed-off-by: Roger Pau Monne roger@citrix.com
Cc: konrad.w...@oracle.com
Cc: linux-kernel@vger.kernel.org
---
drivers/block/xen-blkback/blkback.c | 15 +--
drivers/block/xen-blkback/xenbus.c |2 +-
drivers/block/xen-blkfront.c|3
On 02/11/12 18:05, Konrad Rzeszutek Wilk wrote:
On Fri, Nov 02, 2012 at 04:43:04PM +0100, Roger Pau Monne wrote:
This patch contains fixes for persistent grants implementation v2:
* handle == 0 is a valid handle, so initialize grants in blkback
setting the handle to BLKBACK_INVALID_HANDLE
est of using persistent grants. There is
perhaps a small saving, from the reduced number of hypercalls
performed in granting, and ending foreign access.
Signed-off-by: Oliver Chick
Signed-off-by: Roger Pau Monne
Cc:
Cc:
---
Changes since v1:
* Changed the unmap_seg array to a bitmap.
* O
On 24/10/12 14:40, liuxiaolei1124 wrote:
> Dear Roger:
>
> i have put the patch "Persistent grant maps for xen blk drivers"
> (https://lkml.org/lkml/2012/10/18/191) into my Dom0 which is 2.6.32.36.
> And when i start a vm, sometimes the blkback go to the BUG_ON.
I'm working on top of the
On 23/10/12 20:50, Konrad Rzeszutek Wilk wrote:
> On Tue, Oct 23, 2012 at 08:09:27PM +0200, Roger Pau Monné wrote:
>> On 23/10/12 19:20, Konrad Rzeszutek Wilk wrote:
>>>>>> diff --git a/drivers/block/xen-blkback/blkback.c
>>>>>> b/drivers/block/xen-bl
On 23/10/12 20:50, Konrad Rzeszutek Wilk wrote:
On Tue, Oct 23, 2012 at 08:09:27PM +0200, Roger Pau Monné wrote:
On 23/10/12 19:20, Konrad Rzeszutek Wilk wrote:
diff --git a/drivers/block/xen-blkback/blkback.c
b/drivers/block/xen-blkback/blkback.c
index c6decb9..2b982b2 100644
--- a/drivers
On 24/10/12 14:40, liuxiaolei1124 wrote:
Dear Roger:
i have put the patch Persistent grant maps for xen blk drivers
(https://lkml.org/lkml/2012/10/18/191) into my Dom0 which is 2.6.32.36.
And when i start a vm, sometimes the blkback go to the BUG_ON.
I'm working on top of the next
of using persistent grants. There is
perhaps a small saving, from the reduced number of hypercalls
performed in granting, and ending foreign access.
Signed-off-by: Oliver Chick oliver.ch...@citrix.com
Signed-off-by: Roger Pau Monne roger@citrix.com
Cc: konrad.w...@oracle.com
Cc: linux-kernel
On 23/10/12 19:20, Konrad Rzeszutek Wilk wrote:
diff --git a/drivers/block/xen-blkback/blkback.c
b/drivers/block/xen-blkback/blkback.c
index c6decb9..2b982b2 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -78,6 +78,7 @@
On 22/10/12 15:47, Konrad Rzeszutek Wilk wrote:
> On Thu, Oct 18, 2012 at 01:22:01PM +0200, Roger Pau Monne wrote:
>> This patch implements persistent grants for the xen-blk{front,back}
>> mechanism. The effect of this change is to reduce the number of unmap
>> operat
On 22/10/12 15:47, Konrad Rzeszutek Wilk wrote:
On Thu, Oct 18, 2012 at 01:22:01PM +0200, Roger Pau Monne wrote:
This patch implements persistent grants for the xen-blk{front,back}
mechanism. The effect of this change is to reduce the number of unmap
operations performed, since they cause
On 23/10/12 19:20, Konrad Rzeszutek Wilk wrote:
diff --git a/drivers/block/xen-blkback/blkback.c
b/drivers/block/xen-blkback/blkback.c
index c6decb9..2b982b2 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -78,6 +78,7 @@ struct pending_req {
On 19/10/12 03:34, James Harper wrote:
>>
>> This patch implements persistent grants for the xen-blk{front,back}
>> mechanism. The effect of this change is to reduce the number of unmap
>> operations performed, since they cause a (costly) TLB shootdown. This allows
>> the I/O performance to scale
On 19/10/12 03:34, James Harper wrote:
This patch implements persistent grants for the xen-blk{front,back}
mechanism. The effect of this change is to reduce the number of unmap
operations performed, since they cause a (costly) TLB shootdown. This allows
the I/O performance to scale better
all saving, from the reduced number of hypercalls
performed in granting, and ending foreign access.
Signed-off-by: Oliver Chick
Signed-off-by: Roger Pau Monne
Cc:
Cc:
---
Benchmarks showing the impact of this patch in blk performance can be
found at:
http://xenbits.xensource.com/people/roy
saving, from the reduced number of hypercalls
performed in granting, and ending foreign access.
Signed-off-by: Oliver Chick oliver.ch...@citrix.com
Signed-off-by: Roger Pau Monne roger@citrix.com
Cc: konrad.w...@oracle.com
Cc: linux-kernel@vger.kernel.org
---
Benchmarks showing the impact
On 24/09/12 13:36, Jan Beulich wrote:
On 21.09.12 at 17:52, Oliver Chick wrote:
>> Changes since v1:
>>
>> * Maximum number of persistent grants per device now 64, rather than
>>256, as this is the actual maxmimum request in a (1 page) ring.
>
> As said previously, I don't see why this
On 24/09/12 13:36, Jan Beulich wrote:
On 21.09.12 at 17:52, Oliver Chick oliver.ch...@citrix.com wrote:
Changes since v1:
* Maximum number of persistent grants per device now 64, rather than
256, as this is the actual maxmimum request in a (1 page) ring.
As said previously, I don't see
David Vrabel wrote:
> On 09/07/12 15:45, Konrad Rzeszutek Wilk wrote:
>> On Fri, Jun 22, 2012 at 05:14:41PM +0100, Stefano Stabellini wrote:
>>> We used to rely on a core_initcall to initialize Xen on ARM, however
>>> core_initcalls are actually called after early consoles are initialized.
>>>
David Vrabel wrote:
On 09/07/12 15:45, Konrad Rzeszutek Wilk wrote:
On Fri, Jun 22, 2012 at 05:14:41PM +0100, Stefano Stabellini wrote:
We used to rely on a core_initcall to initialize Xen on ARM, however
core_initcalls are actually called after early consoles are initialized.
That means that
6 detailed in this thread:
http://kerneltrap.org/node/4940
I don't want at all to justify it with the change you talk about in gas,
but maybe it is worth to check if it has anything to do with it. The
slowdown happened in this last six months.
--
Pau
-
To unsubscribe from this list: send the line &q
uld this be the reason for the reported slowdown in the last six months?
--
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
?
--
Pau
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
in this thread:
http://kerneltrap.org/node/4940
I don't want at all to justify it with the change you talk about in gas,
but maybe it is worth to check if it has anything to do with it. The
slowdown happened in this last six months.
--
Pau
-
To unsubscribe from this list: send the line unsubscribe linux
, you still have to unload the card and reload it again to get back
the network working. I'm using hotplug.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-inf
still have to unload the card and reload it again to get back
the network working. I'm using hotplug.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Here's is the trace of a nautilus process in D state.
I'm rebooting now in 2.4.3-ac2 to see if it still happens.
Pau
trace.bz2
/bin/galeon-bin
This didn't happen neither with 2.4.2 nor with 2.4.3-pre7; I'm not sure
about pre8.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.h
/bin/galeon-bin
This didn't happen neither with 2.4.2 nor with 2.4.3-pre7; I'm not sure
about pre8.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.h
Here's is the trace of a nautilus process in D state.
I'm rebooting now in 2.4.3-ac2 to see if it still happens.
Pau
trace.bz2
ally linked.
I've been sent this patch by Eran Mann that adds net_init.o to the
exported objects in the net Makefile.
Still untested ;)
Pau
--- linux/kernel/nous_kernels/linux/drivers/net/Makefile.oldWed Mar 28 16:21:20
2001
+++ linux/kernel/nous_kernels/linux/drivers/net/MakefileW
this patch by Eran Mann that adds net_init.o to the
exported objects in the net Makefile.
Still untested ;)
Pau
--- linux/kernel/nous_kernels/linux/drivers/net/Makefile.oldWed Mar 28 16:21:20
2001
+++ linux/kernel/nous_kernels/linux/drivers/net/MakefileWed Mar 28 16:21:46
+2001
I've tried 2.4.2-ac26 to test the new xircom_cb driver but I have had to
reboot on 2.4.3-pre7 as some processes got stuck on D state.
The processes were large apps: once nautilus and once mozilla.
I couldn't get any other information.
Pau
-
To unsubscribe from this list: send the line
I've tried 2.4.2-ac26 to test the new xircom_cb driver but I have had to
reboot on 2.4.3-pre7 as some processes got stuck on D state.
The processes were large apps: once nautilus and once mozilla.
I couldn't get any other information.
Pau
-
To unsubscribe from this list: send the line
sically with NFS, but also when moving high
amount of Mb in the LAN.
I've moved from pcmcia-cs to hotplug and it works too :)
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vg
ave
> CONFIG_SERIAL enabled, along with hotplugging support etc.
In fact it does. I discovered it last weekend when my modem -them same one
than Alessandro's- stopped working.
Removing "alias char-major-4 serial_cb" from modules.conf did the trick
and the serial driver worked flawlessly
I've been running 2.4.3-pre4 for a few days now and today I've got this
message in the logs a couple of times. Is it harmless?
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo inf
I've been running 2.4.3-pre4 for a few days now and today I've got this
message in the logs a couple of times. Is it harmless?
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo inf
it does. I discovered it last weekend when my modem -them same one
than Alessandro's- stopped working.
Removing "alias char-major-4 serial_cb" from modules.conf did the trick
and the serial driver worked flawlessly. Modules serial got loaded
instead.
Pau
-
To unsubscribe from this
ount of Mb in the LAN.
I've moved from pcmcia-cs to hotplug and it works too :)
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please r
ias eth0 xircom_tulip_cb
and when this happens -90% if times when I boot and 100% of time when I
awake after a sleep- I just do the following:
ifconfig eth0 -promisc
and it works again.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
this happens -90% if times when I boot and 100% of time when I
awake after a sleep- I just do the following:
ifconfig eth0 -promisc
and it works again.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majo
p;& ifconfig eth0 -promisc
Any hints?
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
]: Leaving directory `/usr/src/linux/drivers/md'
make[1]: *** [_modsubdir_md] Error 2
make[1]: Leaving directory `/usr/src/linux/drivers'
make: *** [_mod_drivers] Error 2
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
P
]: Leaving directory `/usr/src/linux/drivers/md'
make[1]: *** [_modsubdir_md] Error 2
make[1]: Leaving directory `/usr/src/linux/drivers'
make: *** [_mod_drivers] Error 2
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
P
-promisc
Any hints?
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
3952 2 [maestro]
uhci 18672 0 (unused)
usbcore52304 2 [uhci]
Thanks for your help
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
[maestro]
uhci 18672 0 (unused)
usbcore52304 2 [uhci]
Thanks for your help
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
depmod: *** Unresolved symbols in
/lib/modules/2.4.0-prerelease/kernel/drivers/net/irda/toshoboe.o
depmod: __bad_udelay
depmod: *** Unresolved symbols in
/lib/modules/2.4.0-prerelease/kernel/drivers/video/atyfb.o
depmod: __bad_udelay
Pau
-
To unsubscribe from this list: send
depmod: *** Unresolved symbols in
/lib/modules/2.4.0-prerelease/kernel/drivers/net/irda/toshoboe.o
depmod: __bad_udelay
depmod: *** Unresolved symbols in
/lib/modules/2.4.0-prerelease/kernel/drivers/video/atyfb.o
depmod: __bad_udelay
Pau
-
To unsubscribe from this list: send
Have a nice and happy new year's eve everybody.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Have a nice and happy new year's eve everybody.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
ch PDA do you have running Linux and worth a few bucks?
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
have running Linux and worth a few bucks?
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
I want to plug a linux box as a router for the ADSL line I've got at home.
My provider uses IP over ATM (not pppoe). I'd like to buy a suitable and
cheap ATM/ADSL card, up to 2Mb (no need for 155 Mbps speeds :) and an
advice about the kernel to use. Any hints?
Thx for your help
Pau
I want to plug a linux box as a router for the ADSL line I've got at home.
My provider uses IP over ATM (not pppoe). I'd like to buy a suitable and
cheap ATM/ADSL card, up to 2Mb (no need for 155 Mbps speeds :) and an
advice about the kernel to use. Any hints?
Thx for your help
Pau
On Thu, 19 Oct 2000, Pau wrote:
> I've compiled and installed test10-pre4 in my laptop and I have had to
> reboot 4 times in less than a day.
>
> sysrq key is working so I attach some traces.
Sorry to follow up my self but... definately it happens when it starts
swappin
I've compiled and installed test10-pre4 in my laptop and I have had to
reboot 4 times in less than a day.
sysrq key is working so I attach some traces.
If something more is needed just tell me.
Pau
Oct 19 11:02:45 pau kernel: kernel BUG at vmscan.c:102!
Oct 19 11:02:45 pau kernel: invalid
I've compiled and installed test10-pre4 in my laptop and I have had to
reboot 4 times in less than a day.
sysrq key is working so I attach some traces.
If something more is needed just tell me.
Pau
Oct 19 11:02:45 pau kernel: kernel BUG at vmscan.c:102!
Oct 19 11:02:45 pau kernel: invalid
On Thu, 19 Oct 2000, Pau wrote:
I've compiled and installed test10-pre4 in my laptop and I have had to
reboot 4 times in less than a day.
sysrq key is working so I attach some traces.
Sorry to follow up my self but... definately it happens when it starts
swapping. Something is not right
what do you see after the system 'hangs' and
> you type sysrq-T, sysrq-M and/or sysrq-P ?
I wrote a message yesterday with the same problem. test8 works ok but
test9-pre? hang when quickly keying while expunging a mailbox.
Only sysrq-o (power down) responds. No oops.
Pau
-
To unsubsc
901 - 976 of 976 matches
Mail list logo
