nly code.)
> +MODULE_DESCRIPTION("Freescale VF610 SoC bus driver");
> +MODULE_LICENSE("GPL v2");
I think soc-vf610.o can only be built-in. But its code contains a few
module specific macros. Was it perhaps intended for SOC_VF610 to be
tristate?
Paul Bolle
--
To unsubscribe
ING OUT OF
> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
I have no idea which license this is.
> +MODULE_LICENSE("GPL");
But I do know that it's not GPL v2 or later (see
include/linux/module.h).
Paul Bolle
--
To unsubscribe from this list: send the
On Wed, 2015-05-27 at 08:15 +0200, Robert Jarzmik wrote:
> Paul Bolle writes:
> > Was it actually intended for PXA_DMA to be tristate?
> It is designed to be a module, and in the "end" it will be a module.
>
> What is important to understand is the 3 phases which are
");
> +MODULE_LICENSE("GPL v2");
This patch added a bool Kconfig symbol. So pxa_dma.c will never be part
of a module. Its code contains a few module specific macros. Was it
actually intended for PXA_DMA to be tristate?
Paul Bolle
--
To unsubscribe from this list: send the line
On Mon, 2015-05-25 at 12:06 -0700, Josh Triplett wrote:
> On Mon, May 25, 2015 at 08:25:35PM +0200, Paul Bolle wrote:
> > On Mon, 2015-05-25 at 10:54 -0700, Josh Triplett wrote:
> For clarity: "recursive dependency resolution" as in "recursive
> resolution of dep
ch for that symbol, remember the path the
> search showed, and browse there manually.
Probably. I'd rather not think about the UI involved when the symbol(s)
that should be enabled is (are) two or more levels down the chain. And
the odd "stacked" UI for searches in the curses t
On Fri, 2015-05-22 at 11:52 -0700, Dmitry Torokhov wrote:
> selects still don't cascade down - right?
select statements trigger the select statements of the selected symbol,
if that's what you mean.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe li
I'm no kconfig expert and I wondered the same.
>
> Perhaps Paul can elaborate.
Because both the dependencies of a symbol and the select statements on
that symbol influence the set of values that is possible for that
symbol.
Paul Bolle
--
To unsubscribe from this list: send the line &quo
kes it run in circles?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
EXPERT.
If EXPERT really turns out to be set on most distributions it will have
gone the way of EXPERIMENTAL: a warning sign that lost its impact
through overuse. Perhaps that's the way these things go. But I don't
think that has happened with EXPERT, not yet.
Paul Bolle
--
To unsubscr
t used in the MODULE_LICENSE() macro should change.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
r, sent out notifications that were flat out wrong. But yes, some
issues can be expected to get resolved given a bit of time. The hard
part is knowing beforehand which issues will be resolved quickly and
which won't.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line &qu
n, either version 2 of the License, or
> + * (at your option) any later version.
> +MODULE_LICENSE("GPL v2");
As I said in the message I sent a short while ago: here too I think that
either the comment at the top of this file or the ident used in the
MODULE_LICENSE() macro needs t
is
just GPL v2. So I think that either the comment at the top of this file
or the ident used in the MODULE_LICENSE() macro needs to change.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vge
link to the patch that adds the missing symbol.
It's a bit annoying. But it helps in catching errors as early as
possible. And it gives the people looking into these kconfig oddities
the info they need to keep track of things.
Paul Bolle
--
To unsubscribe from this list: send the line "u
t of a gotcha. A patch that would have helped here was
posted in https://lkml.org/lkml/2015/4/7/824 . I don't know why that
patch didn't make it into checkpatch.pl. Bjorn?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
t too far. "claims" or "stated"?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, 2015-05-22 at 10:44 +0200, Takashi Iwai wrote:
> At Fri, 22 May 2015 10:17:48 +0200,
> Paul Bolle wrote:
> > Luis also tried to explain to me that disabling FW_LOADER shouldn't make
> > the build fail. (And, of course, we could decide to not care about
> >
code if it's already in the tree, to know the
intentions of the author. Did the author intend the code to be built-in
only or not?
And since most people appear not to be clairvoyant that's kind of hard
to do for most of us.
Paul Bolle
--
To unsubscribe from this list: send the line
take it out. Otherwise, I'll leave it as it is.
Sure. It's the maintainer's decision, at the end of the day.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More maj
h
> has unmet direct dependencies (USB_SUPPORT && USB && PM)
> warning: (SND_SOC_INTEL_BYTCR_RT5640_MACH &&
> SND_SOC_INTEL_CHT_BSW_RT5672_MACH && SND_SOC_INTEL_CHT_BSW_RT5645_MACH)
> selects SND_SST_IPC_ACPI which has unmet direct dependencies (SOUND && !M68K
> &a
CONFIG_EXPERT=n
> CONFIG_MY_CRITICAL_FEATURE=y
> ...
> $
>
> and use "make randconfig KCONFIG_ALLCONFIG=1".
Booting (truly) randconfig builds is like booting allyesconfig or
allnoconfig builds: no one sane should do that, right?
Paul Bolle
--
To unsubscribe from this
On Thu, 2015-05-21 at 10:09 +, yga...@codeaurora.org wrote:
> > On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote:
> > Am I missing something obvious here? Because ufs-qcom currently looks
> > pointless to me, and I actually see little reason to even have it in the
If unsure, say N.
(Please start the indentation with a tab, and not with spaces.)
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/m
exercises the scratchpads and
> +doorbells of the ntb hardware. This driver may be used to test that
> +your ntb hardware and drivers are functioning at a basic level.
> +
> +If unsure, say N.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the
NTB_INTEL
> + tristate "Intel Non-Transparent Bridge support"
> + depends on NTB
Ditto.
> + depends on X86
> + help
> +This driver supports Intel NTB on capable Xeon and Atom hardware.
> +
> +If unsure, say N.
Thanks,
Paul Bol
ys.o can now only be built-in I think the above module specific
macros can safely be dropped. Probably ditto for the module.h include.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
de MODULE_LICENSE() will be effectively
preprocessed away. So you can drop that macro, and the include of
linux/module.h too. (I did a quick compile to see if nothing else
requires module.h, and it compiled cleanly without that include.)
Thanks,
Paul Bolle
--
To unsubscribe from this list: s
of_match_table = cygnus_pcie_phy_match_table,
> + },
> + .probe = cygnus_pcie_phy_probe,
> +};
> +module_platform_driver(cygnus_pcie_phy_driver);
> +
> +MODULE_AUTHOR("Ray Jui ");
> +MODULE_DESCRIPTION("Broadcom Cygnus PCIe PHY driver");
> +MODULE_
uilt-in only. If that's
correct the above three MODULE_ macros (and, probably, the include of
linux/module.h) can safely be dropped.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
amp;&
> + info->params.device_path_info_lenght != 36)
Did this compile?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majord
On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote:
> By the way, as far as I can see, this (new) module can only be loaded
> manually (or via scripts). Is that what people want?
This comment wasn't well thought through. So I hand another look at the
code of usf-qcom.
I noticed that
arch//Kconfig by:
> select HAVE_EARLY_PCI if PCI
That makes more sense. So v4 will put HAVE_EARLY_PCI in a Kconfig under
drivers/pci/?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.or
"default y" or are determined by some other
> expression.
No one has reacted so far. So my plan to have the other people on
linux-kbuild do the work here is not going as I'd hoped. Bother...
I seem to remember that you had a list of three dozen menuconfig
instances that ran into
On Tue, 2015-05-19 at 10:32 -0700, Bin Gao wrote:
> On Tue, May 19, 2015 at 02:01:07PM +0200, Paul Bolle wrote:
> > Is this expected to be used outside of X86?
> Yes, drivers/tty/serial/serial_core.c is going to use it.
What I should have asked is: do you expect architectures other
elp for EXPERT is pretty
clear. But I do wonder if this is a first or if this has been done
before (ie, whether there's a precedent). Because, generally speaking,
people try rather hard to prevent pointless configurations.
Paul Bolle
--
To unsubscribe from this list: send the line "un
think get_android_boot_dev() could be marked __init. Because if
it's built-in it will never be called after the kernel has finished
booting, right?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kern
On Wed, 2015-05-20 at 09:21 +0200, Paul Bolle wrote:
> As far as I can see, in next-20150519, drivers/scsi/ufs/ufs-qcom.c lacks
> the required module specific boilerplate for this to be useful. Is that
> boilerplate added in another series?
I need to rephrase this. Let me try again.
As
qcom.ko]
> undefined!
> ERROR: "ufs_qcom_phy_save_controller_version" [drivers/scsi/ufs/ufs-qcom.ko]
> undefined!
> ERROR: "ufs_qcom_phy_enable_iface_clk" [drivers/scsi/ufs/ufs-qcom.ko]
> undefined!
> make[1]: *** [__modpost] Error 1
Thanks,
Paul Bolle
--
-20150519, drivers/scsi/ufs/ufs-qcom.c lacks
the required module specific boilerplate for this to be useful. Is that
boilerplate added in another series?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord..
ays evaluates to true, so it might not be needed.
Running
scripts/checkkconfigsymbols.py --diff $sha1..$sha2
helps catching typos like this.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.or
Is the -mod
extension needed because a module built from multiple files can't have a
name that matches the name of one of its .c files (minus the .c
extension, of course)?
> obj-$(CONFIG_EXYNOS_LCD_S6E8AX0) += s6e8ax0.o
Thanks,
Paul Bolle
--
To unsubscribe from this list: se
in
> + asm/pci-direct.h) so the kernel can access pci config registers
> + before the PCI subsystem is initialized. Any arch that supports
Is this expected to be used outside of X86?
> + early pci APIs must enable this option which is required by arch
> + indepe
change nothing for those other architectures?
> #endif
>
> diff --git a/init/main.c b/init/main.c
> index 2115055..a7d0129 100644
> -bool initcall_debug;
> -core_param(initcall_debug, initcall_debug, bool, 0644);
> +DEFINE_CORE_PARAM(initcall_debug, initcall_debug, false
the patch is x86 specific. Than it should
have, say, "x86:" as a prefix and it should be sent to the people and
lists taking care of x86.
But a quick grep suggests it's not OK to disable this for all other
architectures. Did I miss something with that quick grep?
Thanks,
Paul Bol
On Tue, 2015-05-19 at 02:09 +0200, Luis R. Rodriguez wrote:
> On Mon, May 18, 2015 at 10:45:30PM +0200, Paul Bolle wrote:
> > [...] so, probably, almost
> > all .config files have FW_LOADER set. So I think, except for some corner
> > cases, either converting all "select
Hi Luis,
On Mon, 2015-05-18 at 22:01 +0200, Luis R. Rodriguez wrote:
> On Thu, May 07, 2015 at 08:06:35PM +0200, Paul Bolle wrote:
> > See, FW_LOADER is 'y' unless EXPERT is set and one goes to the trouble
> > of setting FW_LOADER to 'n'. So in the 100+ pla
t;);
And, according to include/linux/module.h, this states the license is
just GPL v2. So I think that either the license used in the comment at
the top of those files or the ident used in the MODULE_LICENSE() macro
needs to change.
Ditto for the thunder_bgx.ko and the nicvf.ko module.
Thanks,
On Mon, 2015-05-18 at 10:43 +0300, Andrey Ryabinin wrote:
> On 05/16/2015 02:27 PM, Paul Bolle wrote:
> > So perhaps the
> > default line should actually read
> > default 0xdc00 if KASAN
> >
> > after the move. Would that work?
>
> Yes, b
think that either the comment at the top of this file or the
ident used in the MODULE_LICENSE() macro needs to change.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:
/5/10/125 .)
> +MODULE_DESCRIPTION("ETRAX FS GPIO driver");
> +MODULE_LICENSE("GPL");
But the code this patch adds contains a bit of module specific
boilerplate. Was it perhaps your intention to make GPIO_ETRAXFS
tristate?
Paul Bolle
--
To unsubscribe from this list: send the l
capability of the device.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
are guarded by #ifdef CONFIG_KASAN. So perhaps the
default line should actually read
default 0xdc00 if KASAN
after the move. Would that work?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...
e, 5/5 for
init/Kconfig.expert only, and 4/5 for the changes to scripts/kconfig/.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-i
. I
didn't spot a MODULE_LICENSE() macro in this file. So I think that, if
mtk_thermal.ko gets loaded - I guess through the of_match_table magic -
a warning will be issued and the kernel will be tainted.
(I didn't actually test any of this, so I've wasted your time if I&#
or later. So I think that either the comment at the top of these
files or the ident used in the MODULE_LICENSE() macro needs to be
changed.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
he code contains a few module-specific constructs. (These will be
preprocessed away, replaced with a built-in equivalent, etc.) Was it
your intention to make USB_EHCI_MV_OF tristate?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
net/toolchain-build.html
arch/openrisc/README.openrisc:git clone
git://openrisc.net/jonas/or1ksim-svn
arch/openrisc/kernel/setup.c: printk(KERN_INFO "OpenRISC Linux --
http://openrisc.net\n";);
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubs
ly. Your patch
was supposed to be applied already (see
https://lkml.org/lkml/2014/9/22/36 ), but clearly nothing happened.
openrisc.net is for sale.
What's going on here?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
2-or12" if OUTPUT_FORMAT_OR12
> Maybe I should simply stop testing older kernels for openrisc
> after this patch has been merged; that would be much easier.
> Jonas, is that ok with you ?
Would testing be easier if you'd be provided with two defconfig files?
Ie, one for "elf32-
This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
And, according to include/li
are m
we will get mtk-infracfg.ko and mtk-scpsys.ko (see 3/5). And loading
mtk-scpsys.ko will trigger loading mtk-infracfg.ko, right?
But since this file has no MODULE_LICENSE() that should generate a
warning and taint the kernel. (I haven't tested this. Please correct me
if I'm overlook
my]
will fail here. (*/mach/hardware.h is mainly used for arm.) That is
bound to generate, well, fanmail for you. Perhaps it's better if
RTC_DRV_GEMINI depends on, say, ARCH_GEMINI.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body o
L v2. So I think either the comment at the top of this file or
the license ident used in the MODULE_LICENSE() macro needs to change.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
On Mon, 2015-05-11 at 15:04 -0700, Josh Triplett wrote:
> On Mon, May 11, 2015 at 11:50:21PM +0200, Paul Bolle wrote:
> > On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote:
> > > +config KALLSYMS_ALL
> > > + bool "Include all symbols in kallsyms"
> &g
On Mon, 2015-05-11 at 14:47 -0700, Josh Triplett wrote:
> On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote:
> > Is squashing those two lines worth a new kconfig mechanism?
>
> In my opinion, yes. If you use the implicit (and error-prone)
> menuconfig submenuing, you
,
> + but may reduce performance.
> +config PCI_QUIRKS
> + default y
> + bool "Enable PCI quirk workarounds" if EXPERT
Ditto.
> + depends on PCI
> + help
> + This enables workarounds for various PCI chipset
> + bugs/quirks. Disabl
sted at the end of this message, which I quickly cobbled
together an applies on top of this 2/1, generates these two lines in
menuconfig (for EXPERT = 'y')
[*] Configure standard kernel features (expert users)
Standard kernel features --->
Is squashin
prompt "Foo" if EXPERT
entries in that menu roughly do what you want?
> So I'll send a followup patch enhancing kconfig to improve this case,
> but I think splitting this into a separate file is still worth it even
> without that.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
27;s no reason to add
CLKSRC_ST_LPC_TIMER_SCHED_CLOCK in this patch. It currently adds
nothing, as it will always be equal to whatever value CLKSRC_ST_LPC will
have, right?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.o
ULE_AUTHOR("Vishnu Patekar ");
> +MODULE_DESCRIPTION("Allwinner a33 pinctrl driver");
> +MODULE_LICENSE("GPL");
This adds some module specific boilerplate. Was it perhaps your
intention to make PINCTRL_SUN8I_A33 a tristate symbol? If I understand
Maxime correctly dri
On Thu, 2015-05-07 at 22:14 +0200, Paul Bolle wrote:
> Tomorrow, after a (western European) night of sleep, I hope to explain
> why the error in dad's file makes sense. I'm not much of a teacher so I
> need a clear head to do that.
Let's start with mom's Kconfig fi
be able to set
CLKSRC_ST_LPC_TIMER_SCHED_CLOCK to 'n' even though CLKSRC_ST_LPC is 'y',
you need to add a prompt. Or have you found a way around this?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo
On Fri, 2015-05-08 at 11:28 +0100, Lee Jones wrote:
> I'd prefer to keep this as CLKSRC_ST_LPC if you're not passionate
> about the alternative.
No, I'm not passionate about the alternative, so keeping CLKSRC_ST_LPC
is fine with me.
Thanks,
Paul Bolle
--
To unsubscribe
Enable this option to use the Low Power controller timer
> + as clocksource.
(Please add an empty line.)
> endmenu
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More ma
On Fri, 2015-05-08 at 10:36 +0100, Lee Jones wrote:
> On Fri, 08 May 2015, Paul Bolle wrote:
> > On Thu, 2015-05-07 at 14:38 +0100, Lee Jones wrote:
> > > --- a/drivers/clocksource/Kconfig
> > > +++ b/drivers/clocksource/Kconfig
> >
> > > +config CL
oller timer clock source as sched_clock
This adds, as far as I can see, a Kconfig symbol that will always be in
lockstep with CLKSRC_ST_LPC. Ie, CLKSRC_ST_LPC and
CLKSRC_ST_LPC_TIMER_SCHED_CLOCK will always both be 'n' or both be 'y'.
Are there plans to break that lockstep
state "Freescale USB OTG Transceiver Driver"
> depends on USB_EHCI_FSL && USB_FSL_USB2 && USB_OTG_FSM && PM
> select USB_OTG
> select USB_PHY
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
ing"
depends on LOCKER
This triggers the same error but with this as first line:
symbol GYM depends on ROCK_CLIMBING
Now the circular dependency in mom's Kconfig file is rather obvious. The
circular dependency in dad's file too, once you adapt to the reverse
logic of sele
On Thu, 2015-05-07 at 10:42 +0200, Paul Bolle wrote:
> On Wed, 2015-05-06 at 11:33 +0800, Herbert Xu wrote:
> > On Tue, May 05, 2015 at 05:44:21PM -0700, Luis R. Rodriguez wrote:
> > > From: "Luis R. Rodriguez"
> > >
> > > We're going to
approach
clears that bar. (Please note that macros like module_amba_driver() are
basically just a pet peeve.)
And, at the end of the day, what matters is what the maintainer of this
code accepts. I'm not the maintainer here.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the li
On Thu, 2015-05-07 at 10:52 +0200, Arnd Bergmann wrote:
> On Thursday 07 May 2015 09:39:18 Paul Bolle wrote:
> I realize the downsides of not posting the entire series at once
> here, but it seemed better to avoid spamming everyone too much,
> while I try to find out if we have agre
haven't actually tested anything here, and it wouldn't be
the first time my reasoning about Kconfig patches is completely off.)
And, whatever the value of my analysis, adding a Kconfig problem in
02/12 just to fix it in 03/12 is a bit silly. I think the patches should
be squashed if the
> + * GNU General Public License for more details.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think either the comment at the top of this file or
the ident used in the MO
PL");
This adds some module specific boilerplate. Was it perhaps your
intention to make PINCTRL_SUN8I_H3 a tristate symbol?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More major
On Thu, 2015-05-07 at 09:27 +0200, Paul Bolle wrote:
> On Wed, 2015-05-06 at 18:30 +0200, Arnd Bergmann wrote:
> > * After all system calls are converted, we can change one architecture
> > at a time to select ARCH_HAS_COMPAT_TIME, and modify its system
> > call table
030s, we
> should remove that option and all the compat handling.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
nel.org/r/1430428322.2187.24.camel@x220 . Maybe you
didn't receive that message.
It could also be that you think my comments were invalid, or too vague,
or whatever. Please say so, because then I don't have to bother you
again when you send out v4.
Thanks,
Paul Bolle
--
To unsubscribe
ges or as one 512 KiB chunk of memory. This driver
> + enables eSRAM in per-page overlay mode and provides a gen_pool
> + allocator which allows allocation of memory from the eSRAM pool.
> +
> + If you are running on a Galileo/Quark say Y here.
Thanks,
Paul Bolle
--
f-test driver");
> +MODULE_LICENSE("Dual BSD/GPL");
There's some module specific boilerplate above. (Note that I'm not sure
whether KBUILD_MODNAME is module specific, sorry.) And the comment talks
about a module too.
Was your intention to make DEBUG_ESRAM_SELFTEST
settle and then fix it
> properly.
I see. Unless that fix takes very long to land, I won't be bothering you
about this again.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.o
..] macros to
actually test this, so correct me if I'm wrong here.)
So I think that, effectively, these wm[...]-tables.o objects will always
be built if CONFIG_MFD_ARIZONA is set. Is that the intention? If not,
perhaps these test should read
ifeq ($(CONFIG_MFD_WM[...]),y)
Thanks,
Paul Boll
[Added Russell, because I, sort, of drop his name.]
Valentin Rothberg schreef op vr 01-05-2015 om 22:13 [+0200]:
> On Fri, May 1, 2015 at 9:31 PM, Paul Bolle wrote:
> > Valentin Rothberg schreef op wo 29-04-2015 om 16:58 [+0200]:
> >> Sometimes a user might be interested
Greg KH schreef op vr 01-05-2015 om 21:45 [+0200]:
> On Fri, May 01, 2015 at 09:31:36PM +0200, Paul Bolle wrote:
> > Patch hijack: it's been my view for some time now that almost all
> > defconfigs are outdated in one way or another. And they are outdated
> > because the
What exactly can one expect when using a defconfig?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Mathieu Poirier schreef op vr 01-05-2015 om 08:39 [-0600]:
> On 30 April 2015 at 15:29, Paul Bolle wrote:
> > On Wed, 2015-04-29 at 11:16 -0600, Mathieu Poirier wrote:
> >> +#include
> >
> > Is this include needed?
>
> It is needed for "module_param_nam
) GPL v2. So I think either the comment at the top of this file or
the ident used in the MODULE_LICESE() macro should change.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
is what you want). But it should also trigger this warning:
"CONFIG_MTD_RESERVE_END" is not defined [-Wundef]
>
> if (offset + part->parts[i].size > master->size) {
> printk(KERN_WARNING ERRP
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
double check.
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("CoreSight Embedded Trace Macrocell v4 driver");
These macros will be effectively be preprocessed away for built-in only
code.
(There is also a reference to module_param_named(). I don't know by
heart
valent to
calling
platform_driver_register(&crystalcove_pwm_driver);
from a wrapper, and marking that wrapper with device_initcall().
> +MODULE_AUTHOR("Shobhit Kumar ");
> +MODULE_DESCRIPTION("Intel Crystal Cove PWM Driver");
> +MODULE_LICENSE("GPL v2&q
401 - 500 of 2086 matches
Mail list logo
