Re: [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h

2019-01-21 Thread Paul Burton
> Signed-off-by: Masahiro Yamada Good catch. Would you prefer to take this through your kbuild tree or that I take it through the MIPS tree? If the former: Acked-by: Paul Burton Thanks, Paul

[GIT PULL] MIPS fixes

2019-01-19 Thread Paul Burton
Hi Linus, Here's a batch of MIPS fixes for 5.0 - please pull. Thanks, Paul The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) are available in the Git repository at:

[PATCH v2] kbuild: Disable LD_DEAD_CODE_DATA_ELIMINATION with ftrace & GCC <= 4.7

2019-01-11 Thread Paul Burton
the same time as ftrace/CONFIG_FUNCTION_TRACER when building using GCC 4.7 or older. Signed-off-by: Paul Burton Fixes: e85d1d65cd8a ("kbuild: test dead code/data elimination support in Kconfig") Reported-by: Geert Uytterhoeven Cc: Masahiro Yamada Cc: Nicholas Piggin Cc: sta...@vger

Re: [PATCH] kbuild: Disable LD_DEAD_CODE_DATA_ELIMINATION with ftrace & GCC <= 4.7

2019-01-10 Thread Paul Burton
Hi Masahiro, On Thu, Jan 10, 2019 at 11:00:49AM +0900, Masahiro Yamada wrote: > On Thu, Jan 10, 2019 at 8:16 AM Paul Burton wrote: > > When building using GCC 4.7 or older, -ffunction-sections & the -pg flag > > used by ftrace are incompatible. This causes warnings or build

[4.9 PATCH] MIPS: math-emu: Write-protect delay slot emulation pages

2019-01-10 Thread Paul Burton
to backport to stable kernels. Reported-by: Andy Lutomirski Signed-off-by: Paul Burton Fixes: 432c6bacbd0c ("MIPS: Use per-mm page to execute branch delay slot instructions") Cc: sta...@vger.kernel.org # v4.8+ Cc: linux-m...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Rich F

[PATCH] kbuild: Disable LD_DEAD_CODE_DATA_ELIMINATION with ftrace & GCC <= 4.7

2019-01-09 Thread Paul Burton
the same time as ftrace/CONFIG_FUNCTION_TRACER when building using GCC 4.7 or older. Signed-off-by: Paul Burton Fixes: e85d1d65cd8a ("kbuild: test dead code/data elimination support in Kconfig") Reported-by: Geert Uytterhoeven Cc: Masahiro Yamada Cc: Nicholas Piggin Cc: sta...@vger.kernel.org #

Re: [PATCH] MIPS: jazz: fix 64bit build

2019-01-09 Thread Paul Burton
Hello, Thomas Bogendoerfer wrote: > 64bit JAZZ builds failed with > > linux-next/arch/mips/jazz/jazzdma.c: In function ‘vdma_init’: > /linux-next/arch/mips/jazz/jazzdma.c:77:30: error: implicit declaration of > function ‘KSEG1ADDR’; did you mean ‘CKSEG1ADDR’? >

Re: [PATCH V2 mips-fixes] MIPS: BCM47XX: Setup struct device for the SoC

2019-01-09 Thread Paul Burton
Hello, Rafał Miłecki wrote: > From: Rafał Miłecki > > So far we never had any device registered for the SoC. This resulted in > some small issues that we kept ignoring like: > 1) Not working GPIOLIB_IRQCHIP (gpiochip_irqchip_add_key() failing) > 2) Lack of proper tree in the /sys/devices/ > 3)

Re: [PATCH] MIPS: ath79: Enable OF serial ports in the default config

2019-01-07 Thread Paul Burton
Hello, Alban Bedel wrote: > CONFIG_SERIAL_OF_PLATFORM is needed to get a working console on the OF > boards, enable it in the default config to get a working setup out of > the box. > > Signed-off-by: Alban Bedel Applied to mips-fixes. Thanks, Paul [ This message was auto-generated; if

[GIT PULL] MIPS fixes for 4.21

2019-01-05 Thread Paul Burton
Hi Linus, Below is a smattering of early MIPS fixes for 4.21, please pull. Thanks, Paul The following changes since commit adcc81f148d733b7e8e641300c5590a2cdc13bf3: MIPS: math-emu: Write-protect delay slot emulation pages (2018-12-20 10:00:01 -0800) are available in the Git repository

Re: [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"

2018-12-24 Thread Paul Burton
Hi Marek, On Fri, Dec 21, 2018 at 11:02:03PM +0100, Marek Vasut wrote: > >> I shared the entire testcase, which now fails on AM335x due to this > >> revert. Is there any progress on a proper fix from your side which does > >> not break the AM335x ? > > > > No. > > > > Let's be clear - I didn't

[GIT PULL] Main MIPS pull for 4.21

2018-12-23 Thread Paul Burton
leSur and BigSur Maksym Kokhan (2): mips: delete duplicated BUILTIN_DTB and LIBFDT configs mips: sort list of configs for Malta Mathieu Malaterre (1): mips: annotate implicit fall throughs Paul Burton (39): MIPS: Remove GCC_IMM_ASM & GCC_REG_ACCUM macros MIPS: Simplify G

Re: [PATCH v5 0/7] mips: system call table generation support

2018-12-23 Thread Paul Burton
Hi Firoz, On Sun, Dec 23, 2018 at 08:15:48AM -0800, Paul Burton wrote: > Hello, > > Firoz Khan wrote: > > The purpose of this patch series is, we can easily > > add/modify/delete system call table support by cha- > > nging entry in syscall.tbl file instead of manua

Re: [PATCH] MAINTAINERS: Add a maintainer for MSCC MIPS SoCs

2018-12-23 Thread Paul Burton
Hello, Alexandre Belloni wrote: > Microsemi has been bought by Microchip and Microchip is supporting those > SoCs. > > Signed-off-by: Alexandre Belloni > Acked-by: Woojung Huh Applied to mips-fixes. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect

Re: [PATCH v5 0/7] mips: system call table generation support

2018-12-23 Thread Paul Burton
Hello, Firoz Khan wrote: > The purpose of this patch series is, we can easily > add/modify/delete system call table support by cha- > nging entry in syscall.tbl file instead of manually > changing many files. The other goal is to unify the > system call table generation support implementation >

Re: [PATCH] MIPS: math-emu: Write-protect delay slot emulation pages

2018-12-23 Thread Paul Burton
Hello, Paul Burton wrote: > Mapping the delay slot emulation page as both writeable & executable > presents a security risk, in that if an exploit can write to & jump into > the page then it can be used as an easy way to execute arbitrary code. > > Prevent this by map

Re: [PATCH] MIPS: math-emu: Write-protect delay slot emulation pages

2018-12-21 Thread Paul Burton
Hi Sasha, On Thu, Dec 20, 2018 at 07:26:15PM +, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 432c6bacbd0c MIPS: Use per-mm page to execute branch delay > slot instructions. > > The bot has

Re: [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"

2018-12-21 Thread Paul Burton
Hi Marek, On Fri, Dec 21, 2018 at 09:08:28PM +0100, Marek Vasut wrote: > On 12/16/2018 11:28 PM, Paul Burton wrote: > > On Sun, Dec 16, 2018 at 11:01:18PM +0100, Marek Vasut wrote: > >>>>> I did suggest an alternative approach which would rename > >>&g

Re: Fixing MIPS delay slot emulation weakness?

2018-12-20 Thread Paul Burton
Hi Hugh, On Wed, Dec 19, 2018 at 01:12:58PM -0800, Hugh Dickins wrote: > > is_cow_mapping() returns true if the VM_MAYWRITE flag is set and > > VM_SHARED is not set - this suggests a private & potentially-writable > > area, right? That fits in nicely with an area we'd want to COW. Why then > >

[PATCH] MIPS: math-emu: Write-protect delay slot emulation pages

2018-12-20 Thread Paul Burton
Signed-off-by: Paul Burton Fixes: 432c6bacbd0c ("MIPS: Use per-mm page to execute branch delay slot instructions") Cc: sta...@vger.kernel.org # v4.8+ --- arch/mips/kernel/vdso.c | 4 ++-- arch/mips/math-emu/dsemul.c | 38 +++-- 2 files changed

Re: Fixing MIPS delay slot emulation weakness?

2018-12-18 Thread Paul Burton
Hello, On Sat, Dec 15, 2018 at 11:19:37AM -0800, Andy Lutomirski wrote: > The really simple but possibly suboptimal fix is to get rid of > VM_WRITE and to use get_user_pages(..., FOLL_FORCE) to write to it. I actually wound up trying this route because it seemed like it would produce a nice

Re: [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"

2018-12-16 Thread Paul Burton
Hi Ezequiel, On Sun, Dec 16, 2018 at 07:28:22PM -0300, Ezequiel Garcia wrote: > On Sun, 16 Dec 2018 at 19:24, Paul Burton wrote: > > This helps, but it only addresses one part of one of the 4 reasons I > > listed as motivation for my revert. For example serial8250_do_shutdown() &

Re: [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"

2018-12-16 Thread Paul Burton
Hi Marek, On Sun, Dec 16, 2018 at 11:01:18PM +0100, Marek Vasut wrote: > >>> I did suggest an alternative approach which would rename > >>> serial8250_clear_fifos() and split it into 2 variants - one that > >>> disables FIFOs & one that does not, then use the latter in > >>> __do_stop_tx_rs485():

Re: [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"

2018-12-16 Thread Paul Burton
Hi Ezequiel, On Sun, Dec 16, 2018 at 06:52:53PM -0300, Ezequiel Garcia wrote: > diff --git a/drivers/tty/serial/8250/8250_port.c > b/drivers/tty/serial/8250/8250_port.c > index c39482b96111..fac19cbc51d1 100644 > --- a/drivers/tty/serial/8250/8250_port.c > +++

Re: [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"

2018-12-16 Thread Paul Burton
On Sun, Dec 16, 2018 at 10:45:23PM +0100, Marek Vasut wrote: > >> I am unable to test it on such a short notice as I'm currently ill, so I > >> cannot tell if your change breaks the OMAP3/AM335x boards or not. Given > >> that there are very few CI20 boards in use, I'd like to ask you for some > >>

Re: [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"

2018-12-16 Thread Paul Burton
Hi Marek, On Sun, Dec 16, 2018 at 10:08:48PM +0100, Marek Vasut wrote: > > I did suggest an alternative approach which would rename > > serial8250_clear_fifos() and split it into 2 variants - one that > > disables FIFOs & one that does not, then use the latter in > > __do_stop_tx_rs485(): > > >

Re: [PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"

2018-12-16 Thread Paul Burton
Hi Marek, On Sun, Dec 16, 2018 at 09:32:19PM +0100, Marek Vasut wrote: > I am unable to test it on such a short notice as I'm currently ill, so I > cannot tell if your change breaks the OMAP3/AM335x boards or not. Given > that there are very few CI20 boards in use, I'd like to ask you for some >

[PATCH] Revert "serial: 8250: Fix clearing FIFOs in RS485 mode again"

2018-12-16 Thread Paul Burton
callers explicitly re-enable the FIFOs after calling serial8250_clear_fifos(). The premise of that patch that disabling the FIFOs is incorrect therefore seems wrong. For these reasons, this reverts commit f6aa5beb45be ("serial: 8250: Fix clearing FIFOs in RS485 mode again"). S

Re: Fixing MIPS delay slot emulation weakness?

2018-12-15 Thread Paul Burton
Hi Andy, On Sat, Dec 15, 2018 at 11:19:37AM -0800, Andy Lutomirski wrote: > Some security researchers pointed out that writing to the delay slot > emulation page is a great exploit technique on MIPS. It was > introduced in: > > commit 432c6bacbd0c16ec210c43da411ccc3855c4c010

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-13 Thread Paul Burton
Hi Firoz, On Thu, Dec 13, 2018 at 02:23:21PM +0530, Firoz Khan wrote: > > > So If you confirm I can send v5 without '64' to 'n64' conversion (not > > > just above > > > one, completely from this patch series). Or uou can take a call just > > > keep this macro - > > > _MIPS_SIM_ABI64 as it is and

Re: [PATCH v6 16/27] mips: define syscall_get_error()

2018-12-13 Thread Paul Burton
() functions in order to extend the generic > ptrace API with PTRACE_GET_SYSCALL_INFO request. > > Cc: Paul Burton > Cc: Ralf Baechle > Cc: James Hogan > Cc: Oleg Nesterov > Cc: Andy Lutomirski > Cc: Elvira Khabirova > Cc: Eugene Syromyatnikov > Cc: linux-m...

Re: [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again

2018-12-13 Thread Paul Burton
Hi Marek, On Thu, Dec 13, 2018 at 03:51:02PM +0100, Marek Vasut wrote: > > I wonder whether the issue may be the JZ4780 UART not automatically > > resetting the FIFOs when FCR[0] changes. This is a guess, but the manual > > doesn't explicitly say it'll happen & the programming example

Re: [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again

2018-12-12 Thread Paul Burton
Hi Marek, On Thu, Dec 13, 2018 at 05:18:19AM +0100, Marek Vasut wrote: > >>> I wonder whether the issue may be the JZ4780 UART not automatically > >>> resetting the FIFOs when FCR[0] changes. This is a guess, but the manual > >>> doesn't explicitly say it'll happen & the programming example it

Re: [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again

2018-12-12 Thread Paul Burton
Hi Marek, On Thu, Dec 13, 2018 at 03:27:51AM +0100, Marek Vasut wrote: > > I wonder whether the issue may be the JZ4780 UART not automatically > > resetting the FIFOs when FCR[0] changes. This is a guess, but the manual > > doesn't explicitly say it'll happen & the programming example it gives >

Re: [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again

2018-12-12 Thread Paul Burton
Hi Marek, On Thu, Dec 13, 2018 at 01:55:29AM +0100, Marek Vasut wrote: > On 12/13/2018 01:41 AM, Paul Burton wrote: > > This patch has broken the UART on my Ingenic JZ4780 based MIPS Creator > > Ci20 board. After this patch the system seems to detect garbage input > > that i

Re: [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again

2018-12-12 Thread Paul Burton
Hi Marek / Greg / all, On Mon, Sep 03, 2018 at 12:44:52AM +, Marek Vasut wrote: > The 8250 FIFOs indeed need to be cleared after stopping transmission in > RS485 mode without SER_RS485_RX_DURING_TX flag set. But there are two > problems with the approach taken by the previous patch from Fixes

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-12 Thread Paul Burton
Hi Firoz, On Wed, Dec 12, 2018 at 10:04:47AM +0530, Firoz Khan wrote: > > > Will this below change will help? > > > > > > #define _MIPS_SIM_ABI32 1 > > > #define _MIPS_SIM_NABI322 > > > #define _MIPS_SIM_ABI64 3 > > > +#define _MIPS_SIM_ABIN64

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-11 Thread Paul Burton
Hi Firoz, On Tue, Dec 11, 2018 at 02:15:19PM +0530, Firoz Khan wrote: > > > diff --git a/arch/mips/include/uapi/asm/sgidefs.h > > > b/arch/mips/include/uapi/asm/sgidefs.h > > > index 26143e3..0364eec 100644 > > > --- a/arch/mips/include/uapi/asm/sgidefs.h > > > +++

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-10 Thread Paul Burton
Hi Maciej, On Mon, Dec 10, 2018 at 11:32:46PM +, Maciej W. Rozycki wrote: > On Mon, 10 Dec 2018, Paul Burton wrote: > > > And I realise that undoing that but keeping n64 in our own filenames & > > macros is another type of inconsistency, but something imperf

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

2018-12-10 Thread Paul Burton
Hi Firoz, On Thu, Dec 06, 2018 at 10:48:24AM +0530, Firoz Khan wrote: > diff --git a/arch/mips/include/uapi/asm/sgidefs.h > b/arch/mips/include/uapi/asm/sgidefs.h > index 26143e3..0364eec 100644 > --- a/arch/mips/include/uapi/asm/sgidefs.h > +++ b/arch/mips/include/uapi/asm/sgidefs.h > @@ -40,6

Re: [PATCH v5 24/25] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-12-10 Thread Paul Burton
Hi Dmitry, On Mon, Dec 10, 2018 at 07:09:40PM +0300, Dmitry V. Levin wrote: > We decided to add .frame_pointer to struct ptrace_syscall_info just for > consistency with .instruction_pointer and .stack_pointer; I must have been > misled by comments in asm-generic/ptrace.h into thinking that >

Re: [PATCH v4 0/7] mips: system call table generation support

2018-12-09 Thread Paul Burton
Hi Firoz, On Mon, Dec 10, 2018 at 11:05:38AM +0530, Firoz Khan wrote: > Please review this patch series and queue it for linux-next. It's been ~4 days, 2 of which were a weekend. I'll get to it, but pinging so often won't help. Thanks, Paul

Re: [PATCH 1/2] mips/kgdb: prepare arch_kgdb_ops for constness

2018-12-06 Thread Paul Burton
t it can be changed to > > const in following patch, as recommended by checkpatch.pl > > > > Suggested-by: Paul Burton > > Signed-off-by: Christophe Leroy > > From my side this is > Acked-by: Daniel Thompson > > Since this is a dependency for the next patch I

Re: [PATCH] mips: annotate implicit fall throughs

2018-12-03 Thread Paul Burton
Hello, Mathieu Malaterre wrote: > There is a plan to build the kernel with -Wimplicit-fallthrough and > these places in the code produced warnings. Fix them up. > > This patch produces no change in behaviour, but should be reviewed in > case these are actually bugs not intentional fallthoughs. >

Re: [PATCH] mips: annotate implicit fall throughs

2018-12-03 Thread Paul Burton
Hello, Mathieu Malaterre wrote: > There is a plan to build the kernel with -Wimplicit-fallthrough and > these places in the code produced warnings. Fix them up. > > This patch produces no change in behaviour, but should be reviewed in > case these are actually bugs not intentional fallthoughs. >

[GIT PULL] MIPS fixes for 4.20

2018-11-30 Thread Paul Burton
. Dmitry V. Levin (1): mips: fix mips_get_syscall_arg o32 check Mathias Kresin (1): MIPS: ralink: Fix mt7620 nd_sd pinmux Paul Burton (1): MAINTAINERS: Update linux-mips mailing list address MAINTAINERS | 46

[GIT PULL] MIPS fixes for 4.20

2018-11-30 Thread Paul Burton
. Dmitry V. Levin (1): mips: fix mips_get_syscall_arg o32 check Mathias Kresin (1): MIPS: ralink: Fix mt7620 nd_sd pinmux Paul Burton (1): MAINTAINERS: Update linux-mips mailing list address MAINTAINERS | 46

[PATCH] MAINTAINERS: Update linux-mips mailing list address

2018-11-30 Thread Paul Burton
NERS with the shiny new linux-m...@vger.kernel.org address. The new list is now being archived on kernel.org at https://lore.kernel.org/linux-mips/ which also holds the history of the old linux-mips.org list. Signed-off-by: Paul Burton --- MAINTAINERS | 46 +++--

[PATCH] MAINTAINERS: Update linux-mips mailing list address

2018-11-30 Thread Paul Burton
NERS with the shiny new linux-m...@vger.kernel.org address. The new list is now being archived on kernel.org at https://lore.kernel.org/linux-mips/ which also holds the history of the old linux-mips.org list. Signed-off-by: Paul Burton --- MAINTAINERS | 46 +++--

Re: [PATCH] MIPS: ralink: Fix mt7620 nd_sd pinmux

2018-11-26 Thread Paul Burton
Hello, Mathias Kresin wrote: > In case the nd_sd group is set to the sd-card function, Pins 45 + 46 are > configured as GPIOs. If they are blocked by the sd function, they can't > be used as GPIOs. > > Signed-off-by: Mathias Kresin > Reported-by: Kristian Evensen > Fixes: f576fb6a0700 ("MIPS:

Re: [PATCH] MIPS: ralink: Fix mt7620 nd_sd pinmux

2018-11-26 Thread Paul Burton
Hello, Mathias Kresin wrote: > In case the nd_sd group is set to the sd-card function, Pins 45 + 46 are > configured as GPIOs. If they are blocked by the sd function, they can't > be used as GPIOs. > > Signed-off-by: Mathias Kresin > Reported-by: Kristian Evensen > Fixes: f576fb6a0700 ("MIPS:

Re: [PATCH] mips: fix mips_get_syscall_arg o32 check

2018-11-21 Thread Paul Burton
Hello, Dmitry V. Levin wrote: > When checking for TIF_32BIT_REGS flag, mips_get_syscall_arg() should > use the task specified as its argument instead of the current task. > > This potentially affects all syscall_get_arguments() users > who specify tasks different from the current. > > Fixes:

Re: [PATCH] mips: fix mips_get_syscall_arg o32 check

2018-11-21 Thread Paul Burton
Hello, Dmitry V. Levin wrote: > When checking for TIF_32BIT_REGS flag, mips_get_syscall_arg() should > use the task specified as its argument instead of the current task. > > This potentially affects all syscall_get_arguments() users > who specify tasks different from the current. > > Fixes:

[GIT PULL] MIPS fixes for v4.20-rc4

2018-11-20 Thread Paul Burton
is used. Aaro Koskinen (1): MIPS: OCTEON: cavium_octeon_defconfig: re-enable OCTEON USB driver Huacai Chen (1): MIPS: Let early memblock_alloc*() allocate memories bottom-up Paul Burton (1): MIPS: Loongson3,SGI-IP27: Simplify max_low_pfn calculation arch/mips

[GIT PULL] MIPS fixes for v4.20-rc4

2018-11-20 Thread Paul Burton
is used. Aaro Koskinen (1): MIPS: OCTEON: cavium_octeon_defconfig: re-enable OCTEON USB driver Huacai Chen (1): MIPS: Let early memblock_alloc*() allocate memories bottom-up Paul Burton (1): MIPS: Loongson3,SGI-IP27: Simplify max_low_pfn calculation arch/mips

Re: [PATCH] MIPS: Remove superfluous check for __linux__

2018-11-19 Thread Paul Burton
Hello, Sean Young wrote: > When building BPF code using "clang -target bpf -c", clang does not > define __linux__. > > To build BPF IR decoders the include linux/lirc.h is needed which > includes linux/types.h. Currently this workaround is needed: > >

Re: [PATCH] MIPS: Remove superfluous check for __linux__

2018-11-19 Thread Paul Burton
Hello, Sean Young wrote: > When building BPF code using "clang -target bpf -c", clang does not > define __linux__. > > To build BPF IR decoders the include linux/lirc.h is needed which > includes linux/types.h. Currently this workaround is needed: > >

Re: [PATCH 4/9] PCI: consolidate PCI config entry in drivers/pci

2018-11-19 Thread Paul Burton
o for PCI on and the handle the > rest in drivers/pci. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Palmer Dabbelt > Acked-by: Max Filippov > Acked-by: Thomas Gleixner > Acked-by: Bjorn Helgaas > Acked-by: Geert Uytterhoeven For patches 4, 5, 7, 8 & 9: Acked-

Re: [PATCH 4/9] PCI: consolidate PCI config entry in drivers/pci

2018-11-19 Thread Paul Burton
o for PCI on and the handle the > rest in drivers/pci. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Palmer Dabbelt > Acked-by: Max Filippov > Acked-by: Thomas Gleixner > Acked-by: Bjorn Helgaas > Acked-by: Geert Uytterhoeven For patches 4, 5, 7, 8 & 9: Acked-

Re: [PATCH v3 0/3] MIPS: SiByte: Handle PCI DMA with 64-bit memory addressing

2018-11-19 Thread Paul Burton
Hello, Maciej W. Rozycki wrote: > Hi, > > This mini patch series enables correct support for DMA in the presence of > memory outside the 32-bit address range with the Broadcom SiByte SOCs and > the relevant development boards. > > There is a quirk in the BCM1250, BCM1125 and BCM1125H SOCs in

Re: [PATCH v3 0/3] MIPS: SiByte: Handle PCI DMA with 64-bit memory addressing

2018-11-19 Thread Paul Burton
Hello, Maciej W. Rozycki wrote: > Hi, > > This mini patch series enables correct support for DMA in the presence of > memory outside the 32-bit address range with the Broadcom SiByte SOCs and > the relevant development boards. > > There is a quirk in the BCM1250, BCM1125 and BCM1125H SOCs in

Re: [PATCH] MIPS: Use device_type helpers to access the node type

2018-11-19 Thread Paul Burton
Hello, Rob Herring wrote: > Remove directly accessing device_node.type pointer and use the accessors > instead. This will eventually allow removing the type pointer. > > Cc: Ralf Baechle > Cc: Paul Burton > Cc: James Hogan > Cc: linux-m...@linux-mips.org > Signed-off-b

Re: [PATCH] MIPS: Use device_type helpers to access the node type

2018-11-19 Thread Paul Burton
Hello, Rob Herring wrote: > Remove directly accessing device_node.type pointer and use the accessors > instead. This will eventually allow removing the type pointer. > > Cc: Ralf Baechle > Cc: Paul Burton > Cc: James Hogan > Cc: linux-m...@linux-mips.org > Signed-off-b

Re: [PATCH 1/2] MIPS: Use Kconfig to select CPU_NO_EFFICIENT_FFS

2018-11-13 Thread Paul Burton
Hello, Paul Burton wrote: > Select CONFIG_CPU_NO_EFFICIENT_FFS via Kconfig when the kernel is > configured for a pre-MIPS32r1 CPU, rather than defining its equivalent > in asm/cpu-features.h based upon overrides of cpu_has_mips* macros. > > The latter only works if a platform has

Re: [PATCH v2 1/2] mips: delete duplicated BUILTIN_DTB and LIBFDT configs

2018-11-13 Thread Paul Burton
Hello, Maksym Kokhan wrote: > CONFIG_BUILTIN_DTB and CONFIG_LIBFDT selection is duplicated > in menu "Machine selection" under MIPS_MALTA. > > Signed-off-by: Maksym Kokhan > Signed-off-by: Andrii Bordunov Series applied to mips-next. Thanks, Paul [ This message was auto-generated; if

Re: [PATCH 1/2] MIPS: Use Kconfig to select CPU_NO_EFFICIENT_FFS

2018-11-13 Thread Paul Burton
Hello, Paul Burton wrote: > Select CONFIG_CPU_NO_EFFICIENT_FFS via Kconfig when the kernel is > configured for a pre-MIPS32r1 CPU, rather than defining its equivalent > in asm/cpu-features.h based upon overrides of cpu_has_mips* macros. > > The latter only works if a platform has

Re: [PATCH v2 1/2] mips: delete duplicated BUILTIN_DTB and LIBFDT configs

2018-11-13 Thread Paul Burton
Hello, Maksym Kokhan wrote: > CONFIG_BUILTIN_DTB and CONFIG_LIBFDT selection is duplicated > in menu "Machine selection" under MIPS_MALTA. > > Signed-off-by: Maksym Kokhan > Signed-off-by: Andrii Bordunov Series applied to mips-next. Thanks, Paul [ This message was auto-generated; if

Re: [PATCH] MIPS: OCTEON: cavium_octeon_defconfig: re-enable OCTEON USB driver

2018-11-13 Thread Paul Burton
Hello, Aaro Koskinen wrote: > Re-enable OCTEON USB driver which is needed on older hardware > (e.g. EdgeRouter Lite) for mass storage etc. This got accidentally > deleted when config options were changed for OCTEON2/3 USB. > > Fixes: f922bc0ad08b ("MIPS: Octeon: cavium_octeon_defconfig: Enable

Re: [PATCH] MIPS: OCTEON: cavium_octeon_defconfig: re-enable OCTEON USB driver

2018-11-13 Thread Paul Burton
Hello, Aaro Koskinen wrote: > Re-enable OCTEON USB driver which is needed on older hardware > (e.g. EdgeRouter Lite) for mass storage etc. This got accidentally > deleted when config options were changed for OCTEON2/3 USB. > > Fixes: f922bc0ad08b ("MIPS: Octeon: cavium_octeon_defconfig: Enable

[PATCH 1/2] MIPS: Use Kconfig to select CPU_NO_EFFICIENT_FFS

2018-11-08 Thread Paul Burton
more naturally make a decision about instruction support using information about the target ISA. Signed-off-by: Paul Burton Cc: Andrew Morton Cc: Zhaoxiu Zeng --- arch/mips/Kconfig| 13 - arch/mips/include/asm/cpu-features.h | 10 -- 2 files changed, 12 insert

[PATCH 2/2] lib/gcd: Remove use of CPU_NO_EFFICIENT_FFS macro

2018-11-08 Thread Paul Burton
The CPU_NO_EFFICIENT_FFS pre-processor macro is no longer used, with all architectures toggling the equivalent Kconfig symbol CONFIG_CPU_NO_EFFICIENT_FFS instead. Remove our check for the unused macro. Signed-off-by: Paul Burton Cc: Andrew Morton Cc: Zhaoxiu Zeng --- lib/gcd.c | 2 +- 1

[PATCH 1/2] MIPS: Use Kconfig to select CPU_NO_EFFICIENT_FFS

2018-11-08 Thread Paul Burton
more naturally make a decision about instruction support using information about the target ISA. Signed-off-by: Paul Burton Cc: Andrew Morton Cc: Zhaoxiu Zeng --- arch/mips/Kconfig| 13 - arch/mips/include/asm/cpu-features.h | 10 -- 2 files changed, 12 insert

[PATCH 2/2] lib/gcd: Remove use of CPU_NO_EFFICIENT_FFS macro

2018-11-08 Thread Paul Burton
The CPU_NO_EFFICIENT_FFS pre-processor macro is no longer used, with all architectures toggling the equivalent Kconfig symbol CONFIG_CPU_NO_EFFICIENT_FFS instead. Remove our check for the unused macro. Signed-off-by: Paul Burton Cc: Andrew Morton Cc: Zhaoxiu Zeng --- lib/gcd.c | 2 +- 1

Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection

2018-11-08 Thread Paul Burton
Hi Maksym, On Tue, Nov 06, 2018 at 05:29:40PM +0200, Maksym Kokhan wrote: > > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > > > > > index 3551199..71d6549 100644 > > > > > --- a/arch/mips/Kconfig > > > > > +++ b/arch/mips/Kconfig > > > > > @@ -539,7 +539,6 @@ config MIPS_MALTA > > >

Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection

2018-11-08 Thread Paul Burton
Hi Maksym, On Tue, Nov 06, 2018 at 05:29:40PM +0200, Maksym Kokhan wrote: > > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > > > > > index 3551199..71d6549 100644 > > > > > --- a/arch/mips/Kconfig > > > > > +++ b/arch/mips/Kconfig > > > > > @@ -539,7 +539,6 @@ config MIPS_MALTA > > >

Re: [PATCH] MIPS: r2-on-r6-emu: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-11-06 Thread Paul Burton
Hi Yangtao, On Tue, Nov 06, 2018 at 09:36:36AM -0500, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li > --- > arch/mips/kernel/mips-r2-to-r6-emul.c | 32 +-- > 1 file changed, 5 insertions(+), 27 deletions(-)

Re: [PATCH] MIPS: r2-on-r6-emu: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-11-06 Thread Paul Burton
Hi Yangtao, On Tue, Nov 06, 2018 at 09:36:36AM -0500, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li > --- > arch/mips/kernel/mips-r2-to-r6-emul.c | 32 +-- > 1 file changed, 5 insertions(+), 27 deletions(-)

Re: [PATCH] MIPS: math-emu: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-11-05 Thread Paul Burton
Hi Yangtao, On Mon, Nov 05, 2018 at 09:50:49AM -0500, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li > --- > arch/mips/math-emu/me-debugfs.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) Thanks - applied to

Re: [PATCH] MIPS: math-emu: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-11-05 Thread Paul Burton
Hi Yangtao, On Mon, Nov 05, 2018 at 09:50:49AM -0500, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li > --- > arch/mips/math-emu/me-debugfs.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) Thanks - applied to

Re: [PATCH] MIPS: OCTEON: fix out of bounds array access on CN68XX

2018-11-05 Thread Paul Burton
Hi Aaro, On Sat, Oct 27, 2018 at 01:46:34AM +0300, Aaro Koskinen wrote: > The maximum number of interfaces is returned by > cvmx_helper_get_number_of_interfaces(), and the value is used to access > interface_port_count[]. When CN68XX support was added, we forgot > to increase the array size. Fix

Re: [PATCH] MIPS: OCTEON: fix out of bounds array access on CN68XX

2018-11-05 Thread Paul Burton
Hi Aaro, On Sat, Oct 27, 2018 at 01:46:34AM +0300, Aaro Koskinen wrote: > The maximum number of interfaces is returned by > cvmx_helper_get_number_of_interfaces(), and the value is used to access > interface_port_count[]. When CN68XX support was added, we forgot > to increase the array size. Fix

Re: [RFC PATCH] lib: Introduce generic __cmpxchg_u64() and use it where needed

2018-11-01 Thread Paul Burton
Hi Trond, On Thu, Nov 01, 2018 at 12:17:31AM +, Trond Myklebust wrote: > On Wed, 2018-10-31 at 23:32 +0000, Paul Burton wrote: > > In this particular case I have no idea why > > net/sunrpc/auth_gss/gss_krb5_seal.c is using cmpxchg64() at all. It's > > es

Re: [RFC PATCH] lib: Introduce generic __cmpxchg_u64() and use it where needed

2018-11-01 Thread Paul Burton
Hi Trond, On Thu, Nov 01, 2018 at 12:17:31AM +, Trond Myklebust wrote: > On Wed, 2018-10-31 at 23:32 +0000, Paul Burton wrote: > > In this particular case I have no idea why > > net/sunrpc/auth_gss/gss_krb5_seal.c is using cmpxchg64() at all. It's > > es

Re: [PATCH AUTOSEL 4.14 33/46] MIPS: Workaround GCC __builtin_unreachable reordering bug

2018-10-25 Thread Paul Burton
Hi Sasha, On Thu, Oct 25, 2018 at 10:10:40AM -0400, Sasha Levin wrote: > From: Paul Burton > > [ Upstream commit 906d441febc0de974b2a6ef848a8f058f3bfada3 ] > > Some versions of GCC for the MIPS architecture suffer from a bug which > can lead to instructions from beyond an unr

Re: [PATCH AUTOSEL 4.14 33/46] MIPS: Workaround GCC __builtin_unreachable reordering bug

2018-10-25 Thread Paul Burton
Hi Sasha, On Thu, Oct 25, 2018 at 10:10:40AM -0400, Sasha Levin wrote: > From: Paul Burton > > [ Upstream commit 906d441febc0de974b2a6ef848a8f058f3bfada3 ] > > Some versions of GCC for the MIPS architecture suffer from a bug which > can lead to instructions from beyond an unr

Re: Question about mmap syscall and POSIX standard on mips arch

2018-10-18 Thread Paul Burton
Hi Al, On Thu, Oct 18, 2018 at 05:32:00AM +0100, Al Viro wrote: > [mips folks Cc'd] > > On Thu, Oct 18, 2018 at 11:26:02AM +0800, Hongzhi, Song wrote: > > Hi all, > > > > Ltp has a POSIX teatcase about mmap, 24-2.c. > > > >

Re: Question about mmap syscall and POSIX standard on mips arch

2018-10-18 Thread Paul Burton
Hi Al, On Thu, Oct 18, 2018 at 05:32:00AM +0100, Al Viro wrote: > [mips folks Cc'd] > > On Thu, Oct 18, 2018 at 11:26:02AM +0800, Hongzhi, Song wrote: > > Hi all, > > > > Ltp has a POSIX teatcase about mmap, 24-2.c. > > > >

Re: [PATCH 00/14] serial: langtiq: Add CCF suppport

2018-10-15 Thread Paul Burton
Hi Songjun, On Mon, Sep 24, 2018 at 06:27:49PM +0800, Songjun Wu wrote: > This patch series is for adding common clock framework support > for langtiq serial driver, mainly includes: s/langtiq/lantiq/ ... > 1) Add common clock framework support. > 2) Modify the dts file according to the DT

Re: [PATCH 00/14] serial: langtiq: Add CCF suppport

2018-10-15 Thread Paul Burton
Hi Songjun, On Mon, Sep 24, 2018 at 06:27:49PM +0800, Songjun Wu wrote: > This patch series is for adding common clock framework support > for langtiq serial driver, mainly includes: s/langtiq/lantiq/ ... > 1) Add common clock framework support. > 2) Modify the dts file according to the DT

Re: [PATCH 7/8] mips: convert to generic builtin command line

2018-10-12 Thread Paul Burton
Hi Maksym, On Mon, Oct 08, 2018 at 08:56:25PM +0300, Maksym Kokhan wrote: > On Thu, Sep 27, 2018 at 9:56 PM Paul Burton wrote: > > It also doesn't allow for the various Kconfig options which allow us to > > ignore some of the sources of command line arguments, nor does it honor &

Re: [PATCH 7/8] mips: convert to generic builtin command line

2018-10-12 Thread Paul Burton
Hi Maksym, On Mon, Oct 08, 2018 at 08:56:25PM +0300, Maksym Kokhan wrote: > On Thu, Sep 27, 2018 at 9:56 PM Paul Burton wrote: > > It also doesn't allow for the various Kconfig options which allow us to > > ignore some of the sources of command line arguments, nor does it honor &

Re: [PATCH 0/4] MIPS: Ordering enforcement fixes for MMIO accessors

2018-10-11 Thread Paul Burton
Hi Maciej, On Mon, Oct 08, 2018 at 01:36:55AM +0100, Maciej W. Rozycki wrote: > This patch series is a follow-up to my earlier consideration about MMIO > access ordering recorded here: . > > As I have learnt in a recent Alpha/Linux discussion starting

Re: [PATCH 0/4] MIPS: Ordering enforcement fixes for MMIO accessors

2018-10-11 Thread Paul Burton
Hi Maciej, On Mon, Oct 08, 2018 at 01:36:55AM +0100, Maciej W. Rozycki wrote: > This patch series is a follow-up to my earlier consideration about MMIO > access ordering recorded here: . > > As I have learnt in a recent Alpha/Linux discussion starting

Re: [PATCH 0/2] MIPS: memset: Fix `noreorder' issues

2018-10-11 Thread Paul Burton
Hi Maciej, On Tue, Oct 02, 2018 at 12:50:00PM +0100, Maciej W. Rozycki wrote: > A recent change broke CPU_DADDI_WORKAROUNDS support in memset.S, due to a > delay-slot instruction expanding to multiple hardware operations for the > affected configurations. > > The underlying cause is the

Re: [PATCH 0/2] MIPS: memset: Fix `noreorder' issues

2018-10-11 Thread Paul Burton
Hi Maciej, On Tue, Oct 02, 2018 at 12:50:00PM +0100, Maciej W. Rozycki wrote: > A recent change broke CPU_DADDI_WORKAROUNDS support in memset.S, due to a > delay-slot instruction expanding to multiple hardware operations for the > affected configurations. > > The underlying cause is the

Re: [PATCH] MAINTAINERS: MIPS/LOONGSON2 ARCHITECTURE - Use the normal wildcard style

2018-10-01 Thread Paul Burton
Hi Joe, On Sun, Sep 30, 2018 at 09:21:34AM -0700, Joe Perches wrote: > Neither git nor get_maintainer understands the curly brace style. > > Signed-off-by: Joe Perches > --- > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks - applied to mips-fixes, which I intend

Re: [PATCH] MAINTAINERS: MIPS/LOONGSON2 ARCHITECTURE - Use the normal wildcard style

2018-10-01 Thread Paul Burton
Hi Joe, On Sun, Sep 30, 2018 at 09:21:34AM -0700, Joe Perches wrote: > Neither git nor get_maintainer understands the curly brace style. > > Signed-off-by: Joe Perches > --- > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks - applied to mips-fixes, which I intend

Re: [PATCH] MIPS: stop using _PTRS_PER_PGD

2018-09-28 Thread Paul Burton
Hi Alexandre, On Fri, Sep 28, 2018 at 11:32:02AM +0200, Alexandre Belloni wrote: > gcc 3.3 has been retired for a while, use PTRS_PER_PGD and remove the > asm-offsets.h inclusion. > > Signed-off-by: Alexandre Belloni > --- > arch/mips/mm/init.c | 7 +-- > 1 file changed, 1 insertion(+), 6

Re: [PATCH] MIPS: stop using _PTRS_PER_PGD

2018-09-28 Thread Paul Burton
Hi Alexandre, On Fri, Sep 28, 2018 at 11:32:02AM +0200, Alexandre Belloni wrote: > gcc 3.3 has been retired for a while, use PTRS_PER_PGD and remove the > asm-offsets.h inclusion. > > Signed-off-by: Alexandre Belloni > --- > arch/mips/mm/init.c | 7 +-- > 1 file changed, 1 insertion(+), 6

[PATCH v2] MIPS: Fix CONFIG_CMDLINE handling

2018-09-27 Thread Paul Burton
cation issue by initializing boot_command_line to a non-empty string that early_init_dt_scan_chosen() will not overwrite with CONFIG_CMDLINE. This is a little ugly, but cleanup in this area is on its way. In the meantime this is at least easy to backport & contains the ugliness within arch/mips/. S

<    1   2   3   4   5   6   7   8   9   10   >