Re: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create()

2012-07-17 Thread Pekka Enberg
On Mon, 16 Jul 2012, David Rientjes wrote: The kernel cannot check everything and will blow up in unexpected ways if someone codes something stupid. There are numerous debugging options that need to be switched on to get better debugging information to investigate deper. Adding special

[PROBLEM] perf requires python-devel to compile

2013-04-15 Thread Pekka Enberg
Hello, I'm seeing this when I try to build perf in v3.9-rc7: [penberg@golgotha perf]$ make CHK -fstack-protector-all CHK -Wstack-protector CHK -Wvolatile-register-var CHK -D_FORTIFY_SOURCE=2 CHK bionic CHK libelf CHK libdw Makefile:584: No libdw.h found or old libdw.h

Re: [PROBLEM] perf requires python-devel to compile

2013-04-16 Thread Pekka Enberg
Hello, On Tue, Apr 16, 2013 at 5:14 AM, Namhyung Kim namhy...@kernel.org wrote: The problem is that I didn't have python-devel package installed and get-executable-or-default decides to error out instead of letting the Makefile disable Python support. Right. I think the

Re: [RT LATENCY] 249 microsecond latency caused by slub's unfreeze_partials() code.

2013-04-10 Thread Pekka Enberg
On Mon, Apr 8, 2013 at 3:32 PM, Steven Rostedt rost...@goodmis.org wrote: Index: linux/mm/slub.c === --- linux.orig/mm/slub.c2013-03-28 12:14:26.958358688 -0500 +++ linux/mm/slub.c 2013-04-01 10:23:24.677584499 -0500 @@

Re: [RT LATENCY] 249 microsecond latency caused by slub's unfreeze_partials() code.

2013-04-12 Thread Pekka Enberg
Hello, On 04/11/2013 07:42 PM, Christoph Lameter wrote: On Thu, 11 Apr 2013, Steven Rostedt wrote: I was wondering if you made any more forward progress with with patch yet. When it goes into mainline, I'd like to backport it to the -rt stable trees, and will probably make it enabled by

Re: [PATCH] x86: Add a Kconfig shortcut for a kvm-bootable kernel

2013-04-14 Thread Pekka Enberg
Hello, On 4/12/13 9:19 PM, Borislav Petkov wrote: so I'm currently experimenting with my randconfig build scripts and thought that maybe it would be a cool thing to not only do the random builds only but also boot-test them in kvm. Which reminded me that we have that KVMTOOL_TEST_ENABLE config

Re: [PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-04-02 Thread Pekka Enberg
On Tue, Mar 19, 2013 at 7:10 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: Could you pick up 1/3, 3/3? These are already acked by Christoph. 2/3 is same effect as Glauber's slub: correctly bootstrap boot caches, so should skip it. Applied, thanks! -- To unsubscribe from this list: send the

Re: [RT LATENCY] 249 microsecond latency caused by slub's unfreeze_partials() code.

2013-04-02 Thread Pekka Enberg
On Tue, Apr 2, 2013 at 3:42 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: I have a vague memory that Joonsoo also ran into this issue awhile back. Yes. I sent a patch for this two month ago. :) It's applied now. Pekka -- To unsubscribe from this list: send the line

Re: [PATCH v2 08/20] x86, ACPI: Find acpi tables in initrd early from head_32.S/head64.c

2013-03-10 Thread Pekka Enberg
On Sun, Mar 10, 2013 at 8:44 AM, Yinghai Lu ying...@kernel.org wrote: +void __init x86_acpi_override_find(void) +{ + unsigned long ramdisk_image, ramdisk_size; + unsigned char *p = NULL; + +#ifdef CONFIG_X86_32 + struct boot_params *boot_params_p; + + /* +

Re: [PATCH v2, part2 10/10] mm/x86: use free_highmem_page() to free highmem pages into buddy system

2013-03-10 Thread Pekka Enberg
On Sun, Mar 10, 2013 at 10:01 AM, Jiang Liu liu...@gmail.com wrote: Use helper function free_highmem_page() to free highmem pages into the buddy system. Signed-off-by: Jiang Liu jiang@huawei.com --- arch/x86/mm/highmem_32.c |1 - arch/x86/mm/init_32.c| 10 +- 2 files

Re: [PATCH v2, part2 10/10] mm/x86: use free_highmem_page() to free highmem pages into buddy system

2013-03-10 Thread Pekka Enberg
On Sun, Mar 10, 2013 at 12:32 PM, Pekka Enberg penb...@kernel.org wrote: On Sun, Mar 10, 2013 at 10:01 AM, Jiang Liu liu...@gmail.com wrote: Use helper function free_highmem_page() to free highmem pages into the buddy system. Signed-off-by: Jiang Liu jiang@huawei.com --- arch/x86/mm

Re: [PATCH v2, part2 01/10] mm: introduce free_highmem_page() helper to free highmem pages into buddy system

2013-03-10 Thread Pekka Enberg
On Sun, Mar 10, 2013 at 10:01 AM, Jiang Liu liu...@gmail.com wrote: Introduce helper function free_highmem_page(), which will be used by architectures with HIGHMEM enabled to free highmem pages into the buddy system. Signed-off-by: Jiang Liu jiang@huawei.com Reviewed-by: Pekka Enberg

Re: [PATCH] kgdb: Removed kmalloc returned value cast

2013-03-10 Thread Pekka Enberg
On Sun, Mar 10, 2013 at 3:06 PM, Alex Grad alex.g...@gmail.com wrote: Signed-off-by: Alex Grad alex.g...@gmail.com --- arch/powerpc/kernel/kgdb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c index

Re: [PATCH] bcm: don't cast kzalloc() return value

2013-03-10 Thread Pekka Enberg
On Sun, Mar 10, 2013 at 2:48 PM, Mihnea Dobrescu-Balaur mihne...@gmail.com wrote: Signed-off-by: Mihnea Dobrescu-Balaur mihne...@gmail.com Reviewed-by: Pekka Enberg penb...@kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] s390: replace kmalloc + memset with kzalloc

2013-03-10 Thread Pekka Enberg
On Sun, Mar 10, 2013 at 3:13 PM, Stelian Nirlu stelianni...@gmail.com wrote: Signed-off-by: Stelian Nirlu stelianni...@gmail.com --- arch/s390/net/bpf_jit_comp.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/s390/net/bpf_jit_comp.c

[GIT PULL] SLAB changes for v3.9-rc1

2013-03-04 Thread Pekka Enberg
slab: Fixup CONFIG_PAGE_ALLOC/DEBUG_SLAB_LEAK sections Glauber Costa (1): slub: correctly bootstrap boot caches Joonsoo Kim (1): mm/sl[au]b: correct allocation type check in kmalloc_slab() Pekka Enberg (1): Merge branch 'slab/next' into slab/for-linus fs/proc/stat.c

Re: [GIT PULL] SLAB changes for v3.9-rc1

2013-03-06 Thread Pekka Enberg
Hi Christoph, On Wed, Mar 6, 2013 at 6:38 PM, Christoph Lameter c...@linux.com wrote: Well this stuff was already ready for 3.8 and missed that merge period as well. There are a couple of bug fixes included as well. It is the basis for more common code between allocators. Most of it is

Re: kvmtool tree (Was: Re: [patch] config: fix make kvmconfig)

2013-02-08 Thread Pekka Enberg
Linus, I'm going to go out on a limb here and say that this might the odd out case that's not really supposed to happen where *you* are just WRONG, CRAZY, and IGNORING REALITY. On Fri, Feb 8, 2013 at 11:14 PM, Linus Torvalds torva...@linux-foundation.org wrote: I think merging it would be an

Re: kvmtool tree (Was: Re: [patch] config: fix make kvmconfig)

2013-02-09 Thread Pekka Enberg
On Sat, Feb 9, 2013 at 2:45 AM, Linus Torvalds torva...@linux-foundation.org wrote: Quite frankly, that's just optimizing for the wrong case. I obviously don't agree. I'm fairly sure there wouldn't be a kvmtool that supports x86, PPC64, ARM, and all the virtio drivers had we not optimized for

Re: kvmtool tree (Was: Re: [patch] config: fix make kvmconfig)

2013-02-09 Thread Pekka Enberg
On Sat, Feb 9, 2013 at 8:07 PM, Linus Torvalds torva...@linux-foundation.org wrote: Everything you said was about how it's more convenient for you and Ingo, not at all about why it should be better for anybody else. You haven't bothered to even try making it an external project, so it doesn't

Re: kvmtool tree (Was: Re: [patch] config: fix make kvmconfig)

2013-02-11 Thread Pekka Enberg
On Mon, Feb 11, 2013 at 2:26 PM, Ingo Molnar mi...@kernel.org wrote: IIRC Windows support for kmvtool is work in progress - some patches already got applied. People are working on SeaBIOS support which is just one part of running Windows. But yeah, we'll hopefully support non-Linux guest at

Re: [tip:x86/cpu] x86, AMD: Enable WC+ memory type on family 10 processors

2013-02-13 Thread Pekka Enberg
On Wed, Feb 13, 2013 at 2:21 AM, H. Peter Anvin h...@zytor.com wrote: + rdmsrl(MSR_AMD64_BU_CFG2, value); + value = ~(1ULL 24); + wrmsrl(MSR_AMD64_BU_CFG2, value); + } }

Re: kvmtool tree (Was: Re: [patch] config: fix make kvmconfig)

2013-02-13 Thread Pekka Enberg
On Wed, Feb 13, 2013 at 10:23 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 12/02/2013 10:52, Ingo Molnar ha scritto: Check the list I gave (unmodified): - Pekka listed new virtio drivers that were done via tools/kvm. vhost-scsi got in first in tools/kvm, but out-of-tree patches had

Re: [PATCH 1/6] kvm tools: Return error status in lkvm list

2013-02-06 Thread Pekka Enberg
Applied all patches, thanks a lot Michael! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch] config: fix make kvmconfig

2013-02-06 Thread Pekka Enberg
On Mon, Feb 4, 2013 at 9:13 PM, Ingo Molnar mi...@kernel.org wrote: * Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Feb 04, 2013 at 10:57:35AM -0800, David Rientjes wrote: On Mon, 4 Feb 2013, Ingo Molnar wrote: arch/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)

Re: next-20130204 - bisected slab problem to slab: Common constants for kmalloc boundaries

2013-02-06 Thread Pekka Enberg
On Wed, Feb 6, 2013 at 11:44 AM, James Hogan james.ho...@imgtec.com wrote: On 05/02/13 18:34, Christoph Lameter wrote: On Tue, 5 Feb 2013, James Hogan wrote: On 05/02/13 16:36, Christoph Lameter wrote: OK I was able to reproduce it by setting ARCH_DMA_MINALIGN in slab.h. This patch fixes it

Re: [patch] config: fix make kvmconfig

2013-02-06 Thread Pekka Enberg
On Wed, Feb 6, 2013 at 10:12 PM, David Rientjes rient...@google.com wrote: What's the endgame for kvmtool/next? The patch that this fixes has been sitting in linux-next for over 15 months and hasn't been pulled by Linus, yet some find it to be quite useful. Is it a permanent addition to

Re: [PATCH 00/11] lockdep: LD_PRELOAD support

2013-02-06 Thread Pekka Enberg
On Thu, Feb 7, 2013 at 12:11 AM, Sasha Levin sasha.le...@oracle.com wrote: This patch series adds in LD_PRELOAD support for liblockdep. FWIW, Acked-by: Pekka Enberg penb...@kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 0/7] liblock: userspace lockdep

2013-01-31 Thread Pekka Enberg
, the last one is an example of liblock being used on an existing codebase. This is awesome, Sasha! For the whole series: Acked-by: Pekka Enberg penb...@kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-26 Thread Pekka Enberg
On Fri, Feb 22, 2013 at 7:23 PM, Christoph Lameter c...@linux.com wrote: On Fri, 22 Feb 2013, Glauber Costa wrote: On 02/22/2013 09:01 PM, Christoph Lameter wrote: Argh. This one was the final version: https://patchwork.kernel.org/patch/2009521/ It seems it would work. It is all the

Re: [RESEND PATCH v5 1/4] zram: Fix deadlock bug in partial write

2013-01-27 Thread Pekka Enberg
On Mon, Jan 28, 2013 at 2:38 AM, Minchan Kim minc...@kernel.org wrote: Now zram allocates new page with GFP_KERNEL in zram I/O path if IO is partial. Unfortunately, It may cuase deadlock with s/cuase/cause/g reclaim path so this patch solves the problem. It'd be nice to know about the

Re: [RESEND PATCH v5 1/4] zram: Fix deadlock bug in partial write

2013-01-28 Thread Pekka Enberg
On Mon, Jan 28, 2013 at 1:24 PM, Jerome Marchand jmarc...@redhat.com wrote: On 01/28/2013 08:16 AM, Pekka Enberg wrote: On Mon, Jan 28, 2013 at 2:38 AM, Minchan Kim minc...@kernel.org wrote: Now zram allocates new page with GFP_KERNEL in zram I/O path if IO is partial. Unfortunately, It may

Re: [RESEND PATCH v5 1/4] zram: Fix deadlock bug in partial write

2013-01-28 Thread Pekka Enberg
...@kernel.org [ penb...@kernel.org: don't use GFP_ATOMIC ] Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/staging/zram/zram_drv.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index f2a73bd..071e058

Re: [RFC/PATCH] scripts/tracing: Add trace_analyze.py tool

2013-01-22 Thread Pekka Enberg
#Current_dynamic_footprint Cc: Pekka Enberg penb...@kernel.org Cc: Steven Rostedt rost...@goodmis.org Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@redhat.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com Looks really useful! Dunno if this makes most sense as a separate script

Re: [PATCH v2] kvm tools: remove redundant if condition

2013-01-22 Thread Pekka Enberg
On Sat, Jan 19, 2013 at 12:27 PM, Cong Ding ding...@gmail.com wrote: On Sat, Jan 19, 2013 at 10:58:33AM +0200, Pekka Enberg wrote: On Wed, Jan 16, 2013 at 6:52 PM, Cong Ding ding...@gmail.com wrote: After we check (state.kcount != 0), state.kcount has to be 0 in all the else branchs

Re: [PATCH v2] kvm tools: close opened file

2013-01-19 Thread Pekka Enberg
On Wed, Jan 16, 2013 at 6:51 PM, Cong Ding ding...@gmail.com wrote: The file should be closed before return. Signed-off-by: Cong Ding ding...@gmail.com Applied, thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH v2] kvm tools: remove redundant if condition

2013-01-19 Thread Pekka Enberg
On Wed, Jan 16, 2013 at 6:52 PM, Cong Ding ding...@gmail.com wrote: After we check (state.kcount != 0), state.kcount has to be 0 in all the else branchs. Signed-off-by: Cong Ding ding...@gmail.com --- tools/kvm/hw/i8042.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] mm/slab: add a leak decoder callback

2013-01-19 Thread Pekka Enberg
Hello, On Mon, Jan 14, 2013 at 8:03 AM, Liu Bo bo.li@oracle.com wrote: This adds a leak decoder callback so that kmem_cache_destroy() can use to generate debugging output for the allocated objects. Callers like btrfs are using their own leak tracking which will manage allocated objects

[RFC][PATCH] VFS: update documentation (take #2)

2005-08-24 Thread Pekka Enberg
Hi, This patch brings the now out-of-date Documentation/filesystems/vfs.txt back to life. Thanks to Carsten Otte for the description on get_xip_page(). Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- vfs.txt | 382 1 file

Re: [PATCH 1/7] spufs: The SPU file system

2005-08-26 Thread Pekka Enberg
Hi Arnd, This is a work-in-progress version of the SPU file system. --- linux-cg.orig/fs/spufs/file.c 1969-12-31 19:00:00.0 -0500 +++ linux-cg/fs/spufs/file.c 2005-08-25 22:27:19.503976592 -0400 @@ -0,0 +1,716 @@ +/* + * SPU file system -- file contents +/* low-level mailbox

[PATCH] pipe: remove redundant fifo_poll abstraction

2005-08-26 Thread Pekka Enberg
fifo_poll() abstraction from fs/pipe.c and adds a big fat comment stating we set POLLERR for FIFOs too on Linux unlike most Unices. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- pipe.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) Index: 2.6-mm/fs/pipe.c

Re: help

2005-08-27 Thread Pekka Enberg
On 8/27/05, raja [EMAIL PROTECTED] wrote: Hi, I am new to linux kernel programming.Will you please give me the useful mailing lists and how to subscribe please. Please refer to http://www.kernelnewbies.org/. Pekka - To unsubscribe from this list: send the

Re: [PATCH 1/7] spufs: The SPU file system

2005-08-28 Thread Pekka Enberg
On Sun, 2005-08-28 at 18:44 +0200, Arnd Bergmann wrote: I never really thought of it as a device driver but rather an architecture extension, so it started out in arch/ppc64/kernel. Since most of the code is interacting with VFS, it is now in fs/spufs. I don't really care about the location,

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread Pekka Enberg
Hi, Some coding style nitpicks. On 8/30/05, Machida, Hiroyuki [EMAIL PROTECTED] wrote: +inline +static int hint_allocate(struct inode *dir) +{ + void *hints; + int err = 0; + + if (!MSDOS_I(dir)-scan_hints) { + hints =

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread Pekka Enberg
Hi, Some more. On 8/30/05, Machida, Hiroyuki [EMAIL PROTECTED] wrote: --- old/fs/fat/inode.c 2005-08-29 09:38:53.308587787 +0900 +++ new/fs/fat/inode.c 2005-08-29 09:39:33.889555606 +0900 @@ -345,6 +347,15 @@ static void fat_delete_inode(struct inod static void fat_clear_inode(struct

Re: [PATCH][FAT] FAT dirent scan with hin take #3

2005-08-31 Thread Pekka Enberg
Hi, On 8/31/05, Machida, Hiroyuki [EMAIL PROTECTED] wrote: +inline +static int hint_allocate(struct inode *dir) +{ + loff_t *hints; + int err = 0; + + if (!MSDOS_I(dir)-scan_hints) { + hints = kcalloc(FAT_SCAN_NWAY, sizeof(loff_t), GFP_KERNEL); +

Re: [PATCH][FAT] FAT dirent scan with hin take #3

2005-08-31 Thread Pekka Enberg
On 8/31/05, Machida, Hiroyuki [EMAIL PROTECTED] wrote: +inline +static int hint_index_body(const unsigned char *name, int name_len, int check_null) +{ + int i; + int val = 0; + unsigned char *p = (unsigned char *) name; + int id = current-pid; + + for (i=0;

Re: [PATCH][FAT] FAT dirent scan with hin take #3

2005-08-31 Thread Pekka Enberg
Hi, On 8/31/05, Machida, Hiroyuki [EMAIL PROTECTED] wrote: Sorry, I send out wrong version. I attached the latest patch to 2.6.13. OGAWA Hirofumi wrote: Machida, Hiroyuki [EMAIL PROTECTED] writes: Here is a revised version of dirent scan patch, mentioned at following E-mail.

Re: [PATCH][FAT] FAT dirent scan with hin take #3

2005-08-31 Thread Pekka Enberg
On 8/31/05, Machida, Hiroyuki [EMAIL PROTECTED] wrote: Please consider moving this check to callers. Conditional allocation makes this bit strange API-wise. Or alternatively, give hint_allocate() a better name. How about hint_allocate_conditional() ? hint_get() sounds better to me.

Re: [PATCH][FAT] FAT dirent scan with hin take #3

2005-08-31 Thread Pekka Enberg
On 8/31/05, Machida, Hiroyuki [EMAIL PROTECTED] wrote: How about this ? if (!MSDOS_I(dir)-scan_hints) { hints = kcalllo(); down if (MSDOS_I(dir)-scan_hints) { up goto

Re: [PATCH][FAT] FAT dirent scan with hin take #3

2005-08-31 Thread Pekka Enberg
On 8/31/05, Pekka Enberg [EMAIL PROTECTED] wrote: After finally understanding what you're doing, how about: static inline int hint_allocate(struct inode *dir) { loff_t *hints; int err = 0; if (!MSDOS_I(dir)-scan_hints) Should read: if (MSDOS_I(dir)-scan_hints

Re: GFS, what's remaining

2005-09-01 Thread Pekka Enberg
On 9/1/05, David Teigland [EMAIL PROTECTED] wrote: - Adapt the vfs so gfs (and other cfs's) don't need to walk vma lists. [cf. ops_file.c:walk_vm(), gfs works fine as is, but some don't like it.] It works fine only if you don't care about playing well with other clustered filesystems.

[PATCH] fat: Remove duplicate directory scanning code

2005-09-04 Thread Pekka Enberg
-by: Pekka Enberg [EMAIL PROTECTED] --- dir.c | 239 +++--- 1 file changed, 113 insertions(+), 126 deletions(-) Index: 2.6/fs/fat/dir.c === --- 2.6.orig/fs/fat/dir.c +++ 2.6/fs

Re: RFC: i386: kill !4KSTACKS

2005-09-04 Thread Pekka Enberg
On 9/4/05, Paul Misner [EMAIL PROTECTED] wrote: No one is asking you to 'care' about our problems running a notebook with a closed source driver under ndiswrapper. Yes you are. You're asking for 4KSTACKS config option to maintained and it is not something you get for free. Besides, if it is

Re: RFC: i386: kill !4KSTACKS

2005-09-05 Thread Pekka Enberg
On 9/5/05, Willy Tarreau [EMAIL PROTECTED] wrote: Except that someone has to maintain the patch, because with the speed the kernel is changing, a patch against 2.6.14 will not work on 2.6.15. Indeed. It has to be maintained in tree as well and I don't see any justification for making mainline

Re: GFS, what's remaining

2005-09-05 Thread Pekka Enberg
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote: +void gfs2_glock_hold(struct gfs2_glock *gl) +{ + glock_hold(gl); +} eh why? On 9/5/05, David Teigland [EMAIL PROTECTED] wrote: You removed the comment stating exactly why, see below. If that's not a accepted

Re: [Linux-cluster] GFS - updated patches

2005-08-11 Thread Pekka Enberg
On 8/11/05, Michael [EMAIL PROTECTED] wrote: Hi, Dave, I quickly applied gfs2 and dlm patches in kernel 2.6.12.2, it passed compiling but has some warning log, see attachment. maybe helpful to you. kzalloc is not in Linus' tree yet. Try with 2.6.13-rc5-mm1.

Re: GFS - updated patches

2005-08-11 Thread Pekka Enberg
Hi, On 8/11/05, David Teigland [EMAIL PROTECTED] wrote: The large majority, and I think all that people care about. If we ignored something that someone thinks is important, a reminder would be useful. The only remaining issue for me is the vma walk. Thanks, David!

Re: [patch 6/7] mm: lockless pagecache

2005-08-11 Thread Pekka Enberg
Hi Nick, On 8/11/05, Nick Piggin [EMAIL PROTECTED] wrote: +unsigned find_get_pages_nonatomic(struct address_space *mapping, pgoff_t start, + unsigned int nr_pages, struct page **pages) +{ + unsigned int i; + unsigned int ret; Rename to nr_pages? +

Re: GFS

2005-08-11 Thread Pekka Enberg
On Thu, 2005-08-11 at 09:33 -0700, Zach Brown wrote: I don't think this patch is the way to go at all. It imposes an allocation and vma walking overhead for the vast majority of IOs that aren't interested. It doesn't look like it will get a consistent ordering when multiple file systems are

Re: Reusing the slab allocator

2005-08-13 Thread Pekka Enberg
On 8/10/05, Jon Smirl [EMAIL PROTECTED] wrote: We need a memory manager for the VRAM on video cards. The most common video cards have been 2MB and 512MB memory. Is it possible to reuse the kernel slab allocator for managing this memory? There are a couple of other odd constraints. 1) Some

Re: sysfs: write returns ENOMEM?

2005-08-19 Thread Pekka Enberg
Hi Dmitry, On 8/19/05, Dmitry Torokhov [EMAIL PROTECTED] wrote: According to the SuS write() can not return ENOMEM, only ENOBUFS is allowed (surprisingly read() is allowed to use both ENOMEM and ENOBUFS): http://www.opengroup.org/onlinepubs/95399/functions/write.html Should we adjust

Re: [Documentation] Use doxygen or another tool to generate a documentation ?

2005-08-19 Thread Pekka Enberg
On 8/20/05, Stephane Wirtel [EMAIL PROTECTED] wrote: I don't know if there is a project based on Doxygen to make (or generate) a documentation of the kernel. Do you think that will be interesting to make a such document ? The kernel already has it's own API documentation generator called

[RFC][PATCH] VFS: update documentation

2005-08-21 Thread Pekka Enberg
Hi! This patch updates the out-of-date Documentation/filesystems/vfs.txt. As I am a novice on the VFS, I would much appreciate any comments and help on this. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- vfs.txt | 314 +--- 1

Re: [RFC: -mm patch] kcalloc(): INT_MAX - ULONG_MAX

2005-08-21 Thread Pekka Enberg
On Sun, Aug 21, 2005 at 10:47:13PM +0300, Pekka Enberg wrote: You'll probably get even better code if you change the above to: if (size != 0 n ULONG_MAX / size) Reason being that size is virtually always a constant so the compiler can evaluate the division at compile-time. On 8

Re: [RFC: -mm patch] kcalloc(): INT_MAX - ULONG_MAX

2005-08-21 Thread Pekka Enberg
On 8/20/05, Adrian Bunk [EMAIL PROTECTED] wrote: This change could (at least in theory) allow a compiler better optimization (especially in the n=1 case). The practical effect seems to be nearly zero: text data bss dechex filename 256172075850138

Re: sysfs: write returns ENOMEM?

2005-08-23 Thread Pekka Enberg
-by: Pekka Enberg [EMAIL PROTECTED] --- read_write.c |2 ++ 1 files changed, 2 insertions(+) Index: 2.6-mm/fs/read_write.c === --- 2.6-mm.orig/fs/read_write.c +++ 2.6-mm/fs/read_write.c @@ -310,6 +310,8 @@ ssize_t vfs_write(struct file

Re: [PATCH] slab: cache_grow cleanup

2007-01-28 Thread Pekka Enberg
Hi Andrew, On 1/28/07, Andrew Morton [EMAIL PROTECTED] wrote: This gets its local interrupt state mucked up. BUG: sleeping function called from invalid context at mm/slab.c:3038 in_atomic():0, irqs_disabled():1 no locks held by init/1. irq event stamp: 656902 hardirqs last enabled at

Re: [PATCH] tty: cleanup release_mem

2007-01-29 Thread Pekka Enberg
On 1/30/07, Andrew Morton [EMAIL PROTECTED] wrote: BUG: unable to handle kernel paging request at virtual address 6b6b6bdf Use after free. The new code does module_put() _after_ free_tty_struct() which is obviously wrong. - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: Linux 2.6.20-rc7

2007-01-31 Thread Pekka Enberg
On 1/31/07, Linus Torvalds [EMAIL PROTECTED] wrote: When do_tune_cpucache() is called at bootup, I'm not sure how safe it is to do the kzalloc() thing. The kzalloc thing is safe as we have already successfully boostrapped all kmalloc caches at that point. The per-CPU caches that are replaced

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread Pekka Enberg
On 12/31/06, Mitch Bradley [EMAIL PROTECTED] wrote: diff --git a/arch/i386/kernel/ofw_fs.c b/arch/i386/kernel/ofw_fs.c new file mode 100644 index 000..30ca359 --- /dev/null +++ b/arch/i386/kernel/ofw_fs.c @@ -0,0 +1,261 @@ +/* 1275 in little-endian ASCII (for IEEE 1275 - the Open Firmware

Re: [PATCH] include/linux/slab.h: new KFREE() macro.

2007-01-01 Thread Pekka Enberg
On 1/1/07, Amit Choudhary [EMAIL PROTECTED] wrote: +#define KFREE(x) \ + do {\ + kfree(x); \ + x = NULL; \ + } while(0) NAK until you have actual callers for it. CONFIG_SLAB_DEBUG already catches use after

Re: [PATCH] slab: add missing debug_check_no_locks_freed for kmem_cache_free

2007-01-02 Thread Pekka Enberg
Pekka J Enberg [EMAIL PROTECTED] wrote: Add a missing debug_check_no_locks_freed() debug check for kmem_cache_free(). On 1/2/07, Ingo Molnar [EMAIL PROTECTED] wrote: hm, i have a similar fix in -rt already, and i sent a patch for this: http://lkml.org/lkml/2006/12/18/104 have i missed

Re: [PATCH] slab: cache alloc cleanups

2007-01-02 Thread Pekka Enberg
On Tue, 2 Jan 2007, Pekka J Enberg wrote: + + if (nodeid == -1 || nodeid == numa_node_id()) { + if (unlikely(current-flags (PF_SPREAD_SLAB | PF_MEMPOLICY))) { + obj = alternate_node_alloc(cache, flags); + if (obj) +

Re: [PATCH] fix BUG_ON(!PageSlab) from fallback_alloc

2007-01-04 Thread Pekka Enberg
Hi Hugh, [Sorry, no access to kernel tree right now, so can't send a patch.] On 1/4/07, Hugh Dickins [EMAIL PROTECTED] wrote: @@ -3310,7 +3310,7 @@ retry: */ goto retry; } else { -

Re: [PATCH] fix BUG_ON(!PageSlab) from fallback_alloc

2007-01-04 Thread Pekka Enberg
and Christoph to fight over later! Fair enough :-) Acked-by: Pekka Enberg [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] slab: cache alloc cleanups

2007-01-04 Thread Pekka Enberg
On 1/4/07, Christoph Hellwig [EMAIL PROTECTED] wrote: Seems to work nicely on my 2node cell blade. Thanks for testing. Unfortunately as the other Christoph pointed out, my patch reintroduces a bug that was fixed a while ago. kmalloc_node should not be using mempolicies... - To unsubscribe from

Re: [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts

2007-01-05 Thread Pekka Enberg
On 1/5/07, Robert P. J. Day [EMAIL PROTECTED] wrote: in this case, as mr. beer suggests, you should also check if this represents a kmalloc-kzalloc cleanup (there's lots of those), and also see if you can replace one of these: sizeof(struct blah) with one of these: sizeof(*blahptr)

Re: Oops with 2.6.29.1 (slab_get_obj,free_block,journal_write_metadata_buffer)

2007-01-07 Thread Pekka Enberg
On 1/7/07, Sebastian Kärgel [EMAIL PROTECTED] wrote: BUG: unable to handle kernel paging request at virtual address 1b1ca570 printing eip: c014c3b1 *pde = Oops: [#1] Modules linked in: CPU:0 EIP:0060:[c014c3b1]Not tainted VLI EFLAGS: 00010807 (2.6.19.1 #1) EIP is at

Re: 2.6.20-rc3-git4 oops on suspend: __drain_pages

2007-01-07 Thread Pekka Enberg
On Thu, 4 Jan 2007, Robert Hancock wrote: Saw this oops on 2.6.20-rc3-git4 when attempting to suspend. This only happened in 1 of 3 attempts. On Friday, 5 January 2007 20:15, Christoph Lameter wrote: See the fix that I posted yesterday to linux-mm. Its now in Andrew's tree. On 1/5/07,

Re: [PATCH] include/linux/slab.h: new KFREE() macro.

2007-01-08 Thread Pekka Enberg
On 1/8/07, Hua Zhong [EMAIL PROTECTED] wrote: And as I explained, it can result in longer code too. So, why keep this value around. Why not re-initialize it to NULL. Because initialization increases code size. And it also effectively blocks the slab debugging code from doing its job

Re: [PATCH] include/linux/slab.h: new KFREE() macro.

2007-01-08 Thread Pekka Enberg
Hi Amit, On 1/8/07, Amit Choudhary [EMAIL PROTECTED] wrote: Man, doesn't make sense to me. Well, man, double-free is a programming error and papering over it with NULL initializations bloats the kernel and makes the code confusing. Clear enough for you? - To unsubscribe from this list: send

Re: [PATCH] include/linux/slab.h: new KFREE() macro.

2007-01-08 Thread Pekka Enberg
On 1/8/07, Amit Choudhary [EMAIL PROTECTED] wrote: It is a programming error because the underlying code cannot handle it. Yes. Do you also grasp the fact that there is no way for the allocator to handle it either? So, double-free, from allocator standpoint can _never_ be no-op. What you're

Re: [PATCH] slab: cache_grow cleanup

2007-01-10 Thread Pekka Enberg
On 1/9/07, Christoph Lameter [EMAIL PROTECTED] wrote: I am loosing track of these. What is the difference to earlier versions? It is just a rediff on top of Linus' tree as Hugh's fix already went in. Pekka - To unsubscribe from this list: send the line

Re: [PATCH 00/14] GFS

2005-08-02 Thread Pekka Enberg
Hi David, On 8/2/05, David Teigland [EMAIL PROTECTED] wrote: Hi, GFS (Global File System) is a cluster file system that we'd like to see added to the kernel. The 14 patches total about 900K so I won't send them to the list unless that's requested. Comments and suggestions are welcome.

Re: [PATCH 00/14] GFS

2005-08-03 Thread Pekka Enberg
Hi David, Some more comments below. Pekka On 8/2/05, David Teigland [EMAIL PROTECTED] wrote: +/** + * inode_create - create a struct gfs2_inode + * @i_gl: The glock covering the inode + * @inum: The inode number + * @io_gl: the iopen glock to acquire/hold

Re: [PATCH][ACPI] toshiba_acpi.c: add check for NULL pointer

2005-08-04 Thread Pekka Enberg
On 8/4/05, Hmamouche, Youssef [EMAIL PROTECTED] wrote: --- a/drivers/acpi/toshiba_acpi.c 2005-07-15 14:18:57.0 -0700 +++ b/drivers/acpi/toshiba_acpi.c 2005-08-03 21:35:12.0 -0700 @@ -263,6 +263,9 @@ * destination so that sscanf can be used on it safely.

[PATCH] kernel: use kcalloc instead kmalloc/memset

2005-08-04 Thread Pekka Enberg
This patch converts kernel/ to use kcalloc instead of kmalloc/memset. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- intermodule.c |3 +-- params.c |4 ++-- power/pm.c|3 +-- resource.c|3 +-- workqueue.c |3 +-- 5 files changed, 6 insertions(+), 10

[PATCH 0/8] convert kcalloc to kzalloc

2005-08-05 Thread Pekka Enberg
This patchkit converts kcalloc(1, ...) to the new kzalloc(). Andrew, please let me know if you don't want to pick up some of these. I will feed them to subsystem maintainers once kzalloc() hits Linus' tree. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- arch/ia64/sn/kernel/io_init.c

[PATCH 1/8] IA64: convert kcalloc to kzalloc

2005-08-05 Thread Pekka Enberg
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- kernel/io_init.c |2 +- kernel/tiocx.c |2 +- pci/tioca_provider.c |8 3 files changed, 6 insertions(+), 6 deletions(-) Index: 2.6/arch

[PATCH 6/8] drivers: convert kcalloc to kzalloc

2005-08-05 Thread Pekka Enberg
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- block/aoe/aoedev.c |2 +- char/mbcs.c |2 +- i2c/chips/isp1301_omap.c |2 +- infiniband/core/sysfs.c |2 +- scsi/sata_qstor.c

[PATCH 4/8] USB: convert kcalloc to kzalloc

2005-08-05 Thread Pekka Enberg
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- atm/usbatm.c |2 +- core/hcd.c |2 +- host/ehci-sched.c |2 +- host/isp116x-hcd.c |2 +- host/sl811-hcd.c |2 +- input/acecad.c

[PATCH 5/8] PCI: convert kcalloc to kzalloc

2005-08-05 Thread Pekka Enberg
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- hotplug/sgi_hotplug.c |2 +- pci-sysfs.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: 2.6/drivers/pci/hotplug/sgi_hotplug.c

[PATCH 2/8] PPC64: convert kcalloc to kzalloc

2005-08-05 Thread Pekka Enberg
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- pSeries_reconfig.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: 2.6/arch/ppc64/kernel/pSeries_reconfig.c

[PATCH 3/8] input: convert kcalloc to kzalloc

2005-08-05 Thread Pekka Enberg
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- gameport/emu10k1-gp.c |2 +- gameport/fm801-gp.c |2 +- gameport/ns558.c |4 ++-- joystick/a3d.c|2 +- joystick/adi.c|2

[PATCH 7/8] fs: convert kcalloc to kzalloc

2005-08-05 Thread Pekka Enberg
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function. Signed-off-by: Pekka Enberg [EMAIL PROTECTED] --- cifs/connect.c| 82 +- freevxfs/vxfs_super.c |2 - 2 files changed, 42 insertions(+), 42 deletions

Re: [PATCH 8/8] ALSA: convert kcalloc to kzalloc

2005-08-06 Thread Pekka Enberg
Hi, Dmitry Torokhov wrote: Have you seen the following in include/sound/core? ... #define kmalloc(size, flags) snd_hidden_kmalloc(size, flags) #define kcalloc(n, size, flags) snd_hidden_kcalloc(n, size, flags) #define kfree(obj) snd_hidden_kfree(obj) On Fri, 2005-08-05 at 17:10

Re: [PATCH 8/8] ALSA: convert kcalloc to kzalloc

2005-08-06 Thread Pekka Enberg
On Fri, 2005-08-05 at 10:22 -0500, Dmitry Torokhov wrote: On 8/5/05, Pekka Enberg [EMAIL PROTECTED] wrote: This patch converts kcalloc(1, ...) calls to use the new kzalloc() function. Hi, Have you seen the following in include/sound/core? ... #define kmalloc(size, flags

Re: [PATCH] kernel: use kcalloc instead kmalloc/memset

2005-08-06 Thread Pekka Enberg
On Sat, 2005-08-06 at 02:40 +0200, Roman Zippel wrote: I actually looked at the current kcalloc users and besides a few unchecked module parameters, the arguments were either constant or had to be checked anyway. I didn't find a single example which required the safety of kcalloc(). Every

Re: Patch of a new driver for kernel 2.4.x that need review

2005-08-09 Thread Pekka Enberg
On 8/8/05, Mark Gross [EMAIL PROTECTED] wrote: Please tell me what you think :) The formatting seems completely messed up presumably because of your email client. On 8/8/05, Mark Gross [EMAIL PROTECTED] wrote: + alarm_events = kcalloc(sizeof(struct tlclk_alarms), 1, GFP_KERNEL); The first

<    1   2   3   4   5   6   7   8   9   10   >