On Fri, 2005-07-08 at 15:34 +0200, Roman Zippel wrote:
> Are the advantages big enough to actively discourage defines? It's nice
> that you do reviews, but please leave some room for personal preferences.
> If the code is correct and perfectly readable, it doesn't matter whether
> to use
Hi,
On Fri, 2005-07-08 at 21:11 +0200, Roman Zippel wrote:
> So it basically comes down to personal preference, if the original uses
> defines and it works fine, I don't really see a good enough reason to
> change it to enums, so please leave the decision to author.
(And I don't see a good
Hi Roman,
At some point in time, I wrote:
> > Roman, it is not as if I get to decide for the patch submitters. I
> > comment on any issues _I_ have with the patch and the authors fix
> > whatever they want (or what the maintainers ask for).
On Fri, 2005-07-08 at 21:59 +0200, Roman Zippel wrote:
Hi Benjamin,
On Tue, 2005-03-08 at 22:29 +0100, Kronos wrote:
> > kfree(NULL) is fine, no need to check for null pointer.
On Wed, 09 Mar 2005 09:46:20 +1100, Benjamin Herrenschmidt
<[EMAIL PROTECTED]> wrote:
> Hehe, yes, but I don't like it :)
Please consider doing that anyway as there are
Hi Benjamin,
Few coding style nitpicks follow.
On Tue, 08 Mar 2005 18:11:59 +1100, Benjamin Herrenschmidt
<[EMAIL PROTECTED]> wrote:
> Index: linux-work/include/linux/pci.h
> ===
> --- linux-work.orig/include/linux/pci.h
Some of my usual coding style comments...
On Fri, 11 Mar 2005 11:21:32 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote:
> diff -puN /dev/null drivers/net/chelsio/osdep.h
> --- /dev/null 2003-09-15 06:40:47.0 -0700
> +++ 25-akpm/drivers/net/chelsio/osdep.h 2005-03-11
Hi,
Few more coding style comments.
On Fri, 11 Mar 2005 11:21:32 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote:
> diff -puN /dev/null drivers/net/chelsio/cxgb2.c
> --- /dev/null 2003-09-15 06:40:47.0 -0700
> +++ 25-akpm/drivers/net/chelsio/cxgb2.c 2005-03-11 11:13:06.0
>
Hi,
On Tue, 1 Feb 2005 03:28:21 +, [EMAIL PROTECTED]
<[EMAIL PROTECTED]> wrote:
>
> This patch creates the kstrdup library function so that it doesn't have to be
> reimplemented (or even EXPORT'ed) by every user that needs it.
>
> Signed-off-by: Paulo Marques <[EMAIL PROTECTED]>
>
> diff
At some point in time, I wrote:
> > kstrdup() is a special-case _memory allocator_ (not so much a string
> > operation) so I think it should go into mm/slab.c where we currently
> > have kcalloc().
On Tue, 01 Feb 2005 17:00:17 +, Paulo Marques <[EMAIL PROTECTED]> wrote:
> I was following
Hi,
On Fri, 4 Feb 2005 01:22:54 -0600, Olof Johansson <[EMAIL PROTECTED]> wrote:
> +#define CPU_HAS_FEATURE(x) (cur_cpu_spec->cpu_features & CPU_FTR_##x)
> +
Please drop the CPU_FTR_##x macro magic as it makes grepping more
complicated. If the enum names are too long, just do
On Fri, 2005-02-04 at 11:20 -0600, Olof Johansson wrote:
> * cpu-has-feature(cpu-feature-foo) v cpu-has-feature(foo): I picked the
> latter for readability.
> * Renaming CPU_FTR_ -> CPU_ makes it less obvious that
> it's actually a cpu feature it's describing (i.e. CPU_ALTIVEC vs
>
Hi,
On Fri, 25 Mar 2005 17:29:56 -0500 (EST), linux-os
<[EMAIL PROTECTED]> wrote:
> Isn't it expensive of CPU time to call kfree() even though the
> pointer may have already been freed? I suggest that the check
> for a NULL before the call is much less expensive than calling
> kfree() and doing
Hi,
This patch removes one redundant variable from mm/thrash.c and
moves the declaration of one variable closer to the block where
it is actually used.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
thrash.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
Index:
Hi,
Here's a version that applies with -p1. Quilt did some silly things to
the previous one...
This patch removes one redundant variable from mm/thrash.c and moves
declaration of one variable closer to the block where it is actually used.
Signed-off-by: Pekka Enberg <[EMAIL PROTEC
Hi David,
On 8/2/05, David Teigland <[EMAIL PROTECTED]> wrote:
> Hi, GFS (Global File System) is a cluster file system that we'd like to
> see added to the kernel. The 14 patches total about 900K so I won't send
> them to the list unless that's requested. Comments and suggestions are
> welcome.
Hi David,
Some more comments below.
Pekka
On 8/2/05, David Teigland <[EMAIL PROTECTED]> wrote:
> +/**
> + * inode_create - create a struct gfs2_inode
> + * @i_gl: The glock covering the inode
> + * @inum: The inode number
> + * @io_gl: the iopen glock to
On 8/4/05, Hmamouche, Youssef <[EMAIL PROTECTED]> wrote:
> --- a/drivers/acpi/toshiba_acpi.c 2005-07-15 14:18:57.0 -0700
> +++ b/drivers/acpi/toshiba_acpi.c 2005-08-03 21:35:12.0 -0700
> @@ -263,6 +263,9 @@
> * destination so that sscanf can be used on it
This patch converts kernel/ to use kcalloc instead of kmalloc/memset.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
intermodule.c |3 +--
params.c |4 ++--
power/pm.c|3 +--
resource.c|3 +--
workqueue.c |3 +--
5 files changed, 6 insertions(
This patchkit converts kcalloc(1, ...) to the new kzalloc(). Andrew, please
let me know if you don't want to pick up some of these. I will feed them to
subsystem maintainers once kzalloc() hits Linus' tree.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
arch/ia64/sn/kernel/io_
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
kernel/io_init.c |2 +-
kernel/tiocx.c |2 +-
pci/tioca_provider.c |8
3 files changed, 6 insertions(+), 6 deletions(-)
Inde
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
block/aoe/aoedev.c |2 +-
char/mbcs.c |2 +-
i2c/chips/isp1301_omap.c |2 +-
infiniband/core/sysfs.c |2 +-
scsi/sata_q
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
atm/usbatm.c |2 +-
core/hcd.c |2 +-
host/ehci-sched.c |2 +-
host/isp116x-hcd.c |2 +-
host/sl811-hcd.c |2 +-
input/ac
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
hotplug/sgi_hotplug.c |2 +-
pci-sysfs.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Index: 2.6/drivers/pci/hotplug/sgi_hot
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
pSeries_reconfig.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: 2.6/arch/ppc64/kernel/pSeries_reco
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
gameport/emu10k1-gp.c |2 +-
gameport/fm801-gp.c |2 +-
gameport/ns558.c |4 ++--
joystick/a3d.c|2 +-
joystick/adi.c
This patch converts kcalloc(1, ...) calls to use the new kzalloc() function.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
cifs/connect.c| 82 +-
freevxfs/vxfs_super.c |2 -
2 files changed, 42 insertions(+), 42 del
Hi,
Dmitry Torokhov wrote:
> > Have you seen the following in include/sound/core?
> >
> > ...
> > #define kmalloc(size, flags) snd_hidden_kmalloc(size, flags)
> > #define kcalloc(n, size, flags) snd_hidden_kcalloc(n, size, flags)
> > #define kfree(obj) snd_hidden_kfree(obj)
On Fri, 2005-08-05
On Fri, 2005-08-05 at 10:22 -0500, Dmitry Torokhov wrote:
> On 8/5/05, Pekka Enberg <[EMAIL PROTECTED]> wrote:
> > This patch converts kcalloc(1, ...) calls to use the new kzalloc() function.
> >
>
> Hi,
>
> Have you seen the following in include/sound/core
On Sat, 2005-08-06 at 02:40 +0200, Roman Zippel wrote:
> I actually looked at the current kcalloc users and besides a few unchecked
> module parameters, the arguments were either constant or had to be checked
> anyway. I didn't find a single example which required the "safety" of
> kcalloc().
On 8/8/05, Mark Gross <[EMAIL PROTECTED]> wrote:
> Please tell me what you think :)
The formatting seems completely messed up presumably because of your
email client.
On 8/8/05, Mark Gross <[EMAIL PROTECTED]> wrote:
> + alarm_events = kcalloc(sizeof(struct tlclk_alarms), 1, GFP_KERNEL);
The
On Mon, 2005-08-08 at 11:32 -0700, Zach Brown wrote:
> > Sorry if this is an obvious question but what prevents another thread
> > from doing mmap() before we do the second walk and messing up num_gh?
>
> Nothing, I suspect. OCFS2 has a problem like this, too. It wants a way
> for a file system
On 8/11/05, Michael <[EMAIL PROTECTED]> wrote:
> Hi, Dave,
>
> I quickly applied gfs2 and dlm patches in kernel 2.6.12.2, it passed
> compiling but has some warning log, see attachment. maybe helpful to
> you.
kzalloc is not in Linus' tree yet. Try with 2.6.13-rc5-mm1.
Hi,
On 8/11/05, David Teigland <[EMAIL PROTECTED]> wrote:
> The large majority, and I think all that people care about. If we ignored
> something that someone thinks is important, a reminder would be useful.
The only remaining issue for me is the vma walk. Thanks, David!
Hi Nick,
On 8/11/05, Nick Piggin <[EMAIL PROTECTED]> wrote:
> +unsigned find_get_pages_nonatomic(struct address_space *mapping, pgoff_t
> start,
> + unsigned int nr_pages, struct page **pages)
> +{
> + unsigned int i;
> + unsigned int ret;
Rename to
On Thu, 2005-08-11 at 09:33 -0700, Zach Brown wrote:
> I don't think this patch is the way to go at all. It imposes an
> allocation and vma walking overhead for the vast majority of IOs that
> aren't interested. It doesn't look like it will get a consistent
> ordering when multiple file systems
On 8/10/05, Jon Smirl <[EMAIL PROTECTED]> wrote:
> We need a memory manager for the VRAM on video cards. The most common
> video cards have been 2MB and 512MB memory. Is it possible to reuse
> the kernel slab allocator for managing this memory?
>
> There are a couple of other odd constraints.
>
Hi Dmitry,
On 8/19/05, Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> According to the SuS write() can not return ENOMEM, only ENOBUFS is allowed
> (surprisingly read() is allowed to use both ENOMEM and ENOBUFS):
>
> http://www.opengroup.org/onlinepubs/95399/functions/write.html
>
> Should we
On 8/20/05, Stephane Wirtel <[EMAIL PROTECTED]> wrote:
> I don't know if there is a project based on Doxygen to make
> (or generate) a documentation of the kernel.
>
> Do you think that will be interesting to make a such document ?
The kernel already has it's own API documentation generator
Hi!
This patch updates the out-of-date Documentation/filesystems/vfs.txt.
As I am a novice on the VFS, I would much appreciate any comments and
help on this.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
vfs.txt | 314 +
On Sun, Aug 21, 2005 at 10:47:13PM +0300, Pekka Enberg wrote:
> > You'll probably get even better code if you change the above to:
> >
> > if (size != 0 && n > ULONG_MAX / size)
> >
> > Reason being that size is virtually always a constant so t
On 8/20/05, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> This change could (at least in theory) allow a compiler better
> optimization (especially in the n=1 case).
>
> The practical effect seems to be nearly zero:
> text data bss dechex filename
> 25617207
().
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
read_write.c |2 ++
1 files changed, 2 insertions(+)
Index: 2.6-mm/fs/read_write.c
===
--- 2.6-mm.orig/fs/read_write.c
+++ 2.6-mm/fs/read_write.c
@@ -310,6 +310,8
Hi,
This patch brings the now out-of-date Documentation/filesystems/vfs.txt back
to life. Thanks to Carsten Otte for the description on get_xip_page().
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
vfs.txt | 382
Hi Arnd,
> This is a work-in-progress version of the SPU file system.
> --- linux-cg.orig/fs/spufs/file.c 1969-12-31 19:00:00.0 -0500
> +++ linux-cg/fs/spufs/file.c 2005-08-25 22:27:19.503976592 -0400
> @@ -0,0 +1,716 @@
> +/*
> + * SPU file system -- file contents
> +/* low-level
h removes a redundant fifo_poll() abstraction from fs/pipe.c and adds
a big fat comment stating we set POLLERR for FIFOs too on Linux unlike most
Unices.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
pipe.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
Index: 2
On 8/27/05, raja <[EMAIL PROTECTED]> wrote:
> Hi,
> I am new to linux kernel programming.Will you please give me the
> useful mailing lists and how to subscribe please.
Please refer to http://www.kernelnewbies.org/.
Pekka
-
To unsubscribe from this list: send
On 12/19/06, Andrew Morton <[EMAIL PROTECTED]> wrote:
Wow. I didn't expect that, because Mark Haber reported that ext3's
data=writeback
fixed it. Maybe he didn't run it for long enough?
I don't think it did fix it for Mark:
http://marc.theaimsgroup.com/?l=linux-kernel=116625777306843=2
-
On 12/20/06, Sébastien Dugué <[EMAIL PROTECTED]> wrote:
set_param_str() cannot use kstrdup() to duplicate the parameter. That's
fine when the driver is compiled as a module but it sure is not when
built into the kernel as the kernel parameters are parsed before the
kmalloc slabs are setup.
On 12/31/06, Mitch Bradley <[EMAIL PROTECTED]> wrote:
diff --git a/arch/i386/kernel/ofw_fs.c b/arch/i386/kernel/ofw_fs.c
new file mode 100644
index 000..30ca359
--- /dev/null
+++ b/arch/i386/kernel/ofw_fs.c
@@ -0,0 +1,261 @@
+/* 1275 in little-endian ASCII (for IEEE 1275 - the Open Firmware
On 1/1/07, Amit Choudhary <[EMAIL PROTECTED]> wrote:
+#define KFREE(x) \
+ do {\
+ kfree(x); \
+ x = NULL; \
+ } while(0)
NAK until you have actual callers for it. CONFIG_SLAB_DEBUG already
catches use after
Pekka J Enberg <[EMAIL PROTECTED]> wrote:
> Add a missing debug_check_no_locks_freed() debug check for
> kmem_cache_free().
On 1/2/07, Ingo Molnar <[EMAIL PROTECTED]> wrote:
hm, i have a similar fix in -rt already, and i sent a patch for this:
http://lkml.org/lkml/2006/12/18/104
have i
On Tue, 2 Jan 2007, Pekka J Enberg wrote:
> +
> + if (nodeid == -1 || nodeid == numa_node_id()) {
> + if (unlikely(current->flags & (PF_SPREAD_SLAB | PF_MEMPOLICY)))
{
> + obj = alternate_node_alloc(cache, flags);
> + if (obj)
> +
On Sun, 2005-08-28 at 18:44 +0200, Arnd Bergmann wrote:
> I never really thought of it as a device driver but rather an architecture
> extension, so it started out in arch/ppc64/kernel. Since most of the code
> is interacting with VFS, it is now in fs/spufs. I don't really care about
> the
Hi,
Some coding style nitpicks.
On 8/30/05, Machida, Hiroyuki <[EMAIL PROTECTED]> wrote:
> +inline
> +static int hint_allocate(struct inode *dir)
> +{
> + void *hints;
> + int err = 0;
> +
> + if (!MSDOS_I(dir)->scan_hints) {
> + hints =
Hi,
Some more.
On 8/30/05, Machida, Hiroyuki <[EMAIL PROTECTED]> wrote:
> --- old/fs/fat/inode.c 2005-08-29 09:38:53.308587787 +0900
> +++ new/fs/fat/inode.c 2005-08-29 09:39:33.889555606 +0900
> @@ -345,6 +347,15 @@ static void fat_delete_inode(struct inod
> static void
Hi,
On 8/31/05, Machida, Hiroyuki <[EMAIL PROTECTED]> wrote:
> +inline
> +static int hint_allocate(struct inode *dir)
> +{
> + loff_t *hints;
> + int err = 0;
> +
> + if (!MSDOS_I(dir)->scan_hints) {
> + hints = kcalloc(FAT_SCAN_NWAY, sizeof(loff_t), GFP_KERNEL);
>
On 8/31/05, Machida, Hiroyuki <[EMAIL PROTECTED]> wrote:
> +inline
> +static int hint_index_body(const unsigned char *name, int name_len, int
> check_null)
> +{
> + int i;
> + int val = 0;
> + unsigned char *p = (unsigned char *) name;
> + int id = current->pid;
> +
> +
Hi,
On 8/31/05, Machida, Hiroyuki <[EMAIL PROTECTED]> wrote:
>
> Sorry, I send out wrong version. I attached the latest patch to 2.6.13.
>
> OGAWA Hirofumi wrote:
> > "Machida, Hiroyuki" <[EMAIL PROTECTED]> writes:
> >
> >
> >>Here is a revised version of dirent scan patch, mentioned at
>
On 8/31/05, Machida, Hiroyuki <[EMAIL PROTECTED]> wrote:
> > Please consider moving this check to callers. Conditional allocation
> > makes this bit strange API-wise. Or alternatively, give
> > hint_allocate() a better name.
>
> How about hint_allocate_conditional() ?
hint_get() sounds better to
On 8/31/05, Machida, Hiroyuki <[EMAIL PROTECTED]> wrote:
> How about this ?
>
> if (!MSDOS_I(dir)->scan_hints) {
> hints = kcalllo();
>
> down
> if (MSDOS_I(dir)->scan_hints) {
> up
>
On 8/31/05, Pekka Enberg <[EMAIL PROTECTED]> wrote:
> After finally understanding what you're doing, how about:
>
> static inline int hint_allocate(struct inode *dir)
> {
> loff_t *hints;
> int err = 0;
>
> if (!MSDOS_I(dir)->scan_hint
On 9/1/05, David Teigland <[EMAIL PROTECTED]> wrote:
> - Adapt the vfs so gfs (and other cfs's) don't need to walk vma lists.
> [cf. ops_file.c:walk_vm(), gfs works fine as is, but some don't like it.]
It works fine only if you don't care about playing well with other
clustered filesystems.
-by: Pekka Enberg <[EMAIL PROTECTED]>
---
dir.c | 239 +++---
1 file changed, 113 insertions(+), 126 deletions(-)
Index: 2.6/fs/fat/dir.c
===
--- 2.6.orig/fs/fat/dir.c
+
On 9/4/05, Paul Misner <[EMAIL PROTECTED]> wrote:
> No one is asking you to 'care' about our problems running a notebook with a
> closed source driver under ndiswrapper.
Yes you are. You're asking for 4KSTACKS config option to maintained
and it is not something you get for free. Besides, if it
On 9/5/05, Willy Tarreau <[EMAIL PROTECTED]> wrote:
> Except that someone has to maintain the patch, because with the speed the
> kernel is changing, a patch against 2.6.14 will not work on 2.6.15.
Indeed. It has to be maintained in tree as well and I don't see any
justification for making
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote:
> > +void gfs2_glock_hold(struct gfs2_glock *gl)
> > +{
> > + glock_hold(gl);
> > +}
> >
> > eh why?
On 9/5/05, David Teigland <[EMAIL PROTECTED]> wrote:
> You removed the comment stating exactly why, see below. If that's not
On 9/5/05, Howard Chu <[EMAIL PROTECTED]> wrote:
> So, any guesses why with otherwise identical config options, a kernel
> with SMP enabled doesn't boot up with all of the device nodes that it
> should? (Both drives are on the same controller. I haven't checked to
> see if any other device files
On 9/6/05, Richard Purdie <[EMAIL PROTECTED]> wrote:
> +/*
> + * Corgi/Spitz Touchscreen to LCD interface
> + */
> +unsigned long inline corgi_get_hsync_len(void)
> +{
> + if (machine_is_corgi() || machine_is_shepherd() ||
> machine_is_husky()) {
> +#ifdef CONFIG_PXA_SHARP_C7xx
> +
HARP_Cxx00
> > + return pxafb_get_hsync_time(_device.dev);
> > +#endif
> > + }
> > + return 0;
> > +}
On 9/6/05, Pekka Enberg <[EMAIL PROTECTED]> wrote:
> Please consider making two version of corgi_get_hsync_len() instead
> for both config op
On 9/5/05, OGAWA Hirofumi <[EMAIL PROTECTED]> wrote:
> But sorry, I have no time for reviewing all of patch now. I'll send it
> to Andrew after review.
Ok. Please do the appropriate renaming also. Thanks.
Pekka
-
To unsubscribe from this list: send the line
On 9/7/05, Miloslav Trmac <[EMAIL PROTECTED]> wrote:
> +static int __init map_bios(void)
> +{
> + static const unsigned char __initdata signature[]
> + = { 0x42, 0x21, 0x55, 0x30 };
> +
> + void __iomem *base;
> + size_t offset;
> + uint32_t entry_point;
> +
> +
On 12/31/06, Mitchell Blank Jr <[EMAIL PROTECTED]> wrote:
Looking at aligned_kmalloc() it seems to be pretty badly broken -- its fallback
if it gets a non-aligned buffer is to just try a larger size which doesn't
necessarily fix the problem. It looks like explicitly aligning the buffer
is a
Hi Hugh,
[Sorry, no access to kernel tree right now, so can't send a patch.]
On 1/4/07, Hugh Dickins <[EMAIL PROTECTED]> wrote:
@@ -3310,7 +3310,7 @@ retry:
*/
goto retry;
} else {
-
to you and Christoph to fight over later!
Fair enough :-)
Acked-by: Pekka Enberg <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.ht
On 1/4/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
Seems to work nicely on my 2node cell blade.
Thanks for testing. Unfortunately as the other Christoph pointed out,
my patch reintroduces a bug that was fixed a while ago. kmalloc_node
should not be using mempolicies...
-
To unsubscribe
On 1/5/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
in this case, as mr. beer suggests, you should also check if this
represents a kmalloc->kzalloc cleanup (there's lots of those), and
also see if you can replace one of these:
sizeof(struct blah)
with one of these:
sizeof(*blahptr)
On 1/7/07, Sebastian Kärgel <[EMAIL PROTECTED]> wrote:
BUG: unable to handle kernel paging request at virtual address 1b1ca570
printing eip:
c014c3b1
*pde =
Oops: [#1]
Modules linked in:
CPU:0
EIP:0060:[]Not tainted VLI
EFLAGS: 00010807 (2.6.19.1 #1)
EIP is at
On Thu, 4 Jan 2007, Robert Hancock wrote:
> > Saw this oops on 2.6.20-rc3-git4 when attempting to suspend. This only
> > happened in 1 of 3 attempts.
On Friday, 5 January 2007 20:15, Christoph Lameter wrote:
> See the fix that I posted yesterday to linux-mm. Its now in Andrew's tree.
On
On 1/8/07, Hua Zhong <[EMAIL PROTECTED]> wrote:
> And as I explained, it can result in longer code too. So, why
> keep this value around. Why not re-initialize it to NULL.
Because initialization increases code size.
And it also effectively blocks the slab debugging code from doing its
job
Hi Amit,
On 1/8/07, Amit Choudhary <[EMAIL PROTECTED]> wrote:
Man, doesn't make sense to me.
Well, man, double-free is a programming error and papering over it
with NULL initializations bloats the kernel and makes the code
confusing.
Clear enough for you?
-
To unsubscribe from this list:
On 1/8/07, Amit Choudhary <[EMAIL PROTECTED]> wrote:
It is a programming error because the underlying code cannot handle it.
Yes. Do you also grasp the fact that there is no way for the allocator
to handle it either? So, double-free, from allocator standpoint can
_never_ be no-op.
What you're
On 1/9/07, Christoph Lameter <[EMAIL PROTECTED]> wrote:
I am loosing track of these. What is the difference to earlier versions?
It is just a rediff on top of Linus' tree as Hugh's fix already went in.
Pekka
-
To unsubscribe from this list: send the line
On 1/10/07, Serge E. Hallyn <[EMAIL PROTECTED]> wrote:
But since it looks like you just munmap the region now, shouldn't a
subsequent munmap by the app just return -EINVAL? that seems appropriate
to me.
Applications don't know about revoke and neither should they.
Therefore close(2) and
Hi Joe,
On 1/12/07, joe jin <[EMAIL PROTECTED]> wrote:
@@ -788,7 +786,7 @@ static int rlb_initialize(struct bonding
spin_lock_init(&(bond_info->rx_hashtbl_lock));
- new_hashtbl = kmalloc(size, GFP_KERNEL);
+ new_hashtbl = kzalloc(size, GFP_KERNEL);
if
On 1/11/07, Serge E. Hallyn <[EMAIL PROTECTED]> wrote:
Right, but is returning -EINVAL to userspace on munmap a problem?
Yes, because an application has no way of reusing the revoked mapping
range. The current patch should get this right, though.
On 1/11/07, Serge E. Hallyn <[EMAIL
Hi Andrew,
On 1/9/07, Pekka J Enberg <[EMAIL PROTECTED]> wrote:
From: Pekka Enberg <[EMAIL PROTECTED]>
The current implementation of cache_grow() has to either (1) use pre-allocated
memory for the slab or (2) allocate the memory itself which makes the error
paths messy. Move _
On 1/10/07, Serge E. Hallyn <[EMAIL PROTECTED]> wrote:
Now, what slim needs isn't "revoke all files for this inode",
but "revoke this task's write access to this fd". So two functions
which could be useful are
int fd_revoke_write(struct task_struct *tsk, int fd)
int
Check return value for copy_to_user() and copy_from_user().
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
cifssmb.c | 37 ++---
file.c|6 +-
2 files changed, 27 insertions(+), 16 deletions(-)
Index: linux/fs/cifs/cif
This patch removes commented out code.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
asn1.c| 122 --
cifsencrypt.c |5 --
cifsfs.c | 25 ---
cifssmb.c | 48 +-
con
Remove spurious void pointer casts.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
cifsfs.c|9 -
dir.c |6 ++
file.c | 32 +---
misc.c | 17 -
readdir.c |6 +++---
transport.c |5 ++
Convert #defines to proper enums and remove duplicate symbols.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
asn1.c| 72 +++--
cifspdu.h | 798 --
2 files changed, 464 insertions(+), 406 deletions(-)
Index: 2.6/f
This patch converts cifs code to use msleep() and ssleep() instead of
schedule_timeout().
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
cifsfs.c |9 -
connect.c | 25 +
2 files changed, 13 insertions(+), 21 deletions(-)
Index: 2.6/fs/cifs/ci
This patch converts deep if statement nesting to use gotos in few places.
Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]>
---
cifsfs.c | 51 +++
connect.c | 44
2 files changed, 51 inse
On Thu, 20 Jan 2005 01:23:48 -0500, Karim Yaghmour <[EMAIL PROTECTED]> wrote:
> +config RELAYFS_FS
> + tristate "Relayfs file system support"
> + ---help---
> + Relayfs is a high-speed data relay filesystem designed to provide
> + an efficient mechanism for tools and facilities
On 12/8/06, Ulrich Windl <[EMAIL PROTECTED]> wrote:
my apologies for disobeying all the rules for submitting patches, but I'll
suggest
a performance optimization for strstrip() in lib/string.c:
Makes sense. Please submit a patch.
-
To unsubscribe from this list: send the line "unsubscribe
On 12/9/06, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
perhaps i'm just being clueless about the authorship protocol here,
but i'm a bit hacked off by noticing that at least one submitted patch
of mine was apparently re-submitted (albeit slightly modified) a few
days later by another poster
On 12/9/06, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
@@ -705,7 +705,7 @@ static int uss720_probe(struct usb_inter
/*
* Allocate parport interface
*/
- if (!(priv = kcalloc(sizeof(struct parport_uss720_private), 1,
GFP_KERNEL))) {
+ if (!(priv =
On 12/9/06, Pekka Enberg <[EMAIL PROTECTED]> wrote:
You really ought to send these cleanups to [EMAIL PROTECTED] with LKML
cc'd to get them merged.
...or even better, the relevant maintainer.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the b
Hi Christoph,
On 12/8/06, Christoph Lameter <[EMAIL PROTECTED]> wrote:
+#defineSLAB_POISON 0x0800UL/* DEBUG: Poison
objects */
+#defineSLAB_HWCACHE_ALIGN 0x2000UL/* Align objs on cache
lines */
+#define SLAB_CACHE_DMA 0x4000UL/*
On 12/9/06, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
argh, in that i've already mentioned that, following the guidelines in
"SubmittingPatches", i prefer that each of my patches have one logical
purpose. once the order of the kcalloc() args is corrected, that
would be followed by a single
901 - 1000 of 1778 matches
Mail list logo
