[PATCH v2 1/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi read requests

The dcs/generic dsi read feature is not yet implemented so it is important to warn the host_transfer() caller in case of read operation requests. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu

[PATCH v2 0/2] drm/bridge/synopsys: dsi: Add fix & warning in dsi_host_transfer()

Add a fix & a warning in the dsi_host_transfer(). Version 2: - Simplify the 2 patches following comments from Brian Norris. - Swap the 2 patches as the return value is only on tx and in case of rx requests the warning is there. Version 1: - Initial commit Philippe Cornu (2): drm/br

[PATCH v2 0/2] drm/bridge/synopsys: dsi: Add fix & warning in dsi_host_transfer()

Add a fix & a warning in the dsi_host_transfer(). Version 2: - Simplify the 2 patches following comments from Brian Norris. - Swap the 2 patches as the return value is only on tx and in case of rx requests the warning is there. Version 1: - Initial commit Philippe Cornu (2): drm/br

Re: [PATCH v1 1/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value

Hi Brian, And many thanks for your review. On 01/23/2018 10:38 PM, Brian Norris wrote: > Hi Philippe, > > On Tue, Jan 23, 2018 at 6:26 AM, Philippe Cornu <philippe.co...@st.com> wrote: >> The dw_mipi_dsi_host_transfer() must return the number of >> bytes transmitted/

Re: [PATCH v1 1/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value

Hi Brian, And many thanks for your review. On 01/23/2018 10:38 PM, Brian Norris wrote: > Hi Philippe, > > On Tue, Jan 23, 2018 at 6:26 AM, Philippe Cornu wrote: >> The dw_mipi_dsi_host_transfer() must return the number of >> bytes transmitted/received on success instead of

Re: [PATCH v1 2/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi read operations

maybe the read feature), sorry to have not wait a single day more. > On Tue, Jan 23, 2018 at 6:26 AM, Philippe Cornu <philippe.co...@st.com> wrote: >> The DCS/GENERIC DSI read feature is not yet implemented so it >> is important to warn the host_transfer() caller i

Re: [PATCH v1 2/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi read operations

maybe the read feature), sorry to have not wait a single day more. > On Tue, Jan 23, 2018 at 6:26 AM, Philippe Cornu wrote: >> The DCS/GENERIC DSI read feature is not yet implemented so it >> is important to warn the host_transfer() caller in case of >> read operation req

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

Hi Brian, On 01/23/2018 10:15 PM, Brian Norris wrote: > Hi Philippe, > > On Thu, Jan 18, 2018 at 11:40:48AM +, Philippe CORNU wrote: >> On 01/11/2018 12:16 PM, Philippe CORNU wrote: >>> To be honest, I do not really like the memcpy here too and I agree with >&g

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

Hi Brian, On 01/23/2018 10:15 PM, Brian Norris wrote: > Hi Philippe, > > On Thu, Jan 18, 2018 at 11:40:48AM +, Philippe CORNU wrote: >> On 01/11/2018 12:16 PM, Philippe CORNU wrote: >>> To be honest, I do not really like the memcpy here too and I agree with >&g

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

: Andrzej Hajda <a.ha...@samsung.com> >> Signed-off-by: Philippe Cornu <philippe.co...@st.com> >> --- >> Changes in v3: Simplify px_clk probing thanks to Andrzej Hajda comments >> >> Changes in v2: Improve px_clk probing in case of ENOENT dt returned value >

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

:06PM +0100, Philippe Cornu wrote: >> The pixel clock is optional. When available, it offers a better >> preciseness for timing computations and allows to reduce the extra dsi >> bandwidth in burst mode (from ~20% to ~10-12%, hw platform dependant). >> >> Reviewed-

[PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

The pixel clock is optional. When available, it offers a better preciseness for timing computations and allows to reduce the extra dsi bandwidth in burst mode (from ~20% to ~10-12%, hw platform dependant). Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Signed-off-by: Philippe Cornu <ph

[PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

The pixel clock is optional. When available, it offers a better preciseness for timing computations and allows to reduce the extra dsi bandwidth in burst mode (from ~20% to ~10-12%, hw platform dependant). Reviewed-by: Andrzej Hajda Signed-off-by: Philippe Cornu --- Changes in v3: Simplify

[PATCH v1 1/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value

The dw_mipi_dsi_host_transfer() must return the number of bytes transmitted/received on success instead of 0. Note: nb_bytes is introduced in this patch as it will be re-used with the future dcs/generic dsi read feature. Signed-off-by: Philippe Cornu <philippe.co...@st.com> --- drivers/g

[PATCH v1 1/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value

The dw_mipi_dsi_host_transfer() must return the number of bytes transmitted/received on success instead of 0. Note: nb_bytes is introduced in this patch as it will be re-used with the future dcs/generic dsi read feature. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi

[PATCH v1 0/2] drm/bridge/synopsys: dsi: Add fix & warning in dsi_host_transfer()

Add a fix & a warning in the dsi_host_transfer(). Philippe Cornu (2): drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value drm/bridge/synopsys: dsi: Add a warning msg on dsi read operations drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 17 +++-- 1 file changed

[PATCH v1 0/2] drm/bridge/synopsys: dsi: Add fix & warning in dsi_host_transfer()

Add a fix & a warning in the dsi_host_transfer(). Philippe Cornu (2): drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value drm/bridge/synopsys: dsi: Add a warning msg on dsi read operations drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 17 +++-- 1 file changed

[PATCH v1 2/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi read operations

The DCS/GENERIC DSI read feature is not yet implemented so it is important to warn the host_transfer() caller in case of read operation requests. Signed-off-by: Philippe Cornu <philippe.co...@st.com> --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 9 - 1 file changed, 8 inse

[PATCH v1 2/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi read operations

The DCS/GENERIC DSI read feature is not yet implemented so it is important to warn the host_transfer() caller in case of read operation requests. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff

Re: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

Hi Laurent, A big *thank* for your review On 01/23/2018 12:30 AM, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Monday, 22 January 2018 12:26:08 EET Philippe Cornu wrote: >> Add SPDX identifiers to the Synopsys DesignWare MIPI DSI >

Re: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

Hi Laurent, A big *thank* for your review On 01/23/2018 12:30 AM, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Monday, 22 January 2018 12:26:08 EET Philippe Cornu wrote: >> Add SPDX identifiers to the Synopsys DesignWare MIPI DSI >

[PATCH] drm/stm: dsi: Add 1.31 version support

Add support for the stm dsi phy/wrapper version 1.31. Only lane capabilities need to be modified. Signed-off-by: Philippe Cornu <philippe.co...@st.com> --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 39 +++ 1 file changed, 30 insertions(+), 9 deletions(-) diff

[PATCH] drm/stm: dsi: Add 1.31 version support

Add support for the stm dsi phy/wrapper version 1.31. Only lane capabilities need to be modified. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 39 +++ 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/stm

[PATCH] dt-bindings: display: stm32: add pixel clock mandatory property

Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Signed-off-by: Philippe Cornu <philippe.co...@st.com> --- Please apply "dt-bindings: display: stm32: correct clock-names in dsi panel example" b

[PATCH] dt-bindings: display: stm32: add pixel clock mandatory property

Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Signed-off-by: Philippe Cornu --- Please apply "dt-bindings: display: stm32: correct clock-names in dsi panel example" before this patch. Changes in

[PATCH] dt-bindings: display: stm32: correct clock-names in dsi panel example

In the dsi panel example, clock names in the "clock-names" field have been swapped: * "pclk" (peripheral clock) is < 1 CLK_F469_DSI> on stm32f4 * "ref" (dsi phy pll ref clock) is <_hse> on stm32f4 Signed-off-by: Philippe Cornu <philippe.co...@st.com>

[PATCH] dt-bindings: display: stm32: correct clock-names in dsi panel example

In the dsi panel example, clock names in the "clock-names" field have been swapped: * "pclk" (peripheral clock) is < 1 CLK_F469_DSI> on stm32f4 * "ref" (dsi phy pll ref clock) is <_hse> on stm32f4 Signed-off-by: Philippe Cornu --- Documentation/devicet

[PATCH] drm/bridge/synopsys: dsi: Add 1.31 version support

From: Philippe CORNU <philippe.co...@st.com> Add support for the Synopsys DesignWare MIPI DSI version 1.31 Two registers need to be updated/added for supporting 1.31: * PHY_TMR_CFG 0x9c (updated) 1.30 [31:24] phy_hs2lp_time [23:16] phy_lp2hs_time [14: 0] max_rd_time 1.31

[PATCH] drm/bridge/synopsys: dsi: Add 1.31 version support

From: Philippe CORNU Add support for the Synopsys DesignWare MIPI DSI version 1.31 Two registers need to be updated/added for supporting 1.31: * PHY_TMR_CFG 0x9c (updated) 1.30 [31:24] phy_hs2lp_time [23:16] phy_lp2hs_time [14: 0] max_rd_time 1.31 [25:16] phy_hs2lp_time

Re: [PATCH] dt-bindings: display: stm32: correct clock-names in dsi panel example

Hi Rob, On 01/22/2018 03:30 PM, Rob Herring wrote: > On Sun, Jan 21, 2018 at 2:58 PM, Philippe Cornu <philippe.co...@st.com> wrote: >> In the dsi panel example, clock names in the "clock-names" >> field have been swapped: >> * "pclk" (peripheral c

Re: [PATCH] dt-bindings: display: stm32: correct clock-names in dsi panel example

Hi Rob, On 01/22/2018 03:30 PM, Rob Herring wrote: > On Sun, Jan 21, 2018 at 2:58 PM, Philippe Cornu wrote: >> In the dsi panel example, clock names in the "clock-names" >> field have been swapped: >> * "pclk" (peripheral clock) is < 1 CLK_F469_DSI&g

[PATCH] drm/stm: drv: Improve data transfers

To optimize data transfers, align pitch on 128 bytes & height on 4 bytes. This optimization is not applicable without MMU. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Vincent Abriou <vincent.abr...@st.com> Signed-off-by: Philippe Cornu <philippe.co...@s

[PATCH] drm/stm: drv: Improve data transfers

To optimize data transfers, align pitch on 128 bytes & height on 4 bytes. This optimization is not applicable without MMU. Signed-off-by: Yannick Fertre Signed-off-by: Vincent Abriou Signed-off-by: Philippe Cornu --- drivers/gpu/drm/stm/drv.c | 21 + 1 file changed

[PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

Add SPDX identifiers to the Synopsys DesignWare MIPI DSI host controller driver. Signed-off-by: Philippe Cornu <philippe.co...@st.com> --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/synop

[PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

Add SPDX identifiers to the Synopsys DesignWare MIPI DSI host controller driver. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu

Re: [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property

Hi Rob, On 01/19/2018 11:43 PM, Rob Herring wrote: > On Fri, Jan 12, 2018 at 04:30:34PM +0100, Philippe Cornu wrote: >> Add the DPI/RGB input pixel clock in mandatory properties >> because it really offers a better preciseness for timing >> computations. >> Note: Fix

Re: [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property

Hi Rob, On 01/19/2018 11:43 PM, Rob Herring wrote: > On Fri, Jan 12, 2018 at 04:30:34PM +0100, Philippe Cornu wrote: >> Add the DPI/RGB input pixel clock in mandatory properties >> because it really offers a better preciseness for timing >> computations. >> Note: Fix

[PATCH] dt-bindings: display: stm32: add pixel clock mandatory property

Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Signed-off-by: Philippe Cornu <philippe.co...@st.com> --- Please apply "dt-bindings: display: stm32: correct clock-names in dsi panel example" b

[PATCH] dt-bindings: display: stm32: add pixel clock mandatory property

Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Signed-off-by: Philippe Cornu --- Please apply "dt-bindings: display: stm32: correct clock-names in dsi panel example" before this patch. Changes in

[PATCH] dt-bindings: display: stm32: correct clock-names in dsi panel example

In the dsi panel example, clock names in the "clock-names" field have been swapped: * "pclk" (peripheral clock) is < 1 CLK_F469_DSI> on stm32f4 * "ref" (dsi phy pll ref clock) is <_hse> on stm32f4 Signed-off-by: Philippe Cornu <philippe.co...@st.com>

[PATCH] dt-bindings: display: stm32: correct clock-names in dsi panel example

In the dsi panel example, clock names in the "clock-names" field have been swapped: * "pclk" (peripheral clock) is < 1 CLK_F469_DSI> on stm32f4 * "ref" (dsi phy pll ref clock) is <_hse> on stm32f4 Signed-off-by: Philippe Cornu --- Documentation/devicet

[PATCH] drm/panel: otm8009a: Adopt SPDX identifiers

Add SPDX identifiers to OriseTech OTM8009a panel driver. Signed-off-by: Philippe Cornu <philippe.co...@st.com> --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/d

[PATCH] drm/panel: otm8009a: Adopt SPDX identifiers

Add SPDX identifiers to OriseTech OTM8009a panel driver. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel

Re: [PATCH 1/2] clk: stm32: END_PRIMARY_CLK should be declare after CLK_SYSCLK

Hi Gabriel, Tested successfully on f469 disco board. Tested-by: Philippe Cornu <philippe.co...@st.com> Many thanks, Philippe :-) On 01/18/2018 03:49 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez <gabriel.fernan...@st.com> > > Update of END_PRIMARY_CLK

Re: [PATCH 2/2] clk: stm32: Add DSI clock for STM32F469 Board

Hi Gabriel, Tested successfully on f469 disco board. Tested-by: Philippe Cornu <philippe.co...@st.com> Many thanks, Philippe :-) On 01/18/2018 03:49 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez <gabriel.fernan...@st.com> > > This patch adds DSI cloc

Re: [PATCH 1/2] clk: stm32: END_PRIMARY_CLK should be declare after CLK_SYSCLK

Hi Gabriel, Tested successfully on f469 disco board. Tested-by: Philippe Cornu Many thanks, Philippe :-) On 01/18/2018 03:49 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > Update of END_PRIMARY_CLK was missed, it should be after CLK_SYSCLK > hsi and sysclk are

Re: [PATCH 2/2] clk: stm32: Add DSI clock for STM32F469 Board

Hi Gabriel, Tested successfully on f469 disco board. Tested-by: Philippe Cornu Many thanks, Philippe :-) On 01/18/2018 03:49 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch adds DSI clock for STM32F469 board > > Signed-off-by: Ga

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

Hi Brian, On 01/15/2018 06:11 PM, Andrzej Hajda wrote: > On 15.01.2018 15:40, Philippe CORNU wrote: >> Hi Andrzej, >> >> On 01/15/2018 02:52 PM, Andrzej Hajda wrote: >>> On 12.01.2018 17:25, Philippe Cornu wrote: >>>> The pixel clock is op

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

Hi Brian, On 01/15/2018 06:11 PM, Andrzej Hajda wrote: > On 15.01.2018 15:40, Philippe CORNU wrote: >> Hi Andrzej, >> >> On 01/15/2018 02:52 PM, Andrzej Hajda wrote: >>> On 12.01.2018 17:25, Philippe Cornu wrote: >>>> The pixel clock is op

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

Hi Brian, On 01/11/2018 12:16 PM, Philippe CORNU wrote: > Hi Brian, > > On 01/09/2018 07:55 PM, Brian Norris wrote: >> Hi Philippe, >> >> On Tue, Jan 09, 2018 at 10:48:43AM +, Philippe CORNU wrote: >>> Hi Brian, >>> >>> And many

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

Hi Brian, On 01/11/2018 12:16 PM, Philippe CORNU wrote: > Hi Brian, > > On 01/09/2018 07:55 PM, Brian Norris wrote: >> Hi Philippe, >> >> On Tue, Jan 09, 2018 at 10:48:43AM +, Philippe CORNU wrote: >>> Hi Brian, >>> >>> And many

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

Hi Andrzej, On 01/15/2018 02:52 PM, Andrzej Hajda wrote: > On 12.01.2018 17:25, Philippe Cornu wrote: >> The pixel clock is optional. When available, it offers a better >> preciseness for timing computations and allows to reduce the extra dsi >> bandwidth in burst mode (fro

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

Hi Andrzej, On 01/15/2018 02:52 PM, Andrzej Hajda wrote: > On 12.01.2018 17:25, Philippe Cornu wrote: >> The pixel clock is optional. When available, it offers a better >> preciseness for timing computations and allows to reduce the extra dsi >> bandwidth in burst mode (fro

Re: [PATCH] drm/dsi: Fix improper use of mipi_dsi_device_transfer() return value

Hi Andrzej, On 01/15/2018 10:12 AM, Andrzej Hajda wrote: > On 12.01.2018 15:48, Philippe Cornu wrote: >> The function mipi_dsi_device_transfer() returns the number of transmitted >> or received bytes on success or a negative error code on failure. >> >> The functions m

Re: [PATCH] drm/dsi: Fix improper use of mipi_dsi_device_transfer() return value

Hi Andrzej, On 01/15/2018 10:12 AM, Andrzej Hajda wrote: > On 12.01.2018 15:48, Philippe Cornu wrote: >> The function mipi_dsi_device_transfer() returns the number of transmitted >> or received bytes on success or a negative error code on failure. >> >> The functions m

[PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

The pixel clock is optional. When available, it offers a better preciseness for timing computations and allows to reduce the extra dsi bandwidth in burst mode (from ~20% to ~10-12%, hw platform dependent). Signed-off-by: Philippe Cornu <philippe.co...@st.com> --- Changes in v2: Improve

[PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

The pixel clock is optional. When available, it offers a better preciseness for timing computations and allows to reduce the extra dsi bandwidth in burst mode (from ~20% to ~10-12%, hw platform dependent). Signed-off-by: Philippe Cornu --- Changes in v2: Improve px_clk probing in case of ENOENT

[PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property

Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Note: Fix also the DSI panel example where "ref" & "pclk" clocks were swapped. Signed-off-by: Philippe Cornu <philippe.co...@st.com> --

[PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property

Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Note: Fix also the DSI panel example where "ref" & "pclk" clocks were swapped. Signed-off-by: Philippe Cornu --- Changes in v2: put new clo

[PATCH] drm/dsi: Fix improper use of mipi_dsi_device_transfer() return value

alue in case of success: 0 should be returned instead of the number of transmitted bytes. Signed-off-by: Philippe Cornu <philippe.co...@st.com> --- drivers/gpu/drm/drm_mipi_dsi.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drive

[PATCH] drm/dsi: Fix improper use of mipi_dsi_device_transfer() return value

alue in case of success: 0 should be returned instead of the number of transmitted bytes. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/drm_mipi_dsi.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c i

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

s by Nickey Yang, > to make the Rockchip DSI driver wrap this common driver. > > Signed-off-by: Brian Norris <briannor...@chromium.org> > Reviewed-by: Philippe Cornu <philippe.co...@st.com> > Tested-by: Philippe Cornu <philippe.co...@st.com> > --- > v2: >

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

s by Nickey Yang, > to make the Rockchip DSI driver wrap this common driver. > > Signed-off-by: Brian Norris > Reviewed-by: Philippe Cornu > Tested-by: Philippe Cornu > --- > v2: > * remove "dcs" naming, since these commands handle generic DSI too, not

Re: [PATCH] drm/bridge/synopsys: dsi: make dw_mipi_dsi_bridge_mode_set() static

Hi Brian, Reviewed-by: Philippe Cornu <philippe.co...@st.com> Many thanks, Philippe :-) On 01/09/2018 09:33 PM, Brian Norris wrote: > sparse complains: > > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:703:6: warning: symbol > 'dw_mipi_dsi_bridge_mode_set' was not declared. S

Re: [PATCH] drm/bridge/synopsys: dsi: make dw_mipi_dsi_bridge_mode_set() static

Hi Brian, Reviewed-by: Philippe Cornu Many thanks, Philippe :-) On 01/09/2018 09:33 PM, Brian Norris wrote: > sparse complains: > > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:703:6: warning: symbol > 'dw_mipi_dsi_bridge_mode_set' was not declared. Should it be static? >

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

Hi Brian, On 01/09/2018 07:55 PM, Brian Norris wrote: > Hi Philippe, > > On Tue, Jan 09, 2018 at 10:48:43AM +, Philippe CORNU wrote: >> Hi Brian, >> >> And many thanks for implementing these TODOs. > > And thanks for adding them; it gave me a better opti

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

Hi Brian, On 01/09/2018 07:55 PM, Brian Norris wrote: > Hi Philippe, > > On Tue, Jan 09, 2018 at 10:48:43AM +, Philippe CORNU wrote: >> Hi Brian, >> >> And many thanks for implementing these TODOs. > > And thanks for adding them; it gave me a better opti

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

Hi Archit, Andrzej & Laurent, Regarding this patch from Brian, I think it could be nice to merge it (1xAcked-by, 2xReviewed-by). Could you please have a look? Only the small "typo" in the headline needs to be changed. Many thanks, Philippe :-) On 11/28/2017 10:34 AM, Philip

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

Hi Archit, Andrzej & Laurent, Regarding this patch from Brian, I think it could be nice to merge it (1xAcked-by, 2xReviewed-by). Could you please have a look? Only the small "typo" in the headline needs to be changed. Many thanks, Philippe :-) On 11/28/2017 10:34 AM, Philip

Re: [PATCH] drm/stm: ltdc: add clut mode support

Hi all, Do you think the patch is "acceptable" or should I change it somehow? Any opinion is welcomed : ) Many thanks, Philippe :-) On 11/24/2017 02:54 PM, Philippe CORNU wrote: > Hi Peter, > > On 11/13/2017 11:40 AM, Philippe CORNU wrote: >> Hi Peter, >> >>

Re: [PATCH] drm/stm: ltdc: add clut mode support

Hi all, Do you think the patch is "acceptable" or should I change it somehow? Any opinion is welcomed : ) Many thanks, Philippe :-) On 11/24/2017 02:54 PM, Philippe CORNU wrote: > Hi Peter, > > On 11/13/2017 11:40 AM, Philippe CORNU wrote: >> Hi Peter, >> >>

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

eate_packet(, msg); > + if (ret) { > + dev_err(dsi->dev, "failed to create packet: %d\n", ret); > + return ret; > } > > - return ret; > + dw_mipi_message_config(dsi, msg); > + > + return dw_mipi_dsi_dcs_write(dsi, ); > } > > static const struct mipi_dsi_host_ops dw_mipi_dsi_host_ops = { > I performed some tests tracing all DSI_GEN_HDR & DSI_GEN_PLD_DATA reg writes with panel/panel-orisetech-otm8009a.c (using long dcs commands) before and after your patch and this is "100% perfect"! So, apart the un-important "dcs" in dw_mipi_dsi_dcs_write() function name: Reviewed-by: Philippe Cornu <philippe.co...@st.com> Tested-by: Philippe Cornu <philippe.co...@st.com> This clean-up will help a lot to add the dsi read feature in the future. Very good patch Brian and big "thank you" ! Philippe :-)

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

if (ret) { > + dev_err(dsi->dev, "failed to create packet: %d\n", ret); > + return ret; > } > > - return ret; > + dw_mipi_message_config(dsi, msg); > + > + return dw_mipi_dsi_dcs_write(dsi, ); > } > > static const struct mipi_dsi_host_ops dw_mipi_dsi_host_ops = { > I performed some tests tracing all DSI_GEN_HDR & DSI_GEN_PLD_DATA reg writes with panel/panel-orisetech-otm8009a.c (using long dcs commands) before and after your patch and this is "100% perfect"! So, apart the un-important "dcs" in dw_mipi_dsi_dcs_write() function name: Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu This clean-up will help a lot to add the dsi read feature in the future. Very good patch Brian and big "thank you" ! Philippe :-)

Re: [PATCH v7 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Hi Nickey, On 12/12/2017 02:10 AM, Nickey Yang wrote: > From: Brian Norris > > Bridge drivers/helpers shouldn't be clobbering the drvdata, since a > parent driver might need to own this. Instead, let's return our > 'dw_mipi_dsi' object and have callers pass that back

Re: [PATCH v7 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Hi Nickey, On 12/12/2017 02:10 AM, Nickey Yang wrote: > From: Brian Norris > > Bridge drivers/helpers shouldn't be clobbering the drvdata, since a > parent driver might need to own this. Instead, let's return our > 'dw_mipi_dsi' object and have callers pass that back to us for removal. > >

Re: [PATCH v6 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Hi Brian, On 12/06/2017 10:52 PM, Brian Norris wrote: > Hi Nickey, others, > > I just want to highlight a thing or two here. Otherwise, my > 'Reviewed-by' still basically stands (FWIW). > > On Wed, Dec 06, 2017 at 05:08:21PM +0800, Nickey Yang wrote: >> Add the ROCKCHIP DSI controller driver

Re: [PATCH v6 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Hi Brian, On 12/06/2017 10:52 PM, Brian Norris wrote: > Hi Nickey, others, > > I just want to highlight a thing or two here. Otherwise, my > 'Reviewed-by' still basically stands (FWIW). > > On Wed, Dec 06, 2017 at 05:08:21PM +0800, Nickey Yang wrote: >> Add the ROCKCHIP DSI controller driver

Re: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Hi Nickey, platform_set_drvdata() is still missing in your version. Thanks, Philippe :-) On 12/06/2017 10:39 PM, Brian Norris wrote: > On Wed, Dec 06, 2017 at 05:08:19PM +0800, Nickey Yang wrote: >> From: Brian Norris >> >> Bridge drivers/helpers shouldn't be

Re: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Hi Nickey, platform_set_drvdata() is still missing in your version. Thanks, Philippe :-) On 12/06/2017 10:39 PM, Brian Norris wrote: > On Wed, Dec 06, 2017 at 05:08:19PM +0800, Nickey Yang wrote: >> From: Brian Norris >> >> Bridge drivers/helpers shouldn't be clobbering the drvdata, since a >>

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Hi Nickey, On 12/01/2017 10:11 AM, Nickey Yang wrote: > Hi Philippe, > > > On 2017年12月01日 16:32, Philippe CORNU wrote: >> Dear Nickey, >> >> Many thanks for your patch. >> >> I am sorry to say that but you can not add my "Acked-by"

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Hi Nickey, On 12/01/2017 10:11 AM, Nickey Yang wrote: > Hi Philippe, > > > On 2017年12月01日 16:32, Philippe CORNU wrote: >> Dear Nickey, >> >> Many thanks for your patch. >> >> I am sorry to say that but you can not add my "Acked-by"

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

for removal. > > Signed-off-by: Brian Norris <briannor...@chromium.org> > Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> > Reviewed-by: Matthias Kaehlcke <m...@chromium.org> > Reviewed-by: Archit Taneja <arch...@codeaurora.org> > Acked-by: Philippe Cor

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Brian Norris > Signed-off-by: Nickey Yang > Reviewed-by: Matthias Kaehlcke > Reviewed-by: Archit Taneja > Acked-by: Philippe Cornu > Link:https://patchwork.kernel.org/patch/10078493/ > > --- > Changes in v4: > - Add From tag,update subject line > - keep

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

s cleanup. (please update the headline with "synopsys") Successfully tested on stm. Acked-by: Philippe Cornu <philippe.co...@st.com> Many thanks, Philippe :-) > > Signed-off-by: Brian Norris <briannor...@chromium.org> > --- > drivers

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

s cleanup. (please update the headline with "synopsys") Successfully tested on stm. Acked-by: Philippe Cornu Many thanks, Philippe :-) > > Signed-off-by: Brian Norris > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 36 > ++- >

Re: [PATCH] drm/stm: ltdc: add clut mode support

Hi Peter, On 11/13/2017 11:40 AM, Philippe CORNU wrote: > Hi Peter, > > On 11/12/2017 01:31 PM, Peter Rosin wrote: >> On 2017-11-10 17:12, Philippe CORNU wrote: >>> Hi Peter, >>> >>> On 11/07/2017 05:34 PM, Peter Rosin wrote: >>>> On

Re: [PATCH] drm/stm: ltdc: add clut mode support

Hi Peter, On 11/13/2017 11:40 AM, Philippe CORNU wrote: > Hi Peter, > > On 11/12/2017 01:31 PM, Peter Rosin wrote: >> On 2017-11-10 17:12, Philippe CORNU wrote: >>> Hi Peter, >>> >>> On 11/07/2017 05:34 PM, Peter Rosin wrote: >>>> On

Re: [PATCH] drm/stm: ltdc: add clut mode support

Hi Peter, On 11/12/2017 01:31 PM, Peter Rosin wrote: > On 2017-11-10 17:12, Philippe CORNU wrote: >> Hi Peter, >> >> On 11/07/2017 05:34 PM, Peter Rosin wrote: >>> On 2017-11-07 16:53, Philippe CORNU wrote: >>>> + Peter >>>> >>>>

Re: [PATCH] drm/stm: ltdc: add clut mode support

Hi Peter, On 11/12/2017 01:31 PM, Peter Rosin wrote: > On 2017-11-10 17:12, Philippe CORNU wrote: >> Hi Peter, >> >> On 11/07/2017 05:34 PM, Peter Rosin wrote: >>> On 2017-11-07 16:53, Philippe CORNU wrote: >>>> + Peter >>>> >>>>

Re: [PATCH] drm/stm: ltdc: add clut mode support

Hi Peter, On 11/07/2017 05:34 PM, Peter Rosin wrote: > On 2017-11-07 16:53, Philippe CORNU wrote: >> + Peter >> >> Hi Peter, >> >> CLUT support on STM32 has been removed thanks to your clean up patch > > Support is a bit strong for what I thought w

Re: [PATCH] drm/stm: ltdc: add clut mode support

Hi Peter, On 11/07/2017 05:34 PM, Peter Rosin wrote: > On 2017-11-07 16:53, Philippe CORNU wrote: >> + Peter >> >> Hi Peter, >> >> CLUT support on STM32 has been removed thanks to your clean up patch > > Support is a bit strong for what I thought w

Re: [PATCH] drm/stm: ltdc: add clut mode support

May I ask you please a short review on this patch? Many thanks, Philippe :-) On 10/26/2017 01:17 PM, Philippe Cornu wrote: > Add the 8-bit clut mode support at crtc level. > Useful for low memory footprint user interfaces but also for > 8-bit old games (including color shifting visual

Re: [PATCH] drm/stm: ltdc: add clut mode support

May I ask you please a short review on this patch? Many thanks, Philippe :-) On 10/26/2017 01:17 PM, Philippe Cornu wrote: > Add the 8-bit clut mode support at crtc level. > Useful for low memory footprint user interfaces but also for > 8-bit old games (including color shifting visual

Re: [PATCH] drm/bridge/synopsys: dsi: add optional pixel clock

Hi Philipp, On 10/27/2017 10:06 AM, Philipp Zabel wrote: > Hi Philippe, > > On Thu, 2017-10-26 at 18:09 +0200, Philippe Cornu wrote: >> The pixel clock is optional. When available, it offers a better >> preciseness for timing computations. >> >> Signed-of

Re: [PATCH] drm/bridge/synopsys: dsi: add optional pixel clock

Hi Philipp, On 10/27/2017 10:06 AM, Philipp Zabel wrote: > Hi Philippe, > > On Thu, 2017-10-26 at 18:09 +0200, Philippe Cornu wrote: >> The pixel clock is optional. When available, it offers a better >> preciseness for timing computations. >> >> Signed-off-by: Ph

Re: [PATCH] drm/bridge/synopsys: dsi: add optional pixel clock

Hi Andrzej, On 10/27/2017 08:41 AM, Andrzej Hajda wrote: > On 26.10.2017 18:09, Philippe Cornu wrote: >> The pixel clock is optional. When available, it offers a better >> preciseness for timing computations. >> >> Signed-off-by: Philippe Cornu <philippe.co...@st.co

Re: [PATCH] drm/bridge/synopsys: dsi: add optional pixel clock

Hi Andrzej, On 10/27/2017 08:41 AM, Andrzej Hajda wrote: > On 26.10.2017 18:09, Philippe Cornu wrote: >> The pixel clock is optional. When available, it offers a better >> preciseness for timing computations. >> >> Signed-off-by: Philippe Cornu >> --- >>

Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property

Hi Rob, On 10/27/2017 04:38 PM, Rob Herring wrote: > On Thu, Oct 26, 2017 at 06:12:36PM +0200, Philippe Cornu wrote: >> Add the DPI/RGB input pixel clock in mandatory properties >> because it really offers a better preciseness for timing >> computations. >> Note: Fix

Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property

Hi Rob, On 10/27/2017 04:38 PM, Rob Herring wrote: > On Thu, Oct 26, 2017 at 06:12:36PM +0200, Philippe Cornu wrote: >> Add the DPI/RGB input pixel clock in mandatory properties >> because it really offers a better preciseness for timing >> computations. >> Note: Fix

[PATCH] dt-bindings: display: stm32: add pixel clock mandatory property

Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Note: Fix also the DSI panel example where "ref" & "pclk" clocks were swapped. Signed-off-by: Philippe Cornu <philippe.co...@st.com>

<    1   2   3   4   5   >