[PATCH v5 6/7] ARM: davinci: da850: add GPIO DT node

2013-11-08 Thread Prabhakar Lad
From: KV Sujith Add DT node for Davinci GPIO driver. Signed-off-by: KV Sujith Signed-off-by: Philip Avinash Signed-off-by: Lad, Prabhakar --- arch/arm/boot/dts/da850.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/da850.dtsi

[PATCH v5 3/7] gpio: davinci: use irqdomain

2013-11-08 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch converts the davinci gpio driver to use irqdomain support. Signed-off-by: Lad, Prabhakar --- drivers/gpio/gpio-davinci.c| 74 +++- include/linux/platform_data/gpio-davinci.h |2 +- 2 files changed, 41

[PATCH v5 4/7] gpio: davinci: remove unused variable intc_irq_num

2013-11-08 Thread Prabhakar Lad
From: "Lad, Prabhakar" As the davinci-gpio driver is migrated to use irqdomain there is no need to pass the irq base for the gpio driver. This patch removes this variable from davinci_gpio_platform_data and also the references from the machine file. Signed-off-by: Lad, Prabhakar ---

[PATCH v5 5/7] gpio: davinci: add OF support

2013-11-08 Thread Prabhakar Lad
From: KV Sujith This patch adds OF parser support for davinci gpio driver and also appropriate documentation in gpio-davinci.txt located at Documentation/devicetree/bindings/gpio/. Signed-off-by: KV Sujith Signed-off-by: Philip Avinash [prabhakar.cse...@gmail.com: simplified the OF code,

[PATCH v5 2/7] gpio: davinci: use readl/writel instead of __raw_*

2013-11-08 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch replaces the __raw_readl/writel with readl and writel, Although the code runs on ARMv5 based SOCs, changing this will help copying the code for other uses. Signed-off-by: Lad, Prabhakar --- drivers/gpio/gpio-davinci.c | 36

[PATCH v5 7/7] ARM: davinci: da850 evm: add GPIO pinumux entries DT node

2013-11-08 Thread Prabhakar Lad
From: KV Sujith Add GPIO DT node and pinmux entries for DA850 EVM. GPIO is configurable differently on different boards. So add GPIO pinmuxing in dts file. Signed-off-by: KV Sujith Signed-off-by: Philip Avinash Signed-off-by: Lad, Prabhakar --- arch/arm/boot/dts/da850-evm.dts | 20

[PATCH v5 1/7] gpio: davinci: remove unnecessary printk

2013-11-08 Thread Prabhakar Lad
From: "Lad, Prabhakar" the devm_*() helper prints error messages in case of errors no need to do the same in the driver. Signed-off-by: Lad, Prabhakar --- drivers/gpio/gpio-davinci.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c

[PATCH v5 0/7] gpio: daVinci: cleanup and feature enhancement

2013-11-08 Thread Prabhakar Lad
From: KV Sujith This patch series does the following 1> Ports the driver to use irqdomain. 2> Adds dt binding support for gpio-davinci. 3> Adds DA850 dt support goio. Changes for v5: 1: Fixed review comments pointed by Grygorii. 2: Dropped the fixup patch This patch series is based on

[PATCH v5 0/7] gpio: daVinci: cleanup and feature enhancement

2013-11-08 Thread Prabhakar Lad
From: KV Sujith sujit...@ti.com This patch series does the following 1 Ports the driver to use irqdomain. 2 Adds dt binding support for gpio-davinci. 3 Adds DA850 dt support goio. Changes for v5: 1: Fixed review comments pointed by Grygorii. 2: Dropped the fixup patch This patch series is based

[PATCH v5 1/7] gpio: davinci: remove unnecessary printk

2013-11-08 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com the devm_*() helper prints error messages in case of errors no need to do the same in the driver. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/gpio/gpio-davinci.c |6 ++ 1 file changed, 2 insertions(+), 4

[PATCH v5 4/7] gpio: davinci: remove unused variable intc_irq_num

2013-11-08 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com As the davinci-gpio driver is migrated to use irqdomain there is no need to pass the irq base for the gpio driver. This patch removes this variable from davinci_gpio_platform_data and also the references from the machine file. Signed-off-by: Lad,

[PATCH v5 5/7] gpio: davinci: add OF support

2013-11-08 Thread Prabhakar Lad
From: KV Sujith sujit...@ti.com This patch adds OF parser support for davinci gpio driver and also appropriate documentation in gpio-davinci.txt located at Documentation/devicetree/bindings/gpio/. Signed-off-by: KV Sujith sujit...@ti.com Signed-off-by: Philip Avinash avinashphi...@ti.com

[PATCH v5 2/7] gpio: davinci: use readl/writel instead of __raw_*

2013-11-08 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch replaces the __raw_readl/writel with readl and writel, Although the code runs on ARMv5 based SOCs, changing this will help copying the code for other uses. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com ---

[PATCH v5 3/7] gpio: davinci: use irqdomain

2013-11-08 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch converts the davinci gpio driver to use irqdomain support. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/gpio/gpio-davinci.c| 74 +++-

[PATCH v5 6/7] ARM: davinci: da850: add GPIO DT node

2013-11-08 Thread Prabhakar Lad
From: KV Sujith sujit...@ti.com Add DT node for Davinci GPIO driver. Signed-off-by: KV Sujith sujit...@ti.com Signed-off-by: Philip Avinash avinashphi...@ti.com Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- arch/arm/boot/dts/da850.dtsi | 14 ++ 1 file changed, 14

[PATCH v5 7/7] ARM: davinci: da850 evm: add GPIO pinumux entries DT node

2013-11-08 Thread Prabhakar Lad
From: KV Sujith sujit...@ti.com Add GPIO DT node and pinmux entries for DA850 EVM. GPIO is configurable differently on different boards. So add GPIO pinmuxing in dts file. Signed-off-by: KV Sujith sujit...@ti.com Signed-off-by: Philip Avinash avinashphi...@ti.com Signed-off-by: Lad, Prabhakar

[PATCH 1/2] gpio: davinci: Fix a check for unbanked gpio

2013-11-07 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch fixes a check for offset in gpio_to_irq_unbanked() and also assigns gpio_irq, gpio_unbanked of chips[0] to appropriate values which is used in gpio_to_irq_unbanked() function. Reported-by: Grygorii Strashko Signed-off-by: Lad, Prabhakar ---

[PATCH 2/2] ARM: davinci: Fix number of resources passed to davinci_gpio_register() call

2013-11-07 Thread Prabhakar Lad
From: "Lad, Prabhakar" The davinci_gpio_register() function expects the number of resources as the second parameter, but size of resources was passed to it due to which it was causing unexpected behaviour. This patch fixes the same by passing the ARRAY_SIZE of resources. Reported-by: Grygorii

[PATCH 0/2] DaVinci: GPIO: fixes

2013-11-07 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch series fixes gpio driver regestration and offset check for unbanked gpio. Lad, Prabhakar (2): gpio: davinci: Fix a check for unbanked gpio ARM: davinci: Fix number of resources passed to davinci_gpio_register() call arch/arm/mach-davinci/dm355.c |

Re: [PATCH v2] ths7303: Declare as static a private function

2013-11-07 Thread Prabhakar Lad
rning: no previous prototype for > ‘ths7303_setval’ [-Wmissing-prototypes] >int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode) > ^ > > Signed-off-by: Ricardo Ribalda Delgado > Acked-by: Laurent Pinchart Acked-by: Lad, Prabhakar Regards, --Prabhakar

Re: [PATCH v2] ths7303: Declare as static a private function

2013-11-07 Thread Prabhakar Lad
, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH 0/2] DaVinci: GPIO: fixes

2013-11-07 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch series fixes gpio driver regestration and offset check for unbanked gpio. Lad, Prabhakar (2): gpio: davinci: Fix a check for unbanked gpio ARM: davinci: Fix number of resources passed to davinci_gpio_register() call

[PATCH 2/2] ARM: davinci: Fix number of resources passed to davinci_gpio_register() call

2013-11-07 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com The davinci_gpio_register() function expects the number of resources as the second parameter, but size of resources was passed to it due to which it was causing unexpected behaviour. This patch fixes the same by passing the ARRAY_SIZE of resources.

[PATCH 1/2] gpio: davinci: Fix a check for unbanked gpio

2013-11-07 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch fixes a check for offset in gpio_to_irq_unbanked() and also assigns gpio_irq, gpio_unbanked of chips[0] to appropriate values which is used in gpio_to_irq_unbanked() function. Reported-by: Grygorii Strashko grygorii.stras...@ti.com

Re: [PATCH v4 1/6] gpio: davinci: Fixed a check for unbanked gpio

2013-11-06 Thread Prabhakar Lad
Hi Linus, On Wed, Nov 6, 2013 at 3:26 PM, Linus Walleij wrote: > On Wed, Nov 6, 2013 at 10:33 AM, Prabhakar Lad > wrote: >> On Tue, Nov 5, 2013 at 6:09 PM, Linus Walleij >> wrote: >>> On Sat, Nov 2, 2013 at 4:39 PM, Lad, Prabhakar >>> w

Re: [PATCH v4 4/6] gpio: davinci: add OF support

2013-11-06 Thread Prabhakar Lad
Hi Grygorii, On Tue, Nov 5, 2013 at 10:29 PM, Grygorii Strashko wrote: > On 11/05/2013 10:53 AM, Prabhakar Lad wrote:> Hi Grygorii, > >> >> Thanks for the review. >> >> On Mon, Nov 4, 2013 at 11:58 PM, Grygorii Strashko >> wrote: >>> Hi Prabha

Re: [PATCH v4 1/6] gpio: davinci: Fixed a check for unbanked gpio

2013-11-06 Thread Prabhakar Lad
nction. >> >> Signed-off-by: Lad, Prabhakar > > Is this a regression that should go in right now? > Yes it needs too. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH v4 1/6] gpio: davinci: Fixed a check for unbanked gpio

2013-11-06 Thread Prabhakar Lad
() function. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Is this a regression that should go in right now? Yes it needs too. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v4 4/6] gpio: davinci: add OF support

2013-11-06 Thread Prabhakar Lad
Hi Grygorii, On Tue, Nov 5, 2013 at 10:29 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: On 11/05/2013 10:53 AM, Prabhakar Lad wrote: Hi Grygorii, Thanks for the review. On Mon, Nov 4, 2013 at 11:58 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hi Prabhakar Lad, On 11/02

Re: [PATCH v4 1/6] gpio: davinci: Fixed a check for unbanked gpio

2013-11-06 Thread Prabhakar Lad
Hi Linus, On Wed, Nov 6, 2013 at 3:26 PM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Nov 6, 2013 at 10:33 AM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: On Tue, Nov 5, 2013 at 6:09 PM, Linus Walleij linus.wall...@linaro.org wrote: On Sat, Nov 2, 2013 at 4:39 PM, Lad

Re: [PATCH v4 4/6] gpio: davinci: add OF support

2013-11-05 Thread Prabhakar Lad
Hi Grygorii, Thanks for the review. On Mon, Nov 4, 2013 at 11:58 PM, Grygorii Strashko wrote: > Hi Prabhakar Lad, > > > On 11/02/2013 05:39 PM, Lad, Prabhakar wrote: >> >> From: KV Sujith >> >> This patch adds OF parser support for davinci gpio >>

Re: [PATCH v4 3/6] gpio: davinci: use irqdomain

2013-11-05 Thread Prabhakar Lad
Hi grygorii, Thanks for the review. On Mon, Nov 4, 2013 at 11:57 PM, Grygorii Strashko wrote: > Hi Prabhakar Lad, > > On 11/02/2013 05:39 PM, Lad, Prabhakar wrote: >> From: "Lad, Prabhakar" >> >> This patch converts the davinci gpio driver to use irqdo

Re: [PATCH v4 3/6] gpio: davinci: use irqdomain

2013-11-05 Thread Prabhakar Lad
Hi grygorii, Thanks for the review. On Mon, Nov 4, 2013 at 11:57 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hi Prabhakar Lad, On 11/02/2013 05:39 PM, Lad, Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch converts the davinci gpio driver to use

Re: [PATCH v4 4/6] gpio: davinci: add OF support

2013-11-05 Thread Prabhakar Lad
Hi Grygorii, Thanks for the review. On Mon, Nov 4, 2013 at 11:58 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hi Prabhakar Lad, On 11/02/2013 05:39 PM, Lad, Prabhakar wrote: From: KV Sujith sujit...@ti.com This patch adds OF parser support for davinci gpio driver and also

Re: [PATCH v3 1/3] gpio: davinci: add OF support

2013-11-02 Thread Prabhakar Lad
Hi Grygorii, On Mon, Oct 14, 2013 at 5:55 PM, Grygorii Strashko wrote: > Hi Prabhakar Lad, > > On 10/11/2013 07:18 PM, Prabhakar Lad wrote: >> Hi Linus, >> >> On 10/11/13, Linus Walleij wrote: >>> On Fri, Oct 11, 2013 at 4:59 PM, Prabhakar Lad >>>

Re: [PATCH v3 1/3] gpio: davinci: add OF support

2013-11-02 Thread Prabhakar Lad
Hi Grygorii, On Mon, Oct 14, 2013 at 5:55 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hi Prabhakar Lad, On 10/11/2013 07:18 PM, Prabhakar Lad wrote: Hi Linus, On 10/11/13, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Oct 11, 2013 at 4:59 PM, Prabhakar Lad prabhakar.cse

Re: [PATCH] davinci_emac.c: Fix IFF_ALLMULTI setup

2013-10-21 Thread Prabhakar Lad
> > Tested with kernel 2.6.37. > It would have been better if you would have tested this on the latest kernel. Anyway David has pulled this patch in his tree. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] davinci_emac.c: Fix IFF_ALLMULTI setup

2013-10-21 Thread Prabhakar Lad
2.6.37. It would have been better if you would have tested this on the latest kernel. Anyway David has pulled this patch in his tree. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v3 1/3] gpio: davinci: add OF support

2013-10-11 Thread Prabhakar Lad
Hi Linus, On 10/11/13, Linus Walleij wrote: > On Fri, Oct 11, 2013 at 4:59 PM, Prabhakar Lad > wrote: >> On 10/11/13, Linus Walleij wrote: >>> On Fri, Oct 4, 2013 at 6:03 PM, Prabhakar Lad >>> wrote: > >>>> +- ti,davinci-gpio-irq-base: Base fr

Re: [PATCH v3 1/3] gpio: davinci: add OF support

2013-10-11 Thread Prabhakar Lad
Hi Linus , On 10/11/13, Linus Walleij wrote: > On Fri, Oct 4, 2013 at 6:03 PM, Prabhakar Lad > wrote: > >> This patch adds OF parser support for davinci gpio >> driver and also appropriate documentation in gpio-davinci.txt >> located at Documentation/devicetree/bindi

Re: [PATCH v3 1/3] gpio: davinci: add OF support

2013-10-11 Thread Prabhakar Lad
Hi Linus , On 10/11/13, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Oct 4, 2013 at 6:03 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: This patch adds OF parser support for davinci gpio driver and also appropriate documentation in gpio-davinci.txt located at Documentation

Re: [PATCH v3 1/3] gpio: davinci: add OF support

2013-10-11 Thread Prabhakar Lad
Hi Linus, On 10/11/13, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Oct 11, 2013 at 4:59 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: On 10/11/13, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Oct 4, 2013 at 6:03 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote

[PATCH] v4l: tuner-core: fix typo

2013-10-10 Thread Prabhakar Lad
From: "Lad, Prabhakar" Signed-off-by: Lad, Prabhakar --- drivers/media/v4l2-core/tuner-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c index ddc9379..4b8a9a3 100644 ---

[PATCH] v4l: tuner-core: fix typo

2013-10-10 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/v4l2-core/tuner-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c

Re: [PATCH] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2013-10-07 Thread Prabhakar Lad
On Sun, Oct 6, 2013 at 11:53 AM, Michael Opdenacker wrote: > This patch proposes to remove the use of the IRQF_DISABLED flag > > It's a NOOP since 2.6.35 and it will be removed one day. > > Signed-off-by: Michael Opdenacker Acked-by: Lad, Prabhakar Regrads, --Prabhakar Lad --

Re: [PATCH] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2013-10-07 Thread Prabhakar Lad
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regrads, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH] of/of_reserved_mem.c: fix typo

2013-10-02 Thread Prabhakar Lad
From: "Lad, Prabhakar" Signed-off-by: Lad, Prabhakar --- drivers/of/of_reserved_mem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 0fe40c7..c7a1ea3 100644 --- a/drivers/of/of_reserved_mem.c +++

[PATCH] of/of_reserved_mem.c: fix typo

2013-10-02 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/of/of_reserved_mem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 0fe40c7..c7a1ea3

Re: [PATCH v5] media: st-rc: Add ST remote control driver

2013-09-27 Thread Prabhakar Lad
ruct st_rc_device *rc_dev = dev_get_drvdata(dev); > + > + if (device_may_wakeup(dev)) { > + if (!enable_irq_wake(rc_dev->irq)) > + rc_dev->irq_wake = 1; > + else > + return -EINVAL; > + } else { > +

Re: [PATCH v5] media: st-rc: Add ST remote control driver

2013-09-27 Thread Prabhakar Lad
platforms); +MODULE_AUTHOR(STMicroelectronics (RD) Ltd); +MODULE_LICENSE(GPL); -- Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] davinci: remove deprecated IRQF_DISABLED

2013-09-12 Thread Prabhakar Lad
rabhakar Regrads, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] [media] davinci: remove deprecated IRQF_DISABLED

2013-09-12 Thread Prabhakar Lad
...@free-electrons.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regrads, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-09-04 Thread Prabhakar Lad
Hi Mark, On Mon, Sep 2, 2013 at 9:47 PM, Mark Rutland wrote: > On Wed, Aug 28, 2013 at 03:43:04AM +0100, Prabhakar Lad wrote: >> Hi Mark, >> >> On Tue, Aug 27, 2013 at 8:54 PM, Mark Rutland wrote: >> > [fixing up devicetree list address] >> > >>

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-09-04 Thread Prabhakar Lad
Hi Mark, On Mon, Sep 2, 2013 at 9:47 PM, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Aug 28, 2013 at 03:43:04AM +0100, Prabhakar Lad wrote: Hi Mark, On Tue, Aug 27, 2013 at 8:54 PM, Mark Rutland mark.rutl...@arm.com wrote: [fixing up devicetree list address] Thanks! On Mon, Aug

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-08-27 Thread Prabhakar Lad
Hi Mark, On Tue, Aug 27, 2013 at 8:54 PM, Mark Rutland wrote: > [fixing up devicetree list address] > Thanks! > On Mon, Aug 26, 2013 at 03:41:45AM +0100, Prabhakar Lad wrote: >> Hi Sylwester, >> >> On Fri, Aug 23, 2013 at 11:33 PM, Sylwester Nawrocki >> wrote

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-08-27 Thread Prabhakar Lad
Hi Mark, On Tue, Aug 27, 2013 at 8:54 PM, Mark Rutland mark.rutl...@arm.com wrote: [fixing up devicetree list address] Thanks! On Mon, Aug 26, 2013 at 03:41:45AM +0100, Prabhakar Lad wrote: Hi Sylwester, On Fri, Aug 23, 2013 at 11:33 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-08-25 Thread Prabhakar Lad
ower on/off DAC's 1..6, >> + 0 = OFF and 1 = ON, Default value when this >> + property is not specified is <0 0 0 0 0 0>. > > Name of the property is incorrect here. It has changed to "adi,dac-enable". > OK

Re: [PATCH v3 2/2] media: i2c: adv7343: add OF support

2013-08-25 Thread Prabhakar Lad
+ and 1 = ON, Default value when this property is + not specified is 0 0. Similarly, adi,sd-dac-enable. OK Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 7/8] net: davinci_mdio: remove unnecessary dev_set_drvdata()

2013-08-21 Thread Prabhakar Lad
ar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 7/8] net: davinci_mdio: remove unnecessary dev_set_drvdata()

2013-08-21 Thread Prabhakar Lad
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

2013-08-20 Thread Prabhakar Lad
goto error_ret; > + > + err = of_property_read_u16(node, "ti,vendor", > + _dev->id.vendor); > + if (err < 0) > + goto error_ret; > + > +

Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

2013-08-20 Thread Prabhakar Lad
above properties as per the documentation above are optional, but the code here makes them required property. May be what you can do is if property is not defined make it as zero as per documentation. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH v3 7/7] net: davinci_mdio: use platform_{get,set}_drvdata()

2013-08-16 Thread Prabhakar Lad
en Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 7/7] net: davinci_mdio: use platform_{get,set}_drvdata()

2013-08-16 Thread Prabhakar Lad
Chen libo.c...@huawei.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 5/5] ARM: davinci: da850: add OF_DEV_AUXDATA entry for eth0.

2013-08-15 Thread Prabhakar Lad
250.2", NULL), >> OF_DEV_AUXDATA("ti,davinci_mdio", 0x01e24000, "davinci_mdio.0", >> NULL), >> + OF_DEV_AUXDATA("ti,davinci-dm6467-emac", 0x01e2, >> "davinci_emac.1", >> + NULL), >> + >

Re: [PATCH v4 4/5] ARM: davinci: da850: add DT node for eth0.

2013-08-15 Thread Prabhakar Lad
}; >> + eth0: emac@1e2 { > > >According to the ePAPR spec[1] section 2.2.2, the node should be named > "ethernet". > Thanks for pointing it, I'll fix and repost it. Regards, --Prabhakar Lad > [1] http://www.power.org/resources/downloads/Powe

Re: [PATCH v4 4/5] ARM: davinci: da850: add DT node for eth0.

2013-08-15 Thread Prabhakar Lad
to the ePAPR spec[1] section 2.2.2, the node should be named ethernet. Thanks for pointing it, I'll fix and repost it. Regards, --Prabhakar Lad [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v4 5/5] ARM: davinci: da850: add OF_DEV_AUXDATA entry for eth0.

2013-08-15 Thread Prabhakar Lad
, 0x01e2, davinci_emac.1, + NULL), + Empty line hardly needed here. Ah my bad, will fix and repost. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v5] media: i2c: tvp7002: add OF support

2013-08-12 Thread Prabhakar Lad
uld keep it as is, let me know if you still want me to change. >> + >> +- field-even-active: Active-high Field ID output polarity control of the >> bus. >> + Under normal operation, the field ID output is set to logic 1 for an odd >> field >> + (field 1)

Re: [PATCH v5] media: i2c: tvp7002: add OF support

2013-08-12 Thread Prabhakar Lad
-interfaces.txt? The explanation in video-interfaces.txt is more kind of generic and the explanation here is specific to this device. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2 0/4] GPIO DT support for da850

2013-08-11 Thread Prabhakar Lad
; > This patch series has dependency on [PATCH v2 0/7] Convert GPIO Davinci to > platform driver > > https://lkml.org/lkml/2013/6/14/120 > What is the status of this patch series is any one taking care of it or else I can take care of review comments and repost them. Regards, --Prabhakar

Re: [PATCH v2 0/4] GPIO DT support for da850

2013-08-11 Thread Prabhakar Lad
driver https://lkml.org/lkml/2013/6/14/120 What is the status of this patch series is any one taking care of it or else I can take care of review comments and repost them. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH v3 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-08-08 Thread Prabhakar Lad
On Thu, Aug 8, 2013 at 9:35 PM, Sekhar Nori wrote: > On Thursday 08 August 2013 04:02 PM, Prabhakar Lad wrote: >> Hi Sekhar, >> >> Sorry for the delayed response I was on leave and now back again up >> and running. >> >> On Wed, Jul 31, 2013 at 11:17 AM, Se

Re: [PATCH v3 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-08-08 Thread Prabhakar Lad
Hi Sekhar, Sorry for the delayed response I was on leave and now back again up and running. On Wed, Jul 31, 2013 at 11:17 AM, Sekhar Nori wrote: > On Sunday 23 June 2013 08:30 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch makes a common

Re: [PATCH v3 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-08-08 Thread Prabhakar Lad
Hi Sekhar, Sorry for the delayed response I was on leave and now back again up and running. On Wed, Jul 31, 2013 at 11:17 AM, Sekhar Nori nsek...@ti.com wrote: On Sunday 23 June 2013 08:30 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch makes a common

Re: [PATCH v3 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-08-08 Thread Prabhakar Lad
On Thu, Aug 8, 2013 at 9:35 PM, Sekhar Nori nsek...@ti.com wrote: On Thursday 08 August 2013 04:02 PM, Prabhakar Lad wrote: Hi Sekhar, Sorry for the delayed response I was on leave and now back again up and running. On Wed, Jul 31, 2013 at 11:17 AM, Sekhar Nori nsek...@ti.com wrote

Re: [PATCH RFC FINAL v5] media: OF: add "sync-on-green-active" property

2013-07-26 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Fri, Jul 26, 2013 at 3:27 PM, Hans Verkuil wrote: > Hi Prabhakar, > > On 07/17/2013 05:47 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch adds 'sync-on-green-active' property as part >> of

Re: [PATCH v4] media: i2c: tvp7002: add OF support

2013-07-26 Thread Prabhakar Lad
ive state of Sync-on-green signal property of the >> + endpoint. >> + 0 = Normal Operation (Default) > > I would extend this a little bit: > > 0 = Normal Operation (Active Low, Default) > Ok. >> + 1 = Inverted operation >> + >> +- field-even-active: Acti

Re: [PATCH v4] media: i2c: tvp7002: add OF support

2013-07-26 Thread Prabhakar Lad
field + (field 1)and set to logic 0 for an even field (field 0). Add space before 'and'. Ok will fix it. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH RFC FINAL v5] media: OF: add sync-on-green-active property

2013-07-26 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Fri, Jul 26, 2013 at 3:27 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Prabhakar, On 07/17/2013 05:47 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch adds 'sync-on-green-active' property as part of endpoint property

Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-23 Thread Prabhakar Lad
list. [1] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-23 Thread Prabhakar Lad
Hi Hans, On Sat, Jul 13, 2013 at 2:20 PM, Prabhakar Lad wrote: > From: "Lad, Prabhakar" > > This patch series replaces existing resource handling in the > driver with managed device resource. > > Lad, Prabhakar (5): > media: davinci: vpbe_venc: convert t

Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-23 Thread Prabhakar Lad
Hi Hans, On Sat, Jul 13, 2013 at 2:20 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch series replaces existing resource handling in the driver with managed device resource. Lad, Prabhakar (5): media: davinci: vpbe_venc

Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-23 Thread Prabhakar Lad
] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

2013-07-18 Thread Prabhakar Lad
Hi Joe, On Thu, Jul 18, 2013 at 9:10 PM, Joe Perches wrote: > On Thu, 2013-07-18 at 20:59 +0530, Prabhakar Lad wrote: >> Use the dev_* message logging API instead of raw printk. > [] >> diff --git a/drivers/media/platform/davinci/vpbe.c >> b/drivers/media

[PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

2013-07-18 Thread Prabhakar Lad
From: "Lad, Prabhakar" Use the dev_* message logging API instead of raw printk. Signed-off-by: Lad, Prabhakar --- Posting independent patch of the series, http://www.spinics.net/lists/linux-media/msg65701.html Changes for v2: 1: Fixed logging levels.

[PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

2013-07-18 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com Use the dev_* message logging API instead of raw printk. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- Posting independent patch of the series, http://www.spinics.net/lists/linux-media/msg65701.html Changes for v2: 1: Fixed

Re: [PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

2013-07-18 Thread Prabhakar Lad
Hi Joe, On Thu, Jul 18, 2013 at 9:10 PM, Joe Perches j...@perches.com wrote: On Thu, 2013-07-18 at 20:59 +0530, Prabhakar Lad wrote: Use the dev_* message logging API instead of raw printk. [] diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c

Re: [PATCH v3] media: i2c: tvp7002: add OF support

2013-07-17 Thread Prabhakar Lad
Hi Sylwester, Thanks for the quick review. On Wed, Jul 17, 2013 at 10:09 PM, Sylwester Nawrocki wrote: > On 07/17/2013 06:20 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> add OF support for the tvp7002 driver. >> >> Signed-off-by: La

Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-17 Thread Prabhakar Lad
Hi Laurent, On Wed, Jul 17, 2013 at 5:51 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Saturday 13 July 2013 14:20:26 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch series replaces existing resource handling in the >> driver

Re: [PATCH RFC FINAL v5] media: OF: add "sync-on-green-active" property

2013-07-17 Thread Prabhakar Lad
Hi Sylwester, On Wed, Jul 17, 2013 at 9:50 PM, Sylwester Nawrocki wrote: > On 07/17/2013 05:47 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch adds 'sync-on-green-active' property as part >> of endpoint property. >> >> Si

[PATCH v3] media: i2c: tvp7002: add OF support

2013-07-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" add OF support for the tvp7002 driver. Signed-off-by: Lad, Prabhakar --- This patch depends on https://patchwork.kernel.org/patch/2828800/ Changes for v3: 1: Fixed review comments pointed by Sylwester. .../devicetree/bindings/media/i2c/tvp7002.txt | 43

[PATCH RFC FINAL v5] media: OF: add "sync-on-green-active" property

2013-07-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch adds 'sync-on-green-active' property as part of endpoint property. Signed-off-by: Lad, Prabhakar --- Changes for v5: 1: Changed description for sync-on-green-active property in documentation file as suggested by Sylwester. Changes for v4: 1:

Re: [PATCH RFC v4] media: OF: add "sync-on-green-active" property

2013-07-17 Thread Prabhakar Lad
; + or inverted operation. > > > Would you mind adding this entry after pclk-sample property description ? OK. > And how about describing it a bit more precisely and similarly to > VSYNC/HSYNC, > e.g. > > - sync-on-green-active: active state of Sync-on-green (SoG) signal, > 0

Re: [PATCH RFC v4] media: OF: add sync-on-green-active property

2013-07-17 Thread Prabhakar Lad
? OK. And how about describing it a bit more precisely and similarly to VSYNC/HSYNC, e.g. - sync-on-green-active: active state of Sync-on-green (SoG) signal, 0/1 for LOW/HIGH respectively. OK I'll paste the above one itself :-) -- Regards, Prabhakar Lad -- To unsubscribe from this list

[PATCH RFC FINAL v5] media: OF: add sync-on-green-active property

2013-07-17 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch adds 'sync-on-green-active' property as part of endpoint property. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- Changes for v5: 1: Changed description for sync-on-green-active property in documentation file as

[PATCH v3] media: i2c: tvp7002: add OF support

2013-07-17 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the tvp7002 driver. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- This patch depends on https://patchwork.kernel.org/patch/2828800/ Changes for v3: 1: Fixed review comments pointed by Sylwester.

Re: [PATCH RFC FINAL v5] media: OF: add sync-on-green-active property

2013-07-17 Thread Prabhakar Lad
Hi Sylwester, On Wed, Jul 17, 2013 at 9:50 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 07/17/2013 05:47 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch adds 'sync-on-green-active' property as part of endpoint property. Signed-off-by: Lad

Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-17 Thread Prabhakar Lad
Hi Laurent, On Wed, Jul 17, 2013 at 5:51 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, On Saturday 13 July 2013 14:20:26 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch series replaces existing resource handling in the driver

Re: [PATCH v3] media: i2c: tvp7002: add OF support

2013-07-17 Thread Prabhakar Lad
Hi Sylwester, Thanks for the quick review. On Wed, Jul 17, 2013 at 10:09 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 07/17/2013 06:20 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the tvp7002 driver. Signed-off-by: Lad, Prabhakar

<    1   2   3   4   5   6   7   8   9   10   >