[PATCH 1/2] media: davinci: vpss: enable vpss clocks

2013-03-22 Thread Prabhakar lad
From: Lad, Prabhakar By default the VPSS clocks are only enabled in capture driver for davinci family which creates duplicates. This patch adds support to enable the VPSS clocks in VPSS driver. This avoids duplication of code and also adding clock aliases. This patch cleanups the VPSS clock enabl

[PATCH 2/2] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-03-22 Thread Prabhakar lad
From: Lad, Prabhakar The vpss clocks were enabled by calling a exported function from a driver in a machine code. calling driver code from platform code is incorrect way. This patch fixes this issue and calls the function from driver code itself. Signed-off-by: Lad, Prabhakar --- Note: This p

[PATCH v7 0/2] ARM: davinci: add support for dm365 vpbe display

2013-03-22 Thread Prabhakar lad
From: Lad, Prabhakar This patch series enables VPBE display driver on DM365. This patch is work on on following pull request from Hans http://davinci-linux-open-source.1494791.n2.nabble.com/GIT-PULL-FOR-v3-10-tvp7002-davinci-blackfin-legacy-cleanups-td7582451.html + http://www.mail-archive.com

[PATCH v7 1/2] ARM: davinci: dm365: add support for v4l2 video display

2013-03-22 Thread Prabhakar lad
From: Lad, Prabhakar Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm365. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/board-dm365-evm.c |4 +- arch/arm/mach-davinci/davinci.h |2 +- arch/arm/mach-davinci/dm365.c

[PATCH v7 2/2] ARM: davinci: dm365 EVM: add support for VPBE display

2013-03-22 Thread Prabhakar lad
From: Lad, Prabhakar add support for V4L2 video display to DM365 EVM. Support for SD and ED modes is provided, along with Composite and Component outputs. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/board-dm365-evm.c | 164 ++- 1 files changed, 163 inse

[PATCH v6 0/2] ARM: davinci: dm355: add support for vpbe display

2013-03-22 Thread Prabhakar lad
From: Lad, Prabhakar This patch series enables VPBE display driver on DM355. This patch series is dependent on VPSS clock cleanup patches (http://www.mail-archive.com/davinci-linux-open-source@linux.davincidsp.com/msg25499.html) posted. Chnages for v6: 1: Fixed nits pointed by Sekhar. Changes

[PATCH v6 1/2] ARM: davinci: dm355: add support for v4l2 video display

2013-03-22 Thread Prabhakar lad
From: Lad, Prabhakar Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm355. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/board-dm355-evm.c |4 +- arch/arm/mach-davinci/davinci.h |2 +- arch/arm/mach-davinci/dm355.c

[PATCH v6 2/2] ARM: davinci: dm355 EVM: add support for VPBE display

2013-03-22 Thread Prabhakar lad
From: Lad, Prabhakar add support for V4L2 video display to DM355 EVM. Support for SD modes is provided, along with Composite output Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/board-dm355-evm.c | 69 ++- 1 files changed, 68 insertions(+), 1 deletions(-

Re: [PATCH 1/2] media: davinci: vpss: enable vpss clocks

2013-03-25 Thread Prabhakar Lad
Hi Sekhar, Thanks for the review! On Mon, Mar 25, 2013 at 11:02 AM, Sekhar Nori wrote: > On 3/22/2013 1:23 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> By default the VPSS clocks are only enabled in capture driver >> for davinci family which creates dup

Re: [PATCH 2/2] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-03-25 Thread Prabhakar Lad
Hi Sekhar, On Mon, Mar 25, 2013 at 11:09 AM, Sekhar Nori wrote: > On 3/22/2013 1:23 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> The vpss clocks were enabled by calling a exported function from a driver >> in a machine code. calling driver code from pla

Re: [PATCH v7 1/2] ARM: davinci: dm365: add support for v4l2 video display

2013-03-25 Thread Prabhakar Lad
Hi Sekhar, Thanks for the review! On Mon, Mar 25, 2013 at 11:42 AM, Sekhar Nori wrote: > Prabhakar, > > On 3/22/2013 1:33 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> Create platform devices for various video modules like venc,osd, >> vpbe and v4l2 d

Re: [PATCH 1/2] media: davinci: vpss: enable vpss clocks

2013-03-25 Thread Prabhakar Lad
Sekhar, On Mon, Mar 25, 2013 at 3:54 PM, Sekhar Nori wrote: > On 3/25/2013 3:44 PM, Prabhakar Lad wrote: >> Hi Sekhar, >> >> Thanks for the review! >> >> On Mon, Mar 25, 2013 at 11:02 AM, Sekhar Nori wrote: >>> On 3/22/2013 1:23 PM, Prabhakar lad wrot

Re: [PATCH v7 1/2] ARM: davinci: dm365: add support for v4l2 video display

2013-03-25 Thread Prabhakar Lad
Hi Sekhar, On Mon, Mar 25, 2013 at 3:57 PM, Sekhar Nori wrote: > On 3/25/2013 3:52 PM, Prabhakar Lad wrote: >> Hi Sekhar, >> >> Thanks for the review! >> >> On Mon, Mar 25, 2013 at 11:42 AM, Sekhar Nori wrote: >>> Prabhakar, >>> >>&g

[PATCH] ARM: davinci: use is IS_ENABLED macro

2013-03-25 Thread Prabhakar lad
From: Lad, Prabhakar This patches replaces #if defined() by IS_ENABLED macro, which provides better readability. Signed-off-by: Lad, Prabhakar Cc: Sekhar Nori --- Note: This patch is compile tested only for davinci_all_defconfig and da8xx_omapl_defconfig. arch/arm/mach-davinci/board-

Re: [PATCH] ARM: davinci: use is IS_ENABLED macro

2013-03-26 Thread Prabhakar Lad
Hi Randy, On Mon, Mar 25, 2013 at 7:46 PM, Randy Dunlap wrote: > On 03/25/13 04:21, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> This patches replaces #if defined() by IS_ENABLED macro, which provides >> better readability. >> >> Signed-off

Re: [PATCH v4 4/5] ARM: davinci: da850: add DT node for eth0.

2013-08-15 Thread Prabhakar Lad
}; >> + eth0: emac@1e2 { > > >According to the ePAPR spec[1] section 2.2.2, the node should be named > "ethernet". > Thanks for pointing it, I'll fix and repost it. Regards, --Prabhakar Lad > [1] http://www.power.org/resources/downloads/Po

Re: [PATCH v4 5/5] ARM: davinci: da850: add OF_DEV_AUXDATA entry for eth0.

2013-08-15 Thread Prabhakar Lad
250.2", NULL), >> OF_DEV_AUXDATA("ti,davinci_mdio", 0x01e24000, "davinci_mdio.0", >> NULL), >> + OF_DEV_AUXDATA("ti,davinci-dm6467-emac", 0x01e2, >> "davinci_emac.1", >> + NULL), >> + > >

Re: [PATCH v3 7/7] net: davinci_mdio: use platform_{get,set}_drvdata()

2013-08-16 Thread Prabhakar Lad
o Chen Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH V3 1/2] tps6507x-ts: Add DT support

2013-08-19 Thread Prabhakar Lad
goto error_ret; > + > + err = of_property_read_u16(node, "ti,product", > + &input_dev->id.product); > + if (err < 0) > + goto error_ret; > + > + err = of_property_read_u16(node, "ti,version", > + &input_dev->id.version); > + if (err < 0) > + goto error_ret; All the three above properties as per the documentation above are optional, but the code here makes them required property. May be what you can do is if property is not defined make it as zero as per documentation. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] media: i2c: adv7343: add OF support

2013-07-15 Thread Prabhakar Lad
Hi Sylwester, Thanks for the review. On Mon, Jul 15, 2013 at 2:03 AM, Sylwester Nawrocki wrote: > Hi Prabhakar, > > > On 07/13/2013 01:12 PM, Prabhakar Lad wrote: >> >> From: "Lad, Prabhakar" >> >> add OF support for the adv7343 driver. >>

Re: [PATCH v2 2/2] media: i2c: tvp7002: add OF support

2013-07-15 Thread Prabhakar Lad
-on-green-active' property and parse it in v4l2_of_parse_parallel_bus() and add it as part of flags. and define the following flags in mediabus.h V4L2_MBUS_VIDEO_SOG_ACTIVE_{HIGH,LOW}. Hope you are OK with it. -- Regards, Prabhakar Lad -- To unsubscribe from this list: send the line "

[PATCH RFC v4] media: OF: add "sync-on-green-active" property

2013-07-16 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch adds 'sync-on-green-active' property as part of endpoint property. Signed-off-by: Lad, Prabhakar --- Changes for v4: 1: Fixed review comments pointed by Sylwester. Changes for v3: 1: Fixed review comments pointed by Laurent and Sylwester. RFC v2 h

Re: [PATCH RFC v4] media: OF: add "sync-on-green-active" property

2013-07-17 Thread Prabhakar Lad
t;> + or inverted operation. > > > Would you mind adding this entry after pclk-sample property description ? OK. > And how about describing it a bit more precisely and similarly to > VSYNC/HSYNC, > e.g. > > - sync-on-green-active: active state of Sync-on-green (SoG) signal, >

[PATCH RFC FINAL v5] media: OF: add "sync-on-green-active" property

2013-07-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch adds 'sync-on-green-active' property as part of endpoint property. Signed-off-by: Lad, Prabhakar --- Changes for v5: 1: Changed description for sync-on-green-active property in documentation file as suggested by Sylwester. Changes for v4: 1: Fix

[PATCH v3] media: i2c: tvp7002: add OF support

2013-07-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" add OF support for the tvp7002 driver. Signed-off-by: Lad, Prabhakar --- This patch depends on https://patchwork.kernel.org/patch/2828800/ Changes for v3: 1: Fixed review comments pointed by Sylwester. .../devicetree/bindings/media/i2c/tvp7002.txt | 43

Re: [PATCH RFC FINAL v5] media: OF: add "sync-on-green-active" property

2013-07-17 Thread Prabhakar Lad
Hi Sylwester, On Wed, Jul 17, 2013 at 9:50 PM, Sylwester Nawrocki wrote: > On 07/17/2013 05:47 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch adds 'sync-on-green-active' property as part >> of endpoint property. >> >&

Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-17 Thread Prabhakar Lad
Hi Laurent, On Wed, Jul 17, 2013 at 5:51 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Saturday 13 July 2013 14:20:26 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch series replaces existing resource handling in the >> driver with

Re: [PATCH v3] media: i2c: tvp7002: add OF support

2013-07-17 Thread Prabhakar Lad
Hi Sylwester, Thanks for the quick review. On Wed, Jul 17, 2013 at 10:09 PM, Sylwester Nawrocki wrote: > On 07/17/2013 06:20 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> add OF support for the tvp7002 driver. >> >> Signed-off-by: Lad,

Re: [PATCH 7/8] net: davinci_mdio: remove unnecessary dev_set_drvdata()

2013-08-21 Thread Prabhakar Lad
ar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-08-08 Thread Prabhakar Lad
Hi Sekhar, Sorry for the delayed response I was on leave and now back again up and running. On Wed, Jul 31, 2013 at 11:17 AM, Sekhar Nori wrote: > On Sunday 23 June 2013 08:30 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch makes a common fun

Re: [PATCH v3 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-08-08 Thread Prabhakar Lad
On Thu, Aug 8, 2013 at 9:35 PM, Sekhar Nori wrote: > On Thursday 08 August 2013 04:02 PM, Prabhakar Lad wrote: >> Hi Sekhar, >> >> Sorry for the delayed response I was on leave and now back again up >> and running. >> >> On Wed, Jul 31, 2013 at 11:17 AM, Se

[PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

2013-07-18 Thread Prabhakar Lad
From: "Lad, Prabhakar" Use the dev_* message logging API instead of raw printk. Signed-off-by: Lad, Prabhakar --- Posting independent patch of the series, http://www.spinics.net/lists/linux-media/msg65701.html Changes for v2: 1: Fixed logging levels. drivers/media/platform/davinci/vpbe

Re: [PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

2013-07-18 Thread Prabhakar Lad
Hi Joe, On Thu, Jul 18, 2013 at 9:10 PM, Joe Perches wrote: > On Thu, 2013-07-18 at 20:59 +0530, Prabhakar Lad wrote: >> Use the dev_* message logging API instead of raw printk. > [] >> diff --git a/drivers/media/platform/davinci/vpbe.c >> b/drivers/media

Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-23 Thread Prabhakar Lad
Hi Hans, On Sat, Jul 13, 2013 at 2:20 PM, Prabhakar Lad wrote: > From: "Lad, Prabhakar" > > This patch series replaces existing resource handling in the > driver with managed device resource. > > Lad, Prabhakar (5): > media: davinci: vpbe_venc: convert t

Re: [PATCH 0/5] Davinci VPBE use devres and some cleanup

2013-07-23 Thread Prabhakar Lad
list. [1] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH v4] media: i2c: tvp7002: add OF support

2013-07-26 Thread Prabhakar Lad
ive state of Sync-on-green signal property of the >> + endpoint. >> + 0 = Normal Operation (Default) > > I would extend this a little bit: > > 0 = Normal Operation (Active Low, Default) > Ok. >> + 1 = Inverted operation >> + >> +- field-even-active: Active-

Re: [PATCH RFC FINAL v5] media: OF: add "sync-on-green-active" property

2013-07-26 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Fri, Jul 26, 2013 at 3:27 PM, Hans Verkuil wrote: > Hi Prabhakar, > > On 07/17/2013 05:47 PM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch adds 'sync-on-green-active' property as part &g

Re: [PATCH v2 0/4] GPIO DT support for da850

2013-08-11 Thread Prabhakar Lad
gt; This patch series has dependency on [PATCH v2 0/7] Convert GPIO Davinci to > platform driver > > https://lkml.org/lkml/2013/6/14/120 > What is the status of this patch series is any one taking care of it or else I can take care of review comments and repost them. Regards, --Prabhakar Lad

Re: [PATCH v5] media: i2c: tvp7002: add OF support

2013-08-12 Thread Prabhakar Lad
uld keep it as is, let me know if you still want me to change. >> + >> +- field-even-active: Active-high Field ID output polarity control of the >> bus. >> + Under normal operation, the field ID output is set to logic 1 for an odd >> field >> + (field 1)

Re: [PATCH v2] media: i2c: tvp514x: add OF support

2013-05-14 Thread Prabhakar Lad
end this patch on [1] so that slab.h can also be removed. [1] https://patchwork.kernel.org/patch/2539411/ Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH 5/5] media: i2c: tvp7002: add OF support

2013-05-14 Thread Prabhakar Lad
> +- ti,tvp7002-sog-polarity: Sync on Green output polarity of the endpoint. > > Would it make sense to define field-active and sog-active properties in the > V4L2 bindings instead of having per-chip properties ? > yes you are right these properties need to be in the device node rathe

Re: [PATCH 2/6] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-05-15 Thread Prabhakar Lad
3 pdata as it is no longer exists. > > You should move this before 1/6, otherwise you will break bisection. > OK I'll fix it in next version. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties

2013-05-15 Thread Prabhakar Lad
pointing you to it earlier. > I had looked at it earlier it only means "field signal level during the even field data transmission" it only speaks of even filed. Ideally the field ID output is set to logic 1 for odd field and set to 0 for even field, what I want is to invert the FID

Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties

2013-05-16 Thread Prabhakar Lad
Hi Sylwester, On Thu, May 16, 2013 at 4:13 PM, Sylwester Nawrocki wrote: > Hi, > > > On 05/16/2013 06:53 AM, Prabhakar Lad wrote: >>>> [Snip] >> May be we rename "field-active" to "fid-pol" ? > > > I guess we failed to clearly descr

Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties

2013-05-16 Thread Prabhakar Lad
e V4L2_MBUS_FIELD_EVEN_LOW (1<< 11) >> +#define V4L2_MBUS_FIELD_ACTIVE (1<< 12) >> +#define V4L2_MBUS_SOG (1<< 13) > > > How about V4L2_MBUS_SYNC_ON_GREEN ? > OK makes it more readable. Regards, --Prabhakar

Re: [PATCH 2/6] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-05-16 Thread Prabhakar Lad
Hi Laurent, On Wed, May 15, 2013 at 5:41 PM, Prabhakar Lad wrote: > Hi Laurent, > > Thanks for the review. > > On Wed, May 15, 2013 at 5:35 PM, Laurent Pinchart > wrote: >> Hi Prabhakar, >> >> Thank you for the patch. >> >> On Wednesday 15 May

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Prabhakar Lad
ity = 1; >> + >> + if (flags & V4L2_MBUS_PCLK_SAMPLE_RISING) >> + pdata->clk_polarity = 1; >> + > > As well as here. Maybe a > > done: > of_node_put(endpoint); > return pdata; > > with a goto done in the

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Prabhakar Lad
Hi Laurent, On Thu, May 16, 2013 at 6:20 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Thursday 16 May 2013 18:13:38 Prabhakar Lad wrote: >> On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote: >> > Hi Prabhakar, >> >> [Snip] >> >> &g

Re: [PATCH v8 1/2] ARM: davinci: dm365: add support for v4l2 video display

2013-04-07 Thread Prabhakar Lad
Sekhar, On Thu, Apr 4, 2013 at 3:03 PM, Sekhar Nori wrote: > On 4/2/2013 5:24 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> Create platform devices for various video modules like venc,osd, >> vpbe and v4l2 driver for dm365. >> >> Signed-off-b

[PATCH v9 0/2] ARM: davinci: add support for dm365 vpbe display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar This patch series enables VPBE display driver on DM365. Changes for v9: 1: Removed extra line after break's and defines as pointed by Sekhar. 2: Included Ack's from Sekhar. Changes for v8: 1: Fixed nits pointed by Sekhar. Changes for v7: 1: Fixed nits pointed by Sekhar.

[PATCH v9 1/2] ARM: davinci: dm365: add support for v4l2 video display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm365. Signed-off-by: Lad, Prabhakar Acked-by: Sekhar Nori --- arch/arm/mach-davinci/board-dm365-evm.c |4 +- arch/arm/mach-davinci/davinci.h |7 +- arch/arm/mach-dav

[PATCH v9 2/2] ARM: davinci: dm365 EVM: add support for VPBE display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar add support for V4L2 video display to DM365 EVM. Support for SD and ED modes is provided, along with Composite and Component outputs. Signed-off-by: Lad, Prabhakar Acked-by: Sekhar Nori --- arch/arm/mach-davinci/board-dm365-evm.c | 164 ++- 1

[PATCH v8 0/2] ARM: davinci: dm355: add support for vpbe display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar This patch series enables VPBE display driver on DM355. This patch series is dependent on VPSS clock cleanup patches (http://www.mail-archive.com/davinci-linux-open-source@linux.davincidsp.com/msg25613.html) posted. Changes for v8: 1: Removed extra line after break's and de

[PATCH v8 1/2] ARM: davinci: dm355: add support for v4l2 video display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar Create platform devices for various video modules like venc,osd, vpbe and v4l2 driver for dm355. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/board-dm355-evm.c |4 +- arch/arm/mach-davinci/davinci.h |3 +- arch/arm/mach-davinci/dm355.c

[PATCH v8 2/2] ARM: davinci: dm355 EVM: add support for VPBE display

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar add support for V4L2 video display to DM355 EVM. Support for SD modes is provided, along with Composite output Signed-off-by: Lad, Prabhakar Acked-by: Sekhar Nori --- arch/arm/mach-davinci/board-dm355-evm.c | 69 ++- 1 files changed, 68 inser

Re: [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks

2013-04-08 Thread Prabhakar Lad
Sekhar, On Mon, Apr 8, 2013 at 3:56 PM, Sekhar Nori wrote: > On 4/2/2013 5:14 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> By default the VPSS clocks were enabled in capture driver >> for davinci family which creates duplicates for dm355/dm365/dm644x. &g

[PATCH v3 0/3] davinci: vpss: clock cleanup

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar This patch series cleanup's the VPSS clock enabling. The first patch removes vpss clock enabling from the capture drivers and moves it to the VPSS driver itself. The second patch moves the venc_enable_vpss_clock() to the driver which was being done in platform code. Changes

[PATCH v3 1/3] media: davinci: vpss: enable vpss clocks

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar By default the VPSS clocks were enabled in capture driver for davinci family which creates duplicates for dm355/dm365/dm644x. This patch adds support to enable the VPSS clocks in VPSS driver, which avoids duplication of code and also adding clock aliases. This patch uses PM

[PATCH v3 2/3] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar The vpss clocks were enabled by calling a exported function from a driver in a machine code. calling driver code from platform code is incorrect way. This patch fixes this issue and calls the function from driver code itself. Signed-off-by: Lad, Prabhakar --- drivers/medi

[PATCH v3 3/3] davinic: vpss: trivial cleanup

2013-04-08 Thread Prabhakar lad
From: Lad, Prabhakar this patch removes unnecessary header file inclusions and fixes the typo's. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpss.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/davinci/vpss.c b/d

Re: [PATCH v3 2/3] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-04-09 Thread Prabhakar Lad
On Tue, Apr 9, 2013 at 3:27 PM, Sekhar Nori wrote: > > > On 4/8/2013 5:49 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> The vpss clocks were enabled by calling a exported function from a driver >> in a machine code. calling driver code from platform

Re: [PATCH v9 1/2] ARM: davinci: dm365: add support for v4l2 video display

2013-04-09 Thread Prabhakar Lad
Sekhar, On Tue, Apr 9, 2013 at 5:18 PM, Sekhar Nori wrote: > On 4/8/2013 2:47 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> Create platform devices for various video modules like venc,osd, >> vpbe and v4l2 driver for dm365. >> >> Signed-off-by: L

Re: [BUG] mod/file2alias: build error in devicetable-offsets.c [was: asm/types.h Header file wont get generated while building uImage ?]

2013-04-09 Thread Prabhakar Lad
Hi Andreas On Sun, Mar 31, 2013 at 1:16 AM, Andreas Schwab wrote: > "Jon Medhurst (Tixy)" writes: > >> For builds which succeed I see this order: >> >> WRAParch/arm/include/generated/asm/types.h >> [...] >> GEN include/generated/asm-offsets.h >> >> and for those which fail: >> >>

Re: [PATCH] kbuild: generate generic headers before recursing into scripts

2013-04-09 Thread Prabhakar Lad
d, Prabhakar Regards, --Prabhakar > --- > Prabhakar Lad writes: > >> Whats the status of it ? > > I think it has sufficiently been tested by now. > > Andreas. > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Make

[PATCH] pinctrl: pinctrl-single: add missing double quote

2013-04-09 Thread Prabhakar lad
From: Lad, Prabhakar add a missing double quote for compatible property for pmx_wkup. Signed-off-by: Lad, Prabhakar Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: Tony Lindgren Cc: Linus Walleij Cc: Peter Ujfalusi Cc: devicetree-disc...@lists.ozlabs.org Cc: linux-...@vger.kernel.org

[PATCH v2] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage

2013-05-01 Thread Prabhakar Lad
From: Lad, Prabhakar This patch enables tvp7002 decoder driver for media controller based usage by adding v4l2_subdev_pad_ops operations support for enum_mbus_code, set_pad_format, get_pad_format and media_entity_init() on probe and media_entity_cleanup() on remove. Signed-off-by: Lad, Prabhaka

[PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-01 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the mt9p031 sensor driver. Alongside this patch sorts the header inclusion alphabetically. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus

Re: [PATCH] media: i2c: adv7343: add OF support

2013-05-01 Thread Prabhakar Lad
Hi Sylwester, Thanks for the review. On Mon, Apr 29, 2013 at 10:21 PM, Sylwester Nawrocki wrote: > Hi, > > On 04/26/2013 03:18 PM, Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> add OF support for the adv7343 driver. > >> +++ b/Documentation/devic

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Prabhakar Lad
Hi Sascha, Thanks for the quick review. On Thu, May 2, 2013 at 12:25 PM, Sascha Hauer wrote: > On Thu, May 02, 2013 at 11:52:34AM +0530, Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> add OF support for the mt9p031 sensor driver. >> Alongside this patch

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thu, May 2, 2013 at 4:32 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Thursday 02 May 2013 12:34:25 Prabhakar Lad wrote: >> On Thu, May 2, 2013 at 12:25 PM, Sascha Hauer wrote: >> > On Thu, Ma

Re: [PATCH v2] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage

2013-05-02 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thu, May 2, 2013 at 4:40 PM, Laurent Pinchart wrote: > Ho Prabhakar, > > Thank you for the patch. > > On Thursday 02 May 2013 11:14:42 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> This patch enables tvp7002 de

[PATCH RFC v3] media: i2c: mt9p031: add OF support

2013-05-02 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the mt9p031 sensor driver. Alongside this patch sorts the header inclusion alphabetically. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus

[PATCH v3] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage

2013-05-03 Thread Prabhakar Lad
From: Lad, Prabhakar This patch enables tvp7002 decoder driver for media controller based usage by adding v4l2_subdev_pad_ops operations support for enum_mbus_code, set_pad_format, get_pad_format and media_entity_init() on probe and media_entity_cleanup() on remove. Signed-off-by: Lad, Prabhaka

[PATCH] media: davinci: vpbe: fix layer availability for NV12 format

2013-05-03 Thread Prabhakar Lad
From: Lad, Prabhakar For NV12 format, even if display data is single image, both VIDWIN0 and VIDWIN1 parameters must be used. The start address of Y data plane and C data plane is configured in VIDEOWIN0ADH/L and VIDEOWIN1ADH/L respectively. cuurently only one layer was requested, which is suffic

Re: [PATCH 0/6] Davinci fbdev driver and enable it for DMx platform

2013-05-03 Thread Prabhakar Lad
On Fri, May 3, 2013 at 3:25 PM, Sekhar Nori wrote: > On 4/26/2013 11:16 AM, Prabhakar Lad wrote: >> Hi Laurent, >> >> On Thu, Apr 25, 2013 at 2:32 AM, Laurent Pinchart >> wrote: >>> Hi Prabhakar, >>> >>> Thank you for the patch. >>&

Re: [PATCH, RFC 21/22] davinci: vpfe_capture needs i2c

2013-05-03 Thread Prabhakar Lad
capture.c:1934:11: warning: assignment > makes pointer from integer without a cast [enabled by default] > > Cc: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Mauro Carvalho Chehab > Signed-off-by: Arnd Bergmann Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe fro

[PATCH RESEND] media: davinci: vpbe: fix checkpatch warning for CamelCase

2013-05-03 Thread Prabhakar Lad
From: Lad, Prabhakar This patch fixes checkpatch warning to avoid CamelCase. Signed-off-by: Lad, Prabhakar --- The initial version of this patch was a part of series, which is intended to be dropped so sending this patch individually. drivers/media/platform/davinci/vpbe_display.c |2 +-

Re: [PATCH RFC v3] media: i2c: mt9p031: add OF support

2013-05-06 Thread Prabhakar Lad
Hi Arnd, On Fri, May 3, 2013 at 8:04 PM, Arnd Bergmann wrote: > On Friday 03 May 2013, Prabhakar Lad wrote: >> [snip] >> +} > > Ok, good. > >> @@ -955,7 +998,17 @@ static int mt9p031_probe(struct i2c_client *client, >> mt9p031->pdata = pd

[PATCH v2] media: davinci: vpbe: fix layer availability for NV12 format

2013-05-06 Thread Prabhakar Lad
From: Lad, Prabhakar For NV12 format, even if display data is single image, both VIDWIN0 and VIDWIN1 parameters must be used. The start address of Y data plane and C data plane is configured in VIDEOWIN0ADH/L and VIDEOWIN1ADH/L respectively. cuurently only one layer was requested, which is suffic

Re: [PATCH V2 1/2] tps6507x-ts: Add DT support

2013-05-06 Thread Prabhakar Lad
; + input_dev->id.vendor = val32; > + > + err = of_property_read_u32(node, "ti,product", &val32); > + if (err < 0) > + goto error_ret; > + else > + input_dev->id.product =

[PATCH] of/base: fix typos

2013-05-06 Thread Prabhakar Lad
From: Lad, Prabhakar the function of_property_read_u8/16/32_array() has a parameter out_values, but the description mentioned it as out_value. This patch fixes this typo. Signed-off-by: Lad, Prabhakar --- drivers/of/base.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-)

Re: [PATCH RFC v3] media: i2c: mt9p031: add OF support

2013-05-07 Thread Prabhakar Lad
Hi Arnd, On Mon, May 6, 2013 at 8:29 PM, Prabhakar Lad wrote: > Hi Arnd, > > On Fri, May 3, 2013 at 8:04 PM, Arnd Bergmann wrote: >> On Friday 03 May 2013, Prabhakar Lad wrote: >>> > [snip] >>> +} >> >> Ok, good. >> >>> @@ -955,

Re: [PATCH] [media] davinci: vpfe: fix error return code in vpfe_probe()

2013-05-07 Thread Prabhakar Lad
rabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RFC v3] media: i2c: mt9p031: add OF support

2013-05-07 Thread Prabhakar Lad
HI Laurent, On Wed, May 8, 2013 at 7:31 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Friday 03 May 2013 12:21:59 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> add OF support for the mt9p031 sensor driver. >> Alongsid

Re: [PATCH RFC v3] media: i2c: mt9p031: add OF support

2013-05-07 Thread Prabhakar Lad
Hi Laurent, On Wed, May 8, 2013 at 7:32 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Tuesday 07 May 2013 15:10:36 Prabhakar Lad wrote: >> On Mon, May 6, 2013 at 8:29 PM, Prabhakar Lad wrote: >> > On Fri, May 3, 2013 at 8:04 PM, Arnd Bergmann wrote: >> >&

Re: [PATCH RFC v3] media: i2c: mt9p031: add OF support

2013-05-08 Thread Prabhakar Lad
Hi Laurent, On Wed, May 8, 2013 at 4:07 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Wednesday 08 May 2013 10:19:57 Prabhakar Lad wrote: >> On Wed, May 8, 2013 at 7:32 AM, Laurent Pinchart wrote: >> > On Tuesday 07 May 2013 15:10:36 Prabhakar Lad wrote: >> >

Re: [PATCH] davinci: vpfe: fix error path in probe

2013-05-10 Thread Prabhakar Lad
Hi Hans, On Fri, May 10, 2013 at 4:25 PM, Hans Verkuil wrote: > On Fri May 10 2013 06:48:38 Lad Prabhakar wrote: >> From: Lad, Prabhakar [Snip] >> > > Just FYI: > > After applying this patch I get a compiler warning that the probe_free_lock > label is unused. I've added a patch removing that lab

[PATCH 0/6] Davinci fbdev driver and enable it for DMx platform

2013-04-24 Thread Prabhakar Lad
From: Lad, Prabhakar This patch series adds an fbdev driver for Texas Instruments Davinci SoC.The display subsystem consists of OSD and VENC, with OSD supporting 2 RGb planes and 2 video planes. http://focus.ti.com/general/docs/lit/ getliterature.tsp?literatureNumber=sprue37d&fileType=pdf A goo

[PATCH 1/6] media: davinci: vpbe: fix checkpatch warning for CamelCase

2013-04-24 Thread Prabhakar Lad
From: Lad, Prabhakar This patch fixes checkpatch warning to avoid CamelCase. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpbe_display.c |2 +- drivers/media/platform/davinci/vpbe_osd.c | 24 include/media/davinci/vpbe_osd.h |

[PATCH 2/6] media: davinci: vpbe: enable vpbe for fbdev addition

2013-04-24 Thread Prabhakar Lad
From: Lad, Prabhakar enable the venc, osd and vpbe display driver for addition of fbdev driver. Mainly includes fbdev ops structure inclusion, palette and osd layer related functionality for OSD block. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpbe_display.c |6 + dr

[PATCH 4/6] ARM: davinci: dm355: enable fbdev driver

2013-04-24 Thread Prabhakar Lad
From: Lad, Prabhakar This patch enables fbdev driver by creating fbdev device and register it. Alongside renames 'vpfe_capture_dma_mask' to 'dm355_video_dma_mask' for better clarity since it was reused by capture and diplay aswell. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/dm355.

[PATCH 6/6] ARM: davinci: dm644x: enable fbdev driver

2013-04-24 Thread Prabhakar Lad
From: Lad, Prabhakar This patch enables fbdev driver by creating fbdev device and register it. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/dm644x.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-davi

[PATCH 5/6] ARM: davinci: dm365: enable fbdev driver

2013-04-24 Thread Prabhakar Lad
From: Lad, Prabhakar This patch enables fbdev driver by creating fbdev device and register it. Signed-off-by: Lad, Prabhakar --- arch/arm/mach-davinci/dm365.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinc

Re: [PATCH 0/6] Davinci fbdev driver and enable it for DMx platform

2013-04-25 Thread Prabhakar Lad
Hi Laurent, On Thu, Apr 25, 2013 at 2:32 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Wednesday 24 April 2013 17:30:02 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> This patch series adds an fbdev driver for Texas >&

[PATCH] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage

2013-04-26 Thread Prabhakar Lad
From: Lad, Prabhakar This patch enables tvp7002 decoder driver for media controller based usage by adding v4l2_subdev_pad_ops operations support for enum_mbus_code, set_pad_format, get_pad_format and media_entity_init() on probe and media_entity_cleanup() on remove. The device supports 1 output

[PATCH] media: i2c: tvp514x: add OF support

2013-04-26 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the tvp514x driver. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: devicetree-di

[PATCH] media: i2c: adv7343: add OF support

2013-04-26 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the adv7343 driver. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: devicetree-di

[PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the mt9p031 sensor driver. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: device

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Prabhakar Lad
support does not > necessarily mean you actually boot from devicetree. You must still > handle platform data properly. > OK. which one should be given higher preference client->dev.of_node or the client->dev.platform_data ? >> + struct device_node *np; >> + struct mt9p0

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

2013-04-29 Thread Prabhakar Lad
= "aptina,mt9p031m-sensor", }, > > As you'll need to resubmit anyway, please add a space between '{' and '.' > OK >> + {}, >> +}; >> +MODULE_DEVICE_TABLE(of, mt9p031_of_match); >> + [Snip] >> - struct mt9p031_platform_data *pdata = client->d

<    1   2   3   4   5   6   7   >