Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 9:59 AM, Thomas Graf wrote: > On 03/07/2014 06:28 PM, Pravin Shelar wrote: >> >> Problem is mapping SKBTX_DEV_ZEROCOPY pages to userspace. skb_zerocopy >> is not doing that. >> >> Unless I missing something, Current netlink code can not h

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 4:29 AM, Zoltan Kiss wrote: > On 07/03/14 04:46, Pravin Shelar wrote: >> >> On Thu, Mar 6, 2014 at 9:09 AM, Zoltan Kiss >> wrote: >>> >>> Do you have any feedback on this? I'm also adding KVM list as they might >>> be >&g

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 8:23 AM, Thomas Graf wrote: > On 02/28/2014 08:16 PM, Zoltan Kiss wrote: >> >> The kernel datapath now switched to zerocopy Netlink messages, but that >> also >> means that the pages on frags array are sent straight to userspace. If >> those >> pages came outside the

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 7:58 AM, Thomas Graf wrote: > On 03/07/2014 05:46 AM, Pravin Shelar wrote: >> >> But I found bug in datapath user-space queue code. I am not sure how >> this can work with skb fragments and MMAP-netlink socket. >> Here is what happens, OVS all

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 7:58 AM, Thomas Graf tg...@redhat.com wrote: On 03/07/2014 05:46 AM, Pravin Shelar wrote: But I found bug in datapath user-space queue code. I am not sure how this can work with skb fragments and MMAP-netlink socket. Here is what happens, OVS allocates netlink skb

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 8:23 AM, Thomas Graf tg...@redhat.com wrote: On 02/28/2014 08:16 PM, Zoltan Kiss wrote: The kernel datapath now switched to zerocopy Netlink messages, but that also means that the pages on frags array are sent straight to userspace. If those pages came outside the

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 4:29 AM, Zoltan Kiss zoltan.k...@citrix.com wrote: On 07/03/14 04:46, Pravin Shelar wrote: On Thu, Mar 6, 2014 at 9:09 AM, Zoltan Kiss zoltan.k...@citrix.com wrote: Do you have any feedback on this? I'm also adding KVM list as they might be interested in this. Zoli

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 9:59 AM, Thomas Graf tg...@redhat.com wrote: On 03/07/2014 06:28 PM, Pravin Shelar wrote: Problem is mapping SKBTX_DEV_ZEROCOPY pages to userspace. skb_zerocopy is not doing that. Unless I missing something, Current netlink code can not handle skb-frags with zero copy

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 10:05 AM, Thomas Graf tg...@redhat.com wrote: On 03/07/2014 06:19 PM, Pravin Shelar wrote: On Fri, Mar 7, 2014 at 7:58 AM, Thomas Graf tg...@redhat.com wrote: On 03/07/2014 05:46 AM, Pravin Shelar wrote: But I found bug in datapath user-space queue code. I am

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-06 Thread Pravin Shelar
On Thu, Mar 6, 2014 at 9:09 AM, Zoltan Kiss wrote: > Do you have any feedback on this? I'm also adding KVM list as they might be > interested in this. > > Zoli > > > On 28/02/14 19:16, Zoltan Kiss wrote: >> >> The kernel datapath now switched to zerocopy Netlink messages, but that >> also >>

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-06 Thread Pravin Shelar
On Thu, Mar 6, 2014 at 9:09 AM, Zoltan Kiss zoltan.k...@citrix.com wrote: Do you have any feedback on this? I'm also adding KVM list as they might be interested in this. Zoli On 28/02/14 19:16, Zoltan Kiss wrote: The kernel datapath now switched to zerocopy Netlink messages, but that

Re: [PATCH v2] openvswitch: Disable bottom half when grabbing stats lock in userspace context

2014-02-27 Thread Pravin Shelar
On Thu, Feb 27, 2014 at 2:10 PM, Zoltan Kiss wrote: > The megaflow feature introduced per-CPU stats, and the new code did some > refactoring as well [1]. However the new functions doesn't disable bottom > halves > when locking the stat, and as they can be called from userspace context, they >

Re: [PATCH v2] openvswitch: Disable bottom half when grabbing stats lock in userspace context

2014-02-27 Thread Pravin Shelar
On Thu, Feb 27, 2014 at 2:10 PM, Zoltan Kiss zoltan.k...@citrix.com wrote: The megaflow feature introduced per-CPU stats, and the new code did some refactoring as well [1]. However the new functions doesn't disable bottom halves when locking the stat, and as they can be called from userspace

Re: [ovs-dev] [PATCH net-next] openvswitch: Use ether_addr_copy

2014-02-19 Thread Pravin Shelar
Jesse is on vacation. So I applied it to ovs master. Thanks. On Tue, Feb 18, 2014 at 3:15 PM, David Miller wrote: > From: Joe Perches > Date: Tue, 18 Feb 2014 11:15:45 -0800 > >> It's slightly smaller/faster for some architectures. >> >> Signed-off-by: Joe Perches > > I'll let Jesse take this

Re: [ovs-dev] [PATCH net-next] openvswitch: Use ether_addr_copy

2014-02-19 Thread Pravin Shelar
Jesse is on vacation. So I applied it to ovs master. Thanks. On Tue, Feb 18, 2014 at 3:15 PM, David Miller da...@davemloft.net wrote: From: Joe Perches j...@perches.com Date: Tue, 18 Feb 2014 11:15:45 -0800 It's slightly smaller/faster for some architectures. Signed-off-by: Joe Perches

Re: [Regression][v3.10][v3.11] net: Kill link between CSUM and SG features.

2013-07-16 Thread Pravin Shelar
On Tue, Jul 16, 2013 at 12:53 PM, Joseph Salisbury wrote: > On 07/16/2013 02:29 PM, Pravin Shelar wrote: >> On Tue, Jul 16, 2013 at 11:09 AM, Joseph Salisbury >> wrote: >>> Hi Pravin, >>> >>> A bug was opened against the Ubuntu kernel[0]. After a kern

Re: [Regression][v3.10][v3.11] net: Kill link between CSUM and SG features.

2013-07-16 Thread Pravin Shelar
On Tue, Jul 16, 2013 at 11:09 AM, Joseph Salisbury wrote: > Hi Pravin, > > A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, > it was found that reverting the following commit resolved this bug: > > commit ec5f061564238892005257c83565a0b58ec79295 > Author: Pravin B Shelar >

Re: [Regression][v3.10][v3.11] net: Kill link between CSUM and SG features.

2013-07-16 Thread Pravin Shelar
On Tue, Jul 16, 2013 at 11:09 AM, Joseph Salisbury joseph.salisb...@canonical.com wrote: Hi Pravin, A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: commit ec5f061564238892005257c83565a0b58ec79295

Re: [Regression][v3.10][v3.11] net: Kill link between CSUM and SG features.

2013-07-16 Thread Pravin Shelar
On Tue, Jul 16, 2013 at 12:53 PM, Joseph Salisbury joseph.salisb...@canonical.com wrote: On 07/16/2013 02:29 PM, Pravin Shelar wrote: On Tue, Jul 16, 2013 at 11:09 AM, Joseph Salisbury joseph.salisb...@canonical.com wrote: Hi Pravin, A bug was opened against the Ubuntu kernel[0]. After

Re: Network issue on 3.10 rcs, bisected

2013-05-30 Thread Pravin Shelar
On Thu, May 30, 2013 at 2:14 PM, Joao Correia wrote: > On Thu, May 30, 2013 at 5:48 PM, Pravin Shelar wrote: >> On Wed, May 29, 2013 at 12:53 PM, Joao Correia >> wrote: >>> On Wed, May 29, 2013 at 7:59 PM, Pravin Shelar wrote: >>>> >>>> On Wed, M

Re: Network issue on 3.10 rcs, bisected

2013-05-30 Thread Pravin Shelar
On Wed, May 29, 2013 at 12:53 PM, Joao Correia wrote: > On Wed, May 29, 2013 at 7:59 PM, Pravin Shelar wrote: >> >> On Wed, May 29, 2013 at 4:37 AM, Joao Correia >> wrote: >> > Hello list >> > >> > While trying the rc's for 3.10, i've stumbled up

Re: Network issue on 3.10 rcs, bisected

2013-05-30 Thread Pravin Shelar
On Wed, May 29, 2013 at 12:53 PM, Joao Correia joaomiguelcorr...@gmail.com wrote: On Wed, May 29, 2013 at 7:59 PM, Pravin Shelar pshe...@nicira.com wrote: On Wed, May 29, 2013 at 4:37 AM, Joao Correia joaomiguelcorr...@gmail.com wrote: Hello list While trying the rc's for 3.10, i've

Re: Network issue on 3.10 rcs, bisected

2013-05-30 Thread Pravin Shelar
On Thu, May 30, 2013 at 2:14 PM, Joao Correia joaomiguelcorr...@gmail.com wrote: On Thu, May 30, 2013 at 5:48 PM, Pravin Shelar pshe...@nicira.com wrote: On Wed, May 29, 2013 at 12:53 PM, Joao Correia joaomiguelcorr...@gmail.com wrote: On Wed, May 29, 2013 at 7:59 PM, Pravin Shelar pshe

Re: Network issue on 3.10 rcs, bisected

2013-05-29 Thread Pravin Shelar
On Wed, May 29, 2013 at 4:37 AM, Joao Correia wrote: > Hello list > > While trying the rc's for 3.10, i've stumbled upon a problem where > networking does not work at all. Iptables will show packet counts going up, > but nothing actually reaches the programs. > > I'm running fedora under hyper-v

Re: Network issue on 3.10 rcs, bisected

2013-05-29 Thread Pravin Shelar
On Wed, May 29, 2013 at 4:37 AM, Joao Correia joaomiguelcorr...@gmail.com wrote: Hello list While trying the rc's for 3.10, i've stumbled upon a problem where networking does not work at all. Iptables will show packet counts going up, but nothing actually reaches the programs. I'm running

<    1   2   3