The function pointer 'complete' in 'struct mbo' should use an identifier
for its argument.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.h b/drivers/staging/most/core.h
index
Replace calls to BUG_ON() used to check for NULL pointers with WARN_ONCE()
followed by a return.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most
It isn't necessary for the driver to log out-of-memory errors, so
these have been removed and the functions simply return -ENOMEM.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/most/
It isn't necessary for the driver to log out-of-memory errors, so
these have been removed and the functions simply return -ENOMEM.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging
struct sdu_header isn't actually used anywhere in this driver, so
this change removes it on the assumption it isn't needed for any
API.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/hci_packet.h | 8
1 file changed, 8 deletions(-)
diff --git a/d
struct sdu_header isn't actually used anywhere in this driver, so
this change removes it on the assumption it isn't needed for any
API.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/hci_packet.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/gdm724x
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/s
Since the testing for host endianness and in-driver conversion were
removed in 77e8a50149a2, the gdm_endian struct contains only one member,
and can therefore be simplified to a single u8 variable.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_endian.
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/staging/gdm724x/hci_packet.h
Since the testing for host endianness and in-driver conversion were
removed in 77e8a50149a2, the gdm_endian struct contains only one member,
and can therefore be simplified to a single u8 variable.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_endian.c | 24
Mostly this change just reverses the primary conditional so most of
the code can be pulled back a tab, which fixes some code style
warnings.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 22 +++---
1 file changed, 11 inse
Mostly this change just reverses the primary conditional so most of
the code can be pulled back a tab, which fixes some code style
warnings.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff
Fix lines with a trailing open parenthesis, which is a coding style issue.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 44 +++
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/s
Fix lines with a trailing open parenthesis, which is a coding style issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 44 +++
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b
,
Quytelda Kahja
On Thu, Feb 22, 2018 at 6:02 AM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Wed, Feb 21, 2018 at 05:12:36AM -0800, Quytelda Kahja wrote:
>> Since the testing for host endianness and in-driver conversion were
>> removed in 77e8a50149a2, the gdm_endian str
,
Quytelda Kahja
On Thu, Feb 22, 2018 at 6:02 AM, Greg KH wrote:
> On Wed, Feb 21, 2018 at 05:12:36AM -0800, Quytelda Kahja wrote:
>> Since the testing for host endianness and in-driver conversion were
>> removed in 77e8a50149a2, the gdm_endian struct contains only one member,
>&
Mostly this change just reverses the primary conditional so most of
the code can be pulled back a tab, which fixes some code style
warnings.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 22 +++---
1 file changed, 11 inse
Since the testing for host endianness and in-driver conversion were
removed in 77e8a50149a2, the gdm_endian struct contains only one member,
and can therefore be simplified to a single u8 variable.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_endian.
Mostly this change just reverses the primary conditional so most of
the code can be pulled back a tab, which fixes some code style
warnings.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff
Since the testing for host endianness and in-driver conversion were
removed in 77e8a50149a2, the gdm_endian struct contains only one member,
and can therefore be simplified to a single u8 variable.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_endian.c | 24
That could be the case, though I'm not sure where to find any specs.
Though looking through the history of this driver, it seems that some
of the variable names have been slowly changing from camel case to
snake case.
Thanks,
Quytelda Kahja
On Wed, Feb 21, 2018 at 2:45 AM, Dan Carpenter
That could be the case, though I'm not sure where to find any specs.
Though looking through the history of this driver, it seems that some
of the variable names have been slowly changing from camel case to
snake case.
Thanks,
Quytelda Kahja
On Wed, Feb 21, 2018 at 2:45 AM, Dan Carpenter wrote
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja <quyte...@gmail.com>
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/s
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/staging/gdm724x/hci_packet.h
Fix lines with a trailing open parenthesis, which is a coding style issue.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 44 +++
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/s
Fix lines with a trailing open parenthesis, which is a coding style issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 44 +++
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b
Fix a coding style problem.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
This is the patch without the unnecessary fixes for line length.
drivers/staging/media/bcm2048/radio-bcm2048.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff
Fix a coding style problem.
Signed-off-by: Quytelda Kahja
---
This is the patch without the unnecessary fixes for line length.
drivers/staging/media/bcm2048/radio-bcm2048.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media
Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/
Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index
Convert the unsafe macro into an inline function.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_ho
Convert the unsafe macro into an inline function.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index f554477fe6bc
Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks7010_sdio.c | 46 ++--
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdi
Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010_sdio.c | 46 ++--
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/ks7010
Remove the macro 'gdm_tty_recv' which adds unnecessary complexity and has
arguments that could mistakenly be evaluated multiple times.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_tty.c | 11 ++-
1 file changed, 6 insertions(+), 5 del
Remove the macro 'gdm_tty_recv' which adds unnecessary complexity and has
arguments that could mistakenly be evaluated multiple times.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_tty.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers
Remove the macro 'gdm_tty_send_control' which adds unnecessary complexity,
is unused, and has arguments that could mistakenly be evaluated multiple
times.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_tty.c | 3 ---
1 file changed, 3 deletions(-)
Remove the macro 'gdm_tty_send_control' which adds unnecessary complexity,
is unused, and has arguments that could mistakenly be evaluated multiple
times.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_tty.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging
Remove the macro 'gdm_tty_send' which adds unnecessary complexity and has
arguments that could mistakenly be evaluated multiple times.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_tty.c | 15 ++-
1 file changed, 6 insertions(+), 9 del
Remove the macro 'gdm_tty_send' which adds unnecessary complexity and has
arguments that could mistakenly be evaluated multiple times.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_tty.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers
Check the return value of of the register_lte_tty_driver() call in the
module initialization function.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_mux.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/g
Check the return value of of the register_lte_tty_driver() call in the
module initialization function.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_mux.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ks7010
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.h | 74 +-
1 file changed, 50 insertions(
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 74 +-
1 file changed, 50 insertions(+), 24 deletions(-)
diff
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks7010_sdio.c | 40
1 file changed, 27 insertions(
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010_sdio.c | 40
1 file changed, 27 insertions(+), 13 deletions(-)
diff
Fix a coding style warning from checkpatch.pl. Use GNU extensions to create
references to the results of problem macro arguments when they are evaluated so
that they can be used safely multiple times.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm
Fix a coding style warning from checkpatch.pl. Use GNU extensions to create
references to the results of problem macro arguments when they are evaluated so
that they can be used safely multiple times.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_tty.c | 24
Fix coding style warning from checkpatch.pl.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b/drivers/staging/gdm724x/gdm_lte.c
index ff3fed
Fix coding style warning from checkpatch.pl.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b/drivers/staging/gdm724x/gdm_lte.c
index ff3fed9c4a81..26a81fdd0044 100644
Fix a coding style problem causing warnings from checkpatch.pl.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 50 ++-
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/g
Fix a coding style problem causing warnings from checkpatch.pl.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 50 ++-
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b/drivers/staging
Removed parenthesis causing a coding style warning.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/fwserial/dma_fifo.c | 2 +-
drivers/staging/fwserial/fwserial.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/dma_
Removed parenthesis causing a coding style warning.
Signed-off-by: Quytelda Kahja
---
drivers/staging/fwserial/dma_fifo.c | 2 +-
drivers/staging/fwserial/fwserial.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/dma_fifo.c
b/drivers/staging
Replace the literal function name "visorbus_create_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file
Replace the literal function name "visorbus_create_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.
Signed-off-by: Quytelda Kahja
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 del
This patch replaces several instances where a pointer is compared to NULL
(i.e., `ptr == NULL`) with `!ptr`, which is preferred.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/android/ion/ion.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
This patch replaces several instances where a pointer is compared to NULL
(i.e., `ptr == NULL`) with `!ptr`, which is preferred.
Signed-off-by: Quytelda Kahja
---
drivers/staging/android/ion/ion.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1c785d
Signed-off-by: Quytelda Kahja
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1c785dd19ddd..1c6dc3a3e64a 100644
Replace the literal function name "create_bus_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file
Replace the literal function name "create_bus_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.
Signed-off-by: Quytelda Kahja
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 del
501 - 566 of 566 matches
Mail list logo
