[PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 USB reset binding

2020-12-04 Thread Rafał Miłecki
From: Rafał Miłecki Document binding of block responsible for initializing USB controllers (OHCI, EHCI, XHCI). Signed-off-by: Rafał Miłecki --- .../reset/brcm,bcm4908-usb-reset.yaml | 60 +++ 1 file changed, 60 insertions(+) create mode 100644 Documentation

[PATCH 2/2] reset: bcm4908-usb: add driver for BCM4908 USB reset controller

2020-12-04 Thread Rafał Miłecki
From: Rafał Miłecki This controller is responsible for OHCI, EHCI, XHCI and PHYs setup that has to be handled in the proper order. One unusual thing about this controller is that is provides access to the MDIO bus. There are two registers (in the middle of block space) responsible for that. For

Re: [PATCH 2/2] reset: bcm4908-usb: add driver for BCM4908 USB reset controller

2020-12-04 Thread Rafał Miłecki
On Fri, 4 Dec 2020 at 17:13, Philipp Zabel wrote: > On Fri, 2020-12-04 at 10:37 +0100, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > This controller is responsible for OHCI, EHCI, XHCI and PHYs setup that > > has to be handled in the proper order. > >

Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 USB reset binding

2020-12-04 Thread Rafał Miłecki
On 04.12.2020 17:32, Florian Fainelli wrote: On 12/4/2020 1:37 AM, Rafał Miłecki wrote: From: Rafał Miłecki Document binding of block responsible for initializing USB controllers (OHCI, EHCI, XHCI). Signed-off-by: Rafał Miłecki --- .../reset/brcm,bcm4908-usb-reset.yaml | 60

Re: [PATCH 2/2] reset: bcm4908-usb: add driver for BCM4908 USB reset controller

2020-12-04 Thread Rafał Miłecki
On 04.12.2020 17:38, Florian Fainelli wrote: On 12/4/2020 1:37 AM, Rafał Miłecki wrote: From: Rafał Miłecki This controller is responsible for OHCI, EHCI, XHCI and PHYs setup that has to be handled in the proper order. One unusual thing about this controller is that is provides access to the

[PATCH V2 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema

2020-12-20 Thread Rafał Miłecki
From: Rafał Miłecki Changes that require mentioning: 1. interrupt-names Name "wakeup" was changed to the "wake". It matches example and what Linux driver looks for in the first place 2. brcm,ipp and brcm,ioc Both were described as booleans with 0 / 1 values. In e

[PATCH V2 3/3] phy: phy-brcm-usb: support PHY on the BCM4908

2020-12-20 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 seems to have slightly different registers but works when programmed just like the STB one. Signed-off-by: Rafał Miłecki --- V2: Update Kconfig as well --- drivers/phy/broadcom/Kconfig| 3 ++- drivers/phy/broadcom/phy-brcm-usb.c | 4 2 files changed, 6

[PATCH V2 2/3] dt-bindings: phy: brcm,brcmstb-usb-phy: add BCM4908 binding

2020-12-20 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 uses the same PHY and may require just a slightly different programming. Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli --- .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml| 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 1/2] dt-bindings: phy: Add binding for BCM4908 USB PHYs

2020-12-02 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 SoCs have USB 2.0 PHY and USB 3.0 PHY attached to the MDIO bus. Those bindings allow describing them. Signed-off-by: Rafał Miłecki --- .../bindings/phy/bcm4908-usb-phy.yaml | 52 +++ 1 file changed, 52 insertions(+) create mode 100644

[PATCH 2/2] phy: phy-bcm4908-usb: Add drivers for USB PHYs

2020-12-02 Thread Rafał Miłecki
From: Rafał Miłecki This driver initializes BCM4908 USB PHYs so USB can be utilized. Signed-off-by: Rafał Miłecki --- drivers/phy/broadcom/Kconfig | 9 ++ drivers/phy/broadcom/Makefile | 1 + drivers/phy/broadcom/phy-bcm4908-usb.c | 204 + 3

Re: [PATCH] dt-bindings: phy: bcm-ns-usb3-phy: convert to yaml

2021-03-11 Thread Rafał Miłecki
Hi, On 16.11.2020 08:46, Rafał Miłecki wrote: From: Rafał Miłecki 1. Change syntax from txt to yaml 2. Drop "Driver for" from the title 3. Drop "reg = <0x0>;" from example (noticed by dt_binding_check) 4. Specify license Signed-off-by: Rafał Miłecki --- I think th

Re: [PATCH] dt-bindings: phy: bcm-ns-usb2-phy: convert to yaml

2021-03-11 Thread Rafał Miłecki
On 16.11.2020 08:46, Rafał Miłecki wrote: From: Rafał Miłecki 1. Convert from txt to yaml 2. Drop "Driver for" from the title 3. Document "#phy-cells" 4. Fix example node name (noticed by dt_binding_check) 5. Add #include to example (noticed by dt_binding_check) 6. Specify

Re: [PATCH v5 2/3] dt-bindings: mtd: Document use of nvmem-cells compatible

2021-03-11 Thread Rafał Miłecki
On 11.03.2021 11:50, Ansuel Smith wrote: On Thu, Mar 11, 2021 at 10:32:21AM -0700, Rob Herring wrote: On Thu, Mar 11, 2021 at 06:12:48AM +0100, Ansuel Smith wrote: Document nvmem-cells compatible used to treat mtd partitions as a nvmem provider. Signed-off-by: Ansuel Smith --- .../bindings/

Re: [PATCH Broadcom/stblinux] soc: brcmstb: add stubs for getting platform IDs

2021-01-20 Thread Rafał Miłecki
On 20.01.2021 20:58, Florian Fainelli wrote: On 1/20/2021 11:48 AM, Florian Fainelli wrote: On Thu, 14 Jan 2021 11:53:18 +0100, Rafał Miłecki wrote: From: Rafał Miłecki Some brcmstb drivers may be shared with other SoC families. E.g. the same USB PHY block is shared by brcmstb and BCM4908

Re: [PATCH v4 2/3] dt-bindings: mtd: Document use of nvmem-cells compatible

2021-03-10 Thread Rafał Miłecki
See inline On 10.03.2021 22:08, Ansuel Smith wrote: Document nvmem-cells compatible used to treat mtd partitions as a nvmem provider. Signed-off-by: Ansuel Smith --- .../bindings/mtd/partitions/nvmem-cells.yaml | 96 +++ 1 file changed, 96 insertions(+) create mode 100644

Re: [PATCH v4 2/3] dt-bindings: mtd: Document use of nvmem-cells compatible

2021-03-10 Thread Rafał Miłecki
On 10.03.2021 23:47, Ansuel Smith wrote: On Wed, Mar 10, 2021 at 11:41:24PM +0100, Rafał Miłecki wrote: See inline On 10.03.2021 22:08, Ansuel Smith wrote: Document nvmem-cells compatible used to treat mtd partitions as a nvmem provider. Signed-off-by: Ansuel Smith --- .../bindings/mtd

[PATCH stblinux.git 2/2] firmware: bcm47xx_nvram: support platform device "brcm,nvram"

2021-03-02 Thread Rafał Miłecki
From: Rafał Miłecki Add support for platform device providing mapping resource. This allows reading NVRAM based on DT mapping binding. It's required for devices that boot depending on NVRAM stored setup and provides early access to NVRAM data. Signed-off-by: Rafał Miłecki --- bcm47xx_

[PATCH stblinux.git 1/2] dt-bindings: firmware: add Broadcom's NVRAM memory mapping

2021-03-02 Thread Rafał Miłecki
From: Rafał Miłecki NVRAM structure contains device data and can be accessed using MMIO. Signed-off-by: Rafał Miłecki --- .../bindings/firmware/brcm,nvram.yaml | 41 +++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/firmware

Re: [PATCH v2 1/3] mtd: partitions: ofpart: skip subnodes parse with compatible

2021-03-02 Thread Rafał Miłecki
On 16.02.2021 22:26, Ansuel Smith wrote: If a partitions structure is not used, parse direct subnodes as fixed-partitions only if a compatible is not found or is of type fixed-partition. A parser can be used directly on the subnode and subnodes should not be parsed as fixed-partitions by default.

Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-06 Thread Rafał Miłecki
On 2021-03-06 09:00, Thomas Bogendoerfer wrote: On Fri, Mar 05, 2021 at 12:56:55PM +0100, Rafał Miłecki wrote: On 05.03.2021 12:47, Philippe Mathieu-Daudé wrote: > On Fri, Mar 5, 2021 at 11:16 AM Rafał Miłecki wrote: > > On 05.03.2021 10:58, Philippe Mathieu-Daudé wrote: > >

[PATCH mips/linux.git 1/5] firmware: bcm47xx_nvram: rename finding function and its variables

2021-03-08 Thread Rafał Miłecki
From: Rafał Miłecki 1. Use "bcm47xx_" function name prefix for consistency 2. It takes flash start as argument so s/iobase/flash_start/ 3. "off" was used for finding flash end so just call it "flash_size" Signed-off-by: Rafał Miłecki --- drivers/firmware

[PATCH mips/linux.git 0/5] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-08 Thread Rafał Miłecki
From: Rafał Miłecki This patchset refactors driver part finding and reading NVRAM. It been tested on BCM4706. Updated code checks the same offsets as before. Driver still finds & copies NVRAM content. It's a new patchset replacing previous single-patch attempt: [PATCH V2 mips/

[PATCH mips/linux.git 4/5] firmware: bcm47xx_nvram: look for NVRAM with for instead of while

2021-03-08 Thread Rafał Miłecki
From: Rafał Miłecki This loop requires variable initialization, stop condition and post iteration increment. It's pretty much a for loop definition. Signed-off-by: Rafał Miłecki --- drivers/firmware/broadcom/bcm47xx_nvram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH mips/linux.git 3/5] firmware: bcm47xx_nvram: extract code copying NVRAM

2021-03-08 Thread Rafał Miłecki
From: Rafał Miłecki This simplifies function finding NVRAM. It doesn't directly deal with NVRAM structure anymore and is a bit smaller. Signed-off-by: Rafał Miłecki --- drivers/firmware/broadcom/bcm47xx_nvram.c | 43 +-- 1 file changed, 25 insertions(+), 18 dele

[PATCH mips/linux.git 2/5] firmware: bcm47xx_nvram: add helper checking for NVRAM

2021-03-08 Thread Rafał Miłecki
From: Rafał Miłecki This avoids duplicating code doing casting and checking for NVRAM magic. Signed-off-by: Rafał Miłecki --- drivers/firmware/broadcom/bcm47xx_nvram.c | 30 ++- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/firmware/broadcom

[PATCH mips/linux.git 5/5] firmware: bcm47xx_nvram: inline code checking NVRAM size

2021-03-08 Thread Rafał Miłecki
From: Rafał Miłecki Separated function was not improving code quality much (or at all). Moreover it expected possible flash end address as argument and it was returning NVRAM size. The new code always operates on offsets which means less logic and less calculations. Signed-off-by: Rafał

Re: [PATCH v2 3/3] dt-bindings: mtd: Document use of nvmem-partitions compatible

2021-03-08 Thread Rafał Miłecki
On 05.03.2021 23:23, Rob Herring wrote: On Wed, Mar 03, 2021 at 11:01:55AM +0100, Rafał Miłecki wrote: [Rob: please advise] On 16.02.2021 22:26, Ansuel Smith wrote: Document nvmem-partitions compatible used to treat mtd partitions as a nvmem provider. Until now we were using "compa

Re: [PATCH v2 3/3] dt-bindings: mtd: Document use of nvmem-partitions compatible

2021-03-08 Thread Rafał Miłecki
On 16.02.2021 22:26, Ansuel Smith wrote: Document nvmem-partitions compatible used to treat mtd partitions as a nvmem provider. I'm just wondering if "nvmem-partitions" is accurate enough. Partitions bit sounds a bit ambiguous in the mtd context. What do you think about "mtd-nvmem-cells" or ju

Re: [PATCH v2 3/3] dt-bindings: mtd: Document use of nvmem-partitions compatible

2021-03-08 Thread Rafał Miłecki
On 07.03.2021 18:04, Ansuel Smith wrote: On Mon, Mar 08, 2021 at 10:48:32AM +0100, Rafał Miłecki wrote: On 16.02.2021 22:26, Ansuel Smith wrote: Document nvmem-partitions compatible used to treat mtd partitions as a nvmem provider. I'm just wondering if "nvmem-partitions" is

Re: [PATCH v2 3/3] dt-bindings: mtd: Document use of nvmem-partitions compatible

2021-03-08 Thread Rafał Miłecki
On 07.03.2021 18:04, Ansuel Smith wrote: On Mon, Mar 08, 2021 at 10:48:32AM +0100, Rafał Miłecki wrote: On 16.02.2021 22:26, Ansuel Smith wrote: Document nvmem-partitions compatible used to treat mtd partitions as a nvmem provider. I'm just wondering if "nvmem-partitions" is

Re: [PATCH stblinux.git 1/2] dt-bindings: firmware: add Broadcom's NVRAM memory mapping

2021-03-08 Thread Rafał Miłecki
On 08.03.2021 19:43, Rob Herring wrote: On Tue, Mar 02, 2021 at 08:44:04AM +0100, Rafał Miłecki wrote: From: Rafał Miłecki NVRAM structure contains device data and can be accessed using MMIO. Signed-off-by: Rafał Miłecki --- .../bindings/firmware/brcm,nvram.yaml | 41

Re: [PATCH stblinux.git 1/2] dt-bindings: firmware: add Broadcom's NVRAM memory mapping

2021-03-08 Thread Rafał Miłecki
On 08.03.2021 22:37, Rafał Miłecki wrote: On 08.03.2021 19:43, Rob Herring wrote: On Tue, Mar 02, 2021 at 08:44:04AM +0100, Rafał Miłecki wrote: From: Rafał Miłecki NVRAM structure contains device data and can be accessed using MMIO. Signed-off-by: Rafał Miłecki ---   .../bindings/firmware

[PATCH robh next] dt-bindings: usb: add USB controller port

2021-03-09 Thread Rafał Miłecki
From: Rafał Miłecki USB bindings already allow specifying USB device hard wired to a specific controller port but they don't allow describing port on its own. This fixes: arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dt.yaml: usb@23000: port@1: 'compatible' is a required proper

Re: [PATCH 2/3] dt-bindings: phy: brcm,ns-usb2-phy: bind single CRU reg

2021-03-09 Thread Rafał Miłecki
On 06.03.2021 22:52, Rob Herring wrote: On Fri, Feb 26, 2021 at 12:45:00PM +0100, Rafał Miłecki wrote: From: Rafał Miłecki The old binding was using whole DMU space. It was an overkill. DMU is a big block which contains e.g. CRU which contains e.g. PLLs, PHY, pinctrl and thermal blocks

Re: [PATCH] MAINTAINERS: rectify BROADCOM PMB (POWER MANAGEMENT BUS) DRIVER

2021-02-08 Thread Rafał Miłecki
vers/soc/bcm/bcm63xx/bcm-pmb.c'. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains: warning: no file matches F:drivers/soc/bcm/bcm-pmb.c Point the file entry to the right location. Signed-off-by: Lukas Bulwahn Thanks! Acked-by: Rafał Miłecki

Re: [PATCH V2 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema

2021-01-03 Thread Rafał Miłecki
On 03.01.2021 17:23, Rob Herring wrote: On Mon, Dec 21, 2020 at 06:23:37AM +0100, Rafał Miłecki wrote: From: Rafał Miłecki Changes that require mentioning: 1. interrupt-names Name "wakeup" was changed to the "wake". It matches example and what Linux driver looks fo

[PATCH 1/3] dt-bindings: mtd: move partition binding to its own file

2021-01-15 Thread Rafał Miłecki
From: Rafał Miłecki Single partition binding is quite common and may be: 1. Used by multiple parsers 2. Extended for more specific cases Move it to separated file to avoid code duplication. Signed-off-by: Rafał Miłecki --- .../mtd/partitions/fixed-partitions.yaml | 33

[PATCH 2/3] dt-bindings: mtd: add binding from BCM4908 partitions

2021-01-15 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 uses fixed partitions layout but function of some partitions may vary. Some devices use multiple firmware partitions and those should be marked to let system discover their purpose. Signed-off-by: Rafał Miłecki --- .../partitions/brcm,bcm4908-partitions.yaml | 68

[PATCH 3/3] mtd: parsers: ofpart: support BCM4908 fixed partitions

2021-01-15 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 partitioning is based on fixed layout but allows specifying multiple firmware partitions. It requires detecting which firmware partition was used for booting current kernel. To support such cases without duplicating a lot of code (without copying most of the ofpart.c

[PATCH V3 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema

2021-01-06 Thread Rafał Miłecki
From: Rafał Miłecki Changes that require mentioning: 1. interrupt-names Name "wakeup" was changed to the "wake". It matches example and what Linux driver looks for in the first place 2. brcm,ipp and brcm,ioc Both were described as booleans with 0 / 1 values. In e

[PATCH V3 2/3] dt-bindings: phy: brcm,brcmstb-usb-phy: add BCM4908 binding

2021-01-06 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 uses the same PHY and may require just a slightly different programming. Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli Acked-by: Rob Herring --- .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml| 5 - 1 file changed, 4 insertions(+), 1

[PATCH V3 3/3] phy: phy-brcm-usb: support PHY on the BCM4908

2021-01-06 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 seems to have slightly different registers but works when programmed just like the STB one. Signed-off-by: Rafał Miłecki --- V2: Update Kconfig as well --- drivers/phy/broadcom/Kconfig| 3 ++- drivers/phy/broadcom/phy-brcm-usb.c | 4 2 files changed, 6

[PATCH V4 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema

2021-01-06 Thread Rafał Miłecki
From: Rafał Miłecki Changes that require mentioning: 1. interrupt-names Name "wakeup" was changed to the "wake". It matches example and what Linux driver looks for in the first place 2. brcm,ipp and brcm,ioc Both were described as booleans with 0 / 1 values. In e

[PATCH V4 2/3] dt-bindings: phy: brcm,brcmstb-usb-phy: add BCM4908 binding

2021-01-06 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 uses the same PHY and may require just a slightly different programming. Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli Acked-by: Rob Herring --- .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml| 5 - 1 file changed, 4 insertions(+), 1

[PATCH V4 3/3] phy: phy-brcm-usb: support PHY on the BCM4908

2021-01-06 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 seems to have slightly different registers but works when programmed just like the STB one. Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli --- V2: Update Kconfig as well --- drivers/phy/broadcom/Kconfig| 3 ++- drivers/phy/broadcom/phy-brcm-usb.c

[PATCH 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema

2020-12-16 Thread Rafał Miłecki
From: Rafał Miłecki Changes that require mentioning: 1. interrupt-names Name "wakeup" was changed to the "wake". It matches example and what Linux driver looks for in the first place 2. brcm,ipp and brcm,ioc Both were described as booleans with 0 / 1 values. In e

[PATCH 3/3] phy: phy-brcm-usb: support BCM4908 binding

2020-12-16 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 seems to have slightly different registers but work when programmed just like the STB one. Signed-off-by: Rafał Miłecki --- drivers/phy/broadcom/phy-brcm-usb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers

[PATCH 2/3] dt-bindings: phy: brcm,brcmstb-usb-phy: add BCM4908 binding

2020-12-16 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 uses the same PHY and may require just slightly different programming. Signed-off-by: Rafał Miłecki --- .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml| 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree

[PATCH 1/2] phy: phy-brcm-usb: improve getting OF matching data

2020-12-16 Thread Rafał Miłecki
From: Rafał Miłecki 1. Use of_device_get_match_data() helper to simplify the code 2. Check for NULL as a good practice Signed-off-by: Rafał Miłecki --- drivers/phy/broadcom/phy-brcm-usb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/phy/broadcom/phy-brcm

[PATCH 2/2] phy: phy-brcm-usb: specify init function format at struct level

2020-12-16 Thread Rafał Miłecki
From: Rafał Miłecki This is slightly cleaner solution that assures noone assings a wrong function to the pointer. Signed-off-by: Rafał Miłecki --- drivers/phy/broadcom/phy-brcm-usb.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/phy/broadcom/phy-brcm-usb.c

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-14 Thread Rafał Miłecki
On 12.12.2020 04:26, Florian Fainelli wrote: + +static const struct bcm_pmb_pd_data bcm_pmb_bcm4908_data[] = { + { .name = "pcie2", .id = BCM_PMB_PCIE2, .bus = 0, .device = 2, }, + { .name = "pcie0", .id = BCM_PMB_PCIE0, .bus = 1, .device = 14, }, + { .name = "pcie1", .id = BCM_

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-14 Thread Rafał Miłecki
On 11.12.2020 23:08, Florian Fainelli wrote: On 12/11/20 1:59 PM, Rafał Miłecki wrote: From: Rafał Miłecki PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). It's needed to power on and off SoC blocks like PCIe, SATA, USB. Signed-off-by: Rafał Miłecki I will do a

[PATCH V2 1/2] dt-bindings: power: document Broadcom's PMB binding

2020-12-14 Thread Rafał Miłecki
From: Rafał Miłecki Broadcom's PMB is power controller used for disabling and enabling SoC devices. Signed-off-by: Rafał Miłecki --- .../bindings/power/brcm,bcm-pmb.yaml | 50 +++ include/dt-bindings/soc/bcm-pmb.h | 11 2 files changed, 61 inser

[PATCH V2 0/2] Broadcom's PMB (Power Management Bus) support

2020-12-14 Thread Rafał Miłecki
From: Rafał Miłecki PMB is a hardware block used for powering SoC devices like PCIe, USB, SATA. Initially I planned to treat it as a reset controller and Philipp pointed out in review that PMB driver should use a power subsystem. This is my refactored support. *** Please note one difference

[PATCH V2 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-14 Thread Rafał Miłecki
From: Rafał Miłecki PMB originally comes from BCM63138 but can be also found on many other chipsets (e.g. BCM4908). It's needed to power on and off SoC blocks like PCIe, SATA, USB. Signed-off-by: Rafał Miłecki --- V2: Use drivers/soc/bcm/bcm63xx/ Add help to the config BCM_PMB

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-14 Thread Rafał Miłecki
On 14.12.2020 18:32, Florian Fainelli wrote: On 12/14/20 4:24 AM, Rafał Miłecki wrote: On 11.12.2020 23:08, Florian Fainelli wrote: On 12/11/20 1:59 PM, Rafał Miłecki wrote: From: Rafał Miłecki PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). It's needed to power o

[PATCH 2/2] reset: simple: add BCM4908 MISC PCIe reset controller support

2020-11-27 Thread Rafał Miłecki
From: Rafał Miłecki It's a trivial reset controller. One register with bit per PCIe core. Signed-off-by: Rafał Miłecki --- drivers/reset/Kconfig| 2 +- drivers/reset/reset-simple.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/reset/Kconfig b/dr

[PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding

2020-11-27 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 was built using older PCIe hardware block that requires using external reset block controlling PERST# signals. Signed-off-by: Rafał Miłecki --- .../reset/brcm,bcm4908-misc-pcie-reset.yaml | 39 +++ 1 file changed, 39 insertions(+) create mode

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-10-30 Thread Rafał Miłecki
2013/10/1 Anssi Hannula : > ATI/AMD codecs do not support all the standard HDA HDMI/DP functions, > instead various vendor-specific verbs are provided. I've just tried my HD6970M (BARTS, DCE5) in my Samsung NP700G7A-S01PL. > cat /proc/asound/card1/eld#0.0 monitor_present 1 eld_valid 1 monitor_nam

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-10-31 Thread Rafał Miłecki
2013/10/30 Anssi Hannula : > BTW, there is a newer version (which was actually applied) of this patchset > in alsa-devel@, seems you were missing from CC on that one. I didn't try that updated version yet, but I'm afraid I discovered some problem. I've switched from my Denon 1912 to the older Onky

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-10-31 Thread Rafał Miłecki
2013/10/31 Anssi Hannula : >> But I can hear sound for rear right and rear left only :( >> >> Is there anything more I can provide to help resolve this? Do you have >> any idea how we can resolve this? > > According to the below the receiver has separate PCM SADs for 2-channel > and multichannel pl

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-10-31 Thread Rafał Miłecki
2013/11/1 Anssi Hannula : > Just to check, is the display mode 720p50 or higher (as per HDMI spec > 7.3.3)? Though I guess too small mode would cause something else, not > this... I'm using 1080p all the time. Do you think that HDMI_AUDIO_PACKETS_PER_LINE may have anything to do with this issue (s

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-11-01 Thread Rafał Miłecki
2013/11/1 Anssi Hannula : >> Both are working for me. I've tested it using 2 movies: >> 1) English TrueHD.5.1 @ 1417 kbps >> 2) Audio >> Codec: DTSHD-MA >> Bitrate..: 3718 kbps >> kHz/bit..: 24-bit >> Channels.: 5.1 >> Language.: Engli

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-11-01 Thread Rafał Miłecki
2013/11/1 Anssi Hannula : > Strange. One other thing to check (in addition to trying fglrx) would be > to try 192kHz 8ch audio with a different (non-ATI/AMD) card altogether, > to see if this is a receiver issue. What about this: 01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GF108 [

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-11-01 Thread Rafał Miłecki
2013/11/1 Rafał Miłecki : > 2013/11/1 Anssi Hannula : >> Strange. One other thing to check (in addition to trying fglrx) would be >> to try 192kHz 8ch audio with a different (non-ATI/AMD) card altogether, >> to see if this is a receiver issue. > > What about thi

Re: [PATCH] spi: bcm53xx: add BCMA dependency

2014-09-30 Thread Rafał Miłecki
On 30 September 2014 14:09, Arnd Bergmann wrote: > The BCMA bus framework can be disabled on bcm53xx, which leads to a link > error when building the SPI driver: You missed this one: https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/commit/?h=for-next&id=933fc7b06ca62741fd5067edab13068

Re: Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

2014-04-09 Thread Rafał Miłecki
2014-04-09 23:09 GMT+02:00 Josh Boyer : > With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma > module on the MacBookPro 10,2 I have here. This works fine with Linux > v3.14-7333-g59ecc26004e7. There have been no changes between those > two versions to bcma itself, but the GPIO merge

Re: pull request: wireless-next 2014-06-06

2014-06-06 Thread Rafał Miłecki
Hi John, On 6 June 2014 18:05, John W. Linville wrote: > Please accept this batch of fixes intended for the 3.16 stream. I'll be very thankful if you include my fix in the next pull request: [FIX for 3.16][PATCH] b43: disable 5 GHz on G-PHY It fixes a regression I unfortunately introduced and th

Re: Bisected 3.9 regression: Corrupted low memory (x86, mm: Move reserving low memory later in initialization)

2014-05-21 Thread Rafał Miłecki
On 16 May 2014 07:29, Rafał Miłecki wrote: > Sorry for the late report, this bug appears on my old notebook I don't > commonly use. Anyway, I've noticed following problem when using > 3.15-rc1: > > Corrupted low memory at 8800be98 (be98 phys) = b02a0004

Re: Bisected 3.9 regression: Corrupted low memory (x86, mm: Move reserving low memory later in initialization)

2014-05-21 Thread Rafał Miłecki
On 21 May 2014 19:34, H. Peter Anvin wrote: > On 05/21/2014 06:31 AM, Rafał Miłecki wrote: >> On 16 May 2014 07:29, Rafał Miłecki wrote: >>> Sorry for the late report, this bug appears on my old notebook I don't >>> commonly use. Anyway, I've noticed foll

Re: Linux 3.14-rc1 is out

2014-02-02 Thread Rafał Miłecki
Is that OK/wanted to note a possibly wide regression as Reply-To in the announce thread? If your USB 3.0 stopped working with 3.14-rc1, please note it's already tracked regression reported in: xhci regression since "xhci: replace xhci_write_64() with writeq()" - devices not detected http://w

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-18 Thread Rafał Miłecki
2013/11/17 Arend van Spriel : > On 11/17/13 14:37, Borislav Petkov wrote: >> >> From: Borislav Petkov >> >> When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get >> >> drivers/built-in.o: In function `brcms_led_unregister': >> (.text+0x351aca): undefined reference to `led_classdev_unregis

Re: [PATCH] mtd: spi-nor: Add support for SST spi flash

2014-10-21 Thread Rafał Miłecki
On 21 October 2014 13:37, Michal Simek wrote: > From: Harini Katakam > > Add sst25wf080 to the spi-nor device id table. I guess commit message could include some details. We already support plenty of SST flashes without this patch, don't we? -- To unsubscribe from this list: send the line "unsub

Re: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-22 Thread Rafał Miłecki
On 16 October 2014 02:52, bpqw wrote: > For example: > > const struct spi_device_id spi_nor_ids[] = { > .. > .. > .. > { "n25q064", INFO(0x20ba17, 0, 64 * 1024, 128, 0) }, > { "n25q128a11", INFO(0x20bb18, 0, 64 * 1024, 256, 0) },//former > right platform point w

Re: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-16 Thread Rafał Miłecki
On 14 October 2014 03:26, Bean Huo 霍斌斌 (beanhuo) wrote: > This patch used to modify the method of spi_nor_scan overwrite platform ID > point. > > If type of platform data match with the name of spi_nor_ids set, > and JEDEC ID also match with INFO ID of spi_nor_ids set,spi device > ID point(this i

Re: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-16 Thread Rafał Miłecki
On 16 October 2014 10:00, Bean Huo 霍斌斌 (beanhuo) wrote: >>There are a lot of changes happening/requested around this code. I also >>proposed some patch touching this code, see >>https://patchwork.ozlabs.org/patch/377917/ > >>Right now there is a slow ongoing work on fixing some m25p80 regression

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Rafał Miłecki
On 3 October 2014 17:27, Artem Bityutskiy wrote: > Yes, I guess a single patch is indeed OK. I have few nit-picks, though. > > On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman wrote: >> - ubi_err("'ubi_io_read_ec_hdr()' returned unknown code %d", >> err); >> + ubi_err(ubi

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Rafał Miłecki
On 3 October 2014 18:19, Artem Bityutskiy wrote: > On Fri, 2014-10-03 at 17:50 +0200, Rafał Miłecki wrote: >> On 3 October 2014 17:27, Artem Bityutskiy wrote: >> > Yes, I guess a single patch is indeed OK. I have few nit-picks, though. >> > >> > On Tue, 2014-

Re: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-27 Thread Rafał Miłecki
On 27 October 2014 09:44, bpqw wrote: > Maybe this patch is not very reasonable.But for fix this case,I will develop > a new patch that > is just used to add extended ID for micron spi nor in the spi_nor_ids[]. Great, I hope it will work on top of the [PATCH] mtd: spi-nor: prefer more specific

Re: [PATCH 1/2] mtd: spi-nor: Add GD25LQ32C 1.8V SPI NOR flash ID

2015-07-28 Thread Rafał Miłecki
On 28 July 2015 at 16:33, Marek Vasut wrote: > On Tuesday, July 28, 2015 at 11:07:57 AM, Michal Suchanek wrote: >> This 1.8V SPI NOR flash is found on ARM Chromebook XE303C and reads >> something like 25LQ32VIG in the middle. >> >> Signed-off-by: Michal Suchanek >> --- >> drivers/mtd/spi-nor/spi

Re: [PATCH 2/2] mtd: spi-nor: Add Pm25LD020 and GD25Q41B chip ID.

2015-07-28 Thread Rafał Miłecki
On 28 July 2015 at 16:33, Marek Vasut wrote: > On Tuesday, July 28, 2015 at 11:07:58 AM, Michal Suchanek wrote: >> First chip reads Pm25LD020 or Pm25L0020. Found on some WD HDD PCB. >> Identified as PMC Pm25LD020. >> Flash read does not return consistent data which explains why the disk >> died. >

Re: [PATCH V3] phy: bcm-ns-usb2: new driver for USB 2.0 PHY on Northstar

2016-04-14 Thread Rafał Miłecki
Hi and thanks for your review! On 13 April 2016 at 15:54, Kishon Vijay Abraham I wrote: > On Monday 11 April 2016 03:13 PM, Rafał Miłecki wrote: >> +Example: >> + usb2-phy { >> + compatible = "brcm,ns-usb2-phy"; >> + reg = <

[PATCH 01/12] mtd: nand: bf5xx: set ECC algorithm explicitly

2016-04-15 Thread Rafał Miłecki
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to enum nand_ecc_algo). Signed-off-by: Rafał Miłecki --- drivers/mtd/nand/bf5xx_nand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/bf5xx_nand.c b/drivers/mtd/nand/bf5xx_nand.c index b38f414..37da423

[PATCH 02/12] mtd: nand: davinci: set ECC algorithm explicitly

2016-04-15 Thread Rafał Miłecki
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to enum nand_ecc_algo). Signed-off-by: Rafał Miłecki Signed-off-by: Boris Brezillon --- drivers/mtd/nand/davinci_nand.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd

[PATCH 06/12] staging: mt29f_spinand: set ECC algorithm explicitly

2016-04-15 Thread Rafał Miłecki
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to enum nand_ecc_algo). Signed-off-by: Rafał Miłecki --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging

[PATCH 11/12] of: mtd: drop support for NAND_ECC_SOFT_BCH as "soft_bch" mapping

2016-04-15 Thread Rafał Miłecki
lgorithm, it's just handled in of_get_nand_ecc_algo now. Signed-off-by: Rafał Miłecki --- drivers/of/of_mtd.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/of/of_mtd.c b/drivers/of/of_mtd.c index 15d056e..a70a38c 100644 --- a/drivers/of/of_mtd.c +++ b/drivers/of/of_mtd.c

[PATCH 10/12] mtd: nand: read ECC algorithm from the new field

2016-04-15 Thread Rafał Miłecki
Now we have all drivers properly setting this new field we can start using it and proceed with deprecating NAND_ECC_SOFT_BCH. Signed-off-by: Rafał Miłecki --- drivers/mtd/nand/nand_base.c | 98 1 file changed, 53 insertions(+), 45 deletions(-) diff

[PATCH 07/12] mtd: nand: set ECC algorithm to Hamming on fallback

2016-04-15 Thread Rafał Miłecki
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to enum nand_ecc_algo). Signed-off-by: Rafał Miłecki --- drivers/mtd/nand/nand_base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index dd02c09..e1f3cf8

[PATCH 03/12] avr32: set Atmel NAND ECC algorithm explicitly

2016-04-15 Thread Rafał Miłecki
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to enum nand_ecc_algo). Signed-off-by: Rafał Miłecki --- arch/avr32/boards/atngw100/setup.c | 1 + arch/avr32/boards/atstk1000/atstk1002.c | 1 + include/linux/platform_data/atmel.h | 1 + 3 files changed, 3

[PATCH 04/12] mtd: nand: atmel: set ECC algorithm explicitly

2016-04-15 Thread Rafał Miłecki
Set it to value obtained from platform data with fallback to Hamming. This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to enum nand_ecc_algo). Signed-off-by: Rafał Miłecki --- drivers/mtd/nand/atmel_nand.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/mtd

[PATCH 12/12] mtd: mtd: drop NAND_ECC_SOFT_BCH enum value

2016-04-15 Thread Rafał Miłecki
This value should not be part of nand_ecc_modes_t as it specifies algorithm not a mode. We successfully managed to introduce new "algo" field which is respected now. Signed-off-by: Rafał Miłecki --- drivers/mtd/nand/fsmc_nand.c | 3 +-- drivers/mtd/nand/jz4780_nand.c | 1 - driver

[PATCH 05/12] CRIS v32: nand: set ECC algorithm explicitly

2016-04-15 Thread Rafał Miłecki
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to enum nand_ecc_algo). Signed-off-by: Rafał Miłecki --- arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 1 + arch/cris/arch-v32/drivers/mach-fs/nandflash.c | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/cris/arch

[PATCH 08/12] mtd: nand: hisi504: set ECC algorithm based on DT info

2016-04-15 Thread Rafał Miłecki
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to enum nand_ecc_algo). Signed-off-by: Rafał Miłecki --- drivers/mtd/nand/hisi504_nand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c index 7bf844c

[PATCH 09/12] mtd: nand: fsmc: validate ECC setup by checking algorithm directly

2016-04-15 Thread Rafał Miłecki
NAND core sets ECC algorithm in algo field now and it should be preferred over the mode field. This also prepares driver for dropping NAND_ECC_SOFT_BCH. Signed-off-by: Rafał Miłecki --- drivers/mtd/nand/fsmc_nand.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH 09/12] mtd: nand: fsmc: validate ECC setup by checking algorithm directly

2016-04-15 Thread Rafał Miłecki
On 15 April 2016 at 22:24, Joe Perches wrote: > On Fri, 2016-04-15 at 13:23 -0700, Joe Perches wrote: >> Why not just add NAND_ECC_SOFT above the default case? > > Nevermind, misread. At least someone reviews it which is nice :) -- Rafał

Re: Regression: netlink fail (triggered by iw) removes extra wlan (phy) interface

2016-05-04 Thread Rafał Miłecki
Hi again and sorry for the late reply. On 16 March 2016 at 17:00, Cong Wang wrote: > On Thu, Feb 25, 2016 at 5:22 AM, Rafał Miłecki wrote: >> After updating kernel in OpenWrt from 4.1.6 to 4.1.10 I noticed that >> if "iw" command fails (which happens very rar

Re: [PATCH] ARM: BCM5301X: Add DT for Luxul XAP-1510

2016-05-04 Thread Rafał Miłecki
On 4 May 2016 at 20:53, Florian Fainelli wrote: > On 03/05/16 10:28, Dan Haab wrote: >> Luxul XAP-1510 is an AP device based on BCM4708 SoC. It uses flash >> memory connected to the SPI controller. > > Looks fine, except one nit: > >> diff --git a/arch/arm/boot/dts/bcm4708-luxul-xap-1510.dts >> b

Re: [patch] phy: bcm-ns-usb2: checking the wrong variable

2016-05-10 Thread Rafał Miłecki
On 10 May 2016 at 10:01, Dan Carpenter wrote: > We intended to test "usb2->phy" here instead of "dev". > > Fixes: d3feb4067335 ('phy: bcm-ns-usb2: new driver for USB 2.0 PHY on > Northstar') > Signed-off-by: Dan Carpenter Thanks!

[PATCH] brcmfmac: fix setting AP channel with new firmwares

2016-05-24 Thread Rafał Miłecki
nterfaces so it leaves this code unaffected. Signed-off-by: Rafał Miłecki --- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wi

[PATCH] brcmfmac: print error in p2p_ifadd firmware command fails

2016-05-24 Thread Rafał Miłecki
This is helpful for debugging, without this all I was getting from "iw" command on device with BCM43602 was: > command failed: Too many open files in system (-23) Signed-off-by: Rafał Miłecki --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +- 1 file changed, 1 in

<    1   2   3   4   5   6   7   >