[GIT PULL] ACPI fixes for v5.11-rc3

2021-01-08 Thread Rafael J. Wysocki
text for items that are no longer modular Rafael J. Wysocki (1): ACPI: PM: s2idle: Drop unused local variables and related code Shawn Guo (1): ACPI: scan: add stub acpi_create_platform_device() for !CONFIG_ACPI --- drivers/acpi/Kconfig | 6 -- drivers/acpi/x86

Re: [PATCH] drivers: core: Detach device from power domain on shutdown

2021-01-08 Thread Rafael J. Wysocki
On Fri, Jan 8, 2021 at 4:43 PM Greg Kroah-Hartman wrote: > > On Mon, Dec 14, 2020 at 08:56:48PM -0800, Furquan Shaikh wrote: > > On Tue, Dec 1, 2020 at 1:30 PM Furquan Shaikh wrote: > > > > > > When the system is powered off or rebooted, devices are not detached > > > from their PM domain. This

Re: [PATCH] drivers: core: Detach device from power domain on shutdown

2021-01-08 Thread Rafael J. Wysocki
power resources for the device thus complying with its > power sequencing requirements. > > Signed-off-by: Furquan Shaikh Acked-by: Rafael J. Wysocki > --- > drivers/base/core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/base/core.c b/drivers/base/

[PATCH v1 0/3] cpufreq: intel_pstate: Assorted cleanups

2021-01-07 Thread Rafael J. Wysocki
Hi, These three patches clean up intel_pstate a bit: [1/3] makes it always use READ_ONCE() for reading hwp_cap_cached [2/3] changes the first argument of intel_pstate_get_hwp_max() [3/3] renames to functions (to avoid possible confusion). Please see patch changelogs for details. Thanks!

[PATCH v1 3/3] cpufreq: intel_pstate: Rename two functions

2021-01-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Rename intel_cpufreq_adjust_hwp() and intel_cpufreq_adjust_perf_ctl() to intel_cpufreq_hwp_update() and intel_cpufreq_perf_ctl_update(), respectively, to avoid possible confusion with the ->adjist_perf() callback function, intel_cpufreq_adjust_perf(). Signed-

[PATCH v1 2/3] cpufreq: intel_pstate: Change intel_pstate_get_hwp_max() argument

2021-01-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki All of the callers of intel_pstate_get_hwp_max() access the struct cpudata object that corresponds to the given CPU already and the function itself needs to access that object (in order to update hwp_cap_cached), so modify the code to pass a struct cpudata pointer

[PATCH v1 1/3] cpufreq: intel_pstate: Always read hwp_cap_cached with READ_ONCE()

2021-01-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Because intel_pstate_get_hwp_max() which updates hwp_cap_cached may run in parallel with the readers of it, annotate all of the read accesses to it with READ_ONCE(). Signed-off-by: Rafael J. Wysocki --- drivers/cpufreq/intel_pstate.c | 13 +++-- 1 file

Re: [PATCH] cpufreq: intel_pstate: remove obsolete functions

2021-01-07 Thread Rafael J. Wysocki
On Mon, Dec 21, 2020 at 11:21 PM Nathan Chancellor wrote: > > On Mon, Dec 21, 2020 at 06:13:20AM +0100, Lukas Bulwahn wrote: > > percent_fp() was used in intel_pstate_pid_reset(), which was removed in > > commit 9d0ef7af1f2d ("cpufreq: intel_pstate: Do not use PID-based P-state > > selection")

Re: [PATCH][next] powercap/drivers/dtpm: Fix size of object being allocated

2021-01-07 Thread Rafael J. Wysocki
On Mon, Jan 4, 2021 at 3:24 PM Daniel Lezcano wrote: > > On 04/01/2021 13:10, Colin King wrote: > > From: Colin Ian King > > > > The kzalloc allocation for dtpm_cpu is currently allocating the size > > of the pointer and not the size of the structure. Fix this by using > > the correct sizeof

Re: [PATCH v2 1/2] ACPI: platform-profile: Introduce object pointers to callbacks

2021-01-07 Thread Rafael J. Wysocki
On Tue, Jan 5, 2021 at 2:18 PM Hans de Goede wrote: > > Hi, > > On 1/5/21 2:14 PM, Jiaxun Yang wrote: > > Add a object pointer to handler callbacks to avoid having > > global variables everywhere. > > > > Signed-off-by: Jiaxun Yang > > Suggested-by: Hans de Goede > > Thanks, patch looks good to

Re: [PATCH 2/2] device property: add description of fwnode cases

2021-01-07 Thread Rafael J. Wysocki
On Thu, Jan 7, 2021 at 3:11 PM Heikki Krogerus wrote: > > On Tue, Jan 05, 2021 at 05:11:46PM +0800, Bard Liao wrote: > > There are only four valid fwnode cases which are > > - primary --> secondary --> -ENODEV > > - primary --> NULL > > - secondary --> -ENODEV > > - NULL > > > > dev->fwnode

Re: [PATCH] ACPI: Update Kconfig help text for items that are no longer modular

2021-01-07 Thread Rafael J. Wysocki
On Tue, Dec 29, 2020 at 12:19 PM Peter Robinson wrote: > > The CONTAINER and HOTPLUG_MEMORY memory options mention modules > but are bool only options so if selected are alway built in. Drop > the help text about modules. > > Signed-off-by: Peter Robinson > --- > drivers/acpi/Kconfig | 6 --

Re: [PATCH] ACPI: add stub acpi_create_platform_device() for !CONFIG_ACPI

2021-01-07 Thread Rafael J. Wysocki
On Thu, Dec 31, 2020 at 12:36 PM Shawn Guo wrote: > > It adds a stub acpi_create_platform_device() for !CONFIG_ACPI build, so > that caller doesn't have to deal with !CONFIG_ACPI build issue. > > Reported-by: kernel test robot > Signed-off-by: Shawn Guo > --- > This fixes an build issue

Re: [PATCH][V3] cpufreq: powernow-k8: pass policy rather than use cpufreq_cpu_get

2021-01-07 Thread Rafael J. Wysocki
On Tue, Jan 5, 2021 at 11:22 AM Viresh Kumar wrote: > > On 05-01-21, 10:19, Colin King wrote: > > From: Colin Ian King > > > > Currently there is an unlikely case where cpufreq_cpu_get returns a > > null policy and this will cause a null pointer dereference later on. > > Fix this by passing the

Re: [PATCH 0/2] IdeaPad platform profile support

2021-01-07 Thread Rafael J. Wysocki
On Wed, Jan 6, 2021 at 10:17 AM Hans de Goede wrote: > > Hi, > > On 1/5/21 6:18 PM, Rafael J. Wysocki wrote: > > On Mon, Jan 4, 2021 at 9:58 PM Hans de Goede wrote: > > > > >> Patch 1/2 does use a slightly different approach then I suggest above, &g

Re: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-07 Thread Rafael J. Wysocki
On Tue, Jan 5, 2021 at 11:02 PM Dexuan Cui wrote: > > > From: Michael Kelley > > Sent: Tuesday, December 22, 2020 5:56 AM > > From: Dexuan Cui > > Sent: Thursday, December 17, 2020 > > 8:08 PM > > > > > > Linux VM on Hyper-V crashes with the latest mainline: > > > ... > > > ---

Re: [PATCH] ACPI: PM: s2idle: Remove useless variable ‘obj_new’ in lpi_device_get_constraints_amd

2021-01-07 Thread Rafael J. Wysocki
On Wed, Jan 6, 2021 at 2:13 AM Ye Bin wrote: > > Fix warning: > drivers/acpi/x86/s2idle.c:138:25: warning: variable ‘obj_new’ set but > not used [-Wunused-but-set-variable] > union acpi_object *obj_new; >^~~ > Reported-by: Hulk Robot > Signed-off-by: Ye

[PATCH] cpufreq: intel_pstate: Use HWP capabilities in intel_cpufreq_adjust_perf()

2021-01-05 Thread Rafael J. Wysocki
From: Rafael J. Wysocki If turbo P-states cannot be used, either due to the configuration of the processor, or because intel_pstate is not allowed to used them, the maximum available P-state with HWP enabled corresponds to the HWP_CAP.GUARANTEED value which is not static. It can be adjusted

[PATCH] ACPI: PM: s2idle: Drop unused local variables and related code

2021-01-05 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Two local variables in drivers/acpi/x86/s2idle.c are never read, so drop them along with the code updating their values (in vain). Fixes: fef98671194b ("ACPI: PM: s2idle: Move x86-specific code to the x86 directory") Signed-off-by: Rafael J. Wysocki --- dr

Re: [PATCH 0/2] IdeaPad platform profile support

2021-01-05 Thread Rafael J. Wysocki
On Mon, Jan 4, 2021 at 9:58 PM Hans de Goede wrote: > > Hi, > > On 1/4/21 9:33 PM, Rafael J. Wysocki wrote: > > On Mon, Jan 4, 2021 at 3:36 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 1/1/21 1:56 PM, Jiaxun Yang wrote: > >>>

Re: [PATCH 0/2] IdeaPad platform profile support

2021-01-04 Thread Rafael J. Wysocki
On Mon, Jan 4, 2021 at 3:36 PM Hans de Goede wrote: > > Hi, > > On 1/1/21 1:56 PM, Jiaxun Yang wrote: > > Tested on Lenovo Yoga-14SARE Chinese Edition. > > > > Jiaxun Yang (2): > > ACPI: platform-profile: Introduce data parameter to handler > > platform/x86: ideapad-laptop: DYTC Platform

Re: power-off delay/hang due to commit 6d25be57 (mainline)

2021-01-02 Thread Rafael J. Wysocki
On Thursday, December 31, 2020 9:46:11 PM CET Rafael J. Wysocki wrote: > On Wednesday, December 2, 2020 8:13:38 PM CET Rafael J. Wysocki wrote: > > On Wed, Dec 2, 2020 at 7:31 PM Rafael J. Wysocki wrote: > > > > > > On Wed, Dec 2, 2020 at 7:03 PM Sebastian A

[GIT PULL][Resend] Power management updates for v5.11-rc2

2021-01-02 Thread Rafael J. Wysocki
memory leak in _allocate_opp_table Rafael J. Wysocki (1): cpufreq: intel_pstate: Fix fast-switch fallback path Viresh Kumar (1): opp: Call the missing clk_put() on error --- MAINTAINERS| 2 +- drivers/cpufreq/intel_pstate.c | 1 - drivers/idle

Re: [GIT PULL] Power management updates for v5.11-rc2

2021-01-01 Thread Rafael J. Wysocki
On Fri, Jan 1, 2021 at 10:12 PM Linus Torvalds wrote: > > On Fri, Jan 1, 2021 at 8:51 AM Rafael J. Wysocki wrote: > > > > - Add new power capping facility called DTPM (Dynamic Thermal Power > >Management), based on the existing power capping framework, to >

[GIT PULL] Power management updates for v5.11-rc2

2021-01-01 Thread Rafael J. Wysocki
/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols Lukas Bulwahn (1): MAINTAINERS: include governors into CPU IDLE TIME MANAGEMENT FRAMEWORK Quanyang Wang (1): opp: fix memory leak in _allocate_opp_table Rafael J. Wysocki (1): cpufreq: intel_pstate: Fix fast-switch

Re: power-off delay/hang due to commit 6d25be57 (mainline)

2020-12-31 Thread Rafael J. Wysocki
On Wednesday, December 2, 2020 8:13:38 PM CET Rafael J. Wysocki wrote: > On Wed, Dec 2, 2020 at 7:31 PM Rafael J. Wysocki wrote: > > > > On Wed, Dec 2, 2020 at 7:03 PM Sebastian Andrzej Siewior > > wrote: > > > > > > On 2020-10-26 18:20

Re: [PATCH] powercap/drivers/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols

2020-12-30 Thread Rafael J. Wysocki
On Wed, Dec 30, 2020 at 4:38 PM Daniel Lezcano wrote: > > 32 bits architectures do not support u64 division, so the macro > DIV_ROUND_CLOSEST is not adequate as the compiler will replace the > call to an unexisting function for the platform, leading to an > unresolved symbols. > > Fix this by

[PATCH] cpufreq: intel_pstate: Fix fast-switch fallback path

2020-12-29 Thread Rafael J. Wysocki
From: Rafael J. Wysocki When sugov_update_single_perf() falls back to the "frequency" path due to the missing scale-invariance, it will call cpufreq_driver_fast_switch() via sugov_fast_switch() and the driver's ->fast_switch() callback will be invoked, so it must not be NULL. H

Re: [PATCH v2 0/3] cpufreq: Allow drivers to receive more information from the governor

2020-12-28 Thread Rafael J. Wysocki
On Wed, Dec 23, 2020 at 2:08 PM Giovanni Gherdovich wrote: > > On Mon, 2020-12-21 at 17:11 +0100, Rafael J. Wysocki wrote: > > Hi, > > > > On Fri, Dec 18, 2020 at 5:22 PM Giovanni Gherdovich wrote: > > > > > > Gitsource: this test show the most c

[GIT PULL] More ACPI updates for v5.11-rc1

2020-12-22 Thread Rafael J. Wysocki
). Thanks! --- Hans de Goede (1): ACPI: scan: Add Intel Baytrail Mailbox Device to acpi_ignore_dep_ids Hui Wang (1): ACPI: PNP: compare the string length in the matching_id() Rafael J. Wysocki (4): ACPI: scan: Evaluate _DEP before adding the device ACPI: scan: Defer

[GIT PULL] More power management updates for v5.11-rc1

2020-12-22 Thread Rafael J. Wysocki
: replace per-cpu data array with a list Punit Agrawal (1): ACPI: processor: Drop duplicate setting of shared_cpu_map Rafael J. Wysocki (4): cpufreq: schedutil: Add util to struct sg_cpu cpufreq: Add special-purpose fast-switching callback for drivers cpufreq: intel_psta

Re: [PATCH] MAINTAINERS: include governors into CPU IDLE TIME MANAGEMENT FRAMEWORK

2020-12-22 Thread Rafael J. Wysocki
On Thu, Dec 17, 2020 at 8:16 AM Lukas Bulwahn wrote: > > The current pattern in the file entry does not make the files in the > governors subdirectory to be a part of the CPU IDLE TIME MANAGEMENT > FRAMEWORK. > > Adjust the file pattern to include files in governors. > > Signed-off-by: Lukas

Re: [PATCH v5 0/4] powercap/dtpm: Add the DTPM framework

2020-12-22 Thread Rafael J. Wysocki
On Fri, Dec 11, 2020 at 8:15 PM Rafael J. Wysocki wrote: > > On Fri, Dec 11, 2020 at 11:41 AM Daniel Lezcano > wrote: > > > > > > Hi Rafael, > > > > I believe I took into account all the comments, do you think it is > > possible to merge this s

Re: [PATCH 0/4] sched/idle: Fix missing need_resched() checks after rcu_idle_enter()

2020-12-22 Thread Rafael J. Wysocki
/idle.c | 18 -- 4 files changed, 51 insertions(+), 17 deletions(-) Please feel free to add Reviewed-by: Rafael J. Wysocki to all patches in the series. Thanks!

Re: [PATCH v2 0/3] cpufreq: Allow drivers to receive more information from the governor

2020-12-21 Thread Rafael J. Wysocki
Hi, On Fri, Dec 18, 2020 at 5:22 PM Giovanni Gherdovich wrote: > > On Mon, 2020-12-14 at 21:01 +0100, Rafael J. Wysocki wrote: > > Hi, > > > > The timing of this is not perfect (sorry about that), but here's a refresh > > of this series. > > > > The m

Re: [PATCH v2 0/3] cpufreq: Allow drivers to receive more information from the governor

2020-12-21 Thread Rafael J. Wysocki
On Thu, Dec 17, 2020 at 4:27 PM Doug Smythies wrote: > > On 2020.12.14 12:02 Rafael J. Wysocki wrote: > > > Hi, > > Hi Rafael, > > V2 test results below are new, other results are partially re-stated: > > For readers that do not want to read on, I didn'

Re: [PATCH v1 0/5] Enable fw_devlink=on by default

2020-12-21 Thread Rafael J. Wysocki
On Fri, Dec 18, 2020 at 4:17 AM Saravana Kannan wrote: > > As discussed in LPC 2020, cyclic dependencies in firmware that couldn't > be broken using logic was one of the last remaining reasons > fw_devlink=on couldn't be set by default. > > This series changes fw_devlink so that when a cyclic

Re: [PATCH] cpufreq: intel_pstate: Use most recent guaranteed performance values

2020-12-20 Thread Rafael J. Wysocki
On Sat, Dec 19, 2020 at 6:21 AM srinivas pandruvada wrote: > > On Thu, 2020-12-17 at 20:17 +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > When turbo has been disabled by the BIOS, but HWP_CAP.GUARANTEED is > > changed later, user sp

[PATCH] ACPI: PM: s2idle: More x86-specific code to the x86 directory

2020-12-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Some code in drivers/acpi/sleep.c (which is regarded as a generic file) related to suspend-to-idle support has grown direct dependencies on x86, but in fact it has been specific to x86 (which is the only user of it) anyway for a long time. For this reason, move that code

[PATCH] cpufreq: intel_pstate: Use most recent guaranteed performance values

2020-12-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki When turbo has been disabled by the BIOS, but HWP_CAP.GUARANTEED is changed later, user space may want to take advantage of this increased guaranteed performance. HWP_CAP.GUARANTEED is not a static value. It can be adjusted by an out-of-band agent or during an Intel

Re: [PATCH] cpufreq: intel_pstate: Use the latest guaranteed freq during verify

2020-12-17 Thread Rafael J. Wysocki
On Thu, Dec 17, 2020 at 6:29 PM Rafael J. Wysocki wrote: > > On Thu, Dec 17, 2020 at 6:09 PM Srinivas Pandruvada > wrote: > > > > On Thu, 2020-12-17 at 16:24 +0100, Rafael J. Wysocki wrote: > > > On Thu, Dec 17, 2020 at 4:21 PM Srinivas Pandruvada > > >

Re: [PATCH] cpufreq: intel_pstate: Use the latest guaranteed freq during verify

2020-12-17 Thread Rafael J. Wysocki
On Thu, Dec 17, 2020 at 6:09 PM Srinivas Pandruvada wrote: > > On Thu, 2020-12-17 at 16:24 +0100, Rafael J. Wysocki wrote: > > On Thu, Dec 17, 2020 at 4:21 PM Srinivas Pandruvada > > wrote: > > > > > > On Thu, 2020-12-17 at 16:12 +0100, Rafael J. Wysocki wro

Re: [PATCH] cpufreq: intel_pstate: Use the latest guaranteed freq during verify

2020-12-17 Thread Rafael J. Wysocki
On Thu, Dec 17, 2020 at 4:21 PM Srinivas Pandruvada wrote: > > On Thu, 2020-12-17 at 16:12 +0100, Rafael J. Wysocki wrote: > > On Thursday, December 17, 2020 3:23:44 PM CET Srinivas Pandruvada > > wrote: > > > On Thu, 2020-12-17 at 06:19 -0800, Srinivas Pandruvada wro

Re: [PATCH] cpufreq: intel_pstate: Use the latest guaranteed freq during verify

2020-12-17 Thread Rafael J. Wysocki
On Thursday, December 17, 2020 3:23:44 PM CET Srinivas Pandruvada wrote: > On Thu, 2020-12-17 at 06:19 -0800, Srinivas Pandruvada wrote: > > On Thu, 2020-12-17 at 14:58 +0100, Rafael J. Wysocki wrote: > > > On Thu, Dec 17, 2020 at 11:44 AM Srinivas Pandr

Re: [PATCH] cpufreq: intel_pstate: Use the latest guaranteed freq during verify

2020-12-17 Thread Rafael J. Wysocki
On Thu, Dec 17, 2020 at 11:44 AM Srinivas Pandruvada wrote: > > This change tries to address an issue, when BIOS disabled turbo > but HWP_CAP guaranteed is changed later and user space wants to take > advantage of this increased guaranteed performance. > > The HWP_CAP.GUARANTEED value is not a

Re: [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support

2020-12-15 Thread Rafael J. Wysocki
On Mon, Dec 14, 2020 at 5:14 PM Mian Yousaf Kaukab wrote: > > On Mon, Dec 14, 2020 at 12:38:19PM +, Ionela Voinescu wrote: > > Hi guys, > > > > I'm sending v2 of some of the patches at [1] in light of the discussions > > at [2]. > > > > v2: > > - Patches 1-3 are trivial rebase on linux next

Re: [PATCH v2] ACPI: processor: fix NONE coordination for domain mapping failure

2020-12-15 Thread Rafael J. Wysocki
hat both functions return domains with a single CPU, this change > does not affect the functionality, but clarifies the intention. > > Signed-off-by: Ionela Voinescu > Acked-by: Viresh Kumar > [ rjw: Subject edit ] > Signed-off-by: Rafael J. Wysocki > --- > > Hi guy

[GIT PULL] ACPI updates for v5.11-rc1

2020-12-15 Thread Rafael J. Wysocki
(1): ACPI: video: Add DMI quirk for GIGABYTE GB-BXBT-2807 Punit Agrawal (1): ACPI: processor: Drop duplicate setting of shared_cpu_map Rafael J. Wysocki (8): ACPI: EC: Fold acpi_ec_clear_gpe() into its caller ACPI: EC: Rename acpi_ec_is_gpe_raised() ACPI:

[GIT PULL] Power management updates for v5.11-rc1

2020-12-15 Thread Rafael J. Wysocki
missing MODULE_ALIAS Patrice Chotard (1): PM: sleep: Add dev_wakeup_path() helper Pavankumar Kondeti (1): PM / EM: Micro optimization in em_cpu_energy Qinglang Miao (1): cpufreq: mediatek: add missing platform_driver_unregister() on error in mtk_cpufreq_driver_init Rafael J. Wysocki

Re: [PATCH v1 3/4] cpufreq: Add special-purpose fast-switching callback for drivers

2020-12-15 Thread Rafael J. Wysocki
On Tue, Dec 15, 2020 at 5:17 AM Viresh Kumar wrote: > > On 08-12-20, 14:32, Viresh Kumar wrote: > > On 07-12-20, 17:35, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > First off, some cpufreq drivers (eg. intel_pstate) can pass hints &g

[RFT][PATCH v1 0/3] ACPI: scan: Defer enumeration of devices with significant dependencies

2020-12-14 Thread Rafael J. Wysocki
Hi, This series addresses some enumeration ordering issues by using information from _DEP to defer the enumeration of devices that are likely to depend on operation region (OpRegion) handlers supplied by the drivers of other devices. This allows the OpRegion suppliers to be probed and start

[RFT][PATCH v1 2/3] ACPI: scan: Defer enumeration of devices with _DEP lists

2020-12-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki In some cases ACPI control methods used during device enumeration (such as _HID or _STA) may rely on Operation Region handlers supplied by the drivers of other devices [1]: An example of this is the Acer Switch 10E SW3-016 model. The _HID method of the ACPI node

[RFT][PATCH v1 1/3] ACPI: scan: Evaluate _DEP before adding the device

2020-12-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Evaluate _DEP before calling acpi_add_single_object() from acpi_bus_check_add() and do that only for ACPI_BUS_TYPE_DEVICE objects. While at it, rename acpi_device_dep_initialize() to acpi_scan_check_dep(), fix up a memory allocation statement in that function

[RFT][PATCH v1 3/3] ACPI: scan: Avoid unnecessary second pass in acpi_bus_scan()

2020-12-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki If there are no devices whose enumeration has been deferred after the first pass in acpi_bus_scan(), the second pass is not necssary, so avoid it with the help of a new static variable. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/scan.c | 11 ++- 1 file

[PATCH v2 0/3] cpufreq: Allow drivers to receive more information from the governor

2020-12-14 Thread Rafael J. Wysocki
Hi, The timing of this is not perfect (sorry about that), but here's a refresh of this series. The majority of the previous cover letter still applies: On Monday, December 7, 2020 5:25:38 PM CET Rafael J. Wysocki wrote: > > This is based on the RFC posted a few days ago: >

[PATCH v2 3/3] cpufreq: intel_pstate: Implement the ->adjust_perf() callback

2020-12-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make intel_pstate expose the ->adjust_perf() callback when it operates in the passive mode with HWP enabled which causes the schedutil governor to use that callback instead of ->fast_switch(). The minimum and target performance-level values passed by the go

[PATCH v2 1/3] cpufreq: schedutil: Add util to struct sg_cpu

2020-12-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Instead of passing util and max between functions while computing the utilization and capacity, store the former in struct sg_cpu (along with the latter and bw_dl). This will allow the current utilization value to be compared with the one obtained previously (which

[PATCH v2 2/3] cpufreq: Add special-purpose fast-switching callback for drivers

2020-12-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki First off, some cpufreq drivers (eg. intel_pstate) can pass hints beyond the current target frequency to the hardware and there are no provisions for doing that in the cpufreq framework. In particular, today the driver has to assume that it should not allow the frequency

Re: [PATCH] ACPI: Use fwnode_init() to set up fwnode

2020-12-11 Thread Rafael J. Wysocki
3c.ca...@redhat.com/ > Fixes: 01bb86b380a3 ("driver core: Add fwnode_init()") > Reported-by: Qian Cai > Suggested-by: Robin Murphy > Tested-by: Marc Zyngier > Signed-off-by: Saravana Kannan Acked-by: Rafael J. Wysocki > --- > Greg, > > Can you

[PATCH] PCI: ACPI: Fix up ACPI companion lookup for device 0 on the root bus

2020-12-11 Thread Rafael J. Wysocki
From: Rafael J. Wysocki In some cases acpi_pci_find_companion() returns an incorrect device object as the ACPI companion for device 0 on the root bus (bus 0). On the affected systems that device is the PCI interface to the host bridge and the "ACPI companion" returned for it c

Re: [PATCH v5 0/4] powercap/dtpm: Add the DTPM framework

2020-12-11 Thread Rafael J. Wysocki
On Fri, Dec 11, 2020 at 11:41 AM Daniel Lezcano wrote: > > > Hi Rafael, > > I believe I took into account all the comments, do you think it is > possible to merge this series ? It should be, unless more changes are requested. I will be taking care of it next week and, if all goes well, it

Re: [GIT PULL] devfreq next for v5.11

2020-12-11 Thread Rafael J. Wysocki
On Fri, Dec 11, 2020 at 8:45 AM Chanwoo Choi wrote: > > Dear Rafael, > > This is devfreq-next pull request for v5.11-rc1. I add detailed description of > this pull request on the following tag. Please pull devfreq with following > updates. > - tag name : devfreq-next-for-5.11 > > Best Regards, >

Re: [PATCH 1/2] acpi: cppc: add cpufreq device

2020-12-10 Thread Rafael J. Wysocki
On Thu, Dec 10, 2020 at 6:23 PM Ionela Voinescu wrote: > > Hi Rafael, > > On Thursday 10 Dec 2020 at 17:55:56 (+0100), Rafael J. Wysocki wrote: > > On Thursday, December 10, 2020 4:04:40 PM CET Mian Yousaf Kaukab wrote: > > > On Thu, Dec 10, 2020 at 03:32:09PM +01

Re: [PATCH v4] PM: domains: create debugfs nodes when adding power domains

2020-12-10 Thread Rafael J. Wysocki
On Thu, Dec 10, 2020 at 8:18 AM Ulf Hansson wrote: > > On Tue, 8 Dec 2020 at 20:20, Thierry Strudel wrote: > > > > debugfs nodes were created in genpd_debug_init alled in late_initcall > > preventing power domains registered though loadable modules to have > > a debugfs entry. > > > >

Re: [PATCH 1/2] acpi: cppc: add cpufreq device

2020-12-10 Thread Rafael J. Wysocki
On Thu, Dec 10, 2020 at 3:23 PM Mian Yousaf Kaukab wrote: > > From: Mian Yousaf Kaukab > > Since commit 28f06f770454 ("cppc_cpufreq: replace per-cpu structures with > lists"), cppc-cpufreq driver doesn't check availability of PSD data before > registering with cpufreq core. As a result on a

Re: [PATCH 1/2] acpi: cppc: add cpufreq device

2020-12-10 Thread Rafael J. Wysocki
On Thursday, December 10, 2020 4:04:40 PM CET Mian Yousaf Kaukab wrote: > On Thu, Dec 10, 2020 at 03:32:09PM +0100, Rafael J. Wysocki wrote: > > On Thu, Dec 10, 2020 at 3:23 PM Mian Yousaf Kaukab > > wrote: > > > > > > Convert cppc-cpufreq driver to a pl

Re: [PATCH v1 1/4] cpufreq: schedutil: Add util to struct sg_cpu

2020-12-09 Thread Rafael J. Wysocki
On Tue, Dec 8, 2020 at 9:34 AM Viresh Kumar wrote: > > On 07-12-20, 17:28, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Instead of passing util and max between functions while computing the > > utilization and capacity, store the former in struct sg_

Re: [PATCH v4] PM: domains: create debugfs nodes when adding power domains

2020-12-09 Thread Rafael J. Wysocki
On Tue, Dec 8, 2020 at 9:39 PM Greg Kroah-Hartman wrote: > > On Tue, Dec 08, 2020 at 11:19:55AM -0800, Thierry Strudel wrote: > > debugfs nodes were created in genpd_debug_init alled in late_initcall > > preventing power domains registered though loadable modules to have > > a debugfs entry. > >

Re: [PATCH v1 2/4] cpufreq: schedutil: Adjust utilization instead of frequency

2020-12-09 Thread Rafael J. Wysocki
On Wed, Dec 9, 2020 at 6:16 AM Viresh Kumar wrote: > > On 08-12-20, 18:01, Rafael J. Wysocki wrote: > > On Tue, Dec 8, 2020 at 9:52 AM Viresh Kumar wrote: > > > > > > On 07-12-20, 17:29, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysock

Re: [PATCH] driver: core: Fix list corruption after device_del()

2020-12-08 Thread Rafael J. Wysocki
: https://bugzilla.kernel.org/show_bug.cgi?id=209207 > Signed-off-by: Takashi Iwai Reviewed-by: Rafael J. Wysocki > --- > drivers/base/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index d661ada

Re: [RESEND PATCH V3] PM / EM: Micro optimization in em_cpu_energy

2020-12-08 Thread Rafael J. Wysocki
On Sat, Nov 28, 2020 at 3:21 AM Pavankumar Kondeti wrote: > > When the sum of the utilization of CPUs in a power domain is zero, > return the energy as 0 without doing any computations. > > Acked-by: Quentin Perret > Reviewed-by: Dietmar Eggemann > Signed-off-by: Pavankumar Kondeti > --- >

Re: [PATCH v1 0/4] cpufreq: Allow drivers to receive more information from the governor

2020-12-08 Thread Rafael J. Wysocki
On Tue, Dec 8, 2020 at 5:31 PM Giovanni Gherdovich wrote: > > On Mon, 2020-12-07 at 17:25 +0100, Rafael J. Wysocki wrote: > > Hi, > > > > This is based on the RFC posted a few days ago: > > > > https://lore.kernel.org/linux-pm/1817571.2o5Kk4Ohv2@kreacher/

Re: [PATCH v1 4/4] cpufreq: intel_pstate: Implement the ->adjust_perf() callback

2020-12-08 Thread Rafael J. Wysocki
On Tue, Dec 8, 2020 at 1:44 PM Peter Zijlstra wrote: > > On Mon, Dec 07, 2020 at 05:38:58PM +0100, Rafael J. Wysocki wrote: > > > +static void intel_cpufreq_adjust_perf(unsigned int cpunum, > > + u

Re: [PATCH v1 2/4] cpufreq: schedutil: Adjust utilization instead of frequency

2020-12-08 Thread Rafael J. Wysocki
On Tue, Dec 8, 2020 at 9:52 AM Viresh Kumar wrote: > > On 07-12-20, 17:29, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > When avoiding reduction of the frequency after the target CPU has > > been busy since the previous frequency update, adju

[PATCH] ACPI: scan: Fix up _DEP-related terminology with supplier/consumer

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The ACPI namespace scanning code uses the terms master/slave when populating the list of _DEP dependencies, but that use has no external exposures and is not mandated by nor associated with any external specifications. Change the language used through-out to supplier

[PATCH] ACPI: scan: Drop INT3396 from acpi_ignore_dep_ids[]

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki According to Hans, all device objects where the _HID returns "INT3396" also have a _CID returning "PNP0D80", so the former need not be present in acpi_ignore_dep_ids[] any more. Link: https://lore.kernel.org/linux-acpi/52a2b98c-6bf3-760b-eca9-93c

[PATCH v1 2/4] cpufreq: schedutil: Adjust utilization instead of frequency

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki When avoiding reduction of the frequency after the target CPU has been busy since the previous frequency update, adjust the utilization instead of adjusting the frequency, because doing so is more prudent (it is done to counter a possible utilization deficit after all

[PATCH v1 0/4] cpufreq: Allow drivers to receive more information from the governor

2020-12-07 Thread Rafael J. Wysocki
Hi, This is based on the RFC posted a few days ago: https://lore.kernel.org/linux-pm/1817571.2o5Kk4Ohv2@kreacher/ The majority of the original cover letter still applies, so let me quote it here: Using intel_pstate in the passive mode with HWP enabled, in particular under the schedutil

[PATCH v1 1/4] cpufreq: schedutil: Add util to struct sg_cpu

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Instead of passing util and max between functions while computing the utilization and capacity, store the former in struct sg_cpu (along with the latter and bw_dl). This will allow the current utilization value to be compared with the one obtained previously (which

[PATCH v1 4/4] cpufreq: intel_pstate: Implement the ->adjust_perf() callback

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make intel_pstate expose the ->adjust_perf() callback when it operates in the passive mode with HWP enabled which causes the schedutil governor to use that callback instead of ->fast_switch(). The minimum and target performance-level values passed by the go

[PATCH v1 3/4] cpufreq: Add special-purpose fast-switching callback for drivers

2020-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki First off, some cpufreq drivers (eg. intel_pstate) can pass hints beyond the current target frequency to the hardware and there are no provisions for doing that in the cpufreq framework. In particular, today the driver has to assume that it should not allow the frequency

Re: [RFC PATCH 0/4] Add processor to the ignore PSD override list

2020-12-07 Thread Rafael J. Wysocki
On Fri, Dec 4, 2020 at 11:45 PM Punit Agrawal wrote: > > Hi Rafael, > > Punit Agrawal writes: > > > Hi, > > > > While looking into Giovanni's patches to enable frequency invariance > > on AMD systems[0], I noticed an issue with initialising frequency > > domain information on a recent AMD APU. >

Re: [RFC][PATCH 1/2] cpufreq: Add special-purpose fast-switching callback for drivers

2020-12-07 Thread Rafael J. Wysocki
On Mon, Dec 7, 2020 at 8:47 AM Viresh Kumar wrote: > > On 30-11-20, 19:37, Rafael J. Wysocki wrote: > > Index: linux-pm/include/linux/cpufreq.h > > === > > --- linux-pm.orig/include/linux/cpufreq.h > &

Re: [PATCH] ACPI: fan: fix warning with CONFIG_DEBUG_LOCK_ALLOC

2020-12-07 Thread Rafael J. Wysocki
/sysfs.h > > Fixes: d19e470b6605c ('ACPI: fan: Expose fan performance state information') > Cc: Srinivas Pandruvada > Cc: Rafael J. Wysocki > Signed-off-by: Pierre-Louis Bossart > --- > drivers/acpi/fan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --

Re: [PATCH] ACPI: Add DMI quirk for GIGABYTE GB-BXBT-2807

2020-12-07 Thread Rafael J. Wysocki
On Wed, Dec 2, 2020 at 7:41 AM Chris Chiu wrote: > > From: "Jasper St. Pierre" > > The GIGABYTE GB-BXBT-2807 is a mini-PC which uses off the shelf > components, like an Intel GPU which is meant for mobile systems. > As such, it, by default, has a backlight controller exposed. > > Unfortunately,

Re: [PATCH v2] Revert "ACPI / resources: Use AE_CTRL_TERMINATE to terminate resources walks"

2020-12-07 Thread Rafael J. Wysocki
On Sat, Dec 5, 2020 at 7:42 PM Daniel Scally wrote: > > This reverts commit 8a66790b7850a6669129af078768a1d42076a0ef. > > Switching this function to AE_CTRL_TERMINATE broke the documented > behaviour of acpi_dev_get_resources() - AE_CTRL_TERMINATE does not, in > fact, terminate the resource walk

Re: [PATCH] ACPI: scan: Add PNP0D80 to the _DEP exceptions list

2020-12-07 Thread Rafael J. Wysocki
On Sat, Dec 5, 2020 at 7:41 PM Hans de Goede wrote: > > Hi, > > On 12/5/20 4:29 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The PNP0D80 ("Windows-compatible System Power Management Controller") > > device ID is used for i

[PATCH] ACPI: scan: Add PNP0D80 to the _DEP exceptions list

2020-12-05 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The PNP0D80 ("Windows-compatible System Power Management Controller") device ID is used for identifying the special device object providing the LPI (Low-power S0 Idle) _DSM interface [1]. That device object does not supply any operation regions, but it appea

Re: [PATCH] acpi: resource: Use AE_ABORT_METHOD to terminate acpi_dev_get_resources()

2020-12-05 Thread Rafael J. Wysocki
On Friday, December 4, 2020 1:27:40 AM CET Daniel Scally wrote: > Switching this function to AE_CTRL_TERMINATE broke the documented > behaviour of acpi_dev_get_resources() - AE_CTRL_TERMINATE does not, in > fact, terminate the resource walk because acpi_walk_resource_buffer() > ignores it

Re: [PATCH] drivers: acpi: add opt-out of Apple-specific property parsing

2020-12-03 Thread Rafael J. Wysocki
On Thu, Dec 3, 2020 at 6:47 PM Enrico Weigelt, metux IT consult wrote: > > Most x86 machines aren't Apple machines, especially VMs. > Therefore allow opt-out, making the kernel a few KBs smaller, > eg. for embedded or high-density VMs. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- >

Re: [PATCH] driver core: Reorder devices on successful probe

2020-12-03 Thread Rafael J. Wysocki
erhead-related concerns. There still are some, but maybe that doesn't matter in practice. Also, I kind of expect this to blow up somewhere, but since I have no examples ready from the top of my head, I think let's try and see, so: Acked-by: Rafael. J. Wysocki > --- > drivers/base/dd.c |

Re: [RFC][PATCH 1/2] cpufreq: Add special-purpose fast-switching callback for drivers

2020-12-03 Thread Rafael J. Wysocki
On Thu, Dec 3, 2020 at 1:42 PM Peter Zijlstra wrote: > > On Mon, Nov 30, 2020 at 07:37:01PM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > First off, some cpufreq drivers (eg. intel_pstate) can pass hints > > beyond the current ta

Re: power-off delay/hang due to commit 6d25be57 (mainline)

2020-12-02 Thread Rafael J. Wysocki
On Wed, Dec 2, 2020 at 7:31 PM Rafael J. Wysocki wrote: > > On Wed, Dec 2, 2020 at 7:03 PM Sebastian Andrzej Siewior > wrote: > > > > On 2020-10-26 18:20:59 [+0100], To Rafael J. Wysocki wrote: > > > > > > > Done as Bug 208877. > > > > >

Re: power-off delay/hang due to commit 6d25be57 (mainline)

2020-12-02 Thread Rafael J. Wysocki
On Wed, Dec 2, 2020 at 7:03 PM Sebastian Andrzej Siewior wrote: > > On 2020-10-26 18:20:59 [+0100], To Rafael J. Wysocki wrote: > > > > > > Done as Bug 208877. > > > > Rafael, do you have any suggestions? > > > > > > I've lost track of

Re: [RFC][PATCH 1/2] cpufreq: Add special-purpose fast-switching callback for drivers

2020-12-02 Thread Rafael J. Wysocki
On Wed, Dec 2, 2020 at 4:59 PM Doug Smythies wrote: > > Hi Rafael, > > On 2020.11.30 10:37 Rafael J. Wysocki wrote: > > > First off, some cpufreq drivers (eg. intel_pstate) can pass hints > > beyond the current target frequency to the hardware and there are

Re: [RFC] ACPI PM during kernel poweroff/reboot

2020-12-02 Thread Rafael J. Wysocki
On Tue, Dec 1, 2020 at 10:38 PM Furquan Shaikh wrote: > > On Wed, Nov 25, 2020 at 10:29 AM Furquan Shaikh wrote: > > > > On Wed, Nov 25, 2020 at 9:51 AM Rafael J. Wysocki wrote: > > > > > > On Wed, Nov 25, 2020 at 6:43 PM Furquan Shaikh wrote: > > &

Re: [PATCH v4 2/5] resource: Add irqresource_disabled()

2020-12-01 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 6:41 PM John Garry wrote: > > Add a common function to set the fields for a irq resource to disabled, > which mimics what is done in acpi_dev_irqresource_disabled(), with a view > to replace that function. > > Signed-off-by: John Garry Reviewed-by:

Re: [PATCH v4 3/5] ACPI: Drop acpi_dev_irqresource_disabled()

2020-12-01 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 6:41 PM John Garry wrote: > > The functionality of acpi_dev_irqresource_disabled() is same as in common > irqresource_disabled(), so drop acpi_dev_irqresource_disabled() in favour > of that function. > > Signed-off-by: John Garry Acked-by:

Re: [GIT PULL] cpupower update for Linux 5.11-rc1

2020-12-01 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 10:47 PM Shuah Khan wrote: > > Hi Rafael, > > Please pull the following cpupower update for Linux 5.11-rc1. > > This cpupower update for Linux 5.11-rc1 consists of a change to provide > online and offline CPU information. This change makes it easier to keep > track of

Re: [PATCH] cpuidle: Select polling interval based on a c-state with a longer target residency

2020-12-01 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 11:32 PM Mel Gorman wrote: > > On Mon, Nov 30, 2020 at 08:06:44PM +0100, Rafael J. Wysocki wrote: > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt > > > b/Documentation/admin-guide/kernel-parameters.txt > > > index

<    1   2   3   4   5   6   7   8   9   10   >