Re: [PATCH V2 3/4] cpufreq: stats: Enable stats for fast-switch as well

2020-09-23 Thread Rafael J. Wysocki
On Wed, Sep 23, 2020 at 5:14 PM Rafael J. Wysocki wrote: > > On Wed, Sep 16, 2020 at 8:46 AM Viresh Kumar wrote: > > > > Now that all the blockers are gone for enabling stats in fast-switching > > case, enable it. > > > > Signed-off-by: Viresh Kumar &g

Re: [PATCH V2 3/4] cpufreq: stats: Enable stats for fast-switch as well

2020-09-23 Thread Rafael J. Wysocki
On Wed, Sep 16, 2020 at 8:46 AM Viresh Kumar wrote: > > Now that all the blockers are gone for enabling stats in fast-switching > case, enable it. > > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/cpufreq.c | 6 +- > drivers/cpufreq/cpufreq_stats.c | 6 -- > 2 files changed,

Re: [PATCH V2 1/4] cpufreq: stats: Defer stats update to cpufreq_stats_record_transition()

2020-09-23 Thread Rafael J. Wysocki
On Wed, Sep 16, 2020 at 8:45 AM Viresh Kumar wrote: > > In order to prepare for lock-less stats update, add support to defer any > updates to it until cpufreq_stats_record_transition() is called. This is a bit devoid of details. I guess you mean reset in particular, but that's not clear from the

Re: [RFC][PATCH 1/4] acpi: Use CPUIDLE_FLAG_TIMER_STOP

2020-09-22 Thread Rafael J. Wysocki
r > > rcu_idle_enter(). > > > > Signed-off-by: Peter Zijlstra (Intel) > > Acked-by: Rafael J. Wysocki > > Reported-by: Borislav Petkov > > Tested-by: Borislav Petkov > > --- > > drivers/acpi/processor_idle.c | 49 > > +---

Re: [PATCH] MAINTAINERS: drop myself from PM AVS drivers

2020-09-22 Thread Rafael J. Wysocki
On Fri, Sep 18, 2020 at 10:16 PM Kevin Hilman wrote: > > I haven't had the time or the expertise to adequately review and > maintain these drivers for awhile, so make it official. Well, fair enough, so applied as 5.10 material. But this means that I'm going to stop picking up AVS drivers changes

Re: [PATCH -next] power: avs: qcom-cpr: simplify the return expression of cpr_disable()

2020-09-22 Thread Rafael J. Wysocki
On Fri, Sep 18, 2020 at 10:12 PM Kevin Hilman wrote: > > Bjorn Andersson writes: > > > On Mon 14 Sep 22:26 CDT 2020, Liu Shixin wrote: > > > >> Simplify the return expression. > >> > >> Signed-off-by: Liu Shixin > > > > Reviewed-by: Bjorn Andersson > > Acked-by: Kevin Hilman > > Rafael, please

Re: [PATCH] powercap: Add AMD Fam19h RAPL support

2020-09-22 Thread Rafael J. Wysocki
On Tue, Aug 18, 2020 at 12:41 AM Kim Phillips wrote: > > AMD Family 19h's RAPL MSRs are identical to Family 17h's. Extend > Family 17h's support to Family 19h. > > Signed-off-by: Kim Phillips > Cc: "Rafael J. Wysocki" > Cc: Victor Ding >

Re: [PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-09-22 Thread Rafael J. Wysocki
On Tue, Sep 22, 2020 at 6:51 AM Sibi Sankar wrote: > > On 2020-09-22 01:26, Stephen Boyd wrote: > > Quoting Rafael J. Wysocki (2020-09-21 09:18:17) > >> On Fri, Aug 21, 2020 at 10:49 PM Sibi Sankar > >> wrote: > >> > > >> > Add GENPD_FLAG

Re: [PATCH][v2] ACPI: processor: Print more information when acpi_processor_evaluate_cst() failed

2020-09-21 Thread Rafael J. Wysocki
On Wed, Aug 19, 2020 at 5:22 AM Chen Yu wrote: > > Some platforms have bogus _CST which might cause expectd behavior > in the cpu idle driver. Some bogus _CST might be unable to be > disassembled by acpica-tools due to broken format. > Print extra log if the _CST extraction/verification failed. >

Re: [PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-09-21 Thread Rafael J. Wysocki
On Fri, Aug 21, 2020 at 10:49 PM Sibi Sankar wrote: > > Add GENPD_FLAG_NO_SUSPEND/RESUME flags to instruct genpd to keep the > status of the PM domain unaltered during suspend/resume respectively. > The flags are aimed at power domains coupled to co-processors which > enter low-power modes indepen

Re: [PATCH 3/3] PM / Domains: Add support for PM domain on/off notifiers for genpd

2020-09-21 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 8:38 AM Ulf Hansson wrote: > > On Tue, 25 Aug 2020 at 18:16, Lina Iyer wrote: > > > > On Wed, Aug 19 2020 at 04:41 -0600, Ulf Hansson wrote: > > >A device may have specific HW constraints that must be obeyed to, before > > >its corresponding PM domain (genpd) can be powere

Re: [PATCH 0/3] powercap: Enable RAPL for AMD Fam17h

2020-09-21 Thread Rafael J. Wysocki
On Wed, Jul 29, 2020 at 12:52 PM Victor Ding wrote: > > This patch series adds support for AMD Fam17h RAPL counters. As per > AMD PPR, Fam17h support RAPL counters to monitor power usage. The RAPL > counter operates as with Intel RAPL. Therefore, it is beneficial to > re-use existing framework for

Re: [RFC PATCH 2/2] PM: hibernate: introduce opportunistic memory reclaim

2020-09-21 Thread Rafael J. Wysocki
Hi Andrea, On Tue, Jun 9, 2020 at 8:19 AM Andrea Righi wrote: > > On Mon, Jun 08, 2020 at 03:23:22PM -0700, Luigi Semenzato wrote: > > Hi Andrea, > > > > 1. This mechanism is quite general. It is possible that, although > > hibernation may be an important use, there will be other uses for it. >

Re: [PATCH] pm: runtime: fix timer_expires on 32bits arch

2020-09-21 Thread Rafael J. Wysocki
On Mon, Sep 21, 2020 at 8:51 AM Vincent Guittot wrote: > > On Fri, 18 Sep 2020 at 18:55, Grygorii Strashko > wrote: > > > > The commit 8234f6734c5d ("PM-runtime: Switch autosuspend over to using > > hrtimers") switched PM runtime autosuspend to use hrtimers and all related > > time accounting in

Re: [PATCH v2] powercap: include header to fix -Wmissing-prototypes

2020-09-21 Thread Rafael J. Wysocki
On Mon, Sep 21, 2020 at 9:04 AM Herrington wrote: > > Include the linux/idle_inject.h header to fix W=1 build warning: > > drivers/powercap/idle_inject.c:152:6: warning: no previous prototype for > ‘idle_inject_set_duration’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:167:6: w

Re: [PATCH] rcu/tree: Export rcu_idle_{enter,exit} to module

2020-09-21 Thread Rafael J. Wysocki
On Mon, Sep 21, 2020 at 3:32 PM Paul E. McKenney wrote: > > On Mon, Sep 21, 2020 at 12:37:41PM +0200, Borislav Petkov wrote: > > Lemme add whatever get_maintainer spits, to Cc. > > > > On Mon, Sep 21, 2020 at 11:12:33AM +0200, Sven Joachim wrote: > > > On 2020-09-15 12:32 +0200, Peter Zijlstra wro

Re: [PATCH] rcu/tree: Export rcu_idle_{enter,exit} to module

2020-09-21 Thread Rafael J. Wysocki
On Mon, Sep 21, 2020 at 12:37 PM Borislav Petkov wrote: > > Lemme add whatever get_maintainer spits, to Cc. > > On Mon, Sep 21, 2020 at 11:12:33AM +0200, Sven Joachim wrote: > > On 2020-09-15 12:32 +0200, Peter Zijlstra wrote: > > > > > The C3 BusMaster idle code takes lock in a number of places,

Re: [PATCH v5 0/5] cpufreq: improve frequency invariance support

2020-09-18 Thread Rafael J. Wysocki
On Fri, Sep 4, 2020 at 6:39 AM Viresh Kumar wrote: > > On 03-09-20, 14:32, Ionela Voinescu wrote: > > Hi Rafael, Viresh, > > > > Would it be okay for you to apply this series, as the majority of > > changes are in cpufreq? For arch_topology and arm64 changes, they have > > been reviewed and acked-

Re: [PATCH 13/14] PM: mm: cleanup swsusp_swap_check

2020-09-18 Thread Rafael J. Wysocki
On Thu, Sep 17, 2020 at 7:39 PM Christoph Hellwig wrote: > > Use blkdev_get_by_dev instead of bdget + blkdev_get. > > Signed-off-by: Christoph Hellwig Acked-by: Rafael J. Wysocki > --- > kernel/power/swap.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletion

[GIT PULL] Power management updates for v5.9-rc6

2020-09-18 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-5.9-rc6 with top-most commit e8dc676e2a35e753fc46664968963f22e6e8af4a Merge branch 'pm-cpuidle' on top of commit 856deb866d16e29bd65952e0289066f6078af773 Linux 5.9-rc5 to receive pow

Re: [PATCH 11/14] PM: rewrite is_hibernate_resume_dev to not require an inode

2020-09-17 Thread Rafael J. Wysocki
On Thu, Sep 17, 2020 at 7:24 PM Christoph Hellwig wrote: > > Just check the dev_t to help simplifying the code. > > Signed-off-by: Christoph Hellwig Acked-by: Rafael J. Wysocki > --- > fs/block_dev.c | 2 +- > include/linux/suspend.h | 4 ++-- > kern

Re: [RFC][PATCH 1/4] acpi: Use CPUIDLE_FLAG_TIMER_STOP

2020-09-16 Thread Rafael J. Wysocki
On Wed, Sep 16, 2020 at 5:42 PM wrote: > > On Tue, Sep 15, 2020 at 06:26:52PM +0200, Rafael J. Wysocki wrote: > > On Tue, Sep 15, 2020 at 12:44 PM Peter Zijlstra > > wrote: > > > > > > Make acpi_processor_idle use the common broadcast code, there's no &g

Re: [PATCH] powercap/rapl: Add support for Lakefield

2020-09-16 Thread Rafael J. Wysocki
On Fri, Aug 21, 2020 at 8:46 PM Ricardo Neri wrote: > > Simply add Lakefield model ID. No additional changes are needed. > > Cc: Zhang Rui > Cc: "Rafael J. Wysocki" > Cc: "Ravi V. Shankar" > Signed-off-by: Ricardo Neri Applied as 5.9-rc material (

Re: [RFC][PATCH 1/4] acpi: Use CPUIDLE_FLAG_TIMER_STOP

2020-09-16 Thread Rafael J. Wysocki
On Wed, Sep 16, 2020 at 6:01 PM Borislav Petkov wrote: > > On Wed, Sep 16, 2020 at 05:42:12PM +0200, pet...@infradead.org wrote: > > On Tue, Sep 15, 2020 at 06:26:52PM +0200, Rafael J. Wysocki wrote: > > > On Tue, Sep 15, 2020 at 12:44 PM Peter Zijlstra > > &g

Re: [PATCH v15 0/2] ACPI / APEI: Add support to notify the vendor specific HW errors

2020-09-15 Thread Rafael J. Wysocki
On Tue, Sep 15, 2020 at 8:17 PM Bjorn Helgaas wrote: > > On Tue, Sep 15, 2020 at 07:31:50PM +0200, Rafael J. Wysocki wrote: > > On Mon, Sep 14, 2020 at 2:34 PM Shiju Jose wrote: > > > > > > Hello, > > > > > > Can you help to merge this series? >

Re: [PATCH v15 0/2] ACPI / APEI: Add support to notify the vendor specific HW errors

2020-09-15 Thread Rafael J. Wysocki
On Mon, Sep 14, 2020 at 2:34 PM Shiju Jose wrote: > > Hello, > > Can you help to merge this series? Do you want this series to go in through the ACPI tree? > >-Original Message- > >From: Linuxarm [mailto:linuxarm-boun...@huawei.com] On Behalf Of Shiju > >Jose > >Sent: 03 September 2020 1

Re: [PATCH] acpi/nfit: Use kobj_to_dev() instead

2020-09-15 Thread Rafael J. Wysocki
On Sat, Aug 15, 2020 at 12:52 AM Verma, Vishal L wrote: > > On Fri, 2020-08-14 at 17:28 +0200, Rafael J. Wysocki wrote: > > On Thu, Aug 13, 2020 at 4:54 AM Wang Qing wrote: > > > Use kobj_to_dev() instead of container_of() > > > > > > Signed-off-by: W

Re: [RFC][PATCH 1/4] acpi: Use CPUIDLE_FLAG_TIMER_STOP

2020-09-15 Thread Rafael J. Wysocki
d to me, so please feel free to add Acked-by: Rafael J. Wysocki to all of the four patches. Alternatively, please let me know if you want me to take the patches. > --- > drivers/acpi/processor_idle.c | 49 > +- > 1 file changed, 16 inser

[GIT PULL] Power management updates for v5.9-rc5

2020-09-11 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-5.9-rc5 with top-most commit d64e6906d188f0ba6a4f82b3f42e0bd0598183fa Merge branch 'powercap' on top of commit f4d51dffc6c01a9e94650d95ce0104964f8ae822 Linux 5.9-rc4 to receive power

Re: [PATCH 1/4] cpufreq: stats: Defer stats update to cpufreq_stats_record_transition()

2020-09-11 Thread Rafael J. Wysocki
On Fri, Sep 11, 2020 at 1:36 PM Viresh Kumar wrote: > > On 11-09-20, 12:11, pet...@infradead.org wrote: > > On Wed, Sep 02, 2020 at 12:54:41PM +0530, Viresh Kumar wrote: > > > + atomic_t reset_pending; > > > > > + atomic_set(&stats->reset_pending, 0); > > > + if (atomic_read(&stats->reset_pe

Re: [PATCH] PM: s2idle: Introduce syscore callbacks in s2idle flow

2020-09-10 Thread Rafael J. Wysocki
On Thursday, September 3, 2020 4:14:07 AM CEST Claude. Yen wrote: > On Tue, 2020-09-01 at 13:57 +0200, Rafael J. Wysocki wrote: > > On Tue, Sep 1, 2020 at 9:05 AM Claude Yen wrote: > > > > > > This series based on 5.9-rc1 > > > This patch makes s2idle call e

Re: [PATCH] powercap: make documentation reflect code

2020-09-10 Thread Rafael J. Wysocki
On Thu, Sep 10, 2020 at 12:28 PM Amit Kucheria wrote: > > Fix up documentation of the struct members to reflect reality. Also > fixup a stray whitespace. > > Signed-off-by: Amit Kucheria > --- > include/linux/powercap.h | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff

Re: [PATCH] PM: : fix @em_pd kernel-doc warning

2020-09-10 Thread Rafael J. Wysocki
;PM / EM: add support for other devices than CPUs in > Energy Model") > Signed-off-by: Randy Dunlap > Cc: Lukasz Luba > Cc: Rafael J. Wysocki > --- > include/linux/device.h |1 + > 1 file changed, 1 insertion(+) > > --- lnx-59-rc4.orig/include/linux/device.h

[PATCH 3/6] ACPICA: Introduce special struct type for GPE register addresses

2020-09-04 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Notice that the bit_width, bit_offset and access_width fields in struct acpi_generic_address are not used during GPE register accesses any more, so introduce a simplified address structure type, struct acpi_gpe_address, to represent addresses of GPE registers

[PATCH 2/6] ACPICA: Introduce acpi_hw_gpe_read() and acpi_hw_gpe_write()

2020-09-04 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Now that GPE blocks are validated at the initialization time, accesses to GPE registers can be made more straightforward by ommitting all of the redundant checks in acpi_hw_read() and acpi_hw_write() and only invoking the OS-provided helper for the given type

[PATCH 0/6] ACPICA / ACPI: OSL: Rework GPE registers access code

2020-09-04 Thread Rafael J. Wysocki
Hi All, The underlying issue here is that in Linux calling acpi_os_read_memory() or acpi_os_write_memory() from an interrupt handler is generally invalid, because these functions may attempt to map memory on the fly. It is only valid to call them from an interrupt handler if it is known that ther

[PATCH 1/6] ACPICA: Validate GPE blocks at init time

2020-09-04 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Some of the checks done by acpi_hw_read() and acpi_hw_write(), which are used for accessing GPE registers, are redundant in the specific case of GPE registers and the ones that are not redundant can be done upfront at the initialization time so as t

[PATCH 4/6] ACPICA: Add support for using logical addresses of GPE blocks

2020-09-04 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" The logical address of every GPE block in system memory must be known before passing it to acpi_ev_initialize_gpe_block(), because memory cannot be mapped on the fly from an interrupt handler. Accordingly, the host OS must map every GPE block in system memo

[PATCH 5/6] ACPI: OSL: Change the type of acpi_os_map_generic_address() return value

2020-09-04 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Modify acpi_os_map_generic_address() to return the pointer returned by acpi_os_map_iomem() which represents the logical address corresponding to the struct acpi_generic_address argument passed to it or NULL if that address cannot be obtained (for example, th

[PATCH 6/6] ACPI: OSL: Make ACPICA use logical addresses of GPE blocks

2020-09-04 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Define ACPI_GPE_USE_LOGICAL_ADDRESSES in aclinux.h and modify acpi_os_initialize() to store the logical addresses of the FADT GPE blocks 0 and 1 in acpi_gbl_xgpe0_block_logical_address and acpi_gbl_xgpe1_block_logical_address, respectively, so as to allow ACP

[GIT PULL] Power management fixes for v5.9-rc4

2020-09-04 Thread Rafael J. Wysocki
o disabled Rafael J. Wysocki (5): cpufreq: intel_pstate: Refuse to turn off with HWP enabled cpufreq: intel_pstate: Update cached EPP in the active mode cpufreq: intel_pstate: Tweak the EPP sysfs interface cpufreq: intel_pstate: Add ->offline and ->online callbac

Re: [PATCH v7 6/6] Documentation: ACPI: Document allow-low-power-probe _DSD property

2020-09-02 Thread Rafael J. Wysocki
On Wed, Sep 2, 2020 at 6:31 PM Sakari Ailus wrote: > > Hi Rafael, > > Thank you for the review. > > On Wed, Sep 02, 2020 at 05:57:01PM +0200, Rafael J. Wysocki wrote: > > On Tue, Sep 1, 2020 at 11:03 PM Sakari Ailus > > wrote: > > > > > > Document

Re: [PATCH v7 6/6] Documentation: ACPI: Document allow-low-power-probe _DSD property

2020-09-02 Thread Rafael J. Wysocki
On Tue, Sep 1, 2020 at 11:03 PM Sakari Ailus wrote: > > Document the probe-low-power _DSD property and how it is used with I²C > drivers. I would reorder the series to make this go right after the [1/6] or maybe even fold it into that patch. The point is that the changes in [1/6] clearly depend

[PATCH v4 0/5] cpufreq: intel_pstate: Address some HWP-related oddities

2020-09-01 Thread Rafael J. Wysocki
Hi All, The last two patches in the v3 needed to be updated to take re-enabling of HWP after an ACPI S3 suspend/resume cycle into account appropriately. The first three patches are the same as before. The purpose of this series is to address some peculiarities related to taking CPUs offline/onli

[PATCH v4 4/5] cpufreq: intel_pstate: Add ->offline and ->online callbacks

2020-09-01 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Add ->offline and ->online driver callbacks to prepare for taking a CPU offline and to restore its working configuration when it goes back online, respectively, to avoid invoking the ->init callback on every CPU online which is quite a bit of u

[PATCH v4 1/5] cpufreq: intel_pstate: Refuse to turn off with HWP enabled

2020-09-01 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" After commit f6ebbcf08f37 ("cpufreq: intel_pstate: Implement passive mode with HWP enabled") it is possible to change the driver status to "off" via sysfs with HWP enabled, which effectively causes the driver to unregister itself, but HW

[PATCH v4 2/5] cpufreq: intel_pstate: Update cached EPP in the active mode

2020-09-01 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Make intel_pstate update the cached EPP value when setting the EPP via sysfs in the active mode just like it is the case in the passive mode, for consistency, but also for the benefit of subsequent changes. No intentional functional impact. Signed-off-by

[PATCH v4 3/5] cpufreq: intel_pstate: Tweak the EPP sysfs interface

2020-09-01 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Modify the EPP sysfs interface to reject attempts to change the EPP to values different from 0 ("performance") in the active mode with the "performance" policy (ie. scaling_governor set to "performance"), to avoid situations in

[PATCH v4 5/5] cpufreq: intel_pstate: Free memory only when turning off

2020-09-01 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" When intel_pstate switches the operation mode from "active" to "passive" or the other way around, freeing its data structures representing CPUs and allocating them again from scratch is not necessary and wasteful. Moreover, if these data

Re: [PATCH v1] driver core: Fix device_pm_lock() locking for device links

2020-09-01 Thread Rafael J. Wysocki
On Tue, Sep 1, 2020 at 12:10 AM Saravana Kannan wrote: > > This commit fixes two issues: > > 1. The lockdep warning reported by Dong Aisheng [1]. > > It is a warning about a cycle (dpm_list_mtx --> kn->active#3 --> fw_lock) > that was introduced when device-link devices were added to expose devic

Re: [PATCH] PM: s2idle: Introduce syscore callbacks in s2idle flow

2020-09-01 Thread Rafael J. Wysocki
On Tue, Sep 1, 2020 at 9:05 AM Claude Yen wrote: > > This series based on 5.9-rc1 > This patch makes s2idle call existing syscore callbacks. Currently, > when s2idle is selected as system suspend method, callbacks hooked > by register_syscore_ops() will not be triggered. This may induce > unexpect

Re: [PATCH v3 4/5] cpufreq: intel_pstate: Add ->offline and ->online callbacks

2020-08-31 Thread Rafael J. Wysocki
On Thu, Aug 27, 2020 at 5:28 PM Rafael J. Wysocki wrote: > > From: "Rafael J. Wysocki" > > Add ->offline and ->online driver callbacks to prepare for taking a > CPU offline and to restore its working configuration when it goes > back online, respectively, to avo

[GIT PULL] Device properties framework fix for v5.9-rc3

2020-08-28 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ devprop-5.9-rc3 with top-most commit c15e1bdda4365a5f17cdadf22bf1c1df13884a9e device property: Fix the secondary firmware node handling in set_primary_fwnode() on top of commit 9123e3a74ec

[GIT PULL] ACPI fixes for v5.9-rc3

2020-08-28 Thread Rafael J. Wysocki
ailures in the cases when the device property under inspection is missing (Furquan Shaikh). Thanks! --- Ard Biesheuvel (1): ACPI: ioremap: avoid redundant rounding to OS page size Furquan Shaikh (1): ACPI: SoC: APD: Check return value of acpi_dev_get_property()

[GIT PULL] Power management fixes for v5.9-rc3

2020-08-28 Thread Rafael J. Wysocki
ow (Rafael Wysocki). - Fix build warning in the intel_pstate driver documentation and improve the wording in there (Randy Dunlap). - Clean up two pieces of code in the cpufreq core (Viresh Kumar). Thanks! ------- Rafael J. Wysocki (1): PM: sleep: core: Fix the handling of pendi

Re: [PATCH v3 00/11] Fix PM hibernation in Xen guests

2020-08-28 Thread Rafael J. Wysocki
On Fri, Aug 28, 2020 at 8:26 PM Anchal Agarwal wrote: > > On Fri, Aug 21, 2020 at 10:22:43PM +, Anchal Agarwal wrote: > > Hello, > > This series fixes PM hibernation for hvm guests running on xen hypervisor. > > The running guest could now be hibernated and resumed successfully at a > > later

[PATCH v3 4/5] cpufreq: intel_pstate: Add ->offline and ->online callbacks

2020-08-27 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Add ->offline and ->online driver callbacks to prepare for taking a CPU offline and to restore its working configuration when it goes back online, respectively, to avoid invoking the ->init callback on every CPU online which is quite a bit of u

[PATCH v3 2/5] cpufreq: intel_pstate: Update cached EPP in the active mode

2020-08-27 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Make intel_pstate update the cached EPP value when setting the EPP via sysfs in the active mode just like it is the case in the passive mode, for consistency, but also for the benefit of subsequent changes. No intentional functional impact. Signed-off-by

[PATCH v3 5/5] cpufreq: intel_pstate: Free memory only when turning off

2020-08-27 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" When intel_pstate switches the operation mode from "active" to "passive" or the other way around, freeing its data structures representing CPUs and allocating them again from scratch is not necessary and wasteful. Moreover, if these data

[PATCH v3 1/5] cpufreq: intel_pstate: Refuse to turn off with HWP enabled

2020-08-27 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" After commit f6ebbcf08f37 ("cpufreq: intel_pstate: Implement passive mode with HWP enabled") it is possible to change the driver status to "off" via sysfs with HWP enabled, which effectively causes the driver to unregister itself, but HW

[PATCH v3 0/5] cpufreq: intel_pstate: Address some HWP-related oddities

2020-08-27 Thread Rafael J. Wysocki
Hi All, The v3 is here to address feedback from Srinivas and Doug, and Artem concerns regarding the EPP sysfs interface changes. The purpose of this series is to address some peculiarities related to taking CPUs offline/online and switching between different operation modes with HWP enabled that

[PATCH v3 3/5] cpufreq: intel_pstate: Tweak the EPP sysfs interface

2020-08-27 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Modify the EPP sysfs interface to reject attempts to change the EPP to values different from 0 ("performance") in the active mode with the "performance" policy (ie. scaling_governor set to "performance"), to avoid situations in

Re: [PATCH 1/2] cpufreq: No need to verify cpufreq_driver in show_scaling_cur_freq()

2020-08-27 Thread Rafael J. Wysocki
On Thu, Aug 27, 2020 at 7:24 AM Viresh Kumar wrote: > > "cpufreq_driver" is guaranteed to be valid here, no need to check it > here. > > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/cpufreq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/cpufre

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 6:46 PM Guilhem Lettron wrote: > > I've done more tests, maybe it can give you more hints. > I don't see that much differences between both (with and without > patches) in this cases. OK, thanks! I'm assuming that the topmost two sets of data are for the "without the patc

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 6:39 PM Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 18:02 +0200, Rafael J. Wysocki wrote: > > To that end, I would try to upgrade the graphics firmware and see if > > you can get some nonzero PC8 residency then. > > I am curious, somehow that

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 6:19 PM Artem Bityutskiy wrote: > > Indeed, when I compare them: > > acpi_idle (without the patch): Does this come from the Guilhem's data? It's intel_idle in both cases, but in the "without the patch" case it uses ACPI. > CPU%c1 CPU%c6 CPU%c7 CoreTmp PkgTmp GFX%rc6

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 6:02 PM Rafael J. Wysocki wrote: > > On Wed, Aug 26, 2020 at 4:04 PM Guilhem Lettron wrote: > > > > On Wed, 26 Aug 2020 at 15:41, Zhang Rui wrote: > > > > > > > > > This is really hard to read. > > > can you

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 4:04 PM Guilhem Lettron wrote: > > On Wed, 26 Aug 2020 at 15:41, Zhang Rui wrote: > > > > > > This is really hard to read. > > can you please attach the two turbostat output as attachments? > > of course :) Thanks! A couple of things happen here AFAICS. First, your proc

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 3:18 PM Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 16:16 +0300, Artem Bityutskiy wrote: > > Just get a reasonably new turbostat (it is part of the kernel tree, you > > can compile it yourself) and run it for few seconds (like 'turbostat > > sleep 10'), get the output

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 3:09 PM Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 15:03 +0200, Guilhem Lettron wrote: > > On Wed, 26 Aug 2020 at 14:43, Rafael J. Wysocki wrote: > > > On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron > > > wrote: > &

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 2:59 PM Guilhem Lettron wrote: > > On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only report > "C1_ACPI", "C2_ACPI" and "C3_ACPI". Can you list the properties of the idle states in this configuration, that is: $ grep -r '.*' /sys/devices/system/cpu/cpu0/cp

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Rafael J. Wysocki
On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron wrote: > > Use the same C-states as SKL Why is this change needed? > Signed-off-by: Guilhem Lettron > --- > drivers/idle/intel_idle.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c

Re: [PATCH v2 2/5] cpufreq: intel_pstate: Always return last EPP value from sysfs

2020-08-25 Thread Rafael J. Wysocki
On Tue, Aug 25, 2020 at 5:27 PM Srinivas Pandruvada wrote: > > On Tue, 2020-08-25 at 17:14 +0200, Rafael J. Wysocki wrote: > > On Tue, Aug 25, 2020 at 5:06 PM Srinivas Pandruvada > > wrote: > > > On Tue, 2020-08-25 at 16:51 +0200, Rafael J. Wysocki wrote: > > &g

Re: [PATCH v2 2/5] cpufreq: intel_pstate: Always return last EPP value from sysfs

2020-08-25 Thread Rafael J. Wysocki
On Tue, Aug 25, 2020 at 5:06 PM Srinivas Pandruvada wrote: > > On Tue, 2020-08-25 at 16:51 +0200, Rafael J. Wysocki wrote: > > On Tue, Aug 25, 2020 at 8:20 AM Artem Bityutskiy > > wrote: > > > On Mon, 2020-08-24 at 19:42 +0200, Rafael J. Wysocki wrote: >

Re: [PATCH v2 2/5] cpufreq: intel_pstate: Always return last EPP value from sysfs

2020-08-25 Thread Rafael J. Wysocki
On Tue, Aug 25, 2020 at 8:20 AM Artem Bityutskiy wrote: > > On Mon, 2020-08-24 at 19:42 +0200, Rafael J. Wysocki wrote: > > From: "Rafael J. Wysocki" > > > > Make the energy_performance_preference policy attribute in sysfs > > always return the last EP

[PATCH v2 5/5] cpufreq: intel_pstate: Restore cached EPP value during offline

2020-08-24 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Because hwp_req_cached contains the effective EPP value (0) when the "performance" scaling algorithm is used in the active mode, replace it with the cached EPP value during CPU offline to prevent it from being used (unexpectedly) after switching

[PATCH v2 0/5] cpufreq: intel_pstate: Address some HWP-related oddities

2020-08-24 Thread Rafael J. Wysocki
Hi All, The v2 is here to address feedback from Doug and one issue found by me. The purpose of this series is to address some peculiarities related to taking CPUs offline/online and switching between different operation modes with HWP enabled that have become visible after allowing the driver to

[PATCH v2 1/5] cpufreq: intel_pstate: Refuse to turn off with HWP enabled

2020-08-24 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" After commit f6ebbcf08f37 ("cpufreq: intel_pstate: Implement passive mode with HWP enabled") it is possible to change the driver status to "off" via sysfs with HWP enabled, which effectively causes the driver to unregister itself, but HW

[PATCH v2 4/5] cpufreq: intel_pstate: Free memory only when turning off

2020-08-24 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" When intel_pstate switches the operation mode from "active" to "passive" or the other way around, freeing its data structures representing CPUs and allocating them again from scratch is not necessary and wasteful. Moreover, if these data

[PATCH v2 2/5] cpufreq: intel_pstate: Always return last EPP value from sysfs

2020-08-24 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Make the energy_performance_preference policy attribute in sysfs always return the last EPP value written to it instead of the one currently in the HWP Request MSR to avoid possible confusion when the performance scaling algorithm is used in the active mod

[PATCH v2 3/5] cpufreq: intel_pstate: Add ->offline and ->online callbacks

2020-08-24 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Add ->offline and ->online driver callbacks to prepare for taking a CPU offline and to restore its working configuration when it goes back online, respectively, to avoid invoking the ->init callback on every CPU online which is quite a bit of u

[PATCH v2] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Rafael J. Wysocki
From: Rafael J. Wysocki It has been reported that system-wide suspend may be aborted in the absence of any wakeup events due to unforseen interactions of it with the runtume PM framework. One failing scenario is when there are multiple devices sharing an ACPI power resource and runtime-resume

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Rafael J. Wysocki
On Monday, August 24, 2020 5:04:21 PM CEST Alan Stern wrote: > On Mon, Aug 24, 2020 at 03:36:36PM +0200, Rafael J. Wysocki wrote: > > > Furthermore, by the logic used in this patch, the call to > > > pm_wakeup_event() in the original code is also redundant: Any required >

Re: [PATCH 0/4] cpufreq: intel_pstate: Address some HWP-related oddities

2020-08-24 Thread Rafael J. Wysocki
On Saturday, August 22, 2020 2:47:05 AM CEST Doug Smythies wrote: > Hi Rafael, > > On 2020.08.20 09:35 Rafael J. Wysocki wrote: > > > > The purpose of this series is to address some peculiarities related to > > taking CPUs offline/online and switching between differe

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Rafael J. Wysocki
On Friday, August 21, 2020 9:34:42 PM CEST Alan Stern wrote: > On Fri, Aug 21, 2020 at 07:41:02PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > It has been reported that system-wide suspend may be aborted in the > > absence of any wakeup events du

[PATCH v2 3/4] cpufreq: intel_pstate: Add ->offline and ->online callbacks

2020-08-24 Thread Rafael J. Wysocki
On Saturday, August 22, 2020 2:47:16 AM CEST Doug Smythies wrote: > Hi Rafael, > > Just annoying typo type feedback. Thanks! Please find a corrected patch below. Cheers! --- From: Rafael J. Wysocki Subject: [PATCH] cpufreq: intel_pstate: Add ->offline and ->online callbacks

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Rafael J. Wysocki
On Monday, August 24, 2020 10:34:52 AM CEST Mika Westerberg wrote: > Hi, > > On Fri, Aug 21, 2020 at 03:34:42PM -0400, Alan Stern wrote: > > This means that the code could be simplified to just: > > > > pm_runtime_barrier(dev); > > > > Will this fix the reported bug? It seems likely to me t

Re: [PATCH] Documentation: fix pm/intel_pstate build warning and wording

2020-08-24 Thread Rafael J. Wysocki
: intel_pstate: Allow raw energy performance > preference value") > Signed-off-by: Randy Dunlap > Cc: Srinivas Pandruvada > Cc: Rafael J. Wysocki > --- > Documentation/admin-guide/pm/intel_pstate.rst |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > -

Re: [PATCH] device property: Fix the secondary firmware node handling in set_primary_fwnode()

2020-08-21 Thread Rafael J. Wysocki
On Fri, Aug 21, 2020 at 12:53 PM Heikki Krogerus wrote: > > When the primary firmware node pointer is removed from a > device (set to NULL) the secondary firmware node pointer, > when it exists, is made the primary node for the device. > However, the secondary firmware node pointer of the original

Re: [PATCH] drivers: acpi: apd: Check return value of acpi_dev_get_property

2020-08-21 Thread Rafael J. Wysocki
On Wed, Aug 19, 2020 at 7:17 PM Furquan Shaikh wrote: > > `fch_misc_setup()` uses `acpi_dev_get_property()` to read the value of > "is-rv" passed in by BIOS in ACPI tables. However, not all BIOSes > might pass in this property and hence it is important to first check > the return value of `acpi_de

Re: [Patch] cpufreq: replace cpu_logical_map with read_cpuid_mpir

2020-08-21 Thread Rafael J. Wysocki
On Fri, Aug 21, 2020 at 7:22 AM Viresh Kumar wrote: > > On 20-08-20, 13:37, Sudeep Holla wrote: > > On Thu, Aug 20, 2020 at 11:09:45AM +0530, Viresh Kumar wrote: > > > On 12-08-20, 01:13, Sumit Gupta wrote: > > > > Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue") > > > > fixes

[GIT PULL] Power management fixes for v5.9-rc2

2020-08-21 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-5.9-rc2 with top-most commit cc15fd9892e28689b6e17dbd6e28d00c55d62928 Merge branch 'opp/fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm on top of commit 9123e3a74ec7b

[PATCH] ACPI: OSL: Prevent acpi_release_memory() from returning too early

2020-08-21 Thread Rafael J. Wysocki
From: Rafael J. Wysocki After commit 1757659d022b ("ACPI: OSL: Implement deferred unmapping of ACPI memory") in some cases acpi_release_memory() may return before the target memory mappings actually go away, because they are released asynchronously now. Prevent it from returning prem

[PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-21 Thread Rafael J. Wysocki
From: Rafael J. Wysocki It has been reported that system-wide suspend may be aborted in the absence of any wakeup events due to unforseen interactions of it with the runtume PM framework. One failing scenario is when there are multiple devices sharing an ACPI power resource and runtime-resume

Re: [PATCH v2 02/11] cpuidle: Fixup IRQ state

2020-08-21 Thread Rafael J. Wysocki
On Friday, August 21, 2020 10:47:40 AM CEST Peter Zijlstra wrote: > Match the pattern elsewhere in this file. > > Signed-off-by: Peter Zijlstra (Intel) > Reviewed-by: Steven Rostedt (VMware) > Tested-by: Marco Elver For all patches in the series: Acked-by: Ra

[PATCH 1/4] cpufreq: intel_pstate: Refuse to turn off with HWP enabled

2020-08-20 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" After commit f6ebbcf08f37 ("cpufreq: intel_pstate: Implement passive mode with HWP enabled") it is possible to change the driver status to "off" via sysfs with HWP enabled, which effectively causes the driver to unregister itself, but HW

[PATCH 0/4] cpufreq: intel_pstate: Address some HWP-related oddities

2020-08-20 Thread Rafael J. Wysocki
Hi All, The purpose of this series is to address some peculiarities related to taking CPUs offline/online and switching between different operation modes with HWP enabled that have become visible after allowing the driver to work in the passive mode with HWP enabled in 5.9-rc1 (and one that was th

[PATCH 2/4] cpufreq: intel_pstate: Always return last EPP value from sysfs

2020-08-20 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Make the energy_performance_preference policy attribute in sysfs always return the last EPP value written to it instead of the one currently in the HWP Request MSR to avoid possible confusion when the performance scaling algorithm is used in the active mod

[PATCH 4/4] cpufreq: intel_pstate: Free memory only when turning off

2020-08-20 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" When intel_pstate switches the operation mode from "active" to "passive" or the other way around, freeing its data structures representing CPUs and allocating them again from scratch is not necessary and wasteful. Moreover, if these data

[PATCH 3/4] cpufreq: intel_pstate: Add ->offline and ->online callbacks

2020-08-20 Thread Rafael J. Wysocki
From: "Rafael J. Wysocki" Add ->offline and ->online driver callbacksto to do the cleanup before taking a CPU offline and to restore its working configuration when it goes back online, respectively, to avoid invoking the ->init callback on every CPU online which is quite a

<    5   6   7   8   9   10   11   12   13   14   >