Re: [PATCH 2/8] um: Do not use SUBARCH

2013-09-26 Thread Ramkumar Ramachandra
Richard Weinberger wrote: >> Auto-detection of SUBARCH, which can be done with a simple call to >> uname -m (the 90% case). The second patch I submitted prevented >> spawning xterms unnecessarily, which we discussed was a good move. > > Covering only 90% of all cases is not enough. > We must not

Re: [PATCH 1/8] um: Create defconfigs for i386 and x86_64

2013-09-26 Thread Ramkumar Ramachandra
Richard Weinberger wrote: >> $ file linux >> linux: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), >> dynamically linked (uses shared libs), for GNU/Linux 2.6.32, not >> stripped >> $ ./linux ubd0=busybox-rootfs >> [...] >> Kernel panic - not syncing: No init found. Try passing init=

Re: [PATCH 2/8] um: Do not use SUBARCH

2013-09-26 Thread Ramkumar Ramachandra
Richard Weinberger wrote: > I told you already that "make defconfig ARCH=um SUBARCH=x86" will spuriously > create a x86_64 config on x86_64. > This breaks existing setups. I'll fix this and resubmit soon. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH 2/8] um: Do not use SUBARCH

2013-09-26 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: > Richard Weinberger wrote: >> I told you already that "make defconfig ARCH=um SUBARCH=x86" will spuriously >> create a x86_64 config on x86_64. >> This breaks existing setups. > > I'll fix this and resubmit soon. Wait a min

Re: [PATCH 2/8] um: Do not use SUBARCH

2013-09-26 Thread Ramkumar Ramachandra
Geert Uytterhoeven wrote: > Sorry for chiming in, but... what about cross compiling? > SUBARCH=x86 should give you a 32-bit ia32 kernel, right? User-Mode Linux only supports two host architectures (called $SUBARCH) at the moment: i386 and x86_64. If you leave out the $SUBARCH on either an i386 or

[PATCH] tools/perf: remove non-existent entries in MANIFEST

2013-09-26 Thread Ramkumar Ramachandra
(non-existent paths) by running: $ while read l; do file $l; done Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Paul Mackerras Cc: Ingo Molnar Signed-off-by: Ramkumar Ramachandra --- Thanks to David for pointing out that the MANIFEST is used by scripts/package. This patch safely

Re: [PATCH 2/8] um: Do not use SUBARCH

2013-09-26 Thread Ramkumar Ramachandra
Richard Weinberger wrote: >> Sorry for chiming in, but... what about cross compiling? >> SUBARCH=x86 should give you a 32-bit ia32 kernel, right? > > Correct. > Users expect from SUBARCH=x86 a i386 32bit UML kernel. This is an insane expectation. This is kernel convention (it has nothing to do

Re: [PATCH] tools/perf: remove non-existent entries in MANIFEST

2013-09-26 Thread Ramkumar Ramachandra
David Ahern wrote: > Did you create a tarfile after this change, unpack it somewhere out of three > and then verify perf builds? Yeah, it builds fine. In fact, the archive generated from the current upstream is broken. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 2/8] um: Do not use SUBARCH

2013-09-26 Thread Ramkumar Ramachandra
Richard Weinberger wrote: > And, of course, this makes your patch valid. > Can you also please ensure that your new defconfigs are minimal? Yeah, it's close to a minimal configuration for the 3.10 kernel (latest at the time of patch submission). I was aiming to minimize the diff between the

Re: [PATCH] tools/perf: remove non-existent entries in MANIFEST

2013-09-26 Thread Ramkumar Ramachandra
Arnaldo Carvalho de Melo wrote: > Could you please describe how it is broken? > > [acme@zoo linux]$ git branch | grep '*' > * perf/urgent > [acme@zoo linux]$ git describe > v3.12-rc1-51-gc1bf214 Oh, I meant the torvalds/linux.git master. $ git describe v3.12-rc2-83-g4b97280 $ make

[PATCH 0/2] More plesant User-Mode Linux build

2013-09-26 Thread Ramkumar Ramachandra
with an x86_64 userland, as well as the i386 kernel with an i386 userland. The second patch is just a related "while we're there". Thanks. Ramkumar Ramachandra (2): arch/um: make it work with defconfig and x86_64 um/vdso: add .gitignore for a couple of targets arch/um/Kcon

[PATCH 2/2] um/vdso: add .gitignore for a couple of targets

2013-09-26 Thread Ramkumar Ramachandra
Cc: Richard Weinberger Signed-off-by: Ramkumar Ramachandra --- arch/x86/um/vdso/.gitignore | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 arch/x86/um/vdso/.gitignore diff --git a/arch/x86/um/vdso/.gitignore b/arch/x86/um/vdso/.gitignore new file mode 100644 index 000..9cac6d0

[PATCH 1/2] arch/um: make it work with defconfig and x86_64

2013-09-26 Thread Ramkumar Ramachandra
and successfully build User-Mode Linux on an x86_64 box in default configuration. Cc: Richard Weinberger Cc: Jeff Dike Signed-off-by: Ramkumar Ramachandra --- arch/um/Kconfig.common | 5 - arch/um/Makefile | 11 + arch/um/configs/i386_defconfig | 76 arch/um

[QUERY] Building and testing Aarch64

2013-09-27 Thread Ramkumar Ramachandra
Hi, I'm interested in cross-compiling for ARM v8, and fixing some early papercuts to begin with; my host machine is a normal x86_64 box. Although I managed to use Linaro's toolchain [1] to build an Aarch64 kernel, and found a suitable rootfs [2] to use it with, I am not able to find an ARM64

Re: [QUERY] Building and testing Aarch64

2013-09-27 Thread Ramkumar Ramachandra
Hi Catalin, Catalin Marinas wrote: > ARM provides an emulator, ARMv8 Foundation Model (free as in free beer > but you need to register to be able to download, just like the > architecture documentation): > > http://www.arm.com/products/tools/models/fast-models/foundation-model.php I downloaded

Re: [QUERY] Building and testing Aarch64

2013-09-28 Thread Ramkumar Ramachandra
Catalin Marinas wrote: > git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/boot-wrapper-aarch64.git Thanks, I made some progress. Now I'm stuck trying to specify the rootfs. I boot with the following arguments (full fork of your repository here [1]): console=ttyAMA0 mem=2048M

Re: [QUERY] Building and testing Aarch64

2013-09-28 Thread Ramkumar Ramachandra
Andreas Schwab wrote: >> I'm not exactly sure what went wrong: I made sure to compile my kernel >> with virtio support. > > Make sure you have CONFIG_VIRTIO_MMIO enabled. Now, I get the following build error: LD init/built-in.o drivers/built-in.o: In function `vgacon_init':

Re: [QUERY] Building and testing Aarch64

2013-09-28 Thread Ramkumar Ramachandra
Andreas Schwab wrote: > Ramkumar Ramachandra writes: >> Is there a bug in the Kconfig dependency tree? Sounds like VIRTIO_MMIO >> requires some vga (?) drivers to be compiled in as well. I hit this bug when I do `make menuconfig` directly (which configuration does it start out

Re: [QUERY] Building and testing Aarch64

2013-09-28 Thread Ramkumar Ramachandra
Andreas Schwab wrote: > You need all the other relevant virtio options built-in, too, like > VIRTIO_BLK. Thanks! VIRTIO_BLK was the missing feature. I'll submit patches shortly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH 1/2] arm64: include EXT4 in defconfig

2013-09-28 Thread Ramkumar Ramachandra
Most readily available root filesystems are formatted as EXT4 these days. For example, see the raring rootfs that the Debian folk is preparing [1]. [1]: http://people.debian.org/~wookey/bootstrap/rootfs/ Cc: Catalin Marinas Cc: Will Deacon Cc: Andreas Schwab Signed-off-by: Ramkumar

[PATCH 0/2] Lower entry barrier for arm64 development

2013-09-28 Thread Ramkumar Ramachandra
], and it works well for me. I intend to address more papercuts in future patches. Thanks. [1]: https://github.com/artagnon/boot-wrapper-aarch64 Ramkumar Ramachandra (2): arm64: include EXT4 in defconfig arm64: include VIRTIO_{MMIO,BLK} in defconfig arch/arm64/configs/defconfig | 5 - 1

[PATCH 2/2] arm64: include VIRTIO_{MMIO,BLK} in defconfig

2013-09-28 Thread Ramkumar Ramachandra
-by: Ramkumar Ramachandra --- arch/arm64/configs/defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 798bcbb..31c81e9 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -42,7 +42,7

[PATCH 0/2] Toying with the perf tool

2013-09-30 Thread Ramkumar Ramachandra
Hi, I was curiously poking around the perf tool this morning. The hacking session resulted in two minor patches: [1/2] is a minor non-functional cleanup of the Makefile. [2/2] is more important: it omits printing bogus data in an edge case. Thanks for reading. Ramkumar Ramachandra (2): perf

[PATCH 1/2] perf tool: simplify ARCH code in Makefile

2013-09-30 Thread Ramkumar Ramachandra
: Arnaldo Carvalho de Melo Cc: Namhyung Kim Signed-off-by: Ramkumar Ramachandra --- tools/perf/config/Makefile | 47 ++ 1 file changed, 22 insertions(+), 25 deletions(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 5f6f9b3

[PATCH 2/2] perf tool: don't print bogus data on -e cycles

2013-09-30 Thread Ramkumar Ramachandra
. In our case, since we have only requested HW_CPU_CYCLES, runtime_nsecs_stats is unavailable. So, omit printing the comment altogether. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Paul Mackerras Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/builtin-stat.c | 9

[PATCH 0/4] Minor selftests cleanups

2013-06-30 Thread Ramkumar Ramachandra
Just ran a few of them. Unsure about [4/4] because of aabccae6 and a58130d. Thanks. Ramkumar Ramachandra (4): selftests: add .gitignore for vm selftests: fix clean target in kcmp Makefile selftests: add .gitignore for kcmp selftests: get {cpu,memory}-hotplug tests to run tools/testing

[PATCH 3/4] selftests: add .gitignore for kcmp

2013-06-30 Thread Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra --- tools/testing/selftests/kcmp/.gitignore | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 tools/testing/selftests/kcmp/.gitignore diff --git a/tools/testing/selftests/kcmp/.gitignore b/tools/testing/selftests/kcmp/.gitignore new file mode

[PATCH 4/4] selftests: get {cpu,memory}-hotplug tests to run

2013-06-30 Thread Ramkumar Ramachandra
the executable bit fixing this. Signed-off-by: Ramkumar Ramachandra --- tools/testing/selftests/cpu-hotplug/on-off-test.sh| 0 tools/testing/selftests/memory-hotplug/on-off-test.sh | 0 2 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tools/testing/selftests/

[PATCH 1/4] selftests: add .gitignore for vm

2013-06-30 Thread Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra --- tools/testing/selftests/vm/.gitignore | 4 1 file changed, 4 insertions(+) create mode 100644 tools/testing/selftests/vm/.gitignore diff --git a/tools/testing/selftests/vm/.gitignore b/tools/testing/selftests/vm/.gitignore new file mode 100644

[PATCH 2/4] selftests: fix clean target in kcmp Makefile

2013-06-30 Thread Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra --- tools/testing/selftests/kcmp/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile index 56eb552..d7d6bbe 100644 --- a/tools/testing/selftests/kcmp

[PATCH 3/7] perf completion: strip dependency on _filedir

2013-07-04 Thread Ramkumar Ramachandra
_filedir is defined in the bash-completion package, but there is no need to depend on it. Instead, call complete with multiple -o arguments before the -F argument like in git.git's completion script. Cc: Frederic Weisbecker Signed-off-by: Ramkumar Ramachandra --- tools/perf/bash_completion

[PATCH 6/7] perf completion: strip dependency on bash-completion

2013-07-04 Thread Ramkumar Ramachandra
The bash-completion package defines the _get_comp_words_by_ref function. There is no need to depend on it, as we can reimplement it like git.git has. Cc: Namhyung Kim Cc: Frederic Weisbecker Signed-off-by: Ramkumar Ramachandra --- tools/perf/bash_completion | 83

[PATCH 7/7] perf completion: use more comp words

2013-07-04 Thread Ramkumar Ramachandra
The completion words $words and $cword are available, so we might as well use them instead of directly accessing COMP_WORDS. Cc: Frederic Weisbecker Signed-off-by: Ramkumar Ramachandra --- tools/perf/bash_completion | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 2/7] perf completion: update __ltrim_colon_completions

2013-07-04 Thread Ramkumar Ramachandra
The function is taken from the bash-completion package; update it to use the latest version where colon_word doesn't miss quoting. Cc: Frederic Weisbecker Signed-off-by: Ramkumar Ramachandra --- tools/perf/bash_completion | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/7] perf completion: modernize style

2013-07-04 Thread Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra --- tools/perf/bash_completion | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/bash_completion b/tools/perf/bash_completion index d2598be..8c04f5d 100644 --- a/tools/perf/bash_completion +++ b/tools/perf/bash_completion

[PATCH 5/7] perf completion: strip function_exists ()

2013-07-04 Thread Ramkumar Ramachandra
Use "type" to check existence consistently. Cc: Frederic Weisbecker Signed-off-by: Ramkumar Ramachandra --- tools/perf/bash_completion | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tools/perf/bash_completion b/tools/perf/bash_completion index 8c04f5

[PATCH 1/7] perf completion: don't dictate perf install location

2013-07-04 Thread Ramkumar Ramachandra
The statement have perf limits the locations in which to look for the perf program. Moreover, it depends on the bash-completion package to be installed. Replace it with a call to `type perf`. Cc: Frederic Weisbecker Signed-off-by: Ramkumar Ramachandra --- tools/perf/bash_completion | 2

[PATCH 0/7] Minor perf completion improvements

2013-07-04 Thread Ramkumar Ramachandra
on the bash-completion package. Thanks. Ramkumar Ramachandra (7): perf completion: don't dictate perf install location perf completion: update __ltrim_colon_completions perf completion: strip dependency on _filedir perf completion: modernize style perf completion: strip function_exists

[PATCH 0/2] Minor perf build fixes

2013-07-04 Thread Ramkumar Ramachandra
Hi, [1/2] is a trivial cleanup patch. I happened to notice it because the syntax highlighting of shell-script-mode broke due to the unmatched quotes. I'm not sure why [2/2] hasn't already been noticed and fixed though. Thanks. Ramkumar Ramachandra (2): perf/Makefile: do not open-code shell

[PATCH 1/2] perf/Makefile: do not open-code shell-sq

2013-07-04 Thread Ramkumar Ramachandra
are filled with $(call) invocations now. So, use the shell-sq function introduced in ced465c4 (perf tools: Makefile: PYTHON{,_CONFIG} to bandage Python 3 incompatibility, 2011-04-02) in place of open-coding. Cc: Michael Witten Cc: Ingo Molnar Signed-off-by: Ramkumar Ramachandra --- tools/perf

[PATCH 2/2] perf: squelch warnings from perl.h to compile-pass

2013-07-04 Thread Ramkumar Ramachandra
to squelch exactly those warnings, and get perf to compile-pass by default. Cc: Arnaldo Carvalho de Melo Cc: Namhyung Kim Signed-off-by: Ramkumar Ramachandra --- tools/perf/config/feature-tests.mak | 5 + tools/perf/scripts/perl/Perf-Trace-Util/Context.c| 10 -- tools

[PATCH 0/3] Get defconfig to work with ARCH=um

2013-07-04 Thread Ramkumar Ramachandra
(um: Switch to large mcmodel on x86_64, 2012-01-24) indicates that I did something stupid, but I don't know what. Thanks. Ramkumar Ramachandra (3): arch/um/Makefile: remove dead code arch/um/configs: add defconfig for i386, x86_64 arch/um: migrate to using defconfig in configs/ arch/um

[PATCH 1/3] arch/um/Makefile: remove dead code

2013-07-04 Thread Ramkumar Ramachandra
for $SUBARCH to be set as i386 or x86_64. Therefore, any code that checks $SUBARCH against these values is dead code. Cc: Al Viro Cc: Richard Weinberger Cc: Jeff Dike Signed-off-by: Ramkumar Ramachandra --- arch/um/Makefile | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/um

[PATCH 2/3] arch/um/configs: add defconfig for i386, x86_64

2013-07-04 Thread Ramkumar Ramachandra
the old arch/um/defconfig, and point build scripts to these new files. Cc: Jeff Dike Signed-off-by: Ramkumar Ramachandra --- arch/um/configs/i386_defconfig | 966 +++ arch/um/configs/x86_64_defconfig | 957 ++ 2 files

[PATCH 3/3] arch/um: migrate to using defconfig in configs/

2013-07-04 Thread Ramkumar Ramachandra
with $SUBARCH here, instead of $ARCH. Now, you can do: $ ARCH=um make defconfig $ ARCH=um make from the toplevel directory and successfully build User-Mode Linux. Cc: Jeff Dike Cc: Richard Weinberger Signed-off-by: Ramkumar Ramachandra --- arch/um/Kconfig.common | 5 - arch/um/Makefile

Re: [PATCH 0/3] Get defconfig to work with ARCH=um

2013-07-04 Thread Ramkumar Ramachandra
richard -rw- weinberger wrote: >> [1/3] is somewhat unrelated to the series, and I happened to notice it >> while reading. 12783aa07 (um: Switch to large mcmodel on x86_64, >> 2012-01-24) indicates that I did something stupid, but I don't know >> what. > > Yes, you broke kernel modules on

[PATCH v2] arch/um: make it work with defconfig and x86_64

2013-07-04 Thread Ramkumar Ramachandra
in default configuration. Cc: Richard Weinberger Cc: Jeff Dike Signed-off-by: Ramkumar Ramachandra --- arch/um/Kconfig.common | 5 - arch/um/Makefile| 11 ++ arch/um/{defconfig => configs/i386_defconfig} | 209 +--- arch

Re: [PATCH 0/7] Minor perf completion improvements

2013-07-05 Thread Ramkumar Ramachandra
Namhyung Kim wrote: > So the whole point of this patchset is removing dependency, and no > functional change, right? Yep, and to lay the groundwork for extensibility: I would like to add ZSH support in a future patchset, for instance. > It'd be great if the completion script supports multiple

[PATCH v2 4/4] perf/Perf-Trace-Util: regenerate Context.c

2013-07-05 Thread Ramkumar Ramachandra
>From Context.xs, using the procedure described in the README. Now, a simple $ make builds everything correctly. Cc: Tom Zanussi Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/scripts/perl/Perf-Trace-Util/Context.c | 215 +- 1 f

[PATCH v2 0/4] Minor perf build fixes

2013-07-05 Thread Ramkumar Ramachandra
duplication. It then updates Context.xs and trace-event-perl.c to use this new header. Also, notice that feature-tests.mak has not been touched in this iteration: the Perl check passes without needing the #pragma statements (although I'm not sure why exactly). Thanks. Ramkumar Ramachandra (4): perf

[PATCH v2 1/4] perf/Makefile: do not open-code shell-sq

2013-07-05 Thread Ramkumar Ramachandra
are filled with $(call) invocations now. So, use the shell-sq function introduced in ced465c4 (perf tools: Makefile: PYTHON{,_CONFIG} to bandage Python 3 incompatibility, 2011-04-02) in place of open-coding. Cc: Michael Witten Cc: Ingo Molnar Signed-off-by: Ramkumar Ramachandra --- tools/perf

[PATCH v2 2/4] perf/Perf-Trace-Util: fix broken include in Context.xs

2013-07-05 Thread Ramkumar Ramachandra
765532c8 (perf script: Finish the rename from trace to script, 2010-12-23) made a mistake during find-and-replace replacing "../../../util/trace-event.h" with "../../../util/script-event.h", a non-existent file. Fix this include. Cc: Arnaldo Carvalho de Melo Signed-off-by:

[PATCH v2 3/4] perf: squelch warnings from perl.h to compile-pass

2013-07-05 Thread Ramkumar Ramachandra
to squelch exactly those warnings. The next patch will regenerate Context.c from Context.xs and make the compile pass. Cc: Arnaldo Carvalho de Melo Cc: Namhyung Kim Signed-off-by: Ramkumar Ramachandra --- tools/perf/scripts/perl/Perf-Trace-Util/Context.xs | 4 ++-- tools/perf/util/perf-perl.h

Re: [PATCH 1/3] arch/um/Makefile: remove dead code

2013-07-05 Thread Ramkumar Ramachandra
Al Viro wrote: > [...] > IOW, any make variable (== macro in POSIX quote above) can be explicitly > set in make(1) command line in form name=value and in that case nothing in > makefile(s) can change its value. It's true for GNU make, it's true for > BSD make and it's been true for historical

[PATCH] menuconfig: Allow j/k to move down/up the menu

2013-07-05 Thread Ramkumar Ramachandra
Like in Vim. Cc: Michal Marek Signed-off-by: Ramkumar Ramachandra --- Unsure why nobody has done this yet. scripts/kconfig/lxdialog/menubox.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c

[PATCH v5 1/3] perf diff: color the Delta column

2013-12-10 Thread Ramkumar Ramachandra
: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/builtin-diff.c | 49 ++- tools/perf/util/color.c | 6 -- 2 files changed, 52 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin

[PATCH v5 0/3] More color in 'perf diff'

2013-12-10 Thread Ramkumar Ramachandra
Cc: Namhyung Kim Cc: Arnaldo Carvalho de Melo Ramkumar Ramachandra (3): perf diff: color the Delta column perf diff: color the Ratio column perf diff: color the Weighted Diff column tools/perf/builtin-diff.c | 91 ++- tools/perf/util/color.c

[PATCH v5 2/3] perf diff: color the Ratio column

2013-12-10 Thread Ramkumar Ramachandra
: Remove cast of non-variadic function to variadic, 2013-10-31) explains why it needs to be a variadic function. Cc: Jiri Olsa Cc: Namhyung Kim Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/builtin-diff.c | 20 tools/perf/util/color.c | 10

[PATCH v5 3/3] perf diff: color the Weighted Diff column

2013-12-10 Thread Ramkumar Ramachandra
In $ perf diff -c wdiff:M,N color the numbers in the Weighted Diff column either green or red, depending on whether the number is positive or negative. Cc: Jiri Olsa Cc: Namhyung Kim Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/builtin-diff.c | 22

Re: [PATCH] perf tools: Pick up libdw without explicit LIBDW_DIR

2014-04-03 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: > tools/perf/config/Makefile | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Jiri, any comments? Ram -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

[PATCH v2] MAINTAINERS: add tools/lib/traceevent/ to perf subsystem

2014-03-26 Thread Ramkumar Ramachandra
While at it, add Steven Rostedt to the list of maintainers. Cc: Steven Rostedt Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 82640e6..3e8b402 100644 --- a/MAINTAINERS +++ b

[PATCH] perf tools: Pick up libdw without explicit LIBDW_DIR

2014-03-26 Thread Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra --- tools/perf/config/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index c234182..0c043b0 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile

[PATCH] perf list: Replace --raw-dump with parse_options_subcommand()

2014-03-26 Thread Ramkumar Ramachandra
this change. Fixes: 44d742e01e6d (perf list: Add usage) Cc: Jiri Olsa Cc: David Ahern Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/builtin-list.c | 13 +++-- tools/perf/perf-completion.sh | 6 +++--- 2 files changed, 10 insertions(+), 9 deletions

Re: [PATCH 0/4] perf: trivial follow-ons to --list-cmds

2014-03-26 Thread Ramkumar Ramachandra
David Ahern wrote: >> Ramkumar Ramachandra (4): >>perf kmem: introduce --list-cmds for use by scripts >>perf mem: introduce --list-cmds for use by scripts >>perf lock: introduce --list-cmds for use by scripts >>perf sched: introduce --list-cmds for us

Re: [PATCH] perf list: Replace --raw-dump with parse_options_subcommand()

2014-03-27 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: > tools/perf/builtin-list.c | 13 +++-- > tools/perf/perf-completion.sh | 6 +++--- > 2 files changed, 10 insertions(+), 9 deletions(-) Please ignore this patch. Major thinko on my part. -- To unsubscribe from this list: send the line "uns

[PATCH] perf list: Fix --raw-dump argument

2014-03-27 Thread Ramkumar Ramachandra
While adding usage information, 44d742e (perf list: Add usage, 2013-10-30) broke $ perf list --raw-dump Fix this by making raw-dump a proper argument. Cc: David Ahern Cc: Jiri Olsa Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- I sent this patch earlier

[PATCH] perf stat: Don't print bogus data when one event is requested

2014-03-27 Thread Ramkumar Ramachandra
elapsed The 0.00% frontend cycles idle comment in the output is totally bogus and misleading. Omit printing it here, as well as in the stalled-cycles-backend case. Cc: Jiri Olsa Cc: David Ahern Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/builtin-stat.c | 26

[PATCH 3/3] perf bench: Fix segfault at the end of an 'all' execution

2014-03-27 Thread Ramkumar Ramachandra
At the end of $ perf bench all the program segfaults because it attempts to dereference a NULL pointer. Fix this fault. Cc: Jiri Olsa Cc: David Ahern Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/builtin-bench.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/3] perf bench: Set more defaults in the 'numa' suite

2014-03-27 Thread Ramkumar Ramachandra
Ahern Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/bench/numa.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c index d4c83c6..20697fb 100644 --- a/tools/perf/bench/numa.c +++ b/tools/perf/bench/numa.c

[PATCH 0/3] Minor fixes around perf bench

2014-03-27 Thread Ramkumar Ramachandra
Hi, I just started looking at 'perf bench' this afternoon. Here are some simple patches fixing the minor issues I had while starting out. Thanks. Ram Cc: Ingo Molnar Cc: Jiri Olsa Cc: David Ahern Cc: Arnaldo Carvalho de Melo Ramkumar Ramachandra (3): perf bench: Set more defaults

[PATCH 2/3] perf bench: Update manpage to mention numa and futex

2014-03-27 Thread Ramkumar Ramachandra
Cc: Jiri Olsa Cc: David Ahern Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/Documentation/perf-bench.txt | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tools/perf/Documentation/perf-bench.txt b/tools/perf/Documentation/perf

[PATCH v2] avr32: replace simple_strtoul() with kstrtoul()

2014-03-31 Thread Ramkumar Ramachandra
simple_strtoul() is marked for obsoletion; use the newer and more pleasant kstrtoul() in its place. Cc: Alexey Dobriyan Cc: Haavard Skinnemoen Cc: Hans-Christian Egtvedt Signed-off-by: Ramkumar Ramachandra --- arch/avr32/kernel/cpu.c | 48 ++-- 1

Re: [PATCH 1/1] perf:Adding --list-opts to usage string

2015-10-13 Thread Ramkumar Ramachandra
Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 08, 2015 at 10:59:50AM +0530, Sriram Raghunathan escreveu: >> Minor change, adding --list-opts to usage string. So that it is >> visible to the user on running perf --help. or just perf >> from command line. > > > Ramkumar, Yunlong, are you ok with

Re: [PATCH] perf kvm: introduce --list-cmds for use by scripts

2014-03-13 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: > Jiri Olsa wrote: >> On Mon, Mar 03, 2014 at 08:26:36PM -0500, Ramkumar Ramachandra wrote: >>> Introduce >>> >>> $ perf kvm --list-cmds >>> >>> to dump a raw list of commands for use by the

[PATCH 3/3] irq: add lock annotation to squelch a sparse warning

2013-07-06 Thread Ramkumar Ramachandra
ock(), because it does so conditionally. Cc: Thomas Gleixner Signed-off-by: Ramkumar Ramachandra --- kernel/irq/irqdesc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c index 192a302..d6bc26a 100644 --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdes

[PATCH 0/3] Trivial sparse acquire/release annotations

2013-07-06 Thread Ramkumar Ramachandra
Hi, So, I was looking at sparse this lazy Saturday afternoon. Thought I might as well clean up a few obvious warnings while I'm there. Thanks. Ramkumar Ramachandra (3): nfs: add lock annotations to squelch sparse warnings apic: add lock annotations to squelch sparse warnings irq: add

[PATCH 2/3] apic: add lock annotations to squelch sparse warnings

2013-07-06 Thread Ramkumar Ramachandra
Gleixner Signed-off-by: Ramkumar Ramachandra --- arch/x86/kernel/apic/io_apic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 9ed796c..b756417 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic

[PATCH 1/3] nfs: add lock annotations to squelch sparse warnings

2013-07-06 Thread Ramkumar Ramachandra
in 'nfs_volume_list_start' - unexpected unlock Help it by annotating the pairs of functions with __acquires and __releases. Cc: David Howells Cc: Trond Myklebust Signed-off-by: Ramkumar Ramachandra --- fs/nfs/client.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/nfs/client.c b/fs/nfs

Re: [PATCH 2/2] perf: squelch warnings from perl.h to compile-pass

2013-07-07 Thread Ramkumar Ramachandra
Kirill A. Shutemov wrote: > On Fri, Jul 05, 2013 at 11:34:12AM +0900, Namhyung Kim wrote: >> On Thu, 4 Jul 2013 19:10:46 +0530, Ramkumar Ramachandra wrote: >> > Currently, a simple >> > >> > $ make >> > >> > errors out because we comp

Re: [PATCH] menuconfig: Allow j/k to move down/up the menu

2013-07-07 Thread Ramkumar Ramachandra
Rob Landley wrote: >> Unsure why nobody has done this yet. > > [...] > And now you know _why_ Linux is over 20 years old and has never needed this. I was just asking out of curiosity: I'm not old enough to know that much history. Isn't it a nice convenience to have _now_? Or do you have

Re: [PATCH v2 0/4] Minor perf build fixes

2013-07-09 Thread Ramkumar Ramachandra
Hi Namhyung, Namhyung Kim wrote: > On Fri, 5 Jul 2013 15:46:13 +0530, Ramkumar Ramachandra wrote: >> [3/4] introduces a util/perf-perl.h to include with #pragma >> statements, hence eliminating duplication. It then updates Context.xs >> and trace-event-perl.c to use t

[PATCH v3 3/5] perf: squelch warnings from perl.h to compile-pass

2013-07-09 Thread Ramkumar Ramachandra
to squelch exactly those warnings, making perf compile-pass. Helped-by: Namhyung Kim Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/util/perl.h | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 tools/perf/util/perl.h diff --git a/tools/perf/util

[PATCH v3 0/5] Minor perf build fixes

2013-07-09 Thread Ramkumar Ramachandra
. Ramkumar Ramachandra (5): perf/Makefile: do not open-code shell-sq perf/Perf-Trace-Util: fix broken include in Context.xs perf: squelch warnings from perl.h to compile-pass perf/Perf-Trace-Util: regenerate Context.c perf/Perf-Trace-Util: add .gitignore tools/perf/Makefile

[PATCH v3 1/5] perf/Makefile: do not open-code shell-sq

2013-07-09 Thread Ramkumar Ramachandra
are filled with $(call) invocations now. So, use the shell-sq function introduced in ced465c4 (perf tools: Makefile: PYTHON{,_CONFIG} to bandage Python 3 incompatibility, 2011-04-02) in place of open-coding. Cc: Michael Witten Cc: Ingo Molnar Signed-off-by: Ramkumar Ramachandra --- tools/perf

[PATCH v3 2/5] perf/Perf-Trace-Util: fix broken include in Context.xs

2013-07-09 Thread Ramkumar Ramachandra
765532c8 (perf script: Finish the rename from trace to script, 2010-12-23) made a mistake during find-and-replace replacing "../../../util/trace-event.h" with "../../../util/script-event.h", a non-existent file. Fix this include. Cc: Arnaldo Carvalho de Melo Signed-off-by:

[PATCH v3 5/5] perf/Perf-Trace-Util: add .gitignore

2013-07-09 Thread Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra --- tools/perf/scripts/perl/Perf-Trace-Util/.gitignore | 5 + 1 file changed, 5 insertions(+) create mode 100644 tools/perf/scripts/perl/Perf-Trace-Util/.gitignore diff --git a/tools/perf/scripts/perl/Perf-Trace-Util/.gitignore b/tools/perf/scripts/perl

[PATCH v3 4/5] perf/Perf-Trace-Util: regenerate Context.c

2013-07-09 Thread Ramkumar Ramachandra
>From Context.xs, using the procedure described in the README. Cc: Tom Zanussi Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/scripts/perl/Perf-Trace-Util/Context.c | 211 ++ 1 file changed, 171 insertions(+), 40 deletions(-) diff --

Re: [PATCH 2/2] perf: squelch warnings from perl.h to compile-pass

2013-07-09 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: >> This one: https://lkml.org/lkml/2013/6/24/66 ? > > Yeah, I think this is more sensible than my approach. Thanks to Namhyung, I think my v3 is better now: http://article.gmane.org/gmane.linux.kernel/1522137 -- To unsubscribe from this list: send the line

[PATCH] virtio tools: add .gitignore

2013-07-10 Thread Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra --- tools/virtio/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tools/virtio/.gitignore diff --git a/tools/virtio/.gitignore b/tools/virtio/.gitignore new file mode 100644 index 000..1cfbb01 --- /dev/null +++ b/tools/virtio

[PATCH 0/2] virtio tools: build failure

2013-07-10 Thread Ramkumar Ramachandra
I should atleast submit a bug report. Maybe I'm missing something? Thanks. Ramkumar Ramachandra (2): virtio tools: strip bad include-path from Makefile virtio tools: add .gitignore tools/virtio/.gitignore | 3 +++ tools/virtio/Makefile | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) cr

[PATCH 1/2] virtio tools: strip bad include-path from Makefile

2013-07-10 Thread Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra --- tools/virtio/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virtio/Makefile b/tools/virtio/Makefile index 3187c62..53623c6 100644 --- a/tools/virtio/Makefile +++ b/tools/virtio/Makefile @@ -3,7 +3,7 @@ test: virtio_test v

Re: [PATCH 1/2] virtio tools: strip bad include-path from Makefile

2013-07-10 Thread Ramkumar Ramachandra
Michael S. Tsirkin wrote: >> CFLAGS contains a mysterious "-I ../../usr/include", but no such path >> exists in the linux tree. The line was originally introduced in >> 4e53f78e (tools/virtio: virtio_test tool, 2010-11-29), but no such path >> existed in the tree even then. > > It exists if you

Re: [PATCH 1/2] virtio tools: strip bad include-path from Makefile

2013-07-10 Thread Ramkumar Ramachandra
Michael S. Tsirkin wrote: > This is usespace code so it needs the cleaned-up version from > usr/include, not the internal kernel one. Right, thanks for clearing that up. However, it does seem to depend on some code in /include in the linux tree. From tools/virtio/linux/virtio_ring.h:

[PATCH 1/3] menuconfig: factor out reserved letters

2013-07-10 Thread Ramkumar Ramachandra
These letters that should not be used in menu selection. Cc: Michal Marek Signed-off-by: Ramkumar Ramachandra --- scripts/kconfig/lxdialog/menubox.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog

[PATCH 3/3] menuconfig: allow j/k to move down/up the menu

2013-07-10 Thread Ramkumar Ramachandra
Like in Vim. Cc: Michal Marek Signed-off-by: Ramkumar Ramachandra --- scripts/kconfig/lxdialog/menubox.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c index 698d7c3..151394a 100644

[PATCH 2/3] menuconfig: remove redundant info from RESERVED_LETTERS

2013-07-10 Thread Ramkumar Ramachandra
first_alpha() checks only against lowercase characters anyway. Cc: Michal Marek Signed-off-by: Ramkumar Ramachandra --- scripts/kconfig/lxdialog/menubox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog

[PATCH v2 0/3] Modernize menuconfig a bit

2013-07-10 Thread Ramkumar Ramachandra
]. Independent of part 3, I think parts 1 and 2 are obviously correct, and should be merged. Thanks. Ramkumar Ramachandra (3): menuconfig: factor out reserved letters menuconfig: remove redundant info from RESERVED_LETTERS menuconfig: allow j/k to move down/up the menu scripts/kconfig

Re: [PATCH v3 3/5] perf: squelch warnings from perl.h to compile-pass

2013-07-10 Thread Ramkumar Ramachandra
Arnaldo Carvalho de Melo wrote: > Huh? In what distro? I see, one that has a newer perl (5.18.0) I use Arch. Yeah, all my packages are new :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] x86/ia32: remove unused argument in macro

2013-07-10 Thread Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra --- Trivial. arch/x86/ia32/ia32entry.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S index 474dc1b..4299eb0 100644 --- a/arch/x86/ia32/ia32entry.S +++ b/arch/x86/ia32/ia32entry.S

[PATCH] scripts: remove unused function in sortextable.c

2013-07-10 Thread Ramkumar Ramachandra
Cc: David Daney Cc: Michal Marek Signed-off-by: Ramkumar Ramachandra --- Trivial. I wonder why make didn't tell us? scripts/sortextable.c | 8 1 file changed, 8 deletions(-) diff --git a/scripts/sortextable.c b/scripts/sortextable.c index f9ce116..7c2310c 100644 --- a/scripts

<    1   2   3   4   5   6   7   8   >