On Tue, Oct 17, 2000 at 05:59:22PM -0200, Arnaldo Carvalho de Melo wrote:
Jeff,
Here it is, resubmitting after rediffing wrt 2.4.0-test10-pre3.
- Arnaldo
--- linux-2.4.0-test10-3/drivers/block/cpqarray.c Fri Oct 13 18:40:39 2000
(snipped Linus from the to-list since this is
I still think the code is correct and only the documentation needs to be
updated (I'll send a patch to Linus as soon as I catch up with my mail queue).
You are right. I missed the place in check_pcibios where you remove the
PCI_PROBE_CONF{1,2}-flags from pci_probe :( My bad. If you would like
Hi.
Reading through kernel/sched.c I came across this block (on line 597):
{
cycles_t t, this_slice;
t = get_cycles();
this_slice = t - sched_data-last_schedule;
sched_data-last_schedule = t;
}
It seems to me that
On Wed, Oct 25, 2000 at 08:50:15AM -0400, Richard B. Johnson wrote:
On Wed, 25 Oct 2000, Michael O'Donnell wrote:
Before I spend too many additional brain cells diagnosing
this, can somebody remind me if this happens to be a
well known problem? Several of my other brain cells
think
Hi.
(Does anybody know who the maintainer for this code is?)
The patch below moves drivers/scsi/g_NCR5380.c from using isa_{read,
write, memcpy} to ioremap and the equivalent non-isa functions. It
also fixes an 'unused variable' warning and exchanges check_region for
request_region (and fixes a
On Sun, Feb 25, 2001 at 02:05:42PM +, Alan Cox wrote:
[...]
(An indication of how often this code path is used can be found in
the fact that the previous define of NCR5380_write had its payload
and address mixed up, probably making for wierd results should
the code ever be executed.)
Im running PIO. However while I agree with that one Im dubious about the
inverts on the memcpy_*io bits
I am sorry but have I inverted the arguments to the memcpy_*io calls?
Or are you referring to something other than the arguments here?
--
Rasmus([EMAIL PROTECTED])
"Science is
On Sun, Feb 25, 2001 at 02:46:15PM +, Alan Cox wrote:
I am sorry but have I inverted the arguments to the memcpy_*io calls?
Or are you referring to something other than the arguments here?
You seem to have swapped the source/dest over in memcpy_toio cases and I need
to convince myself
On Tue, Feb 27, 2001 at 10:02:11AM +, Russell King wrote:
Hi,
I'm seeing odd behaviour with rsync over ssh between two x86 machines -
one if the is an UP PIII (Katmai) running 2.4.2 (isdn-gw) and the other
is an UP Pentium 75-200 (pilt-gw) running 2.2.15pre13 with some custom
serial
On Fri, Nov 03, 2000 at 06:51:05AM -0800, David S. Miller wrote:
Are you saying that the original bug report may not actually be a
problem? Is ms-rss actually protected in _all_ of the right
places, but people got confused because of the syntactic sugar?
I don't know if all of
Hi.
Some time ago there was a thread about subject and a patch was posted
(by davej?). It was rejected because of the vmlist_modify_{un}lock
mess (AFAIR) and nothing has been done since. The first patch below
moves mm-rss inside the page_table_lock in mm/.
I noticed that mm-rss is also
Hi.
(The following (with minor differences in the text) was sent to linux-kernel
Thursday. I have received no response and the item is still on Teds list
of todo (www version anyway) so I'll risk a limb to the Quake monster :)
by sending this to you.)
Some time ago there was a thread about
Hi.
I recently investigated an 'unused function' warning in iph5526.c. Looking
at it (both the code causing the warning and the whole driver) convinced
me that the driver cannot be used without PCI enabled.
I therefore propose that we add a dependency in net/Config.in for this
driver and clean
Hi.
This patch is blessed by the maintainer and is based on the observation
that the Interphase 5526 card requires PCI to work. Therefore the PCI
dependency is moved into net/Config.in and removed from the .c-file.
The maintainers email address is also updated and a minor code shuffle
is done in
Hi.
The following patch eliminates an 'defined but not used' warning when
compiling drivers/net/arlan.c without module support (240t12p3). It
also fixes a typo.
It should apply cleanly.
--- linux-240-t12-pre3-clean/drivers/net/arlan.cWed Nov 22 22:41:40 2000
+++
(I sent the following to [EMAIL PROTECTED], but forgot to cc linux-kernel).
Hi.
The following patch removes some 'defined but not used' warnings when
compiling drivers/net/eepro.c (240t12p7) without modular support.
--- linux-240-t12-pre7-clean/drivers/net/eepro.cFri Dec 8 00:44:58
Hi.
The following patch removes a 'defined but not used' warning from drivers/
new/hp100.c when compiling without CONFIG_PCI (240t12p3). It should apply
cleanly.
--- linux-240-t12-pre3-clean/drivers/net/hp100.cSat Nov 4 23:27:07 2000
+++ linux/drivers/net/hp100.c Sat Dec 2 16:07:27
Hi.
The following patch moves the page_table_lock in mm/* to cover the
modification of mm-rss in 240-test12-pre7. It was inspired by a
similar patch from davej(?) which covered too much, AFAIR. The item
is on Tytso's ToDo list.
Please comment.
diff -Naur linux-240-t12-pre7-clean/mm/memory.c
Hi.
The following patch makes some 'defined but not used' warnings go away
when compiling drivers/char/moxa.c without CONFIG_PCI (240t12p3). It should
apply cleanly.
--- linux-240-t12-pre3-clean/drivers/char/moxa.cWed May 3 10:45:18 2000
+++ linux/drivers/char/moxa.c Wed Nov 29
Hi.
The following patch makes some 'defined but not used' warnings go
away when compiling drivers/char/mxser.c without CONFIG_PCI (240t12p3).
It should apply cleanly.
--- linux-240-t12-pre3-clean/drivers/char/mxser.c Wed Nov 22 22:41:39 2000
+++ linux/drivers/char/mxser.c Wed Nov 29
Hi.
The following patch makes a 'defined but not used' warning go away
when compiling drivers/char/random.c without sysctl support (240t12p3).
(but should apply cleanly). I am aware that there is a sysctl section
of this code, but the function seems to belong where it is. I would be
happy to
Hi.
(Does anyone know the maintainer of this code?)
When compiling drivers/net/rclanmtl.c (240t12p3) I get a warning about
incompatible pointer assignment. As far as I can tell it has appeared
because PU32 has been changed to __u32* since test9 (where it was an
unsigned long*). The following
Hi.
This patch makes a 'defined but not used' warning go away when compiling
drivers/net/tokenring/smctr.c without module support (kernel 240t12p3).
(It should apply cleanly.)
--- linux-240-t12-pre3-clean/drivers/net/tokenring/smctr.c Sat Nov 4 23:27:09
2000
+++
Hi.
The following patch makes a 'defined but not used' warning go
away when compiling drivers/net/irda/w83977af_ir.c without
modular support (kernel 240t12p7). It also removes some unneeded
zero initializations.
--- linux-240-t12-pre7-clean/drivers/net/irda/w83977af_ir.c Wed Nov 22
On Sat, Dec 09, 2000 at 04:46:15AM -0600, Peter Samuelson wrote:
[Rasmus Andersen]
-static struct w83977af_ir *dev_self[] = { NULL, NULL, NULL, NULL};
+static struct w83977af_ir *dev_self[];
How does the compiler know the size of the array?
By reading my mind, I guess :( The following
On Sat, Dec 09, 2000 at 11:25:09AM +0100, Roberto Fichera wrote:
[...]
+ spin_lock(mm-page_table_lock);
mm-rss++;
+ spin_unlock(mm-page_table_lock);
[...snip...]
Why we couldn't use atomic_inc(mm-rss) here and below, avoiding to wrap
the inc with a
On Sat, Dec 09, 2000 at 04:37:40PM -0600, Peter Samuelson wrote:
[Pavel Machek]
I'd say that warning is more acceptable than #ifdef... In cases where
warnings can be eliminating without ifdefs, that's okay, but this...
In this case it is dead weight in the object file -- and for
On Mon, Dec 11, 2000 at 06:09:31PM -0600, Peter Samuelson wrote:
[Rasmus Andersen]
How about this patch? It moves the offending struct to the __init
function where it is used and inside an existing #ifdef CONFIG_PCI.
H, if you're messing around with the pci device table, why
Hi.
I'm not quite sure whom this patch belongs to but I hope that it ends up
in the right hands by way of linux-kernel.
In order to get 'make dep' to make it through my tree (240-test13-pre1) I
need the following patch applied:
diff -Naur linux-240-t13-pre1-clean/net/802/transit/Makefile
Hi.
When I try to compile kernel 240test13pre2 I get the following:
rm -f eicon_drv.o
ld -m elf_i386 -r -o eicon_drv.o eicon.o divas.o
divas.o: In function `eicon_init':
divas.o(.text+0x61d0): multiple definition of `eicon_init'
eicon.o(.text+0x197c): first defined here
ld: Warning: size of
Hi.
This patch fixes a trivial makefile problem i drivers/isdn/sc.
--- linux-240-t13-pre2-clean/drivers/isdn/sc/Makefile Sat Dec 16 20:40:56 2000
+++ linux/drivers/isdn/sc/Makefile Sat Dec 16 21:14:57 2000
@@ -2,7 +2,7 @@
# The target object and module list name.
-O_TARGET :=
Hi.
drivers/isdn/isdn_bsdcomp.c #errors if it is not compiled as a module. The
following patch moves this into the Config.in file. Other options include
fixing the code or just noting this in the help option for the config entry.
I leave this up to the maintainers.
---
Hi.
In the link phase of a kernel 240t13p2 build I get the following:
drivers/char/char.o: In function `tty_init':
drivers/char/char.o(.text.init+0x259): undefined reference to `riscom8_init'
I guess this is bacause riscom8_init is now a static function and thus
tty_init cannot see it. If this
Hi.
Various files in drivers/mtd references cfi_probe (by way of do_cfi_probe).
This function is static and thus not shared. The following patch removes
the static declaration but if it is What Was Intended I do not know. It
makes the kernel link, however.
---
On Sat, Dec 16, 2000 at 10:37:59PM +, Alan Cox wrote:
Remove the call from tty_init. riscom8 now uses the new style initialisers
I guess this would do it then.
--- linux-240-t13-pre2-clean/drivers/char/tty_io.c Thu Dec 14 20:13:29 2000
+++ linux/drivers/char/tty_io.c Sun Dec 17
+36,8 @@
** Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
**
**
+** Rasmus Andersen, December 2000: Converted to new PCI API.
+**
** Pete Popov, January 11,99: Fixed a couple of 2.1.x problems
** (virt_to_bus() not called), tested it under 2.2pre5 (as a module), and
** added
+ unregister_netdev(dev);
+ iounmap((void *)dev-base_addr);
+free_irq(dev-irq, dev);
I'd rather inhibit irq first then release the ressources.
+ free_irq(dev-irq, dev);
+ iounmap((void *)dev-base_addr);
+ unregister_netdev(dev);
Fair enough. I just copied
On Tue, Dec 19, 2000 at 10:05:30PM +0100, Torben Mathiasen wrote:
You should release the irq when the adapter is closed, not removed,
unless there's some special case that can't be handled if you take
ints during init.
You seem to be right. I have moved the free_irq to the close function.
Hi.
This is the final version of my rcpci45.c patch. It is somewhat more
ambitious than the last one (which only cleaned up the PCI API), so
I would appreciate feedback since I don't know half of what I am doing
(questions galore below). It features:
o Conversion to new PCI API.
o Removal of
On Thu, Dec 21, 2000 at 10:46:52PM +, Alan Cox wrote:
o The driver currently allocates irqs during its initialization
instead of postponing it until it is opened for use. Is there
a reason for this?
Shouldnt be - its an I2O network interface with some extra bits for
the
On Mon, Jan 08, 2001 at 03:36:23PM -0200, Rik van Riel wrote:
I have not taken^Whad the time to check the kernel tree
and see if the RSS counting has indeed been made safe
everywhere.
I have posted the one below a couple of times without it making
it in. If you like ot please fold it into
ugh Forgot to cc linux-kernel
Hi.
I get the following error when trying to compile 2.4.0-test10pre6
without procfs support:
drivers/ide/osb4.c: In function `pci_init_osb4':
drivers/ide/osb4.c:264: `osb4_revision' undeclared (first use in this function)
drivers/ide/osb4.c:264: (Each undeclared
This patch, and a lot of others of a similar nature, are in my test10pre6
compile patch at
[snip]
(Added a bit to the cc list)
Hi Arjan.
Thanks for the pointer. However my test build still barfs in the final
link phase because we (in t10p6) morphed drivers/pcmcia/cs.c::pcmcia_
request_irq
Hi.
Various parts of the kernel, notably the drivers, have sections
of code that is only relevant if certain defines are valid. The
obvious examples would be CONFIG_PROC_FS and MODULES. In both
cases the functions directly used in conjunction with these
defines evaluate to nops. But especially
Hi.
If I compile a 2.4.0-test10 kernel without pci support I get a compile
error in both drivers/isdn/hisax/nj_u.c and nj_s.c. The patch below
fixes these in what I hope is the Right Way. But I am not sure, so
Linus is not cc'ed on this. Please forward to him if the patches are
correct.
---
On Wed, Nov 08, 2000 at 02:11:34PM -0800, H. Peter Anvin wrote:
Followup to: [EMAIL PROTECTED]
By author:Igmar Palsenberg [EMAIL PROTECTED]
In newsgroup: linux.dev.kernel
[snip]
May I remind you guys that a malloc(0) is equal to a free(). There is no
way that any mem get's malloced.
On Sun, Nov 12, 2000 at 08:58:48PM +1100, john slee wrote:
On Sat, Nov 11, 2000 at 07:22:06PM -0800, Linus Torvalds wrote:
-
- pre3:
- Bartlomiej Zolnierkiewicz: sound and drm driver init fixes and
cleanups
this breaks for me, gcc 2.95.2:
gus_midi.c:206: parse error
On Sun, Nov 12, 2000 at 12:17:07PM +0100, Rasmus Andersen wrote:
On Sun, Nov 12, 2000 at 08:58:48PM +1100, john slee wrote:
On Sat, Nov 11, 2000 at 07:22:06PM -0800, Linus Torvalds wrote:
-
- pre3:
- Bartlomiej Zolnierkiewicz: sound and drm driver init fixes
Hi.
When I try to compile 2.4.0-test11-pre3 I get the following in
the link phase:
drivers/net/irda/irda.o: In function `nsc_ircc_hard_xmit_fir':
drivers/net/irda/irda.o(.text+0x346e): undefined reference to
`nsc_ircc_change_speed_complete'
drivers/net/irda/irda.o: In function
On Sun, Nov 12, 2000 at 12:31:26PM +0100, Rasmus Andersen wrote:
On Sun, Nov 12, 2000 at 12:17:07PM +0100, Rasmus Andersen wrote:
On Sun, Nov 12, 2000 at 08:58:48PM +1100, john slee wrote:
On Sat, Nov 11, 2000 at 07:22:06PM -0800, Linus Torvalds wrote:
-
- pre3
Hi.
When running 'tar cvIf file /' or 'tar cvzf file /' (but sometimes not
with 'plain' tar, i.e., without compression) I get an oops after some
time. This is reproducible. The oops below is from a 'tar cvIf' run.
I get this also with 2.2.17pre10 (which was what I was running before
On Mon, Nov 13, 2000 at 11:10:08PM -0600, Peter Samuelson wrote:
[Rasmus Andersen]
I'm getting oopses on a linux 2.2.17 box when I try to do
tar cvIf file -Xfile /. Reproducably.
Are you excluding /proc? Trying to back up all of /proc is definitely
asking for trouble, although
I get this also with 2.2.17pre10 (which was what I was running before
encountering this) but not with the stock RH 6.2 kernel (2.2.14-5.0).
Unless I get other suggestions I'm going to try with the latest 2.2.18pre
and 2.2.16 tomorrow.
OK, I tried with 2.2.16 and 2.2.18pre21 compiled with
OK, I tried with 2.2.16 and 2.2.18pre21 compiled with egcs-2.91.66
(the kernels reported yesterday were compiled with 2.95.2).
2.2.16 oopsed faithfully (I could not get hold of the oops as several
scrolled by and none made it to the log). 2.2.18pre21 does not oops.
Bzip2 core dumps, but
Hi.
Recent changes in the kernel has made the patch below necessary:
--- linux-240-t11-pre5-clean/drivers/net/hamradio/baycom_epp.c Sat Nov 4 23:27:07
2000
+++ linux/drivers/net/hamradio/baycom_epp.c Thu Nov 16 20:27:22 2000
@@ -812,10 +812,10 @@
/*
Hi.
Changes in the kernel has made the patch below necessary for sm.h:
--- linux-240-t11-pre5-clean/drivers/net/hamradio/soundmodem/sm.h Wed Aug 18
20:38:50 1999
+++ linux/drivers/net/hamradio/soundmodem/sm.h Thu Nov 16 20:33:17 2000
@@ -299,7 +299,7 @@
#ifdef __i386__
-#define
Hi.
I get an oops reproducably with 2.2.17 and 2.2.18pre21 on a stock RH 6.2
system. I cannot trigger it with the RH supplied kernel (2.2.14-5.0).
I also got it with 2.2.17pre10 which prompted me to upgrade the kernel.
I initially suspected bad RAM but have exchanged the RAM with memtest86'ed
On Tue, Jun 12, 2001 at 02:59:12PM +0100, Jeremy Sanders wrote:
I'm getting numerous rsync (v2.4.6) problems under Linux 2.4.2 (RedHat
7.1) or stock 2.4.4 on several machines. rsync often hangs copying files
from NFS or local disks to local disks. Strangely the problem is fixed by
stracing
On Tue, Jun 12, 2001 at 11:23:02AM -0400, Disconnect wrote:
On Tue, 12 Jun 2001, David S. Miller did have cause to say:
Look everyone, it was determined to be a deadlock because of some
interaction between how rsync sets up it's communication channels
with the ssh subprocess, readas:
On Tue, Jun 19, 2001 at 10:41:51AM +0100, Jeremy Sanders wrote:
I've found a patch which fixes the hanging problem, so I guess it's not
linux-kernel which is at fault. Get it from Wayne Davison at:
Works for me too.
--
Rasmus([EMAIL PROTECTED])
Men kick friendship around like a
Hi.
The following patch #ifdefs a function to be in its preprocessor
scope and eliminates the use of check_region, adds '\n' to printk's,
adds checks for kmalloc and does error path resource releasing
in ip2_init_board. All in drivers/char/ip2main.c and against
245ac16.
(The kmalloc part of
Hi.
The patch below adds one instance of vmalloc return code checking
and a number of error path resource release cleanups in build_maps.
It is against 245-ac16.
(The vmalloc non-check was reported by the Stanford team a
while back.)
--- linux-245-ac16-clean/drivers/mtd/ftl.c Sun May 27
On Fri, Jun 22, 2001 at 05:21:06PM -0300, Arnaldo Carvalho de Melo wrote:
Hi Rasmus,
I've fixed this ones and its already in 2.4.6-pre5, please take a
look and see if something is missing.
These patches are very close so I'll of course retract mine[1].
The only thing I'll recommend is
Hi.
The patch below adds a kmalloc check to drivers/pcmcmia/rsrc_mgr.c.
Against 245-ac16 but aplies to 256p6 also. Reported a while back
by the stanford team.
--- linux-245-ac16-clean/drivers/pcmcia/rsrc_mgr.c Sat May 19 20:59:21 2001
+++ linux-245-ac16/drivers/pcmcia/rsrc_mgr.cSat
Hi.
The following patch adds some checks for kmalloc returning NULL
to fs/jffs/intrep.c along with some way of getting that propagated
back. Applies against 245ac16 and 246p5. These dereferences were
reported by the Stanford team a way back.
--- linux-245-ac16-clean/fs/jffs/intrep.c Thu
On Sat, Jun 23, 2001 at 02:30:06PM -0300, Arnaldo Carvalho de Melo wrote:
[...]
printk(KERN_ERR __FUNCTION__ Out of memory.);
Then if you move the code to other function or if you change the name of
the function you don't have to go all over the code doing
On Sun, Jun 24, 2001 at 10:52:31PM +0200, Eric Lammerts wrote:
[...]
There are zillions of functions called 'init_module' in the kernel.
I think my suggestion was better (and it had a \n at the end!)
Agreed. Actually, 'ouch' on point two :) BTW, was it intentional
that you dropped the
Hi.
(My last mail to [EMAIL PROTECTED] bounced. Is there another
maintainer for drivers/char/ip2main.c somewhere?)
The patch below tries to avoid dereferencing (potential)
NULL pointers. It was reported by the Stanford team way
back and applies against 245ac16 and 246p6. It could
probably be
Hi.
The following patch tries to avoid a potential null pointer
dereference. It applies against 245-ac16 and 246p6. The
dereference was originally reported by the Stanford team.
--- linux-245-ac16-clean/drivers/media/video/i2c-parport.c Thu Jul 13 01:24:33
2000
+++
On Sun, Jun 24, 2001 at 07:14:00PM -0400, Michael H. Warfield wrote:
On Sun, Jun 24, 2001 at 11:06:06PM +0200, Rasmus Andersen wrote:
Hi.
(My last mail to [EMAIL PROTECTED] bounced. Is there another
maintainer for drivers/char/ip2main.c somewhere?)
I'm still here. :-) Just
On Sun, Jun 24, 2001 at 07:14:00PM -0400, Michael H. Warfield wrote:
[...]
I'm responsible for the kernel / driver integration end of it
anyways.
I'll find out what's up with Doug, but this is my issue to deal
with anyways. And yes, I'm looking at it. I've got a couple of
Hi.
This patch tries to fix the potential rss accounting race where we
change mm-rss without holding page_table_lock.
My reasoning for the correctness of the patch below is as follows.
First I cover the lock pairs added by the patch (top to bottom)
and then the places it does not touch.
Hi.
For some time up through the testX kernels I used rsync to
update my "dirty" tree after applying the latest patches to the
clean tree. At some point this stopped working (more about that
later) but as new kernels were coming fast at that time I did
not think much of it, assuming that
On Mon, Feb 19, 2001 at 11:09:33PM +0100, Rasmus Andersen wrote:
[...]
(I'll just continue talking to myself in the hope that somebody
will read this and be inspired.)
In order to clear things up I should clearly state that my rsync
problem manifests itself under local operation. Ie., 'rsync
Hi.
(I have not been able to find a probable current maintainer for
this code.)
The following patch makes drivers/scsi/seagate.c use ioremap
instead of isa_{read, write} (I have not been able to find
a fitting place to put an iounmap since the driver does not
have a release function). The patch
Hello,
Let me first start by saying that if a better place to ask these
quesions is to be found, please let me know.
I have a 2.6.20 kernel running a raid 1 set with two SATA disks.
Recently (on an older (gentoo-specific) kernel) I started getting
entries like this after my weekly 'echo check
Hi.
The patch below adds a check for create_proc_entry return code
in drivers/media/video/videodev.c. It applies against 245-ac16
and 246p6.
--- linux-245-ac16-clean/drivers/media/video/videodev.c Sun May 27 22:15:23 2001
+++ linux-245-ac16/drivers/media/video/videodev.c Sun Jun 24
Hi.
The following patch makes drivers/net/tokenring/ibmtr.c
call iounmap before it returns on error paths, makes it
not use check_region(), makes it check the return
of request_region and init_trdev and adds a few comment
strings on #endifs.
It applies against 246ac5 and my writing this patch
Hello,
I was hoping that you could help me interpret these SATA errors from my
brand new Western Digital disk (at end). Also, this disk seems to refuse
smart commands:
# smartctl -s on -o on -S on /dev/sda
smartctl version 5.37 [i686-pc-linux-gnu] Copyright (C) 2002-6 Bruce
Allen
Home page is
Hello,
I have just upgraded from 2.6.22 to 2.6.24.2 and after booting into the
new kernel and seeing that everything went right, I wanted to make the
new kernel the default boot kernel. But running LILO I got
Fatal: Linux experimental device 0x04x needs to be defined.
Check 'man lilo.conf'
On Tue, Feb 19, 2008 at 09:22:27AM -0800, H. Peter Anvin wrote:
Rasmus Andersen wrote:
[...]
You have at least one file on a device mapper device (possibly an LVM
module), and LILO doesn't understand it.
Hi Peter, and thanks for your reply. That was indeed the issue, my /boot
was not mounted
Hello,
I have for some time been facing some RAID1 issues which I finally have
been able to take the time to write about. I hope you can help me shed
some light on this.
My main problem is that a check/repair run of my RAID1 device reports
errors. Not always the same number of errors and not
On Mon, May 28, 2007 at 11:57:55AM +0200, Rasmus Andersen wrote:
My main problem is that a check/repair run of my RAID1 device reports
errors. Not always the same number of errors and not monotonously
increasing. It has not always been like this but I have not been able to
link this to any
Disclaimer: I know nothing of this device/hw, the scsi protocol or
anything remotely applicable the functioning of this driver. The
stuff below is just nit-picking and PITA-ing :) Pro-active kernel
janitoring, if you like.
On Sat, May 12, 2001 at 11:43:04AM -0500, James Bottomley wrote:
[...]
>
Hi.
The following trivial patch against 2.4.4(-ac11) makes ps2esdi compile.
--- linux-244-ac10-clean/drivers/block/ps2esdi.cSat May 19 21:06:29 2001
+++ linux-244-ac10/drivers/block/ps2esdi.c Sun May 20 14:47:04 2001
@@ -953,10 +953,10 @@
break;
}
On Thu, May 24, 2001 at 09:00:20AM -0700, Jonathan Lundell wrote:
[...]
>
> Fine. But:
>
> At 3:02 AM +0200 2001-05-24, Andrzej Krzysztofowicz wrote:
> >-printk(version);
> >+#ifdef MODULE
> >+printk("s", version);
> > printed_version = 1;
> >+#endif /* MODULE */
>
> ...is playing
Hi.
The following patch changes an __init to an __initdata. Applies
against 2.4.4-ac16.
--- linux-244-ac16-clean/arch/ppc/kernel/feature.c Sat May 19 21:06:18 2001+++
linux-244-ac16/arch/ppc/kernel/feature.cMon May 21 00:04:35 2001
@@ -267,7 +267,7 @@
static struct board_features_t
Hi.
This patch adds a check for the return value from kmalloc in
ide_cdrom_open. Applies against ac16.
--- linux-244-ac16-clean/drivers/ide/ide-cd.c Fri May 25 21:11:08 2001
+++ linux-244-ac16/drivers/ide/ide-cd.c Fri May 25 21:30:20 2001
@@ -2869,12 +2869,12 @@
int ide_cdrom_open (struct
Hi.
The following patch adds a number of checks for kmalloc returns
to drivers/ide/ide-probe.c. It applies against ac16.
One comment: This patch adds 'drive-present = 0' to the
code path for the EXABYTE case. I could not discern if this was a
shortcoming of the original code or not. Please
Hi.
This trivial patch adds a kmalloc check to ide-tape.c::
idetape_onstream_read_back_buffer as per the Stanford team's report
way back. It applies against 244ac16.
Reading the code I was not sure if it was OK to just return
or more should be done. Please sanity check this.
---
On Fri, May 25, 2001 at 01:47:52PM -0700, Andre Hedrick wrote:
>
> Not valid because the jump to that part of the code is protected.
> If a polling response for a valid status and no timeout, is detected then
> it attempts to the command for real only after success or a test.
>
> Otherwise it
(I forgot to cc l-k on this one when it went to andre.)
Hi.
This patch adds a spin_unlock_irqsave to ide_spin_wait_hwgroup as
reported by the Stanford team way back. It applies against 244ac16.
--- linux-244-ac16-clean/drivers/ide/ide.c Fri May 25 21:11:08 2001
+++
Hi.
The following patch changes an __init to __initdata. Applies against
2.4.4-ac11.
--- linux-244-ac11-clean/drivers/video/matrox/matroxfb_base.c Sat May 19 20:58:43
2001
+++ linux-244-ac11/drivers/video/matrox/matroxfb_base.c Sun May 20 23:55:24 2001
@@ -2483,7 +2483,7 @@
return
On Fri, May 25, 2001 at 11:11:23PM +0200, Jens Axboe wrote:
[...]
> This isn't right. Granted the locking isn't straight forward here, but
> take a look at ide_write_setting -> ide_spin_wait_hwgroup and the
> latters return value.
Yes, Andre set me straight here. My apologies for being lazy
(Forgot l-k when sending this off to [EMAIL PROTECTED] :/)
Hi.
The following patch tries to eliminate the interrupt flag bugs
identified by the stanford team a while back in drivers/net/wan/
comx-hw-mixcom.c. It moves request_region and request_irq outside
the cli()/restore_flags() pair as they
Forgot l-k when sending this off...
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Hi.
The following patch fixes a buggy variable reuse i drivers/char/
rio/riotable.c (244-ac18) as reported by the stanford team way
back.
--- linux-244-ac18-clean/drivers/ch
Forgot l-k when sending this off..
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Hi.
The following patch fixes a missing rio_spin_unlock_irqrestore
in drivers/char/rio/rioroute.c as per the stanford team's
report a way back. It applies against 244ac18.
--- lin
Hi.
The following patch adds a missing restore_flags as per the
stanford team's report way back. Applies against 244ac18.
--- linux-244-ac18-clean/drivers/net/hamradio/soundmodem/sm_wss.c Wed Jul 19
01:55:19 2000
+++ linux-244-ac18/drivers/net/hamradio/soundmodem/sm_wss.c Sun May 27
Hi.
The following patch tries to correct the interrupt bugs found
by the stanford team a long time ago in drivers/net/irda/irport.c.
Applies against 2.4.4-ac18.
--- linux-244-ac18-clean/drivers/net/irda/irport.c Sat May 19 20:59:17 2001
+++ linux-244-ac18/drivers/net/irda/irport.cSat
(Forgot l-k again... :<)
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Hi.
The following patch removes two superfluous initializations
from aironet4500_proc.c, making the .o ~12K smaller in
size. It applies against 245ac1 and was discovered by Adam
Ritcher
101 - 200 of 388 matches
Mail list logo
