Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-20 Thread Reji Thomas
> End.X, > > End.DX6 or End.DX4 (we are submiting in the next couple of days to support > > End.DX4). > > > > We can submit the optional parameter again. Then Reji can leverage this to > > provide OIF > > as an optional parameters. > > > > Wou

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-20 Thread Reji Thomas
On Mon, Oct 19, 2020 at 9:47 PM Jakub Kicinski wrote: > > If we can save the device lookup and still be semantically correct, > that's probably better. I am afraid we need to do a device lookup if I am looking up the neighbor. neigh_lookup apis expect dev to be passed. If I go through the current

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-18 Thread Reji Thomas
Hi, Please find my replies inline below. Regards Reji On Mon, Oct 19, 2020 at 4:31 AM Jakub Kicinski wrote: > > On Thu, 15 Oct 2020 13:51:19 +0530 Reji Thomas wrote: > > Currently End.X action doesn't consider the outgoing interface > > while looking up the nexthop.This

[PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-15 Thread Reji Thomas
seems this is a day one issue. Fixes: 140f04c33bbc ("ipv6: sr: implement several seg6local actions") Signed-off-by: Reji Thomas --- Changes in v2: - Fixed seg6_strict_lookup_nexthop() to be a static function Reported-by: kernel test robot - Fixed comments from Jakub Kicinski

[PATCH] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-13 Thread Reji Thomas
seems this is a day one issue. Fixes: 140f04c33bbc ("implement several seg6local actions") Signed-off-by: Reji Thomas --- net/ipv6/seg6_local.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_loc

[PATCH SRv6 End.X] Signed-off-by: Reji Thomas

2020-10-12 Thread Reji Thomas
seg6: Fix End.X nexthop to use oif. Currently End.X action doesn't consider the outgoing interface while looking up the nexthop.This breaks packet path functionality while using link local address as the End.X nexthop.The patch fixes this for link local addresses. Signed-off-by: Reji Thomas