> +static void sensor_hub_fill_attr_info(
> + struct hid_sensor_hub_attribute_info *info,
> + s32 index, s32 report_id, struct hid_field *field)
> +{
> + info->index = index;
> + info->report_id = report_id;
> + info->units = field->unit;
> +
, May 28, 2014 at 4:25 PM, Srinivas Pandruvada
wrote:
> On 05/28/2014 02:15 PM, Reyad Attiyat wrote:
>>>
>>> +static void sensor_hub_fill_attr_info(
>>> + struct hid_sensor_hub_attribute_info *info,
>>> + s32 index,
Forgot to forward to list
-- Forwarded message --
From: Reyad Attiyat
Date: Wed, May 28, 2014 at 4:57 PM
Subject: Re: [PATCH 3/3] IO: hid-sensor-magn-3d: Add in support for
True/Magnetic North HID usages
To: Srinivas Pandruvada
Hey Srinivas,
> It shouldn't be an is
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git a/drivers/iio
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Changes from v4
Removed the scan index as this is set dynamically
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 53 ++-
1 file changed, 52
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b
formatting
Added comment about magn_val_addr and iio_vals
Added more debugging information and checks
Removed static initalizing of scan_index, it is now set dynamically
Use struct iio_chan_spec address field to store magn array index (could be set
statically)
Signed-off-by: Reyad Attiyat
---
drivers
attribute. The scan_index field is generated when creating
an iio channel.
Reyad Attiyat (4):
iio: Documentation: Add documentation for rotation from north sensor
usage attributes
iio: types: Added support for rotation from north usage attributes
iio: hid-sensor-magn-3d: Scan for usage
ion and
don't believe it needs any other changes
Thanks.
On Wed, Jul 9, 2014 at 2:30 PM, Reyad Attiyat wrote:
> Scan for and count the HID usage attributes supported by the driver.
> This allows for the driver to only setup the IIO channels for the
> sensor usages present in the HID
parse_report returns (-EINVAL or -ENOMEM) in probe
Thanks,
Reyad Attiyat
On Wed, Jul 9, 2014 at 2:45 PM, Srinivas Pandruvada
wrote:
> On 07/09/2014 12:30 PM, Reyad Attiyat wrote:
>>
>> This series of patches modifies magn-3d driver to handle the rotation
>> from nort
Hey Jonathan,
Thanks for the review. I'll be sure to fix up all the formatting you
mentioned and run it through the checkpatch.pl script.
> There should be an explanation here of what has changed from one version to
> the
> next.
Will include updates in future patch notes.
> The patches should
ou review your logic?
> It is possible that platforms don't have all attributes, so looks
> like the probe is returnning with error.
>
>
> On 07/07/2014 09:44 AM, Jonathan Cameron wrote:
>>
>> On 30/06/14 03:58, Reyad Attiyat wrote:
>>>
>>> Scan for and
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b
the values from the static array
of
IIO configurations. There is also an array used to store each channel IIO value
pointer for each HID usage attribute.
Reyad Attiyat (4):
iio: Documentation: Add documentation for rotation from north sensor
usage attributes
iio: types: Added support
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 58 ++-
1 file changed, 57 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/magnetometer/hid
Scan for and count the HID usage attributes supported by the driver.
This allows for the driver to only setup the IIO channels for the
sensor usages present in the HID USB reports.
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 111 +-
1
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git a/drivers/iio
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git a/drivers/iio
Added the ability for this driver to scan for a range of hid usage attributes.
This allows for dynamic creation of iio channels such as rotation from north
and/or magnetic flux axises (X, Y, Z).
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 394
channel and value arrays
Use proper return errors (-EINVAL) and (-ENOMEM)
Reyad Attiyat (3):
iio: documentation: Added documentation for rotation from north usage
attributes
iio: types: Added support for rotation from north usage attributes
iio: hid-sensor-magn-3d: Add support
Added documentation for the sysfs attributes added by the rotation from north
usage attributes.
Signed-off-by: Reyad Attiyat
---
Documentation/ABI/testing/sysfs-bus-iio | 79 -
1 file changed, 78 insertions(+), 1 deletion(-)
diff --git a/Documentation/ABI
---
drivers/hid/hid-ids.h| 3 +++
drivers/hid/hid-sensor-hub.c | 8
2 files changed, 11 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 34bb220..18e2099 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -633,6 +633,9 @@
#define
---
drivers/hid/hid-debug.c | 79 +
1 file changed, 79 insertions(+)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index 53b771d..25cc71c 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -272,6 +272,85 @@
Changes all dyn_callback_lock spinlocks to spinlocks that disable
interrupts. The dynamic callback lock (dyn_callback_lock) must not be
interrupted when locked as it is used in an interrupt handler
function, sensor_hub_raw_event.
---
drivers/hid/hid-sensor-hub.c | 31
Ignore this patch I'll have to resend
On Tue, May 13, 2014 at 7:53 PM, Reyad Attiyat wrote:
> ---
> drivers/hid/hid-ids.h| 3 +++
> drivers/hid/hid-sensor-hub.c | 8
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid
---
drivers/hid/hid-ids.h| 3 +++
drivers/hid/hid-sensor-hub.c | 9 +
2 files changed, 12 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 34bb220..18e2099 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -633,6 +633,9 @@
#define
Here is a sample of the kernel lockdep warning I got after turingon
dynamic debugging:
https://bugzilla.kernel.org/show_bug.cgi?id=73321#c3
On Tue, May 13, 2014 at 8:03 PM, Reyad Attiyat wrote:
> Changes all dyn_callback_lock spinlocks to spinlocks that disable
> interrupts. The d
://bugzilla.kernel.org/show_bug.cgi?id=73321#c7
I'd be willing to work on this. Just wanted to know what would work best
Thank You,
Reyad Attiyat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
tached diff, which will fix this.
>
> Thanks,
> Srinivas
>
>
> On 07/09/2014 03:12 PM, Reyad Attiyat wrote:
>>
>> Hey Srinivas,
>>
>> I did look into the panic you sent. I wasn't sure exactly what caused
>> the NULL pointer.
>> I tested it w
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 53 ++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/magnetometer/hid
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b
-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 149 ++
1 file changed, 105 insertions(+), 44 deletions(-)
diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
index b2b0937..d3b9114 100644
This series of patches modifies magn-3d driver to handle the rotation
from north usage. This is done by scanning the report and then building
the iio arrays (vals and channels) dynamically.
Changes from V5
- Fix kernel panics from dereference
Reyad Attiyat (4):
iio: Documentation: Add
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git a/drivers/iio
Signed-off-by: Reyad Attiyat
Acked-by: Srinivas Pandruvada
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 152 ++
1 file changed, 105 insertions(+), 47 deletions(-)
diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
b/drivers/iio/magnetometer/hid-sensor
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat
Acked-by: Srinivas Pandruvada
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Signed-off-by: Reyad Attiyat
Acked-by: Srinivas Pandruvada
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 53 ++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff --git
to iio_push_to_buffer
Reyad Attiyat (4):
iio: Documentation: Add documentation for rotation from north sensor
usage attributes
iio: types: Added support for rotation from north usage attributes
iio: hid-sensor-magn-3d: Scan for usage attributes before setting up
iio channels
iio: hid-sensor-magn
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat
Acked-by: Srinivas Pandruvada
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation
Set disconnected flag in struct usbhid when a usb device
is removed. Check for disconnected flag before sending urb
requests. This prevents a kernel panic when a hid driver calls
hid_hw_request() after removing a usb device.
Signed-off-by: Reyad Attiyat
---
drivers/hid/usbhid/hid-core.c | 6
at 12:13 AM, Reyad Attiyat wrote:
> Set disconnected flag in struct usbhid when a usb device
> is removed. Check for disconnected flag before sending urb
> requests. This prevents a kernel panic when a hid driver calls
> hid_hw_request() after removing a usb device.
>
> Signed-off
Fix build warning, sizeof() called on dynamically
sized pointer, by removing the call and the dependent
function parameter. It is not needed or used in this
driver, when pushing values to an iio buffer.
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 7
Whoops looks like I typed an extra character, sorry should have caught this.
Thanks Sirinivas will resend.
On Fri, Jul 25, 2014 at 2:52 PM, Srinivas Pandruvada
wrote:
> On 07/25/2014 12:32 PM, Reyad Attiyat wrote:
>>
>> Fix build warning, sizeof() called on dynamically
&
Fix build warning, sizeof() called on dynamically
sized pointer, by removing the call and the dependent
function parameter. It is not needed or used in this
driver, when pushing values to an iio buffer.
Changes from v1
- Fix mistake in varible name
Signed-off-by: Reyad Attiyat
---
drivers/iio
Thanks for the review. I don't believe many devices have this problem
no need to rush it.
On Sun, Jul 19, 2015 at 7:57 AM, Jonathan Cameron wrote:
> On 15/07/15 08:43, Reyad Attiyat wrote:
>> Some devices on a hid sensor hub will not report a measurement unit. This
>> causes th
Some devices on a hid sensor hub will not report a measurement unit. This
causes the rotation from north channels to have an incorrect scale value.
This patch will set the unit to degrees if the maximum value is 360 when
the unit exponent value is accounted for.
Signed-off-by: Reyad Attiyat
these checks as well to keep in line with the their
implementation.
Do you think this is the best method for creating a zero-length
packet, will every trb convert into at least one endpoint packet?
Thank you,
Reyad Attiyat
On Mon, Jun 29, 2015 at 10:48 AM, Mathias Nyman wrote:
> Hi
>
> On 2
This commit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length is a multiple of the endpoint's
max packet length.
Signed-off-by: Reyad Attiyat
---
drivers/usb/host/xhci-ring.c | 66 ++--
drivers/usb/host
once as there is a check in finish_td() to
ensure that all td's have been received.
If you think I should change anything else please let me know.
Thank you,
Reyad Attiyat
On Thu, Jul 2, 2015 at 1:54 PM, Reyad Attiyat wrote:
> This commit checks for the URB_ZERO_PACKET flag and creates an ex
The newer frimware on MS Surface 2 tablets causes the type and touch cover
keyboards to timeout when waiting for reports.
Signed-off-by: Reyad Attiyat
---
drivers/hid/usbhid/hid-quirks.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid
This is missing a device ID I will need to resubmit
Sorry,
Reyad Attiyat
On Fri, Jun 26, 2015 at 1:00 AM, Reyad Attiyat wrote:
> The newer frimware on MS Surface 2 tablets causes the type and touch cover
> keyboards to timeout when waiting for reports.
>
> Signed-off-by: R
The newer firmware on MS Surface 2 tablets causes the type and touch cover
keyboards to timeout when waiting for reports.
The quirk HID_QUIRK_NO_INIT_REPORTS allows them to function normally.
Signed-off-by: Reyad Attiyat
---
drivers/hid/usbhid/hid-quirks.c | 3 +++
1 file changed, 3 insertions
This commit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length is a multiple of the endpoint
max packet length.
Signed-off-by: Reyad Attiyat
---
drivers/usb/host/xhci-ring.c | 41 -
1 file changed, 32
Sorry I have forgotten to change the dp loop check line in the bulk_sg
function. Will resubmit.
On Sun, Jun 28, 2015 at 7:36 PM, Reyad Attiyat wrote:
> This commit checks for the URB_ZERO_PACKET flag and creates an extra
> zero-length td if the urb transfer length is a multiple of the en
This commmit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length is a multiple of the endpoint's
max packet length.
Signed-off-by: Reyad Attiyat
---
drivers/usb/host/xhci-ring.c | 43 +--
1 file changed, 33
]---
Signed-off-by: Reyad Attiyat
---
drivers/net/wireless/mwifiex/usb.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mwifiex/usb.c
b/drivers/net/wireless/mwifiex/usb.c
index fd8027f..cd3ba76 100644
--- a/drivers/net/wireless/mwifiex/usb.c
+++ b
101 - 156 of 156 matches
Mail list logo