[PATCH v2 11/11] clk: tegra: WARN if clk in the init_table has enable

2016-05-27 Thread Rhyland Klein
Enabling clocks through the init_table mechanism is deprecated. Clocks that need to be enabled early and stay on should be marked as CRITICAL. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/clk

[PATCH v2 11/11] clk: tegra: WARN if clk in the init_table has enable

2016-05-27 Thread Rhyland Klein
Enabling clocks through the init_table mechanism is deprecated. Clocks that need to be enabled early and stay on should be marked as CRITICAL. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/clk/tegra/clk.c b/drivers/clk

[PATCH v2 00/11] Switch to using CRITICAL clks for Tegra

2016-05-27 Thread Rhyland Klein
to be able to easily tell what clks are CRITICAL through the table. I added a warning for using the init_table to enable clks. I considered removing it entirely, but I thought phasing it out might be better. Rhyland Klein (11): clk: tegra: Switch to using critical clks clk: tegra20: Mark required clks

[PATCH v2 07/11] clk: tegra124: clean up init_table

2016-05-27 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein <

[PATCH v2 07/11] clk: tegra124: clean up init_table

2016-05-27 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein --- drivers

[PATCH v2 00/11] Switch to using CRITICAL clks for Tegra

2016-05-27 Thread Rhyland Klein
to be able to easily tell what clks are CRITICAL through the table. I added a warning for using the init_table to enable clks. I considered removing it entirely, but I thought phasing it out might be better. Rhyland Klein (11): clk: tegra: Switch to using critical clks clk: tegra20: Mark required clks

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-05-27 Thread Rhyland Klein
On 5/12/2016 1:52 PM, Laxman Dewangan wrote: > > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: >> When configuring FPS during probe, assuming a DT node is present for >> FPS, the code can run into a problem with the switch statements in >

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-05-27 Thread Rhyland Klein
On 5/12/2016 1:52 PM, Laxman Dewangan wrote: > > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: >> When configuring FPS during probe, assuming a DT node is present for >> FPS, the code can run into a problem with the switch statements in >

[PATCH v5] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-05-26 Thread Rhyland Klein
version: define UTMIP_PLL_CFG1_ENABLE_DLY_COUNT(x) (((x) & 0x1f) << 27) which matches the Tegra124 TRM register definition. Signed-off-by: Andrew Bresticker <abres...@chromium.org> [rklein: Merged in some later fixes for potential deadlocks] Signed-off-by: Rhyland Klein <rkl...

[PATCH v5] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-05-26 Thread Rhyland Klein
n: define UTMIP_PLL_CFG1_ENABLE_DLY_COUNT(x) (((x) & 0x1f) << 27) which matches the Tegra124 TRM register definition. Signed-off-by: Andrew Bresticker [rklein: Merged in some later fixes for potential deadlocks] Signed-off-by: Rhyland Klein --- v5: - Initialized flags to 0 to avoid harmless spinlock warni

[PATCH 01/11] clk: tegra: Switch to using critical/handoff clks

2016-05-25 Thread Rhyland Klein
ort is less in mainline and some clks might not be requested then Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk-tegra-periph.c | 21 ++--- drivers/clk/tegra/clk-tegra-super-gen4.c | 12 +++- 2 files changed, 21 insertions(+), 12 deletions

[PATCH 02/11] clk: tegra20: Mark required clks as CRITICAL

2016-05-25 Thread Rhyland Klein
Mark clks that are required to be on as CRITICAL clks. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk-tegra20.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c

[PATCH 01/11] clk: tegra: Switch to using critical/handoff clks

2016-05-25 Thread Rhyland Klein
ort is less in mainline and some clks might not be requested then Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-tegra-periph.c | 21 ++--- drivers/clk/tegra/clk-tegra-super-gen4.c | 12 +++- 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/drivers/

[PATCH 02/11] clk: tegra20: Mark required clks as CRITICAL

2016-05-25 Thread Rhyland Klein
Mark clks that are required to be on as CRITICAL clks. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-tegra20.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c index 837e5cbd60e9

[PATCH 06/11] clk: tegra114: clean up init_table

2016-05-25 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein <

[PATCH 06/11] clk: tegra114: clean up init_table

2016-05-25 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein --- drivers

[PATCH 03/11] clk: tegra20: clean up init_table

2016-05-25 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein <

[PATCH 03/11] clk: tegra20: clean up init_table

2016-05-25 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein --- drivers

[PATCH 09/11] clk: tegra210: clean up init_table

2016-05-25 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein <

[PATCH 05/11] clk: tegra30: clean up init_table

2016-05-25 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein <

[PATCH 09/11] clk: tegra210: clean up init_table

2016-05-25 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein --- drivers

[PATCH 05/11] clk: tegra30: clean up init_table

2016-05-25 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein --- drivers

[PATCH 07/11] clk: tegra124: clean up init_table

2016-05-25 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein <

[PATCH 07/11] clk: tegra124: clean up init_table

2016-05-25 Thread Rhyland Klein
Remove entries from the init_table where the clks are now defined as CRITICAL clks, if we were only enabling them in the init_table. Remove the flag to signal to enable CRITICAL clks if they are still needed in the init_table to set other properties. Signed-off-by: Rhyland Klein --- drivers

[PATCH 08/11] clk: tegra210: Mark required clks as CRITICAL

2016-05-25 Thread Rhyland Klein
Mark clks that are required to be on as CRITICAL clks. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk-tegra210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c index b85518

[PATCH 11/11] clk: tegra: WARN if clk in the init_table has enable

2016-05-25 Thread Rhyland Klein
Enabling clocks through the init_table mechanism is deprecated. Clocks that need to be enabled early and stay on should be marked as CRITICAL. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/clk

[PATCH 04/11] clk: tegra30: Mark certain clks as critical

2016-05-25 Thread Rhyland Klein
Mark the required clks as critical so the core will enable them during registration and therefore they will stay on. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk-tegra30.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH 08/11] clk: tegra210: Mark required clks as CRITICAL

2016-05-25 Thread Rhyland Klein
Mark clks that are required to be on as CRITICAL clks. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-tegra210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c index b8551813ec43..156dc8ec6bf6

[PATCH 11/11] clk: tegra: WARN if clk in the init_table has enable

2016-05-25 Thread Rhyland Klein
Enabling clocks through the init_table mechanism is deprecated. Clocks that need to be enabled early and stay on should be marked as CRITICAL. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/clk/tegra/clk.c b/drivers/clk

[PATCH 04/11] clk: tegra30: Mark certain clks as critical

2016-05-25 Thread Rhyland Klein
Mark the required clks as critical so the core will enable them during registration and therefore they will stay on. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-tegra30.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra30

[PATCH 10/11] clk: Show CRITICAL clks in clk_summary output

2016-05-25 Thread Rhyland Klein
Add a '^' character to the beginning of clk entries that are for CRITICAL clks. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/clk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 874c7dd8ef66..22dd0c

[PATCH 10/11] clk: Show CRITICAL clks in clk_summary output

2016-05-25 Thread Rhyland Klein
Add a '^' character to the beginning of clk entries that are for CRITICAL clks. Signed-off-by: Rhyland Klein --- drivers/clk/clk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 874c7dd8ef66..22dd0ca1e491 100644

[PATCH 00/11] Switch to using CRITICAL clks for Tegra

2016-05-25 Thread Rhyland Klein
to be able to easily tell what clks are CRITICAL through the table. I added a warning for using the init_table to enable clks. I considered removing it entirely, but I thought phasing it out might be better. Rhyland Klein (11): clk: tegra: Switch to using critical/handoff clks clk: tegra20: Mark

[PATCH 00/11] Switch to using CRITICAL clks for Tegra

2016-05-25 Thread Rhyland Klein
to be able to easily tell what clks are CRITICAL through the table. I added a warning for using the init_table to enable clks. I considered removing it entirely, but I thought phasing it out might be better. Rhyland Klein (11): clk: tegra: Switch to using critical/handoff clks clk: tegra20: Mark

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 1:26 PM, Jon Hunter wrote: > > On 25/05/16 17:36, Rhyland Klein wrote: > > ... > >> I can see that getting the temperature could work. I would point out >> that I don't see any recent changes to bq27xxx or the power_supply_core >> that would imp

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 1:26 PM, Jon Hunter wrote: > > On 25/05/16 17:36, Rhyland Klein wrote: > > ... > >> I can see that getting the temperature could work. I would point out >> that I don't see any recent changes to bq27xxx or the power_supply_core >> that would imp

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 12:29 PM, Jon Hunter wrote: > > On 25/05/16 17:10, Jon Hunter wrote: > > ... > >> So power_supply_read_temp() calls ->get_property() and passes the >> power_supply psy struct which is initialised. The problem is that inside >> the bq27xxx driver, this then kicks off the worker

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 12:29 PM, Jon Hunter wrote: > > On 25/05/16 17:10, Jon Hunter wrote: > > ... > >> So power_supply_read_temp() calls ->get_property() and passes the >> power_supply psy struct which is initialised. The problem is that inside >> the bq27xxx driver, this then kicks off the worker

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 11:46 AM, Thierry Reding wrote: > On Wed, May 25, 2016 at 12:03:47PM +0100, Jon Hunter wrote: >> >> On 25/05/16 11:58, Jon Hunter wrote: >> >> ... >> >>> Looking at this a bit more I am wondering if we should prevent the >>> battery for being polled before the registration has

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 11:46 AM, Thierry Reding wrote: > On Wed, May 25, 2016 at 12:03:47PM +0100, Jon Hunter wrote: >> >> On 25/05/16 11:58, Jon Hunter wrote: >> >> ... >> >>> Looking at this a bit more I am wondering if we should prevent the >>> battery for being polled before the registration has

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 7:03 AM, Jon Hunter wrote: > > On 25/05/16 11:58, Jon Hunter wrote: > > ... I am aware of the splat, and I was considering the proper place for working around that. > >> Looking at this a bit more I am wondering if we should prevent the >> battery for being polled before the

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 7:03 AM, Jon Hunter wrote: > > On 25/05/16 11:58, Jon Hunter wrote: > > ... I am aware of the splat, and I was considering the proper place for working around that. > >> Looking at this a bit more I am wondering if we should prevent the >> battery for being polled before the

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-24 Thread Rhyland Klein
On 5/24/2016 10:09 AM, Jon Hunter wrote: > Hi Rhyland, > > On 03/05/16 16:45, Rhyland Klein wrote: >> Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and >> the BA27XXX battery driver. These are all used on the Tegra210 Smaug >> platform. >> >

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-24 Thread Rhyland Klein
On 5/24/2016 10:09 AM, Jon Hunter wrote: > Hi Rhyland, > > On 03/05/16 16:45, Rhyland Klein wrote: >> Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and >> the BA27XXX battery driver. These are all used on the Tegra210 Smaug >> platform. >> >&g

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-19 Thread Rhyland Klein
On 5/3/2016 11:45 AM, Rhyland Klein wrote: > Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and > the BA27XXX battery driver. These are all used on the Tegra210 Smaug > platform. > > Signed-off-by: Rhyland Klein <rkl...@nvidia.com> Has anyone had a chan

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-19 Thread Rhyland Klein
On 5/3/2016 11:45 AM, Rhyland Klein wrote: > Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and > the BA27XXX battery driver. These are all used on the Tegra210 Smaug > platform. > > Signed-off-by: Rhyland Klein Has anyone had a chance to review this

Re: drivers/of: crash on boot

2016-05-18 Thread Rhyland Klein
On 5/18/2016 3:58 PM, Rhyland Klein wrote: > On 5/18/2016 3:36 PM, Rob Herring wrote: >> On Wed, May 18, 2016 at 10:34 AM, Sasha Levin <sasha.le...@oracle.com> wrote: >>> Hi Rhyland, >>> >>> I'm seeing a crash on boot that seems to have been caused by &g

Re: drivers/of: crash on boot

2016-05-18 Thread Rhyland Klein
On 5/18/2016 3:58 PM, Rhyland Klein wrote: > On 5/18/2016 3:36 PM, Rob Herring wrote: >> On Wed, May 18, 2016 at 10:34 AM, Sasha Levin wrote: >>> Hi Rhyland, >>> >>> I'm seeing a crash on boot that seems to have been caused by >>> "

Re: drivers/of: crash on boot

2016-05-18 Thread Rhyland Klein
On 5/18/2016 3:36 PM, Rob Herring wrote: > On Wed, May 18, 2016 at 10:34 AM, Sasha Levin wrote: >> Hi Rhyland, >> >> I'm seeing a crash on boot that seems to have been caused by >> "drivers/of: Fix depth when unflattening devicetree": >> >> [ 61.145229] >>

Re: drivers/of: crash on boot

2016-05-18 Thread Rhyland Klein
On 5/18/2016 3:36 PM, Rob Herring wrote: > On Wed, May 18, 2016 at 10:34 AM, Sasha Levin wrote: >> Hi Rhyland, >> >> I'm seeing a crash on boot that seems to have been caused by >> "drivers/of: Fix depth when unflattening devicetree": >> >> [ 61.145229] >>

[PATCH] mfd: max77620: Fix FPS switch statements

2016-05-12 Thread Rhyland Klein
all through to the default switch case and return -EINVAL. Returning this from max77620_config_fps() will cause probe to fail. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/mfd/max77620.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/max77620.c b/drivers/mfd/m

[PATCH] mfd: max77620: Fix FPS switch statements

2016-05-12 Thread Rhyland Klein
all through to the default switch case and return -EINVAL. Returning this from max77620_config_fps() will cause probe to fail. Signed-off-by: Rhyland Klein --- drivers/mfd/max77620.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index 199d26199

[PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-03 Thread Rhyland Klein
Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and the BA27XXX battery driver. These are all used on the Tegra210 Smaug platform. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- arch/arm64/configs/defconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch

[PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-03 Thread Rhyland Klein
Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and the BA27XXX battery driver. These are all used on the Tegra210 Smaug platform. Signed-off-by: Rhyland Klein --- arch/arm64/configs/defconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/configs/defconfig b

Re: [PATCH 1/1] pinctrl: tegra: avoid parked_reg and parked_bank

2016-05-02 Thread Rhyland Klein
On 5/2/2016 10:28 AM, Laxman Dewangan wrote: > NVIDIA's Tegra210 support the park bit to make pinmux configuration > enable/disable. If parked bit is 1 then configuration does not apply > and if it is 0 then pinmux configuration applies. This is to support > to avoid any glitch in pinmux

Re: [PATCH 1/1] pinctrl: tegra: avoid parked_reg and parked_bank

2016-05-02 Thread Rhyland Klein
On 5/2/2016 10:28 AM, Laxman Dewangan wrote: > NVIDIA's Tegra210 support the park bit to make pinmux configuration > enable/disable. If parked bit is 1 then configuration does not apply > and if it is 0 then pinmux configuration applies. This is to support > to avoid any glitch in pinmux

Re: [PATCH 1/2] clk: tegra: Fix pllre Tegra210 and add pll_re_out1

2016-04-15 Thread Rhyland Klein
On 4/12/2016 11:23 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Mar 21, 2016 at 03:58:52PM -0400, Rhyland Klein wrote: >> Use a new Tegra210 version of the pll_register_pllre function to >> allow setting the proper settings for the m and n div field

Re: [PATCH 1/2] clk: tegra: Fix pllre Tegra210 and add pll_re_out1

2016-04-15 Thread Rhyland Klein
On 4/12/2016 11:23 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Mar 21, 2016 at 03:58:52PM -0400, Rhyland Klein wrote: >> Use a new Tegra210 version of the pll_register_pllre function to >> allow setting the proper settings for the m and n div field

[PATCH] arm64: tegra: Enable cros-ec and charger on Smaug

2016-04-14 Thread Rhyland Klein
Add nodes for the ChromeOS Embedded Controller and for the gas gauge connected to the I2C bus that it controls. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 27 +++ 1 file changed, 27 insertions(+) diff --git

[PATCH] arm64: tegra: Enable cros-ec and charger on Smaug

2016-04-14 Thread Rhyland Klein
Add nodes for the ChromeOS Embedded Controller and for the gas gauge connected to the I2C bus that it controls. Signed-off-by: Rhyland Klein --- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 27 +++ 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH] mfd: cros_ec: Enable cros-ec driver for arm64

2016-04-14 Thread Rhyland Klein
The cros-ec driver should also be enabled for arm64 platforms as there are platforms, like the tegra210-smaug which make use of the ChromeOS Embedded Controller. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] mfd: cros_ec: Enable cros-ec driver for arm64

2016-04-14 Thread Rhyland Klein
The cros-ec driver should also be enabled for arm64 platforms as there are platforms, like the tegra210-smaug which make use of the ChromeOS Embedded Controller. Signed-off-by: Rhyland Klein --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd

[PATCH v2] arm64: tegra: Add pinmux for Smaug board

2016-04-11 Thread Rhyland Klein
Add pinmux node for Tegra210 Smaug board. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- v2: - Fixed address to align with recent patch: 'arm64: tegra: Remove 0, prefix from unit-addresses' arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 1271 + 1 file c

[PATCH v2] arm64: tegra: Add pinmux for Smaug board

2016-04-11 Thread Rhyland Klein
Add pinmux node for Tegra210 Smaug board. Signed-off-by: Rhyland Klein --- v2: - Fixed address to align with recent patch: 'arm64: tegra: Remove 0, prefix from unit-addresses' arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 1271 + 1 file changed, 1271 insertions

Re: [PATCH 1/2] clk: tegra: Fix pllre Tegra210 and add pll_re_out1

2016-04-08 Thread Rhyland Klein
On 3/21/2016 3:58 PM, Rhyland Klein wrote: > Use a new Tegra210 version of the pll_register_pllre function to > allow setting the proper settings for the m and n div fields. > > Additionally define PLL_RE_OUT1 on Tegra210. > > Signed-off-by: Rhyland Klein <rkl...@nv

Re: [PATCH 1/2] clk: tegra: Fix pllre Tegra210 and add pll_re_out1

2016-04-08 Thread Rhyland Klein
On 3/21/2016 3:58 PM, Rhyland Klein wrote: > Use a new Tegra210 version of the pll_register_pllre function to > allow setting the proper settings for the m and n div fields. > > Additionally define PLL_RE_OUT1 on Tegra210. > > Signed-off-by: Rhyland Klein > --- Ping. >

[PATCH] pinctrl: tegra: clear park bit for all pins

2016-04-07 Thread Rhyland Klein
to disable. The park bit is used to prevent glitching when reprogramming pinctrl registers. Based on work by: Shravani Dingari <shrava...@nvidia.com> Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/pinctrl/tegra/pinctrl-tegra.c| 18 ++ drivers/pinctrl/t

[PATCH] pinctrl: tegra: clear park bit for all pins

2016-04-07 Thread Rhyland Klein
to disable. The park bit is used to prevent glitching when reprogramming pinctrl registers. Based on work by: Shravani Dingari Signed-off-by: Rhyland Klein --- drivers/pinctrl/tegra/pinctrl-tegra.c| 18 ++ drivers/pinctrl/tegra/pinctrl-tegra.h| 6 ++ drivers/pinctrl

[PATCH] arm64: tegra: Add pinmux for Smaug board

2016-04-06 Thread Rhyland Klein
Add pinmux node for Tegra210 Smaug board. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 1272 + 1 file changed, 1272 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/bo

[PATCH] arm64: tegra: Add pinmux for Smaug board

2016-04-06 Thread Rhyland Klein
Add pinmux node for Tegra210 Smaug board. Signed-off-by: Rhyland Klein --- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 1272 + 1 file changed, 1272 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-30 Thread Rhyland Klein
On 3/30/2016 4:58 AM, YH Huang wrote: > On Tue, 2016-03-29 at 11:05 -0400, Rhyland Klein wrote: >> On 3/28/2016 9:52 PM, YH Huang wrote: >>> On Mon, 2016-03-28 at 11:57 -0400, Rhyland Klein wrote: >>>> On 3/28/2016 6:05 AM, Daniel Kurtz wrote: >>>>>

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-30 Thread Rhyland Klein
On 3/30/2016 4:58 AM, YH Huang wrote: > On Tue, 2016-03-29 at 11:05 -0400, Rhyland Klein wrote: >> On 3/28/2016 9:52 PM, YH Huang wrote: >>> On Mon, 2016-03-28 at 11:57 -0400, Rhyland Klein wrote: >>>> On 3/28/2016 6:05 AM, Daniel Kurtz wrote: >>>>>

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-29 Thread Rhyland Klein
On 3/28/2016 9:52 PM, YH Huang wrote: > On Mon, 2016-03-28 at 11:57 -0400, Rhyland Klein wrote: >> On 3/28/2016 6:05 AM, Daniel Kurtz wrote: >>> +Rhyland Klein who original wrote this code... >>> >>> On Mon, Mar 28, 2016 at 10:32 AM, YH Huang <yh.hu...@medi

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-29 Thread Rhyland Klein
On 3/28/2016 9:52 PM, YH Huang wrote: > On Mon, 2016-03-28 at 11:57 -0400, Rhyland Klein wrote: >> On 3/28/2016 6:05 AM, Daniel Kurtz wrote: >>> +Rhyland Klein who original wrote this code... >>> >>> On Mon, Mar 28, 2016 at 10:32 AM, YH Huang wrote: >>

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-28 Thread Rhyland Klein
On 3/28/2016 6:05 AM, Daniel Kurtz wrote: > +Rhyland Klein who original wrote this code... > > On Mon, Mar 28, 2016 at 10:32 AM, YH Huang <yh.hu...@mediatek.com> wrote: >> >> On Fri, 2016-03-25 at 11:06 +0800, Daniel Kurtz wrote: >>> On Thu, Mar

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-28 Thread Rhyland Klein
On 3/28/2016 6:05 AM, Daniel Kurtz wrote: > +Rhyland Klein who original wrote this code... > > On Mon, Mar 28, 2016 at 10:32 AM, YH Huang wrote: >> >> On Fri, 2016-03-25 at 11:06 +0800, Daniel Kurtz wrote: >>> On Thu, Mar 24, 2016 at 2:43 PM, YH Hua

[PATCH 2/2] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-03-21 Thread Rhyland Klein
or potential deadlocks] Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk-pll.c | 482 +++ drivers/clk/tegra/clk-tegra114.c | 155 + drivers/clk/tegra/clk-tegra124.c | 156 + drivers/clk/tegra/cl

[PATCH 1/2] clk: tegra: Fix pllre Tegra210 and add pll_re_out1

2016-03-21 Thread Rhyland Klein
Use a new Tegra210 version of the pll_register_pllre function to allow setting the proper settings for the m and n div fields. Additionally define PLL_RE_OUT1 on Tegra210. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- drivers/clk/tegra/clk-pll.c

[PATCH 2/2] clk: tegra: Initialize UTMIPLL when enabling PLLU

2016-03-21 Thread Rhyland Klein
From: Andrew Bresticker Move the UTMIPLL initialization code from the clk-tegra.c files into clk-pll.c and perform the initialization sequence when PLLU is enabled. Signed-off-by: Andrew Bresticker [rklein: Merged in some later fixes for potential deadlocks] Signed-off-by: Rhyland Klein

[PATCH 1/2] clk: tegra: Fix pllre Tegra210 and add pll_re_out1

2016-03-21 Thread Rhyland Klein
Use a new Tegra210 version of the pll_register_pllre function to allow setting the proper settings for the m and n div fields. Additionally define PLL_RE_OUT1 on Tegra210. Signed-off-by: Rhyland Klein --- drivers/clk/tegra/clk-pll.c | 46 drivers

Re: [PATCH 17/41] clk: tegra: Remove CLK_IS_ROOT

2016-03-02 Thread Rhyland Klein
On 3/1/2016 2:00 PM, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Rhyland Klein <rkl...@nvidia.com> > Cc: Thierry Reding <tred...@nvidia.com> > Signed-off-by: Stephen Boyd <sb...@codeaurora.org> > --- > drivers/clk/teg

Re: [PATCH 17/41] clk: tegra: Remove CLK_IS_ROOT

2016-03-02 Thread Rhyland Klein
On 3/1/2016 2:00 PM, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Rhyland Klein > Cc: Thierry Reding > Signed-off-by: Stephen Boyd > --- > drivers/clk/tegra/clk-audio-sync.c | 2 +- > drivers/clk/tegra/clk-dfll.c| 1 -

Re: [PATCH] mfd: Fix MACRO for commonly declared MFD cell attributes

2016-02-26 Thread Rhyland Klein
On 2/19/2016 11:28 AM, Rhyland Klein wrote: > On 2/19/2016 3:50 AM, Lee Jones wrote: >> On Thu, 18 Feb 2016, Rhyland Klein wrote: >> >>> MFD_ARRAY_SIZE() would not accurately return 0 if the passed >>> parameter was NULL. Fix this so that num_resources wil

Re: [PATCH] mfd: Fix MACRO for commonly declared MFD cell attributes

2016-02-26 Thread Rhyland Klein
On 2/19/2016 11:28 AM, Rhyland Klein wrote: > On 2/19/2016 3:50 AM, Lee Jones wrote: >> On Thu, 18 Feb 2016, Rhyland Klein wrote: >> >>> MFD_ARRAY_SIZE() would not accurately return 0 if the passed >>> parameter was NULL. Fix this so that num_resources wil

Re: [PATCH] mfd: Fix MACRO for commonly declared MFD cell attributes

2016-02-19 Thread Rhyland Klein
On 2/19/2016 3:50 AM, Lee Jones wrote: > On Thu, 18 Feb 2016, Rhyland Klein wrote: > >> MFD_ARRAY_SIZE() would not accurately return 0 if the passed >> parameter was NULL. Fix this so that num_resources will >> accurately be 0 in the case that _res is NULL. >

Re: [PATCH] mfd: Fix MACRO for commonly declared MFD cell attributes

2016-02-19 Thread Rhyland Klein
On 2/19/2016 3:50 AM, Lee Jones wrote: > On Thu, 18 Feb 2016, Rhyland Klein wrote: > >> MFD_ARRAY_SIZE() would not accurately return 0 if the passed >> parameter was NULL. Fix this so that num_resources will >> accurately be 0 in the case that _res is NULL. >> &

[PATCH] mfd: Fix MACRO for commonly declared MFD cell attributes

2016-02-18 Thread Rhyland Klein
MFD_ARRAY_SIZE() would not accurately return 0 if the passed parameter was NULL. Fix this so that num_resources will accurately be 0 in the case that _res is NULL. cc: Lee Jones <lee.jo...@linaro.org> cc: Laxman Dewangan <ldewan...@nvidia.com> Signed-off-by: Rhyland Klein <rk

[PATCH] mfd: Fix MACRO for commonly declared MFD cell attributes

2016-02-18 Thread Rhyland Klein
MFD_ARRAY_SIZE() would not accurately return 0 if the passed parameter was NULL. Fix this so that num_resources will accurately be 0 in the case that _res is NULL. cc: Lee Jones cc: Laxman Dewangan Signed-off-by: Rhyland Klein --- include/linux/mfd/core.h | 15 +-- 1 file changed

Re: [PATCH] clk: clk_register: Correctly initialize enable_count

2016-02-11 Thread Rhyland Klein
On 2/11/2016 4:32 PM, Michael Turquette wrote: > Quoting Rhyland Klein (2016-02-10 10:34:16) >> On 2/9/2016 9:56 PM, Emilio López wrote: >>> Hi, >>> >>> El 09/02/16 a las 19:48, Rhyland Klein escribió: >>>> When clocks are registered, they coul

Re: [PATCH] clk: clk_register: Correctly initialize enable_count

2016-02-11 Thread Rhyland Klein
On 2/11/2016 4:32 PM, Michael Turquette wrote: > Quoting Rhyland Klein (2016-02-10 10:34:16) >> On 2/9/2016 9:56 PM, Emilio López wrote: >>> Hi, >>> >>> El 09/02/16 a las 19:48, Rhyland Klein escribió: >>>> When clocks are registered, they coul

Re: [PATCH] clk: clk_register: Correctly initialize enable_count

2016-02-10 Thread Rhyland Klein
On 2/9/2016 9:56 PM, Emilio López wrote: > Hi, > > El 09/02/16 a las 19:48, Rhyland Klein escribió: >> When clocks are registered, they could be enabled already in >> hardware. As of now, the enable count will start at 0. When this >> happens, it means a clock is enable

Re: [PATCH] clk: clk_register: Correctly initialize enable_count

2016-02-10 Thread Rhyland Klein
On 2/9/2016 9:56 PM, Emilio López wrote: > Hi, > > El 09/02/16 a las 19:48, Rhyland Klein escribió: >> When clocks are registered, they could be enabled already in >> hardware. As of now, the enable count will start at 0. When this >> happens, it means a clock is enable

[PATCH] clk: clk_register: Correctly initialize enable_count

2016-02-09 Thread Rhyland Klein
the first time someone calls clk_enable() for a clk that was on at boot. Signed-off-by: Rhyland Klein --- Perhaps this code should be something optional right now? I can't test all boards that use this framework, and some boards may be using the clocks that are on but thought off without realizing

[PATCH] clk: clk_register: Correctly initialize enable_count

2016-02-09 Thread Rhyland Klein
the first time someone calls clk_enable() for a clk that was on at boot. Signed-off-by: Rhyland Klein <rkl...@nvidia.com> --- Perhaps this code should be something optional right now? I can't test all boards that use this framework, and some boards may be using the clocks that are on but thoug

Re: [PATCH] clk: tegra: Fix divider settings for Tegra210 pll_a

2016-02-05 Thread Rhyland Klein
On 2/5/2016 9:01 AM, Jon Hunter wrote: > When setting the pll_a frequency, to what should be 368639844 Hz, the > actual output frequency of the pll is 737279687 Hz (as reported by the > debugfs clk_summary entry), which is double the expect frequency. The > calculations for the pll frequency

Re: [PATCH] clk: tegra: Fix divider settings for Tegra210 pll_a

2016-02-05 Thread Rhyland Klein
On 2/5/2016 9:01 AM, Jon Hunter wrote: > When setting the pll_a frequency, to what should be 368639844 Hz, the > actual output frequency of the pll is 737279687 Hz (as reported by the > debugfs clk_summary entry), which is double the expect frequency. The > calculations for the pll frequency

Re: [PATCH 2/2] clk: tegra: Use definition for pll_u override bit

2015-12-21 Thread Rhyland Klein
- val &= ~BIT(24); /* disable PLLU_OVERRIDE */ > + val &= ~PLLU_BASE_OVERRIDE; /* disable PLLU_OVERRIDE */ > writel(val, clk_base + pll_u_vco_params.base_reg); > > clk = tegra_clk_register_pllre("pll_u_vco", "pll_ref", clk_base, pmc,

Re: [PATCH 1/2] clk: tegra: Fix warning caused by pll_u failing to lock

2015-12-21 Thread Rhyland Klein
{ TEGRA210_CLK_PLL_RE_VCO, TEGRA210_CLK_CLK_MAX, 67200, 1 }, > - { TEGRA210_CLK_PLL_U_OUT1, TEGRA210_CLK_CLK_MAX, 4800, 1 }, > - { TEGRA210_CLK_PLL_U_OUT2, TEGRA210_CLK_CLK_MAX, 6000, 1 }, > { TEGRA210_CLK_XUSB_GATE, TEGRA210_CLK_CLK_MAX, 0, 1 }, >

Re: [PATCH 1/2] clk: tegra: Fix warning caused by pll_u failing to lock

2015-12-21 Thread Rhyland Klein
TEGRA210_CLK_PLL_P, 1200, 1 }, > { TEGRA210_CLK_PLL_RE_VCO, TEGRA210_CLK_CLK_MAX, 67200, 1 }, > - { TEGRA210_CLK_PLL_U_OUT1, TEGRA210_CLK_CLK_MAX, 4800, 1 }, > - { TEGRA210_CLK_PLL_U_OUT2, TEGRA210_CLK_CLK_MAX, 6000, 1 }, > { TEGRA210_CLK_XUSB_GATE, TEG

Re: [PATCH 2/2] clk: tegra: Use definition for pll_u override bit

2015-12-21 Thread Rhyland Klein
+ pll_u_vco_params.base_reg); > - val &= ~BIT(24); /* disable PLLU_OVERRIDE */ > + val &= ~PLLU_BASE_OVERRIDE; /* disable PLLU_OVERRIDE */ > writel(val, clk_base + pll_u_vco_params.base_reg); > > clk = tegra_clk_register_pllre("pll_u_vco", "pll_r

<    1   2   3   4   5   6   7   8   >