Lars,
Am Sonntag, 23. September 2018, 15:49:42 CEST schrieb Lars Persson:
> Hi Richard
>
> Sorry, I assumed this omission from -stable was a mistake.
>
> The timing for our boot increased from 45 seconds to 55 seconds on one
> chip and 42 seconds to 48 seconds on another chip. The regression was
Lars,
Am Sonntag, 23. September 2018, 14:49:23 CEST schrieb Lars Persson:
> On Sun, Jul 1, 2018 at 6:27 PM Greg Kroah-Hartman
> wrote:
> >
> > 4.9-stable review patch. If anyone has any objections, please let me know.
> >
> > ----------
> >
> >
On Sun, Sep 23, 2018 at 3:00 AM Miguel Ojeda
wrote:
>
> Hi Diego,
>
> A few things, since it looks like this is your first patch.
git log...
> On Sat, Sep 22, 2018 at 5:56 PM, Diego Viola wrote:
> > On Wed, Sep 12, 2018 at 12:54 AM Diego Viola wrote:
> >>
> >> Signed-off-by: Diego Viola
> >>
Am Freitag, 21. September 2018, 15:53:42 CEST schrieb Greg KH:
> On Fri, Sep 21, 2018 at 11:33:15AM +0200, Richard Weinberger wrote:
> > Greg,
> >
> > The following changes since commit ae596de1a0c8c2c924dc99d23c026259372ab234:
> >
> > Compiler Attributes: nake
Fix for a NULL pointer deref in mount code
- Revert of a bad fix for xattrs
--------
Richard Weinberger (2):
ubifs: Check for name being NULL while mounting
Revert "ubifs: xattr: Don't operate on deleted inodes"
Sasch
Am Freitag, 21. September 2018, 03:42:25 CEST schrieb Joel Stanley:
> On Thu, 20 Sep 2018 at 16:40, Richard Weinberger wrote:
> >
> > Am Donnerstag, 20. September 2018, 04:30:41 CEST schrieb Joel Stanley:
> > > On Mon, 17 Sep 2018 at 07:30, Richard Weinberger wrote:
>
Am Donnerstag, 20. September 2018, 08:26:38 CEST schrieb Ritesh Raj Sarraf:
> The current code fails to run on amd64 because of hardcoded reference to
> i386
>
> Signed-off-by: Ritesh Raj Sarraf
Thanks for spotting this!
> ---
> arch/um/drivers/port_user.c | 2 +-
> 1 file changed, 1 insertion
Am Donnerstag, 20. September 2018, 04:30:41 CEST schrieb Joel Stanley:
> On Mon, 17 Sep 2018 at 07:30, Richard Weinberger wrote:
> >
> > This reverts commit 11a6fc3dc743e22fb50f2196ec55bee5140d3c52.
> > UBIFS wants to assert that xattr operations are only issued on files
&
Andrew,
Am Dienstag, 18. September 2018, 15:05:21 CEST schrieb Andrew Worsley:
> Use a slightly larger than average EC so these PEBs will be
> reinitialised with erase counts that make them less likely to
> be reused than other (perhaps less worn or error-prone) PEBs
>
> We have more frequent ECC
Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada:
> Some samples require headers installation, so commit 3fca1700c4c3
> ("kbuild: make samples really depend on headers_install") added
> such dependency in the top Makefile. However, UML fails to build
> with CONFIG_SAMPLES=y b
xattr operations are perfectly fine on unlinked
files.
Instead the assertions need to be fixed/removed.
Cc:
Fixes: 11a6fc3dc743 ("ubifs: xattr: Don't operate on deleted inodes")
Reported-by: Koen Vandeputte
Signed-off-by: Richard Weinberger
---
fs/ubifs/xattr.c | 24 -
Am Dienstag, 4. September 2018, 04:11:07 CEST schrieb Haibo Xu (Arm Technology
China):
> Hi Richard,
>
> What do you mean by done it in the core? moving macro definition to
> include/uapi/linux/ptrace.h?
> The patch is strictly follow x86's sematic on PTRACE_SYSEMU/SINGLESTEP
> support.
Well,
865e5c6379...@syzkaller.appspotmail.com
Signed-off-by: Richard Weinberger
---
fs/ubifs/super.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 23e7042666a7..87d08f738632 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1954,6 +1954,9 @@ sta
Am Montag, 3. September 2018, 18:31:03 CEST schrieb Will Deacon:
> On Mon, Sep 03, 2018 at 02:23:17PM +0800, Haibo.Xu wrote:
> > Add PTRACE_SYSEMU and PTRACE_SYSEMU_SINGLESTEP support on ARM64.
> > This copies the x86 semantics for invoking ptrace hooks, and have
> > been verified on ARM64 machine.
Am Mittwoch, 29. August 2018, 16:38:34 CEST schrieb Sascha Hauer:
> I assumed that make_reservation would align len anyway. I can't find the
> place that led me to that assumption anymore and even if this is true
> it's probably safer to just stick to the original len for the
> non-authenticated ca
Am Mittwoch, 29. August 2018, 16:38:34 CEST schrieb Sascha Hauer:
> On Mon, Aug 27, 2018 at 10:48:26PM +0200, Richard Weinberger wrote:
> > > release_head(c, BASEHD);
> > > kfree(dent);
> > > + ubifs_add_dirt(c, lnum, ubifs_auth_node_sz(c));
> >
> >
want to attend but didn't send an mail yet, please do it now, only few
seats are left!
Thank you on behalf of the program committee:
Stephen Bates
Sagi Grimberg
Christoph Hellwig
Johannes Thumshirn
Richard Weinberger
[1] http://www.tyrol.com/things-to-do/sports/hiking/r
Am Mittwoch, 4. Juli 2018, 14:41:28 CEST schrieb Sascha Hauer:
> Make sure that during replay all buds can be authenticated. To do
> this we calculate the hash chain until we find an authentication
> node and check the HMAC in that node against the current status
> of the hash chain.
>
> After a p
Am Mittwoch, 4. Juli 2018, 14:41:27 CEST schrieb Sascha Hauer:
> To be able to authenticate the garbage collector journal head add
> authentication nodes to the buds the garbage collector creates.
>
> Signed-off-by: Sascha Hauer
> ---
> fs/ubifs/gc.c | 37 ++---
>
Am Mittwoch, 4. Juli 2018, 14:41:26 CEST schrieb Sascha Hauer:
> Nodes that are written to flash can only be authenticated through the
> index after the next commit. When a journal replay is necessary the
> nodes are not yet referenced by the index and thus can't be
> authenticated.
>
> This patch
Am Mittwoch, 4. Juli 2018, 14:41:25 CEST schrieb Sascha Hauer:
> With this patch the hashes over the index nodes stored in the tree node
> cache are written to flash and are checked when read back from flash.
> The hash of the root index node is stored in the master node.
>
> During journal replay
Am Mittwoch, 4. Juli 2018, 14:41:24 CEST schrieb Sascha Hauer:
> As part of the UBIFS authentication support every branch in the index
> gets a hash covering the referenced node. To make that happen the tree
> node cache needs hashes over the nodes. This patch adds a hash argument
> to ubifs_tnc_ad
Am Mittwoch, 4. Juli 2018, 14:41:22 CEST schrieb Sascha Hauer:
> This patch adds the various helper functions needed for authentication
> support. We need functions to hash nodes, to embed HMACs into a node and
> to compare hashes and HMACs. Most functions first check if this
> filesystem is authen
Am Mittwoch, 4. Juli 2018, 14:41:19 CEST schrieb Sascha Hauer:
> The superblock node is read/modified/written several times throughout
> the UBIFS code. Instead of reading it from the device each time just
> keep a copy in memory and write back the modified copy when necessary.
> This patch helps f
On Mon, Aug 13, 2018 at 8:31 AM Sascha Hauer wrote:
>
> On Wed, Jul 04, 2018 at 02:41:17PM +0200, Sascha Hauer wrote:
> > ubifs_lpt_lookup() starts by looking up the nth pnode in the LPT. We
> > already have this functionality in ubifs_pnode_lookup(). Use this
> > function rather than open coding
Richard Weinberger (1):
ubifs: Remove empty file.h
fs/ubifs/file.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 fs/ubifs/file.h
This empty file sneaked into the tree by mistake.
Remove it.
Fixes: 6eb61d587f45 ("ubifs: Pass struct ubifs_info to ubifs_assert()")
Signed-off-by: Richard Weinberger
---
fs/ubifs/file.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 fs/ubifs/file.h
diff
. Silva (1):
ubifs: use swap macro in swap_dirty_idx
Quentin Schulz (2):
ubi: provide a way to skip CRC checks
ubi: expose the volume CRC check skip flag
Richard Weinberger (15):
ubifs: Fix directory size calculation for symlinks
ubifs: Fix synced_i_size calculation for
Am Dienstag, 21. August 2018, 08:57:44 CEST schrieb liu.son...@zte.com.cn:
> Hi Richard,
>
> In ubifs_log_start_commit, the value of c->lhead_offs is zero or set to zero
> by code bellow
> 409 /* Switch to the next log LEB */
> 410 if (c->lhead_offs) {
> 411 c->lhe
Liu Song,
Am Dienstag, 21. August 2018, 05:17:22 CEST schrieb Liu Song:
> The value of c->lhead_offs cannot exceed max_len which much
> smaller than c->leb_size. So the check will never be true.
> Just remove it.
Please explain in more detail why this case is never ever possible.
Removing such co
Lui Song,
Am Montag, 20. August 2018, 08:09:05 CEST schrieb Liu Song:
> From: fishland
Please use your real name. 1st Signed-off-by and patch author should match.
> Even though we protect on-flash data by CRC checksums,
> we still don't trust the media. If lnum is not 0 or 1,
> access exceed a
On Thu, Aug 16, 2018 at 2:58 PM Sedat Dilek wrote:
>
> Hi Linus,
>
> I am here on Linux v4.18 and tried first to merge the l1tf-final Git-branch.
> Unfortunately, this is no more available in the tip Git-tree.
>
> Then I saw Linux v4.18.1 which includes all the above stuff.
>
> I tried to 'git che
Every single time I come across that code, I get confused
because it looks like a possible dead lock.
Help myself by adding a comment.
Signed-off-by: Richard Weinberger
---
fs/ubifs/journal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index
Am Montag, 13. August 2018, 10:12:38 CEST schrieb Sascha Hauer:
> > Can you please add a helper function for that? These shift games are
> > always confusing and not easy to spot.
>
> Do you have a suggestion for a helper function? lpt.c is full of rather
> non obvious arithmetic operations and I
Am Montag, 13. August 2018, 08:31:27 CEST schrieb Sascha Hauer:
> On Wed, Jul 04, 2018 at 02:41:17PM +0200, Sascha Hauer wrote:
> > ubifs_lpt_lookup() starts by looking up the nth pnode in the LPT. We
> > already have this functionality in ubifs_pnode_lookup(). Use this
> > function rather than ope
ries to kbuild tree.
> Ack from UML folks are appreciated.
Nice to see this fixed, Masahiro! :-)
Acked-by: Richard Weinberger
Thanks,
//richard
e Rapoport (2):
> > um: setup_physmem: stop using global variables
> > um: switch to NO_BOOTMEM
> >
> > arch/um/Kconfig.common | 2 ++
> > arch/um/kernel/physmem.c | 22 ++----
> > 2 files changed, 12 insertions(+), 12 deletions(-)
Acked-by: Richard Weinberger
Thanks,
//richard
Ben,
Am Samstag, 28. Juli 2018, 03:28:58 CEST schrieb Ben Hutchings:
> > > Isn't there a risk here, that a read error leads to erasing data that
> > > might be recoverable if the read is retried?
> >
> > Well, read error means that already something went very wrong. At other
> > places
> > in UB
Ben,
Am Donnerstag, 26. Juli 2018, 04:12:54 CEST schrieb Ben Hutchings:
> On Tue, 2018-07-10 at 20:24 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch. If anyone has any objections, please let me
know.
> >
> > --
> >
> > From: Ri
- various fixes from Randy
> - various UML patches to be able to use the common Kconfig
For the UML bits,
Acked-by: Richard Weinberger
Thanks,
//richard
On Fri, Jul 20, 2018 at 1:50 AM, Theuns Verwoerd
wrote:
> Security certifications such as FIPS require the capability to securely
> delete files, which is problematic under JFFS2's log-based model. We can
Can you please be a little more specific about the certifications?
These days secure delet
[fixing CC list]
On Fri, Jul 20, 2018 at 2:54 AM, Theuns Verwoerd
wrote:
>
> On 07/20/2018 12:04 PM, Al Viro wrote:
>> On Fri, Jul 20, 2018 at 11:50:12AM +1200, Theuns Verwoerd wrote:
>>
>>> +ssize_t jffs2_sync_file_read(struct file *f,
>>> + char __user *b, size_t len, loff_t *ofs)
>>>
We are going to pass struct ubifs_info to ubifs_assert()
but while unloading the UBIFS module we don't have the info
struct anymore.
Therefore replace the asserts by a regular WARN_ON().
Signed-off-by: Richard Weinberger
---
fs/ubifs/super.c | 4 ++--
1 file changed, 2 insertions(
This allows us to have more context in ubifs_assert()
and take different actions depending on the configuration.
Signed-off-by: Richard Weinberger
---
fs/ubifs/budget.c | 68 -
fs/ubifs/commit.c | 8 +--
fs/ubifs/crypto.c | 4 +-
fs/ubifs/debug.c
go
on.
- read-only: Switch to read-only mode.
- panic: shoot the kernel in the head.
Signed-off-by: Richard Weinberger
---
fs/ubifs/debug.c | 22 ++
fs/ubifs/debug.h | 10 ++
fs/ubifs/ubifs.h | 14 ++
3 files changed, 42 insertions(+), 4 deletions
UBIFS will not write possible bad data to the
MTD and gives users the chance to collect debugging information.
Signed-off-by: Richard Weinberger
---
fs/ubifs/super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 524122da7868..4b9890e54a78 100644
---
Expose our three options to userspace.
Signed-off-by: Richard Weinberger
---
fs/ubifs/misc.c | 11 +++
fs/ubifs/misc.h | 2 ++
fs/ubifs/super.c | 24
3 files changed, 37 insertions(+)
diff --git a/fs/ubifs/misc.c b/fs/ubifs/misc.c
index 586fd5b578a7
-only mode
>From now on the default action is read-only.
Richard Weinberger (5):
ubifs: Turn two ubifs_assert() into a WARN_ON()
ubifs: Pass struct ubifs_info to ubifs_assert()
ubifs: Rework ubifs_assert()
ubifs: Allow setting assert action as mount parameter
ubifs: Set default assert a
xattr operations can race with unlink and the following assert triggers:
UBIFS assert failed in ubifs_jnl_change_xattr at 1606 (pid 6256)
Fix this by checking i_nlink before working on the host inode.
Cc:
Fixes: 1e51764a3c2a ("UBIFS: add new flash file system")
Signed-off-by: Richard
UBIFS operates on LEBs, not PEBs.
Signed-off-by: Richard Weinberger
---
fs/ubifs/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
index 11c09ce3c795..a57be0b698b5 100644
--- a/fs/ubifs/gc.c
+++ b/fs/ubifs/gc.c
@@ -483,7 +483,7 @@ int
Am Freitag, 6. Juli 2018, 16:47:32 CEST schrieb Boris Brezillon:
> On Fri, 06 Jul 2018 16:44:44 +0200
> Richard Weinberger wrote:
>
> > Am Freitag, 6. Juli 2018, 15:05:25 CEST schrieb Benjamin Gaignard:
> > > The format specifier "%p" can leak kernel
Am Freitag, 6. Juli 2018, 15:05:25 CEST schrieb Benjamin Gaignard:
> The format specifier "%p" can leak kernel addresses.
> Use "%pK" instead.
Does %pK really make sense for dev_dbg()?
When the driver is being debugged "leaking" is on purpose. :)
Thanks,
//richard
> Signed-off-by: Benjamin Gaig
Signed-off-by: Richard Weinberger
---
fs/ubifs/gc.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
index a03a47cf880d..11c09ce3c795 100644
--- a/fs/ubifs/gc.c
+++ b/fs/ubifs/gc.c
@@ -513,7 +513,13 @@ int ubifs_garbage_collect_leb(struct ubi
...@vger.kernel.org
Fixes: 1e51764a3c2a ("UBIFS: add new flash file system")
Signed-off-by: Richard Weinberger
---
fs/ubifs/log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ubifs/log.c b/fs/ubifs/log.c
index 7cffa120a750..60d49c6dd470 100644
--- a/fs/ubifs/log.c
+++
Am Dienstag, 3. Juli 2018, 09:35:33 CEST schrieb Ingo Molnar:
>
> * Richard Weinberger wrote:
>
> > Masahiro,
> >
> > Am Dienstag, 3. Juli 2018, 03:50:12 CEST schrieb Masahiro Yamada:
> > >
> > > At first, I sent the first patch to UML ML,
> &
Am Montag, 2. Juli 2018, 16:24:15 CEST schrieb Richard Weinberger:
> Arnd,
>
> Am Mittwoch, 20. Juni 2018, 10:29:11 CEST schrieb Arnd Bergmann:
> > The tnc uses get_seconds() based timestamps to check the age of a znode,
> > which has two problems: on 32-bit architectures
Masahiro,
Am Dienstag, 3. Juli 2018, 03:50:12 CEST schrieb Masahiro Yamada:
>
> At first, I sent the first patch to UML ML,
> but they did not pick it up.
> Instead, I was able to get Acked-by from Richard,
> one of the UML maintainers.
>
> https://patchwork.kernel.org/patch/10399787/
>
> I am
Since commit 6da2ec56059c ("treewide: kmalloc() -> kmalloc_array()")
we use kmalloc_array() for kmalloc() that computes the length with
a multiplication.
Cc: Kees Cook
Suggested-by: Kees Cook
Signed-off-by: Richard Weinberger
---
fs/ubifs/journal.c | 2 +-
1 file changed, 1 in
Am Montag, 2. Juli 2018, 20:27:00 CEST schrieb Kees Cook:
> > Let's queue another patch for the next merge window which converts
> > kmalloc() -> kmalloc_array().
>
> I'd prefer to leave it as-is for 4.18 because it would be the only
> unconverted kmalloc()-with-multiplication in the entire tree.
Am Montag, 2. Juli 2018, 18:00:05 CEST schrieb Kees Cook:
> On Sun, Jul 1, 2018 at 2:20 PM, Richard Weinberger wrote:
> > This reverts commit 353748a359f1821ee934afc579cf04572406b420.
> > It bypassed the linux-mtd review process and fixes the issue not as it
> > should.
>
Am Montag, 2. Juli 2018, 09:51:21 CEST schrieb Boris Brezillon:
> Hi Artem,
>
> On Mon, 02 Jul 2018 10:30:25 +0300
> Artem Bityutskiy wrote:
>
> > Hi,
> >
> > On Thu, 2018-06-28 at 09:40 +0200, Quentin Schulz wrote:
> > > diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c
> > > index
Artem,
Am Montag, 2. Juli 2018, 09:30:25 CEST schrieb Artem Bityutskiy:
> Hi,
>
> On Thu, 2018-06-28 at 09:40 +0200, Quentin Schulz wrote:
> > diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c
> > index d4b2e87..e9e9ecb 100644
> > --- a/drivers/mtd/ubi/kapi.c
> > +++ b/drivers/mtd/ubi/
Am Montag, 2. Juli 2018, 08:52:27 CEST schrieb Boris Brezillon:
> On Mon, 2 Jul 2018 08:44:33 +0200
> Quentin Schulz wrote:
>
> > Hi Richard, Boris,
> >
> > On Sun, Jul 01, 2018 at 10:50:41PM +0200, Richard Weinberger wrote:
> > > Am Sonntag, 1. Juli 2018, 2
Check whether the size is within bounds before using it.
If the size is not correct, abort and dump the bad data node.
Cc: Kees Cook
Cc: Silvio Cesare
Cc: sta...@vger.kernel.org
Fixes: 1e51764a3c2ac ("UBIFS: add new flash file system")
Reported-by: Silvio Cesare
Signed-off-b
This reverts commit 353748a359f1821ee934afc579cf04572406b420.
It bypassed the linux-mtd review process and fixes the issue not as it
should.
Cc: Kees Cook
Cc: Silvio Cesare
Cc: sta...@vger.kernel.org
Signed-off-by: Richard Weinberger
---
fs/ubifs/journal.c | 5 ++---
1 file changed, 2
Am Sonntag, 1. Juli 2018, 22:54:32 CEST schrieb Joe Perches:
> On Sun, 2018-07-01 at 22:33 +0200, Boris Brezillon wrote:
> > On Sun, 01 Jul 2018 21:35:57 +0200 Richard Weinberger
> > wrote:
> > > Am Donnerstag, 28. Juni 2018, 09:40:53 CEST schrieb Quentin Schulz:
>
Am Sonntag, 1. Juli 2018, 22:33:47 CEST schrieb Boris Brezillon:
> On Sun, 01 Jul 2018 21:35:57 +0200
> Richard Weinberger wrote:
>
> > Quentin,
> >
> > Am Donnerstag, 28. Juni 2018, 09:40:53 CEST schrieb Quentin Schulz:
> > > Now that we have the logic f
ntin Schulz
> Reviewed-by: Boris Brezillon
Reviewed-by: Richard Weinberger
Thanks,
//richard
Quentin,
Am Donnerstag, 28. Juni 2018, 09:40:53 CEST schrieb Quentin Schulz:
> Now that we have the logic for skipping CRC check for static UBI volumes
> in the core, let's expose it to users.
>
> This makes use of a padding byte in the volume description data
> structure as a flag. This flag onl
On Sun, Jul 1, 2018 at 6:22 PM, Greg Kroah-Hartman
wrote:
> 4.17-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Silvio Cesare
>
> commit 353748a359f1821ee934afc579cf04572406b420 upstream.
>
> There is potential for the size and len fields
Am Freitag, 29. Juni 2018, 02:52:16 CEST schrieb Jefferson Carpenter:
> On 6/27/2018 1:18 PM, Richard Weinberger wrote:
> > Am Mittwoch, 27. Juni 2018, 15:12:48 CEST schrieb Michal Hocko:
> >> On Wed 27-06-18 13:29:05, Richard Weinberger wrote:
> >>> On Wed, Jun 2
Am Mittwoch, 27. Juni 2018, 15:12:48 CEST schrieb Michal Hocko:
> On Wed 27-06-18 13:29:05, Richard Weinberger wrote:
> > On Wed, Jun 27, 2018 at 11:34 AM, Jefferson Carpenter
> > wrote:
> > > Is there a way for a user process to mark memory as 'sensitive' o
On Wed, Jun 27, 2018 at 11:34 AM, Jefferson Carpenter
wrote:
> Is there a way for a user process to mark memory as 'sensitive' or
> 'non-sensitive' when it is allocated? That could allow it not to have to be
> zeroed before being allocated to another process.
Isn't this what we have Meltdown and
Masahiro,
Am Freitag, 22. Juni 2018, 16:37:21 CEST schrieb Masahiro Yamada:
> Hi Richard,
>
>
> 2018-06-19 21:07 GMT+09:00 Richard Weinberger :
> > The denali NAND flash controller needs at least two clocks to operate,
> > nand_clk and nand_x_clk.
> > Since 1b
On Mon, Aug 9, 2010 at 10:52 AM, Stefani Seibold wrote:
> Am Montag, den 09.08.2010, 09:37 +0100 schrieb David Woodhouse:
>> On Mon, 2010-08-09 at 09:25 +0100, stef...@seibold.net wrote:
>> > From: Stefani Seibold
>> >
>> > This patch add a quick format option which skips erasing of already erase
Marek,
Am Mittwoch, 20. Juni 2018, 06:52:09 CEST schrieb Marek Vasut:
> On 06/19/2018 02:07 PM, Richard Weinberger wrote:
> > The denali NAND flash controller needs at least two clocks to operate,
> > nand_clk and nand_x_clk.
> > Since 1bb88666775e ("mtd: nand: denali: h
The denali NAND flash controller needs at least two clocks to operate,
nand_clk and nand_x_clk.
Since 1bb88666775e ("mtd: nand: denali: handle timing parameters by
setup_data_interface()") nand_x_clk is used to derive timing settings.
Signed-off-by: Richard Weinberger
---
Strictl
dt->clk_x))
> dt->clk_x = NULL;
>
> - dt->clk_ecc = devm_clk_get(&pdev->dev, "ecc");
> + dt->clk_ecc = devm_clk_get(dev, "ecc");
> if (IS_ERR(dt->clk_ecc))
> dt->clk_ecc = NULL;
>
> @@ -155,7 +156,7 @@ static int denali_dt_probe(struct platform_device *pdev)
>* Hardcode the clock rates for the backward compatibility.
>* This works for both SOCFPGA and UniPhier.
>*/
> - dev_notice(&pdev->dev,
> + dev_notice(dev,
> "necessary clock is missing. default clock rates are
> used.\n");
> denali->clk_x_rate = 2;
> }
>
Tested-by: Richard Weinberger
Thanks,
//richard
gt; "necessary clock is missing. default clock rates are
> used.\n");
> + denali->clk_rate = 5000;
> denali->clk_x_rate = 2;
> }
>
> diff --git a/drivers/mtd/nand/raw/denali_pci.c
> b/drivers/mtd/nand/raw/denali_pci.c
> index 49cb3e1..7c8efc4 100644
> --- a/drivers/mtd/nand/raw/denali_pci.c
> +++ b/drivers/mtd/nand/raw/denali_pci.c
> @@ -73,6 +73,7 @@ static int denali_pci_probe(struct pci_dev *dev, const
> struct pci_device_id *id)
> denali->irq = dev->irq;
> denali->ecc_caps = &denali_pci_ecc_caps;
> denali->nand.ecc.options |= NAND_ECC_MAXIMIZE;
> + denali->clk_rate = 5000;/* 50 MHz */
> denali->clk_x_rate = 2; /* 200 MHz */
>
> ret = pci_request_regions(dev, DENALI_NAND_NAME);
>
Tested-by: Richard Weinberger
Thanks,
//richard
Am Dienstag, 19. Juni 2018, 10:07:26 CEST schrieb Masahiro Yamada:
> Hi Boris,
>
>
> 2018-06-18 16:46 GMT+09:00 Boris Brezillon :
> > On Mon, 18 Jun 2018 09:09:02 +0200
> > Richard Weinberger wrote:
> >
> >> Am Freitag, 15. Juni 2018, 03:18:50 CEST schri
ovided. It is true for all upstreamed platforms.
>
> Signed-off-by: Masahiro Yamada
Reviewed-by: Richard Weinberger
Thanks,
//richard
Am Freitag, 15. Juni 2018, 03:18:51 CEST schrieb Masahiro Yamada:
> The probe function references &pdev->dev many times. Add 'dev' as
> a shorthand.
>
> Signed-off-by: Masahiro Yamada
Reviewed-by: Richard Weinberger
Thanks,
//richard
both platforms use 200 MHz for
> the bus interface clock.
>
> Fixes: 1bb88666775e ("mtd: nand: denali: handle timing parameters by
> setup_data_interface()")
> Cc: linux-stable #4.14+
> Reported-by: Richard Weinberger
> Signed-off-by: Masahiro Yamada
Reviewed-by: Richard Weinberger
Reported-by: Philipp Rosenberger
Thanks,
//richard
On Fri, Jun 15, 2018 at 9:13 PM, Veluthakkal, Sreeram
wrote:
> Veluthakkal, Sreeram would like to recall the message, "PROBLEM: JFFS2 Empty
> summary info causes OOPS".
-ENOMSEXCHANGE
--
Thanks,
//richard
Fixes:
arch/um/os-Linux/skas/process.c:613:1: warning: control reaches end of
non-void function [-Wreturn-type]
longjmp() never returns but gcc still warns that the end of the function
can be reached.
Add a return code and debug aid to detect this impossible case.
Signed-off-by: Richard
This function is nowhere used, let's get rid of it.
Signed-off-by: Richard Weinberger
---
arch/x86/um/shared/sysdep/ptrace_32.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/um/shared/sysdep/ptrace_32.h
b/arch/x86/um/shared/sysdep/ptrace_32.h
index ae00d22bce02..db8478a
Sarraf
Signed-off-by: Richard Weinberger
---
arch/x86/um/shared/sysdep/ptrace_32.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/arch/x86/um/shared/sysdep/ptrace_32.h
b/arch/x86/um/shared/sysdep/ptrace_32.h
index b94a108de1dc..ae00d22bce02 100644
--- a/arch/x86/um/shared/sys
Linus,
On Wed, Jun 13, 2018 at 9:31 PM, Richard Weinberger wrote:
> Linus,
>
> The following changes since commit 29dcea88779c856c7dc92040a0c01233263101d4:
>
> Linux 4.17 (2018-06-03 14:15:21 -0700)
>
> are available in the git repository at:
>
> git://git.kernel.o
Am Donnerstag, 14. Juni 2018, 10:04:36 CEST schrieb Boris Brezillon:
> On Thu, 14 Jun 2018 09:29:42 +0200
> Richard Weinberger wrote:
>
> > Quentin,
> >
> > Am Montag, 11. Juni 2018, 12:20:37 CEST schrieb Quentin Schulz:
> > > If we go for a per-image fla
Am Donnerstag, 14. Juni 2018, 09:38:35 CEST schrieb Boris Brezillon:
> On Thu, 14 Jun 2018 16:29:59 +0900
> Masahiro Yamada wrote:
>
> > Hi Richard,
> >
> > 2018-06-14 16:25 GMT+09:00 Richard Weinberger :
> > > Masahiro,
> > >
> > > Am Don
On Wed, May 23, 2018 at 4:46 PM, Borislav Petkov wrote:
> + Tom and Brijesh.
>
> On Mon, May 21, 2018 at 10:12:53AM -0500, Janakarajan Natarajan wrote:
>> Use Kconfig imply 'option' when specifying SEV CRYPTO dependencies.
>>
>> Example configuration:
>> .
>> .
>> CONFIG_CRYPTO_DEV_CCP=y
>> CONFIG
Quentin,
Am Montag, 11. Juni 2018, 12:20:37 CEST schrieb Quentin Schulz:
> If we go for a per-image flag, adding nocheck to the ioctl makes sense,
> otherwise we have to find a way to select only one or more volumes for
> which the nocheck flag should be set. That being said, I'm not sure a
> per-
Masahiro,
Am Donnerstag, 14. Juni 2018, 07:11:04 CEST schrieb Masahiro Yamada:
>
> The ->setup_data_interface() hook needs to know the clock frequency.
> In fact, this IP needs three clocks, bus "which clock?" is really
> confusing. (It is not described in the DT-binding at all.)
>
> This serie
git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Richard-Weinberger/ubi-Fastmap-updates/20180614-052830
> base: git://git.infradead.org/linux-mtd.git master
> reproduce:
> # apt-get install spar
This flag indicates that the fastmap was preseeded, which means
it was created offline by a tool such as ubinize which cannot know
the whole MTD state such as real size and bad blocks.
As consequence UBI has to take special care to use that fastmap.
Signed-off-by: Richard Weinberger
---
drivers
full scan is useful mostly for debugging and making sure that
it works.
4. Remove the experimental stigma.
Richard Weinberger (14):
ubi: fastmap: Read PEB numbers more carefully
ubi: Fix assert in ubi_wl_init
ubi: fastmap: Add support for flags
ubi: fastmap: Add UBI_FM_SB_PRESEEDED_FLG
With version 2 of fastmap, flags are supported.
We fall back to scanning mode if unsupported flags are found.
Signed-off-by: Richard Weinberger
---
drivers/mtd/ubi/fastmap.c | 24
drivers/mtd/ubi/ubi-media.h | 11 +--
drivers/mtd/ubi/ubi.h | 2 ++
3
If the fastmap is preseeded the bad block count is created while
scanning for bad blocks in the PEB fixup code.
Signed-off-by: Richard Weinberger
---
drivers/mtd/ubi/fastmap.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd
than the kernel expects.
Signed-off-by: Richard Weinberger
---
drivers/mtd/ubi/fastmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index 09a9d3a0ccf5..dabeb01af24a 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers
Now userspace can specify how UBI shall attach.
By default UBI decides how to attach, but userspace can
also force a full scan.
Signed-off-by: Richard Weinberger
---
drivers/mtd/ubi/build.c | 15 ---
drivers/mtd/ubi/cdev.c | 7 ++-
drivers/mtd/ubi/ubi.h | 3 ++-
3 files
401 - 500 of 2417 matches
Mail list logo
