[RESEND RFC 2/3] mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm

From: Sahitya Tummala <stumm...@codeaurora.org> Implement ->platform_dumpregs host operation to print the platform specific registers in addition to standard SDHC register during error conditions. Signed-off-by: Sahitya Tummala <stumm...@codeaurora.org> Signed-off-by: Rites

[RESEND RFC 0/3] mmc: sdhci: sdhci-msm: Add more debug logs

(->platform_dumpregs) for sdhci-msm. Patch 3 :- Adds more logs for data errors to aid debugging. Ritesh Harjani (1): mmc: sdhci: Add more debug info in case of data error Sahitya Tummala (2): mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops. mmc: sdhci-msm: Implem

[RESEND RFC 2/3] mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm

From: Sahitya Tummala Implement ->platform_dumpregs host operation to print the platform specific registers in addition to standard SDHC register during error conditions. Signed-off-by: Sahitya Tummala Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci-msm.c |

[RESEND RFC 0/3] mmc: sdhci: sdhci-msm: Add more debug logs

(->platform_dumpregs) for sdhci-msm. Patch 3 :- Adds more logs for data errors to aid debugging. Ritesh Harjani (1): mmc: sdhci: Add more debug info in case of data error Sahitya Tummala (2): mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops. mmc: sdhci-msm: Implem

[RFC PATCH 3/3] mmc: sdhci: Add more debug info in case of data error

print error log message and dump sdhc registers for debugging purpose in case of data errors (except when tuning commands generate CRC/timeout/end bit errors). Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/host/sdhci.c | 21 +++-- 1 file chang

[RFC PATCH 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops.

.org> Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/host/sdhci.c | 3 +++ drivers/mmc/host/sdhci.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 2390980..73a8918 100644 --- a/drivers/mmc/host/sdhc

[RFC PATCH 3/3] mmc: sdhci: Add more debug info in case of data error

print error log message and dump sdhc registers for debugging purpose in case of data errors (except when tuning commands generate CRC/timeout/end bit errors). Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions

[RFC PATCH 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops.

From: Sahitya Tummala Add new host operation ->platform_dumpregs to provide a mechanism through which host drivers can dump platform specific registers in addition to SDHC registers during error conditions. Signed-off-by: Sahitya Tummala Signed-off-by: Ritesh Harjani --- drivers/mmc/h

[RFC PATCH 0/3] mmc: sdhci: sdhci-msm: Add more debug logs

msm. Patch 3 :- Adds more logs for data errors to aid debugging. Ritesh Harjani (1): mmc: sdhci: Add more debug info in case of data error Sahitya Tummala (2): mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops. mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm driv

[RFC PATCH 0/3] mmc: sdhci: sdhci-msm: Add more debug logs

msm. Patch 3 :- Adds more logs for data errors to aid debugging. Ritesh Harjani (1): mmc: sdhci: Add more debug info in case of data error Sahitya Tummala (2): mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops. mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm driv

[RFC PATCH 2/3] mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm

From: Sahitya Tummala <stumm...@codeaurora.org> Implement ->platform_dumpregs host operation to print the platform specific registers in addition to standard SDHC register during error conditions. Signed-off-by: Sahitya Tummala <stumm...@codeaurora.org> Signed-off-by: Rites

[RFC PATCH 2/3] mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm

From: Sahitya Tummala Implement ->platform_dumpregs host operation to print the platform specific registers in addition to standard SDHC register during error conditions. Signed-off-by: Sahitya Tummala Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci-msm.c |

[PATCH 1/8] mmc: sdhci-msm: Factor out sdhci_msm_hc_select_mode

This factors out sdhci_msm_hc_select_mode to later use it during enhanced_strobe mode select. It also further breaks sdhci_msm_hc_select_mode into separate functions for configuring HS400 mode or other modes. Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/host/sdhci

[PATCH 1/8] mmc: sdhci-msm: Factor out sdhci_msm_hc_select_mode

This factors out sdhci_msm_hc_select_mode to later use it during enhanced_strobe mode select. It also further breaks sdhci_msm_hc_select_mode into separate functions for configuring HS400 mode or other modes. Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci-msm.c | 201

[PATCH 3/8] mmc: sdhci-msm: Factor out sdhci_msm_hs400

Factor out sdhci_msm_hs400 used for DLL calibration in HS400 modes. This function will be needed for enhanced_strobe as well. Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 32 ++-- 1 file changed, 26 insertions

[PATCH 6/8] mmc: sdhci: Clear SDHCI_HS400_TUNING flag after platform_execute_tuning

Clear SDHCI_HS400_TUNING flag after platform_execute_tuning so that platform_execute_tuning may use it if needed. Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/host/sdhci.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/s

[PATCH 4/8] mmc: sdhci-msm: Reset vendor specific func register on probe

ed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c inde

[PATCH 8/8] mmc: sdhci-msm: Provide enhanced_strobe mode feature support

This provides enhanced_strobe mode feature support in sdhci-msm driver. Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/sdhci-m

[PATCH 3/8] mmc: sdhci-msm: Factor out sdhci_msm_hs400

Factor out sdhci_msm_hs400 used for DLL calibration in HS400 modes. This function will be needed for enhanced_strobe as well. Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci-msm.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git

[PATCH 6/8] mmc: sdhci: Clear SDHCI_HS400_TUNING flag after platform_execute_tuning

Clear SDHCI_HS400_TUNING flag after platform_execute_tuning so that platform_execute_tuning may use it if needed. Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host

[PATCH 4/8] mmc: sdhci-msm: Reset vendor specific func register on probe

Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci-msm.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 5a37c29..a028568 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci

[PATCH 8/8] mmc: sdhci-msm: Provide enhanced_strobe mode feature support

This provides enhanced_strobe mode feature support in sdhci-msm driver. Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci-msm.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci

[PATCH 7/8] mmc: sdhci-msm: Make HS400 tuning follow as per recommeneded HW sequence

During tuning execution for HS400 mode, HW sequence recommends to select MCLK_SEL/2(0x3) in VENDOR_SPEC & sdhc msm clock at GCC to be 400MHZ (nearest supported clk). Add this change in tuning sequence during HS400 tuning. Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- d

[PATCH 5/8] mmc: sdhci-msm: configure CORE_CSR_CDC_DELAY_CFG to recommended value

From: Subhash Jadavani <subha...@codeaurora.org> Program CORE_CSR_CDC_DELAY_CFG for hardware recommended 1.25ns delay. We may see data CRC errors if it's programmed for any other delay value. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Ritesh H

[PATCH 5/8] mmc: sdhci-msm: configure CORE_CSR_CDC_DELAY_CFG to recommended value

From: Subhash Jadavani Program CORE_CSR_CDC_DELAY_CFG for hardware recommended 1.25ns delay. We may see data CRC errors if it's programmed for any other delay value. Signed-off-by: Subhash Jadavani Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci-msm.c | 2 +- 1 file changed, 1

[PATCH 7/8] mmc: sdhci-msm: Make HS400 tuning follow as per recommeneded HW sequence

During tuning execution for HS400 mode, HW sequence recommends to select MCLK_SEL/2(0x3) in VENDOR_SPEC & sdhc msm clock at GCC to be 400MHZ (nearest supported clk). Add this change in tuning sequence during HS400 tuning. Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci-msm.c

[PATCH 2/8] mmc: sdhci-msm: Factor out function to set/get msm clock rate

Factor out msm_set/get_clock_rate_for_bus_mode for it's later use in changing the tuning sequence for selecting HS400 bus speed mode. Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 64 +++- 1 file chang

[PATCH 0/8] mmc: sdhci-msm: Provide support for enhanced strobe

tuning. Patch 7 :- Implements an additional step as per HPG for HS400 tuning. Patch 8 :- Implements enhanced strobe functionality in sdhci-msm driver. Ritesh Harjani (6): mmc: sdhci-msm: Factor out sdhci_msm_hc_select_mode mmc: sdhci-msm: Factor out function to set/get msm clock rate mmc: sd

[PATCH 2/8] mmc: sdhci-msm: Factor out function to set/get msm clock rate

Factor out msm_set/get_clock_rate_for_bus_mode for it's later use in changing the tuning sequence for selecting HS400 bus speed mode. Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci-msm.c | 64 +++- 1 file changed, 40 insertions(+), 24 deletions

[PATCH 0/8] mmc: sdhci-msm: Provide support for enhanced strobe

tuning. Patch 7 :- Implements an additional step as per HPG for HS400 tuning. Patch 8 :- Implements enhanced strobe functionality in sdhci-msm driver. Ritesh Harjani (6): mmc: sdhci-msm: Factor out sdhci_msm_hc_select_mode mmc: sdhci-msm: Factor out function to set/get msm clock rate mmc: sd

Re: [PATCH 3/4] mmc: mmc: enable ios.enhanced_strobe before mmc_set_timing

be acceptable or not ? Regards Ritesh On 12/20/2016 11:23 AM, Ritesh Harjani wrote: Some controllers may need to configure few registers based on enhanced strobe mode while configuring to HS400 timing, thus make ios.enhanced_strobe to true before mmc_set_timing in mmc_select_hs400es. Signed-off

Re: [PATCH 3/4] mmc: mmc: enable ios.enhanced_strobe before mmc_set_timing

be acceptable or not ? Regards Ritesh On 12/20/2016 11:23 AM, Ritesh Harjani wrote: Some controllers may need to configure few registers based on enhanced strobe mode while configuring to HS400 timing, thus make ios.enhanced_strobe to true before mmc_set_timing in mmc_select_hs400es. Signed-off

Re: [PATCH 2/4] mmc: mmc: Add change to set controller to HS400 frequency in enhanced strobe

Hi Shawn, On 12/20/2016 4:33 PM, Shawn Lin wrote: On 2016/12/20 18:33, Ritesh Harjani wrote: Hi Shawn, On 12/20/2016 12:59 PM, Shawn Lin wrote: On 2016/12/20 13:53, Ritesh Harjani wrote: Currently mmc_select_hs400es is not setting the desired frequency before sending switch command

Re: [PATCH 2/4] mmc: mmc: Add change to set controller to HS400 frequency in enhanced strobe

Hi Shawn, On 12/20/2016 4:33 PM, Shawn Lin wrote: On 2016/12/20 18:33, Ritesh Harjani wrote: Hi Shawn, On 12/20/2016 12:59 PM, Shawn Lin wrote: On 2016/12/20 13:53, Ritesh Harjani wrote: Currently mmc_select_hs400es is not setting the desired frequency before sending switch command

Re: [PATCH 2/4] mmc: mmc: Add change to set controller to HS400 frequency in enhanced strobe

Hi Shawn, On 12/20/2016 12:59 PM, Shawn Lin wrote: On 2016/12/20 13:53, Ritesh Harjani wrote: Currently mmc_select_hs400es is not setting the desired frequency before sending switch command. This makes CMD13 to timeout on some controllers. Thus add a change to set the desired HS400 frequency

Re: [PATCH 2/4] mmc: mmc: Add change to set controller to HS400 frequency in enhanced strobe

Hi Shawn, On 12/20/2016 12:59 PM, Shawn Lin wrote: On 2016/12/20 13:53, Ritesh Harjani wrote: Currently mmc_select_hs400es is not setting the desired frequency before sending switch command. This makes CMD13 to timeout on some controllers. Thus add a change to set the desired HS400 frequency

[PATCH 4/4] mmc: sdhci-msm: provide enhanced_strobe mode feature support

This provide support for enhanced_strobe feature to sdhci-msm. Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drive

[PATCH 2/4] mmc: mmc: Add change to set controller to HS400 frequency in enhanced strobe

Currently mmc_select_hs400es is not setting the desired frequency before sending switch command. This makes CMD13 to timeout on some controllers. Thus add a change to set the desired HS400 frequency in mmc_select_hs400es when the timing is switched to HS400. Signed-off-by: Ritesh Harjani <r

[PATCH 4/4] mmc: sdhci-msm: provide enhanced_strobe mode feature support

This provide support for enhanced_strobe feature to sdhci-msm. Signed-off-by: Ritesh Harjani --- drivers/mmc/host/sdhci-msm.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index

[PATCH 2/4] mmc: mmc: Add change to set controller to HS400 frequency in enhanced strobe

Currently mmc_select_hs400es is not setting the desired frequency before sending switch command. This makes CMD13 to timeout on some controllers. Thus add a change to set the desired HS400 frequency in mmc_select_hs400es when the timing is switched to HS400. Signed-off-by: Ritesh Harjani

[PATCH 3/4] mmc: mmc: enable ios.enhanced_strobe before mmc_set_timing

Some controllers may need to configure few registers based on enhanced strobe mode while configuring to HS400 timing, thus make ios.enhanced_strobe to true before mmc_set_timing in mmc_select_hs400es. Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/core/mmc

[PATCH 1/4] mmc: core: Return from mmc_set_clock if hz is already set to ios.clock

Signed-off-by: Ritesh Harjani <rite...@codeaurora.org> --- drivers/mmc/core/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 543eadd..125f8a9 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -1139,6 +

[PATCH 0/4] mmc: Provide enhanced strobe support for sdhci-msm

Hi, Patch series is to enable enhanced strobe feature for sdhci-msm driver. But there are also some changes done in core layer for this. This was tested on msm8996 based interal target with emmc-5.1 card. Ritesh Harjani (4): mmc: core: Return from mmc_set_clock if hz is already set

[PATCH 3/4] mmc: mmc: enable ios.enhanced_strobe before mmc_set_timing

Some controllers may need to configure few registers based on enhanced strobe mode while configuring to HS400 timing, thus make ios.enhanced_strobe to true before mmc_set_timing in mmc_select_hs400es. Signed-off-by: Ritesh Harjani --- drivers/mmc/core/mmc.c | 8 +++- 1 file changed, 7

[PATCH 1/4] mmc: core: Return from mmc_set_clock if hz is already set to ios.clock

Signed-off-by: Ritesh Harjani --- drivers/mmc/core/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 543eadd..125f8a9 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -1139,6 +1139,9 @@ void mmc_set_clock

[PATCH 0/4] mmc: Provide enhanced strobe support for sdhci-msm

Hi, Patch series is to enable enhanced strobe feature for sdhci-msm driver. But there are also some changes done in core layer for this. This was tested on msm8996 based interal target with emmc-5.1 card. Ritesh Harjani (4): mmc: core: Return from mmc_set_clock if hz is already set

Re: [PATCH 2/7] blk-mq: abstract out blk_mq_dispatch_rq_list() helper

Minor comments. On 12/9/2016 1:43 AM, Jens Axboe wrote: Takes a list of requests, and dispatches it. Moves any residual requests to the dispatch list. Signed-off-by: Jens Axboe --- block/blk-mq.c | 85 -- block/blk-mq.h |

Re: [PATCH 2/7] blk-mq: abstract out blk_mq_dispatch_rq_list() helper

Minor comments. On 12/9/2016 1:43 AM, Jens Axboe wrote: Takes a list of requests, and dispatches it. Moves any residual requests to the dispatch list. Signed-off-by: Jens Axboe --- block/blk-mq.c | 85 -- block/blk-mq.h | 1 + 2 files

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

On 12/1/2016 11:38 PM, Georgi Djakov wrote: On 11/29/2016 05:40 AM, Ritesh Harjani wrote: Hi Georgi, On 11/28/2016 11:09 PM, Georgi Djakov wrote: On apq8016, apq8084 and apq8074 platforms, writing to the software reset register triggers the "power irq". We need to ack and hand

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

On 12/1/2016 11:38 PM, Georgi Djakov wrote: On 11/29/2016 05:40 AM, Ritesh Harjani wrote: Hi Georgi, On 11/28/2016 11:09 PM, Georgi Djakov wrote: On apq8016, apq8084 and apq8074 platforms, writing to the software reset register triggers the "power irq". We need to ack and hand

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

Hi Georgi, On 11/28/2016 11:09 PM, Georgi Djakov wrote: On apq8016, apq8084 and apq8074 platforms, writing to the software reset register triggers the "power irq". We need to ack and handle the irq, otherwise the following message appears: mmc0: Reset 0x1 never completed. sdhci: ===

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

Hi Georgi, On 11/28/2016 11:09 PM, Georgi Djakov wrote: On apq8016, apq8084 and apq8074 platforms, writing to the software reset register triggers the "power irq". We need to ack and handle the irq, otherwise the following message appears: mmc0: Reset 0x1 never completed. sdhci: ===

Re: [PATCH] mmc: sdhci-msm: Add sdhci_reset() implementation

Hi Georgi, I collected some info on this problem. May be below info might help you. I think "Reset 0x1" problem is occurring because of below call stack. SDHCI_RESET_ALL to SDHCI_SOFTWARE_RESET register will anyway trigger the sdhci_msm_pwr_irq. But I think the problem is that the above

Re: [PATCH] mmc: sdhci-msm: Add sdhci_reset() implementation

Hi Georgi, I collected some info on this problem. May be below info might help you. I think "Reset 0x1" problem is occurring because of below call stack. SDHCI_RESET_ALL to SDHCI_SOFTWARE_RESET register will anyway trigger the sdhci_msm_pwr_irq. But I think the problem is that the above

Re: [PATCH v4] mmc: sdhci-msm: Add pm_runtime and system PM support

Hi Pramod, Thanks for this patch. Few minor comments. I have tested your patch on db410c and 8996 based internal platform and it works fine. On 10/18/2016 3:46 PM, Pramod Gurav wrote: Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM

Re: [PATCH v4] mmc: sdhci-msm: Add pm_runtime and system PM support

Hi Pramod, Thanks for this patch. Few minor comments. I have tested your patch on db410c and 8996 based internal platform and it works fine. On 10/18/2016 3:46 PM, Pramod Gurav wrote: Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

Hi Ulf, On 9/23/2016 3:37 PM, Ulf Hansson wrote: [...] Is there anything else needed in msm sdhci driver so that the auto tuning is taken care of? I am not familiar with any other than sdhci-esdhc-imx which supports the SDHCI_TUNING_MODE_3. I may be wrong though. In the sdhci-esdhc-imx

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

Hi Ulf, On 9/23/2016 3:37 PM, Ulf Hansson wrote: [...] Is there anything else needed in msm sdhci driver so that the auto tuning is taken care of? I am not familiar with any other than sdhci-esdhc-imx which supports the SDHCI_TUNING_MODE_3. I may be wrong though. In the sdhci-esdhc-imx

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

Hi Pramod, On 9/15/2016 7:28 PM, Pramod Gurav wrote: On 15 September 2016 at 15:49, Ulf Hansson wrote: On 15 September 2016 at 09:59, Pramod Gurav wrote: On 9 September 2016 at 15:48, Georgi Djakov wrote: On

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

Hi Pramod, On 9/15/2016 7:28 PM, Pramod Gurav wrote: On 15 September 2016 at 15:49, Ulf Hansson wrote: On 15 September 2016 at 09:59, Pramod Gurav wrote: On 9 September 2016 at 15:48, Georgi Djakov wrote: On 09/08/2016 11:02 AM, Adrian Hunter wrote: On 01/09/16 17:23, Pramod Gurav

Re: [PATCH v2] ARM: mm: Do not invoke OOM for higher order IOMMU DMA allocations

On Thu, Mar 26, 2015 at 6:04 AM, David Rientjes wrote: > On Thu, 26 Mar 2015, Ritesh Harjani wrote: > >> > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c >> > index 83cd5ac..3f1ac51 100644 >> > --- a/arch/arm/mm/dma-mapping.c >

Re: [PATCH v2] ARM: mm: Do not invoke OOM for higher order IOMMU DMA allocations

Hi On Mon, Mar 23, 2015 at 12:57 PM, Tomasz Figa wrote: > IOMMU should be able to use single pages as well as bigger blocks, so if > higher order allocations fail, we should not affect state of the system, > with events such as OOM killer, but rather fall back to order 0 > allocations. > > This

Re: [PATCH v2] ARM: mm: Do not invoke OOM for higher order IOMMU DMA allocations

Hi On Mon, Mar 23, 2015 at 12:57 PM, Tomasz Figa tf...@chromium.org wrote: IOMMU should be able to use single pages as well as bigger blocks, so if higher order allocations fail, we should not affect state of the system, with events such as OOM killer, but rather fall back to order 0

Re: [PATCH v2] ARM: mm: Do not invoke OOM for higher order IOMMU DMA allocations

On Thu, Mar 26, 2015 at 6:04 AM, David Rientjes rient...@google.com wrote: On Thu, 26 Mar 2015, Ritesh Harjani wrote: diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 83cd5ac..3f1ac51 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c

Re: [PATCH 1/1] device.h: arm,dma-iommu: Move out dma_iommu_mapping struct

Hi Greg, On Thu, Jun 5, 2014 at 12:29 AM, Greg KH wrote: > On Thu, Jun 05, 2014 at 12:16:28AM +0530, Ritesh Harjani wrote: >> Hi Greg, >> >> Thanks for reviewing. >> >> On Wed, Jun 4, 2014 at 11:21 PM, Greg KH wrote: >> > On Wed, Jun 04, 2014 at 01:41:

Re: [PATCH 1/1] device.h: arm,dma-iommu: Move out dma_iommu_mapping struct

Hi Greg, On Thu, Jun 5, 2014 at 12:29 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jun 05, 2014 at 12:16:28AM +0530, Ritesh Harjani wrote: Hi Greg, Thanks for reviewing. On Wed, Jun 4, 2014 at 11:21 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 04, 2014 at 01:41:46PM

Re: [PATCH 1/1] device.h: arm,dma-iommu: Move out dma_iommu_mapping struct

Hi Greg, Thanks for reviewing. On Wed, Jun 4, 2014 at 11:21 PM, Greg KH wrote: > On Wed, Jun 04, 2014 at 01:41:46PM +0530, ritesh.harj...@gmail.com wrote: >> From: Ritesh Harjani >> >> This patch moves out *mapping pointer of dma_iommu_mapping >> from arch/arm/incl

Re: [PATCH 1/1] device.h: arm,dma-iommu: Move out dma_iommu_mapping struct

Hi Greg, Thanks for reviewing. On Wed, Jun 4, 2014 at 11:21 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 04, 2014 at 01:41:46PM +0530, ritesh.harj...@gmail.com wrote: From: Ritesh Harjani ritesh.harj...@gmail.com This patch moves out *mapping pointer of dma_iommu_mapping from

Re: [PATCH v2 3/3] CMA: always treat free cma pages as non-free on watermark checking

Hi Joonsoo, CC'ing the developer of the patch (Tomasz Stanislawski) On Fri, May 30, 2014 at 8:16 PM, Joonsoo Kim wrote: > 2014-05-30 19:40 GMT+09:00 Ritesh Harjani : >> Hi Joonsoo, >> >> I think you will be loosing the benefit of below patch with your changes. >> I

Re: [PATCH v2 3/3] CMA: always treat free cma pages as non-free on watermark checking

Hi Joonsoo, CC'ing the developer of the patch (Tomasz Stanislawski) On Fri, May 30, 2014 at 8:16 PM, Joonsoo Kim js1...@gmail.com wrote: 2014-05-30 19:40 GMT+09:00 Ritesh Harjani ritesh.l...@gmail.com: Hi Joonsoo, I think you will be loosing the benefit of below patch with your changes. I

Re: [PATCH v2 3/3] CMA: always treat free cma pages as non-free on watermark checking

Hi Joonsoo, I think you will be loosing the benefit of below patch with your changes. I am no expert here so please bear with me. I tried explaining in the inline comments, let me know if I am wrong. commit 026b08147923142e925a7d0aaa39038055ae0156 Author: Tomasz Stanislawski Date: Wed Jun 12

Re: [PATCH v2 3/3] CMA: always treat free cma pages as non-free on watermark checking

Hi Joonsoo, I think you will be loosing the benefit of below patch with your changes. I am no expert here so please bear with me. I tried explaining in the inline comments, let me know if I am wrong. commit 026b08147923142e925a7d0aaa39038055ae0156 Author: Tomasz Stanislawski

<    1   2   3