[PATCH v2 10/13] dmaengine: pxa: document pxad_param

2018-05-24 Thread Robert Jarzmik
Add some documentation for the pxad_param structure, and describe the contract behind the minimal required priority of a DMA channel. Signed-off-by: Robert Jarzmik --- include/linux/dma/pxa-dma.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/dma/pxa-dma.h b/include

[PATCH v2 12/13] ARM: pxa: remove the DMA IO resources

2018-05-24 Thread Robert Jarzmik
As the last driver using the former mechanism to acquire the DMA requestor line has be converted to the dma_slave_map, remove all these resources from the PXA devices. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 136 1 file

[PATCH v2 02/13] ARM: pxa: add dma slave map

2018-05-24 Thread Robert Jarzmik
In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static, and the DMA resources removed from device.c. Signed-off-by: Robert

[PATCH v2 08/13] ASoC: pxa: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- sound/arm/pxa2xx-ac97.c | 14 ++ sound/arm/pxa2xx-pcm-lib.c | 6 +++--- sound/soc/pxa/pxa2xx-ac97.c | 32 +--- sound/soc/pxa/pxa2xx-i2s.c | 6 ++ 4 files changed, 12 insertions(+), 46 deletions(-) diff --git a/sound

[PATCH v2 06/13] net: smc911x: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc911x.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 05157442a980..4c3713bd5caa 100644 --- a/drivers/net/ethernet/smsc

[PATCH v2 09/13] ata: pata_pxa: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik Acked-by: Bartlomiej Zolnierkiewicz --- drivers/ata/pata_pxa.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index f6c46e9a4dc0..e8b6a2e464c9 100644 --- a/drivers/ata/pata_pxa.c +++ b/drivers

[PATCH v2 01/13] dmaengine: pxa: use a dma slave map

2018-05-24 Thread Robert Jarzmik
tatic, and the DMA resources removed from device.c. Signed-off-by: Robert Jarzmik Reported-by: Arnd Bergmann Acked-by: Vinod Koul --- drivers/dma/pxa_dma.c | 10 +- include/linux/platform_data/mmp_dma.h | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --

[PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Signed-off-by: Daniel Mack Signed-off-by: Robert Jarzmik --- drivers/mtd/nand/raw/marvell_nand.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c index 10e953218948

[PATCH v2 03/13] mmc: pxamci: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik Acked-by: Ulf Hansson --- drivers/mmc/host/pxamci.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index c763b404510f..6c94474e36f4 100644 --- a/drivers/mmc/host

[PATCH v2 04/13] media: pxa_camera: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- drivers/media/platform/pxa_camera.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c index

[PATCH v2 11/13] dmaengine: pxa: make the filter function internal

2018-05-24 Thread Robert Jarzmik
As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma

[PATCH v2 13/13] ARM: pxa: change SSP DMA channels allocation

2018-05-24 Thread Robert Jarzmik
x" or "tx". - for device tree platforms, the dma node should be hooked into the pxa2xx-ac97 or pxa-ssp-dai node. Signed-off-by: Robert Jarzmik --- Since v1: Removed channel names from platform_data --- arch/arm/plat-pxa/ssp.c| 47 -

[PATCH v2 07/13] net: smc91x: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.c | 12 +--- drivers/net/ethernet/smsc/smc91x.h | 1 - 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index 080428762858..4c600f430f6d

[PATCH v2 00/13] ARM: pxa: switch to DMA slave maps

2018-05-24 Thread Robert Jarzmik
that the cpu device provides the DMA - I added pxa2xx-i2s which was forgotten Therefore I need a new ack - Arnd and Daniel / SSP topic / 0013 Review and ack of this one Happy review. -- Robert Robert Jarzmik (13): dmaengine: pxa: use a dma slave map ARM: pxa: add dma slave map

Re: [PATCH 29/61] mtd: devices: simplify getting .drvdata

2018-04-21 Thread Robert Jarzmik
Wolfram Sang writes: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need

2018-04-21 Thread Robert Jarzmik
Robert Jarzmik writes: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource acquisition, using the more >

Re: [PATCH 09/15] net: irda: pxaficp_ir: remove the dmaengine compat need

2018-04-21 Thread Robert Jarzmik
Robert Jarzmik writes: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource acquisition, using the more >

Re: [PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

2018-04-21 Thread Robert Jarzmik
Robert Jarzmik writes: > From: Robert Jarzmik > > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource a

Re: [PATCH 1/7] i2c: i2c-gpio: move header to platform_data

2018-04-20 Thread Robert Jarzmik
Wolfram Sang writes: > This header only contains platform_data. Move it to the proper directory. > > Signed-off-by: Wolfram Sang For mach-pxa: Acked-by: Robert Jarzmik Take it through your tree, no problem for the pxa part. Cheers. -- Robert

Re: [PATCH 08/15] ASoC: pxa: remove the dmaengine compat need

2018-04-12 Thread Robert Jarzmik
Mark Brown writes: > On Mon, Apr 02, 2018 at 04:26:49PM +0200, Robert Jarzmik wrote: >> As the pxa architecture switched towards the dmaengine slave map, the >> old compatibility mechanism to acquire the dma requestor line number and >> priority are not needed anymore. >

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-08 Thread Robert Jarzmik
Arnd Bergmann writes: > I don't know exactly how the probing works, but I'd assume that we have > the correct device pointers in pxa2xx_ac97_dev_probe() and > asoc_ssp_probe(), or maybe in pxa2xx_ac97_*_startup() and > pxa_ssp_startup(). Yes, let's try this way, in the former patch "ASoC: pxa:

Re: [RESEND PATCH] ARM: pxa: stargate2: use device properties for at24 eeprom

2018-04-08 Thread Robert Jarzmik
Bartosz Golaszewski writes: > 2018-04-04 21:44 GMT+02:00 Robert Jarzmik : >> Bartosz Golaszewski writes: > Yes, it does use the type field from i2c_board_info implicitly over > i2c-core. The type field is copied over to client->name and then is > matched against the i2c I

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-04 Thread Robert Jarzmik
Arnd Bergmann writes: > I'm still unable to follow through that code, but I understand now that > the device you pass to dma_request_slave_channel() is not the one > we'd like it to be here. > > Where exactly does that call to dma_request_chan() happen? Is this > the one in dmaengine_pcm_new()? C

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-04 Thread Robert Jarzmik
Ulf Hansson writes: > On 2 April 2018 at 16:26, Robert Jarzmik wrote: >> Hi, >> >> This serie is aimed at removing the dmaengine slave compat use, and transfer >> knowledge of the DMA requestors into architecture code. >> As this looks like a patch bomb, each m

Re: [RESEND PATCH] ARM: pxa: stargate2: use device properties for at24 eeprom

2018-04-04 Thread Robert Jarzmik
Bartosz Golaszewski writes: > We want to work towards phasing out the at24_platform_data structure. > There are few users and its contents can be represented using generic > device properties. Using device properties only will allow us to > significantly simplify the at24 configuration code. > >

Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-04 Thread Robert Jarzmik
Arnd Bergmann writes: > On Tue, Apr 3, 2018 at 10:19 PM, Robert Jarzmik > wrote: >> ... chop chop removing unneeded recipients >> >> Arnd Bergmann writes: >>> It still feels odd to me that there is an entry in the slave map for >>> a device that

Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-03 Thread Robert Jarzmik
... chop chop removing unneeded recipients Arnd Bergmann writes: > Ok, I looked at the driver in more detail now and found the scary parts. > So it's using the async DMA interface to do synchronous DMA in > interrupt context in order to transfer the rx data faster than an readsl() > would,

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-03 Thread Robert Jarzmik
Arnd Bergmann writes: chop chop ... removed several mail recipients to leave only the ASoC / PXA subset ... > On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > >> >> +static struct pxa_ssp_info pxa_ssp_infos[] = { >> + { .dma_chan_rx_name = "ssp1_rx&q

Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-03 Thread Robert Jarzmik
Arnd Bergmann writes: >> + { "smc911x.0", "rx", PDMA_FILTER_PARAM(LOWEST, -1) }, >> + { "smc911x.0", "tx", PDMA_FILTER_PARAM(LOWEST, -1) }, >> + { "smc91x.0", "data", PDMA_FILTER_PARAM(LOWEST, -1) }, > > This one is interesting, as you are dealing with an off-chip device, > and

[PATCH 02/15] ARM: pxa: add dma slave map

2018-04-02 Thread Robert Jarzmik
In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static, and the DMA resources removed from device.c. Signed-off-by: Robert

[PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 08/15] ASoC: pxa: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- sound/arm/pxa2xx-ac97.c | 14 ++ sound/arm/pxa2xx-pcm-lib.c | 6 +++--- sound/soc/pxa/pxa2xx-ac97.c | 32 +--- 3 files changed, 10 insertions(+), 42 deletions(-) diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c

[PATCH 09/15] net: irda: pxaficp_ir: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- drivers/staging/irda/drivers/pxaficp_ir.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c b/drivers/staging/irda/drivers/pxaficp_ir.c index 2ea00a6531f9..9dd6e21dc11e 100644 --- a/drivers

[PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- drivers/ata/pata_pxa.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index f6c46e9a4dc0..e8b6a2e464c9 100644 --- a/drivers/ata/pata_pxa.c +++ b/drivers/ata/pata_pxa.c @@ -25,7 +25,6

[PATCH 11/15] dmaengine: pxa: document pxad_param

2018-04-02 Thread Robert Jarzmik
Add some documentation for the pxad_param structure, and describe the contract behind the minimal required priority of a DMA channel. Signed-off-by: Robert Jarzmik --- include/linux/dma/pxa-dma.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/dma/pxa-dma.h b/include

[PATCH 15/15] ARM: pxa: change SSP DMA channels allocation

2018-04-02 Thread Robert Jarzmik
device tree platforms, the dma node should be hooked into the pxa-pcm-audio node. Signed-off-by: Robert Jarzmik --- arch/arm/plat-pxa/ssp.c| 50 +- include/linux/pxa2xx_ssp.h | 4 ++-- sound/soc/pxa/pxa-ssp.c| 5 ++--- 3 files changed, 9

[PATCH 12/15] dmaengine: pxa: make the filter function internal

2018-04-02 Thread Robert Jarzmik
As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma

[PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-02 Thread Robert Jarzmik
In order to prepare for the dma_slave_map change for SSP DMA channels allocation, the SSP platform devices will now include a platform data structure which in turn selects which dma channel has to be used for data transfers, especially the PCM ones. Signed-off-by: Robert Jarzmik --- arch/arm

[PATCH 13/15] ARM: pxa: remove the DMA IO resources

2018-04-02 Thread Robert Jarzmik
As the last driver using the former mechanism to acquire the DMA requestor line has be converted to the dma_slave_map, remove all these resources from the PXA devices. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 136 1 file

[PATCH 07/15] net: smc91x: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 01/15] dmaengine: pxa: use a dma slave map

2018-04-02 Thread Robert Jarzmik
tatic, and the DMA resources removed from device.c. Signed-off-by: Robert Jarzmik Reported-by: Arnd Bergmann --- drivers/dma/pxa_dma.c | 10 +- include/linux/platform_data/mmp_dma.h | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/dma/pxa_

[PATCH 03/15] mmc: pxamci: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- drivers/mmc/host/pxamci.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index c763b404510f..6c94474e36f4 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc

[PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 06/15] net: smc911x: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-02 Thread Robert Jarzmik
ware, including : - pxamci - pxa_camera - smc* - ASoC and SSP Happy review. Robert Jarzmik (15): dmaengine: pxa: use a dma slave map ARM: pxa: add dma slave map mmc: pxamci: remove the dmaengine compat need media: pxa_camera: remove the dmaengine compat need mtd: nand: pxa3xx: remov

Re: [PATCH 18/21] regulator: fixed/gpio: Pull inversion/OD into gpiolib

2018-02-17 Thread Robert Jarzmik
Linus Walleij writes: > This pushes the handling of inversion semantics and open drain > settings to the GPIO descriptor and gpiolib. All affected board > files are also augmented. Hi Linus, Could we split the patch into chunks, one for i2c, one for pxa, etc ... I fear that exceptionally I have

Re: [PATCH 00/20] Remove references to undefined symbols and fix two potential bugs

2018-02-07 Thread Robert Jarzmik
Ulf Magnusson writes: > The symbol AC97_BUS_NEW in sound/ac97/Kconfig selects the globally > undefined symbol AC97. > > It doesn't seem to simply be a misspelling of AC97_BUS, because then > the dependencies of AC97_BUS_COMPAT would be impossible to satisfy. You're correct. I don't know what hap

Re: [PATCH] ARM: pxa/tosa-bt: add MODULE_LICENSE tag

2018-01-19 Thread Robert Jarzmik
Arnd Bergmann writes: > On Wed, Jan 10, 2018 at 9:22 PM, Robert Jarzmik > wrote: >> Arnd Bergmann writes: >> >>> Without this tag, we get a build warning: >>> >>> WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o >>

Re: [PATCH v3 RESEND] cpufreq: pxa: convert to clock API

2018-01-11 Thread Robert Jarzmik
Viresh Kumar writes: > On 11-01-18, 09:10, Robert Jarzmik wrote: >> Robert Jarzmik writes: >> >> > As the clock settings have been introduced into the clock pxa drivers, >> > which are now available to change the CPU clock by themselves, remove >> >

Re: [PATCH v3 RESEND] cpufreq: pxa: convert to clock API

2018-01-11 Thread Robert Jarzmik
Robert Jarzmik writes: > As the clock settings have been introduced into the clock pxa drivers, > which are now available to change the CPU clock by themselves, remove > the clock handling from this driver, and rely on pxa clock drivers. > > Signed-off-by: Robert Jarzmik >

Re: [PATCH] ARM: pxa/tosa-bt: add MODULE_LICENSE tag

2018-01-10 Thread Robert Jarzmik
Arnd Bergmann writes: > Without this tag, we get a build warning: > > WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o > > For completeness, I'm also adding author and description fields. > > Signed-off-by: Arnd Bergmann Queued into pxa/for-next, thanks. Cheers. -- Rob

[PATCH v3] backlight: tdo24m: fix the spi cs between transfers

2017-12-28 Thread Robert Jarzmik
commit a52db659c79c ("spi: pxa2xx: Fix cs_change management") for PXA based boards. This fix makes the TD035S work again on a cm-x300 board. The same applies to other PXA boards, ie. corgi and tosa. Fixes: a52db659c79c ("spi: pxa2xx: Fix cs_change management") Reported-by: And

Re: [PATCH v2 2/3] backlight: tdo24m: add the reset line gpio

2017-12-24 Thread Robert Jarzmik
Robert Jarzmik writes: > Daniel Thompson writes: > >> On Fri, Oct 13, 2017 at 09:42:48PM +0200, Robert Jarzmik wrote: >> Also, this adds a new optional property, doesn't the devicetree binding >> docs need to be update to match this? > Ah yes, that too. I&#x

Re: [PATCH v2 1/3] backlight: tdo24m: fix the spi cs between transfers

2017-12-16 Thread Robert Jarzmik
Daniel Thompson writes: > On Fri, Oct 13, 2017 at 09:42:47PM +0200, Robert Jarzmik wrote: >> Currently the LCD display (TD035S) on the cm-x300 platform is broken and >> remains blank. > Didn't I already ack this one? Ah yes, I forgot to report the Ack, sorry, I'

Re: [PATCH v2 3/3] backlight: tdo24m: add model and status sysfs entries

2017-12-16 Thread Robert Jarzmik
Daniel Thompson writes: > On Fri, Oct 13, 2017 at 09:42:49PM +0200, Robert Jarzmik wrote: >> Add entries to query the panel ASIC to acquire the model number and the >> status field. This comes in handy to check that the SPI connection is >> functional and that the pane

Re: [PATCH v2 2/3] backlight: tdo24m: add the reset line gpio

2017-12-16 Thread Robert Jarzmik
Daniel Thompson writes: > On Fri, Oct 13, 2017 at 09:42:48PM +0200, Robert Jarzmik wrote: >> The Toppoly panels have a global reset line. Add an optional gpio >> control for this line, for platforms which have the ability to drive it. >> >> Signed-off-by: Robert

Re: [PATCH v2 1/3] backlight: tdo24m: fix the spi cs between transfers

2017-12-14 Thread Robert Jarzmik
Robert Jarzmik writes: > Currently the LCD display (TD035S) on the cm-x300 platform is broken and > remains blank. ... blablabla ... Could I know when this serie can be cherry-picked please ? Cheers. -- Robert

Re: [PATCH 1/4] ARM: pxa/corgi: Remove hardcoded partitioning, use sharpslpart parser

2017-11-28 Thread Robert Jarzmik
Andrea Adami writes: > With the introduction of sharpslpart partition parser we can now read the > offsets from NAND: we specify the list of the parsers as platform data, with > cmdlinepart and ofpart parsers first allowing to override the part. table > written in NAND. This is done here in the b

Re: [PATCH 3/4] ARM: pxa/spitz: Remove hardcoded partitioning, use sharpslpart parser

2017-11-28 Thread Robert Jarzmik
Andrea Adami writes: > On Thu, Nov 23, 2017 at 12:06 AM, Pavel Machek wrote: >> On Tue 2017-11-21 22:43:50, Andrea Adami wrote: Pavel, given that you didn't challenge Andrea's statement, I assume QEMU users will switch to mtdparts again. I'll apply the serie to pxa/for-next. Cheers. -- Rober

Re: [PATCH v5 0/9] mtd: sharpslpart partition parser

2017-11-08 Thread Robert Jarzmik
Boris Brezillon writes: >> Hi Boris, >> >> So what's the status about the sync, should I pick the patches, and have the >> others make it to your for-next branch ? > > It's been merged in l2-mtd/master (our -next branch) which is > targeting 4.15. Unfortunately we didn't create a topic branch, w

Re: [PATCH][V2] usb: gadget: pxa27x: Remove redundant assignment to is_short and dev

2017-11-07 Thread Robert Jarzmik
t is updated a few statements later, this too is > redundant and can be removed. Cleans up clan warnings: > > drivers/usb/gadget/udc/pxa27x_udc.c:986:3: warning: Value stored > to 'is_short' is never read > drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored > to

Re: [PATCH] i2c: pxa: move header file out of deprecated i2c folder

2017-10-29 Thread Robert Jarzmik
Wolfram Sang writes: Hi Wolfram, > Wouldn't it be even cleaner if patch 1 & 2 above would be swapped? First > move the chunk, then rename the file? Yeah sure. > And is there a branch I should base this on? Currently, I am thinking of > basing this patch on for-next and then submit it around rc1

Re: [PATCH] arm: pxa: Convert timers to use timer_setup()

2017-10-17 Thread Robert Jarzmik
nter. > > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Kees Cook Applied to pxa/for-next tree, thanks. -- Robert

Re: [PATCH] Makefile: Another fix for stackprotector _AUTO mode

2017-10-15 Thread Robert Jarzmik
Kees Cook writes: > If the compiler didn't support a build mode, the second empty test would > still trip. This moves it to an "else" test for the non-AUTO modes. > > Reported-by: Robert Jarzmik > Signed-off-by: Kees Cook > --- > Robert, can you test

[PATCH v3 RESEND] cpufreq: pxa: convert to clock API

2017-10-14 Thread Robert Jarzmik
As the clock settings have been introduced into the clock pxa drivers, which are now available to change the CPU clock by themselves, remove the clock handling from this driver, and rely on pxa clock drivers. Signed-off-by: Robert Jarzmik Acked-by: Viresh Kumar --- This is a resend of a

[PATCH] ASoC: wm97xx: fix compilation corner case

2017-10-14 Thread Robert Jarzmik
When the old AC97 is not used, CONFIG_SND_SOC_AC97_BUS is not defined. As a consequence, in the error path, snd_soc_free_ac97_codec() is not defined and triggers a compilation error. Fix it for wm9705 and wm9712, as wm9713 is correctly written. Signed-off-by: Robert Jarzmik --- sound/soc

Stack protector kernel build error

2017-10-14 Thread Robert Jarzmik
Hi Kees, Today my linux-next build broke for the pxa architecture. My specific setup is : - ARCH=arm make pxa_defconfig; ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- make - my compiler is: rj@belgarion:~/mio_linux/kernel$ arm-linux-gnueabi-gcc --version arm-linux-gnueabi-gcc (Debian

Re: [PATCH] i2c: pxa: move header file out of deprecated i2c folder

2017-10-13 Thread Robert Jarzmik
Wolfram Sang writes: > include/linux/i2c is deprecated because too many platform_data of i2c > clients incorrectly ended up there. The few still relevant include files > for I2C bus masters with their platform_data have been moved to the > platform_data directory. This final one, PXA, is not enti

[PATCH v2 2/3] backlight: tdo24m: add the reset line gpio

2017-10-13 Thread Robert Jarzmik
The Toppoly panels have a global reset line. Add an optional gpio control for this line, for platforms which have the ability to drive it. Signed-off-by: Robert Jarzmik --- drivers/video/backlight/tdo24m.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/backlight/tdo24m.c b

[PATCH v2 3/3] backlight: tdo24m: add model and status sysfs entries

2017-10-13 Thread Robert Jarzmik
Add entries to query the panel ASIC to acquire the model number and the status field. This comes in handy to check that the SPI connection is functional and that the panel's firmware is alive. Signed-off-by: Robert Jarzmik --- drivers/video/backlight/tdo24m.c

[PATCH v2 1/3] backlight: tdo24m: fix the spi cs between transfers

2017-10-13 Thread Robert Jarzmik
commit a52db659c79c ("spi: pxa2xx: Fix cs_change management") for PXA based boards. This fix makes the TD035S work again on a cm-x300 board. The same applies to other PXA boards, ie. corgi and tosa. Fixes: a52db659c79c ("spi: pxa2xx: Fix cs_change management") Reported-by: And

Re: [PATCH 1/3] backlight: tdo24m: fix the spi cs between transfers

2017-10-09 Thread Robert Jarzmik
Daniel Thompson writes: > On 06/10/17 20:58, Robert Jarzmik wrote: > > I'm a tiny bit worried about see-saw bug fixing here but nevertheless this > change looks correct to me. > > Mike's change was eight years ago and it is reasonable to hope that the patch > w

Re: [PATCH v5 0/9] mtd: sharpslpart partition parser

2017-10-08 Thread Robert Jarzmik
Robert Jarzmik writes: > Boris Brezillon writes: > >> Hi Robert, >> Wait a bit before applying. I think patches 6 to 9 have a dependency on >> patch 1 (it's not a build dependency, but NAND partitioning might be >> wrong if you apply them), so we need to sy

[PATCH 3/3] backlight: tdo24m: add model and status sysfs entries

2017-10-06 Thread Robert Jarzmik
Add entries to query the panel ASIC to acquire the model number and the status field. This comes in handy to check that the SPI connection is functional and that the panel's firmware is alive. Signed-off-by: Robert Jarzmik --- drivers/video/backlight/tdo24m.c

[PATCH 2/3] backlight: tdo24m: add the reset line gpio

2017-10-06 Thread Robert Jarzmik
The Toppoly panels have a global reset line. Add an optional gpio control for this line, for platforms which have the ability to drive it. Signed-off-by: Robert Jarzmik --- drivers/video/backlight/tdo24m.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/backlight/tdo24m.c b

[PATCH 1/3] backlight: tdo24m: fix the spi cs between transfers

2017-10-06 Thread Robert Jarzmik
ct changes between transfers") Signed-off-by: Robert Jarzmik --- drivers/video/backlight/tdo24m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/tdo24m.c b/drivers/video/backlight/tdo24m.c index eab1f842f9c0..e4bd63e9db6b 100644 --- a/drivers/

Re: linux-next: build failure after merge of the sound-asoc tree

2017-09-20 Thread robert . jarzmik
Hi Stephen and Mark, This is my mess. And today my mailer is not my usual one, please don't blame me for its probably awfull rendering. Somehow, in my last serie, in wm9712_soc_probe(), a closing bracket has disappeared. This affects only wm9712.c, not the others, ie. the commit : - 2ed1a8e "AS

Re: [PATCH] clk: pxa: fix building on older compilers

2017-09-19 Thread Robert Jarzmik
raneous ':' to let all compilers parse the > driver correctly. > > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert

[PATCH v7 7/8] ASoC: wm9705: add ac97 new bus support

2017-09-13 Thread Robert Jarzmik
Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik Acked-by: Charles Keepax --- Since v4: - added #ifdef spotted by Charles - tentatively kept Charles's ack Since v6: reworked wm9705_soc_remove() --- sound/soc/c

[PATCH v7 2/8] mfd: wm97xx-core: core support for wm97xx Codec

2017-09-13 Thread Robert Jarzmik
withstand the new AC97 bus model, where codecs are discovered on runtime. Signed-off-by: Robert Jarzmik Acked-by: Charles Keepax Acked-by: Lee Jones --- Since v3: - added a "depends on AC97_BUS_NEW" Kconfig statement - added default values for wm9705, wm9712 per Charles's comment Sin

[PATCH v7 1/8] Input: wm97xx: split out touchscreen registering

2017-09-13 Thread Robert Jarzmik
specific from the remaining part. This is only code shuffling, there is no functional change. Signed-off-by: Robert Jarzmik Acked-by: Dmitry Torokhov Acked-by: Charles Keepax --- Since v1: - took into account Charles's comment --- drivers/input/touchscreen/wm97xx-core.c

[PATCH v7 3/8] Input: wm97xx: add new AC97 bus support

2017-09-13 Thread Robert Jarzmik
l" as the touchscreen driver. This was tested on the pxa architecture with a pxa270 + wm9713 + the mioa701 touchscreen. Signed-off-by: Robert Jarzmik Acked-by: Charles Keepax Acked-by: Dmitry Torokhov --- drivers/input/touchscreen/Kconfig | 2 +- drivers/input/touchscreen/wm97xx-c

[PATCH v7 4/8] ASoC: wm9713: add ac97 new bus support

2017-09-13 Thread Robert Jarzmik
Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik Acked-by: Charles Keepax --- Since v6: reworked wm9713_soc_remove() --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9713.c | 39

[PATCH v7 6/8] ASoC: wm9705: add private structure

2017-09-13 Thread Robert Jarzmik
Add a private data structure. This is a preparation for a codec which would need an another data on top of snd_ac97, which will be the case when an MFD wm97xx device will probe wm9705. Signed-off-by: Robert Jarzmik Acked-by: Charles Keepax --- sound/soc/codecs/wm9705.c | 36

[PATCH v7 8/8] ASoC: pxa: switch to new ac97 bus support

2017-09-13 Thread Robert Jarzmik
Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik --- Since v1: split into 2 patches, the former being XXX ac97 codec agnostic Since v2: fix driver unregistration Since v3: added platform driver data for controller removal

[PATCH v7 5/8] ASoC: wm9712: add ac97 new bus support

2017-09-13 Thread Robert Jarzmik
Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik --- Since v4: - added #ifdef spotted by Charles Since v6: reworked wm9712_soc_remove() --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9712.c | 44

[PATCH v7 0/8] AC97 device/driver model revamp

2017-09-13 Thread Robert Jarzmik
the last serie. As before Charles, I think your ack is not granted anymore for codecs, could you have a look please ? Cheers. -- Robert Robert Jarzmik (8): Input: wm97xx: split out touchscreen registering mfd: wm97xx-core: core support for wm97xx Codec Input: wm97xx: add new AC97 bus

Re: [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_probe()

2017-09-09 Thread Robert Jarzmik
SF Markus Elfring writes: > From: Markus Elfring > Date: Fri, 8 Sep 2017 22:05:14 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by:

Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support

2017-09-04 Thread Robert Jarzmik
Charles Keepax writes: > On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote: >> Add support for the new ac97 bus model, where devices are automatically >> discovered on AC-Links. >> >> Signed-off-by: Robert Jarzmik >> --- >> Since v4

[PATCH v6 03/12] ASoC: add new ac97 bus support

2017-09-02 Thread Robert Jarzmik
Add the new ac97 bus support, with ac97 bus automatic probing. Signed-off-by: Robert Jarzmik Acked-by: Charles Keepax --- sound/Kconfig | 2 ++ sound/Makefile | 1 + 2 files changed, 3 insertions(+) diff --git a/sound/Kconfig b/sound/Kconfig index ee2e69a9ecd1..141b145c4195 100644 --- a

[PATCH v6 02/12] ALSA: ac97: add an ac97 bus

2017-09-02 Thread Robert Jarzmik
create mode 100644 sound/ac97/snd_ac97_compat.c diff --git a/include/sound/ac97/codec.h b/include/sound/ac97/codec.h new file mode 100644 index ..ec04be9ab119 --- /dev/null +++ b/include/sound/ac97/codec.h @@ -0,0 +1,118 @@ +/* + * Copyright (C) 2016 Robert Jarzmik + * + * This program

[PATCH v6 00/12] AC97 device/driver model revamp

2017-09-02 Thread Robert Jarzmik
following Lee's review, if you don't agree Charles, I'll remove it. Cheers. -- Robert Robert Jarzmik (12): ALSA: ac97: split out the generic ac97 registers ALSA: ac97: add an ac97 bus ASoC: add new ac97 bus support ASoC: arm: make pxa2xx-ac97-lib ac97 codec agnostic Input: wm

[PATCH v6 01/12] ALSA: ac97: split out the generic ac97 registers

2017-09-02 Thread Robert Jarzmik
efinition which would come with ac97_codec.h by "chance". - don't have to have snd_a97_*() functions, as they rely on struct snd_ac97. - don't want the struct snd_ac97_bus_ops, there is a new one Signed-off-by: Robert Jarzmik --- Since v1: improve commit message to ex

[PATCH v6 05/12] Input: wm97xx: split out touchscreen registering

2017-09-02 Thread Robert Jarzmik
specific from the remaining part. This is only code shuffling, there is no functional change. Signed-off-by: Robert Jarzmik Acked-by: Dmitry Torokhov Acked-by: Charles Keepax --- Since v1: - took into account Charles's comment --- drivers/input/touchscreen/wm97xx-core.c

[PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support

2017-09-02 Thread Robert Jarzmik
Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik --- Since v4: - added #ifdef spotted by Charles --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9712.c | 39 ++- 2 files

[PATCH v6 07/12] Input: wm97xx: add new AC97 bus support

2017-09-02 Thread Robert Jarzmik
l" as the touchscreen driver. This was tested on the pxa architecture with a pxa270 + wm9713 + the mioa701 touchscreen. Signed-off-by: Robert Jarzmik Acked-by: Charles Keepax Acked-by: Dmitry Torokhov --- drivers/input/touchscreen/Kconfig | 2 +- drivers/input/touchscreen/wm97xx-c

[PATCH v6 08/12] ASoC: wm9713: add ac97 new bus support

2017-09-02 Thread Robert Jarzmik
Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik Acked-by: Charles Keepax --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/codecs/wm9713.c | 39 +++ 2 files changed, 29 insertions

[PATCH v6 12/12] ASoC: pxa: switch to new ac97 bus support

2017-09-02 Thread Robert Jarzmik
Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik --- Since v1: split into 2 patches, the former being XXX ac97 codec agnostic Since v2: fix driver unregistration Since v3: added platform driver data for controller removal

[PATCH v6 10/12] ASoC: wm9705: add private structure

2017-09-02 Thread Robert Jarzmik
Add a private data structure. This is a preparation for a codec which would need an another data on top of snd_ac97, which will be the case when an MFD wm97xx device will probe wm9705. Signed-off-by: Robert Jarzmik Acked-by: Charles Keepax --- sound/soc/codecs/wm9705.c | 36

[PATCH v6 11/12] ASoC: wm9705: add ac97 new bus support

2017-09-02 Thread Robert Jarzmik
Add support for the new ac97 bus model, where devices are automatically discovered on AC-Links. Signed-off-by: Robert Jarzmik Acked-by: Charles Keepax --- Since v4: - added #ifdef spotted by Charles - tentatively kept Charles's ack --- sound/soc/codecs/Kconfig | 3 ++- sound/soc/c

<    1   2   3   4   5   6   7   8   9   10   >