Re: [PATCH v5 01/13] media: mt9m111: make a standalone v4l2 subdevice

2016-08-30 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Hi Robert, > > On Mon, 29 Aug 2016, Robert Jarzmik wrote: > >> Remove the soc_camera adherence. Mostly the change removes the power >> manipulation provided by soc_camera, and instead : >> - powers on the sensor when the s_power con

Re: [PATCH] ARM: pxa: remove irq init from dt machines

2016-08-29 Thread Robert Jarzmik
Arnd Bergmann <a...@arndb.de> writes: > On Monday, August 15, 2016 12:24:55 AM CEST Robert Jarzmik wrote: >> The init_irq and handle_irq can be declared through standard irqchip >> declaration and are not necessary in machine descriptions. >> >> This is anothe

Re: [PATCH] ARM: pxa: remove irq init from dt machines

2016-08-29 Thread Robert Jarzmik
Arnd Bergmann writes: > On Monday, August 15, 2016 12:24:55 AM CEST Robert Jarzmik wrote: >> The init_irq and handle_irq can be declared through standard irqchip >> declaration and are not necessary in machine descriptions. >> >> This is another step towards the

Re: [PATCH] ARM: pxa: Use kmalloc_array() in pxa_pm_init()

2016-08-29 Thread Robert Jarzmik
SF Markus Elfring writes: > From: Markus Elfring > Date: Thu, 25 Aug 2016 18:01:37 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. >

Re: [PATCH] ARM: pxa: Use kmalloc_array() in pxa_pm_init()

2016-08-29 Thread Robert Jarzmik
SF Markus Elfring writes: > From: Markus Elfring > Date: Thu, 25 Aug 2016 18:01:37 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This

[PATCH v5 12/13] media: platform: pxa_camera: change stop_streaming semantics

2016-08-29 Thread Robert Jarzmik
a "cancel capture" than a "wait for end of capture" semantic. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/platform/soc_camera/pxa_camera.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v5 12/13] media: platform: pxa_camera: change stop_streaming semantics

2016-08-29 Thread Robert Jarzmik
a "cancel capture" than a "wait for end of capture" semantic. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/soc_camera/pxa_camer

[PATCH v5 06/13] media: platform: pxa_camera: introduce sensor_call

2016-08-29 Thread Robert Jarzmik
Introduce sensor_call(), which will be used for all sensor invocations. This is a preparation move to v4l2 device conversion, ie. soc_camera adherence removal. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/platform/soc_camera/pxa_camera.

[PATCH v5 11/13] media: platform: pxa_camera: add debug register access

2016-08-29 Thread Robert Jarzmik
Add pxa_camera registers access through advanced video debugging. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/platform/soc_camera/pxa_camera.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/drivers/media/platform/soc_

[PATCH v5 11/13] media: platform: pxa_camera: add debug register access

2016-08-29 Thread Robert Jarzmik
Add pxa_camera registers access through advanced video debugging. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media

[PATCH v5 06/13] media: platform: pxa_camera: introduce sensor_call

2016-08-29 Thread Robert Jarzmik
Introduce sensor_call(), which will be used for all sensor invocations. This is a preparation move to v4l2 device conversion, ie. soc_camera adherence removal. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 27 ++ 1 file changed, 15

[PATCH v5 05/13] media: platform: pxa_camera: trivial move of functions

2016-08-29 Thread Robert Jarzmik
doesn't modify a single line of code. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v3: replace void *alloc_ctxt by struct device *alloc_devs impact Since v4: videobuf2 device init change impact --- drivers/media/platform/soc_camera/pxa_camera.c | 473 +-

[PATCH v5 05/13] media: platform: pxa_camera: trivial move of functions

2016-08-29 Thread Robert Jarzmik
doesn't modify a single line of code. Signed-off-by: Robert Jarzmik --- Since v3: replace void *alloc_ctxt by struct device *alloc_devs impact Since v4: videobuf2 device init change impact --- drivers/media/platform/soc_camera/pxa_camera.c | 473 + 1 file changed, 241

[PATCH v5 09/13] media: platform: pxa_camera: remove set_crop

2016-08-29 Thread Robert Jarzmik
This is to be seen as a regression as the set_crop function is removed. This is a temporary situation in the v4l2 porting, and will have to be added later. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/platform/soc_camera/pxa_camera.c | 76 ---

[PATCH v5 09/13] media: platform: pxa_camera: remove set_crop

2016-08-29 Thread Robert Jarzmik
This is to be seen as a regression as the set_crop function is removed. This is a temporary situation in the v4l2 porting, and will have to be added later. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 76 -- 1 file changed, 76

[PATCH v5 10/13] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-29 Thread Robert Jarzmik
ing. In a subsequence patch pxa_camera_mclk_ops should be used, and platform data MCLK ignored. It will be the sensor's duty to request the clock and enable it, which will end in pxa_camera_mclk_ops. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: - function namings wer

[PATCH v5 10/13] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-29 Thread Robert Jarzmik
ing. In a subsequence patch pxa_camera_mclk_ops should be used, and platform data MCLK ignored. It will be the sensor's duty to request the clock and enable it, which will end in pxa_camera_mclk_ops. Signed-off-by: Robert Jarzmik --- Since v1: - function namings were cleaned into pxac_XXX_() - funct

[PATCH v5 03/13] media: mt9m111: move mt9m111 out of soc_camera

2016-08-29 Thread Robert Jarzmik
As the mt9m111 is now working as a standalone v4l2 subdevice sensor, move it out of soc_camera directory and severe its dependency on soc_camera. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Ma

[PATCH v5 03/13] media: mt9m111: move mt9m111 out of soc_camera

2016-08-29 Thread Robert Jarzmik
As the mt9m111 is now working as a standalone v4l2 subdevice sensor, move it out of soc_camera directory and severe its dependency on soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile |1 + drivers/media/i2c

[PATCH v5 13/13] media: platform: pxa_camera: move pxa_camera out of soc_camera

2016-08-29 Thread Robert Jarzmik
As the conversion to a v4l2 standalone device is finished, move pxa_camera one directory up and finish severing any dependency to soc_camera. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/platform/Kconfig |8 + drivers/media/platform/Ma

[PATCH v5 00/13] pxa_camera transition to v4l2 standalone device

2016-08-29 Thread Robert Jarzmik
There is no change between v4 and v5, ie. the global diff is empty, only one line was shifted to prevent breaking bisectablility. All the text in https://lkml.org/lkml/2016/8/15/609 is still applicable. Cheers. -- Robert Robert Jarzmik (13): media: mt9m111: make a standalone v4l2 subdevice

[PATCH v5 08/13] media: platform: pxa_camera: add buffer sequencing

2016-08-29 Thread Robert Jarzmik
Add sequence numbers to completed buffers. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v3: reset buffer sequence number in start_streaming() --- drivers/media/platform/soc_camera/pxa_camera.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/pl

[PATCH v5 13/13] media: platform: pxa_camera: move pxa_camera out of soc_camera

2016-08-29 Thread Robert Jarzmik
As the conversion to a v4l2 standalone device is finished, move pxa_camera one directory up and finish severing any dependency to soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/platform/Kconfig |8 + drivers/media/platform/Makefile|1

[PATCH v5 00/13] pxa_camera transition to v4l2 standalone device

2016-08-29 Thread Robert Jarzmik
There is no change between v4 and v5, ie. the global diff is empty, only one line was shifted to prevent breaking bisectablility. All the text in https://lkml.org/lkml/2016/8/15/609 is still applicable. Cheers. -- Robert Robert Jarzmik (13): media: mt9m111: make a standalone v4l2 subdevice

[PATCH v5 08/13] media: platform: pxa_camera: add buffer sequencing

2016-08-29 Thread Robert Jarzmik
Add sequence numbers to completed buffers. Signed-off-by: Robert Jarzmik --- Since v3: reset buffer sequence number in start_streaming() --- drivers/media/platform/soc_camera/pxa_camera.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b

[PATCH v5 04/13] media: platform: pxa_camera: convert to vb2

2016-08-29 Thread Robert Jarzmik
Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: took into account Hans's comments renamed all vb2 functions to pxac_vb2_*() Since v2: spit queue_buffer() and start_streaming() Since v3: replace void *alloc_ctxs by struct device *alloc_devs Since v4: move

[PATCH v5 07/13] media: platform: pxa_camera: make printk consistent

2016-08-29 Thread Robert Jarzmik
Make all print consistent by always using : - dev_xxx(pcdev_to_dev(pcdev), ) This prepares the soc_camera adherence removal by making these call rely on only pcdev, and not the soc_camera icd structure. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/pl

[PATCH v5 04/13] media: platform: pxa_camera: convert to vb2

2016-08-29 Thread Robert Jarzmik
Signed-off-by: Robert Jarzmik --- Since v1: took into account Hans's comments renamed all vb2 functions to pxac_vb2_*() Since v2: spit queue_buffer() and start_streaming() Since v3: replace void *alloc_ctxs by struct device *alloc_devs Since v4: move the queue device initialization to v4l2

[PATCH v5 07/13] media: platform: pxa_camera: make printk consistent

2016-08-29 Thread Robert Jarzmik
Make all print consistent by always using : - dev_xxx(pcdev_to_dev(pcdev), ) This prepares the soc_camera adherence removal by making these call rely on only pcdev, and not the soc_camera icd structure. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 70

[PATCH v5 01/13] media: mt9m111: make a standalone v4l2 subdevice

2016-08-29 Thread Robert Jarzmik
-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/i2c/soc_camera/mt9m111.c | 51 ++ 1 file changed, 15 insertions(+), 36 deletions(-) diff --git a/drivers/media/i2c/soc_camera/mt9m111.c b/drivers/media/i2c/soc_camera/mt9m111.c index 6dfaea

[PATCH v5 01/13] media: mt9m111: make a standalone v4l2 subdevice

2016-08-29 Thread Robert Jarzmik
-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 51 ++ 1 file changed, 15 insertions(+), 36 deletions(-) diff --git a/drivers/media/i2c/soc_camera/mt9m111.c b/drivers/media/i2c/soc_camera/mt9m111.c index 6dfaead6aaa8..a7efaa5964d1 100644

[PATCH v5 02/13] media: mt9m111: use only the SRGB colorspace

2016-08-29 Thread Robert Jarzmik
mt9m111 being a camera sensor, its colorspace should always be SRGB, for both RGB based formats or YCbCr based ones. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/i2c/soc_camera/mt9m111.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v5 02/13] media: mt9m111: use only the SRGB colorspace

2016-08-29 Thread Robert Jarzmik
mt9m111 being a camera sensor, its colorspace should always be SRGB, for both RGB based formats or YCbCr based ones. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/soc_camera

Re: [RFC PATCH v2 0/7] AC97 device/driver model revamp

2016-08-29 Thread Robert Jarzmik
Mark Brown <broo...@kernel.org> writes: > On Tue, Aug 23, 2016 at 06:39:35PM +0200, Robert Jarzmik wrote: > >> In the old ac97 bus, the match function was always returning "true", and the >> driver did probe. With this new implementation, the ac97 is discovere

Re: [RFC PATCH v2 0/7] AC97 device/driver model revamp

2016-08-29 Thread Robert Jarzmik
Mark Brown writes: > On Tue, Aug 23, 2016 at 06:39:35PM +0200, Robert Jarzmik wrote: > >> In the old ac97 bus, the match function was always returning "true", and the >> driver did probe. With this new implementation, the ac97 is discovered and >> sound/soc

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-27 Thread Robert Jarzmik
Russell King - ARM Linux <li...@armlinux.org.uk> writes: > On Thu, Aug 25, 2016 at 08:02:35PM +0200, Robert Jarzmik wrote: >> Arnd Bergmann <a...@arndb.de> writes: >> >> > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: >> &

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-27 Thread Robert Jarzmik
Russell King - ARM Linux writes: > On Thu, Aug 25, 2016 at 08:02:35PM +0200, Robert Jarzmik wrote: >> Arnd Bergmann writes: >> >> > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: >> >> dri

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-25 Thread Robert Jarzmik
Arnd Bergmann writes: > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: >> drivers/net/ethernet/smsc/smc91x.h | 50 >> +++--- >> 1 file changed, 30 insertions(+), 20 deletions(-) >> >> While this patch fixes one bug on Neponset,

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-25 Thread Robert Jarzmik
Arnd Bergmann writes: > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: >> drivers/net/ethernet/smsc/smc91x.h | 50 >> +++--- >> 1 file changed, 30 insertions(+), 20 deletions(-) >> >> While this patch fixes one bug on Neponset, it probably

Re: [PATCH -next] ARM: pxa: remove duplicated include from spitz.c

2016-08-23 Thread Robert Jarzmik
Wei Yongjun <weiyj...@gmail.com> writes: > Hi Robert, > On 08/24/2016 12:24 AM, Robert Jarzmik wrote: >> Wei Yongjun <weiyj...@gmail.com> writes: >> >>> Remove duplicated include. >> How so duplicated ? Can you elaborate please ? >> >

Re: [PATCH -next] ARM: pxa: remove duplicated include from spitz.c

2016-08-23 Thread Robert Jarzmik
Wei Yongjun writes: > Hi Robert, > On 08/24/2016 12:24 AM, Robert Jarzmik wrote: >> Wei Yongjun writes: >> >>> Remove duplicated include. >> How so duplicated ? Can you elaborate please ? >> >> Moreover, how do you do think symbol_get() can s

Re: [RFC PATCH v2 0/7] AC97 device/driver model revamp

2016-08-23 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > It all started in the pxa device-tree submission here : >https://lkml.org/lkml/2016/2/25/965 > > It will be maintained in : >git fetch https://github.com/rjarzmik/linux.git work/ac97 > > And now it trans

Re: [RFC PATCH v2 0/7] AC97 device/driver model revamp

2016-08-23 Thread Robert Jarzmik
Robert Jarzmik writes: > It all started in the pxa device-tree submission here : >https://lkml.org/lkml/2016/2/25/965 > > It will be maintained in : >git fetch https://github.com/rjarzmik/linux.git work/ac97 > > And now it transformed into this RFC, which would

Re: [PATCH -next] ARM: pxa: remove duplicated include from spitz.c

2016-08-23 Thread Robert Jarzmik
Wei Yongjun writes: > Remove duplicated include. How so duplicated ? Can you elaborate please ? Moreover, how do you do think symbol_get() can stay in spitz.c without having this include ? Cheers. -- Robert

Re: [PATCH -next] ARM: pxa: remove duplicated include from spitz.c

2016-08-23 Thread Robert Jarzmik
Wei Yongjun writes: > Remove duplicated include. How so duplicated ? Can you elaborate please ? Moreover, how do you do think symbol_get() can stay in spitz.c without having this include ? Cheers. -- Robert

Re: [PATCH v4 04/13] media: platform: pxa_camera: convert to vb2

2016-08-16 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > Convert pxa_camera from videobuf to videobuf2. > > As the soc_camera was already compatible with videobuf2, the port is > quite straightforward. > > The special case of this code in which the vb2 to prepare is &quo

Re: [PATCH v4 04/13] media: platform: pxa_camera: convert to vb2

2016-08-16 Thread Robert Jarzmik
Robert Jarzmik writes: > Convert pxa_camera from videobuf to videobuf2. > > As the soc_camera was already compatible with videobuf2, the port is > quite straightforward. > > The special case of this code in which the vb2 to prepare is "too > big" in terms of

[PATCH v4 08/13] media: platform: pxa_camera: add buffer sequencing

2016-08-15 Thread Robert Jarzmik
Add sequence numbers to completed buffers. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v3: reset buffer sequence number in start_streaming() --- drivers/media/platform/soc_camera/pxa_camera.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/pl

[PATCH v4 09/13] media: platform: pxa_camera: remove set_crop

2016-08-15 Thread Robert Jarzmik
This is to be seen as a regression as the set_crop function is removed. This is a temporary situation in the v4l2 porting, and will have to be added later. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/platform/soc_camera/pxa_camera.c | 76 ---

[PATCH v4 08/13] media: platform: pxa_camera: add buffer sequencing

2016-08-15 Thread Robert Jarzmik
Add sequence numbers to completed buffers. Signed-off-by: Robert Jarzmik --- Since v3: reset buffer sequence number in start_streaming() --- drivers/media/platform/soc_camera/pxa_camera.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b

[PATCH v4 09/13] media: platform: pxa_camera: remove set_crop

2016-08-15 Thread Robert Jarzmik
This is to be seen as a regression as the set_crop function is removed. This is a temporary situation in the v4l2 porting, and will have to be added later. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 76 -- 1 file changed, 76

[PATCH v4 06/13] media: platform: pxa_camera: introduce sensor_call

2016-08-15 Thread Robert Jarzmik
Introduce sensor_call(), which will be used for all sensor invocations. This is a preparation move to v4l2 device conversion, ie. soc_camera adherence removal. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/platform/soc_camera/pxa_camera.

[PATCH v4 06/13] media: platform: pxa_camera: introduce sensor_call

2016-08-15 Thread Robert Jarzmik
Introduce sensor_call(), which will be used for all sensor invocations. This is a preparation move to v4l2 device conversion, ie. soc_camera adherence removal. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 27 ++ 1 file changed, 15

[PATCH v4 01/13] media: mt9m111: make a standalone v4l2 subdevice

2016-08-15 Thread Robert Jarzmik
-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/i2c/soc_camera/mt9m111.c | 51 ++ 1 file changed, 15 insertions(+), 36 deletions(-) diff --git a/drivers/media/i2c/soc_camera/mt9m111.c b/drivers/media/i2c/soc_camera/mt9m111.c index 6dfaea

[PATCH v4 04/13] media: platform: pxa_camera: convert to vb2

2016-08-15 Thread Robert Jarzmik
Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: took into account Hans's comments renamed all vb2 functions to pxac_vb2_*() Since v2: spit queue_buffer() and start_streaming() Since v3: replace void *alloc_ctxs by struct device *alloc_devs --- drivers/media/pla

[PATCH v4 01/13] media: mt9m111: make a standalone v4l2 subdevice

2016-08-15 Thread Robert Jarzmik
-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 51 ++ 1 file changed, 15 insertions(+), 36 deletions(-) diff --git a/drivers/media/i2c/soc_camera/mt9m111.c b/drivers/media/i2c/soc_camera/mt9m111.c index 6dfaead6aaa8..a7efaa5964d1 100644

[PATCH v4 04/13] media: platform: pxa_camera: convert to vb2

2016-08-15 Thread Robert Jarzmik
Signed-off-by: Robert Jarzmik --- Since v1: took into account Hans's comments renamed all vb2 functions to pxac_vb2_*() Since v2: spit queue_buffer() and start_streaming() Since v3: replace void *alloc_ctxs by struct device *alloc_devs --- drivers/media/platform/soc_camera/Kconfig

[PATCH v4 00/13] pxa_camera transition to v4l2 standalone device

2016-08-15 Thread Robert Jarzmik
/linux.git work/v4l2 The result of v4l-compliance -s is in [1]. The result of v4l-compliance -f is in [2]. Happy review. -- Robert Robert Jarzmik (13): media: mt9m111: make a standalone v4l2 subdevice media: mt9m111: use only the SRGB colorspace media: mt9m111: move mt9m111 out of soc_camera

[PATCH v4 03/13] media: mt9m111: move mt9m111 out of soc_camera

2016-08-15 Thread Robert Jarzmik
As the mt9m111 is now working as a standalone v4l2 subdevice sensor, move it out of soc_camera directory and severe its dependency on soc_camera. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Ma

[PATCH v4 00/13] pxa_camera transition to v4l2 standalone device

2016-08-15 Thread Robert Jarzmik
/linux.git work/v4l2 The result of v4l-compliance -s is in [1]. The result of v4l-compliance -f is in [2]. Happy review. -- Robert Robert Jarzmik (13): media: mt9m111: make a standalone v4l2 subdevice media: mt9m111: use only the SRGB colorspace media: mt9m111: move mt9m111 out of soc_camera

[PATCH v4 03/13] media: mt9m111: move mt9m111 out of soc_camera

2016-08-15 Thread Robert Jarzmik
As the mt9m111 is now working as a standalone v4l2 subdevice sensor, move it out of soc_camera directory and severe its dependency on soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile |1 + drivers/media/i2c

[PATCH v4 05/13] media: platform: pxa_camera: trivial move of functions

2016-08-15 Thread Robert Jarzmik
doesn't modify a single line of code. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v3: replace void *alloc_ctxt by struct device *alloc_devs impact --- drivers/media/platform/soc_camera/pxa_camera.c | 475 + 1 file changed, 242 insertions(+), 233 del

[PATCH v4 05/13] media: platform: pxa_camera: trivial move of functions

2016-08-15 Thread Robert Jarzmik
doesn't modify a single line of code. Signed-off-by: Robert Jarzmik --- Since v3: replace void *alloc_ctxt by struct device *alloc_devs impact --- drivers/media/platform/soc_camera/pxa_camera.c | 475 + 1 file changed, 242 insertions(+), 233 deletions(-) diff --git a/drivers

[PATCH v4 10/13] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-15 Thread Robert Jarzmik
ing. In a subsequence patch pxa_camera_mclk_ops should be used, and platform data MCLK ignored. It will be the sensor's duty to request the clock and enable it, which will end in pxa_camera_mclk_ops. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: - function namings wer

[PATCH v4 10/13] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-15 Thread Robert Jarzmik
ing. In a subsequence patch pxa_camera_mclk_ops should be used, and platform data MCLK ignored. It will be the sensor's duty to request the clock and enable it, which will end in pxa_camera_mclk_ops. Signed-off-by: Robert Jarzmik --- Since v1: - function namings were cleaned into pxac_XXX_() - funct

[PATCH v4 07/13] media: platform: pxa_camera: make printk consistent

2016-08-15 Thread Robert Jarzmik
Make all print consistent by always using : - dev_xxx(pcdev_to_dev(pcdev), ) This prepares the soc_camera adherence removal by making these call rely on only pcdev, and not the soc_camera icd structure. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/pl

[PATCH v4 07/13] media: platform: pxa_camera: make printk consistent

2016-08-15 Thread Robert Jarzmik
Make all print consistent by always using : - dev_xxx(pcdev_to_dev(pcdev), ) This prepares the soc_camera adherence removal by making these call rely on only pcdev, and not the soc_camera icd structure. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 70

[PATCH v4 11/13] media: platform: pxa_camera: add debug register access

2016-08-15 Thread Robert Jarzmik
Add pxa_camera registers access through advanced video debugging. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/platform/soc_camera/pxa_camera.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/drivers/media/platform/soc_

[PATCH v4 13/13] media: platform: pxa_camera: move pxa_camera out of soc_camera

2016-08-15 Thread Robert Jarzmik
As the conversion to a v4l2 standalone device is finished, move pxa_camera one directory up and finish severing any dependency to soc_camera. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/platform/Kconfig |8 + drivers/media/platform/Ma

[PATCH v4 11/13] media: platform: pxa_camera: add debug register access

2016-08-15 Thread Robert Jarzmik
Add pxa_camera registers access through advanced video debugging. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media

[PATCH v4 13/13] media: platform: pxa_camera: move pxa_camera out of soc_camera

2016-08-15 Thread Robert Jarzmik
As the conversion to a v4l2 standalone device is finished, move pxa_camera one directory up and finish severing any dependency to soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/platform/Kconfig |8 + drivers/media/platform/Makefile|1

[PATCH v4 02/13] media: mt9m111: use only the SRGB colorspace

2016-08-15 Thread Robert Jarzmik
mt9m111 being a camera sensor, its colorspace should always be SRGB, for both RGB based formats or YCbCr based ones. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/i2c/soc_camera/mt9m111.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v4 12/13] media: platform: pxa_camera: change stop_streaming semantics

2016-08-15 Thread Robert Jarzmik
a "cancel capture" than a "wait for end of capture" semantic. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/media/platform/soc_camera/pxa_camera.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v4 02/13] media: mt9m111: use only the SRGB colorspace

2016-08-15 Thread Robert Jarzmik
mt9m111 being a camera sensor, its colorspace should always be SRGB, for both RGB based formats or YCbCr based ones. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/soc_camera

[PATCH v4 12/13] media: platform: pxa_camera: change stop_streaming semantics

2016-08-15 Thread Robert Jarzmik
a "cancel capture" than a "wait for end of capture" semantic. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/soc_camera/pxa_camer

Re: [PATCH v3 09/14] media: platform: pxa_camera: add buffer sequencing

2016-08-15 Thread Robert Jarzmik
Hans Verkuil <hverk...@xs4all.nl> writes: > On 08/15/2016 03:26 PM, Robert Jarzmik wrote: >> Robert Jarzmik <robert.jarz...@free.fr> writes: >> I've seen no documentation on the rules applicable to this sequence number: >> - should it be reset if a &

Re: [PATCH v3 09/14] media: platform: pxa_camera: add buffer sequencing

2016-08-15 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/15/2016 03:26 PM, Robert Jarzmik wrote: >> Robert Jarzmik writes: >> I've seen no documentation on the rules applicable to this sequence number: >> - should it be reset if a "start streaming" operation occurs ? > > sta

Re: [PATCH v3 09/14] media: platform: pxa_camera: add buffer sequencing

2016-08-15 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > Add sequence numbers to completed buffers. > > Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> > --- > drivers/media/platform/soc_camera/pxa_camera.c | 5 + > 1 file changed, 5 insertions(+) > >

Re: [PATCH v3 09/14] media: platform: pxa_camera: add buffer sequencing

2016-08-15 Thread Robert Jarzmik
Robert Jarzmik writes: > Add sequence numbers to completed buffers. > > Signed-off-by: Robert Jarzmik > --- > drivers/media/platform/soc_camera/pxa_camera.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/platform/soc_camera/pxa_camera.c &g

Re: [PATCH v3 14/14] media: platform: pxa_camera: move pxa_camera out of soc_camera

2016-08-15 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > As the conversion to a v4l2 standalone device is finished, move > pxa_camera one directory up and finish severing any dependency to > soc_camera. > diff --git a/drivers/media/platform/soc_camera/Kconfig > b/drivers/medi

Re: [PATCH v3 14/14] media: platform: pxa_camera: move pxa_camera out of soc_camera

2016-08-15 Thread Robert Jarzmik
Robert Jarzmik writes: > As the conversion to a v4l2 standalone device is finished, move > pxa_camera one directory up and finish severing any dependency to > soc_camera. > diff --git a/drivers/media/platform/soc_camera/Kconfig > b/drivers/media/platform/soc_camera/Kconfig >

[PATCH] ARM: pxa: remove irq init from dt machines

2016-08-14 Thread Robert Jarzmik
The init_irq and handle_irq can be declared through standard irqchip declaration and are not necessary in machine descriptions. This is another step towards the generic kernel for the pxa architecture. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Cc: Arnd Bergmann <a...

[PATCH] ARM: pxa: remove irq init from dt machines

2016-08-14 Thread Robert Jarzmik
The init_irq and handle_irq can be declared through standard irqchip declaration and are not necessary in machine descriptions. This is another step towards the generic kernel for the pxa architecture. Signed-off-by: Robert Jarzmik Cc: Arnd Bergmann --- arch/arm/mach-pxa/generic.h | 3

Re: [PATCH v3 02/14] media: mt9m111: prevent module removal while in use

2016-08-14 Thread Robert Jarzmik
Hans Verkuil <hverk...@xs4all.nl> writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> The mt9m111 can be a removable module : the only case where the module >> should be kept loaded is while it is used, ie. while an active >> transation is ongoing on it.

Re: [PATCH v3 02/14] media: mt9m111: prevent module removal while in use

2016-08-14 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> The mt9m111 can be a removable module : the only case where the module >> should be kept loaded is while it is used, ie. while an active >> transation is ongoing on it. >> >> The notio

Re: [PATCH v3 12/14] media: platform: pxa_camera: add debug register access

2016-08-14 Thread Robert Jarzmik
Hans Verkuil <hverk...@xs4all.nl> writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> Add pxa_camera registers access through advanced video debugging. >> +static int pxac_vidioc_g_chip_info(struct file *file, void *fh, >> + stru

Re: [PATCH v3 12/14] media: platform: pxa_camera: add debug register access

2016-08-14 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> Add pxa_camera registers access through advanced video debugging. >> +static int pxac_vidioc_g_chip_info(struct file *file, void *fh, >> + struct v4l2_dbg_chip_info *chip) &

Re: [PATCH v3 10/14] media: platform: pxa_camera: remove set_crop

2016-08-14 Thread Robert Jarzmik
Hans Verkuil <hverk...@xs4all.nl> writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> This is to be seen as a regression as the set_crop function is >> removed. This is a temporary situation in the v4l2 porting, and will >> have to be added later. > &g

Re: [PATCH v3 11/14] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-14 Thread Robert Jarzmik
Hans Verkuil <hverk...@xs4all.nl> writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > >> +pcdev->sensor = subdev; >> +pcdev->vdev.queue = >vb2_vq; >> +pcdev->vdev.v4l2_dev = >v4l2_dev; > > You're missing this line here: > &

Re: [PATCH v3 10/14] media: platform: pxa_camera: remove set_crop

2016-08-14 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> This is to be seen as a regression as the set_crop function is >> removed. This is a temporary situation in the v4l2 porting, and will >> have to be added later. > > This is a bit confusing, sinc

Re: [PATCH v3 11/14] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-14 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > >> +pcdev->sensor = subdev; >> +pcdev->vdev.queue = >vb2_vq; >> +pcdev->vdev.v4l2_dev = >v4l2_dev; > > You're missing this line here: > > pcdev->vdev

Re: [PATCH v3 05/14] media: platform: pxa_camera: convert to vb2

2016-08-13 Thread Robert Jarzmik
Hans Verkuil <hverk...@xs4all.nl> writes: > On 08/13/2016 11:25 AM, Robert Jarzmik wrote: >> Hi Hans, >> >> Robert Jarzmik <robert.jarz...@free.fr> writes: >>> Convert pxa_camera from videobuf to videobuf2. >> ...zip... >> >

Re: [PATCH v3 05/14] media: platform: pxa_camera: convert to vb2

2016-08-13 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/13/2016 11:25 AM, Robert Jarzmik wrote: >> Hi Hans, >> >> Robert Jarzmik writes: >>> Convert pxa_camera from videobuf to videobuf2. >> ...zip... >> >>> +static int pxac_vb2_queue_setup(struct vb2_queue *vq,

Re: [PATCH v3 05/14] media: platform: pxa_camera: convert to vb2

2016-08-13 Thread Robert Jarzmik
Hi Hans, Robert Jarzmik <robert.jarz...@free.fr> writes: > Convert pxa_camera from videobuf to videobuf2. ...zip... > +static int pxac_vb2_queue_setup(struct vb2_queue *vq, > + unsigned int *nbufs, > + unsigned int *num_pl

Re: [PATCH v3 05/14] media: platform: pxa_camera: convert to vb2

2016-08-13 Thread Robert Jarzmik
Hi Hans, Robert Jarzmik writes: > Convert pxa_camera from videobuf to videobuf2. ...zip... > +static int pxac_vb2_queue_setup(struct vb2_queue *vq, > + unsigned int *nbufs, > + unsigned int *num_planes, unsign

[PATCH] ARM: dts: add pxa25x .dtsi file

2016-08-10 Thread Robert Jarzmik
This file describes pxa25x SoCs. Not all devices are listed yet, only the subset which was already tested with a lubbock board. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- arch/arm/boot/dts/pxa25x.dtsi | 92 +++ 1 file changed, 92 inse

[PATCH] ARM: dts: add pxa25x .dtsi file

2016-08-10 Thread Robert Jarzmik
This file describes pxa25x SoCs. Not all devices are listed yet, only the subset which was already tested with a lubbock board. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa25x.dtsi | 92 +++ 1 file changed, 92 insertions(+) create mode 100644

Re: [PATCH v4] ARM: pxa: fix GPIO double shifts

2016-08-09 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of > gpio register") from Oct 17, 2011, leads to the following static checker > warning: > arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup()

Re: [PATCH v4] ARM: pxa: fix GPIO double shifts

2016-08-09 Thread Robert Jarzmik
Robert Jarzmik writes: > The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of > gpio register") from Oct 17, 2011, leads to the following static checker > warning: > arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup() > warn: double le

Re: [PATCH] dm9000: Fix irq trigger type setup on non-dt platforms

2016-08-09 Thread Robert Jarzmik
ctually send the mail. Your analysis of the core in non-OF/ACPI case is the reason I didn't post a patch for dm9000 ... I was overconfident in finding a reason in irq core code within a couple of days. Therefore: Acked-by: Robert Jarzmik <robert.jarz...@free.fr> And I can make a test for you

<    5   6   7   8   9   10   11   12   13   14   >