Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-11-19 Thread Robert Jarzmik
Lee Jones writes: > On Wed, 26 Oct 2016, Robert Jarzmik wrote: >> +config MFD_WM97xx >> +tristate "Wolfson Microelectronics WM97xx" >> +select MFD_CORE >> +select REGMAP_AC97 >> +select AC97_BUS_COMPAT if AC97_BUS_NEW >> +

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-10 Thread Robert Jarzmik
Arvind Yadav writes: Hi Arvind, > In functions pxa2xx_build_functions, the memory allocated for > 'functions' is live within the function only. After the > allocation it is immediately freed with devm_kfree. There is > no need to allocate memory for 'functions' with devm function > so replace de

Re: [RFC PATCH 15/23] arm: use kconfig fragments for ARCH_PXA defconfigs (part 1)

2016-12-10 Thread Robert Jarzmik
ing defconfig files (before/after the patch). > > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Cc: Cyril Bur > Signed-off-by: Bartlomiej Zolnierkiewicz Hi Bartolomiej, It's a bit hard to judge without any context for me, especially I'm receiving patch

Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Robert Jarzmik
Philippe Reynes writes: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. I have the hardware. Do you want anything specific to be tested, like set

Re: [PATCH 07/12] gpio: pxa: use devm_irq_alloc_descs()

2017-03-04 Thread Robert Jarzmik
Bartosz Golaszewski writes: > This driver never frees the interrupt descriptors it allocates. Fix > it by using the resource managed version of irq_alloc_descs(). > > Signed-off-by: Bartosz Golaszewski Acked-by: Robert Jarzmik -- Robert

Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

2017-03-05 Thread Robert Jarzmik
t; see the changes ping -f x.x.x.x This both with your patch and without, it works in both cases, and the former as a smaller throughput, which makes me believe the patch is fine. Tested-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH 4/5] usb: pxa27x_udc: remove unused function argument

2016-06-16 Thread Robert Jarzmik
uot;Fixes" : Fixes: 70189a63d408 ("usb: gadget: pxa27x_udc: convert to udc_start/udc_stop") Apart form that: Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH v3 3/4] ARM: dts: pxa: add pxa27x cpu operating points

2016-11-02 Thread Robert Jarzmik
Robert Jarzmik writes: > Add the relevant data taken from the PXA27x Electrical, Mechanical, and > Thermal Specfication. This will be input data for cpufreq-dt driver. > > Signed-off-by: Robert Jarzmik > --- > Since v2: opp definition amended as per Viresh's comment Queued to pxa/dt. -- Robert

Re: [PATCH v3 2/4] ARM: dts: pxa: add pxa25x cpu operating points

2016-11-02 Thread Robert Jarzmik
Robert Jarzmik writes: > Add the relevant data taken from the PXA 25x Electrical, Mechanical, and > Thermal Specfication. This will be input data for cpufreq-dt driver. > > Signed-off-by: Robert Jarzmik > --- > Since v2: opp definition amended as per Viresh's c

Re: [PATCH 0/4] ARM64: Initial Marvell IAP140 enablement

2017-02-21 Thread Robert Jarzmik
Andreas Färber writes: > Hi Gregory, > > Am 20.02.2017 um 14:17 schrieb Gregory CLEMENT: >> On dim., févr. 19 2017, Andreas Färber wrote: >> >>> This mini-series adds initial support for the Marvell IAP140 SoC (aka >>> PXA1908) >>> and the Andromeda Box Edge development board. >> >> Given th

Re: [PATCH v2] tags: honor COMPILED_SOURCE with apart output directory

2017-02-13 Thread Robert Jarzmik
Robert Jarzmik writes: > Robert Jarzmik writes: >> Signed-off-by: Robert Jarzmik >> --- >> Since v1: amended k expression, Marek's comments > Hi Marek, > > Is this version good for you ? Marek, could you take a look please ? -- Robert >> --- >>

Re: [PATCH] ARM: defconfigs: make NF_CT_PROTO_SCTP and NF_CT_PROTO_UDPLITE built-in

2017-02-06 Thread Robert Jarzmik
Arnd Bergmann writes: > On Fri, Feb 3, 2017 at 5:46 PM, Arnd Bergmann wrote: >> The symbols can no longer be used as loadable modules, leading to a harmless >> Kconfig >> warning: >> >> arch/arm/configs/imote2_defconfig:60:warning: symbol value 'm' invalid for >> NF_CT_PROTO_UDPLITE >> arch/ar

Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2017-02-03 Thread Robert Jarzmik
Mark Brown writes: >> >> As for the "sound specific part", it's because AC97 bus is mainly used in >> >> sound >> >> oriented drivers, but still the codec IPs provide more than just sound, >> >> as the >> >> Wolfson codecs for instance. > >> > I'd like to get Mark Brown's opinion on this. > > I'

Re: [PATCH] dm9000: Fix irq trigger type setup on non-dt platforms

2016-08-09 Thread Robert Jarzmik
sis of the core in non-OF/ACPI case is the reason I didn't post a patch for dm9000 ... I was overconfident in finding a reason in irq core code within a couple of days. Therefore: Acked-by: Robert Jarzmik And I can make a test for you on my cm-x300 board, even if your patch is very alike the dr

Re: [PATCH v4] ARM: pxa: fix GPIO double shifts

2016-08-09 Thread Robert Jarzmik
Robert Jarzmik writes: > The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of > gpio register") from Oct 17, 2011, leads to the following static checker > warning: > arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup() > warn: double le

[PATCH] ARM: dts: add pxa25x .dtsi file

2016-08-10 Thread Robert Jarzmik
This file describes pxa25x SoCs. Not all devices are listed yet, only the subset which was already tested with a lubbock board. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa25x.dtsi | 92 +++ 1 file changed, 92 insertions(+) create mode 100644

[PATCH v4] ARM: pxa: fix GPIO double shifts

2016-08-01 Thread Robert Jarzmik
tion instead of gpio register") Reported-by: Dan Carpenter Cc: Joe Perches Signed-off-by: Robert Jarzmik --- Since v1: replaced binary ORs with logical ORs after assembly comparison Since v2: changed charger_wakeup prototype to bool foo() Since v3: direct return statements in xxx_charger_wa

Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly

2016-08-01 Thread Robert Jarzmik
Kishon Vijay Abraham I writes: > *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM. > Fix it from getting redundantly selected in all > ARCH_MULTIPLATFORM based machines. If that's the purpose, then CM-X255 and CM-X270 don't fall in that category, as they are not part of ARCH_MUL

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-08-02 Thread Robert Jarzmik
Hans Verkuil writes: Hi Hans, Working further on the pxa_camera conversion out of soc_camera, I hit a problem of dma being very long, in running v4l2-compliance -f. After digging a bit, I realized that the video buffer queued was a 640x480 format, while the s_fmt_vid_cap() lastly called was a 4

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-08-03 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/02/2016 08:03 PM, Robert Jarzmik wrote: >> Hans Verkuil writes: >> [ 1509.773051] pxa27x-camera pxa27x-camera.0: >> s_fmt_vid_cap(pix=48x32:56595559) >> [ 1509.777213] pxa27x-camera pxa27x-camera.0: current_fmt->fourcc: 0x56595559

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-27 Thread Robert Jarzmik
Russell King - ARM Linux writes: > On Thu, Aug 25, 2016 at 08:02:35PM +0200, Robert Jarzmik wrote: >> Arnd Bergmann writes: >> >> > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: >> >> dri

Re: [RFC PATCH v2 0/7] AC97 device/driver model revamp

2016-08-29 Thread Robert Jarzmik
Mark Brown writes: > On Tue, Aug 23, 2016 at 06:39:35PM +0200, Robert Jarzmik wrote: > >> In the old ac97 bus, the match function was always returning "true", and the >> driver did probe. With this new implementation, the ac97 is discovered and >> sound/soc/code

[PATCH v5 02/13] media: mt9m111: use only the SRGB colorspace

2016-08-29 Thread Robert Jarzmik
mt9m111 being a camera sensor, its colorspace should always be SRGB, for both RGB based formats or YCbCr based ones. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/soc_camera

[PATCH v5 01/13] media: mt9m111: make a standalone v4l2 subdevice

2016-08-29 Thread Robert Jarzmik
-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 51 ++ 1 file changed, 15 insertions(+), 36 deletions(-) diff --git a/drivers/media/i2c/soc_camera/mt9m111.c b/drivers/media/i2c/soc_camera/mt9m111.c index 6dfaead6aaa8..a7efaa5964d1 100644 --- a

[PATCH v5 04/13] media: platform: pxa_camera: convert to vb2

2016-08-29 Thread Robert Jarzmik
ned-off-by: Robert Jarzmik --- Since v1: took into account Hans's comments renamed all vb2 functions to pxac_vb2_*() Since v2: spit queue_buffer() and start_streaming() Since v3: replace void *alloc_ctxs by struct device *alloc_devs Since v4: move the queue device initialization to

[PATCH v5 07/13] media: platform: pxa_camera: make printk consistent

2016-08-29 Thread Robert Jarzmik
Make all print consistent by always using : - dev_xxx(pcdev_to_dev(pcdev), ) This prepares the soc_camera adherence removal by making these call rely on only pcdev, and not the soc_camera icd structure. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 70

[PATCH v5 13/13] media: platform: pxa_camera: move pxa_camera out of soc_camera

2016-08-29 Thread Robert Jarzmik
As the conversion to a v4l2 standalone device is finished, move pxa_camera one directory up and finish severing any dependency to soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/platform/Kconfig |8 + drivers/media/platform/Makefile|1

[PATCH v5 00/13] pxa_camera transition to v4l2 standalone device

2016-08-29 Thread Robert Jarzmik
There is no change between v4 and v5, ie. the global diff is empty, only one line was shifted to prevent breaking bisectablility. All the text in https://lkml.org/lkml/2016/8/15/609 is still applicable. Cheers. -- Robert Robert Jarzmik (13): media: mt9m111: make a standalone v4l2 subdevice

[PATCH v5 08/13] media: platform: pxa_camera: add buffer sequencing

2016-08-29 Thread Robert Jarzmik
Add sequence numbers to completed buffers. Signed-off-by: Robert Jarzmik --- Since v3: reset buffer sequence number in start_streaming() --- drivers/media/platform/soc_camera/pxa_camera.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b

[PATCH v5 03/13] media: mt9m111: move mt9m111 out of soc_camera

2016-08-29 Thread Robert Jarzmik
As the mt9m111 is now working as a standalone v4l2 subdevice sensor, move it out of soc_camera directory and severe its dependency on soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile |1 + drivers/media/i2c

[PATCH v5 10/13] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-29 Thread Robert Jarzmik
sing. In a subsequence patch pxa_camera_mclk_ops should be used, and platform data MCLK ignored. It will be the sensor's duty to request the clock and enable it, which will end in pxa_camera_mclk_ops. Signed-off-by: Robert Jarzmik --- Since v1: - function namings were cleaned into pxac_XXX_Y

[PATCH v5 09/13] media: platform: pxa_camera: remove set_crop

2016-08-29 Thread Robert Jarzmik
This is to be seen as a regression as the set_crop function is removed. This is a temporary situation in the v4l2 porting, and will have to be added later. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 76 -- 1 file changed, 76

[PATCH v5 05/13] media: platform: pxa_camera: trivial move of functions

2016-08-29 Thread Robert Jarzmik
doesn't modify a single line of code. Signed-off-by: Robert Jarzmik --- Since v3: replace void *alloc_ctxt by struct device *alloc_devs impact Since v4: videobuf2 device init change impact --- drivers/media/platform/soc_camera/pxa_camera.c | 473 + 1 file changed

[PATCH v5 11/13] media: platform: pxa_camera: add debug register access

2016-08-29 Thread Robert Jarzmik
Add pxa_camera registers access through advanced video debugging. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media

[PATCH v5 06/13] media: platform: pxa_camera: introduce sensor_call

2016-08-29 Thread Robert Jarzmik
Introduce sensor_call(), which will be used for all sensor invocations. This is a preparation move to v4l2 device conversion, ie. soc_camera adherence removal. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 27 ++ 1 file changed, 15

[PATCH v5 12/13] media: platform: pxa_camera: change stop_streaming semantics

2016-08-29 Thread Robert Jarzmik
a "cancel capture" than a "wait for end of capture" semantic. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/soc_camera/pxa_camer

Re: [PATCH] ARM: pxa: Use kmalloc_array() in pxa_pm_init()

2016-08-29 Thread Robert Jarzmik
SF Markus Elfring writes: > From: Markus Elfring > Date: Thu, 25 Aug 2016 18:01:37 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This is

Re: [PATCH] ARM: pxa: remove irq init from dt machines

2016-08-29 Thread Robert Jarzmik
Arnd Bergmann writes: > On Monday, August 15, 2016 12:24:55 AM CEST Robert Jarzmik wrote: >> The init_irq and handle_irq can be declared through standard irqchip >> declaration and are not necessary in machine descriptions. >> >> This is another step towards the

Re: [PATCH v5 01/13] media: mt9m111: make a standalone v4l2 subdevice

2016-08-30 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Hi Robert, > > On Mon, 29 Aug 2016, Robert Jarzmik wrote: > >> Remove the soc_camera adherence. Mostly the change removes the power >> manipulation provided by soc_camera, and instead : >> - powers on the sensor when the s_power con

[PATCH 1/3] usb: gadget: pxa27x: add phy notifier event handler

2016-07-08 Thread Robert Jarzmik
devicetree platforms, we'll rely on the probe deferral, and the phy can be gadget API agnostic. Signed-off-by: Robert Jarzmik --- drivers/usb/gadget/udc/pxa27x_udc.c | 51 +++-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/u

[PATCH 2/3] usb: phy: generic: cope with initial state

2016-07-08 Thread Robert Jarzmik
e gadget will be aware it should answer enumeration and go forth Without this fix, the USB cable must be removed and replugged for any gadget relying on phy-generic and its gpio vbus handling to work. The problem was seen on a pxa27x architecture based board on a devicetree build. Signed-off-by

[PATCH 3/3] usb: phy: generic: remove the vbus dependency

2016-07-08 Thread Robert Jarzmik
not necessary anymore. Signed-off-by: Robert Jarzmik --- drivers/usb/phy/phy-generic.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index 41b8aff9b925..c14e767a3fbf 100644 --- a/drivers/usb/phy/phy

Re: [PATCH 5/5] rtc: v3020: move rtc-v3020.h to platform_data

2016-07-09 Thread Robert Jarzmik
Alexandre Belloni writes: > rtc-v3020.h belongs to include/linux/platform_data/ > > Signed-off-by: Alexandre Belloni > --- > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Cc: linux-arm-ker...@lists.infradead.org > arch/arm/mach-pxa/cm-x270.c

[PATCH] dmaengine: pxa_dma: implement device_synchronize

2016-07-10 Thread Robert Jarzmik
ensures on pxa architecture that the interrupt cannot be fired anymore Reported-by: Vinod Koul Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index e756a30ccba2

Re: [RFC] [PATCH v2 1/3] scatterlist: Add support to clone scatterlist

2016-07-12 Thread Robert Jarzmik
Mark Brown writes: > On Thu, Jul 07, 2016 at 07:43:25PM +0200, Robert Jarzmik wrote: > >> I'll try, but I don't trust much my chances of success, given that this >> tester : >> - should compile and link in $(TOP)/lib/scatterlist.c, as this is where >

Re: [PATCH RFC v2 1/2] media: platform: transfer format translations to soc_mediabus

2016-07-12 Thread Robert Jarzmik
Hans Verkuil writes: > On 04/02/2016 04:26 PM, Robert Jarzmik wrote: >> Transfer the formats translations to soc_mediabus. Even is soc_camera >> was to be deprecated, soc_mediabus will survive, and should describe all >> that happens on the bus connecting the image proce

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Robert Jarzmik
Hans Verkuil writes: > Hi Robert, > > A quick review below. > > I assume this is the first step to moving the pxa_camera driver out of > soc-camera? Hi Hans, It probably is. The next step would be the soc_camera adherence removal. I already began the work, but it's still in very early draft ugly

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Robert Jarzmik
Hans Verkuil writes: > On 03/11/2016 02:41 PM, Robert Jarzmik wrote: >> Hans Verkuil writes: > One area where I would like to see some helper functions is with respect to > format/media bus processing. I played with this a little bit but it is > surprisingly > hard to do.

Re: [PATCH v2] dmaengine: pxa_dma: fix cyclic transfers

2016-03-03 Thread Robert Jarzmik
Vinod Koul writes: > On Tue, Feb 16, 2016 at 10:54:02PM +0100, Robert Jarzmik wrote: >> While testing audio with pxa2xx-ac97, underrun were happening while the >> user application was correctly feeding the music. Debug proved that the >> cyclic transfer is not cyclic, ie. th

Re: [PATCH 1/4] scatterlist: Introduce some helper functions

2016-03-03 Thread Robert Jarzmik
Baolin Wang writes: > @@ -212,6 +212,37 @@ static inline void sg_unmark_end(struct scatterlist *sg) > } > > /** > + * sg_is_contiguous - Check if the scatterlists are contiguous > + * @sga: SG entry > + * @sgb: SG entry > + * > + * Description: > + * If the sga scatterlist is contiguous wit

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-03-03 Thread Robert Jarzmik
Fabio Estevam writes: > On Sat, Feb 20, 2016 at 12:48 PM, Robert Jarzmik > wrote: > >> Hello, >> >> I'll reping once more, to see if any of you could give this patch a try. >> So far Hitoshi doesn't have the hardware anymore, so it leaves only Guennad

Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set

2016-03-05 Thread Robert Jarzmik
Arnd Bergmann writes: > I guess we can bring back the macros for the case that MTD_XIP and XIP_KERNEL > are both enabled. > > Arnd I wouldn't have ICMR and ICIP exposed to drivers, Eric's original move looks corect to me. On the other hand, I'm wondering if xip_irqpending(), xip_currtime()

Re: Problems with commit a770d946371e ("gpio: pxa: add pin control gpio direction and request")

2016-03-27 Thread Robert Jarzmik
mail, while I'm doing the same on my Jenkins, on both device-tree and legacy platform-data builds, to see if we can fix this ? Cheers. -- Robert ---8<--- >From 05c5c95d4ee77918be9c2ef271edf8dcd492ab81 Mon Sep 17 00:00:00 2001 From: Robert Jarzmik Date: Sun, 27 Mar 2016 21:13:20 +0200 Su

[PATCH] dmaengine: pxa: handle bus errors

2016-03-28 Thread Robert Jarzmik
and T1 was completed while T2 causes a bus error, the status of T3 and T4 will be reported as DMA_IN_PROGRESS, while the channel is actually stopped. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/d

[PATCH] gpio: pxa: fix legacy non pinctrl aware builds

2016-03-29 Thread Robert Jarzmik
changing a gpio direction is very very seldom, usually in machine initialization, seldom in drivers probe, and an exception for ac97 reset bug. Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request") Reported-by: Guenter Roeck Tested-by: Guenter Roeck Signed-off-

[PATCH v2] media: platform: pxa_camera: convert to vb2

2016-03-29 Thread Robert Jarzmik
ned-off-by: Robert Jarzmik --- Since v1: took into account Hans's comments renamed all vb2 functions to pxac_vb2_*() --- drivers/media/platform/soc_camera/Kconfig | 4 +- drivers/media/platform/soc_camera/pxa_camera.c | 576 - 2 files changed, 266 ins

Re: [PATCH] ARM: pxa: fix the number of DMA requestor lines

2016-03-29 Thread Robert Jarzmik
Robert Jarzmik writes: > The number of requestor lines was clamped to 0 for all pxa architectures > in the requestor declaration. Fix this by using the value. > > Fixes: 72b195cb7162 ("ARM: pxa: add the number of DMA requestor lines") > Signed-off-by: Robert Jarzmik &

[PATCH RFC 0/2] pxa_camera transition to v4l2 standalone device

2016-03-19 Thread Robert Jarzmik
v4l2 devices - pxa_camera is ported This sets a ground of discussion for soc_camera adherence removal from pxa_camera. I'd like to have a comment from Hans if this is what he has in mind, and Guennadi if he agrees to transfer the soc xlate stuff to soc_mediabus. Cheers. -- Robert Robert

[PATCH RFC 2/2] media: platform: pxa_camera: make a standalone v4l2 device

2016-03-19 Thread Robert Jarzmik
provided by then sensor, ie. not MCLK, the dual stage change is not handled yet. (see all the comments left) Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 715 ++--- include/linux/platform_data/media/camera-pxa.h | 2 + 2 files changed

[PATCH RFC 1/2] media: platform: transfer format translations to soc_mediabus

2016-03-19 Thread Robert Jarzmik
available in the v4l2 device, given any sensors format capabilities bound with known image processing transformations. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/soc_camera.c | 7 +-- drivers/media/platform/soc_camera/soc_mediabus.c | 65

[PATCH v2] net: smc911x: convert pxa dma to dmaengine

2016-03-19 Thread Robert Jarzmik
Convert the dma transfers to be dmaengine based, now pxa has a dmaengine slave driver. This makes this driver a bit more PXA agnostic. The driver was only compile tested. The risk is quite small as no current PXA platform I'm aware of is using smc911x driver. Signed-off-by: Robert Ja

Re: [PATCH RFC 0/2] pxa_camera transition to v4l2 standalone device

2016-03-21 Thread Robert Jarzmik
Hans Verkuil writes: > On 03/19/2016 10:01 PM, Robert Jarzmik wrote: >> Hi Hans and Guennadi, >> >> As Hans is converting sh_mobile_ceu_camera.c, > > That's not going as fast as I hoped. This driver is quite complex and > extracting > it from soc-camera

Re: [PATCH RFC 0/2] pxa_camera transition to v4l2 standalone device

2016-03-21 Thread Robert Jarzmik
Hans Verkuil writes: >> Input ioctls: >> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) >> test VIDIOC_G/S_FREQUENCY: OK (Not Supported) >> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) >> test VIDIOC_ENUMAUDIO: OK (Not Supported) >> fail: v4l2-test-in

[PATCH] ASoC: wm9713: fix regmap free path

2016-02-19 Thread Robert Jarzmik
removing the doubled regmap free. Fixes: 700dadfefc3d ASoC: wm9713: convert to regmap Signed-off-by: Robert Jarzmik --- sound/soc/codecs/wm9713.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm9713.c b/sound/soc/codecs/wm9713.c index 79e143625ac3

[PATCH 2/4] ASoC: wm9713: add device tree support

2016-02-20 Thread Robert Jarzmik
Add the code to be able to use this codec in a devicetree platform. This is tested with the zylonite pxa310 board. Signed-off-by: Robert Jarzmik --- sound/soc/codecs/wm9713.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/codecs/wm9713.c b/sound/soc/codecs/wm9713.c

[PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Robert Jarzmik
This adds a binding for the Wolfson WM9713 audio codec. Signed-off-by: Robert Jarzmik --- Documentation/devicetree/bindings/sound/wm9713.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/wm9713.txt diff --git a/Documentation

[PATCH 3/4] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2016-02-20 Thread Robert Jarzmik
This adds a binding for the Marvell PXA audio complex, available in pxa2xx and pxa3xx variants. Signed-off-by: Robert Jarzmik --- .../bindings/sound/marvell,pxa2xx-ac97.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree

[PATCH 4/4] ASoC: pxa: add pxa2xx-ac97 devicetree support

2016-02-20 Thread Robert Jarzmik
Add the devicetree support, so that the driver can be used in a devicetree platform. Signed-off-by: Robert Jarzmik --- sound/arm/pxa2xx-ac97-lib.c | 11 +++ sound/soc/pxa/pxa2xx-ac97.c | 10 ++ 2 files changed, 21 insertions(+) diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-02-20 Thread Robert Jarzmik
Hitoshi Mitake writes: > Hi Robert, > > On Sat, Feb 6, 2016 at 6:05 PM, Robert Jarzmik wrote: > > Please just keep pinging people to properly test this. > > Okay, let's have another try. > > Hi Guennadi, Hitoshi, Fabio, > >

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Robert Jarzmik
Mark Brown writes: > On Sat, Feb 20, 2016 at 03:37:56PM +0100, Robert Jarzmik wrote: > >> +WM9713 audio CODEC >> + >> +This devices supports I2C. > > No, it clearly doesn't... Right, it supports AC97. > The problem with doing this is that since AC'97

[PATCH v2] ASoC: wm9713: fix regmap free path

2016-02-20 Thread Robert Jarzmik
removing the doubled regmap free. Fixes: 700dadfefc3d ASoC: wm9713: convert to regmap Signed-off-by: Robert Jarzmik --- Since v1: fix the diff second hunk, god knows where it came from. --- sound/soc/codecs/wm9713.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/wm9713.c b

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Robert Jarzmik
Mark Brown writes: > On Sat, Feb 20, 2016 at 07:22:04PM +0100, Robert Jarzmik wrote: >> Mark Brown writes: Removed DT people from this conversation. >> > Instead we should be probing at runtime (as the non-ASoC AC'97 code does) >> > or >> > something s

[PATCH v3] net: ethernet: davicom: fix devicetree irq resource

2016-02-20 Thread Robert Jarzmik
t_irq(), which handles the deferral. Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse IRQ flags from resources"), the interrupt trigger flags are honored in platform_get_irq(), so remove the needless code in dm9000. Signed-off-by: Robert Jarzmik Acked-by: Marc

Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

2016-02-20 Thread Robert Jarzmik
Arnd Bergmann writes: > Coming back to the specific pxa25x_udc case: using __raw_* accessors > in the driver would possibly end up breaking the PXA25x machines in > the (very unlikely) case that someone wants to make it work with > big-endian kernels, assuming it does not have the same hardware >

Re: [PATCH] ARM: pxa: pxa3xx device-tree support cleanup

2016-02-20 Thread Robert Jarzmik
Robert Jarzmik writes: > Clocks, timer and several other drivers have well defined and working > device-tree bindings. Clean-up the code to leave only the strict > minimum. The final goal will be to remove the lookup array. > > Signed-off-by: Robert Jarzmik Queued to pxa/f

Re: [PATCH v2 4/4] dmaengine: pxa_dma: fix the maximum requestor line

2016-02-20 Thread Robert Jarzmik
Robert Jarzmik writes: > The current number of requestor lines is limited to 31. This was an > error of a previous commit, as this number is platform dependent, and is > actually : > - for pxa25x: 40 requestor lines > - for pxa27x: 75 requestor lines > - for pxa3xx: 1

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Robert Jarzmik
Mark Brown writes: > On Sat, Feb 20, 2016 at 09:32:58PM +0100, Robert Jarzmik wrote: >> Mark Brown writes: >> > On Sat, Feb 20, 2016 at 07:22:04PM +0100, Robert Jarzmik wrote: >> I will. By now I fail to see how this will help in the wm9713 probing and >> detectio

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-21 Thread Robert Jarzmik
Guennadi Liakhovetski writes: >> Okay Guennadi, I retested this version on top of v4.5-rc2, still good to >> go. There is a minor conflict in the includes since this submission, and I >> can >> repost a v6 which solves it. > > How did you test it with that patchg #3?? I rebased my patches on top

Re: [PATCH v6] serial: rewrite pxa2xx-uart to use 8250_core

2016-02-21 Thread Robert Jarzmik
he transition to the new driver faster. > >> If so, great, get the platform maintainer to sign off on this please and >> then resend it. If you're talking about the PXA maintainer, then : Acked-by: Robert Jarzmik I'm happy with the patch, all pxa board maintainers have been warned, and there exists a fallback solution. So let's go forward, and if people complain, let them complain and forward them to me. Cheers. -- Robert

Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb

2016-02-22 Thread Robert Jarzmik
t/ohci-pxa27x.c at line 441: > ---8<--- > 441: usb_clk = devm_clk_get(&pdev->dev, NULL); > 442: if (IS_ERR(usb_clk)) > 443: return PTR_ERR(usb_clk); > ---8<--- > > The error is caused by different names for the same DT node in pxa2xx.dtsi > and pxa27x.dt

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2016-02-22 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > On Sun, 21 Feb 2016, Robert Jarzmik wrote: > Please, have a look at > http://git.linuxtv.org/gliakhovetski/v4l-dvb.git/log/?h=for-4.6-2 > If all is good there, no need for a v6 Thanks for fixing the *_dma_irq() mess, and sorry for that. And I just

[PATCH v2] ASoC: wm9713: fix regmap free path

2016-02-22 Thread Robert Jarzmik
initialization code with the non devm_() variant. Fixes: 700dadfefc3d ASoC: wm9713: convert to regmap Cc: Lars-Peter Clausen Signed-off-by: Robert Jarzmik --- Since v1: changed the fix into removing the devm_() variant --- sound/soc/codecs/wm9713.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 9/9] ARM: mmp: mark usb_dma_mask as __maybe_unused

2016-02-22 Thread Robert Jarzmik
Arnd Bergmann writes: > This variable may be used by some devices that each have their > on Kconfig symbol, or by none of them, and that causes a build > warning: > > arch/arm/mach-mmp/devices.c:241:12: error: 'usb_dma_mask' defined but not > used [-Werror=unused-variable] > > Marking it __maybe

[PATCH 0/4] Fix pxa dma requestor lines

2016-02-11 Thread Robert Jarzmik
rant/Kumar/Ian ack on patch 1/4 - Haojian's ack on patch 2/4 - Vinod's ack on patch 4/4 Thanks in advance. -- Robert Robert Jarzmik (4): dma: mmp_pdma: Add the #requestors DT property documentation dmaengine: mmp-pdma: add number of requestors ARM: pxa: add the number of

[PATCH 4/4] dmaengine: pxa_dma: fix the maximum requestor line

2016-02-11 Thread Robert Jarzmik
faulty constant as on pxa[23]xx platforms, only camera, MSL and USB are above requestor 32, and in these only the camera has a driver using dma. Fixes: e87ffbdf0697 ("dmaengine: pxa_dma: fix the no-requestor case") Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_

[PATCH 2/4] dmaengine: mmp-pdma: add number of requestors

2016-02-11 Thread Robert Jarzmik
The DMA chip has a fixed number of requestor lines used for flow control. This number is platform dependent. The pxa_dma dma driver will use this value to activate or not the flow control. There won't be any impact on mmp_pdma driver. Signed-off-by: Robert Jarzmik --- include/

[PATCH 1/4] dma: mmp_pdma: Add the #requestors DT property documentation

2016-02-11 Thread Robert Jarzmik
For pxa based platforms, the number of requestor lines should be specified, so that the driver can check if the flow control should be activated (when a requestor line is asked for) or not. Signed-off-by: Robert Jarzmik --- Documentation/devicetree/bindings/dma/mmp-dma.txt | 2 ++ 1 file

[PATCH 3/4] ARM: pxa: add the number of DMA requestor lines

2016-02-11 Thread Robert Jarzmik
Declare the number of DMA requestor lines per platform : - for pxa25x: 40 requestor lines - for pxa27x: 75 requestor lines - for pxa3xx: 100 requestor lines This information will be used to activate the DMA flow control or not. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa27x.dtsi

Re: [PATCH 1/4] dma: mmp_pdma: Add the #requestors DT property documentation

2016-02-12 Thread Robert Jarzmik
Arnd Bergmann writes: > On Thursday 11 February 2016 22:23:15 Robert Jarzmik wrote: >> @@ -12,6 +12,8 @@ Required properties: >> Optional properties: >> - #dma-channels: Number of DMA channels supported by the controller >> (defaults >>to 32 when not spe

[PATCH] mtd: nand: pxa3xx_nand: fix dmaengine initialization

2016-02-12 Thread Robert Jarzmik
MA IO resource is not acquired through platform resources but by OF bindings. Fix this by ensuring that DMA IO resources are only queried in the non device-tree case. Fixes: 8f5ba31aa565 ("mtd: nand: pxa3xx-nand: switch to dmaengine") Signed-off-by: Robert Jarzmik --- drivers/mtd/nand/px

[PATCH] ARM: dts: pxa: fix dma engine node to pxa3xx-nand

2016-02-12 Thread Robert Jarzmik
configuration, ie. failing all data transfers. Fixes: c943646d1f49 ("ARM: dts: pxa: add dma engine node to pxa3xx-nand") Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa3xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/pxa3xx.dtsi b/arch/ar

[PATCH] usb: host: ohci-pxa27x: propagate the irq error code

2016-02-13 Thread Robert Jarzmik
. Even if in this specific case the driver was not broken, because the interrupt controller is always probed before drivers, propagate the proper return code. Signed-off-by: Robert Jarzmik --- drivers/usb/host/ohci-pxa27x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 11/41] clk: pxa: Remove CLK_IS_ROOT

2016-03-01 Thread Robert Jarzmik
Stephen Boyd writes: > This flag is a no-op now. Remove usage of the flag. > > Cc: Robert Jarzmik > Signed-off-by: Stephen Boyd > --- > drivers/clk/pxa/clk-pxa25x.c | 8 +++- > drivers/clk/pxa/clk-pxa27x.c | 6 +++--- > drivers/clk/pxa/clk-pxa3xx.c | 8 ---

[PATCH v3 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-26 Thread Robert Jarzmik
previously the minimum turnaround time was counted in 76ns steps, while with this patch it is counted in microsecond steps. The strictly equal formula would have been : while ((sched_clock() - si->last_clk) * 76 < mtt) Signed-off-by: Robert Jarzmik --- Since v2: fixed clock calculat

[PATCH v3 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-26 Thread Robert Jarzmik
Convert the pxa IRDA driver to readl and writel primitives, and remove another set of direct registers access. This leaves only the DMA registers access, which will be dealt with dmaengine conversion. Signed-off-by: Robert Jarzmik Tested-by: Petr Cvek --- Since v1: modified __REG macro to cope

[PATCH v3 3/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-26 Thread Robert Jarzmik
Convert pxaficp_ir to dmaengine. As pxa architecture is shifting from raw DMA registers access to pxa_dma dmaengine driver, convert this driver to dmaengine. Signed-off-by: Robert Jarzmik Tested-by: Petr Cvek --- Since v1: removed mach/dma.h include, which is the goal --- drivers/net/irda

Re: [PATCH] ARM: pxa: add resources to pxaficp_ir

2015-09-26 Thread Robert Jarzmik
Petr Cvek writes: > Tested-by: Petr Cvek Thanks for the test. Applied to pxa/for-next. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-in

[PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM"

2015-09-26 Thread Robert Jarzmik
mongst which pxa have been tested as broken. Signed-off-by: Robert Jarzmik --- drivers/video/backlight/pwm_bl.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index eff379b234cc..57cb9ec8be43 100644 --- a/drivers/vide

Re: [PATCH v2] ARM: pxa: mioa701: add wm9713 codec

2015-09-26 Thread Robert Jarzmik
Robert Jarzmik writes: > The mioa701 is using the wm9713 for audio, battery and touchscreen. Add > the missing audio part, which disappeared. > > Signed-off-by: Robert Jarzmik > --- > Since v1: Igor's catch of subject prefix issue Queued in pxa/for-next. -- Robert -- T

[PATCH v3] mmc: pxamci: fix card detect with slot-gpio API

2015-09-26 Thread Robert Jarzmik
cannot be a nested interrupt from a threaded interrupt (set __setup_irq()). This was tested on zylonite and mioa701 boards. Signed-off-by: Robert Jarzmik Cc: Petr Cvek --- Since v1: trade threaded interrupt for slot-gpio API Since v2: remove gpio_free() calls --- drivers/mmc/host/pxamci.c | 66

<    5   6   7   8   9   10   11   12   13   14   >