[PATCH wireless/arlan] Replace logical- by bit-and

Totally untested patch below from linus' git tree. The is incorrect, right? from drivers/net/wireless/arlan.h:390: #define ARLAN_POWER 0x40 #define ARLAN_ACCESS0x80 Replace logical and by bit-and Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/pcmcia/au1000_xxs1500.c b/drivers/pcmcia/au1000_xxs1500.c index ce9d5c4..855e1d6 100644 --- a/drivers/pcmcia/au1000_xxs1500.c +++ b/drivers/pcmcia/au1000_xxs1500.c @@ -56,7 +56,7 @@ #define PCMCIA_IRQ AU1000_GPIO_4 #if 0

Re: [PATCH wireless/arlan] Replace logical- by bit-and

Randy Dunlap wrote: On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h index 3ed1df7..7b7498f 100644 --- a/drivers/net/wireless/arlan.h +++ b/drivers/net/wireless/arlan.h @@ -485,7 +485,7 @@ struct arlan_private

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

Paul Mundt wrote: On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote: On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote: -#define DEBUG(x,args...) printk(__FUNCTION__ : x,##args) +#define DEBUG(x, args...) printk(%s: , __func__, x, ##args) Can this really be expected

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

Paul Mundt wrote: On Fri, Jan 11, 2008 at 10:45:30AM +0100, Roel Kluin wrote: Paul Mundt wrote: On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote: On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote: -#define DEBUG(x,args...) printk(__FUNCTION__ : x,##args) +#define DEBUG(x

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

Paul Mundt wrote: On Fri, Jan 11, 2008 at 12:04:14PM +0100, Roel Kluin wrote: Paul Mundt wrote: Take a look at how CONFIG_PCMCIA_DEBUG is handled. In drivers/pcmcia/Makefile, when CONFIG_PCMCIA_DEBUG=y, it gives EXTRA_CFLAGS += -DDEBUG which causes the definition of DEBUG as a macro

Re: [rfc-patch 07/11] Text Edit Lock - kprobes architecture independent support

Mathieu Desnoyers wrote: Use the mutual exclusion provided by the text edit lock in the kprobes code. It allows coherent manipulation of the kernel code by other subsystems. Signed-off-by: Mathieu Desnoyers [EMAIL PROTECTED] Acked-by: Ananth N Mavinakayanahalli [EMAIL PROTECTED] CC:

Re: [PATCH 7/8] UML - add virt_to_pte

Jeff Dike wrote: Turn um_virt_to_phys into virt_to_pte, cleaning up a horrid interface. It's also made non-static and declared in pgtable.h because it'll be needed when the stubs get a vma. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/kernel/skas/uaccess.c | 56

[PATCH drivers/isdn/hardware/eicon/message.c] fix 'and' typo in eicons' AddInfo()

I have previously sent this to [EMAIL PROTECTED] and its maintainer, but the error is still in linus' tree. -- '!' has a higher priority than '', so as was the bit test masks a binary. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers

[PATCH] asm-h8300: parentheses around definition CLOCK_TICK_RATE

errors Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/include/asm-h8300/timex.h b/include/asm-h8300/timex.h index 2041314..23e6701 100644 --- a/include/asm-h8300/timex.h +++ b/include/asm-h8300/timex.h @@ -6,7 +6,7 @@ #ifndef _ASM_H8300_TIMEX_H #define _ASM_H8300_TIMEX_H -#define

[PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl

evaluate to something like: (1792000 / 15 ) bta-sampleshift Isn't intended (HWBASE_AD * 4)/(bta-decimation bta-sampleshift)? Then consider the patch below. -- Fix operator precedence in return Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/sound/oss/btaudio.c b/sound/oss/btaudio.c

[PATCH] asm-arm/{arch-omap,arch-ixp23xx}: parentheses around NR_IRQS definition

paranoya? anyway, adding parentheses should be safe. -- Add parentheses to prevent operator precedence errors Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/include/asm-arm/arch-ixp23xx/irqs.h b/include/asm-arm/arch-ixp23xx/irqs.h index e696395..27c5808 100644 --- a/include/asm-arm

Re: [PATCH] asm-arm/{arch-omap,arch-ixp23xx}: parentheses around NR_IRQS definition

Roel Kluin wrote: Add parentheses to prevent operator precedence errors Signed-off-by: Roel Kluin [EMAIL PROTECTED] For the arch-ixp23xx part I should have added: Acked-by: Lennert Buytenhek [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH] net/e1000: fix memcpy in e1000_get_strings

) / (ETH_GSTRING_LEN * ETH_GSTRING_LEN) Please confirm that the change is as wanted. -- A lack of parentheses around defines causes unexpected results due to operator precedences. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000

[PATCH] fix 'and' typos in drivers/block/pktcdvd.c

Fix two 'and' typos Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index a8130a4..9cd6ba2 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2202,11 +2202,11 @@ static int pkt_media_speed(struct pktcdvd_device *pd

[PATCH] fix 'and' typo in drivers/block/paride/pt.c

Fix 'and' typo (PT_WRITE_OK is defined 2) Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/block/paride/pt.c b/drivers/block/paride/pt.c index 9f4e67e..b91accf 100644 --- a/drivers/block/paride/pt.c +++ b/drivers/block/paride/pt.c @@ -664,7 +664,7 @@ static int pt_open(struct

Debugging activated during runtime

Wouldn't it be nice to be able to specify upon loading, or during runtime to modules whether debug messages should be printed? - No kernel recompile needed for debugging. - Less *_DEBUG options required in menuconfig. How I think this could work: Add to the module struct a bool to denote

Re: Debugging activated during runtime

Jan Engelhardt wrote: On Oct 28 2007 16:15, Roel Kluin wrote: Wouldn't it be nice to be able to specify upon loading, or during runtime to modules whether debug messages should be printed? modprobe ark3116 debug=1 Nothing new. Ok, thanks and sorry, I didn't know that. - A module could

build failure, missing libvdeplug.h?

Building uml with an allyesconfig and a few changes in UML only fails with: ... CC arch/um/drivers/vde_user.o /home/roel/dnld/src/kernel/git/linux-2.6/arch/um/drivers/vde_user.c:8:24: error: libvdeplug.h: No such file or directory

Re: build failure, missing libvdeplug.h?

Roel Kluin wrote: the file libvdeplug.h is missing There is a reference to http://wiki.virtualsquare.org/index.php/Main_Page in the Kconfig (also added by this commit). After reverting this commit the build continues. possibly the header libvdeplug.h was forgotten? Sorry for answering

Re: [PATCH 9/16] CRIS architecture: Correct compile errors

Jesper Nilsson wrote: static int e100_probe_transceiver(struct net_device* dev) { +#if !defined(CONFIG_ETRAX_NO_PHY) unsigned int phyid_high; unsigned int phyid_low; unsigned int oui; struct transceiver_ops* ops = NULL; + struct net_local *np =

Re: [PATCH] several returns before unlocking in lmc_ioctl

Kristof Provost wrote: On 2007-10-23 03:47:48 (+0200), Roel Kluin [EMAIL PROTECTED] wrote: I think we should keep the lmc_tracing. Use this patch instead. -- Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net

Re: [2.6 patch] fix drivers/net/wan/lmc/ compilation

Adrian Bunk wrote: Documentation/SubmitChecklist, point 1: -- snip -- ... CC drivers/net/wan/lmc/lmc_main.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In function ‘lmc_ioctl’:

[PATCH 4/4 returns] fix not-and/or errors

Thanks for comments, here a second version with previously covered commits removed Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c index 5cd3cad..7229319 100644 --- a/arch/arm/mach-pxa/mfp.c +++ b/arch/arm/mach-pxa/mfp.c

Re: [PATCH 1/4] fix not-and/or errors

Al Viro wrote: On Wed, Oct 17, 2007 at 03:46:43PM +0200, Roel Kluin wrote: +++ b/drivers/misc/asus-laptop.c @@ -322,7 +322,7 @@ static void write_status(acpi_handle handle, int out, int mask) switch (mask) { case MLED_ON: -out = !out 0x1; +out = !(out

Re: [PATCH 1/4] fix not-and/or errors

previously applied changes removed and changed as suggested. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c index 7dce318..752ae26 100644 --- a/drivers/misc/asus-laptop.c +++ b/drivers/misc/asus-laptop.c @@ -322,7 +322,7

Re: [PATCH 9/9] RT: Only dirty a cacheline if the priority is actually changing

Gregory Haskins wrote: We can avoid dirtying a rq related cacheline with a simple check, so why not. Signed-off-by: Gregory Haskins [EMAIL PROTECTED] --- 0 files changed, 0 insertions(+), 0 deletions(-) I think you wanted a patch here? - To unsubscribe from this list: send the line

[PATCH] errors with assignments in if

with assignments in ifs Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c index d9af436..e6e85b7 100644 --- a/arch/arm/mach-omap2/clock.c +++ b/arch/arm/mach-omap2/clock.c @@ -651,7 +651,7 @@ static u32 omap2_get_clksel(u32

Re: [PATCH] errors with assignments in if

Roel Kluin wrote: I am not entirely certain about the third one: from fs/udf/udf_sb.h: #define UDF_SB_VAT(X) ( UDF_SB(X)-s_vat ) if it's the desired behavior then I think this should at least be changed to UDF_SB_VAT(sb) = udf_iget(sb, ino); if (!(UDF_SB_VAT

[PATCH] return hidden bug

return hidden bug Signed-off-by: Roel Kluin [EMAIL PROTECTED] diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index e1c4707..6a69425 100644 --- a/arch/alpha/kernel/pci_iommu.c +++ b/arch/alpha/kernel/pci_iommu.c @@ -365,8 +365,8 @@ pci_unmap_single(struct

Re: [PATCH] return hidden bug

Rik van Riel wrote: On Mon, 22 Oct 2007 03:05:05 +0200 Roel Kluin [EMAIL PROTECTED] wrote: return hidden bug Signed-off-by: Roel Kluin [EMAIL PROTECTED] diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index e1c4707..6a69425 100644 --- a/arch/alpha

[PATCH] unlock before bug returns

I think the unlock should be before bugging? -- unlock before bug returns Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index 5a4cc20..c910170 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach-omap2

Re: [PATCH] unlock before bug returns

Roel Kluin wrote: unlock before bug returns if (cs = GPMC_CS_NUM || !gpmc_cs_reserved(cs)) { printk(KERN_ERR Trying to free non-reserved GPMC CS%d\n, cs); - BUG(); spin_unlock(gpmc_mem_lock); - return; + BUG

Re: [PATCH] unlock before bug returns

that occur before BUG() as well? -- Unlock before BUG() Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c index 88629a3..679c8b4 100644 --- a/drivers/mtd/ubi/vmt.c +++ b/drivers/mtd/ubi/vmt.c @@ -100,8 +100,10 @@ static ssize_t

[PATCH retry] return hidden bug and unlock bugs

(), but don't change behavior in the case when CONFIG_BUG is disabled Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index e1c4707..6a69425 100644 --- a/arch/alpha/kernel/pci_iommu.c +++ b/arch/alpha/kernel/pci_iommu.c

Re: [PATCH] return hidden bug

Ray Lee wrote: I'm sorry, perhaps I poured myself a cup of stupid this morning, but isn't the above patch effectively introducing a BUG where none could be reached before? In other words, for the patch to have zero behavioral change, wouldn't it have to remove the BUG() altogether? True, but

Re: [PATCH] return hidden bug

Ray Lee wrote: I'm sorry, perhaps I poured myself a cup of stupid this morning, but isn't the above patch effectively introducing a BUG where none could be reached before? In other words, for the patch to have zero behavioral change, wouldn't it have to remove the BUG() altogether? True, but

Re: [PATCH retry] return hidden bug and unlock bugs

Roel Kluin wrote: This patches shouldn't alter behavior when CONFIG_BUG is disabled. It is meant as a replacement for the previous patches. Concerning the patch changing fs/buffer.c, I am still wondering whether page_cache_release(page) should be placed before or after the BUG

Re: [PATCH] unlock before bug returns

Rene Herman wrote: On 10/22/2007 02:40 PM, Pekka Enberg wrote: NAK. This will cause double-unlock when CONFIG_BUG is disabled. It's incorrect to assume that BUG() will always terminate the current process. (which by the way also means that the return; delete from your original patch

[PATCH] unlock 12c_mutex before return

unlock 12c_mutex before return -EINVAL Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/media/dvb/dvb-usb/au6610.c b/drivers/media/dvb/dvb-usb/au6610.c index 18e0b16..31f47c7 100644 --- a/drivers/media/dvb/dvb-usb/au6610.c +++ b/drivers/media/dvb/dvb-usb/au6610.c

Re: [PATCH] unlock 12c_mutex before return

And a similar one in drivers/media/dvb/dvb-usb/gl861.c -- unlock 12c_mutex before return -EINVAL Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/media/dvb/dvb-usb/gl861.c b/drivers/media/dvb/dvb-usb/gl861.c index f01d99c..20c340a 100644 --- a/drivers/media/dvb

[PATCH] several returns before unlocking in lmc_ioctl

Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c index 5ea8772..af7b3e4 100644 --- a/drivers/net/wan/lmc/lmc_main.c +++ b/drivers/net/wan/lmc/lmc_main.c @@ -142,9

[PATCH] Unlock in iTCO_wdt_start when reboot is disabled

commit 61c31efe4e9c34531666a6c5857ecd19c8db Author: Roel Kluin [EMAIL PROTECTED] Date: Tue Oct 23 03:08:27 2007 +0200 Unlock in iTCO_wdt_start when reboot is disabled Signed-off-by: Roel Kluin [EMAIL PROTECTED] diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog

[PATCH] Unlock before return in p9_mux_poll_start

commit 9f822afc65cc094c905901f9d92bf25042f9ed22 Author: Roel Kluin [EMAIL PROTECTED] Date: Tue Oct 23 03:15:55 2007 +0200 Unlock before return in p9_mux_poll_start Signed-off-by: Roel Kluin [EMAIL PROTECTED] diff --git a/net/9p/mux.c b/net/9p/mux.c index f140147..c9f0805 100644

Re: [PATCH] several returns before unlocking in lmc_ioctl

I think we should keep the lmc_tracing. Use this patch instead. -- Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c index 5ea8772..64eb578 100644 --- a/drivers

Re: [PATCH] unlock 12c_mutex before return

Andreas Schwab wrote: -if (num 2) +if (num 2) { +mutex_unlock(d-i2c_mutex); return -EINVAL; How about moving the check before the lock? Good suggestion. Patch below covers both previous patches. -- Move check before lock Signed-off-by: Roel Kluin

[PATCH] Unlock when ssp tries to close an invalid port

Unlock when ssp tries to close an invalid port Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/arm/mach-pxa/ssp.c b/arch/arm/mach-pxa/ssp.c index 71766ac..422afee 100644 --- a/arch/arm/mach-pxa/ssp.c +++ b/arch/arm/mach-pxa/ssp.c @@ -309,6 +309,7 @@ void ssp_exit(struct

[PATCH] Fix unlocking before return in gpio

Fix unlocking before return in gpio Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/cris/arch-v10/drivers/gpio.c b/arch/cris/arch-v10/drivers/gpio.c index f389ed6..0d347a7 100644 --- a/arch/cris/arch-v10/drivers/gpio.c +++ b/arch/cris/arch-v10/drivers/gpio.c @@ -297,8

[PATCH 1/?] Unlock when sn_oemdata can't be extended

Unlock when sn_oemdata can't be extended Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/ia64/sn/kernel/mca.c b/arch/ia64/sn/kernel/mca.c index 3db62f2..868c9aa 100644 --- a/arch/ia64/sn/kernel/mca.c +++ b/arch/ia64/sn/kernel/mca.c @@ -98,6 +98,7

[PATCH 2/2] Fix unlock on error

Fix unlock on error Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c index a0a9105..a6e6e78 100644 --- a/arch/mips/kernel/irixsig.c +++ b/arch/mips/kernel/irixsig.c @@ -426,6 +426,7 @@ asmlinkage int irix_sigprocmask(int

Re: [PATCH 1/?] Unlock when sn_oemdata can't be extended

Several unlocking issues Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/net/9p/mux.c b/net/9p/mux.c index f140147..c9f0805 100644 --- a/net/9p/mux.c +++ b/net/9p/mux.c @@ -222,8 +222,10 @@ static int p9_mux_poll_start(struct p9_conn *m) } if (i

Re: [PATCH 1/?] Unlock when sn_oemdata can't be extended

This includes some that I think I have reported earlier: in drivers/media/dvb/dvb-usb/au6610.c and drivers/media/dvb/dvb-usb/gl861.c -- Some more unlocking issues Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/char/drm/sis_mm.c b/drivers/char/drm/sis_mm.c index

[PATCH] [arch/arm/mach-pnx4008/gpio.c] duplication in if ... else if branches

There is a duplication of code in the following section. Possibly it was copy-pasted and it was forgotten to edit these lines? otherwise consider removing the duplicate lines with the patch below. --- Different if ... else if branches do the same, remove duplication Signed-off-by: Roel Kluin

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

James Bottomley wrote: On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote: duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct No, it looks completely incorrect to me. What makes you think

[PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct --- fix noncoherent allocation Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent

John David Anglin wrote: James Bottomley wrote: On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote: duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct No, it looks completely incorrect to me

[PATCH][fs/cifs/cifsfs.c] Make use of cifs_xquota_get

else in the kernel. The patch below makes use of the function cifs_xquota_get, As an alternative the entire function cifs_xquota_get could be removed. --- Make use of cifs_xquota_get Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index fcc4342

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent = pa11_dma_alloc_consistent?

Matthew Wilcox wrote: On Mon, Feb 11, 2008 at 05:23:33PM +0100, Roel Kluin wrote: duplicate pa11_dma_alloc_consistent; more appropriate appears pa11_dma_alloc_noncoherent here. Not tested, please confirm that this fix is correct I don't think it is. The memories are fading, so I don't

[PATCH][drivers/pnp/pnpacpi/core.c] __initdata is not an identifier

these sparse complaints do not occur --- __initdata is not an identifier Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c index 662b4c2..c283a9a 100644 --- a/drivers/pnp/pnpacpi/core.c +++ b/drivers/pnp/pnpacpi/core.c @@ -36,7 +36,7

Re: [PATCH] crypto: be*_add_cpu conversion

[EMAIL PROTECTED] wrote: From: Marcin Slusarz [EMAIL PROTECTED] replace all: big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) + expression_in_cpu_byteorder); with: beX_add_cpu(big_endian_variable, expression_in_cpu_byteorder);

Re: [PATCH] ufs: [bl]e*_add_cpu conversion

also want these: --- [bl]e_add_cpu conversion in return Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/fs/ufs/swab.h b/fs/ufs/swab.h index 1683d2b..a1e3000 100644 --- a/fs/ufs/swab.h +++ b/fs/ufs/swab.h @@ -44,18 +44,22 @@ static __inline u32 fs64_add(struct super_block *sbp, u32 *n

[drivers/video/sis/init301.c] SiS_Pr-ChipType = SIS_661 not evaluated twice

Not sure whether this is important, but in drivers/video/sis/init301.c:1557: if((SiS_Pr-ChipType = SIS_661) || (SiS_Pr-SiS_ROMNew)) { SiS_Pr-SiS_LCDTypeInfo = (SiS_GetReg(SiS_Pr-SiS_P3d4,0x39) 0x7c) 2; } else if((SiS_Pr-ChipType SIS_315H) || (SiS_Pr-ChipType = SIS_661)) {

Re: Announce: Linux-next (Or Andrew's dream :-))

Linus Torvalds wrote: On Tue, 12 Feb 2008, Greg KH wrote: That's the point. Not it isn't. To quote you a number of years ago: Linux is evolution, not intelligent design Umm. Have you read a lot of books on evolution? It doesn't sound like you have. The fact is, evolution often

Re: [PATCH] use array_size macro

Please use this one instead. it also removes an unnecessary #define. This patch changes code to use the ARRAY_SIZE macro. This patch is the result of: find -name *.[chsS] | xargs sed -i s/sizeof(\(\w*\))[ \t]*\/[ \t]*sizeof(\1\[0\])/ARRAY_SIZE(\1)/g Signed-off-by: Roel Kluin [EMAIL PROTECTED

[PATCH] use array_size macro

This patch changes code to use the ARRAY_SIZE macro. This patch is the result of: find -name *.[chsS] | xargs sed -i s/sizeof(\(\w*\))[ \t]*\/[ \t]*sizeof(\1\[0\])/ARRAY_SIZE(\1)/g Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/arm/kernel/dma-isa.c b/arch/arm/kernel/dma-isa.c

Re: [PATCH] use array_size macro

Jeff Dike wrote: On Fri, Sep 28, 2007 at 12:56:31PM +0200, Roel Kluin wrote: arch/um/kernel/tt/ptproxy/ptrace.c | 12 ++-- I don't know what you're diffing against, but this file is history in -mm, and will be gone in mainline after 2.6.23. Jeff Thanks for noting me. I

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

Greg KH wrote: @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, if (block == NULL) { struct file_lock *conf = kzalloc(sizeof(*conf), GFP_KERNEL); + struct nlm_host *host; if (conf == NULL) return

Re: [PATCH v4] IBM power meter driver

Mark M. Hoffman wrote: +static void ibmpex_register_bmc(int iface, struct device *dev) +{ +struct ibmpex_bmc_data *data; +int err; + +data = kzalloc(sizeof(*data), GFP_KERNEL); +if (!data) { +printk(KERN_ERR DRVNAME : Insufficient memory for BMC +

Re: [PATCH 09/31] IGET: Stop BFS from using iget() and read_inode() [try #3]

It is very well possible that I misunderstand the locking order here, but FWIW: David Howells wrote: diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c index f346eb1..76798c9 100644 --- a/fs/bfs/inode.c +++ b/fs/bfs/inode.c @@ -32,25 +32,29 @@ MODULE_LICENSE(GPL); void dump_imap(const char

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

Bryan Wu wrote: +static int ad7142_i2c_read(struct i2c_client *client, unsigned short offset, + unsigned short *data, unsigned int len) +{ + int ret = -1; + int i; + u8 block_data[32]; + + if (len 1 len 16) { you want || here + printk(KERN_ERR

Re: [PATCH] tty_ioctl: Fix the baud_table check in encode_baud_rate

Since you were sending a fix, possibly I shouldn't comment on this. If so please disregard my suggestion for a trivial cleanup. Roel Maciej W. Rozycki wrote: +void tty_termios_encode_baud_rate(struct ktermios *termios, + speed_t ibaud, speed_t obaud) {

[PATCH 1/4] fix not-and/or errors

if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review this is against current git. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/media/video/pvrusb2/pvrusb2-ctrl.c b/drivers/media/video/pvrusb2

Re: [PATCH 2/4] fix not-and/or errors

Roel Kluin wrote: if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review several changes to drivers/net/ Signed-off-by: Roel Kluin [EMAIL PROTECTED] hmmm forgot to place '---' here, should I resend? diff --git

[PATCH 4/4] fix not-and/or errors

if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c index 5cd3cad..7229319 100644 --- a/arch/arm/mach-pxa/mfp.c

[PATCH 2/4] fix not-and/or errors

if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review several changes to drivers/net/ Signed-off-by: Roel Kluin [EMAIL PROTECTED] diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c index cf70522

Re: [PATCH 3/4] fix not-and/or errors

commit 568f9787e58b4d24be50ab2abf1c7dab12a9ef2c Author: Roel Kluin [EMAIL PROTECTED] Date: Wed Oct 17 15:16:44 2007 +0200 if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review several changes to drivers/isdn/ Signed

Re: Fix bug in end absolute address in drivers/mtd/devices/slram.c

; + devlength = handle_unit(devlength, buffer); if (devlength devstart) goto err_out; ... adding the suspects to CC so that they are aware of this. Yes, that's what it should have been. FWIW, Acked-by: Roel Kluin roel.kl...@gmail.com -- To unsubscribe

[drivers/misc/thinkpad_acpi.c] duplicate test if (level TP_EC_FAN_FULLSPEED)

in drivers/misc/thinkpad_acpi.c: 4137-4142 it reads: /* safety net should the EC not support AUTO * or FULLSPEED mode bits and just ignore them */ if (level TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 */

[drivers/scsi/NCR53C9x.c] remove duplication for family_code == 0x00

) { if ((version 7) == 2) esp-erev = fas100a; /* NCR53C9X */ else esp-erev = espunknown; Note the duplication of test 'if(family_code == 0x00)' and lines below Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git

[PATCH][sound/soc/fsl/mpc8610_hpcd.c] duplicate strcasecmp test for rj-master in mpc8610_hpcd_probe()

In linus' git tree I found this problem. Is it also in the alsa tree? please confirm it's the right fix. The patch was not yet tested. -- duplicate test for rj-master Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c index

[PATCH][drivers/misc/thinkpad_acpi.c] duplicate test 'if (level TP_EC_FAN_FULLSPEED)'

in drivers/misc/thinkpad_acpi.c, lines 4137-4142 it reads: /* safety net should the EC not support AUTO * or FULLSPEED mode bits and just ignore them */ if (level TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7

[PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level TP_EC_FAN_FULLSPEED)

is Not A Good Thing. So, as a safety net, we now make sure to also set the fan level part of the HFSP register to speed 7 for full-speed, and a minimum of speed 4 for auto mode. -- second TP_EC_FAN_FULLSPEED should be P_EC_FAN_AUTO Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers

[PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE'

the memory to the device DMA_FROM_DEVICE = PCI_DMA_FROMDEVICEdata is coming from the device to the Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c index 662c004..1e704f9 100644

Re: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE'

[EMAIL PROTECTED] wrote: Good to know that somebody still uses the Ultrastor 14f board :). Yes, this typo was introduced by somebody doing massive editing to all scsi drivers long ago. Cheers, --db Actually, I do not own a Ultrastor 14f board. I found this by searching for if (test) ...

Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level TP_EC_FAN_FULLSPEED)

Henrique de Moraes Holschuh wrote: On Tue, 05 Feb 2008, Roel Kluin wrote: Roland Dreier wrote: /* safety net should the EC not support AUTO * or FULLSPEED mode bits and just ignore them */ if (level TP_EC_FAN_FULLSPEED

Re: [PATCH/HP7XX] - Add combined LCD / BL driver for platform HP Jornada 7xx handhelds

Roel Kluin wrote: Kristoffer Ericson wrote: Greetings, Richard I've cleaned up the driver by checking with checkpatch.pl as Russell suggested. I would appreciate it if you could look through the patch again and give comments since the patch looks somewhat different. I can add patch

Re: [PATCH/HP7XX] - Add combined LCD / BL driver for platform HP Jornada 7xx handhelds

Kristoffer Ericson wrote: Greetings, Richard I've cleaned up the driver by checking with checkpatch.pl as Russell suggested. I would appreciate it if you could look through the patch again and give comments since the patch looks somewhat different. I can add patch for Kconfig/Makefile

Re: [PATCH/HP7XX] - Add combined LCD / BL driver for platform HP Jornada 7xx handhelds

Kristoffer Ericson wrote: Oki, here is attempt #2 (btw, new mail or just keep thread?) Tested to build and checkpatch. diff --git a/drivers/video/backlight/jornada720_bllcd.c b/drivers/video/backlight/jornada720_bllcd.c +static int jornada_bl_update_status(struct backlight_device *dev)

Re: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE'

James Bottomley wrote: On Mon, 2008-02-04 at 23:36 +0100, Roel Kluin wrote: Note the duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE' - if (SCpnt-sc_data_direction == DMA_FROM_DEVICE) { + if (SCpnt-sc_data_direction == DMA_TO_DEVICE) { cpp-xdir = DTD_IN; return

Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level TP_EC_FAN_FULLSPEED)

Greg KH wrote: On Tue, Feb 05, 2008 at 09:34:54AM +0100, Roel Kluin wrote: Henrique de Moraes Holschuh wrote: On Tue, 05 Feb 2008, Roel Kluin wrote: Roland Dreier wrote: Note the duplicate test 'if (level TP_EC_FAN_FULLSPEED)'. should this be replaced by Actually I suspect one

[PATCH][drivers/usb/serial/ftdi_sio.c] add missing '|'

add missing '|' Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 90dcc62..2173561 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -394,7 +394,7 @@ static const char *ftdi_chip_name

Re: [PATCH 05/18] MMC: OMAP: Introduce new multislot structure and change driver to use it

Carlos Aguiar wrote: From: Juha Yrjola [EMAIL PROTECTED] Introduce new MMC multislot structure and change driver to use it. diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c It could be that I misunderstand, but... @@ -897,19 +1037,106 @@ static const struct mmc_host_ops

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote: - if (val 0x1) + if (val 0x1) Joe Perches wrote: I think this pattern should be added to checkpatch + if ($line =~ /\\\s*0[xX]/) { On Thu, Jan 24, 2008 at 01:18:48AM +0100, Roel Kluin wrote: I agree

[drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM

In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy(): if (pause_adv (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM)) Note that the two are the same and this is therefore equivalent to if (pause_adv ADVERTISE_1000XPSE_ASYM) This appears to be incorrect, was maybe '|

[PATCH][drivers/net/fec_mpc52xx.c] duplicate NETIF_MSG_IFDOWN in MPC52xx_MESSAGES_DEFAULT

Untested patch below, please confirm it's the right fix. -- duplicate NETIF_MSG_IFDOWN, 2nd should be NETIF_MSG_IFUP Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c index f91ee70..ca3c3b3 100644 --- a/drivers/net/fec_mpc52xx.c

[PATCH][net/sched/sch_teql.c] duplicate IFF_BROADCAST in FMASK, remove 2nd

Untested patch below, please confirm it's the right fix (should it be some other IFF_*?) -- duplicate IFF_BROADCAST, remove 2nd Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index c0ed06d..a53acf4 100644 --- a/net/sched/sch_teql.c +++ b

[PATCH][drivers/pcmcia/ti113x.h] ENE_TEST_C9_PFENABLE duplicate *_F0

Untested patch below, please confirm it's the right fix. -- duplicate ENE_TEST_C9_PFENABLE_F0, 2nd should be *_F1 Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/pcmcia/ti113x.h b/drivers/pcmcia/ti113x.h index d29657b..87a5fd5 100644 --- a/drivers/pcmcia/ti113x.h +++ b

[PATCH][drivers/usb/gadget/amd5536udc.c] duplicate use_dma_ppb_du = 2nd use_dma_ppb

Untested patch below, please confirm it's the right fix. -- duplicate use_dma_ppb_du, 2nd should be use_dma_ppb Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c index c72e962..fbc10f9 100644 --- a/drivers/usb/gadget

[PATCH] [wireless/iwlwifi/iwl-4965.c] add parentheses

'!' has a higher priority than '': bitanding has no effect. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c index 569347f..2439868 100644 --- a/drivers/net/wireless/iwlwifi/iwl-4965.c +++ b/drivers/net

[PATCH] [drivers/video/i810/i810_main.c] add parentheses

'!' has a higher priority than '': bitanding has no effect. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c index 1a7d778..1d13dd0 100644 --- a/drivers/video/i810/i810_main.c +++ b/drivers/video/i810/i810_main.c

  1   2   3   >