[PATCH] [video/sis/sis_main.c] add parentheses

'!' has a higher priority than '': bitanding has no effect. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c index 93ae747..5b28fa2 100644 --- a/drivers/video/sis/sis_main.c +++ b/drivers/video/sis/sis_main.c @@ -427,7 +427,7

[PATCH] [drivers/misc/asus-laptop.c] add parentheses

'!' has a higher priority than '': bitanding has no effect. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c index 7dce318..65c67d1 100644 --- a/drivers/misc/asus-laptop.c +++ b/drivers/misc/asus-laptop.c @@ -322,7 +322,7

[PATCH] [rivers/media/video/tvaudio.c] add parentheses

'!' has a higher priority than '': bitanding has no effect. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c index a755605..01ebcec 100644 --- a/drivers/media/video/tvaudio.c +++ b/drivers/media/video/tvaudio.c @@ -1571,14

Re: [2.6 patch] atm/idt77105.c: fix section mismatch

:EXPORT_SYMBOL(vio_unregister_device); __cpu_init arch/x86/kernel/topology.c:60:EXPORT_SYMBOL(arch_register_cpu); -- EXPORT_SYMBOL'ed code mustn't be __*init. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/arm/mach-imx/generic.c b/arch/arm/mach-imx/generic.c index 4cfc9d3..92e098a 100644

[PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

logical/bitand typo Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c index ebf9e21..dcfb459 100644 --- a/arch/powerpc/boot/4xx.c +++ b/arch/powerpc/boot/4xx.c @@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void) val

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

Joe Perches wrote: On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote: Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c index ebf9e21..dcfb459 100644 --- a/arch/powerpc/boot/4xx.c +++ b/arch/powerpc/boot/4xx.c @@ -104,7 +104,7

Re: Announce: Linux-next (Or Andrew's dream :-))

Linus Torvalds wrote: On Wed, 13 Feb 2008, Roel Kluin wrote: In nature there is a lot of duplication: several copies of genes can exist and different copies may have a distinct evolution. This is true of very complex animals, but much less so when looking at things like bacteria

Re: Announce: Linux-next (Or Andrew's dream :-))

Alan Cox wrote: Evolution in nature and changes in code are different because in code junk and bugs are constantly removed. In biology junk is allowed and may provide a pool for future development. Linux development is intended and not survival. I would be interested to see any evidence

Re: + bluetooth-fix-warning-in-net-bluetooth-hci_sysfsc.patch added to -mm tree

Andrew Morton wrote: On Sat, 16 Feb 2008 01:27:41 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: [EMAIL PROTECTED] Date: Fri, 15 Feb 2008 20:49:33 -0800 Subject: bluetooth: fix warning in net/bluetooth/hci_sysfs.c From: Andrew Morton [EMAIL PROTECTED]

[PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

Replace !likely(x) by likely(!x) Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/x86/kernel/signal_32.c b/arch/x86/kernel/signal_32.c index caee1f0..335872f 100644 --- a/arch/x86/kernel/signal_32.c +++ b/arch/x86/kernel/signal_32.c @@ -303,7 +303,7 @@ get_sigframe(struct

[PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/kernel/exit.c b/kernel/exit.c index 506a957..df207fc 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1497,7 +1497,7 @@ repeat

[PATCH 1/3] Fix Unlikely(x) == y

The patch below was not yet tested. If it's correct as it is, please comment. --- Fix Unlikely(x) == y Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/powerpc/platforms/ps3/interrupt.c b/arch/powerpc/platforms/ps3/interrupt.c index 3a6db04..a14e5cd 100644 --- a/arch/powerpc

[PATCH 3/3] drivers/s390/block/dcssblk.c: Fix Unlikely(x) != y

The patch below was not yet tested. If it's correct as it is, please comment. --- Fix Unlikely(x) != y Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 3faf053..e6c94db 100644 --- a/drivers/s390/block/dcssblk.c +++ b

[PATCH 2/3] drivers/media/video/sn9c102/sn9c102_core.c Fix Unlikely(x) == y

The patch below was not yet tested. If it's incorrect, please comment. --- Fix Unlikely(x) == y Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/media/video/sn9c102/sn9c102_core.c b/drivers/media/video/sn9c102/sn9c102_core.c index c40ba3a..66313b1 100644 --- a/drivers/media

[PATCH] kernel/sched.c unlikely(x) || unlikely(y) = unlikely(x || y)

Not yet tested. --- Replace unlikely(x) || unlikely(y) by unlikely(x || y) Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/kernel/sched.c b/kernel/sched.c index f28f19e..816c299 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -137,7 +137,7 @@ static inline void sg_inc_cpu_power

[PATCH] drivers/mtd/onenand/onenand_base.c unlikely(x) || unlikely(y) = unlikely(x || y)

Not yet tested. --- Replace unlikely(x) || unlikely(y) by unlikely(x || y) Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index 8d7d21b..7334b4a 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd

Re: [PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

Roel Kluin wrote: Replace !likely(x) by likely(!x) Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/x86/kernel/signal_32.c b/arch/x86/kernel/signal_32.c index caee1f0..335872f 100644 --- a/arch/x86/kernel/signal_32.c +++ b/arch/x86/kernel/signal_32.c @@ -303,7 +303,7

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

H. Peter Anvin wrote: Roel Kluin wrote: Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) Whoa... Are you sure this is correct? !likely(x) is equivalent to unlikely(!x), not the opposite, so this is a functional change... -hpa You are right, sorry

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

H. Peter Anvin wrote: Roel Kluin wrote: H. Peter Anvin wrote: Roel Kluin wrote: Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) Whoa... Are you sure this is correct? !likely(x) is equivalent to unlikely(!x), not the opposite, so this is a functional change

Re: [PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

Roel Kluin wrote: Roel Kluin wrote: Replace !likely(x) by likely(!x) sorry, please ignore this patch The patch below shouldn't change semantics. --- replace !likely(x) by unlikely(!x) Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/x86/kernel/signal_32.c b/arch/x86/kernel

[PATCH] fs/ufs/util.h 2nd parameter of fs32_to_cpu is not boolean

is not boolean --- Test the return value, rather than passing a boolean Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/fs/ufs/util.h b/fs/ufs/util.h index b26fc4d..23ceed8 100644 --- a/fs/ufs/util.h +++ b/fs/ufs/util.h @@ -58,7 +58,7 @@ ufs_set_fs_state(struct super_block *sb, struct

[PATCH] arch/sh/drivers/heartbeat.c ioremap is expected to succeed

!unlikely(hd-base) is equivalent to likely(!hd-base) (for instance see comments with commit fd312561adcc90e924f35d3032d5493aeb4c3017), I think the ioremap is expected to succeed? please confirm that's right. The patch below was *not* tested. --- ioremap is expected to succeed Signed-off-by: Roel

Re: [PATCH 1/3] Fix Unlikely(x) == y

David Howells wrote: Geert Uytterhoeven [EMAIL PROTECTED] wrote: Hence shouldn't we ask the gcc people what's the purpose of __builtin_expect(), if it doesn't live up to its promise? __builtin_expect() is useful on FRV where you _have_ to give each branch and conditional branch

[PATCH] wireless: Convert to list_for_each_entry_rcu()

Please verify, this patch was not yet tested. --- Convert list_for_each_rcu() to list_for_each_entry_rcu() Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net/wireless/strip.c b/drivers/net/wireless/strip.c index 88efe1b..c5aaab8 100644 --- a/drivers/net/wireless/strip.c

[PATCH] fs/ext4/mballoc.c: Convert to list_for_each_entry_rcu()

Please verify, this patch was not yet tested --- Convert list_for_each_rcu() to list_for_each_entry_rcu() Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index dd0fcfc..0c4dd13 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3127,6

Re: [PATCH] wireless: Convert to list_for_each_entry_rcu()

Roel Kluin wrote: Please verify, this patch was not yet tested. --- Convert list_for_each_rcu() to list_for_each_entry_rcu() Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- Same mistake as in other patch, please ignore the previous patch and consider the patch below. --- Convert

Re: [PATCH] fs/ext4/mballoc.c: Convert to list_for_each_entry_rcu()

Aneesh Kumar K.V wrote: On Tue, Feb 19, 2008 at 01:31:18AM +0100, Roel Kluin wrote: Please verify, this patch was not yet tested --- Convert list_for_each_rcu() to list_for_each_entry_rcu() Signed-off-by: Roel Kluin [EMAIL PROTECTED] NACK. This patch doesn't build. You have extra cur

[PATCH] fix writing to unintended memory in eth16i_probe_port(); drivers/net/eth16i.c

14 is added as an offset to the array dummy_packet (64 unsigned chars) to serve as a destination address in a call to memset(). However, when added, it is automatically scaled by the size of dummy_packet, which is 64. This results in writing to unintended memory. Signed-off-by: Roel Kluin [EMAIL

[PATCH] fix writing to unintended memory in pkt_generic_packet(); drivers/block/pktcdvd.c

in the call to memset() writing to unintended memory. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index a8130a4..548efcf 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -767,7 +767,7 @@ static int pkt_generic_packet

Re: [PATCH] fix writing to unintended memory in pkt_generic_packet(); drivers/block/pktcdvd.c

Al Viro wrote: On Tue, Nov 06, 2007 at 11:43:12PM +0100, Roel Kluin wrote: CDROM_PACKET_SIZE is added as an offset to the pointer to unsigned char cmd[16]. The adjusted pointer is then used as a destination address in a call to memset(). However, when CDROM_PACKET_SIZE is added

Re: [PATCH] fix writing to unintended memory in eth16i_probe_port(); drivers/net/eth16i.c

Al Viro wrote: On Tue, Nov 06, 2007 at 11:57:44PM +0100, Roel Kluin wrote: 14 is added as an offset to the array dummy_packet (64 unsigned chars) to serve as a destination address in a call to memset(). However, when added, it is automatically scaled by the size of dummy_packet, which is 64

[PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

If count reaches zero, the loop ends, but the postfix decrement subtracts it. so, testing for 'count == 0' will not work. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/sound/oss/trident.c b/sound/oss/trident.c index 96adc47..94b5fb4 100644 --- a/sound/oss/trident.c +++ b/sound/oss

Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

Ray Lee wrote: On Nov 7, 2007 10:34 AM, Roel Kluin [EMAIL PROTECTED] wrote: If count reaches zero, the loop ends, but the postfix decrement subtracts it. so, testing for 'count == 0' will not work. Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/sound/oss/trident.c b/sound/oss

tty: incorrect test of echo_buf() result for ECHO_OP_START

Untested, but this looks like a bug to me --- test echo_buf() result for ECHO_OP_START Signed-off-by: Roel Kluin roel.kl...@gmail.com --- diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c index 7a744b6..42b6cca 100644 --- a/drivers/tty/n_tty.c +++ b/drivers/tty/n_tty.c @@ -767,7

[PATCH] jump_label: unlikely(x) 0

untested, but wasn't this intended instead? -- if (unlikely(x) 0) doesn't seem to help branch prediction Signed-off-by: Roel Kluin roel.kl...@gmail.com --- diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h index a507907..cf08540 100644 --- a/include/linux

lockdep: testing '0' where '\0' intended?

Not entirely sure about the assembly part, but shouldn't it... Test for the nul character rather than the '0' (== 0x30), in the __get_user_unknown() case. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- diff --git a/kernel/lockdep_proc.c b/kernel/lockdep_proc.c index b2c71c5..71b3aba

exynos4: index out of bounds if no pixelcode found

In case no valid pixelcode is found, an i of -1 after the loop is out of bounds for the array. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- diff --git a/drivers/media/platform/exynos4-is/fimc-lite-reg.c b/drivers/media/platform/exynos4-is/fimc-lite-reg.c index 72a343e3b..d0dc7ee 100644

[PATCH] set data enable logic level to low

Signed-off-by: Roel Kluin roel.kl...@gmail.com --- drivers/video/omap2/dss/display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/omap2/dss/display.c b/drivers/video/omap2/dss/display.c index fafe7c9..669a81f 100644 --- a/drivers/video/omap2/dss/display.c

[PATCH] unset twsi option3 for gconfig as well

Signed-off-by: Roel Kluin roel.kl...@gmail.com --- drivers/pinctrl/mvebu/pinctrl-dove.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c b/drivers/pinctrl/mvebu/pinctrl-dove.c index 29f7e4f..360b9b2 100644 --- a/drivers/pinctrl/mvebu

Re: [PATCH] use array_size macro

Please use this one instead. it also removes an unnecessary #define. This patch changes code to use the ARRAY_SIZE macro. This patch is the result of: find -name *.[chsS] | xargs sed -i "s/sizeof(\(\w*\))[ \t]*\/[ \t]*sizeof(\1\[0\])/ARRAY_SIZE(\1)/g" Signed-off-by: Roel Klu

[PATCH] use array_size macro

This patch changes code to use the ARRAY_SIZE macro. This patch is the result of: find -name *.[chsS] | xargs sed -i "s/sizeof(\(\w*\))[ \t]*\/[ \t]*sizeof(\1\[0\])/ARRAY_SIZE(\1)/g" Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/kernel/dma-isa.c b/arc

Re: [PATCH] use array_size macro

Jeff Dike wrote: > On Fri, Sep 28, 2007 at 12:56:31PM +0200, Roel Kluin wrote: >> arch/um/kernel/tt/ptproxy/ptrace.c | 12 ++-- > > I don't know what you're diffing against, but this file is history in > -mm, and will be gone in mainline after 2.6.23. > > J

Re: [rfc-patch 07/11] Text Edit Lock - kprobes architecture independent support

Mathieu Desnoyers wrote: > Use the mutual exclusion provided by the text edit lock in the kprobes code. > It > allows coherent manipulation of the kernel code by other subsystems. > > Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]> > Acked-by: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]>

Re: [PATCH 7/8] UML - add virt_to_pte

Jeff Dike wrote: > Turn um_virt_to_phys into virt_to_pte, cleaning up a horrid interface. > > It's also made non-static and declared in pgtable.h because it'll be > needed when the stubs get a vma. > > Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> > --- > arch/um/kernel/skas/uaccess.c | 56 >

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

Greg KH wrote: @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, if (block == NULL) { struct file_lock *conf = kzalloc(sizeof(*conf), GFP_KERNEL); + struct nlm_host *host; if (conf == NULL) return

Re: [PATCH v4] IBM power meter driver

Mark M. Hoffman wrote: >> +static void ibmpex_register_bmc(int iface, struct device *dev) >> +{ >> +struct ibmpex_bmc_data *data; >> +int err; >> + >> +data = kzalloc(sizeof(*data), GFP_KERNEL); >> +if (!data) { >> +printk(KERN_ERR DRVNAME ": Insufficient memory for BMC

Re: [PATCH 09/31] IGET: Stop BFS from using iget() and read_inode() [try #3]

It is very well possible that I misunderstand the locking order here, but FWIW: David Howells wrote: > diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c > index f346eb1..76798c9 100644 > --- a/fs/bfs/inode.c > +++ b/fs/bfs/inode.c > @@ -32,25 +32,29 @@ MODULE_LICENSE("GPL"); > > void

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

Bryan Wu wrote: > +static int ad7142_i2c_read(struct i2c_client *client, unsigned short offset, > + unsigned short *data, unsigned int len) > +{ > + int ret = -1; > + int i; > + u8 block_data[32]; > + > + if (len < 1 && len > 16) { you want || here > +

[PATCH] errors with assignments in if

ors with assignments in ifs Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c index d9af436..e6e85b7 100644 --- a/arch/arm/mach-omap2/clock.c +++ b/arch/arm/mach-omap2/clock.c @@ -651,7 +651,7 @@ static u32 omap2_get_c

Re: [PATCH] errors with assignments in if

Roel Kluin wrote: > I am not entirely certain about the third one: > > from fs/udf/udf_sb.h: > > #define UDF_SB_VAT(X) ( UDF_SB(X)->s_vat ) > > if it's the desired behavior then I think this should at least be changed to > > UDF

[PATCH] return hidden bug

return hidden bug Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index e1c4707..6a69425 100644 --- a/arch/alpha/kernel/pci_iommu.c +++ b/arch/alpha/kernel/pci_iommu.c @@ -365,8 +365,8 @@ pci_unmap_single(

Re: [PATCH] return hidden bug

Rik van Riel wrote: > On Mon, 22 Oct 2007 03:05:05 +0200 > Roel Kluin <[EMAIL PROTECTED]> wrote: > >> return hidden bug >> >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> >> >> diff --git a/arch/alpha/kernel/pci_iommu.c >&g

[PATCH] unlock before bug returns

I think the unlock should be before bugging? -- unlock before bug returns Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index 5a4cc20..c910170 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach

Re: [PATCH] unlock before bug returns

Roel Kluin wrote: > unlock before bug returns > if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) { > printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs); > - BUG(); > spin_unlock(_mem_lock); > -

Re: [PATCH] unlock before bug returns

ome cases where it was attempted to free after BUG(). should that occur before BUG() as well? -- Unlock before BUG() Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c index 88629a3..679c8b4 100644 --- a/drivers/mtd/ubi

[PATCH retry] return hidden bug and unlock bugs

before BUG(), but don't change behavior in the case when CONFIG_BUG is disabled Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index e1c4707..6a69425 100644 --- a/arch/alpha/kernel/pci_iommu.c +++ b/a

Re: [PATCH] return hidden bug

Ray Lee wrote: > I'm sorry, perhaps I poured myself a cup of stupid this morning, but > isn't the above patch effectively introducing a BUG where none could > be reached before? In other words, for the patch to have zero > behavioral change, wouldn't it have to remove the BUG() altogether? True,

Re: [PATCH] return hidden bug

Ray Lee wrote: >>> I'm sorry, perhaps I poured myself a cup of stupid this morning, but >>> isn't the above patch effectively introducing a BUG where none could >>> be reached before? In other words, for the patch to have zero >>> behavioral change, wouldn't it have to remove the BUG()

Re: [PATCH retry] return hidden bug and unlock bugs

Roel Kluin wrote: > This patches shouldn't alter behavior when CONFIG_BUG is disabled. It is meant > as a replacement for the previous patches. > > Concerning the patch changing fs/buffer.c, I am still wondering whether > "page_cache_release(page)" should be place

Re: [PATCH] unlock before bug returns

Rene Herman wrote: > On 10/22/2007 02:40 PM, Pekka Enberg wrote: > >> NAK. This will cause double-unlock when CONFIG_BUG is disabled. It's >> incorrect to assume that BUG() will always terminate the current >> process. > > (which by the way also means that the "return;" delete from your >

[PATCH] unlock 12c_mutex before return

unlock 12c_mutex before return -EINVAL Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/media/dvb/dvb-usb/au6610.c b/drivers/media/dvb/dvb-usb/au6610.c index 18e0b16..31f47c7 100644 --- a/drivers/media/dvb/dvb-usb/au6610.c +++ b/drivers/media/dvb/dvb-usb/

Re: [PATCH] unlock 12c_mutex before return

And a similar one in drivers/media/dvb/dvb-usb/gl861.c -- unlock 12c_mutex before return -EINVAL Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/media/dvb/dvb-usb/gl861.c b/drivers/media/dvb/dvb-usb/gl861.c index f01d99c..20c340a 100644 --- a/drivers/med

[PATCH] several returns before unlocking in lmc_ioctl

Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c index 5ea8772..af7b3e4 100644 --- a/drivers/net/wan/lmc/lmc_main.c +++ b/drivers/net/wan/lmc/lmc_

[PATCH] Unlock in iTCO_wdt_start when reboot is disabled

commit 61c31efe4e9c34531666a6c5857ecd19c8db Author: Roel Kluin <[EMAIL PROTECTED]> Date: Tue Oct 23 03:08:27 2007 +0200 Unlock in iTCO_wdt_start when reboot is disabled Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> diff --git a/drivers/watchdog/iTCO_wdt.c b/driv

[PATCH] Unlock before return in p9_mux_poll_start

commit 9f822afc65cc094c905901f9d92bf25042f9ed22 Author: Roel Kluin <[EMAIL PROTECTED]> Date: Tue Oct 23 03:15:55 2007 +0200 Unlock before return in p9_mux_poll_start Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> diff --git a/net/9p/mux.c b/net/9p/mux.c index f140

Re: [PATCH] several returns before unlocking in lmc_ioctl

I think we should keep the lmc_tracing. Use this patch instead. -- Several returns before unlocking in lmc_ioctl Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c index 5ea8772..64eb578 100644 --- a/d

Re: [PATCH] unlock 12c_mutex before return

. -- Move check before lock Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/media/dvb/dvb-usb/au6610.c b/drivers/media/dvb/dvb-usb/au6610.c index 18e0b16..f3ff813 100644 --- a/drivers/media/dvb/dvb-usb/au6610.c +++ b/drivers/media/dvb/dvb-usb/au6610.c @@ -79,12 +79,12 @@

[PATCH] Unlock when ssp tries to close an invalid port

Unlock when ssp tries to close an invalid port Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/mach-pxa/ssp.c b/arch/arm/mach-pxa/ssp.c index 71766ac..422afee 100644 --- a/arch/arm/mach-pxa/ssp.c +++ b/arch/arm/mach-pxa/ssp.c @@ -309,6 +309,7 @@ void ssp_exit(

[PATCH] Fix unlocking before return in gpio

Fix unlocking before return in gpio Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/cris/arch-v10/drivers/gpio.c b/arch/cris/arch-v10/drivers/gpio.c index f389ed6..0d347a7 100644 --- a/arch/cris/arch-v10/drivers/gpio.c +++ b/arch/cris/arch-v10/drivers/gpio.c @@

[PATCH 1/?] Unlock when sn_oemdata can't be extended

Unlock when sn_oemdata can't be extended Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/ia64/sn/kernel/mca.c b/arch/ia64/sn/kernel/mca.c index 3db62f2..868c9aa 100644 --- a/arch/ia64/sn/kernel/mca.c +++ b/arch/ia64/sn/kernel/mca.c @@ -98,6

[PATCH 2/2] Fix unlock on error

Fix unlock on error Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c index a0a9105..a6e6e78 100644 --- a/arch/mips/kernel/irixsig.c +++ b/arch/mips/kernel/irixsig.c @@ -426,6 +426,7 @@ asmlinkage int irix_sigprocma

Re: [PATCH 1/?] Unlock when sn_oemdata can't be extended

Several unlocking issues Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/net/9p/mux.c b/net/9p/mux.c index f140147..c9f0805 100644 --- a/net/9p/mux.c +++ b/net/9p/mux.c @@ -222,8 +222,10 @@ static int p9_mux_poll_start(struct p9_conn *m) }

Re: [PATCH 1/?] Unlock when sn_oemdata can't be extended

This includes some that I think I have reported earlier: in drivers/media/dvb/dvb-usb/au6610.c and drivers/media/dvb/dvb-usb/gl861.c -- Some more unlocking issues Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/char/drm/sis_mm.c b/drivers/char/drm/sis_mm.c

[PATCH] fix 'and' typos in drivers/block/pktcdvd.c

Fix two 'and' typos Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index a8130a4..9cd6ba2 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2202,11 +2202,11 @@ static int pkt_media_speed(struct pktcdvd_

[PATCH] fix 'and' typo in drivers/block/paride/pt.c

Fix 'and' typo (PT_WRITE_OK is defined 2) Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/block/paride/pt.c b/drivers/block/paride/pt.c index 9f4e67e..b91accf 100644 --- a/drivers/block/paride/pt.c +++ b/drivers/block/paride/pt.c @@ -664,7 +664,7 @@ static int p

Debugging activated during runtime

Wouldn't it be nice to be able to specify upon loading, or during runtime to modules whether debug messages should be printed? - No kernel recompile needed for debugging. - Less *_DEBUG options required in menuconfig. How I think this could work: Add to the module struct a bool to denote

Re: Debugging activated during runtime

Jan Engelhardt wrote: > On Oct 28 2007 16:15, Roel Kluin wrote: >> Wouldn't it be nice to be able to specify upon loading, or during runtime >> to modules whether debug messages should be printed? > > modprobe ark3116 debug=1 > > Nothing new. Ok, than

[PATCH] fix writing to unintended memory in eth16i_probe_port(); drivers/net/eth16i.c

14 is added as an offset to the array dummy_packet (64 unsigned chars) to serve as a destination address in a call to memset(). However, when added, it is automatically scaled by the size of dummy_packet, which is 64. This results in writing to unintended memory. Signed-off-by: Roel Kluin

[PATCH] fix writing to unintended memory in pkt_generic_packet(); drivers/block/pktcdvd.c

in the call to memset() writing to unintended memory. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index a8130a4..548efcf 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -767,7 +767,7 @@ stat

Re: [PATCH] fix writing to unintended memory in pkt_generic_packet(); drivers/block/pktcdvd.c

Al Viro wrote: > On Tue, Nov 06, 2007 at 11:43:12PM +0100, Roel Kluin wrote: >> CDROM_PACKET_SIZE is added as an offset to the pointer to unsigned char >> cmd[16]. >> The adjusted pointer is then used as a destination address in a call to >> memset(). However, when

Re: [PATCH] fix writing to unintended memory in eth16i_probe_port(); drivers/net/eth16i.c

Al Viro wrote: > On Tue, Nov 06, 2007 at 11:57:44PM +0100, Roel Kluin wrote: >> 14 is added as an offset to the array dummy_packet (64 unsigned chars) to >> serve as a destination address in a call to memset(). However, when added, >> it is automatically scaled by the size o

[PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

If count reaches zero, the loop ends, but the postfix decrement subtracts it. so, testing for 'count == 0' will not work. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/sound/oss/trident.c b/sound/oss/trident.c index 96adc47..94b5fb4 100644 --- a/sound/oss/trident.c +++ b

Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

Ray Lee wrote: > On Nov 7, 2007 10:34 AM, Roel Kluin <[EMAIL PROTECTED]> wrote: >> If count reaches zero, the loop ends, but the postfix decrement subtracts it. >> so, testing for 'count == 0' will not work. >> >> Signed-off-by: Roel Kluin <[EMAIL PROTECTE

Re: [PATCH] tty_ioctl: Fix the baud_table check in encode_baud_rate

Since you were sending a fix, possibly I shouldn't comment on this. If so please disregard my suggestion for a trivial cleanup. Roel Maciej W. Rozycki wrote: > +void tty_termios_encode_baud_rate(struct ktermios *termios, > + speed_t ibaud, speed_t obaud) > { >

[PATCH 1/4] fix not-and/or errors

if(!x & y) should either be if(!(x & y)) or if(!x && y) I made changes as seemed appropriate, but please review this is against current git. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/media/video/pvrusb2/pvrusb2-ctrl.c b/drive

Re: [PATCH 2/4] fix not-and/or errors

Roel Kluin wrote: > if(!x & y) should either be if(!(x & y)) or if(!x && y) > I made changes as seemed appropriate, but please review > > several changes to drivers/net/ > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > hmmm

[PATCH 4/4] fix not-and/or errors

if(!x & y) should either be if(!(x & y)) or if(!x && y) I made changes as seemed appropriate, but please review Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c index 5cd3cad..7229319 100644 -

[PATCH 2/4] fix not-and/or errors

if(!x & y) should either be if(!(x & y)) or if(!x && y) I made changes as seemed appropriate, but please review several changes to drivers/net/ Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> diff --git a/drivers/net/e1000e/82571.c b/drivers/ne

Re: [PATCH 3/4] fix not-and/or errors

commit 568f9787e58b4d24be50ab2abf1c7dab12a9ef2c Author: Roel Kluin <[EMAIL PROTECTED]> Date: Wed Oct 17 15:16:44 2007 +0200 if(!x & y) should either be if(!(x & y)) or if(!x && y) I made changes as seemed appropriate, but please review several c

[PATCH 4/4 returns] fix not-and/or errors

Thanks for comments, here a second version with previously covered commits removed Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c index 5cd3cad..7229319 100644 --- a/arch/arm/mach-pxa/mfp.c +++ b/arch/arm/ma

Re: [PATCH 1/4] fix not-and/or errors

Al Viro wrote: > On Wed, Oct 17, 2007 at 03:46:43PM +0200, Roel Kluin wrote: >> +++ b/drivers/misc/asus-laptop.c >> @@ -322,7 +322,7 @@ static void write_status(acpi_handle handle, int out, >> int mask) >> >> switch (mask) { >> case ML

Re: [PATCH 1/4] fix not-and/or errors

previously applied changes removed and changed as suggested. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c index 7dce318..752ae26 100644 --- a/drivers/misc/asus-laptop.c +++ b/drivers/misc/asus-laptop.c @@ -322,7

Re: [PATCH 9/9] RT: Only dirty a cacheline if the priority is actually changing

Gregory Haskins wrote: > We can avoid dirtying a rq related cacheline with a simple check, so why not. > > Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> > --- > > 0 files changed, 0 insertions(+), 0 deletions(-) I think you wanted a patch here? - To unsubscribe from this list: send the

build failure, missing libvdeplug.h?

Building uml with an allyesconfig and a few changes in UML only fails with: ... CC arch/um/drivers/vde_user.o /home/roel/dnld/src/kernel/git/linux-2.6/arch/um/drivers/vde_user.c:8:24: error: libvdeplug.h: No such file or directory

Re: build failure, missing libvdeplug.h?

Roel Kluin wrote: > the file libvdeplug.h is missing > > There is a reference to http://wiki.virtualsquare.org/index.php/Main_Page in > the Kconfig (also added by this commit). > After reverting this commit the build continues. possibly the header > libvdeplug.h was

Re: [PATCH 9/16] CRIS architecture: Correct compile errors

Jesper Nilsson wrote: > static int > e100_probe_transceiver(struct net_device* dev) > { > +#if !defined(CONFIG_ETRAX_NO_PHY) > unsigned int phyid_high; > unsigned int phyid_low; > unsigned int oui; > struct transceiver_ops* ops = NULL; > + struct net_local *np =

Re: [PATCH] several returns before unlocking in lmc_ioctl

Kristof Provost wrote: > On 2007-10-23 03:47:48 (+0200), Roel Kluin <[EMAIL PROTECTED]> wrote: >> I think we should keep the lmc_tracing. Use this patch instead. >> >> -- >> Several returns before unlocking in lmc_ioctl >> >>

Re: [2.6 patch] fix drivers/net/wan/lmc/ compilation

Adrian Bunk wrote: > Documentation/SubmitChecklist, point 1: > > <-- snip --> > > ... > CC drivers/net/wan/lmc/lmc_main.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In > function ‘lmc_ioctl’: >

tty: incorrect test of echo_buf() result for ECHO_OP_START

Untested, but this looks like a bug to me --- test echo_buf() result for ECHO_OP_START Signed-off-by: Roel Kluin --- diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c index 7a744b6..42b6cca 100644 --- a/drivers/tty/n_tty.c +++ b/drivers/tty/n_tty.c @@ -767,7 +767,7 @@ static size_t

[PATCH] jump_label: unlikely(x) > 0

untested, but wasn't this intended instead? -- if (unlikely(x) > 0) doesn't seem to help branch prediction Signed-off-by: Roel Kluin --- diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h index a507907..cf08540 100644 --- a/include/linux/jump_label.h +++ b/incl

<    1   2   3   >