Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

2017-02-09 Thread Roger Quadros
On 08/02/17 22:43, Jack Pham wrote: > Hi Peter, Sriram, Arnd, > > On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: >> From: Arnd Bergmann >> >> For xhci-hcd platform device, all the DMA parameters are not >> configured properly, notably dma ops for dwc3 devices. So, set >> the dma fo

Re: drivers: usb: dwc3: A question...

2017-02-09 Thread Roger Quadros
Hi, On 09/02/17 10:14, Gustavo A. R. Silva wrote: > Hello everybody, > > I ran into the following piece of code at drivers/usb/dwc3/dwc3-omap.c:218 > (linux-next) > > 218static void dwc3_omap_set_mailbox(struct dwc3_omap *omap, > 219enum omap_dwc3_vbus_id_status status) > 220{ > 221

Re: [PATCH 0/8] usb: dwc3: add dual-role support

2017-02-08 Thread Roger Quadros
Vivek, On 09/02/17 08:42, Vivek Gautam wrote: > Hi Roger, > > On Mon, Jan 23, 2017 at 4:49 PM, Roger Quadros wrote: >> Hi, >> >> We rely on the OTG controller block to provide us with >> VBUS and ID line status via an interrupt. >> >> This is th

Re: [PATCH 6/8] ARM: dts: dra7x-evm: Enable dual-role mode for USB1

2017-01-26 Thread Roger Quadros
On 26/01/17 17:56, Tony Lindgren wrote: > * Roger Quadros [170123 03:21]: >> USB1 port is micro-AB type and can function as peripheral >> as well as host. Enable dual-role mode for USB1. > > Good to see this happening :) Can you please send the dts changes > separately

Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

2017-01-24 Thread Roger Quadros
Felipe, On 03/01/17 14:53, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Mathias & Felipe, >> >> On 17/11/16 17:01, Roger Quadros wrote: >>> Hi, >>> >>> Some XHCI controllers e.g. dwc3 based have a broken Port disable

[PATCH] extcon: palmas: Don't spam console

2017-01-24 Thread Roger Quadros
User is not interested in USB cable events appearing on the console. Use dev_dbg() instead of dev_info() for these events. Signed-off-by: Roger Quadros --- drivers/extcon/extcon-palmas.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon

[PATCH 8/8] ARM: dts: am57xx-idk: Enable dual-role mode for USB2

2017-01-23 Thread Roger Quadros
USB port is micro-AB type and can function as peripheral as well as host. Enable dual-role mode for USB2. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/am57xx-idk-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am57xx-idk-common.dtsi b

[PATCH 4/8] usb: dwc3: core.h: add some register definitions

2017-01-23 Thread Roger Quadros
Add OTG and GHWPARAMS6 register definitions Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 82 + 1 file changed, 82 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index d514dca..fc82d2e 100644 --- a

[PATCH 1/8] usb: otg-fsm: Prevent build warning "VDBG" redefined

2017-01-23 Thread Roger Quadros
.h:33, from drivers/usb/dwc3/ep0.c:33: include/linux/usb/otg-fsm.h:30:1: warning: "VDBG" redefined In file included from drivers/usb/dwc3/ep0.c:31: include/linux/usb/composite.h:615:1: warning: this is the location of the previous definition Signed-off-by: Roger Quadros Revi

[PATCH 0/8] usb: dwc3: add dual-role support

2017-01-23 Thread Roger Quadros
or directly read extcon?). cheers, -roger Roger Quadros (8): usb: otg-fsm: Prevent build warning "VDBG" redefined usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox() usb: dwc3: use BIT() macro where possible usb: dwc3: core.h: add some register definitions usb: dwc3: add du

[PATCH 3/8] usb: dwc3: use BIT() macro where possible

2017-01-23 Thread Roger Quadros
To avoid checkpatch warnings with new patches let's start using the BIT() macro wherever possible. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 192 +-- drivers/usb/dwc3/dwc3-omap.c | 48 +-- drivers/usb/dwc3/gadget.h

[PATCH 7/8] ARM: dts: am43xx: Enable dual-role mode for USB1

2017-01-23 Thread Roger Quadros
USB1 port is micro-AB type and can function as peripheral as well as host. Enable dual-role mode for USB1. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/am437x-gp-evm.dts | 2 +- arch/arm/boot/dts/am437x-sk-evm.dts | 2 +- arch/arm/boot/dts/am43x-epos-evm.dts | 2 +- 3 files changed, 3

[PATCH 5/8] usb: dwc3: add dual-role support

2017-01-23 Thread Roger Quadros
OST - Host controller active 1 0 B_IDLE - Both Host and Gadget controllers inactive 1 1 B_PERIPHERAL - Gadget controller active Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.c | 583 -- drivers/usb/dwc3/core.h | 38 ++

[PATCH 2/8] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()

2017-01-23 Thread Roger Quadros
We need to break from all cases if we want to treat each one of them separately. Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently") Signed-off-by: Roger Quadros --- drivers/usb/dwc3/dwc3-omap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb

[PATCH 6/8] ARM: dts: dra7x-evm: Enable dual-role mode for USB1

2017-01-23 Thread Roger Quadros
USB1 port is micro-AB type and can function as peripheral as well as host. Enable dual-role mode for USB1. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7-evm.dts | 2 +- arch/arm/boot/dts/dra72-evm-common.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2017-01-20 Thread Roger Quadros
Vivek, On 19/01/17 17:15, vivek.gau...@codeaurora.org wrote: > Hi Roger, > > On 2017-01-19 17:45, Roger Quadros wrote: >> Vivek, >> >> On 19/01/17 13:56, Vivek Gautam wrote: >>> Hi, >>> >>> >>> On Wed, Jun 22, 2016 at 2:00 PM, Roger

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2017-01-19 Thread Roger Quadros
Vivek, On 19/01/17 13:56, Vivek Gautam wrote: > Hi, > > > On Wed, Jun 22, 2016 at 2:00 PM, Roger Quadros wrote: > > Luckily hit this thread while checking about DRD role functionality for DWC3. > >> On 22/06/16 11:14, Felipe Balbi wrote: >>> &

Re: [PATCH v2] usb: host: xhci: plat: check hcc_params after add hcd

2017-01-17 Thread Roger Quadros
xhci_gen_setup() called from > usb_add_hcd(). > > This patch checks the Maximum Primary Stream Array Size > in the hcc_params register after add primary hcd. > > Signed-off-by: William wu Acked-by: Roger Quadros > --- > drivers/usb/host/xhci-plat.c | 6 +++--- > 1 file cha

Re: [PATCH] usb: host: xhci: plat: check hcc_params after add hcd

2017-01-13 Thread Roger Quadros
Hi, On 13/01/17 05:18, William Wu wrote: > From: William wu > > The commit 4ac53087d6d4 ("usb: xhci: plat: Create both > HCDs before adding them") move add hcd to the end of > probe, this cause hcc_params uninitiated, because xHCI > driver sets hcc_params in xhci_gen_setup() called from > usb_ad

Re: [PATCH] usb: hcd: initialize hcd->flags to 0 when rm hcd

2017-01-12 Thread Roger Quadros
On 12/01/17 17:33, Alan Stern wrote: > On Thu, 12 Jan 2017, Roger Quadros wrote: > >> William, >> >> On 12/01/17 14:03, William Wu wrote: >>> From: William wu >>> >>> On some platforms(e.g. rk3399 board), we can call hcd_add/remove >>>

Re: [PATCH] usb: hcd: initialize hcd->flags to 0 when rm hcd

2017-01-12 Thread Roger Quadros
William, On 12/01/17 14:03, William Wu wrote: > From: William wu > > On some platforms(e.g. rk3399 board), we can call hcd_add/remove > consecutively without calling usb_put_hcd/usb_create_hcd in between, > so hcd->flags can be stale. > > If the HC dies due to whatever reason then without this

Re: [PATCH v5 4/6] usb: xhci: use bus->sysdev for DMA configuration

2017-01-12 Thread Roger Quadros
Mathias, On 11/01/17 17:08, Alan Stern wrote: > On Wed, 11 Jan 2017, Mathias Nyman wrote: > >> On 17.11.2016 13:43, Sriram Dash wrote: >>> From: Arnd Bergmann >>> >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops for dwc3 devices. So, set >

Re: gpio: pcf857x: lockdep warning on v4.10-rc3

2017-01-11 Thread Roger Quadros
Grygorii, On 10/01/17 22:00, Grygorii Strashko wrote: > Hi > > On 01/10/2017 06:18 AM, Roger Quadros wrote: >> Hi Linus, >> >> I see the following lockdep warning on v4.10-rc3 on TI's dra7-evm. >> >> reverting (d245b3f9bd3 "gpio: simplify

Re: gpio: pcf857x: lockdep warning on v4.10-rc3

2017-01-11 Thread Roger Quadros
On 11/01/17 17:38, Linus Walleij wrote: > On Tue, Jan 10, 2017 at 1:18 PM, Roger Quadros wrote: > >> Hi Linus, >> >> I see the following lockdep warning on v4.10-rc3 on TI's dra7-evm. >> >> reverting (d245b3f9bd3 "gpio: simplify adding threaded inter

gpio: pcf857x: lockdep warning on v4.10-rc3

2017-01-10 Thread Roger Quadros
Hi Linus, I see the following lockdep warning on v4.10-rc3 on TI's dra7-evm. reverting (d245b3f9bd3 "gpio: simplify adding threaded interrupts") seems to fix it. [2.358337] [ cut here ] [2.363194] WARNING: CPU: 1 PID: 76 at kernel/locking/lockdep.c:3124 gpiochi

Re: [PATCH v5 0/6] inherit dma configuration from parent dev

2017-01-10 Thread Roger Quadros
On 05/01/17 19:16, Greg KH wrote: > On Thu, Jan 05, 2017 at 05:21:09PM +0200, Roger Quadros wrote: >> Hi, >> >> On 17/11/16 13:43, Sriram Dash wrote: >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops for

Re: [PATCH v5 0/6] inherit dma configuration from parent dev

2017-01-05 Thread Roger Quadros
Hi, On 17/11/16 13:43, Sriram Dash wrote: > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. > > The idea here is that you pass in the parent of_node along > with the child device pointer, so it would behave exactly > like the p

Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

2017-01-03 Thread Roger Quadros
Mathias & Felipe, On 17/11/16 17:01, Roger Quadros wrote: > Hi, > > Some XHCI controllers e.g. dwc3 based have a broken Port disable [1]. > > If the attached high-speed device is misbehaving, the USB stack typically > disables the port using the PED bit in PORTSC. Fo

[PATCH v2] usb: dwc3: gadget: Fix full speed mode

2017-01-03 Thread Roger Quadros
ff-by: Roger Quadros --- drivers/usb/dwc3/core.h | 6 ++ drivers/usb/dwc3/gadget.c | 5 ++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index de5a857..389dd6d 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/c

Re: [PATCH 1/1] extcon: usb-gpio: add pinctrl operation during system PM

2017-01-03 Thread Roger Quadros
Hi Peter, On 03/01/17 10:17, Peter Chen wrote: > At some systems, the pinctrl setting will be lost or needs to > set as "sleep" state to save power consumption. So, we need to > configure pinctrl as "sleep" state when system enters suspend, > and as "default" state after system resumes. In this wa

Re: [PATCH v5 4/6] usb: xhci: use bus->sysdev for DMA configuration

2016-12-09 Thread Roger Quadros
Hi, On 17/11/16 13:43, Sriram Dash wrote: > From: Arnd Bergmann > > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. So, set > the dma for xhci from sysdev. sysdev is pointing to device that > is known to the system firmware or

[PATCH v2] extcon: palmas: Check the parent instance to prevent the NULL

2016-12-08 Thread Roger Quadros
igned-off-by: Roger Quadros --- Changelog: v2: - updated error message and commit message subject drivers/extcon/extcon-palmas.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 634ba70..a128fd2 100644 --- a/drivers/e

Re: [PATCH] extcon: palmas: Fail gracefully if invalid configuration

2016-12-08 Thread Roger Quadros
NULL pointer error I'm OK with this. > > On 2016년 12월 07일 21:12, Roger Quadros wrote: >> extcon-palmas must be child of palmas and expects parent's >> drvdata to be valid. Check for non NULL parent drvdata and >> fail if it is NULL. Not doing so will result in a NU

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

2016-12-07 Thread Roger Quadros
Hi, On 29/11/16 14:28, Roger Quadros wrote: > Hi, > > On 29/11/16 13:51, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> DCFG.DEVSPD == 0x3 is not valid and we need to set >>> DCFG.DEVSPD to 0x1 for full speed mode. >> >&

[PATCH] extcon: palmas: Fail gracefully if invalid configuration

2016-12-07 Thread Roger Quadros
igned-off-by: Roger Quadros --- drivers/extcon/extcon-palmas.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 634ba70..ec987ab 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c @@ -190,6 +1

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

2016-11-29 Thread Roger Quadros
Hi, On 29/11/16 13:51, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> DCFG.DEVSPD == 0x3 is not valid and we need to set >> DCFG.DEVSPD to 0x1 for full speed mode. > > seems like it has been made invalid somewhere between 1.73a and > 2.60a. Can you

[PATCH 2/2] usb: dwc3: gadget: Clean up DCFG/DSTS FULLSPEED macro

2016-11-29 Thread Roger Quadros
DCFG/DSTS.FULLSPEED can be either 0x1 or 0x3. Let's call 0x1 as DCFG/DSTS_FULLSPEED1 and 0x3 as DCFG/DSTS_FULLSPEED3. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 8 drivers/usb/dwc3/gadget.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --

[PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

2016-11-29 Thread Roger Quadros
DCFG.DEVSPD == 0x3 is not valid and we need to set DCFG.DEVSPD to 0x1 for full speed mode. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 1dfa56a5f

[PATCH 0/2] usb: dwc3: fix full speed gadget mode configuration

2016-11-29 Thread Roger Quadros
Hi, Although full speed gadget mode isn't really broken on my boards, we are not strictly following the dwc3 manual with regards to the DCFG.DEVSPD configuration. This series fixes that. cheers, -roger Roger Quadros (2): usb: dwc3: gadget: Fix full speed mode usb: dwc3: gadget: Cle

Re: [PATCH v7 9/9] ARM: dts: omap3: Fix NAND device nodess

2016-11-24 Thread Roger Quadros
Hi Adam On 24/11/16 00:34, Adam Ford wrote: > > On Tue, Feb 23, 2016 at 10:37 AM, Roger Quadros <mailto:rog...@ti.com>> wrote: > > Add compatible id, GPMC register resource and interrupt > resource to NAND controller nodes. > > The GPMC node will p

[PATCH v3 1/3] usb: xhci: add quirk flag for broken PED bits

2016-11-21 Thread Roger Quadros
HCI Port Disable Feature Does Not Work Signed-off-by: Felipe Balbi Signed-off-by: Roger Quadros --- drivers/usb/host/xhci-hub.c | 6 ++ drivers/usb/host/xhci.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index 0ef1

Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

2016-11-21 Thread Roger Quadros
On 21/11/16 13:56, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h >> index f945380..6553903 100644 >> --- a/drivers/usb/host/xhci.h >> +++ b/drivers/usb/host/xhci.h >> @@ -1656,

Re: [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits

2016-11-21 Thread Roger Quadros
On 18/11/16 12:49, Sergei Shtylyov wrote: > Hello. > > On 11/17/2016 6:01 PM, Roger Quadros wrote: > >> From: Felipe Balbi >> >> Some devices from Texas Instruments [1] suffer from >> a silicon bug where Port Enabled/Disabled bit >> should not be used

[PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

2016-11-21 Thread Roger Quadros
HCI Port Disable Feature Does Not Work Signed-off-by: Felipe Balbi Signed-off-by: Roger Quadros --- drivers/usb/host/xhci-hub.c | 6 ++ drivers/usb/host/xhci.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index 0ef1

[PATCH 0/3] usb: xhci: Add broken port disable quirk

2016-11-19 Thread Roger Quadros
Hi, Some XHCI controllers e.g. dwc3 based have a broken Port disable [1]. If the attached high-speed device is misbehaving, the USB stack typically disables the port using the PED bit in PORTSC. For the controllers that have broken port disable, the port fails to detect further attach/detach even

[PATCH 3/3] usb: dwc3: host: pass quirk-broken-port-ped property for known broken revisions

2016-11-17 Thread Roger Quadros
d-off-by: Felipe Balbi Signed-off-by: Roger Quadros --- drivers/usb/dwc3/host.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c index f6533c6..626d87d 100644 --- a/drivers/usb/dwc3/host.c +++ b/drivers/usb/dwc

[PATCH 1/3] usb: xhci: add quirk flag for broken PED bits

2016-11-17 Thread Roger Quadros
HCI Port Disable Feature Does Not Work Signed-off-by: Felipe Balbi Signed-off-by: Roger Quadros --- drivers/usb/host/xhci-hub.c | 6 ++ drivers/usb/host/xhci.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index 0ef1

[PATCH 2/3] usb: host: xhci-plat: enable BROKEN_PED quirk if platform requested

2016-11-17 Thread Roger Quadros
Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + drivers/usb/host/xhci-plat.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci

[PATCH] net: phy: dp83848: add dp83822 PHY support

2016-10-28 Thread Roger Quadros
This PHY has a compatible register set with DP83848x so add support for it. Acked-by: Andrew F. Davis Signed-off-by: Roger Quadros --- drivers/net/phy/dp83848.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c index 03d54c4..800b39f

Re: [PATCH] extcon: usb-gpio: Add VBUS detection support

2016-10-07 Thread Roger Quadros
Hi Chanwoo, On 27/09/16 08:48, Peter Chen wrote: > On Tue, Sep 20, 2016 at 05:53:55PM +0300, Roger Quadros wrote: >> Driver can now work with both ID and VBUS pins or either one of >> them. >> >> There can be the following 3 cases >> >> 1) Both ID and V

Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

2016-09-28 Thread Roger Quadros
Hi, On 12/09/16 14:38, Roger Quadros wrote: > Hi Santosh & Russell, > > On 19/08/16 19:38, Santosh Shilimkar wrote: >> >> On 8/19/2016 12:30 AM, Roger Quadros wrote: >>> Hi Santosh, >>> >> >>>>> So I'm 99.9% convinced that

[PATCH] extcon: usb-gpio: Add VBUS detection support

2016-09-20 Thread Roger Quadros
= LOW -> USB_HOST active, USB inactive ID = HIGH -> USB_HOST inactive, USB active 3) Only VBUS GPIO is available: VBUS = LOW -> USB_HOST inactive, USB inactive VBUS = HIGH -> USB_HOST inactive, USB active Signed-off-by: Roger Quadros --- .../devicetree/bindings/extcon/extcon-usb-gpio.tx

[PATCH v4] usb: core: setup dma_pfn_offset for USB devices and, interfaces

2016-09-13 Thread Roger Quadros
x_pfn() = dma_mask_pfn + dma_pfn_offset Signed-off-by: Roger Quadros --- Changelog: v4: - added comment in the code as to why we need to set dma_mask and dma_pfn_offset for usb devices. v3: - removed comments from code as commit log is sufficient. v2: - added more information in commit log and code. dr

[PATCH v3] usb: core: setup dma_pfn_offset for USB devices and, interfaces

2016-09-12 Thread Roger Quadros
x_pfn() = dma_mask_pfn + dma_pfn_offset Signed-off-by: Roger Quadros --- Changelog: v3: - removed comments from code as commit log is sufficient. v2: - added more information in commit log and code. drivers/usb/core/message.c | 1 + drivers/usb/core/usb.c | 1 + 2 files changed, 2 insertions(+)

Re: [PATCH v2] usb: core: setup dma_pfn_offset for USB devices and, interfaces

2016-09-12 Thread Roger Quadros
Hi Alan, On 12/09/16 16:09, Alan Stern wrote: > On Mon, 12 Sep 2016, Roger Quadros wrote: > >> If dma_pfn_offset is not inherited correctly from the host controller, >> it might result in sub-optimal configuration as bounce >> buffer limit might be set to less than optim

Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

2016-09-12 Thread Roger Quadros
Hi Santosh & Russell, On 19/08/16 19:38, Santosh Shilimkar wrote: > > On 8/19/2016 12:30 AM, Roger Quadros wrote: >> Hi Santosh, >> > >>>> So I'm 99.9% convinced that the proposed change is correct. >>>> >>> I will got with that the

Re: [PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration

2016-09-12 Thread Roger Quadros
8-rc1 because USB_HPY config option got dropped. >> >> >> On 8/17/2016 3:44 AM, Roger Quadros wrote: >>> Simply enabling CONFIG_KEYSTONE_USB_PHY doesn't work anymore >>> as it depends on CONFIG_NOP_USB_XCEIV. We need to enable >>> that as well. >

[PATCH v2] usb: core: setup dma_pfn_offset for USB devices and, interfaces

2016-09-12 Thread Roger Quadros
x_pfn() = dma_mask_pfn + dma_pfn_offset Signed-off-by: Roger Quadros --- drivers/usb/core/message.c | 6 ++ drivers/usb/core/usb.c | 7 +++ 2 files changed, 13 insertions(+) diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index 0406a59..66364ea 100644 --- a/drivers/usb

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-07 Thread Roger Quadros
On 07/09/16 11:29, Arnd Bergmann wrote: > On Wednesday, September 7, 2016 10:17:31 AM CEST Roger Quadros wrote: >>> >>> Speaking of that flag, I suppose we need the same logic to know where >>> to look for USB devices attached to a dwc3 host when we need to describe

Re: [PATCH] usb: phy: generic: request regulator optionally

2016-09-07 Thread Roger Quadros
Hi Stefan, On 06/09/16 21:01, Stefan Agner wrote: > On 2016-09-06 01:22, Mark Brown wrote: >> On Tue, Sep 06, 2016 at 10:45:19AM +0300, Felipe Balbi wrote: >>> Stefan Agner writes: >> According to the device tree bindings the vcc-supply is optional. >> >> This is nonsense unless the device c

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-07 Thread Roger Quadros
Hi Arnd, On 02/09/16 18:51, Arnd Bergmann wrote: > On Friday, September 2, 2016 10:21:23 AM CEST Alan Stern wrote: >> On Fri, 2 Sep 2016, Felipe Balbi wrote: >> >>> Hi, >>> >>> Russell King - ARM Linux writes: On Fri, Sep 02, 2016 at 12:43:39PM +0200, Arnd Bergmann wrote: > On Thursday,

Re: [PATCH] fix:memory:omap-gpmc:mark symbols static where possible

2016-08-29 Thread Roger Quadros
Hi, On 28/08/16 08:28, Baoyou Xie wrote: > We get 1 warning when build kernel with W=1: > drivers/memory/omap-gpmc.c:354:14: warning: no previous prototype for > 'gpmc_clk_ticks_to_ns' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't

[PATCH] mtd: nand: Allow MTD_NAND_OMAP2 to be usable on Keystone devices

2016-08-24 Thread Roger Quadros
Some Keystone devices (e.g. K2G) include a OMAP NAND IP. Allow the NAND driver to be usable for both Keystone and OMAP devices. Signed-off-by: Roger Quadros --- drivers/mtd/nand/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/Kconfig b

[PATCH] memory: omap-gpmc: Fix build with CONFIG_OMAP_GPMC disabled

2016-08-24 Thread Roger Quadros
Fix the following build failure if omap-gpmc.h is used with CONFIG_OMAP_GPMC disabled. ./include/linux/omap-gpmc.h:32:1: error: unknown type name ‘gpmc_nand_ops’ Signed-off-by: Roger Quadros --- include/linux/omap-gpmc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH] dt-bindings: GPIO: Add TPIC2810 binding

2016-08-23 Thread Roger Quadros
From: "Andrew F. Davis" Add binding for TPIC2810 GPO device. Signed-off-by: Andrew F. Davis Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt | 16 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetre

[PATCH 3/3] ARM: dts: dra7: workaround silicon limitation i845

2016-08-23 Thread Roger Quadros
t for USB1 PHY. The workaround is already in place for USB2 PHY. Signed-off-by: Sekhar Nori Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index d9bfb9

[PATCH 0/3] phy: omap-usb2: Fixes for v4.9

2016-08-23 Thread Roger Quadros
Hi Kishon & Tony, Here are some fixes found in the TI vendor tree for omap-usb2 PHY and are important for upstream. Please queue for -next if OK. Thanks. The 3rd patch should probably go via Tony's SoC DT tree. cheers, -roger Sekhar Nori (3): phy: omap-usb2: support suspend/resume dt-bindin

[PATCH 2/3] dt-bindings: phy: ti: add documentation for ti,dra7x-usb2

2016-08-23 Thread Roger Quadros
From: Sekhar Nori Commit 7e472402ca30 ("phy: omap-usb2: Provide workaround for USB2PHY false disconnect") added a new binding for USB2 PHYs on DRA7x. But it has remained undocumented so far. Add documentation for the binding. Signed-off-by: Sekhar Nori Signed-off-by: Rog

[PATCH 1/3] phy: omap-usb2: support suspend/resume

2016-08-23 Thread Roger Quadros
ons. Signed-off-by: Sekhar Nori Signed-off-by: Roger Quadros --- drivers/phy/phy-omap-usb2.c | 100 1 file changed, 46 insertions(+), 54 deletions(-) diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c index c134989..fe909fd 1006

Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

2016-08-19 Thread Roger Quadros
: >>>> On Wed, Aug 17, 2016 at 03:05:17PM +0300, Roger Quadros wrote: >>>>> Since commit 6ce0d2001692 ("ARM: dma: Use dma_pfn_offset for dma address >>>>> translation"), >>>>> dma_to_pfn() already returns the PFN with the physical memo

[PATCH] usb: core: setup dma_pfn_offset for USB devices

2016-08-17 Thread Roger Quadros
() = dma_mask_pfn + dma_pfn_offset Signed-off-by: Roger Quadros --- drivers/usb/core/message.c | 1 + drivers/usb/core/usb.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index 0406a59..6856b7a 100644 --- a/drivers/usb/core/message.c +++ b

[PATCH 1/1] ARM: dma: fix dma_max_pfn()

2016-08-17 Thread Roger Quadros
j Reported-by: Grygorii Strashko Signed-off-by: Roger Quadros --- arch/arm/include/asm/dma-mapping.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h index d009f79..bf02dbd 100644 --- a/arch/arm/include/asm

[PATCH 0/1] ARM: Keystone: Fix USB Mass storage on K2E

2016-08-17 Thread Roger Quadros
e lock-up. This is explained further in the patch. cheers, -roger Roger Quadros (1): ARM: dma: fix dma_max_pfn() arch/arm/include/asm/dma-mapping.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4

[PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration

2016-08-17 Thread Roger Quadros
Simply enabling CONFIG_KEYSTONE_USB_PHY doesn't work anymore as it depends on CONFIG_NOP_USB_XCEIV. We need to enable that as well. This fixes USB on Keystone boards from v4.8-rc1 onwards. Signed-off-by: Roger Quadros --- arch/arm/configs/keystone_defconfig | 1 + 1 file changed, 1 inse

[PATCH 0/1] ARM: Keystone: Fix USB on v4.8-rc

2016-08-17 Thread Roger Quadros
Hi Santosh, USB ports are broken on Keystone2 boards since v4.8-rc1. This is because CONFIG_KEYSTONE_USB_PHY is no longer being enabled by keystone_defconfig. Fix that. Please pick this for the v4.8-rc cycle. Thanks. cheers, -roger Roger Quadros (1): ARM: keystone: defconfig: Fix USB

Re: [PATCH] extcon: Use the extcon_set_state_sync() instead of deprecated functions

2016-08-16 Thread Roger Quadros
naming pattern. > - extcon_set_cable_state_() -> extcon_set_state_sync() > - extcon_get_cable_state_() -> extcon_get_state() > > [1] https://lkml.org/lkml/2016/8/4/729 > - extcon: Rename the extcon_set/get_state() to maintain the function naming > pattern > > Cc: Krzysztof Kozlowski &g

[PATCH] mtd: nand: omap2: Don't call dma_release_channel() if dma_request_chan() failed

2016-08-15 Thread Roger Quadros
. Fixes: de3bfc4a1616: ("mtd: nand: omap2: fix return value check in omap_nand_probe()") Reported-by: Dan Carpenter Signed-off-by: Roger Quadros --- drivers/mtd/nand/omap2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/oma

Re: [PATCH v3 2/6] extcon: Add the support for extcon property according to extcon type

2016-08-04 Thread Roger Quadros
On 04/08/16 07:09, Guenter Roeck wrote: > On Wed, Aug 3, 2016 at 5:42 PM, Chanwoo Choi wrote: >> Hi Roger, >> >> On 2016년 08월 03일 18:46, Roger Quadros wrote: >>> Hi Chanwoo, >>> > > [ ... ] > >>>>>> + /* >>>>>&

Re: [PATCH v3 2/6] extcon: Add the support for extcon property according to extcon type

2016-08-03 Thread Roger Quadros
Hi Chanwoo, On 02/08/16 11:08, Chanwoo Choi wrote: > Hi, > > On 2016년 08월 02일 16:43, Roger Quadros wrote: >> +Felipe >> >> Hi, >> >> On 02/08/16 04:58, Chanwoo Choi wrote: >>> This patch support the extcon property for the external connector &g

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

2016-08-03 Thread Roger Quadros
On 03/08/16 11:01, Johan Hovold wrote: > On Wed, Aug 03, 2016 at 10:46:24AM +0300, Roger Quadros wrote: >> On 02/08/16 13:35, Tony Lindgren wrote: >>> * Johan Hovold [160724 05:11]: >>>> Networking is currently broken for Overo boards due to a regression in &

Re: [PATCH 0/3] ARM: omap: fix 4.7 gpmc networking regression

2016-08-03 Thread Roger Quadros
On 02/08/16 13:35, Tony Lindgren wrote: > * Johan Hovold [160724 05:11]: >> Networking is currently broken for Overo boards due to a regression in >> 4.7. I bisected it down to >> >> d2d00862dfbb ("memory: omap-gpmc: Support general purpose input >> for WAITPINs") > ... > >> Note that s

Re: [PATCH v3 3/6] extcon: Add the support for the capability of each property

2016-08-02 Thread Roger Quadros
Hi, On 02/08/16 04:58, Chanwoo Choi wrote: > This patch adds the support of the property capability setting. This function > decides the supported properties of each external connector on extcon provider > driver. > > Ths list of new extcon APIs to get/set the capability of property as > followi

Re: [PATCH v3 1/6] extcon: Add the extcon_type to gather each connector into five category

2016-08-02 Thread Roger Quadros
Hi, On 02/08/16 04:58, Chanwoo Choi wrote: > This patch adds the new extcon type to group the each connecotr > into following five category. This type would be used to handle > the connectors as a group unit instead of a connector unit. > - EXTCON_TYPE_USB : USB connector > - EXTCON_TYPE_CHG : C

Re: [PATCH v3 2/6] extcon: Add the support for extcon property according to extcon type

2016-08-02 Thread Roger Quadros
+Felipe Hi, On 02/08/16 04:58, Chanwoo Choi wrote: > This patch support the extcon property for the external connector > because each external connector might have the property according to > the H/W design and the specific characteristics. > > - EXTCON_PROP_USB_[property name] > - EXTCON_PROP_C

Re: [RFC v4 0/7] extcon: usb-gpio: fixes and improvements

2016-08-01 Thread Roger Quadros
Hi, On 09/06/16 12:32, Chanwoo Choi wrote: > Hi, > > On 2016년 06월 09일 17:39, Krzysztof Kozlowski wrote: >> >> Hi, >> >> >> On 06/09/2016 10:35 AM, Chanwoo Choi wrote: >>> Hi, >>> >>> It is good to support USB_ID and USB_VBUS by extcon. >>> >>> But, >>> there is some issue about adding the new cab

Re: [PATCH] memory: omap-gpmc: Delete an unnecessary check before the function call "gpiochip_free_own_desc"

2016-08-01 Thread Roger Quadros
Hi Markus, On 23/07/16 20:09, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 23 Jul 2016 18:54:02 +0200 > > The gpiochip_free_own_desc() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was dete

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Roger Quadros
On 01/07/16 12:41, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>>>>>>> NOP_USB_XCEIV is used not only by gadget drivers but by >>>>>>>> host drivers as well e.g. EHCI_OMAP. >>>>>>>> >>

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Roger Quadros
On 01/07/16 11:15, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>>>>> NOP_USB_XCEIV is used not only by gadget drivers but by >>>>>> host drivers as well e.g. EHCI_OMAP. >>>>>> >>>>>> commit 5a8d651a2

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-07-01 Thread Roger Quadros
On 01/07/16 10:57, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>>> NOP_USB_XCEIV is used not only by gadget drivers but by >>>> host drivers as well e.g. EHCI_OMAP. >>>> >>>> commit 5a8d651a2bde ("usb: gadget: move gadg

Re: [PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-06-30 Thread Roger Quadros
Hi Felipe, On 30/06/16 13:14, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> NOP_USB_XCEIV is used not only by gadget drivers but by >> host drivers as well e.g. EHCI_OMAP. >> >> commit 5a8d651a2bde ("usb: gadget: move gadget API f

[PATCH] usb: host: Allow EHCI_OMAP to be built-in when USB_GADGET is 'm'

2016-06-30 Thread Roger Quadros
s: 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") Signed-off-by: Roger Quadros --- drivers/usb/gadget/udc/core.c | 60 --- drivers/usb/host/Kconfig | 2 +- drivers/usb/phy/Kconfig | 5 ++-- include/linux/usb/gadget

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-28 Thread Roger Quadros
On 29/06/16 01:01, Stephen Boyd wrote: > Quoting Roger Quadros (2016-06-28 02:13:57) >> On 28/06/16 11:47, Stephen Boyd wrote: >>> >>> Sorry I must have confused you. There are two modules in the PMIC that >>> are doing detection here. The charger module is d

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-28 Thread Roger Quadros
On 28/06/16 11:47, Stephen Boyd wrote: > Quoting Roger Quadros (2016-06-27 23:36:26) >> On 27/06/16 22:30, Stephen Boyd wrote: >>> >>> The VBUS notification is done through another piece of hardware. In this >>> case it's done by the charger module. I&#x

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-27 Thread Roger Quadros
On 27/06/16 22:30, Stephen Boyd wrote: > Quoting Roger Quadros (2016-06-27 00:39:51) >> Hi Stephen, >> >> On 26/06/16 08:56, Stephen Boyd wrote: >>> Some Qualcomm PMICs have a misc device that performs USB id pin >>> detection via an interrupt. When the int

Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

2016-06-27 Thread Roger Quadros
he ID pin is grounded, and if the > interrupt is high then the ID pin is being held high. Does this depend on any other drivers to configure the USB ID interrupt or it works automatically once the interrupt is enabled? > > Cc: Roger Quadros > Cc: Chanwoo Choi > Signed-off-by: Stephen

Re: [PATCHv3 1/2] usb: USB Type-C connector class

2016-06-23 Thread Roger Quadros
Hi, On 23/06/16 15:00, Heikki Krogerus wrote: > Hi Oliver, > > On Thu, Jun 23, 2016 at 10:38:58AM +0200, Oliver Neukum wrote: >> On Thu, 2016-06-23 at 11:23 +0300, Heikki Krogerus wrote: >>> On Wed, Jun 22, 2016 at 06:44:18PM +0200, Oliver Neukum wrote: >> >>> No it's not. DRP means a port that c

Re: [PATCHv3 1/2] usb: USB Type-C connector class

2016-06-23 Thread Roger Quadros
Hi Heikki, On 21/06/16 17:51, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when USB PD is s/PD/PD (P

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-22 Thread Roger Quadros
On 22/06/16 11:14, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>>>>>>>>> For the real use case, some Carplay platforms need it. >>>>>>>>> >>>>>>>>> Carplay does *NOT* rely on OTG. Apple

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-22 Thread Roger Quadros
Hi Felipe, On 22/06/16 09:56, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: >>> Peter Chen writes: >>> So far, I haven't seen anybody talking about real USB OTG (the spec) >>> when they say OTG. Usually they just mean "a method for swapping between >>> host and peripheral role

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-20 Thread Roger Quadros
On 20/06/16 15:03, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: >>>> It provides APIs for the following tasks >>>> >>>> - Registering an OTG/dual-role capable controller >>>> - Registering H

<    2   3   4   5   6   7   8   9   10   11   >