[PATCH 1/1] Security : smack : Use kmem_cache for allocation and freeing of inode_smack

2014-10-14 Thread Rohit Kumar
From: Rohit rohit...@samsung.com Use kmem_cache to allocate/free inode_smack since they are alloced in high volumes making it a perfect case for kmem_cache. Accounting of memory allocation is below : total slacknet count-alloc/freecaller Before (with kzalloc)

[PATCH 1/1] staging: ion: Fix error handling in ion_buffer_create

2015-09-29 Thread Rohit kumar
This patch fixes error handling case when buffer->pages allocation fails. Also, it removes unreachable code of checking ret variable although it is not updated. Signed-off-by: Rohit kumar <rohit...@samsung.com> --- drivers/staging/android/ion/ion.c | 14 +- 1 file c

[PATCHv2 1/1] staging/ion: Add support to get ion handle from dma buf

2016-01-05 Thread Rohit kumar
. This patch exposes api to retrieve the ion handle from dma_buf for similar use cases. With this patch, we can integrate ION within DRM-GEM for buffer management and dma_buf sharing. Signed-off-by: Rohit kumar <rohit...@samsung.com> --- v2: Updated commit message with use case expla

[PATCH] staging/ion: Add support to get ion handle from dma buf

2016-01-05 Thread Rohit kumar
Currently we can only import dma buf fd's to get ion_handle. Adding support to import dma buf handles to support kernel specific use cases. Signed-off-by: Rohit kumar <rohit...@samsung.com> --- Currently, ION is the memory manager for graphics in android. However, in other linux pla

[PATCH] remoteproc: Add APSS based Qualcomm ADSP PIL driver for SDM845

2018-05-13 Thread Rohit kumar
This adds Qualcomm ADSP PIL driver support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor SubSystem(APSS). Signed-off-by: Rohit kumar <rohi...@codeaurora.org> Signed-off-by: RajendraBabu Medisetti <rajendr...@codeaurora.org> Signed-off-by: Krishn

Re: [PATCH] remoteproc: Add APSS based Qualcomm ADSP PIL driver for SDM845

2018-05-23 Thread Rohit Kumar
Thanks Bjorn for reviewing. On 5/23/2018 11:56 AM, Bjorn Andersson wrote: On Sun 13 May 00:01 PDT 2018, Rohit kumar wrote: --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt @@ -10,6 +10,7 @@ on the Qualcomm ADSP

[PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-18 Thread Rohit kumar
This patch adds sdm845 audio machine driver support. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,sdm845.txt | 87 sound/soc/qcom/Kconfig | 9 + sound/soc/qcom/Makefile| 2 + sound/soc/qcom/sdm845.c

Re: [RFC PATCH 3/5] remoteproc: qcom: adsp: Use common q6v5 helpers

2018-06-01 Thread Rohit Kumar
disabling of proxy resources. But apart from this there should be no change in functionality. Signed-off-by: Bjorn Andersson Reviewed-and-tested-by: Rohit kumar --- drivers/remoteproc/Kconfig | 1 + drivers/remoteproc/qcom_adsp_pil.c | 156 + 2 files changed

Re: [RFC PATCH 0/5] Hexagon remoteproc spring cleaning

2018-06-01 Thread Rohit Kumar
Thanks Bjorn for the cleanup. I validated PAS and Non- PAS ADSP PIL with the cleanup changes on SDM845. Adding tag for ADSP PIL. Reviewed-and-tested-by: Rohit kumar On 5/23/2018 10:50 AM, Bjorn Andersson wrote: With the introduction of support for the non-MSA Hexagon WCSS driver from

[PATCH] ASoC: qcom: apq8096: set card as device drvdata

2018-06-06 Thread Rohit kumar
snd_soc_card is retrieved as device drvdata during unbind(). Set it as drvdata during bind() to avoid memory corruption during unbind(). Signed-off-by: Rohit kumar --- sound/soc/qcom/apq8096.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-19 Thread Rohit Kumar
Thanks Srinivas for reviewing. On 6/19/2018 2:16 PM, Srinivas Kandagatla wrote: Thanks Rohit for the patch! On 18/06/18 12:16, Rohit kumar wrote: This patch adds sdm845 audio machine driver support. Signed-off-by: Rohit kumar ---   .../devicetree/bindings/sound/qcom,sdm845.txt  |  87

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-19 Thread Rohit Kumar
Thanks Vinod for reviewing. On 6/19/2018 10:35 AM, Vinod wrote: On 18-06-18, 16:46, Rohit kumar wrote: +struct sdm845_snd_data { + struct snd_soc_card *card; + struct regulator *vdd_supply; + struct snd_soc_dai_link dai_link[]; +}; + +static struct mutex pri_mi2s_res_lock

Re: [alsa-devel] [PATCH v7 16/24] ASoC: qdsp6: q6asm: Add support to audio stream apis

2018-05-04 Thread Rohit Kumar
On 5/1/2018 5:38 PM, Srinivas Kandagatla wrote: +static int __q6asm_run(struct audio_client *ac, uint32_t flags, + uint32_t msw_ts, uint32_t lsw_ts, bool wait) +{ + struct asm_session_cmd_run_v2 *run; + struct apr_pkt *pkt; + int pkt_size, rc; + void *p; + +

Re: [alsa-devel] [RESEND PATCH v2 12/15] ASoC: qcom: qdsp6: Add support to q6asm dai driver

2018-01-13 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6asm dai driver which configures Q6ASM streams to pass pcm data. Currently the driver only exposes 2 playback streams for hdmi playback support,

Re: [alsa-devel] [RESEND PATCH v2 08/15] ASoC: qcom: q6asm: add support to audio stream apis

2018-01-13 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to open, write and media format commands in the q6asm module. [..] +static int32_t q6asm_callback(struct apr_device *adev, +

Re: [alsa-devel] [RESEND PATCH v2 11/15] ASoC: qcom: qdsp6: Add support to q6afe dai driver

2018-02-07 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6afe backend dais driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 5 +

Re: [alsa-devel] [RESEND PATCH v2 09/15] ASoC: qcom: qdsp6: Add support to Q6CORE

2018-02-07 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to core apr service, which is used to query status of other static and dynamic services on the dsp. Signed-off-by: Srinivas Kandagatla

Re: [alsa-devel] [PATCH v3 24/25] ASoC: qcom: apq8096: Add db820c machine driver

2018-02-22 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to DB820c machine driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 8 +++

Re: [alsa-devel] [PATCH v3 12/25] ASoC: qcom: qdsp6: Add support to Q6CORE

2018-02-19 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to core apr service, which is used to query status of other static and dynamic services on the dsp. Signed-off-by: Srinivas Kandagatla

Re: [alsa-devel] [PATCH v3 14/25] ASoC: qcom: qdsp6: Add support to q6afe dai driver

2018-02-19 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6afe backend dais driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/Makefile| 2 +-

Re: [alsa-devel] [PATCH v3 05/25] ASoC: qcom: qdsp6: Add support to Q6AFE

2018-02-19 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to Q6AFE (Audio Front End) module on Q6DSP. AFE module sits right at the other end of cpu where the codec/audio devices are connected. AFE provides

Re: [alsa-devel] [PATCH v3 15/25] ASoC: qcom: qdsp6: Add support to q6asm dai driver

2018-02-21 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6asm dai driver which configures Q6ASM streams to pass pcm data. Signed-off-by: Srinivas Kandagatla [..] diff

[PATCH v2 1/2] ASoC: qcom: dt-bindings: Add sdm845 machine bindings

2018-06-21 Thread Rohit kumar
Add devicetree bindings documentation file for SDM845 sound card. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,sdm845.txt | 82 ++ 1 file changed, 82 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sdm845.txt diff

[PATCH v2 0/2] Add support for audio on SDM845 SoC

2018-06-21 Thread Rohit kumar
This provides initial patchset to support audio on Qualcomm Techonologies Inc. SDM845 SoC. Currently, it supports audio playback/capture over Primary MI2S and Quaternary TDM ports. Changes since v1: Addressed comments posted by Vinod and Srinivas. Rohit kumar (2): ASoC: qcom: dt-bindings: Add

[PATCH v2 2/2] ASoC: qcom: add sdm845 sound card support

2018-06-21 Thread Rohit kumar
This patch adds sdm845 audio machine driver support. Signed-off-by: Rohit kumar --- sound/soc/qcom/Kconfig | 9 + sound/soc/qcom/Makefile | 2 + sound/soc/qcom/sdm845.c | 514 3 files changed, 525 insertions(+) create mode 100644 sound/soc

Re: [alsa-devel] [PATCH v2 2/2] ASoC: qcom: add sdm845 sound card support

2018-06-22 Thread Rohit Kumar
On 6/21/2018 8:39 PM, Srinivas Kandagatla wrote: On 21/06/18 13:35, Vinod wrote: And this one is generic DT parsing and seems quite similar to one in apq8096.c Can we move these into a lib and use them instead of duplicating. I totally agree with Vinod, We should probably come up with a

Re: [PATCH v2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-08-03 Thread Rohit Kumar
Hello Bjorn, Can you please let us know the suggest the file name and review the patch. On 7/9/2018 11:29 AM, Rohit Kumar wrote: Thanks Rob for reviewing. On 7/7/2018 2:02 AM, Rob Herring wrote: On Fri, Jun 29, 2018 at 02:50:53PM +0530, Rohit kumar wrote: This adds APSS based ADSP PIL

Re: [PATCH v4 4/4] ASoC: qcom: add sdm845 sound card support

2018-08-01 Thread Rohit Kumar
patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rohit-kumar/Add-support-for-audio-on-SDM845-SoC/20180801-082203 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next reproduce

[PATCH v5 1/4] ASoC: qcom: dt-bindings: Add sdm845 machine bindings

2018-08-01 Thread Rohit kumar
Add devicetree bindings documentation file for SDM845 sound card. Reviewed-by: Rob Herring Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,sdm845.txt | 80 ++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound

[PATCH v5 0/4] Add support for audio on SDM845 SoC

2018-08-01 Thread Rohit kumar
This provides initial patchset to support audio on Qualcomm Techonologies Inc. SDM845 SoC. Currently, it supports audio playback/capture over Primary MI2S and Quaternary TDM ports. Changes since v4: - Used snd_mask_set_format() instead of snd_mask_set() to avoid sparse warning. Rohit kumar (4

[PATCH v5 3/4] ASoC: qcom: Add support to parse common audio device nodes

2018-08-01 Thread Rohit kumar
This adds support to parse cpu, platform and codec device nodes and add them in dai-links. Also, update apq8096 machine driver to use the common API. Acked-by: Srinivas Kandagatla Signed-off-by: Rohit kumar --- sound/soc/qcom/Makefile | 2 +- sound/soc/qcom/apq8096.c | 111

[PATCH v5 2/4] ASoC: dt-bindings: Update dt binding name for apq8096

2018-08-01 Thread Rohit kumar
Remove qcom prefix from machine driver dt bindings of apq8096 SoC. Acked-by: Srinivas Kandagatla Reviewed-by: Rob Herring Signed-off-by: Rohit kumar --- Documentation/devicetree/bindings/sound/qcom,apq8096.txt | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git

[PATCH v5 4/4] ASoC: qcom: add sdm845 sound card support

2018-08-01 Thread Rohit kumar
This patch adds sdm845 audio machine driver support. Acked-by: Srinivas Kandagatla Signed-off-by: Rohit kumar --- sound/soc/qcom/Kconfig | 8 ++ sound/soc/qcom/Makefile | 2 + sound/soc/qcom/sdm845.c | 286 3 files changed, 296 insertions

[PATCH] ASoC: qcom: Fix unmet dependency warning for SND_SOC_SDM845

2018-08-02 Thread Rohit kumar
Add DEPENDS_ON QCOM_APR for SND_SOC_SDM845 to fix the warning: unmet direct dependencies detected for SND_SOC_QDSP6. Reported-by: Stephen Rothwell Signed-off-by: Rohit kumar --- sound/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom

[PATCH v4 3/4] ASoC: qcom: Add support to parse common audio device nodes

2018-07-30 Thread Rohit kumar
This adds support to parse cpu, platform and codec device nodes and add them in dai-links. Also, update apq8096 machine driver to use the common API. Acked-by: Srinivas Kandagatla Signed-off-by: Rohit kumar --- sound/soc/qcom/Makefile | 2 +- sound/soc/qcom/apq8096.c | 111

[PATCH v4 4/4] ASoC: qcom: add sdm845 sound card support

2018-07-30 Thread Rohit kumar
This patch adds sdm845 audio machine driver support. Acked-by: Srinivas Kandagatla Signed-off-by: Rohit kumar --- sound/soc/qcom/Kconfig | 8 ++ sound/soc/qcom/Makefile | 2 + sound/soc/qcom/sdm845.c | 286 3 files changed, 296 insertions

[PATCH v4 2/4] ASoC: dt-bindings: Update dt binding name for apq8096

2018-07-30 Thread Rohit kumar
Remove qcom prefix from machine driver dt bindings of apq8096 SoC. Acked-by: Srinivas Kandagatla Signed-off-by: Rohit kumar --- Documentation/devicetree/bindings/sound/qcom,apq8096.txt | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree

[PATCH v4 0/4] Add support for audio on SDM845 SoC

2018-07-30 Thread Rohit kumar
- Addressed comments by Srinivas, Mark and Vinod. Rohit kumar (4): ASoC: qcom: dt-bindings: Add sdm845 machine bindings ASoC: dt-bindings: Update dt binding name for apq8096 ASoC: qcom: Add support to parse common audio device nodes ASoC: qcom: add sdm845 sound card support .../devicetree

[PATCH v4 1/4] ASoC: qcom: dt-bindings: Add sdm845 machine bindings

2018-07-30 Thread Rohit kumar
Add devicetree bindings documentation file for SDM845 sound card. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,sdm845.txt | 80 ++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sdm845.txt diff

[PATCH] ASoC: Fix UBSAN warning at snd_soc_get/put_volsw_sx()

2018-09-10 Thread Rohit kumar
[] __ubsan_handle_sub_overflow+0x34/0x44 lib/ubsan.c:211 [] snd_soc_get_volsw_sx+0x1a8/0x1f8 sound/soc/soc-ops.c:382 Typecast the operation to unsigned int to fix the issue. Signed-off-by: Rohit kumar --- sound/soc/soc-ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-ops.c

Re: [PATCH v3 1/2] dt-binding: remoteproc: Add QTI ADSP PIL bindings

2018-09-10 Thread Rohit Kumar
Thanks Rob for reviewing. On 9/11/2018 1:31 AM, Rob Herring wrote: On Mon, Sep 03, 2018 at 05:22:39PM +0530, Rohit kumar wrote: Add devicetree bindings documentation file for Qualcomm Technolgies Inc ADSP Peripheral Image Loader. Signed-off-by: Rohit kumar --- .../bindings/remoteproc/qcom

Re: [PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-09-10 Thread Rohit Kumar
Thanks Bjorn for reviewing. On 9/11/2018 12:01 AM, Bjorn Andersson wrote: On Mon 03 Sep 04:52 PDT 2018, Rohit kumar wrote: This adds Non PAS ADSP PIL driver for Qualcomm Technologies Inc SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application

[PATCH v4] dt-binding: remoteproc: Add QTI ADSP PIL bindings

2018-09-10 Thread Rohit kumar
Add devicetree bindings documentation file for Qualcomm Technolgies Inc ADSP Peripheral Image Loader. Signed-off-by: Rohit kumar --- Changes since v3: Addressed comments given by Rob .../bindings/remoteproc/qcom,adsp-pil.txt | 126 + 1 file changed, 126 insertions

Re: [alsa-devel] [PATCH] ASoC: Fix UBSAN warning at snd_soc_get/put_volsw_sx()

2018-09-11 Thread Rohit Kumar
Thanks Takashi for reviewing. On 9/10/2018 11:56 PM, Takashi Iwai wrote: On Mon, 10 Sep 2018 19:33:56 +0200, Rohit kumar wrote: In functions snd_soc_get_volsw_sx() or snd_soc_put_volsw_sx(), if the result of (min + max) is negative, then fls() returns signed integer with value as 32

[PATCH v2] ASoC: Fix UBSAN warning at snd_soc_get/put_volsw_sx()

2018-09-11 Thread Rohit kumar
[] __ubsan_handle_sub_overflow+0x34/0x44 lib/ubsan.c:211 [] snd_soc_get_volsw_sx+0x1a8/0x1f8 sound/soc/soc-ops.c:382 Typecast the operation to unsigned int to fix the issue. Signed-off-by: Rohit kumar --- Changes since v1: Addressed comments given by Takashi. sound/soc/soc-ops.c | 4 ++-- 1 file changed, 2

[PATCH v3 0/5] Add support for audio on SDM845 SoC

2018-07-06 Thread Rohit kumar
driver. - Removed qcom prefix from device tree properties as suggested by Robb. - Updated apq8096 machine driver to use common APIs. Rohit kumar (5): ASoC: qcom: dt-bindings: Add sdm845 machine bindings ASoC: qcom: Add support to parse common audio device nodes ASoC: qcom: add sdm845 sound

[PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support

2018-07-06 Thread Rohit kumar
This patch adds sdm845 audio machine driver support. Signed-off-by: Rohit kumar --- sound/soc/qcom/Kconfig | 10 ++ sound/soc/qcom/Makefile | 2 + sound/soc/qcom/sdm845.c | 390 3 files changed, 402 insertions(+) create mode 100644 sound/soc

[PATCH v3 5/5] ASoC: qcom: apq8096: Use common APIs to parse device nodes

2018-07-06 Thread Rohit kumar
Use generic APIs exposed by common.c for parsing dai link device tree nodes and adding slave components. Signed-off-by: Rohit kumar --- sound/soc/qcom/Kconfig | 1 + sound/soc/qcom/apq8096.c | 151 --- 2 files changed, 11 insertions(+), 141

[PATCH v3 1/5] ASoC: qcom: dt-bindings: Add sdm845 machine bindings

2018-07-06 Thread Rohit kumar
Add devicetree bindings documentation file for SDM845 sound card. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,sdm845.txt | 80 ++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sdm845.txt diff

[PATCH v3 2/5] ASoC: qcom: Add support to parse common audio device nodes

2018-07-06 Thread Rohit kumar
This adds support to parse cpu, platform and codec device nodes and add them in dai-links. Also, add API to add slave components associated with machine driver. Signed-off-by: Rohit kumar --- sound/soc/qcom/Kconfig | 3 + sound/soc/qcom/Makefile | 1 + sound/soc/qcom/common.c | 150

[PATCH v3 4/5] ASoC: dt-bindings: Update dt binding name for apq8096

2018-07-06 Thread Rohit kumar
Remove qcom prefix from machine driver dt bindings of apq8096 SoC. Signed-off-by: Rohit kumar --- Documentation/devicetree/bindings/sound/qcom,apq8096.txt | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8096

Re: [alsa-devel] [PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support

2018-07-09 Thread Rohit Kumar
Thanks Vinod for reviewing. On 7/9/2018 1:18 PM, Vinod wrote: On 06-07-18, 15:13, Rohit kumar wrote: +static void sdm845_init_supplies(struct device *dev) +{ + struct snd_soc_card *card = dev_get_drvdata(dev); + struct sdm845_snd_data *data = snd_soc_card_get_drvdata(card

Re: [PATCH v2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-07-09 Thread Rohit Kumar
Thanks Rob for reviewing. On 7/7/2018 2:02 AM, Rob Herring wrote: On Fri, Jun 29, 2018 at 02:50:53PM +0530, Rohit kumar wrote: This adds APSS based ADSP PIL driver for QCOM SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor

Re: [alsa-devel] [PATCH v4 07/24] ASoC: qdsp6: q6afe: Add q6afe driver

2018-03-13 Thread Rohit Kumar
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to Q6AFE (Audio Front End) module on Q6DSP. [..] + if (res->status) { + dev_err(afe->dev, "cmd = 0x%x returned

Re: [alsa-devel] [PATCH v4 15/24] ASoC: qdsp6: q6core: Add q6core driver

2018-03-13 Thread Rohit Kumar
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla [..] +static int q6core_get_svc_versions(struct q6core *core) +{ + struct apr_device *adev = core->adev; + struct apr_hdr hdr = {0}; + int rc; + +

Re: [alsa-devel] [PATCH v3 19/25] ASoC: qcom: q6afe: add support to MI2S ports

2018-03-07 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla --- include/dt-bindings/sound/qcom,q6afe.h | 10 +++ sound/soc/qcom/qdsp6/q6afe.c | 111

Re: [alsa-devel] [PATCH v4 02/24] soc: qcom: Add APR bus driver

2018-03-14 Thread Rohit Kumar
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla [..] +struct bus_type aprbus_type = { + .name = "aprbus", + .match = apr_device_match, + .probe = apr_device_probe, +

Re: [alsa-devel] [PATCH v4 14/24] ASoC: qdsp6: q6asm: Add support to audio stream apis

2018-04-09 Thread Rohit Kumar
t; Reviewed-and-Tested-by: Rohit kumar <rohi...@codeaurora.org> --- sound/soc/qcom/qdsp6/q6asm.c | 744 ++- sound/soc/qcom/qdsp6/q6asm.h | 49 +++ 2 files changed, 792 insertions(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/

[PATCH v2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-06-29 Thread Rohit kumar
This adds APSS based ADSP PIL driver for QCOM SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor SubSystem(APSS). Signed-off-by: Rohit kumar --- Changes since v1: - Used APIs from qcom_q6v5.c - Use clock, reset and regmap driver APIs

Re: [alsa-devel] [PATCH v2 1/2] ASoC: qcom: dt-bindings: Add sdm845 machine bindings

2018-06-28 Thread Rohit Kumar
Thanks Rob for reviewing. On 6/26/2018 12:47 AM, Rob Herring wrote: On Thu, Jun 21, 2018 at 04:23:18PM +0530, Rohit kumar wrote: Add devicetree bindings documentation file for SDM845 sound card. Signed-off-by: Rohit kumar --- .../devicetree/bindings/sound/qcom,sdm845.txt | 82

[PATCH] ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask

2018-11-01 Thread Rohit kumar
SD line mask for MI2S starts from BIT 0 instead of BIT 1. Fix all bit mask for MI2S SD lines. Signed-off-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6afe.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6

[PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-01 Thread Rohit kumar
+0xe4/0x164 Signed-off-by: Rohit kumar --- sound/soc/soc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 6ddcf12..abdc460 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1467,7 +1467,7 @@ static int

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-02 Thread Rohit Kumar
On 11/2/2018 1:12 PM, Takashi Iwai wrote: On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote: Remove no_pcm check to invoke pcm_new() for backend dai-links too. This fixes crash in hdmi codec driver during hdmi_codec_startup() while accessing chmap_info struct. chmap_info struct memory

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-05 Thread Rohit Kumar
Hello Arnaud, On 11/5/2018 4:43 PM, Arnaud Pouliquen wrote: Hello Rohit, On 11/2/18 1:06 PM, Rohit Kumar wrote: On 11/2/2018 1:12 PM, Takashi Iwai wrote: On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote: Remove no_pcm check to invoke pcm_new() for backend dai-links too. This fixes

[PATCH] ASoC: qcom: Set dai_link id to each dai_link

2018-11-08 Thread Rohit kumar
Frontend dai_link id is used for closing ADM sessions. During concurrent usecase when one session is closed, it closes other ADM session associated with other usecase too. Dai_link->id should always point to Frontend dai id. Set cpu_dai id as dai_link id to fix the issue. Signed-off-by: Ro

[PATCH 0/2] ASoC: SDM845: Update MI2S and TDM configuration

2018-11-15 Thread Rohit kumar
Update bit clock rate, slot width for TDM and MI2S interfaces. Also add support for secondary MI2S TX interface in SDM845 machine driver. Rohit kumar (2): ASoC: sdm845: Update slot_width for Quaternary TDM port ASoC: sdm845: Add support for Secondary MI2S interface sound/soc/qcom/sdm845.c

[PATCH 1/2] ASoC: sdm845: Update slot_width for Quaternary TDM port

2018-11-15 Thread Rohit kumar
Change slot_width for quaternary TDM port to 16 and update bclk rate for TDM and MI2S interfaces accordingly. Signed-off-by: Rohit kumar --- sound/soc/qcom/sdm845.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c

[PATCH 2/2] ASoC: sdm845: Add support for Secondary MI2S interface

2018-11-15 Thread Rohit kumar
Add support to configure bit clock for secondary MI2S TX interface. Signed-off-by: Rohit kumar --- sound/soc/qcom/sdm845.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c index 84e6ee7..58593db 100644 --- a/sound/soc/qcom

Re: [alsa-devel] [PATCH 2/2] ASoC: qdsp6: q6afe-dai: Fix the dai widgets

2018-11-06 Thread Rohit Kumar
stream. Reported-by: Jimmy Cheng-Yi Chiang Reported-by: Rohit kumar Tested-by: Rohit kumar Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6afe-dai.c | 208 +++ 1 file changed, 104 insertions(+), 104 deletions(-) diff --git a/sound/soc/qcom/qdsp6

Re: [PATCH v2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-08-30 Thread Rohit Kumar
Thanks Bjorn for reviewing the patch. On 8/28/2018 11:39 AM, Bjorn Andersson wrote: On Fri 29 Jun 02:20 PDT 2018, Rohit kumar wrote: This adds APSS based ADSP PIL driver for QCOM SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor

Re: [PATCH] remoteproc: qcom: Rename Hexagon v5 PAS driver

2018-08-30 Thread Rohit Kumar
Thanks Bjorn for posting the patch. On 8/28/2018 10:42 AM, Bjorn Andersson wrote: The Hexagon v5 ADSP driver is used for more than only the ADSP and there's an upcoming non-PAS ADSP PIL for SDM845, so rename the driver to qcom_q6v5_pas in order to better suite this. Cc: Rohit kumar Signed

[PATCH v3 0/2] Add ADSP PIL driver for SDM845

2018-09-03 Thread Rohit kumar
and renaming of Hexagon v5 PAS driver https://lkml.org/lkml/2018/8/28/129 . Rohit kumar (2): dt-binding: remoteproc: Add QTI ADSP PIL bindings remoteproc: qcom: Introduce Non-PAS ADSP PIL driver .../bindings/remoteproc/qcom,adsp-pil.txt | 123 + drivers/remoteproc/Kconfig

[PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-09-03 Thread Rohit kumar
This adds Non PAS ADSP PIL driver for Qualcomm Technologies Inc SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor SubSystem(APSS). Signed-off-by: Rohit kumar --- drivers/remoteproc/Kconfig | 14 ++ drivers/remoteproc

[PATCH v3 1/2] dt-binding: remoteproc: Add QTI ADSP PIL bindings

2018-09-03 Thread Rohit kumar
Add devicetree bindings documentation file for Qualcomm Technolgies Inc ADSP Peripheral Image Loader. Signed-off-by: Rohit kumar --- .../bindings/remoteproc/qcom,adsp-pil.txt | 123 + 1 file changed, 123 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-09-24 Thread Rohit Kumar
On 9/24/2018 12:19 PM, Rohit Kumar wrote: Thanks Sibi for reviewing. On 9/22/2018 1:11 AM, Sibi Sankar wrote: Hi Rohit, On 2018-09-03 17:22, Rohit kumar wrote: This adds Non PAS ADSP PIL driver for Qualcomm Technologies Inc SoCs. Added initial support for SDM845 with ADSP bootup

Re: [PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-09-24 Thread Rohit Kumar
Thanks Sibi for reviewing. On 9/22/2018 1:11 AM, Sibi Sankar wrote: Hi Rohit, On 2018-09-03 17:22, Rohit kumar wrote: This adds Non PAS ADSP PIL driver for Qualcomm Technologies Inc SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application

[PATCH v4] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-09-24 Thread Rohit kumar
This adds Non PAS ADSP PIL driver for Qualcomm Technologies Inc SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor SubSystem(APSS). Signed-off-by: Rohit kumar --- Changes since v3: Addressed comments posted by Sibi

[PATCH 1/2] dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock list

2018-11-29 Thread Rohit kumar
LPASS_Audio_Wrapper_AON clock is on by default. Remove it from lpass clock list to avoid voting for it. Signed-off-by: Rohit kumar --- Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree

[PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock

2018-11-29 Thread Rohit kumar
Lpass_aon clock is on by default. Remove it from lpass clock list to avoid voting for it. Signed-off-by: Rohit kumar --- drivers/remoteproc/qcom_q6v5_adsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc

[PATCH 0/2] qcom_adsp_pil: Remove voting for lpass_aon clock

2018-11-29 Thread Rohit kumar
LPASS Audio Wrapper AON clock is on by default. Remove voting for it. Rohit kumar (2): dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock list remoteproc: q6v5_adsp: Remove voting for lpass_aon clock Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5

Re: [alsa-devel] [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-09-12 Thread Rohit Kumar
On 9/12/2018 5:49 PM, Cheng-Yi Chiang wrote: Toggle reset line in max98927_i2c_probe. Use a list to store max98927 instances so we do not toggle reset line again if more than one instances share the same reset line. Signed-off-by: Cheng-Yi Chiang Reviewed-and-tested-by: Rohit kumar

Re: [alsa-devel] [PATCH v4 14/14] ASoC: qcom: common: move be_hw_fixup to common

2018-09-18 Thread Rohit Kumar
Hello Srinivas, We will add support for vi feedback usecase in sdm845 machine driver where we have to support 4 channel tx data for a particular backend. We should probably keep be_hw_params_fixup in respective machine driver for now to support such requirement. Thanks, Rohit On

[PATCH] ASoC: q6afe: dt-bindings: Update input range for qcom,sd-lines

2018-09-19 Thread Rohit kumar
Input to qcom,sd-lines should be between 0 and 3 instead of 1 to 4 as 0 corresponds to BIT(0) which is MI2S_SD0 line. Bit 1 to 3 corresponds to SD1 to SD3 lines respectively. Updated documentation for the same. Signed-off-by: Rohit kumar --- Documentation/devicetree/bindings/sound/qcom

Re: [PATCH v4] dt-binding: remoteproc: Add QTI ADSP PIL bindings

2018-09-17 Thread Rohit Kumar
Hello Rob, Can you please review this patch and let me know if there is any concern with this patch. On 9/11/2018 9:24 AM, Rohit kumar wrote: Add devicetree bindings documentation file for Qualcomm Technolgies Inc ADSP Peripheral Image Loader. Signed-off-by: Rohit kumar --- Changes since

Re: [alsa-devel] [PATCH v4 02/24] soc: qcom: Add APR bus driver

2018-03-14 Thread Rohit Kumar
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla [..] +struct bus_type aprbus_type = { + .name = "aprbus", + .match = apr_device_match, + .probe = apr_device_probe, + .remove =

Re: [alsa-devel] [PATCH v4 07/24] ASoC: qdsp6: q6afe: Add q6afe driver

2018-03-13 Thread Rohit Kumar
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to Q6AFE (Audio Front End) module on Q6DSP. [..] + if (res->status) { + dev_err(afe->dev, "cmd = 0x%x returned error = 0x%x\n", +

Re: [alsa-devel] [PATCH v4 15/24] ASoC: qdsp6: q6core: Add q6core driver

2018-03-13 Thread Rohit Kumar
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla [..] +static int q6core_get_svc_versions(struct q6core *core) +{ + struct apr_device *adev = core->adev; + struct apr_hdr hdr = {0}; + int rc; + + core->get_version_supported =

Re: [alsa-devel] [PATCH v3 15/25] ASoC: qcom: qdsp6: Add support to q6asm dai driver

2018-02-21 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6asm dai driver which configures Q6ASM streams to pass pcm data. Signed-off-by: Srinivas Kandagatla [..] diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c

Re: [alsa-devel] [PATCH v3 24/25] ASoC: qcom: apq8096: Add db820c machine driver

2018-02-22 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to DB820c machine driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 8 +++ sound/soc/qcom/apq8096.c | 173

Re: [alsa-devel] [PATCH v7 16/24] ASoC: qdsp6: q6asm: Add support to audio stream apis

2018-05-04 Thread Rohit Kumar
On 5/1/2018 5:38 PM, Srinivas Kandagatla wrote: +static int __q6asm_run(struct audio_client *ac, uint32_t flags, + uint32_t msw_ts, uint32_t lsw_ts, bool wait) +{ + struct asm_session_cmd_run_v2 *run; + struct apr_pkt *pkt; + int pkt_size, rc; + void *p; + +

[PATCH] remoteproc: Add APSS based Qualcomm ADSP PIL driver for SDM845

2018-05-13 Thread Rohit kumar
This adds Qualcomm ADSP PIL driver support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor SubSystem(APSS). Signed-off-by: Rohit kumar Signed-off-by: RajendraBabu Medisetti Signed-off-by: Krishnamurthy Renu --- .../devicetree/bindings/remoteproc/qcom

Re: [alsa-devel] [PATCH v4 14/24] ASoC: qdsp6: q6asm: Add support to audio stream apis

2018-04-09 Thread Rohit Kumar
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to open, write and media format commands in the q6asm module. Signed-off-by: Srinivas Kandagatla Reviewed-and-Tested-by: Rohit kumar --- sound/soc/qcom/qdsp6/q6asm.c | 744

Re: [alsa-devel] [PATCH v3 19/25] ASoC: qcom: q6afe: add support to MI2S ports

2018-03-07 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla --- include/dt-bindings/sound/qcom,q6afe.h | 10 +++ sound/soc/qcom/qdsp6/q6afe.c | 111 + sound/soc/qcom/qdsp6/q6afe.h

Re: [alsa-devel] [RESEND PATCH v2 08/15] ASoC: qcom: q6asm: add support to audio stream apis

2018-01-13 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to open, write and media format commands in the q6asm module. [..] +static int32_t q6asm_callback(struct apr_device *adev, + struct apr_client_data

Re: [alsa-devel] [RESEND PATCH v2 12/15] ASoC: qcom: qdsp6: Add support to q6asm dai driver

2018-01-13 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6asm dai driver which configures Q6ASM streams to pass pcm data. Currently the driver only exposes 2 playback streams for hdmi playback support, it can be easily extended to

Re: [alsa-devel] [PATCH v3 05/25] ASoC: qcom: qdsp6: Add support to Q6AFE

2018-02-19 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to Q6AFE (Audio Front End) module on Q6DSP. AFE module sits right at the other end of cpu where the codec/audio devices are connected. AFE provides abstraced interfaces to both

Re: [alsa-devel] [PATCH v3 14/25] ASoC: qcom: qdsp6: Add support to q6afe dai driver

2018-02-19 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6afe backend dais driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/Makefile| 2 +- sound/soc/qcom/qdsp6/q6afe-dai.c | 280

Re: [alsa-devel] [PATCH v3 12/25] ASoC: qcom: qdsp6: Add support to Q6CORE

2018-02-19 Thread Rohit Kumar
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to core apr service, which is used to query status of other static and dynamic services on the dsp. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig| 5 +

Re: [alsa-devel] [RESEND PATCH v2 11/15] ASoC: qcom: qdsp6: Add support to q6afe dai driver

2018-02-07 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6afe backend dais driver. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 5 + sound/soc/qcom/qdsp6/Makefile| 1 +

Re: [alsa-devel] [RESEND PATCH v2 09/15] ASoC: qcom: qdsp6: Add support to Q6CORE

2018-02-07 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to core apr service, which is used to query status of other static and dynamic services on the dsp. Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig| 5 +

  1   2   3   >