Re: [PATCH 2/4] drivers/mmc/host: don't use devm_pinctrl_get_select_default() in probe

2013-10-14 Thread Romain Izard
-dev); - if (IS_ERR(pinctrl)) - dev_warn(pdev-dev, no pins associated\n); - /* * Some non-DT platforms do not pass a clock, and the clock * frequency is passed through platform_data. On DT platforms, Best regards, -- Romain Izard -- To unsubscribe from

[PATCH] trace: module: Maintain a valid user count

2014-03-03 Thread Romain Izard
code, and the refcount in the traces was not usable as a result. Use 'count = incs - decs' to compute the user count. Signed-off-by: Romain Izard romain.izard@gmail.com --- include/trace/events/module.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/trace

[PATCH v2] trace: module: Maintain a valid user count

2014-03-04 Thread Romain Izard
code, and the refcount in the traces was not usable as a result. Use 'count = incs - decs' to compute the user count. Signed-off-by: Romain Izard romain.izard@gmail.com --- include/trace/events/module.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events

Re: [PATCH v2] trace: module: Maintain a valid user count

2014-05-07 Thread Romain Izard
2014-03-06 18:34 GMT+01:00 Steven Rostedt rost...@goodmis.org: Ingo, You want to push this to Linus? Reviewed-by: Steven Rostedt rost...@goodmis.org -- Steve On Tue, 4 Mar 2014 10:09:39 +0100 Romain Izard romain.izard@gmail.com wrote: The replacement of the 'count' variable

[PATCH v1] clocksource: atmel-pit: register as a sched_clock

2016-02-04 Thread Romain Izard
Register the counter of the Periodic Interval Timer as a possible source for sched_clock. This provides a better precision than the jiffies-based default. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- To reduce overhead and cache consumption, sched_clock_register does no

[PATCH] tty/serial: at91: restore dynamic driver binding

2016-02-23 Thread Romain Izard
t;clk" field on removal, triggering an oops when a device was bound again after being unbound. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/tty/serial/atmel_serial.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/dr

Re: [PATCH] tty/serial: at91: restore dynamic driver binding

2016-02-24 Thread Romain Izard
2016-02-23 20:18 GMT+01:00 Paul Gortmaker <paul.gortma...@windriver.com>: > [[PATCH] tty/serial: at91: restore dynamic driver binding] On 23/02/2016 (Tue > 17:59) Romain Izard wrote: > >> In commit c39dfebc7798956fd2140ae6321786ff35da30c3, the modular support >> code f

[PATCH v2] clocksource: atmel-pit: register as a sched_clock

2016-02-24 Thread Romain Izard
in the initialization sequence. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- Changelog: v2: - Keep the tick counter updated when the clocksource is disabled - Ensure that sched_clock is a 64 bit counter drivers/clocksource/timer-atmel-pit.c | 31 ---

Re: [PATCH] tty/serial: at91: restore dynamic driver binding

2016-02-24 Thread romain izard
2016-02-24 15:53 GMT+01:00 Nicolas Ferre <nicolas.fe...@atmel.com>: > Le 23/02/2016 17:59, Romain Izard a écrit : >> In commit c39dfebc7798956fd2140ae6321786ff35da30c3, the modular support >> code for atmel_serial was removed, as the driver cannot be built as a >>

Re: [PATCH v2] clocksource: atmel-pit: register as a sched_clock

2016-02-24 Thread Romain Izard
2016-02-24 17:20 GMT+01:00 Sylvain Rochet <sylvain.roc...@finsecur.com>: > Hi, > > On Wed, Feb 24, 2016 at 05:04:42PM +0100, Romain Izard wrote: >> Register the counter of the Periodic Interval Timer as a possible >> source for sched_clock. Keep the timer running even i

Re: [PATCH v2] tty/serial: at91: restore dynamic driver binding

2016-02-25 Thread Romain Izard
2016-02-25 17:09 GMT+01:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>: > On Thu, Feb 25, 2016 at 11:01:07AM +0100, Nicolas Ferre wrote: >> Le 25/02/2016 10:23, Romain Izard a écrit : >> > In commit c39dfebc7798956fd2140ae6321786ff35da30c3, the modular >> &

[PATCH v2] tty/serial: at91: restore dynamic driver binding

2016-02-25 Thread Romain Izard
t;clk" field on removal, triggering an oops when a device was bound again after being unbound. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- Changelog: v2: Add the rationale for keeping the "remove" function as a comment. drivers/tty/

[PATCH v3] tty/serial: at91: restore dynamic driver binding

2016-02-26 Thread Romain Izard
t;clk" field on removal, triggering an oops when a device was bound again after being unbound. Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Romain Izard <romain.izard@gmail.com> --- Changelog: v2: Add the rationale for keeping the "remove" function

[PATCH v1] serial: mctrl_gpio: Add missing module license

2016-02-23 Thread Romain Izard
As the mctrl_gpio driver can be built as a module, it needs to have its license specified with MODULE_LICENSE. Otherwise, it cannot access required symbols exported through EXPORT_SYMBOL_GPL. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/tty/serial/serial_mctrl_gpio

Re: [PATCH v1] serial: mctrl_gpio: Add missing module license

2016-02-23 Thread Romain Izard
2016-02-23 16:21 GMT+01:00 Fabio Estevam <feste...@gmail.com>: > On Tue, Feb 23, 2016 at 11:54 AM, Romain Izard > <romain.izard@gmail.com> wrote: >> As the mctrl_gpio driver can be built as a module, it needs to have its >> license specified with MODULE_LICENS

[PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node

2016-02-18 Thread Romain Izard
to require valid mappings. Additionally, the pin is not protected from being remapped later by an other driver. There is an external 1kΩ pull-up to 3.3V, so no bias is required on the Ethernet PHY's interrupt line. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- arch/arm/boot/dt

Device probing proceeds even when the default pinctrl state is invalid

2016-02-18 Thread Romain Izard
probed successfully as conflicting pin sets are not recognized as an issue, which means that my use case does not work. Is the direction I'm taking something correct ? Best regards, -- Romain Izard

Re: Device probing proceeds even when the default pinctrl state is invalid

2016-02-19 Thread romain izard
2016-02-18 21:07 GMT+01:00 Linus Walleij <linus.wall...@linaro.org>: > On Thu, Feb 18, 2016 at 11:37 AM, Romain Izard > <romain.izard@gmail.com> wrote: > >> The current code for device probing tries to map the default pinctrl >> state (in pinctrl_bind_pin

Re: [PATCH v1] watchdog: sama5d4_wdt: Reset delay on start

2016-03-04 Thread Romain Izard
Hi Wenyou, Guenter, 2016-03-04 6:23 GMT+01:00 Guenter Roeck <li...@roeck-us.net>: > On 03/03/2016 05:35 PM, Yang, Wenyou wrote: >> On 2016/3/3 18:29, Romain Izard wrote: >>> >>> If the internal counter is not refreshed when the watchdog is >>> started for

Re: [PATCH v1] watchdog: sama5d4_wdt: Reset delay on start

2016-03-04 Thread Romain Izard
MA5D4 & SAMA5D2 have a newer revision, which supports multiple writes to the MR register. Are you sure about your datasheet? I have this in the latest version found on Atmel's site. > Atmel-11238B-ATARM-SAMA5D4-Datasheet_24-Aug-15 > Section 18.5.2 > > Note: Write access to this register has no effect if the LOCKMR > command is issued in WDT_CR (unlocked on hardware reset). > Note: The WDT_MR register values must not be modified within three slow > clock periods following a restart of the watchdog performed by > a write access in WDT_CR. Any modification will cause the watchdog > to trigger an end of period earlier than expected. > It matches the comments from Wenyou when he committed the sama5d4 watchdog driver to replace the existing at91sam9 watchdog. Best regards, -- Romain Izard

Re: [PATCH v1] watchdog: sama5d4_wdt: Reset delay on start

2016-03-04 Thread Romain Izard
2016-03-04 14:09 GMT+01:00 Guenter Roeck <li...@roeck-us.net>: > On 03/04/2016 01:06 AM, Romain Izard wrote: >> 2016-03-04 6:23 GMT+01:00 Guenter Roeck <li...@roeck-us.net>: >>> On 03/03/2016 05:35 PM, Yang, Wenyou wrote: >>>> On 2016/3/3 18:29, Romai

[PATCH v1] watchdog: sama5d4_wdt: Reset delay on start

2016-03-03 Thread Romain Izard
the timer on opening the watchdog device. Command: "while sleep 5; do echo 1; done > /dev/watchdog" Before: system reset After: the watchdog runs correctly Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/watchdog/sama5d4_wdt.c | 3 +++ 1 file changed, 3

Re: [PATCH v1] watchdog: sama5d4_wdt: Reset delay on start

2016-03-03 Thread Romain Izard
Hi Guenter, 2016-03-03 13:10 GMT+01:00 Guenter Roeck <li...@roeck-us.net>: > On 03/03/2016 02:29 AM, Romain Izard wrote: >> >> If the internal counter is not refreshed when the watchdog is started >> for the first time, the watchdog will trigger very rapidly. For >&g

Re: [PATCH] ARM: dts: at91: sama5d2: use "atmel,sama5d3-nfc" compatible for nfc

2016-05-09 Thread Romain Izard
ives the proper ready/busy bit information. The NAND flash > driver will be updated to remove the support for this different > implementation. > > Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> > [nicolas.fe...@atmel.com: change commit message] > Signed-off-by: Nicolas F

Re: [PATCH 1/2] Revert "mtd: atmel_nand: Support variable RB_EDGE interrupts"

2016-05-10 Thread Romain Izard
freeze the kernel version to be used on my board as soon as possible. Best regards, -- Romain Izard

[PATCH v1] usb: gadget: configfs: log function unbinding as information

2016-07-26 Thread Romain Izard
Disabling USB gadget functions configured through configfs is something that can happen in normal use cases. Keep the existing log for this type of event, but only as information, not as an error. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/usb/gadget/configfs

Fractional divider on the Atmel USART controller

2017-02-06 Thread Romain Izard
Should I just propose this as a patch, or is it necessary to add a limitation for supported devices only ? Best regards, -- Romain Izard

Re: Fractional divider on the Atmel USART controller

2017-02-06 Thread Romain Izard
2017-02-06 16:14 GMT+01:00 Romain Izard <romain.izard@gmail.com>: > > For verification, I checked the SAMA5D2 datasheet, and (in rev. D) the > warning is still present in §41.7.1.2. It looks like I got confused with between the versions. In fact, the warning disappeared between

Re: Fractional divider on the Atmel USART controller

2017-02-06 Thread Romain Izard
2017-02-06 14:42 GMT+01:00 Ludovic Desroches <ludovic.desroc...@microchip.com>: > Hello Romain, > > On Mon, Feb 06, 2017 at 12:56:42PM +0100, Romain Izard wrote: >> >> Unfortunately, I know that this will work on SAMA5D2, but this driver is >> used for many

[PATCH] Revert "ARM: at91/dt: sama5d2: Use new compatible for ohci node"

2017-02-17 Thread Romain Izard
RM: at91/dt: sama5d2: Use new compatible for ohci node") Signed-off-by: Romain Izard <romain.izard@gmail.com> cc: <sta...@vger.kernel.org> --- arch/arm/boot/dts/sama5d2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sama5d2.d

[PATCH] usb: gadget: legacy gadgets are optional

2017-02-13 Thread Romain Izard
When building without modules, it makes sense to configure the kernel to only use configfs for USB Gadget drivers. Mark the choice for legacy gadget drivers as optional. Signed-off-by: Romain Izard <romain.izard@gmail.com> cc: <sta...@vger.kernel.org> # 4.9 --- drivers/usb/ga

[PATCH] atmel_serial: Use the fractional divider when possible

2017-02-10 Thread Romain Izard
. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/tty/serial/atmel_serial.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index fabbe76203bb..6684456dca9e 100644 --- a/drive

Re: [PATCH] tcb_clksrc: Use 32 bit tcb as sched_clock

2017-01-17 Thread Romain Izard
0x18/0x124) [] (kernel_init) from [] (ret_from_fork+0x14/0x20) ---[ end trace 3d13186881cd5c91 ]--- "sched_clock_register" expects to be called with interrupts disabled, but the tcb_clksrc initialization is called as an arch_initcall, which runs too late in the boot sequence. Best regards, -- Romain Izard

Re: [PATCH v2] usb: gadget: configfs: log function unbinding as debug

2016-09-07 Thread Romain Izard
2016-08-29 11:07 GMT+02:00 Romain Izard <romain.izard@gmail.com>: > Disabling USB gadget functions configured through configfs is something > that can happen in normal use cases. Keep the existing log for this type > of event, but only as debug, not as an error. > > Signed

[PATCH v2] usb: gadget: configfs: log function unbinding as debug

2016-08-29 Thread Romain Izard
Disabling USB gadget functions configured through configfs is something that can happen in normal use cases. Keep the existing log for this type of event, but only as debug, not as an error. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- v1 -> v2: - use dev_dbg instead of

Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information

2016-08-29 Thread Romain Izard
2016-07-26 18:21 GMT+02:00 Romain Izard <romain.izard@gmail.com>: > Disabling USB gadget functions configured through configfs is something > that can happen in normal use cases. Keep the existing log for this type > of event, but only as information, not as an error. > >

Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information

2016-08-29 Thread Romain Izard
2016-08-29 10:13 GMT+02:00 Felipe Balbi <ba...@kernel.org>: > > Hi, > > Romain Izard <romain.izard@gmail.com> writes: >> Disabling USB gadget functions configured through configfs is something >> that can happen in normal use cases. Keep the existing log

[PATCH v1] usb: gadget: udc: atmel: Remove an unused local variable

2017-03-09 Thread Romain Izard
The local variable ept_cfg is not used anymore in usba_ep_enable. Use ep->ept_cfg in the debug function to remove a warning when building with dynamic debug enabled. Signed-off-by: Romain Izard <romain.izard@gmail.com> Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpo

[PATCH v1] Revert "clocksource/drivers/tcb_clksrc: Use 32 bit tcb as sched_clock"

2017-03-09 Thread Romain Izard
ed as well. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/clocksource/tcb_clksrc.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c index 745844ee973e..d4ca9962a759 1006

Re: [PATCH v2] usb: gadget: legacy gadgets are optional

2017-03-10 Thread Romain Izard
Hello Felipe, 2017-03-10 10:15 GMT+01:00 Felipe Balbi <ba...@kernel.org>: > > Hi, > > Romain Izard <romain.izard@gmail.com> writes: >> With commit "usb: gadget: don't couple configfs to legacy gadgets" >> it is possible to build a modular

[PATCH] mmc: sdhci-of-at91: Support external regulators

2017-03-09 Thread Romain Izard
the connected device. Implement a custom 'set_power' function for this specific hardware, that configures the voltage in the register in all cases. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/mmc/host/sdhci-of-at91.c | 19 +++ 1 file changed, 19 inse

[PATCH v2] usb: gadget: legacy gadgets are optional

2017-03-09 Thread Romain Izard
ithout any legacy gadget driver. Mark the choice for legacy gadget drivers as optional. Fixes: bc49d1d17dcf ("usb: gadget: don't couple configfs to legacy gadgets") Cc: <sta...@vger.kernel.org> # 4.9+ Signed-off-by: Romain Izard <romain.izard@gmail.com> --- changes in v2: -

[PATCH v3 1/2] usb: gadget: legacy gadgets are optional

2017-03-10 Thread Romain Izard
gets") Cc: <sta...@vger.kernel.org> # 4.9+ Signed-off-by: Romain Izard <romain.izard@gmail.com> --- Changes in v2: - Reword description Changes in v3: - Remove comment changes drivers/usb/gadget/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/Kcon

[PATCH v3 0/2] Various cleanups for USB Gadget Kconfig

2017-03-10 Thread Romain Izard
Fix some issues left when the configuration was updated to support a built-in USB gadget configfs together with modular legacy gadget drivers. Changes in v2: - Reword description Changes in v3: - Split functional and comment changes Romain Izard (2): usb: gadget: legacy gadgets are optional

[PATCH v3 2/2] usb: gadget: reword configuration choices

2017-03-10 Thread Romain Izard
is not the only way to provice service as an USB gadget. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- Changes in v3: - split from the functional patch drivers/usb/gadget/Kconfig | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/Kc

Re: [PATCH v1] usb: gadget: udc: atmel: Remove an unused local variable

2017-03-10 Thread Romain Izard
2017-03-09 18:02 GMT+01:00 Romain Izard <romain.izard@gmail.com>: > The local variable ept_cfg is not used anymore in usba_ep_enable. > Use ep->ept_cfg in the debug function to remove a warning when building > with dynamic debug enabled. > > Signed-off-by: Ro

Warning on boot on SAMA5D2 with Linux 4.11-rc1

2017-03-06 Thread Romain Izard
are enabled. This warning does not prevent the tcb clock from being used. -- Romain Izard

Re: Warning on boot on SAMA5D2 with Linux 4.11-rc1

2017-03-07 Thread Romain Izard
2017-03-06 12:28 GMT+01:00 Romain Izard <romain.izard@gmail.com>: > > While looking for another issue, I tried Linux 4.11-rc1 on a SAMA5D2 Xplained > board. The boot log contains the following warning: > > [0.10] [ cut here ] > [0.100

Re: [PATCH 1/3] ARM: at91: pm: Add sama5d2 backup mode

2017-04-27 Thread Romain Izard
) > + mov pc, lr > +ENDPROC(at91_slowck_mode) > > /* > * void at91_sramc_self_refresh(unsigned int is_active) > @@ -314,6 +358,10 @@ ENDPROC(at91_sramc_self_refresh) > .word 0 > .sramc1_base: > .word 0 > +.shdwc: > + .word 0 > +.sfr: > + .word 0 > .memtype: > .word 0 > .pm_mode: > diff --git a/arch/arm/mach-at91/sama5.c b/arch/arm/mach-at91/sama5.c > index 6d157d0ead8e..3d0bf95a56ae 100644 > --- a/arch/arm/mach-at91/sama5.c > +++ b/arch/arm/mach-at91/sama5.c > @@ -34,7 +34,6 @@ DT_MACHINE_START(sama5_dt, "Atmel SAMA5") > MACHINE_END > > static const char *const sama5_alt_dt_board_compat[] __initconst = { > - "atmel,sama5d2", > "atmel,sama5d4", > NULL > }; > @@ -45,3 +44,21 @@ DT_MACHINE_START(sama5_alt_dt, "Atmel SAMA5") > .dt_compat = sama5_alt_dt_board_compat, > .l2c_aux_mask = ~0UL, > MACHINE_END > + > +static void __init sama5d2_init(void) > +{ > + of_platform_default_populate(NULL, NULL, NULL); > + sama5d2_pm_init(); > +} > + > +static const char *const sama5d2_compat[] __initconst = { > + "atmel,sama5d2", > + NULL > +}; > + > +DT_MACHINE_START(sama5d2, "Atmel SAMA5") > + /* Maintainer: Atmel */ > + .init_machine = sama5d2_init, > + .dt_compat = sama5d2_compat, > + .l2c_aux_mask = ~0UL, > +MACHINE_END Best regards, -- Romain Izard

Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks

2017-09-14 Thread romain izard
2017-09-13 19:03 GMT+02:00 Alexandre Belloni <alexandre.bell...@free-electrons.com>: > On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote: >> On 08/09/2017 at 17:35, Romain Izard wrote: >> > From: Romain Izard <romain.iz...@mobile-devices.fr> >> >

[PATCH v2 4/9] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

2017-09-15 Thread Romain Izard
reset the PMECC controller before using it. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/mtd/nand/atmel/pmecc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c index 8c210a

[PATCH v2 0/9] Various patches for SAMA5D2 backup mode

2017-09-15 Thread Romain Izard
a week without hanging. Changes in v2: * drop the IIO patch duplicating existing code * determine the number of programmable clocks to save dynamically * declare a required local variable in the tty/serial patch Romain Izard (9): clk: at91: pmc: Wait for clocks when resuming clk: at91: pmc

[PATCH v2 8/9] atmel_flexcom: Support backup mode

2017-09-15 Thread Romain Izard
The controller used by a flexcom module is configured at boot, and left alone after this. As the configuration will be lost after backup mode, restore the state of the flexcom driver on resume. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/mfd/atmel-flexcom.

[PATCH v2 7/9] pwm: atmel-tcb: Support backup mode

2017-09-15 Thread Romain Izard
Save and restore registers for the PWM on suspend and resume, which makes hibernation and backup modes possible. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/pwm/pwm-atmel-tcb.c | 63 +++-- 1 file changed, 61 insertions

[PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors

2017-09-15 Thread Romain Izard
It is not normal for the PMECC to fail when trying to fix ECC errors. Report these cases as errors. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/mtd/nand/atmel/pmecc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/atmel/pme

[PATCH v2 9/9] tty/serial: atmel: Prevent a warning on suspend

2017-09-15 Thread Romain Izard
spend_port disappears, and suspending is 20ms shorter for each enabled Atmel serial port. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/tty/serial/atmel_serial.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/tty/serial/atmel_serial.c b/dr

[PATCH v2 6/9] ehci-atmel: Power down during suspend is normal

2017-09-15 Thread Romain Izard
When an Atmel SoC is suspended with the backup mode, the USB bus will be powered down. As this is expected, do not return an error to the driver core when ehci_resume detects it. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/usb/host/ehci-atmel.c | 3 ++- 1 file chan

[PATCH v2 3/9] clk: at91: pmc: Support backup for programmable clocks

2017-09-15 Thread Romain Izard
From: Romain Izard <romain.iz...@mobile-devices.fr> When an AT91 programmable clock is declared in the device tree, register it into the Power Management Controller driver. On entering suspend mode, the driver saves and restores the Programmable Clock registers to support the backu

[PATCH v2 2/9] clk: at91: pmc: Save SCSR during suspend

2017-09-15 Thread Romain Izard
clocks will be impacted. Fix the obvious typo in the suspend/resume code, as the IMR register does not need to be saved twice. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com> --- drivers/clk/at91/pmc.c | 4 ++-- 1 fil

[PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming

2017-09-15 Thread Romain Izard
Wait for the syncronization of all clocks when resuming, not only the UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() when interrupts are masked, which is the case in here. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/clk/at91/pmc.

Re: [PATCH v1 01/10] clk: at91: pmc: Wait for clocks when resuming

2017-09-14 Thread Romain Izard
2017-09-13 14:15 GMT+02:00 Nicolas Ferre <nicolas.fe...@microchip.com>: > On 08/09/2017 at 17:35, Romain Izard wrote: >> Wait for the syncronization of all clocks when resuming, not only the >> UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() >>

Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode

2017-09-20 Thread Romain Izard
2017-09-19 17:25 GMT+02:00 Lee Jones <lee.jo...@linaro.org>: > On Tue, 19 Sep 2017, Nicolas Ferre wrote: > >> On 15/09/2017 at 16:04, Romain Izard wrote: >> > The controller used by a flexcom module is configured at boot, and left >> > alone after this. As

[PATCH] ARM: unaligned.h: Use an arch-specific version

2017-09-20 Thread Romain Izard
header to ARM, to retain other optimizations that rely on HAVE_EFFICIENT_UNALIGNED_ACCESS, while making sure that access that explicitly rely on the unaligned accessors are correctly handled by the compiler. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- This is a fol

Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors

2017-09-21 Thread Romain Izard
2017-09-18 12:00 GMT+02:00 Boris Brezillon <boris.brezil...@free-electrons.com>: > Hi Romain, > > On Fri, 15 Sep 2017 16:04:07 +0200 > Romain Izard <romain.izard@gmail.com> wrote: > >> It is not normal for the PMECC to fail when trying to fix ECC errors

[PATCH] crypto: atmel-aes - properly set IV after {en,de}crypt

2017-10-06 Thread Romain Izard
is now correctly passed. To handle the case of in-place decryption, copy the ciphertext in an intermediate buffer before decryption. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/crypto/atmel-aes.c | 28 1 file changed, 28 insertions(+)

Re: [PATCH] crypto: atmel-aes - properly set IV after {en,de}crypt

2017-10-10 Thread Romain Izard
2017-10-06 17:51 GMT+02:00 Romain Izard <romain.izard@gmail.com>: > > Certain cipher modes like CTS expect the IV (req->info) of > ablkcipher_request (or equivalently req->iv of skcipher_request) to > contain the last ciphertext block when the {en,de}crypt operation is

Re: [PATCH] crypto: atmel-aes - properly set IV after {en,de}crypt

2017-10-10 Thread Romain Izard
y/Tested-by? > > [1]http://patchwork.ozlabs.org/patch/821959/ I'll try it. -- Romain Izard

Re: [PATCH v1 07/10] iio:adc:at91-sama5d2: Support backup mode

2017-09-08 Thread Romain Izard
2017-09-08 18:03 GMT+02:00 Nicolas Ferre <nicolas.fe...@microchip.com>: > On 08/09/2017 at 17:36, Romain Izard wrote: >> Support the backup mode for platform suspend, by restoring the hardware >> registers on resume. >> >> Signed-off-by: Romain Izard <ro

[PATCH v1 10/10] tty/serial: atmel: Prevent a warning on suspend

2017-09-08 Thread Romain Izard
spend_port disappears, and suspending is 20ms shorter for each enabled Atmel serial port. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/tty/serial/atmel_serial.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/tty/serial/atmel_serial.c b/dr

[PATCH v1 01/10] clk: at91: pmc: Wait for clocks when resuming

2017-09-08 Thread Romain Izard
Wait for the syncronization of all clocks when resuming, not only the UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() when interrupts are masked, which is the case in here. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/clk/at91/pmc.

[PATCH v1 06/10] ehci-atmel: Power down during suspend is normal

2017-09-08 Thread Romain Izard
When an Atmel SoC is suspended with the backup mode, the USB bus will be powered down. As this is expected, do not return an error to the driver core when ehci_resume detects it. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/usb/host/ehci-atmel.c | 3 ++- 1 file chan

[PATCH v1 05/10] mtd: nand: atmel: Report PMECC failures as errors

2017-09-08 Thread Romain Izard
It is not normal for the PMECC to fail when trying to fix ECC errors. Report these cases as errors. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/mtd/nand/atmel/pmecc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/atmel/pme

[PATCH v1 00/10] Various patches for SAMA5D2 backup mode

2017-09-08 Thread Romain Izard
a week without hanging. Romain Izard (10): clk: at91: pmc: Wait for clocks when resuming clk: at91: pmc: Save SCSR during suspend clk: at91: pmc: Support backup for programmable clocks mtd: nand: atmel: Avoid ECC errors when leaving backup mode mtd: nand: atmel: Report PMECC failures

[PATCH v1 02/10] clk: at91: pmc: Save SCSR during suspend

2017-09-08 Thread Romain Izard
clocks will be impacted. Fix the obvious typo in the suspend/resume code, as the IMR register does not need to be saved twice. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/clk/at91/pmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks

2017-09-08 Thread Romain Izard
From: Romain Izard <romain.iz...@mobile-devices.fr> Save and restore the System Clock and Programmable Clock register for the backup use case. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/clk/at91/pmc.c | 5 + 1 file changed, 5 insertions(+) diff --git a

[PATCH v1 04/10] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

2017-09-08 Thread Romain Izard
reset the PMECC controller before using it. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/mtd/nand/atmel/pmecc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c index 8c210a

[PATCH v1 08/10] pwm: atmel-tcb: Support backup mode

2017-09-08 Thread Romain Izard
Save and restore registers for the PWM on suspend and resume, which makes hibernation and backup modes possible. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/pwm/pwm-atmel-tcb.c | 63 +++-- 1 file changed, 61 insertions

[PATCH v1 09/10] atmel_flexcom: Support backup mode

2017-09-08 Thread Romain Izard
The controller used by a flexcom module is configured at boot, and left alone after this. As the configuration will be lost after backup mode, restore the state of the flexcom driver on resume. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/mfd/atmel-flexcom.

[PATCH v1 07/10] iio:adc:at91-sama5d2: Support backup mode

2017-09-08 Thread Romain Izard
Support the backup mode for platform suspend, by restoring the hardware registers on resume. Signed-off-by: Romain Izard <romain.izard@gmail.com> --- drivers/iio/adc/at91-sama5d2_adc.c | 71 -- 1 file changed, 61 insertions(+), 10 deletions(-) diff

Re: [PATCH v1 10/10] tty/serial: atmel: Prevent a warning on suspend

2017-09-11 Thread Romain Izard
2017-09-08 17:36 GMT+02:00 Romain Izard <romain.izard@gmail.com>: > The atmel serial port driver reported the following warning on suspend: > atmel_usart f802.serial: ttyS1: Unable to drain transmitter > > As the ATMEL_US_TXEMPTY status bit in ATMEL_US_CSR is alw

Re: [PATCH v2 3/9] clk: at91: pmc: Support backup for programmable clocks

2017-09-25 Thread Romain Izard
2017-09-22 12:31 GMT+02:00 Nicolas Ferre <nicolas.fe...@microchip.com>: > On 15/09/2017 at 16:04, Romain Izard wrote: >> From: Romain Izard <romain.iz...@mobile-devices.fr> >> >> When an AT91 programmable clock is declared in the device tree, register >>

Re: [PATCH v3 4/8] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

2017-09-27 Thread Romain Izard
2017-09-27 17:08 GMT+02:00 Boris Brezillon <boris.brezil...@free-electrons.com>: > On Wed, 27 Sep 2017 10:35:51 +0200 > Romain Izard <romain.izard@gmail.com> wrote: > >> During backup mode, the contents of all registers will be cleared as the >> So

[PATCH v3 1/8] clk: at91: pmc: Wait for clocks when resuming

2017-09-27 Thread Romain Izard
Wait for the syncronization of all clocks when resuming, not only the UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() when interrupts are masked, which is the case in here. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Ludovic Desroches <ludov

[PATCH v3 8/8] tty/serial: atmel: Prevent a warning on suspend

2017-09-27 Thread Romain Izard
spend_port disappears, and suspending is 20ms shorter for each enabled Atmel serial port. Signed-off-by: Romain Izard <romain.izard@gmail.com> Tested-by: Nicolas Ferre <nicolas.fe...@microchip.com> Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com> Acked-by: Richard Geno

[PATCH v3 7/8] atmel_flexcom: Support backup mode

2017-09-27 Thread Romain Izard
The controller used by a flexcom module is configured at boot, and left alone after this. As the configuration will be lost after backup mode, restore the state of the flexcom driver on resume. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Nicolas Ferre <n

[PATCH v3 6/8] pwm: atmel-tcb: Support backup mode

2017-09-27 Thread Romain Izard
Save and restore registers for the PWM on suspend and resume, which makes hibernation and backup modes possible. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com> --- drivers/pwm/pwm-atme

[PATCH v3 4/8] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

2017-09-27 Thread Romain Izard
-by: Romain Izard <romain.izard@gmail.com> --- Change in v3: * keep the PMECC disabled when not in use, and use atmel_pmecc_resume to reset the controller after the bootloader has left it enabled. drivers/mtd/nand/atmel/nand-controller.c | 3 +++ drivers/mtd/nand/atmel/pmecc.c

[PATCH v3 5/8] ehci-atmel: Power down during suspend is normal

2017-09-27 Thread Romain Izard
When an Atmel SoC is suspended with the backup mode, the USB bus will be powered down. As this is expected, do not return an error to the driver core when ehci_resume detects it. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Nicolas Ferre <nicolas.fe...@micr

[PATCH v3 0/8] Various patches for SAMA5D2 backup mode

2017-09-27 Thread Romain Izard
variable in the tty/serial patch Changes in v3: * drop dev_printk changes for PMECC * rework the resume code for PMECC * improve comments on PMC clock handling Romain Izard (8): clk: at91: pmc: Wait for clocks when resuming clk: at91: pmc: Save SCSR during suspend clk: at91: pmc: Support

[PATCH v3 2/8] clk: at91: pmc: Save SCSR during suspend

2017-09-27 Thread Romain Izard
clocks will be impacted. Fix the obvious typo in the suspend/resume code, as the IMR register does not need to be saved twice. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com> --- drivers/clk/at91/pmc.c | 4 ++-- 1 fil

[PATCH v3 3/8] clk: at91: pmc: Support backup for programmable clocks

2017-09-27 Thread Romain Izard
From: Romain Izard <romain.iz...@mobile-devices.fr> When an AT91 programmable clock is declared in the device tree, register it into the Power Management Controller driver. On entering suspend mode, the driver saves and restores the Programmable Clock registers to support the backu

[PATCH v4 6/8] pwm: atmel-tcb: Support backup mode

2017-09-28 Thread Romain Izard
Save and restore registers for the PWM on suspend and resume, which makes hibernation and backup modes possible. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com> --- drivers/pwm/pwm-atme

[PATCH v4 5/8] ehci-atmel: Power down during suspend is normal

2017-09-28 Thread Romain Izard
When an Atmel SoC is suspended with the backup mode, the USB bus will be powered down. As this is expected, do not return an error to the driver core when ehci_resume detects it. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Nicolas Ferre <nicolas.fe...@micr

[PATCH v4 3/8] clk: at91: pmc: Support backup for programmable clocks

2017-09-28 Thread Romain Izard
From: Romain Izard <romain.iz...@mobile-devices.fr> When an AT91 programmable clock is declared in the device tree, register it into the Power Management Controller driver. On entering suspend mode, the driver saves and restores the Programmable Clock registers to support the backu

[PATCH v4 4/8] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

2017-09-28 Thread Romain Izard
-by: Romain Izard <romain.izard@gmail.com> --- Changes in v3: * keep the PMECC disabled when not in use, and use atmel_pmecc_resume to reset the controller after the bootloader has left it enabled. Changes in v4: * export atmel_pmecc_reset instead of atmel_pmecc_resume * use the correct p

[PATCH v4 1/8] clk: at91: pmc: Wait for clocks when resuming

2017-09-28 Thread Romain Izard
Wait for the syncronization of all clocks when resuming, not only the UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG() when interrupts are masked, which is the case in here. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Ludovic Desroches <ludov

[PATCH v4 8/8] tty/serial: atmel: Prevent a warning on suspend

2017-09-28 Thread Romain Izard
spend_port disappears, and suspending is 20ms shorter for each enabled Atmel serial port. Signed-off-by: Romain Izard <romain.izard@gmail.com> Tested-by: Nicolas Ferre <nicolas.fe...@microchip.com> Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com> Acked-by: Richard Geno

[PATCH v4 0/8] Various patches for SAMA5D2 backup mode

2017-09-28 Thread Romain Izard
variable in the tty/serial patch Changes in v3: * drop dev_printk changes for PMECC * rework the resume code for PMECC * improve comments on PMC clock handling Changes in v4: * fix a bug in the PMECC resume code Romain Izard (8): clk: at91: pmc: Wait for clocks when resuming clk: at91: pmc

[PATCH v4 2/8] clk: at91: pmc: Save SCSR during suspend

2017-09-28 Thread Romain Izard
clocks will be impacted. Fix the obvious typo in the suspend/resume code, as the IMR register does not need to be saved twice. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com> --- drivers/clk/at91/pmc.c | 4 ++-- 1 fil

[PATCH v4 7/8] atmel_flexcom: Support backup mode

2017-09-28 Thread Romain Izard
The controller used by a flexcom module is configured at boot, and left alone after this. As the configuration will be lost after backup mode, restore the state of the flexcom driver on resume. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Nicolas Ferre <n

  1   2   3   >