Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-18 Thread Russell King - ARM Linux
On Tue, Dec 18, 2018 at 05:36:04PM +0530, Souptick Joarder wrote: > On Tue, Dec 18, 2018 at 3:27 PM Russell King - ARM Linux > wrote: > > This looks like a change in behaviour. > > > > If user_count is zero, and offset is zero, then we pass into > > vm_inser

Re: [PATCH v4 3/9] drivers/firewire/core-iso.c: Convert to use vm_insert_range

2018-12-18 Thread Russell King - ARM Linux
On Tue, Dec 18, 2018 at 01:52:46AM +0530, Souptick Joarder wrote: > Convert to use vm_insert_range to map range of kernel memory > to user vma. > > Signed-off-by: Souptick Joarder > Reviewed-by: Matthew Wilcox > --- > drivers/firewire/core-iso.c | 15 ++- > 1 file changed, 2

Re: Question: pause mode disabled for marvell 88e151x phy

2018-12-18 Thread Russell King - ARM Linux
On Tue, Dec 18, 2018 at 05:34:27PM +0800, Yunsheng Lin wrote: > On 2018/12/17 22:36, Russell King - ARM Linux wrote: > > As I've previously stated, the behaviour I've seen is _both_ pause bits > > clear: > > > > If I set bit 10 (pause), and read back to confirm: > &

Re: [PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-18 Thread Russell King - ARM Linux
On Tue, Dec 18, 2018 at 01:53:34AM +0530, Souptick Joarder wrote: > Convert to use vm_insert_range() to map range of kernel > memory to user vma. > > Signed-off-by: Souptick Joarder > Tested-by: Heiko Stuebner > Acked-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 19

Re: [PATCH v4 2/9] arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range

2018-12-18 Thread Russell King - ARM Linux
On Tue, Dec 18, 2018 at 01:52:09AM +0530, Souptick Joarder wrote: > Convert to use vm_insert_range() to map range of kernel > memory to user vma. > > Signed-off-by: Souptick Joarder > --- > arch/arm/mm/dma-mapping.c | 21 +++-- > 1 file changed, 7 insertions(+), 14 deletions(-)

Re: Question: pause mode disabled for marvell 88e151x phy

2018-12-17 Thread Russell King - ARM Linux
On Mon, Dec 17, 2018 at 05:42:20PM +0800, Yunsheng Lin wrote: > On 2018/12/15 18:37, Russell King - ARM Linux wrote: > > On Sat, Dec 15, 2018 at 04:07:42PM +0800, Yunsheng Lin wrote: > >> There seems to be some problem with pause subsequent negotiation. > >> We reverte

Re: Question: pause mode disabled for marvell 88e151x phy

2018-12-15 Thread Russell King - ARM Linux
On Sat, Dec 15, 2018 at 04:07:42PM +0800, Yunsheng Lin wrote: > There seems to be some problem with pause subsequent negotiation. > We reverted the above patch and tried to reproduce the above problem > by triggering another negotiation by reconnection of the cable, using > ethtool -a cmd shows

Re: [PATCH net v2] net: mvpp2: 10G modes aren't supported on all ports

2018-12-14 Thread Russell King - ARM Linux
On Fri, Dec 14, 2018 at 05:09:44PM +0100, Antoine Tenart wrote: > Hi Russell, > > On Fri, Dec 14, 2018 at 04:02:50PM +, Russell King - ARM Linux wrote: > > On Fri, Dec 14, 2018 at 10:34:51AM +0100, Antoine Tenart wrote: > > > The mvpp2_phylink_validate()

Re: [PATCH net v2] net: mvpp2: 10G modes aren't supported on all ports

2018-12-14 Thread Russell King - ARM Linux
On Fri, Dec 14, 2018 at 10:34:51AM +0100, Antoine Tenart wrote: > The mvpp2_phylink_validate() function sets all modes that are > supported by a given PPv2 port. A recent change made all ports to > advertise they support 10G modes in certain cases. This is not true, > as only the port #0 can do

Re: [PATCH] tty: serial: don't do termios for BTIF

2018-12-13 Thread Russell King - ARM Linux
On Thu, Dec 13, 2018 at 02:24:03PM +0800, Ryder Lee wrote: > The MediaTek BTIF controller doesn't need to set termios so add > a new capability 'UART_CAP_NMOD' for the unsupported case. > > > Signed-off-by: Sean Wang > Signed-off-by: Ryder Lee > --- > drivers/tty/serial/8250/8250.h | 1 +

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-11 Thread Russell King - ARM Linux
On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > That is, something like this, right? > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 125ea99418df..04cb0241ca2b 100644 > ---

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-11 Thread Russell King - ARM Linux
On Tue, Dec 11, 2018 at 05:32:28PM +0100, Antoine Tenart wrote: > The mvpp2_phylink_validate() function sets all modes that are > supported by a given PPv2 port. A recent change made all ports to > advertise they support 10G modes in certain cases. This is not true, > as only the port #0 can do

Re: [PATCH] mm/zsmalloc.c: Fix zsmalloc 32-bit PAE support

2018-12-10 Thread Russell King - ARM Linux
On Mon, Dec 10, 2018 at 02:35:55PM +, Robin Murphy wrote: > On 10/12/2018 14:21, Rafael David Tinoco wrote: > >On 32-bit systems, zsmalloc uses HIGHMEM and, when PAE is enabled, the > >physical frame number might be so big that zsmalloc obj encoding (to > >location) will break, causing: > > >

Re: [PATCH v3] ARM: smp: add support for per-task stack canaries

2018-12-09 Thread Russell King - ARM Linux
On Sun, Dec 09, 2018 at 06:28:11PM +0800, kbuild test robot wrote: > Hi Ard, > > I love your patch! Perhaps something to improve: Hi, This looks to me like a false warning - how can a patch touching arch code affect the result of lib/test_ubsan.c? Please can you double- check this result?

Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

2018-12-02 Thread Russell King - ARM Linux
On Sun, Dec 02, 2018 at 08:35:09PM +0100, Miquel Raynal wrote: > Hi Russell, > > Russell King - ARM Linux wrote on Fri, 30 Nov > 2018 19:00:31 +: > > > On Fri, Nov 30, 2018 at 03:47:37PM +0100, Miquel Raynal wrote: > > > So far the PHY ->xlate()

Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

2018-12-02 Thread Russell King - ARM Linux
On Sun, Dec 02, 2018 at 08:35:09PM +0100, Miquel Raynal wrote: > Hi Russell, > > Russell King - ARM Linux wrote on Fri, 30 Nov > 2018 19:00:31 +: > > > On Fri, Nov 30, 2018 at 03:47:37PM +0100, Miquel Raynal wrote: > > > So far the PHY ->xlate()

Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init

2018-11-30 Thread Russell King - ARM Linux
On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote: > > > Hi, > > > > > > As I've already fed b

Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init

2018-11-30 Thread Russell King - ARM Linux
On Fri, Nov 30, 2018 at 04:18:43PM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 30, 2018 at 04:15:54PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Nov 29, 2018 at 02:28:18PM +, Russell King - ARM Linux wrote: > > > Hi, > > > > > > As I've already fed b

Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

2018-11-30 Thread Russell King - ARM Linux
On Fri, Nov 30, 2018 at 03:47:37PM +0100, Miquel Raynal wrote: > So far the PHY ->xlate() callback was checking if the port was > "invalid" before continuing, meaning that the port has not been used > yet. This check is not correct as there is no opposite call to > ->xlate() once the PHY is

Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate()

2018-11-30 Thread Russell King - ARM Linux
On Fri, Nov 30, 2018 at 03:47:37PM +0100, Miquel Raynal wrote: > So far the PHY ->xlate() callback was checking if the port was > "invalid" before continuing, meaning that the port has not been used > yet. This check is not correct as there is no opposite call to > ->xlate() once the PHY is

Re: [PATCH v8] clk: Add (devm_)clk_get_optional() functions

2018-11-30 Thread Russell King - ARM Linux
On Fri, Nov 30, 2018 at 10:25:37AM +, Phil Edworthy wrote: > Hi Stephen, > > On 30 November 2018 09:09 Stephen Boyd wrote: > > Quoting Phil Edworthy (2018-11-20 06:14:45) > > > This adds clk_get_optional() and devm_clk_get_optional() functions to > > > get optional clocks. > > > They behave

Re: [PATCH v8] clk: Add (devm_)clk_get_optional() functions

2018-11-30 Thread Russell King - ARM Linux
On Fri, Nov 30, 2018 at 10:25:37AM +, Phil Edworthy wrote: > Hi Stephen, > > On 30 November 2018 09:09 Stephen Boyd wrote: > > Quoting Phil Edworthy (2018-11-20 06:14:45) > > > This adds clk_get_optional() and devm_clk_get_optional() functions to > > > get optional clocks. > > > They behave

Re: [PATCH 2/6] phy: add A3700 COMPHY support

2018-11-29 Thread Russell King - ARM Linux
On Thu, Nov 29, 2018 at 05:12:45PM +0100, Miquel Raynal wrote: > Hello, > > Miquel Raynal wrote on Thu, 22 Nov 2018 > 22:04:16 +0100: > > +static struct phy *mvebu_a3700_comphy_xlate(struct device *dev, > > + struct of_phandle_args *args) > > +{ > > +

Re: [PATCH 2/6] phy: add A3700 COMPHY support

2018-11-29 Thread Russell King - ARM Linux
On Thu, Nov 29, 2018 at 05:12:45PM +0100, Miquel Raynal wrote: > Hello, > > Miquel Raynal wrote on Thu, 22 Nov 2018 > 22:04:16 +0100: > > +static struct phy *mvebu_a3700_comphy_xlate(struct device *dev, > > + struct of_phandle_args *args) > > +{ > > +

Re: [PATCH] arm64: io: specify asm operand width for __iormb()

2018-11-29 Thread Russell King - ARM Linux
On Thu, Nov 29, 2018 at 09:10:39AM -0700, Nathan Chancellor wrote: > On Thu, Nov 29, 2018 at 10:49:03AM +, Will Deacon wrote: > > On Thu, Nov 29, 2018 at 09:03:54AM +, Julien Thierry wrote: > > > > > > > > > On 29/11/18 04:19, Nick Desaulniers wrote: > > > > Fixes the warning produced from

Re: [PATCH] arm64: io: specify asm operand width for __iormb()

2018-11-29 Thread Russell King - ARM Linux
On Thu, Nov 29, 2018 at 09:10:39AM -0700, Nathan Chancellor wrote: > On Thu, Nov 29, 2018 at 10:49:03AM +, Will Deacon wrote: > > On Thu, Nov 29, 2018 at 09:03:54AM +, Julien Thierry wrote: > > > > > > > > > On 29/11/18 04:19, Nick Desaulniers wrote: > > > > Fixes the warning produced from

Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init

2018-11-29 Thread Russell King - ARM Linux
e secondary startup code during hotplug. > > Reviewed-by: Julien Thierry > Signed-off-by: Russell King > Signed-off-by: Sasha Levin > --- > arch/arm/kernel/head-common.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/kernel/he

Re: [PATCH 3.18 14/83] ARM: make lookup_processor_type() non-__init

2018-11-29 Thread Russell King - ARM Linux
e secondary startup code during hotplug. > > Reviewed-by: Julien Thierry > Signed-off-by: Russell King > Signed-off-by: Sasha Levin > --- > arch/arm/kernel/head-common.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/kernel/he

Re: [PATCH] pci: imx6: support kernels built in Thumb-2 mode

2018-11-28 Thread Russell King - ARM Linux
On Wed, Nov 28, 2018 at 02:25:54PM +0100, Stefan Agner wrote: > Add a fault handler which handles reads in Thumb-2 mode. Install > the appropriate handler depending on which mode the kernel has > been built. This avoids an "Unhandled fault: external abort on > non-linefetch (0x1008) at 0xf0a8"

Re: [PATCH] pci: imx6: support kernels built in Thumb-2 mode

2018-11-28 Thread Russell King - ARM Linux
On Wed, Nov 28, 2018 at 02:25:54PM +0100, Stefan Agner wrote: > Add a fault handler which handles reads in Thumb-2 mode. Install > the appropriate handler depending on which mode the kernel has > been built. This avoids an "Unhandled fault: external abort on > non-linefetch (0x1008) at 0xf0a8"

Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init

2018-11-28 Thread Russell King - ARM Linux
On Wed, Nov 28, 2018 at 09:12:52AM -0500, Sasha Levin wrote: > On Fri, Nov 23, 2018 at 12:02:54AM +0000, Russell King - ARM Linux wrote: > >Hi Sasha, > > > >We need to keep track of which Spectre patches have been backported > >and which haven't. David Long has b

Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init

2018-11-28 Thread Russell King - ARM Linux
On Wed, Nov 28, 2018 at 09:12:52AM -0500, Sasha Levin wrote: > On Fri, Nov 23, 2018 at 12:02:54AM +0000, Russell King - ARM Linux wrote: > >Hi Sasha, > > > >We need to keep track of which Spectre patches have been backported > >and which haven't. David Long has b

Re: [PATCH] arm: always update thread_info->syscall

2018-11-27 Thread Russell King - ARM Linux
On Tue, Nov 27, 2018 at 10:56:20AM +, Russell King - ARM Linux wrote: > On Tue, Nov 27, 2018 at 08:30:32AM -0200, Rafael David Tinoco wrote: > > On 11/26/18 9:44 PM, Russell King - ARM Linux wrote: > > >On Mon, Nov 26, 2018 at 11:41:11PM +, Russell King - ARM Linux wrote:

Re: [PATCH] arm: always update thread_info->syscall

2018-11-27 Thread Russell King - ARM Linux
On Tue, Nov 27, 2018 at 10:56:20AM +, Russell King - ARM Linux wrote: > On Tue, Nov 27, 2018 at 08:30:32AM -0200, Rafael David Tinoco wrote: > > On 11/26/18 9:44 PM, Russell King - ARM Linux wrote: > > >On Mon, Nov 26, 2018 at 11:41:11PM +, Russell King - ARM Linux wrote:

Re: [PATCH] arm: always update thread_info->syscall

2018-11-27 Thread Russell King - ARM Linux
On Tue, Nov 27, 2018 at 08:30:32AM -0200, Rafael David Tinoco wrote: > On 11/26/18 9:44 PM, Russell King - ARM Linux wrote: > >On Mon, Nov 26, 2018 at 11:41:11PM +, Russell King - ARM Linux wrote: > >>On Mon, Nov 26, 2018 at 11:33:03PM +, Russell King - ARM Linux wrote: &

Re: [PATCH] arm: always update thread_info->syscall

2018-11-27 Thread Russell King - ARM Linux
On Tue, Nov 27, 2018 at 08:30:32AM -0200, Rafael David Tinoco wrote: > On 11/26/18 9:44 PM, Russell King - ARM Linux wrote: > >On Mon, Nov 26, 2018 at 11:41:11PM +, Russell King - ARM Linux wrote: > >>On Mon, Nov 26, 2018 at 11:33:03PM +, Russell King - ARM Linux wrote: &

Re: [PATCH] arm: always update thread_info->syscall

2018-11-26 Thread Russell King - ARM Linux
On Mon, Nov 26, 2018 at 11:41:11PM +, Russell King - ARM Linux wrote: > On Mon, Nov 26, 2018 at 11:33:03PM +0000, Russell King - ARM Linux wrote: > > On Mon, Nov 26, 2018 at 08:53:35PM -0200, Rafael David Tinoco wrote: > > > Right now, only way for task->thread_info-&

Re: [PATCH] arm: always update thread_info->syscall

2018-11-26 Thread Russell King - ARM Linux
On Mon, Nov 26, 2018 at 11:41:11PM +, Russell King - ARM Linux wrote: > On Mon, Nov 26, 2018 at 11:33:03PM +0000, Russell King - ARM Linux wrote: > > On Mon, Nov 26, 2018 at 08:53:35PM -0200, Rafael David Tinoco wrote: > > > Right now, only way for task->thread_info-&

Re: [PATCH] arm: always update thread_info->syscall

2018-11-26 Thread Russell King - ARM Linux
On Mon, Nov 26, 2018 at 11:33:03PM +, Russell King - ARM Linux wrote: > On Mon, Nov 26, 2018 at 08:53:35PM -0200, Rafael David Tinoco wrote: > > Right now, only way for task->thread_info->syscall to be updated is if > > if _TIF_SYSCALL_WORK is set in current's ta

Re: [PATCH] arm: always update thread_info->syscall

2018-11-26 Thread Russell King - ARM Linux
On Mon, Nov 26, 2018 at 11:33:03PM +, Russell King - ARM Linux wrote: > On Mon, Nov 26, 2018 at 08:53:35PM -0200, Rafael David Tinoco wrote: > > Right now, only way for task->thread_info->syscall to be updated is if > > if _TIF_SYSCALL_WORK is set in current's ta

Re: [PATCH] arm: always update thread_info->syscall

2018-11-26 Thread Russell King - ARM Linux
On Mon, Nov 26, 2018 at 08:53:35PM -0200, Rafael David Tinoco wrote: > Right now, only way for task->thread_info->syscall to be updated is if > if _TIF_SYSCALL_WORK is set in current's task thread_info->flags > (similar to what has_syscall_work() checks for arm64). > > This means that "->syscall"

Re: [PATCH] arm: always update thread_info->syscall

2018-11-26 Thread Russell King - ARM Linux
On Mon, Nov 26, 2018 at 08:53:35PM -0200, Rafael David Tinoco wrote: > Right now, only way for task->thread_info->syscall to be updated is if > if _TIF_SYSCALL_WORK is set in current's task thread_info->flags > (similar to what has_syscall_work() checks for arm64). > > This means that "->syscall"

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sun, Nov 25, 2018 at 11:11:05AM +, Russell King - ARM Linux wrote: > On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux [181124 20:10]: > > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > > Hi

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sun, Nov 25, 2018 at 11:11:05AM +, Russell King - ARM Linux wrote: > On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux [181124 20:10]: > > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > > Hi

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [181124 20:10]: > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > Hi, > > > > > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalus

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [181124 20:10]: > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > Hi, > > > > > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalus

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > Hi, > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > On 22/11/2018 17.12, Russell King - ARM Linux wrote: > > > I'm also not sure about this: > > >

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > Hi, > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > On 22/11/2018 17.12, Russell King - ARM Linux wrote: > > > I'm also not sure about this: > > >

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 09:06:48PM +0200, Aaro Koskinen wrote: > Hello, > > On Sat, Nov 24, 2018 at 05:48:23PM +, Russell King - ARM Linux wrote: > > Hmm, there's more questionable stuff in this driver, and the gadget > > layer. > > [...] > > > So, w

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 09:06:48PM +0200, Aaro Koskinen wrote: > Hello, > > On Sat, Nov 24, 2018 at 05:48:23PM +, Russell King - ARM Linux wrote: > > Hmm, there's more questionable stuff in this driver, and the gadget > > layer. > > [...] > > > So, w

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 02:17:40AM +0200, Aaro Koskinen wrote: > Hi, > > On Fri, Nov 23, 2018 at 01:45:46PM +0200, Peter Ujfalusi wrote: > > On 23/11/2018 0.01, Aaro Koskinen wrote: > > > With that reverted, the DMA works OK (and I can also now confirm that > > > OMAP_DMA_LCH_2D works). I haven't

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 02:17:40AM +0200, Aaro Koskinen wrote: > Hi, > > On Fri, Nov 23, 2018 at 01:45:46PM +0200, Peter Ujfalusi wrote: > > On 23/11/2018 0.01, Aaro Koskinen wrote: > > > With that reverted, the DMA works OK (and I can also now confirm that > > > OMAP_DMA_LCH_2D works). I haven't

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 04:16:59PM +, Russell King - ARM Linux wrote: > Hi Peter, > > Here's the patch, which should now support IN as well as OUT. > Completely untested, as mentioned before. Now compile tested... drivers/usb/gadget/udc/omap

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 04:16:59PM +, Russell King - ARM Linux wrote: > Hi Peter, > > Here's the patch, which should now support IN as well as OUT. > Completely untested, as mentioned before. Now compile tested... drivers/usb/gadget/udc/omap

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Russell King - ARM Linux
Hi Peter, Here's the patch, which should now support IN as well as OUT. Completely untested, as mentioned before. drivers/usb/gadget/udc/omap_udc.c | 286 ++ drivers/usb/gadget/udc/omap_udc.h | 3 +- 2 files changed, 135 insertions(+), 154 deletions(-)

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Russell King - ARM Linux
Hi Peter, Here's the patch, which should now support IN as well as OUT. Completely untested, as mentioned before. drivers/usb/gadget/udc/omap_udc.c | 286 ++ drivers/usb/gadget/udc/omap_udc.h | 3 +- 2 files changed, 135 insertions(+), 154 deletions(-)

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > Also we can't deal with the omap_set_dma_dest_burst_mode() setting - > > DMAengine always uses a 64 byte burst, but udc wants a smaller burst > > setting. Does this matter? > > The tusb also fiddled with the burst before the

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > Also we can't deal with the omap_set_dma_dest_burst_mode() setting - > > DMAengine always uses a 64 byte burst, but udc wants a smaller burst > > setting. Does this matter? > > The tusb also fiddled with the burst before the

Re: Sleeping in user_access section

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 11:57:31AM +, Julien Thierry wrote: > > > On 23/11/18 10:50, Russell King - ARM Linux wrote: > >On Fri, Nov 23, 2018 at 01:57:12AM -0800, h...@zytor.com wrote: > >>You should never call a sleeping function from a user_access section. >

Re: Sleeping in user_access section

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 11:57:31AM +, Julien Thierry wrote: > > > On 23/11/18 10:50, Russell King - ARM Linux wrote: > >On Fri, Nov 23, 2018 at 01:57:12AM -0800, h...@zytor.com wrote: > >>You should never call a sleeping function from a user_access section. >

Re: Sleeping in user_access section

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 01:57:12AM -0800, h...@zytor.com wrote: > You should never call a sleeping function from a user_access section. > It is intended for very limited regions. So, what happens if the "unsafe" user access causes a page fault that ends up sleeping? -- RMK's Patch system:

Re: Sleeping in user_access section

2018-11-23 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 01:57:12AM -0800, h...@zytor.com wrote: > You should never call a sleeping function from a user_access section. > It is intended for very limited regions. So, what happens if the "unsafe" user access causes a page fault that ends up sleeping? -- RMK's Patch system:

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 12:24:26AM +0200, Aaro Koskinen wrote: > Hi, > > On Thu, Nov 22, 2018 at 03:12:36PM +, Russell King - ARM Linux wrote: > > On Thu, Nov 22, 2018 at 10:29:48AM +0000, Russell King - ARM Linux wrote: > > > On Tue, Nov 20, 2018 at 11:04:06PM +0

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 12:24:26AM +0200, Aaro Koskinen wrote: > Hi, > > On Thu, Nov 22, 2018 at 03:12:36PM +, Russell King - ARM Linux wrote: > > On Thu, Nov 22, 2018 at 10:29:48AM +0000, Russell King - ARM Linux wrote: > > > On Tue, Nov 20, 2018 at 11:04:06PM +0

Re: [PATCH AUTOSEL 4.4 3/8] ARM: make lookup_processor_type() non-__init

2018-11-22 Thread Russell King - ARM Linux
:10PM -0500, Sasha Levin wrote: > From: Russell King > > [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ] > > Move lookup_processor_type() out of the __init section so it is callable > from (eg) the secondary startup code during hotplug. > > Reviewed-by: Juli

Re: [PATCH AUTOSEL 4.4 3/8] ARM: make lookup_processor_type() non-__init

2018-11-22 Thread Russell King - ARM Linux
:10PM -0500, Sasha Levin wrote: > From: Russell King > > [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ] > > Move lookup_processor_type() out of the __init section so it is callable > from (eg) the secondary startup code during hotplug. > > Reviewed-by: Juli

Re: [PATCH AUTOSEL 4.9 10/15] ARM: split out processor lookup

2018-11-22 Thread Russell King - ARM Linux
Sorry, I meant this patch, not patch 11. On Thu, Nov 22, 2018 at 02:56:16PM -0500, Sasha Levin wrote: > From: Russell King > > [ Upstream commit 65987a8553061515b5851b472081aedb9837a391 ] > > Split out the lookup of the processor type and associated error handling

Re: [PATCH AUTOSEL 4.9 10/15] ARM: split out processor lookup

2018-11-22 Thread Russell King - ARM Linux
Sorry, I meant this patch, not patch 11. On Thu, Nov 22, 2018 at 02:56:16PM -0500, Sasha Levin wrote: > From: Russell King > > [ Upstream commit 65987a8553061515b5851b472081aedb9837a391 ] > > Split out the lookup of the processor type and associated error handling

Re: [PATCH AUTOSEL 4.9 09/15] ARM: make lookup_processor_type() non-__init

2018-11-22 Thread Russell King - ARM Linux
8 at 02:56:15PM -0500, Sasha Levin wrote: > From: Russell King > > [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ] > > Move lookup_processor_type() out of the __init section so it is callable > from (eg) the secondary startup code during hotplug. > > Reviewe

Re: [PATCH AUTOSEL 4.9 09/15] ARM: make lookup_processor_type() non-__init

2018-11-22 Thread Russell King - ARM Linux
8 at 02:56:15PM -0500, Sasha Levin wrote: > From: Russell King > > [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ] > > Move lookup_processor_type() out of the __init section so it is callable > from (eg) the secondary startup code during hotplug. > > Reviewe

Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init

2018-11-22 Thread Russell King - ARM Linux
where they don't apply. On Thu, Nov 22, 2018 at 02:54:41PM -0500, Sasha Levin wrote: > From: Russell King > > [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ] > > Move lookup_processor_type() out of the __init section so it is callable > from (eg) the secondary s

Re: [PATCH AUTOSEL 4.14 10/21] ARM: make lookup_processor_type() non-__init

2018-11-22 Thread Russell King - ARM Linux
where they don't apply. On Thu, Nov 22, 2018 at 02:54:41PM -0500, Sasha Levin wrote: > From: Russell King > > [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ] > > Move lookup_processor_type() out of the __init section so it is callable > from (eg) the secondary s

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Russell King - ARM Linux
On Thu, Nov 22, 2018 at 06:40:45PM +0100, Ard Biesheuvel wrote: > On Thu, 22 Nov 2018 at 17:29, Jessica Yu wrote: > > > > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > > >On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > > >> On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Russell King - ARM Linux
On Thu, Nov 22, 2018 at 06:40:45PM +0100, Ard Biesheuvel wrote: > On Thu, 22 Nov 2018 at 17:29, Jessica Yu wrote: > > > > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > > >On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > > >> On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Russell King - ARM Linux
On Thu, Nov 22, 2018 at 10:29:48AM +, Russell King - ARM Linux wrote: > On Tue, Nov 20, 2018 at 11:04:06PM +0200, Aaro Koskinen wrote: > > I had switched to PIO mode in 2015 since the WARNs about legacy DMA > > API were too annoying and flooding the console. And now that I trie

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Russell King - ARM Linux
On Thu, Nov 22, 2018 at 10:29:48AM +, Russell King - ARM Linux wrote: > On Tue, Nov 20, 2018 at 11:04:06PM +0200, Aaro Koskinen wrote: > > I had switched to PIO mode in 2015 since the WARNs about legacy DMA > > API were too annoying and flooding the console. And now that I trie

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Russell King - ARM Linux
On Tue, Nov 20, 2018 at 11:04:06PM +0200, Aaro Koskinen wrote: > I had switched to PIO mode in 2015 since the WARNs about legacy DMA > API were too annoying and flooding the console. And now that I tried > using DMA again with g_ether, it doesn't work anymore. The device get's > recognized on host

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Russell King - ARM Linux
On Tue, Nov 20, 2018 at 11:04:06PM +0200, Aaro Koskinen wrote: > I had switched to PIO mode in 2015 since the WARNs about legacy DMA > API were too annoying and flooding the console. And now that I tried > using DMA again with g_ether, it doesn't work anymore. The device get's > recognized on host

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-16 Thread Russell King - ARM Linux
On Thu, Nov 15, 2018 at 03:12:17PM +1100, Finn Thain wrote: > The thread went way off-topic when Christoph took the opportunity to > suggest the removal of RPC and EBSA110. That doesn't interest me. I suspect that is the right solution - I've been trying to get 4.19 to boot on my RPC and it's

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-16 Thread Russell King - ARM Linux
On Thu, Nov 15, 2018 at 03:12:17PM +1100, Finn Thain wrote: > The thread went way off-topic when Christoph took the opportunity to > suggest the removal of RPC and EBSA110. That doesn't interest me. I suspect that is the right solution - I've been trying to get 4.19 to boot on my RPC and it's

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-14 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 03:58:36PM +0100, Geert Uytterhoeven wrote: > Hi Russell, > > On Wed, Nov 14, 2018 at 3:16 PM Russell King - ARM Linux > wrote: > > On Wed, Nov 14, 2018 at 02:17:09PM +1100, Finn Thain wrote: > > > So, even assuming that you're right about the

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-14 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 03:58:36PM +0100, Geert Uytterhoeven wrote: > Hi Russell, > > On Wed, Nov 14, 2018 at 3:16 PM Russell King - ARM Linux > wrote: > > On Wed, Nov 14, 2018 at 02:17:09PM +1100, Finn Thain wrote: > > > So, even assuming that you're right about the

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-14 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 02:17:09PM +1100, Finn Thain wrote: > On Tue, 13 Nov 2018, Russell King - ARM Linux wrote: > > > > > A clocksource provides a cycle counter that monotonically changes and > > does not wrap between clockevent events. > > > > A cloc

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-14 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 02:17:09PM +1100, Finn Thain wrote: > On Tue, 13 Nov 2018, Russell King - ARM Linux wrote: > > > > > A clocksource provides a cycle counter that monotonically changes and > > does not wrap between clockevent events. > > > > A cloc

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-14 Thread Russell King - ARM Linux
On Mon, Nov 12, 2018 at 03:12:39PM +1100, Finn Thain wrote: > Implementations of arch_gettimeoffset are generally not re-entrant > and assume that interrupts have been disabled. Unfortunately this > pre-condition got broken in v2.6.32. To me, it looks way worse than what you think. The original

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-14 Thread Russell King - ARM Linux
On Mon, Nov 12, 2018 at 03:12:39PM +1100, Finn Thain wrote: > Implementations of arch_gettimeoffset are generally not re-entrant > and assume that interrupts have been disabled. Unfortunately this > pre-condition got broken in v2.6.32. To me, it looks way worse than what you think. The original

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-13 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 02:35:29PM +1300, Michael Schmitz wrote: > So we'd still have to use jiffies + interpolation from the current timer > rundown counter as clocksource (since that will be monotonous and won't > wrap)? > > The way Finn did the clocksource for m68k, the clocksource counter

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-13 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 02:35:29PM +1300, Michael Schmitz wrote: > So we'd still have to use jiffies + interpolation from the current timer > rundown counter as clocksource (since that will be monotonous and won't > wrap)? > > The way Finn did the clocksource for m68k, the clocksource counter

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-13 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 08:55:37AM +1100, Finn Thain wrote: > On Tue, 13 Nov 2018, Russell King - ARM Linux wrote: > > > On Tue, Nov 13, 2018 at 02:39:00PM +1100, Finn Thain wrote: > > > > > > You could remove the old arch_gettimeoffset API without

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-13 Thread Russell King - ARM Linux
On Wed, Nov 14, 2018 at 08:55:37AM +1100, Finn Thain wrote: > On Tue, 13 Nov 2018, Russell King - ARM Linux wrote: > > > On Tue, Nov 13, 2018 at 02:39:00PM +1100, Finn Thain wrote: > > > > > > You could remove the old arch_gettimeoffset API without

Re: [PATCH] arm64: dts: marvell: armada_8k: reserve memory for ATF

2018-11-13 Thread Russell King - ARM Linux
On Tue, Nov 13, 2018 at 02:48:07PM +0100, Emmanuel Vadot wrote: > Like 4436a371 for 37xx, reserve the PSCI area memory region so kernels > can call the code there. > Region address is taken from the ATF code [1] and is 2MiB aligned. > > [1] plat/marvell/a8k/common/include/platform_def.h > >

Re: [PATCH] arm64: dts: marvell: armada_8k: reserve memory for ATF

2018-11-13 Thread Russell King - ARM Linux
On Tue, Nov 13, 2018 at 02:48:07PM +0100, Emmanuel Vadot wrote: > Like 4436a371 for 37xx, reserve the PSCI area memory region so kernels > can call the code there. > Region address is taken from the ATF code [1] and is 2MiB aligned. > > [1] plat/marvell/a8k/common/include/platform_def.h > >

Re: [PATCH] ARM: stm32: debug: add low-level debug support

2018-11-13 Thread Russell King - ARM Linux
On Tue, Nov 13, 2018 at 09:16:16AM +, Bich HEMON wrote: > > On 11/12/18 7:22 PM, Olof Johansson wrote: > > On Thu, Jul 27, 2017 at 04:50:20PM +, Bich HEMON wrote: > >> From: Gerald Baeza > >> > >> This adds low-level debug support on USART1 for STM32F4 > >> and STM32F7. > >> Compiled via

Re: [PATCH] ARM: stm32: debug: add low-level debug support

2018-11-13 Thread Russell King - ARM Linux
On Tue, Nov 13, 2018 at 09:16:16AM +, Bich HEMON wrote: > > On 11/12/18 7:22 PM, Olof Johansson wrote: > > On Thu, Jul 27, 2017 at 04:50:20PM +, Bich HEMON wrote: > >> From: Gerald Baeza > >> > >> This adds low-level debug support on USART1 for STM32F4 > >> and STM32F7. > >> Compiled via

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-13 Thread Russell King - ARM Linux
On Tue, Nov 13, 2018 at 02:39:00PM +1100, Finn Thain wrote: > On Mon, 12 Nov 2018, Christoph Hellwig wrote: > > > On Mon, Nov 12, 2018 at 03:12:39PM +1100, Finn Thain wrote: > > > Implementations of arch_gettimeoffset are generally not re-entrant and > > > assume that interrupts have been

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-13 Thread Russell King - ARM Linux
On Tue, Nov 13, 2018 at 02:39:00PM +1100, Finn Thain wrote: > On Mon, 12 Nov 2018, Christoph Hellwig wrote: > > > On Mon, Nov 12, 2018 at 03:12:39PM +1100, Finn Thain wrote: > > > Implementations of arch_gettimeoffset are generally not re-entrant and > > > assume that interrupts have been

Re: [PATCH v6 5/9] dt-bindings: ARM: document marvell,ecc-enable binding

2018-11-09 Thread Russell King - ARM Linux
On Fri, Nov 09, 2018 at 12:40:06PM +0100, Arnd Bergmann wrote: > On Fri, Nov 9, 2018 at 8:04 AM Chris Packham > wrote: > > > > Add documentation for the marvell,ecc-enable and marvell,ecc-disable > > properties which can be used to enable/disable ECC on the Marvell aurora > > cache. > > > >

Re: [PATCH v6 5/9] dt-bindings: ARM: document marvell,ecc-enable binding

2018-11-09 Thread Russell King - ARM Linux
On Fri, Nov 09, 2018 at 12:40:06PM +0100, Arnd Bergmann wrote: > On Fri, Nov 9, 2018 at 8:04 AM Chris Packham > wrote: > > > > Add documentation for the marvell,ecc-enable and marvell,ecc-disable > > properties which can be used to enable/disable ECC on the Marvell aurora > > cache. > > > >

Re: linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste error

2018-11-06 Thread Russell King - ARM Linux
On Tue, Nov 06, 2018 at 04:29:54PM +, Julien Thierry wrote: > Hi Russel, David, > > On 06/11/18 16:20, Russell King - ARM Linux wrote: > >On Mon, Nov 05, 2018 at 01:53:13PM +, David Binderman wrote: > >>Hello there, > >> > >>2nd try. Plain

Re: linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste error

2018-11-06 Thread Russell King - ARM Linux
On Tue, Nov 06, 2018 at 04:29:54PM +, Julien Thierry wrote: > Hi Russel, David, > > On 06/11/18 16:20, Russell King - ARM Linux wrote: > >On Mon, Nov 05, 2018 at 01:53:13PM +, David Binderman wrote: > >>Hello there, > >> > >>2nd try. Plain

<    4   5   6   7   8   9   10   11   12   13   >