[PATCH 1/4] HID: logitech-dj: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Mon, 5 Feb 2018 21:36:18 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-logitech-dj.c | 12 +++- 1 file changed, 3 in

[PATCH 0/4] HID: logitech-dj: Adjustments for some function implementations

From: Markus Elfring Date: Mon, 5 Feb 2018 22:22:11 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete an error message for a failed memory allocation in two functions Improve a size determination in four functions Combine su

Re: hid-sensor-accel-3d: Delete an error message for a failed memory allocation in hid_accel_3d_probe()

> If making changes like this I would suggest only sending one until > you have have a response from the relevant maintainer. The corresponding feedback can become more positive for such a transformation pattern after a while, can't it? > It would save you time as often these sorts of changes ar

[PATCH] HID: magicmouse: Delete an error message for a failed memory allocation in magicmouse_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 22:15:05 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-magicmouse.c | 4 +--- 1 file changed, 1 insertion(+),

[PATCH 2/2] HID: ntrig: Improve a size determination in ntrig_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:48:39 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was dete

[PATCH 1/2] HID: ntrig: Delete an error message for a failed memory allocation in ntrig_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:46:20 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-ntrig.c | 4 +--- 1 file changed, 1 insertion(+), 3 del

[PATCH 0/2] HID: N-Trig: Adjustments for ntrig_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:54:32 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/hid/hid-ntrig.c | 6 ++ 1 file chan

[PATCH 2/2] HID: picoLCD: Improve a size determination in picolcd_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 21:05:55 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was dete

[PATCH 1/2] HID: picoLCD: Delete an error message for a failed memory allocation in three functions

From: Markus Elfring Date: Sat, 3 Feb 2018 21:00:37 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-picolcd_core.c | 1 - drivers/hid/hid-picolcd_fb.c

[PATCH 0/2] HID-picoLCD: Adjustments for three function implementations

From: Markus Elfring Date: Sat, 3 Feb 2018 21:12:24 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in three functions Improve a size determination in picolcd_probe() drivers/h

[PATCH 6/6] hid-prodikeys: Rename a jump label in pcmidi_send_note()

From: Markus Elfring Date: Sat, 3 Feb 2018 18:10:00 +0100 An other label fits better to the jump target. Thus rename it. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-prodikeys.c b/drivers/h

[PATCH 5/6] hid-prodikeys: Combine two condition checks into one statement in pcmidi_send_note()

From: Markus Elfring Date: Sat, 3 Feb 2018 18:00:06 +0100 The same label was used by goto statements after two condition checks. Thus use a single statement instead. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff -

[PATCH 4/6] hid-prodikeys: Delete an unnecessary return statement in pcmidi_send_note()

From: Markus Elfring Date: Sat, 3 Feb 2018 17:33:40 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected function. Signed-off-by: Markus Elfring --- drivers/

[PATCH 3/6] hid-prodikeys: Move an assignment in pk_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 17:20:01 +0100 Move one assignment for a data structure member in one local variable so that its setting will only be performed after a corresponding memory allocation succeeded by this function. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodi

[PATCH 2/6] hid-prodikeys: Delete an unnecessary variable initialisation in pk_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 14:45:24 +0100 The local variable "pm" will eventually be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 2 +- 1 file changed, 1 insert

[PATCH 1/6] hid-prodikeys: Delete two error messages for a failed memory allocation in pk_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 14:36:20 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 5 + 1 file changed, 1 insertion(+), 4

[PATCH 0/6] HID-Prodikeys: Adjustments for two function implementations

From: Markus Elfring Date: Sat, 3 Feb 2018 18:21:23 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (6): Delete two error messages for a failed memory allocation in pk_probe() Delete an unnecessary variable initialisation in pk_probe()

[PATCH] hid-rmi: Delete an error message for a failed memory allocation in rmi_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 13:42:08 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-rmi.c | 4 +--- 1 file changed, 1 insertion(+), 3 delet

[PATCH] HID: Roccat: Delete an error message for a failed memory allocation in nine functions

From: Markus Elfring Date: Sat, 3 Feb 2018 11:45:15 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-roccat-arvo.c | 5 ++--- drivers/hid/hid-roccat-i

[PATCH] hid-saitek: Delete an error message for a failed memory allocation in saitek_probe()

From: Markus Elfring Date: Sat, 3 Feb 2018 09:12:24 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-saitek.c | 4 +--- 1 file changed, 1 insertion(+), 3 de

Re: Coccinelle: zalloc-simple: Checking consistency for SmPL rules

>> * Do we agree that a proper size determination is essential for every >> condition in the discussed SmPL rules together with forwarding >> this information? > > No. I don't mind a few false positives. Do you care to split SmPL rules by their confidence category in such an use case? Rega

[PATCH] hid-sony: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Fri, 2 Feb 2018 22:08:31 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-sony.c | 5 + 1 file changed, 1 insertion(+), 4 d

[PATCH] hid-zydacron: Delete an error message for a failed memory allocation in zc_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 21:41:37 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hid/hid-zydacron.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] hsi_char: Delete an error message for a failed memory allocation in hsc_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 21:21:12 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hsi/clients/hsi_char.c | 5 ++--- 1 file changed, 2 insertions(

[PATCH 0/2] HSI: ssi_protocol: Adjustments for two function implementations

From: Markus Elfring Date: Fri, 2 Feb 2018 21:03:45 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in ssi_protocol_probe() Fix a typo in two comment lines drivers/hsi/clients/

[PATCH 2/2] HSI: ssi_protocol: Fix a typo in two comment lines

From: Markus Elfring Date: Fri, 2 Feb 2018 20:57:23 +0100 Adjust two words in this description. Signed-off-by: Markus Elfring --- drivers/hsi/clients/ssi_protocol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients

[PATCH 1/2] HSI: ssi_protocol: Delete an error message for a failed memory allocation in ssi_protocol_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 20:02:17 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hsi/clients/ssi_protocol.c | 4 +--- 1 file changed, 1 insertio

[PATCH 2/2] i2c-bfin-twi: Improve a size determination in i2c_bfin_twi_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 19:01:14 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was dete

[PATCH 1/2] i2c-bfin-twi: Delete an error message for a failed memory allocation in i2c_bfin_twi_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:55:04 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-bfin-twi.c | 4 +--- 1 file changed, 1 insertion

[PATCH 0/2] I2C-Blackfin TWI: Adjustments for i2c_bfin_twi_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 19:09:08 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/i2c/busses/i2c-bfin-twi.c | 7 ++-

[PATCH 1/2] i2c-davinci: Delete an error message for a failed memory allocation in davinci_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:00:20 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-davinci.c | 4 +--- 1 file changed, 1 insertion(

[PATCH 2/2] i2c-davinci: Improve a size determination in davinci_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:02:49 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was dete

[PATCH 0/2] I2C-DaVinci: Adjustments for davinci_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 18:16:14 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/i2c/busses/i2c-davinci.c | 7 ++- 1

[PATCH] i2c-ibm_iic: Delete an error message for a failed memory allocation in iic_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 17:24:57 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-ibm_iic.c | 4 +--- 1 file changed, 1 insertion(

[PATCH 2/2] i2c-nomadik: Improve a size determination in nmk_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 16:28:20 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was dete

[PATCH 1/2] i2c-nomadik: Delete an error message for a failed memory allocation in nmk_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 16:25:14 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-nomadik.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 0/2] I2C-Nomadik: Adjustments for nmk_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 16:34:56 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/i2c/busses/i2c-nomadik.c | 3 +-- 1 fil

[PATCH 2/2] i2c-puv3: Improve a size determination in puv3_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:43:21 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was dete

[PATCH 1/2] i2c-puv3: Delete an error message for a failed memory allocation in puv3_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:41:26 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-puv3.c | 1 - 1 file changed, 1 deletion(-) dif

[PATCH 0/2] i2c-puv3: Adjustments for puv3_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:54:32 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/i2c/busses/i2c-puv3.c | 3 +-- 1 file c

[PATCH 2/2] i2c-sh7760: Improve a size determination in sh7760_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 14:50:09 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was dete

[PATCH 1/2] i2c-sh7760: Delete an error message for a failed memory allocation in sh7760_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 11:46:02 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-sh7760.c | 1 - 1 file changed, 1 deletion(-) d

[PATCH 0/2] i2c-sh7760: Adjustments for sh7760_i2c_probe()

From: Markus Elfring Date: Fri, 2 Feb 2018 15:18:29 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/i2c/busses/i2c-sh7760.c | 3 +-- 1 file

Re: Adjustments for a lot of function implementations

> One last time: either post per-driver patches with all the cleanups for a > driver > in a single patch, I preferred to offer source code adjustments according to specific transformation patterns mostly for each software module separately (also in small patch series). > or a per-directory pa

Re: Adjustments for a lot of function implementations

> ??? I did that: either one patch per directory with the same type of change, > or one patch per driver combining all the changes for that driver. Do any contributors get into the mood to take another look at software updates from my selection of change possibilities in a more constructive way?

[PATCH 2/2] i2c-tiny-usb: Return an error code only as a constant in i2c_tiny_usb_probe()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:45:21 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "error" and local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-ti

[PATCH 1/2] i2c-tiny-usb: Delete an error message for a failed memory allocation in i2c_tiny_usb_probe()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:36:50 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/busses/i2c-tiny-usb.c | 4 +--- 1 file changed, 1 insertion

[PATCH 0/2] i2c-tiny-usb: Adjustments for i2c_tiny_usb_probe()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:51:23 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Return an error code only as a constant drivers/i2c/busses/i2c-tiny-usb.c |

[PATCH] i2c-mux-reg: Delete an error message for a failed memory allocation in i2c_mux_reg_probe_dt()

From: Markus Elfring Date: Thu, 1 Feb 2018 17:17:19 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/i2c/muxes/i2c-mux-reg.c | 4 +--- 1 file changed, 1 insertion(+

Re: Coccinelle: reduce false positives

> +@safe depends on context || org || report exists@ > +expression x; > +position p; > +@@ > + > +( > + x = kmalloc(...) > +| > + x = kvasprintf(...) … * How do you think about to reduce also a bit of duplicate SmPL code? * Can it help to work with nested SmPL disjunctions here? Regards, Markus

Re: Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

>> * Do we agree that a proper size determination is essential for every >> condition in the discussed SmPL rules together with forwarding >> this information? > > No. I don't mind a few false positives. I have got other source code analysis expectations there. This SmPL script contains the

Re: Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

>> The function "kmem_cache_alloc" was specified despite of the technical >> detail that this function does not get a parameter passed which would >> correspond to such a size information. >> >> Thus remove it from the first two SmPL rules and omit the rule "r4". > > Nack. I find such a rejection

[PATCH] Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

From: Markus Elfring Date: Thu, 1 Feb 2018 10:20:47 +0100 The deletion for a call of the function "memset" depends on the specification that a size determination is passed by the expression "E1". The function "kmem_cache_alloc" was specified despite of the technical detail that this function does

[PATCH] hid-sensor-accel-3d: Delete an error message for a failed memory allocation in hid_accel_3d_probe()

From: Markus Elfring Date: Wed, 31 Jan 2018 22:20:56 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/accel/hid-sensor-accel-3d.c | 6 ++ 1 file changed, 2

[PATCH] iio/adc: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Wed, 31 Jan 2018 21:57:50 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/adc/at91_adc.c | 1 - drivers/iio/adc/max1027.c | 4 +--

[PATCH] hid-sensor-gyro-3d: Delete an error message for a failed memory allocation in hid_gyro_3d_probe()

From: Markus Elfring Date: Wed, 31 Jan 2018 21:36:53 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/gyro/hid-sensor-gyro-3d.c | 4 +--- 1 file changed, 1 inse

[PATCH] iio/light: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Wed, 31 Jan 2018 21:12:09 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/light/hid-sensor-als.c | 4 +--- drivers/iio/light/hid-

Re: [v2] Coccinelle: zalloc-simple: Delete function “kmem_cache_alloc” from SmPL rules

>> Will the rule set be more consistent then? > > If E1 is not bound by the kem_cache_alloc rule, then it will match anything. How much was such a software behaviour intended by the discussed SmPL script? > The user can check if it is appropriate. How does such an information fit to expectatio

Re: [v2] Coccinelle: zalloc-simple: Delete function “kmem_cache_alloc” from SmPL rules

> I removed the blank line at EOF, > then applied to linux-kbuild/misc. I have taken another look at this script for the semantic patch language. I imagined that I could refactor the shown SmPL disjunctions a bit. But I noticed then that these SmPL rules contain a development mistake. The deletio

[PATCH] iio/orientation: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Mon, 29 Jan 2018 22:20:07 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/orientation/hid-sensor-incl-3d.c | 4 +--- drivers/iio/

[PATCH] iio/pressure: Delete an error message for a failed memory allocation in hid_press_probe()

From: Markus Elfring Date: Mon, 29 Jan 2018 21:55:08 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/pressure/hid-sensor-press.c | 4 +--- 1 file changed, 1 in

Re: [0/3] IB-iSER: Adjustments for three function implementations

> Okay, applied to for-next, thanks both Thanks for your acceptance. How are the chances for integration of further software updates from my selection of change possibilities? Example: IB/iser: Add spaces for better code readability https://lkml.org/lkml/2017/4/7/667 https://patchwork.kernel.org

Re: mfd: Patch management?

>> I imagine that acceptance for these changes could be influenced >> also by review comments from other contributors. > > Influenced yes, but I will also need to review them. Yes. - This is the usual process. > You can't 'go around' me, if that's what you're thinking. I do not think this. - I

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

> You don't need 2 patches when changing same lines of code. Are these really the same? > Could you squash both and send your changes in a single patch. I prefer to keep the deletion of questionable error messages separate from the refactoring for a bit of exception handling. > The patches lo

[PATCH 3/3] RDMA/iwpm: Improve a size determination in two functions

From: Markus Elfring Date: Sat, 27 Jan 2018 22:05:54 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detec

[PATCH 2/3] RDMA/iwpm: Adjust a variable initialisation in iwpm_create_nlmsg()

From: Markus Elfring Date: Sat, 27 Jan 2018 21:56:54 +0100 The local variable "skb" will be reassigned by a following statement. Thus adjust the initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/infiniband/core/iwpm_util.c | 3 +-- 1 file changed, 1 insertion(+), 2 del

[PATCH 1/3] RDMA/iwpm: Delete an error message for a failed memory allocation in iwpm_create_nlmsg()

From: Markus Elfring Date: Sat, 27 Jan 2018 21:48:01 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/infiniband/core/iwpm_util.c | 5 ++--- 1 file changed, 2 inser

[PATCH 0/3] RDMA/iwpm: Adjustments for three function implementations

From: Markus Elfring Date: Sat, 27 Jan 2018 22:12:34 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in iwpm_create_nlmsg() Adjust a variable initialisation in iwpm_create_nlms

[PATCH 2/2] RDMA/bnxt_re: Use common error handling code in bnxt_qplib_alloc_dpi_tbl()

From: Markus Elfring Date: Sat, 27 Jan 2018 20:56:56 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/bnxt_re/qplib_res.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH 1/2] RDMA/bnxt_re: Delete two error messages for a failed memory allocation in bnxt_qplib_alloc_dpi_tbl()

From: Markus Elfring Date: Sat, 27 Jan 2018 20:40:11 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/bnxt_re/qplib_res.c | 5 - 1 file changed, 5 d

[PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

From: Markus Elfring Date: Sat, 27 Jan 2018 21:10:12 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Use common error handling code drivers/infiniband/hw/bnxt_re/qplib_res.c

[PATCH] IB/usnic: Delete an error message for a failed memory allocation in usnic_transport_init()

From: Markus Elfring Date: Sat, 27 Jan 2018 20:06:59 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/usnic/usnic_transport.c | 4 +--- 1 file changed

[PATCH 3/3] IB/iser: Combine substrings for three messages

From: Markus Elfring Date: Sat, 27 Jan 2018 18:25:37 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/infiniband/ulp/iser/iser_initiator.c

[PATCH 2/3] IB/iser: Delete an unnecessary variable initialisation in iser_send_data_out()

From: Markus Elfring Date: Sat, 27 Jan 2018 17:55:13 +0100 The variable "tx_desc" will be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/infiniband/ulp/iser/iser_initiator.c | 2 +- 1 file changed, 1

[PATCH 1/3] IB/iser: Delete an error message for a failed memory allocation in iser_send_data_out()

From: Markus Elfring Date: Sat, 27 Jan 2018 17:48:47 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/infiniband/ulp/iser/iser_initiator.c | 4 +--- 1 file changed,

[PATCH 0/3] IB-iSER: Adjustments for three function implementations

From: Markus Elfring Date: Sat, 27 Jan 2018 19:02:34 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in iser_send_data_out() Delete an unnecessary variable initialisation in is

[PATCH 2/2] Input: gamecon: Improve a size determination in gc_attach()

From: Markus Elfring Date: Sat, 27 Jan 2018 16:30:58 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 1/2] Input: gamecon: Delete an error message for a failed memory allocation in gc_attach()

From: Markus Elfring Date: Sat, 27 Jan 2018 16:27:11 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/joystick/gamecon.c | 4 +--- 1 file changed, 1 insertion

[PATCH 0/2] input/joystick/gamecon: Adjustments for gc_attach()

From: Markus Elfring Date: Sat, 27 Jan 2018 17:07:27 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/input/joystick/gamecon.c | 6 ++ 1

[PATCH 2/2] Input: turbografx: Improve a size determination in tgfx_attach()

From: Markus Elfring Date: Sat, 27 Jan 2018 15:46:24 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 1/2] Input: turbografx: Delete an error message for a failed memory allocation in tgfx_attach()

From: Markus Elfring Date: Sat, 27 Jan 2018 15:43:38 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/joystick/turbografx.c | 4 +--- 1 file changed, 1 insert

[PATCH 0/2] Input-TurboGraFX: Adjustments for tgfx_attach()

From: Markus Elfring Date: Sat, 27 Jan 2018 15:55:44 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/input/joystick/turbografx.c | 6 ++

[PATCH] Input: adp5520-keys: Delete an error message for a failed memory allocation in adp5520_keys_probe()

From: Markus Elfring Date: Sat, 27 Jan 2018 15:15:52 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/adp5520-keys.c | 4 +--- 1 file changed, 1 inse

[PATCH] Input: gpio_keys: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Sat, 27 Jan 2018 14:42:19 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/gpio_keys.c| 4 +--- drivers/input/ke

[PATCH] Input: imx_keypad: Delete an error message for a failed memory allocation in imx_keypad_probe()

From: Markus Elfring Date: Sat, 27 Jan 2018 14:14:04 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/imx_keypad.c | 4 +--- 1 file changed, 1 insert

[PATCH 2/2] Input: matrix_keypad: Improve a size determination in matrix_keypad_probe()

From: Markus Elfring Date: Sat, 27 Jan 2018 13:43:16 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 1/2] Input: matrix_keypad: Delete two error messages for a failed memory allocation in matrix_keypad_parse_dt()

From: Markus Elfring Date: Sat, 27 Jan 2018 13:35:02 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/matrix_keypad.c | 8 ++-- 1 file changed, 2 i

[PATCH 0/2] Input: matrix_keypad: Adjustments for two function implementations

From: Markus Elfring Date: Sat, 27 Jan 2018 13:48:42 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation in matrix_keypad_parse_dt() Improve a size determination in matrix_keyp

[PATCH 2/2] Input: max7359_keypad: Improve a size determination in max7359_probe()

From: Markus Elfring Date: Sat, 27 Jan 2018 13:00:10 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 1/2] Input: max7359_keypad: Delete an error message for a failed memory allocation in max7359_probe()

From: Markus Elfring Date: Sat, 27 Jan 2018 12:56:25 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/max7359_keypad.c | 4 +--- 1 file changed, 1 in

[PATCH 0/2] Input: max7359_keypad: Adjustments for max7359_probe()

From: Markus Elfring Date: Sat, 27 Jan 2018 13:08:24 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/input/keyboard/max7359_keypad.c | 8 ++

[PATCH 2/2] Input: nspire-keypad: Improve a size determination in nspire_keypad_probe()

From: Markus Elfring Date: Sat, 27 Jan 2018 10:36:20 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 1/2] Input: nspire-keypad: Delete an error message for a failed memory allocation in nspire_keypad_probe()

From: Markus Elfring Date: Sat, 27 Jan 2018 10:33:37 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/nspire-keypad.c | 4 +--- 1 file changed, 1 ins

[PATCH 0/2] Input: nspire-keypad: Adjustments for nspire_keypad_probe()

From: Markus Elfring Date: Sat, 27 Jan 2018 10:48:28 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/input/keyboard/nspire-keypad.c | 7 ++-

Re: mfd: Patch management?

>> I am curious if more positive feedback could evolve till then. >> I would appreciate if a potentially needed resend for my selection >> of update suggestions could become smaller (when reviewed steps >> could be already integrated for example). > > I'm not entirely sure what you're trying to sa

[PATCH 2/2] Input: omap4-keypad: Improve a size determination in omap4_keypad_probe()

From: Markus Elfring Date: Fri, 26 Jan 2018 14:28:07 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 1/2] Input: omap4-keypad: Delete two error messages for a failed memory allocation in omap4_keypad_probe()

From: Markus Elfring Date: Fri, 26 Jan 2018 14:24:35 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/omap4-keypad.c | 5 + 1 file changed, 1 inser

[PATCH 0/2] Input: omap4-keypad: Adjustments for omap4_keypad_probe()

From: Markus Elfring Date: Fri, 26 Jan 2018 14:45:54 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Improve a size determination drivers/input/keyboard/omap4-keypad.c | 7 ++

[PATCH] Input: pxa27x_keypad: Delete an error message for a failed memory allocation

From: Markus Elfring Date: Thu, 25 Jan 2018 22:15:27 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/pxa27x_keypad.c | 4 +--- 1 file changed, 1 ins

[PATCH] Input: sh_keysc: Delete an error message for a failed memory allocation in sh_keysc_probe()

From: Markus Elfring Date: Thu, 25 Jan 2018 22:02:46 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/sh_keysc.c | 1 - 1 file changed, 1 deletion(-)

<    1   2   3   4   5   6   7   8   9   10   >