Re: linux-next: build failures after merge of the drm tree
On Sun, Aug 10, 2014 at 1:28 PM, Dave Airlie wrote: >> > > Been on holidays, but ack for anything DT related, > > Look I wishI knew how DT worked, and what tree is canonical for changes to > it, I'm not sure its well defined enough or sub maintaniers know enough, > so I do just trust the exynos guys with this. > Inki, Can you please get your tree included in linux-next so that these kind of issues could be detected much earlier (even before they hit Dave's tree)? -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] usb: ehci/ohci-exynos: Fix PHY getting sequence
Hi Vivek, On Tue, Aug 5, 2014 at 4:09 PM, Vivek Gautam wrote: > Since we want to keep support for both older usb-phys as well as the > newer generic phys, lets first get the generic PHYs and fallback to > older USB-PHYs only when we fail to get the former. > This should fix the issue with ehci-exynos and ohci-exynos, wherein > in the absence of SAMSUNG_USB2PHY config symbol, we end up getting > the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs > are not configured properly. > > Reported-by: Sachin Kamat > Signed-off-by: Vivek Gautam > Cc: Alan Stern > Cc: Jingoo Han Tested this patch on Exynos5250 based Arndale and Snow boards. Fixes the said issue. Thanks. Tested-by: Sachin Kamat -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] MAINTAINERS: Update Samsung pin control entry
On Fri, Jul 11, 2014 at 3:41 PM, Tomasz Figa wrote: > On 11.07.2014 11:57, Sachin Kamat wrote: >> + Tomasz >> >> Sorry for missing the maintainer himself :) >> >> On Fri, Jul 11, 2014 at 2:29 PM, Sachin Kamat >> wrote: >>> Update to reflect the recent file movement to a sub-directory. >>> >>> Signed-off-by: Sachin Kamat >>> --- >>> MAINTAINERS |4 +--- >>> 1 file changed, 1 insertion(+), 3 deletions(-) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index e3a517635eb4..898cf76f8837 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -6943,9 +6943,7 @@ M:Thomas Abraham >>> L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) >>> L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers) >>> S: Maintained >>> -F: drivers/pinctrl/pinctrl-exynos.* >>> -F: drivers/pinctrl/pinctrl-s3c* >>> -F: drivers/pinctrl/pinctrl-samsung.* >>> +F: drivers/pinctrl/samsung/ >>> >>> PIN CONTROLLER - ST SPEAR >>> M: Viresh Kumar >>> -- >>> 1.7.9.5 >>> >> > > Acked-by: Tomasz Figa Linus, Gentle ping :) -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc
Hi Pramod,
On Fri, Jul 25, 2014 at 2:42 PM, wrote:
> From: Pramod Gurav
>
> This patch does below:
> - Removes kfree done on data allocated with devm_zalloc in probe
> path of the driver.
> - Adds a check on return value from devm_kzalloc which was missing
> - Removes the error lables and instead releases resources and returns
> after failures
>
> CC: Dmitry Torokhov
> CC: Lejun Zhu
> CC: Sachin Kamat
>
> Signed-off-by: Pramod Gurav
> ---
>
> Changes since v1:
> - Removes de_err logs on OOM cases which is not needed.
>
> drivers/input/misc/soc_button_array.c | 27 +++
> 1 file changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/input/misc/soc_button_array.c
> b/drivers/input/misc/soc_button_array.c
> index 5a6334b..f421cf4 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -83,6 +83,11 @@ soc_button_device_create(struct pnp_dev *pdev,
>sizeof(*gpio_keys_pdata) +
> sizeof(*gpio_keys) * MAX_NBUTTONS,
>GFP_KERNEL);
> + if (!gpio_keys_pdata) {
> + error = -ENOMEM;
> + return ERR_PTR(error);
You don't need a variable here. You could directly do:
return ERR_PTR(-ENOMEM);
> + }
> +
> gpio_keys = (void *)(gpio_keys_pdata + 1);
>
> for (info = button_info; info->name; info++) {
> @@ -104,7 +109,7 @@ soc_button_device_create(struct pnp_dev *pdev,
>
> if (n_buttons == 0) {
> error = -ENODEV;
> - goto err_free_mem;
> + return ERR_PTR(error);
ditto
> }
>
> gpio_keys_pdata->buttons = gpio_keys;
> @@ -114,25 +119,23 @@ soc_button_device_create(struct pnp_dev *pdev,
> pd = platform_device_alloc("gpio-keys", PLATFORM_DEVID_AUTO);
> if (!pd) {
> error = -ENOMEM;
> - goto err_free_mem;
> + return ERR_PTR(error);
ditto
> }
>
> error = platform_device_add_data(pd, gpio_keys_pdata,
> sizeof(*gpio_keys_pdata));
> - if (error)
> - goto err_free_pdev;
This goto could be retained to avoid code duplication.
> + if (error) {
> + platform_device_put(pd);
> + return ERR_PTR(error);
> + }
>
> error = platform_device_add(pd);
> - if (error)
> - goto err_free_pdev;
ditto
> + if (error) {
> + platform_device_put(pd);
> + return ERR_PTR(error);
> + }
>
> return pd;
> -
> -err_free_pdev:
> - platform_device_put(pd);
> -err_free_mem:
> - devm_kfree(&pdev->dev, gpio_keys_pdata);
> - return ERR_PTR(error);
> }
>
> static void soc_button_remove(struct pnp_dev *pdev)
> --
> 1.7.9.5
>
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc
On Fri, Jul 25, 2014 at 12:39 PM, wrote:
> From: Pramod Gurav
>
> This patch does below:
> - Removes kfree done on data allocated with devm_zalloc in probe
> path of the driver.
> - Adds a check on return value from devm_kzalloc which was missing
> and renames a lable from err_free_mem to err_mem.
> - Adds couple of dev_err on failure to allocate memory
>
> CC: Dmitry Torokhov
> CC: Lejun Zhu
> CC: Sachin Kamat
>
> Signed-off-by: Pramod Gurav
> ---
> drivers/input/misc/soc_button_array.c | 19 ++-
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/misc/soc_button_array.c
> b/drivers/input/misc/soc_button_array.c
> index 5a6334b..ac82971 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -83,6 +83,13 @@ soc_button_device_create(struct pnp_dev *pdev,
>sizeof(*gpio_keys_pdata) +
> sizeof(*gpio_keys) * MAX_NBUTTONS,
>GFP_KERNEL);
> + if (!gpio_keys_pdata) {
> + dev_err(&pdev->dev,
> + "Can't allocate memory for
> gpio_keys_platform_data\n");
OOM message is not needed as memory subsystem will take care of it.
> + error = -ENOMEM;
> + goto err_mem;
Return directly from here.
> + }
> +
> gpio_keys = (void *)(gpio_keys_pdata + 1);
>
> for (info = button_info; info->name; info++) {
> @@ -104,7 +111,7 @@ soc_button_device_create(struct pnp_dev *pdev,
>
> if (n_buttons == 0) {
> error = -ENODEV;
> - goto err_free_mem;
> + goto err_mem;
ditto
> }
>
> gpio_keys_pdata->buttons = gpio_keys;
> @@ -114,7 +121,7 @@ soc_button_device_create(struct pnp_dev *pdev,
> pd = platform_device_alloc("gpio-keys", PLATFORM_DEVID_AUTO);
> if (!pd) {
> error = -ENOMEM;
> - goto err_free_mem;
> + goto err_mem;
ditto
> }
>
> error = platform_device_add_data(pd, gpio_keys_pdata,
> @@ -130,8 +137,7 @@ soc_button_device_create(struct pnp_dev *pdev,
>
> err_free_pdev:
> platform_device_put(pd);
> -err_free_mem:
> - devm_kfree(&pdev->dev, gpio_keys_pdata);
> +err_mem:
This label would not be required once returned directly from above.
> return ERR_PTR(error);
> }
>
> @@ -155,8 +161,11 @@ static int soc_button_pnp_probe(struct pnp_dev *pdev,
> int error;
>
> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> - if (!priv)
> + if (!priv) {
> + dev_err(&pdev->dev,
> + "Can't allocate memory for soc_button_data\n");
OOM message is not needed as memory subsystem will take care of it.
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH Resend 2/2] mfd: tps65912-spi: Remove unused variable
‘rx_buf’ is not used in this function. Signed-off-by: Sachin Kamat --- drivers/mfd/tps65912-spi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c index 69a5178bf152..de60ad98bd9f 100644 --- a/drivers/mfd/tps65912-spi.c +++ b/drivers/mfd/tps65912-spi.c @@ -32,10 +32,9 @@ static int tps65912_spi_write(struct tps65912 *tps65912, u8 addr, unsigned long spi_data = 1 << 23 | addr << 15 | *data; struct spi_transfer xfer; struct spi_message msg; - u32 tx_buf, rx_buf; + u32 tx_buf; tx_buf = spi_data; - rx_buf = 0; xfer.tx_buf = &tx_buf; xfer.rx_buf = NULL; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2 Resend] mfd: htc-i2cpld: Remove unused code
Removed code unused in this function.
Signed-off-by: Sachin Kamat
Cc: Cory Maccarrone
---
Compile tested.
---
drivers/mfd/htc-i2cpld.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index d7b2a75aca3e..b44f0203983b 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -332,18 +332,13 @@ static int htcpld_setup_chip_irq(
int chip_index)
{
struct htcpld_data *htcpld;
- struct device *dev = &pdev->dev;
- struct htcpld_core_platform_data *pdata;
struct htcpld_chip *chip;
- struct htcpld_chip_platform_data *plat_chip_data;
unsigned int irq, irq_end;
int ret = 0;
/* Get the platform and driver data */
- pdata = dev_get_platdata(dev);
htcpld = platform_get_drvdata(pdev);
chip = &htcpld->chip[chip_index];
- plat_chip_data = &pdata->chip[chip_index];
/* Setup irq handlers */
irq_end = chip->irq_start + chip->nirqs;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/4 v2] iio: exyno-adc: use syscon for PMU register access
Hi Naveen, On Thu, Jul 17, 2014 at 4:49 PM, Naveen Krishna Chatradhi wrote: > This patch updates the IIO based ADC driver to use syscon and regmap > APIs to access and use PMU registers instead of remapping the PMU > registers in the driver. > > Signed-off-by: Naveen Krishna Chatradhi > To: linux-...@vger.kernel.org With only this patch applied, I believe the ADC functionality would be broken. Perhaps the DT changes should be merged along with this patch? -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs
Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and USB gadget controller supported by the DWC2 gadget driver, make it depend on them and default to ARCH_EXYNOS as they are meant for Exynos platforms. Also, make the sub-drivers silent options enabling them based on the SoC platforms that they are meant to work with. This will make life easier for end users who do not have any way knowing the dependencies. Signed-off-by: Sachin Kamat Reviewed-by: Jingoo Han --- Changes since v3: * Rebased the series on top of latest PHY tree [1]. [1] git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git --- drivers/phy/Kconfig | 35 +++ 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 5fceb33..c412ca4 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -132,43 +132,30 @@ config PHY_SUN4I_USB config PHY_SAMSUNG_USB2 tristate "Samsung USB 2.0 PHY driver" depends on HAS_IOMEM + depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2 select GENERIC_PHY select MFD_SYSCON + default ARCH_EXYNOS help Enable this to support the Samsung USB 2.0 PHY driver for Samsung - SoCs. This driver provides the interface for USB 2.0 PHY. Support for - particular SoCs has to be enabled in addition to this driver. Number - and type of supported phys depends on the SoC. + SoCs. This driver provides the interface for USB 2.0 PHY. Support + for particular PHYs will be enabled based on the SoC type in addition + to this driver. config PHY_EXYNOS4210_USB2 - bool "Support for Exynos 4210" + bool depends on PHY_SAMSUNG_USB2 - depends on CPU_EXYNOS4210 - help - Enable USB PHY support for Exynos 4210. This option requires that - Samsung USB 2.0 PHY driver is enabled and means that support for this - particular SoC is compiled in the driver. In case of Exynos 4210 four - phys are available - device, host, HSIC0 and HSIC1. + default CPU_EXYNOS4210 config PHY_EXYNOS4X12_USB2 - bool "Support for Exynos 3250/4x12" + bool depends on PHY_SAMSUNG_USB2 - depends on (SOC_EXYNOS3250 || SOC_EXYNOS4212 || SOC_EXYNOS4412) - help - Enable USB PHY support for Exynos 3250/4x12. This option requires - that Samsung USB 2.0 PHY driver is enabled and means that support for - this particular SoC is compiled in the driver. In case of Exynos 4x12 - four phys are available - device, host, HSIC0 and HSIC1. + default SOC_EXYNOS3250 || SOC_EXYNOS4212 || SOC_EXYNOS4412 config PHY_EXYNOS5250_USB2 - bool "Support for Exynos 5250" + bool depends on PHY_SAMSUNG_USB2 - depends on SOC_EXYNOS5250 - help - Enable USB PHY support for Exynos 5250. This option requires that - Samsung USB 2.0 PHY driver is enabled and means that support for this - particular SoC is compiled in the driver. In case of Exynos 5250 four - phys are available - device, host, HSIC0 and HSIC. + default SOC_EXYNOS5250 || SOC_EXYNOS5420 config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] phy: Kconfig: Update config for Exynos USB DRD
USB DWC3 driver on Exynos platform does not work without its corresponding phy driver. Hence make the PHY driver depend on Exynos DWC3 driver and default it to yes to make things easier for the end user. Signed-off-by: Sachin Kamat Reviewed-by: Jingoo Han --- drivers/phy/Kconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index c412ca4..c730e85 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -161,8 +161,10 @@ config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" depends on ARCH_EXYNOS5 && OF depends on HAS_IOMEM + depends on USB_DWC3_EXYNOS select GENERIC_PHY select MFD_SYSCON + default y help Enable USB DRD PHY support for Exynos 5 SoC series. This driver provides PHY interface for USB 3.0 DRD controller -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs
On Mon, Jul 14, 2014 at 2:39 PM, Kishon Vijay Abraham I wrote: > > > On Monday 14 July 2014 02:36 PM, Sachin Kamat wrote: >> On Mon, Jul 14, 2014 at 2:32 PM, Kishon Vijay Abraham I >> wrote: >>> >>> >>> On Monday 14 July 2014 02:29 PM, Sachin Kamat wrote: >>>> Hi, >>>> >>>> On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I >>>> wrote: >>>>> Hi, >>>>> >>>>> On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote: >>>>>> Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and >>>>>> USB gadget controller supported by the DWC2 gadget driver, make it >>>>>> depend on them and default to ARCH_EXYNOS as they are meant for >>>>>> Exynos platforms. Also, make the sub-drivers silent options enabling >>>>>> them based on the SoC platforms that they are meant to work with. This >>>>>> will make life easier for end users who do not have any way knowing the >>>>>> dependencies. >>>>> >>>>> There is a new Exynos PHY in town, Exynos 3250. Can you rebase your patch >>>>> on >>>>> top of that? >>>> >>>> Sure. But I did not see it in linux-next yet. Is it merged somewhere? >>> >>> It's in the list. I can push it to my tree if that helps. >> >> That would be great to avoid any other conflicts. > > pushed to git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git > next. You can use it to rebase your patch. Thanks. I will re-spin on top of it. -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs
On Mon, Jul 14, 2014 at 2:32 PM, Kishon Vijay Abraham I wrote: > > > On Monday 14 July 2014 02:29 PM, Sachin Kamat wrote: >> Hi, >> >> On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I >> wrote: >>> Hi, >>> >>> On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote: >>>> Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and >>>> USB gadget controller supported by the DWC2 gadget driver, make it >>>> depend on them and default to ARCH_EXYNOS as they are meant for >>>> Exynos platforms. Also, make the sub-drivers silent options enabling >>>> them based on the SoC platforms that they are meant to work with. This >>>> will make life easier for end users who do not have any way knowing the >>>> dependencies. >>> >>> There is a new Exynos PHY in town, Exynos 3250. Can you rebase your patch on >>> top of that? >> >> Sure. But I did not see it in linux-next yet. Is it merged somewhere? > > It's in the list. I can push it to my tree if that helps. That would be great to avoid any other conflicts. -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs
Hi, On Mon, Jul 14, 2014 at 2:26 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 09 July 2014 05:19 PM, Sachin Kamat wrote: >> Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and >> USB gadget controller supported by the DWC2 gadget driver, make it >> depend on them and default to ARCH_EXYNOS as they are meant for >> Exynos platforms. Also, make the sub-drivers silent options enabling >> them based on the SoC platforms that they are meant to work with. This >> will make life easier for end users who do not have any way knowing the >> dependencies. > > There is a new Exynos PHY in town, Exynos 3250. Can you rebase your patch on > top of that? Sure. But I did not see it in linux-next yet. Is it merged somewhere? -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] mfd: tps65912-spi: Remove unused variable
‘rx_buf’ is not used in this function. Signed-off-by: Sachin Kamat --- drivers/mfd/tps65912-spi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c index 69a5178bf152..de60ad98bd9f 100644 --- a/drivers/mfd/tps65912-spi.c +++ b/drivers/mfd/tps65912-spi.c @@ -32,10 +32,9 @@ static int tps65912_spi_write(struct tps65912 *tps65912, u8 addr, unsigned long spi_data = 1 << 23 | addr << 15 | *data; struct spi_transfer xfer; struct spi_message msg; - u32 tx_buf, rx_buf; + u32 tx_buf; tx_buf = spi_data; - rx_buf = 0; xfer.tx_buf = &tx_buf; xfer.rx_buf = NULL; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] mfd: htc-i2cpld: Remove unused code
Removed code unused in this function.
Signed-off-by: Sachin Kamat
---
Compile tested.
---
drivers/mfd/htc-i2cpld.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index d7b2a75aca3e..b44f0203983b 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -332,18 +332,13 @@ static int htcpld_setup_chip_irq(
int chip_index)
{
struct htcpld_data *htcpld;
- struct device *dev = &pdev->dev;
- struct htcpld_core_platform_data *pdata;
struct htcpld_chip *chip;
- struct htcpld_chip_platform_data *plat_chip_data;
unsigned int irq, irq_end;
int ret = 0;
/* Get the platform and driver data */
- pdata = dev_get_platdata(dev);
htcpld = platform_get_drvdata(pdev);
chip = &htcpld->chip[chip_index];
- plat_chip_data = &pdata->chip[chip_index];
/* Setup irq handlers */
irq_end = chip->irq_start + chip->nirqs;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] MAINTAINERS: Update Samsung pin control entry
+ Tomasz Sorry for missing the maintainer himself :) On Fri, Jul 11, 2014 at 2:29 PM, Sachin Kamat wrote: > Update to reflect the recent file movement to a sub-directory. > > Signed-off-by: Sachin Kamat > --- > MAINTAINERS |4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e3a517635eb4..898cf76f8837 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6943,9 +6943,7 @@ M:Thomas Abraham > L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers) > S: Maintained > -F: drivers/pinctrl/pinctrl-exynos.* > -F: drivers/pinctrl/pinctrl-s3c* > -F: drivers/pinctrl/pinctrl-samsung.* > +F: drivers/pinctrl/samsung/ > > PIN CONTROLLER - ST SPEAR > M: Viresh Kumar > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] Documentation: dt-bindings: move exynos-adc.txt to more iio/adc/
Hi Naveen, On Fri, Jul 11, 2014 at 2:36 PM, Naveen Krishna Chatradhi wrote: > The DT bindings in exynos-adc.txt applies to the ADC > driver (exynos-adc.c) developed based on IIO framework. > > The bindings are more appropriate to be under > Documentation/devicetree/bindings/iio/adc/ > > Signed-off-by: Naveen Krishna Chatradhi > To: devicet...@vger.kernel.org > --- > .../devicetree/bindings/arm/samsung/exynos-adc.txt | 82 > > .../devicetree/bindings/iio/adc/exynos-adc.txt | 82 > > 2 files changed, 82 insertions(+), 82 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt > create mode 100644 Documentation/devicetree/bindings/iio/adc/exynos-adc.txt > Tip: For only a file move or rename please use "-M" with git format-patch. That will make the patch concise. -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] MAINTAINERS: Update Samsung pin control entry
Update to reflect the recent file movement to a sub-directory. Signed-off-by: Sachin Kamat --- MAINTAINERS |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e3a517635eb4..898cf76f8837 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6943,9 +6943,7 @@ M:Thomas Abraham L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers) S: Maintained -F: drivers/pinctrl/pinctrl-exynos.* -F: drivers/pinctrl/pinctrl-s3c* -F: drivers/pinctrl/pinctrl-samsung.* +F: drivers/pinctrl/samsung/ PIN CONTROLLER - ST SPEAR M: Viresh Kumar -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to improve bootup time
Hi Wolfram, On Thu, Jul 10, 2014 at 5:16 PM, Wolfram Sang wrote: > This driver has been flagged to drop class based instantiation. The removal > improves boot-up time and is unneeded for embedded controllers. Users have > been > warned to switch for some time now, so we can actually do the removal. Keep > the > DEPRECATED flag, so the core can inform users that the behaviour finally > changed now. After another transition period, this flag can go, too. > While we are here, remove the indentation for the array setup because > such things always break after some time. > > Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/i2c-s3c2410.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c > b/drivers/i2c/busses/i2c-s3c2410.c > index e828a1dba0e5..6252c051525a 100644 > --- a/drivers/i2c/busses/i2c-s3c2410.c > +++ b/drivers/i2c/busses/i2c-s3c2410.c > @@ -1128,11 +1128,11 @@ static int s3c24xx_i2c_probe(struct platform_device > *pdev) > s3c24xx_i2c_parse_dt(pdev->dev.of_node, i2c); > > strlcpy(i2c->adap.name, "s3c2410-i2c", sizeof(i2c->adap.name)); > - i2c->adap.owner = THIS_MODULE; > - i2c->adap.algo= &s3c24xx_i2c_algorithm; > + i2c->adap.owner = THIS_MODULE; > + i2c->adap.algo = &s3c24xx_i2c_algorithm; > i2c->adap.retries = 2; > - i2c->adap.class = I2C_CLASS_HWMON | I2C_CLASS_SPD | > I2C_CLASS_DEPRECATED; > - i2c->tx_setup = 50; > + i2c->adap.class = I2C_CLASS_DEPRECATED; > + i2c->tx_setup = 50; > > init_waitqueue_head(&i2c->wait); > > -- Tested on Exynos 5250 boards. Tested-by: Sachin Kamat -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] pinctrl: samsung: Group all drivers in a sub-dir
Group all pin control drivers of Samsung platform together in
a sub-directory for easy maintenance.
Signed-off-by: Sachin Kamat
---
This patch has been inspired by a similar patch [1] from Linus Walleij for
Qualcomm drivers. I have boot tested this patch on Exynos boards and
compile tested for other Samsung platforms.
[1] http://www.spinics.net/lists/arm-kernel/msg345924.html
---
drivers/pinctrl/Kconfig| 27 +--
drivers/pinctrl/Makefile |6 +
drivers/pinctrl/samsung/Kconfig| 28
drivers/pinctrl/samsung/Makefile |7 +
drivers/pinctrl/{ => samsung}/pinctrl-exynos.c |0
drivers/pinctrl/{ => samsung}/pinctrl-exynos.h |0
drivers/pinctrl/{ => samsung}/pinctrl-exynos5440.c |2 +-
drivers/pinctrl/{ => samsung}/pinctrl-s3c24xx.c|0
drivers/pinctrl/{ => samsung}/pinctrl-s3c64xx.c|0
drivers/pinctrl/{ => samsung}/pinctrl-samsung.c|2 +-
drivers/pinctrl/{ => samsung}/pinctrl-samsung.h|0
11 files changed, 39 insertions(+), 33 deletions(-)
create mode 100644 drivers/pinctrl/samsung/Kconfig
create mode 100644 drivers/pinctrl/samsung/Makefile
rename drivers/pinctrl/{ => samsung}/pinctrl-exynos.c (100%)
rename drivers/pinctrl/{ => samsung}/pinctrl-exynos.h (100%)
rename drivers/pinctrl/{ => samsung}/pinctrl-exynos5440.c (99%)
rename drivers/pinctrl/{ => samsung}/pinctrl-s3c24xx.c (100%)
rename drivers/pinctrl/{ => samsung}/pinctrl-s3c64xx.c (100%)
rename drivers/pinctrl/{ => samsung}/pinctrl-samsung.c (99%)
rename drivers/pinctrl/{ => samsung}/pinctrl-samsung.h (100%)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 2744fa2825e0..f8bf9d80fc1a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -363,22 +363,6 @@ config PINCTRL_COH901
COH 901 335 and COH 901 571/3. They contain 3, 5 or 7
ports of 8 GPIO pins each.
-config PINCTRL_SAMSUNG
- bool
- select PINMUX
- select PINCONF
-
-config PINCTRL_EXYNOS
- bool "Pinctrl driver data for Samsung EXYNOS SoCs other than 5440"
- depends on OF && GPIOLIB && (ARCH_EXYNOS || ARCH_S5PV210)
- select PINCTRL_SAMSUNG
-
-config PINCTRL_EXYNOS5440
- bool "Samsung EXYNOS5440 SoC pinctrl driver"
- depends on SOC_EXYNOS5440
- select PINMUX
- select PINCONF
-
config PINCTRL_PALMAS
bool "Pinctrl driver for the PALMAS Series MFD devices"
depends on OF && MFD_PALMAS
@@ -390,18 +374,9 @@ config PINCTRL_PALMAS
open drain configuration for the Palmas series devices like
TPS65913, TPS80036 etc.
-config PINCTRL_S3C24XX
- bool "Samsung S3C24XX SoC pinctrl driver"
- depends on ARCH_S3C24XX
- select PINCTRL_SAMSUNG
-
-config PINCTRL_S3C64XX
- bool "Samsung S3C64XX SoC pinctrl driver"
- depends on ARCH_S3C64XX
- select PINCTRL_SAMSUNG
-
source "drivers/pinctrl/berlin/Kconfig"
source "drivers/pinctrl/mvebu/Kconfig"
+source "drivers/pinctrl/samsung/Kconfig"
source "drivers/pinctrl/sh-pfc/Kconfig"
source "drivers/pinctrl/spear/Kconfig"
source "drivers/pinctrl/sunxi/Kconfig"
diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
index c7d8f1b7311f..2ee910dbfe36 100644
--- a/drivers/pinctrl/Makefile
+++ b/drivers/pinctrl/Makefile
@@ -60,11 +60,6 @@ obj-$(CONFIG_PINCTRL_TZ1090) += pinctrl-tz1090.o
obj-$(CONFIG_PINCTRL_TZ1090_PDC) += pinctrl-tz1090-pdc.o
obj-$(CONFIG_PINCTRL_U300) += pinctrl-u300.o
obj-$(CONFIG_PINCTRL_COH901) += pinctrl-coh901.o
-obj-$(CONFIG_PINCTRL_SAMSUNG) += pinctrl-samsung.o
-obj-$(CONFIG_PINCTRL_EXYNOS) += pinctrl-exynos.o
-obj-$(CONFIG_PINCTRL_EXYNOS5440) += pinctrl-exynos5440.o
-obj-$(CONFIG_PINCTRL_S3C24XX) += pinctrl-s3c24xx.o
-obj-$(CONFIG_PINCTRL_S3C64XX) += pinctrl-s3c64xx.o
obj-$(CONFIG_PINCTRL_XWAY) += pinctrl-xway.o
obj-$(CONFIG_PINCTRL_LANTIQ) += pinctrl-lantiq.o
obj-$(CONFIG_PINCTRL_TB10X)+= pinctrl-tb10x.o
@@ -78,3 +73,4 @@ obj-$(CONFIG_SUPERH) += sh-pfc/
obj-$(CONFIG_PLAT_SPEAR) += spear/
obj-$(CONFIG_ARCH_VT8500) += vt8500/
obj-$(CONFIG_ARCH_SUNXI) += sunxi/
+obj-$(CONFIG_PLAT_SAMSUNG) += samsung/
diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig
new file mode 100644
index ..d0461cd5d707
--- /dev/null
+++ b/drivers/pinctrl/samsung/Kconfig
@@ -0,0 +1,28 @@
+#
+# Samsung Pin control drivers
+#
+config PINCTRL_SAMSUNG
+ bool
+ select PINMUX
+ select PINCONF
+
+config PINCTRL_EXYNOS
+ bool "Pinctrl driver data for Samsung EXYNOS SoCs other than 5440"
+ depends on OF && GPIOLIB && (ARCH_EXYNOS || ARCH_S5PV210)
Re: [PATCH 1/3] usb: usb3503: fix build warning
Hi Joonyoung, On Thu, Jul 10, 2014 at 9:53 AM, Joonyoung Shim wrote: > This fixes below build warning. > > drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’: > drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized > in this function [-Wmaybe-uninitialized] > dev_err(dev, "unable to request refclk (%d)\n", err); >^ This has been fixed and availabe in Greg's usb-next tree. https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=ec5734c41bee2ee7c938a8f34853d31cada7e67a -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs
Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and USB gadget controller supported by the DWC2 gadget driver, make it depend on them and default to ARCH_EXYNOS as they are meant for Exynos platforms. Also, make the sub-drivers silent options enabling them based on the SoC platforms that they are meant to work with. This will make life easier for end users who do not have any way knowing the dependencies. Signed-off-by: Sachin Kamat --- Changes since v1: * Added dependency on DWC2 gadget driver as suggested by Tomasz Figa. --- drivers/phy/Kconfig | 35 +++ 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index fcdfe7c0e4a7..128f8b92b55c 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -123,43 +123,30 @@ config PHY_SUN4I_USB config PHY_SAMSUNG_USB2 tristate "Samsung USB 2.0 PHY driver" depends on HAS_IOMEM + depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2 select GENERIC_PHY select MFD_SYSCON + default ARCH_EXYNOS help Enable this to support the Samsung USB 2.0 PHY driver for Samsung - SoCs. This driver provides the interface for USB 2.0 PHY. Support for - particular SoCs has to be enabled in addition to this driver. Number - and type of supported phys depends on the SoC. + SoCs. This driver provides the interface for USB 2.0 PHY. Support + for particular PHYs will be enabled based on the SoC type in addition + to this driver. config PHY_EXYNOS4210_USB2 - bool "Support for Exynos 4210" + bool depends on PHY_SAMSUNG_USB2 - depends on CPU_EXYNOS4210 - help - Enable USB PHY support for Exynos 4210. This option requires that - Samsung USB 2.0 PHY driver is enabled and means that support for this - particular SoC is compiled in the driver. In case of Exynos 4210 four - phys are available - device, host, HSIC0 and HSIC1. + default CPU_EXYNOS4210 config PHY_EXYNOS4X12_USB2 - bool "Support for Exynos 4x12" + bool depends on PHY_SAMSUNG_USB2 - depends on (SOC_EXYNOS4212 || SOC_EXYNOS4412) - help - Enable USB PHY support for Exynos 4x12. This option requires that - Samsung USB 2.0 PHY driver is enabled and means that support for this - particular SoC is compiled in the driver. In case of Exynos 4x12 four - phys are available - device, host, HSIC0 and HSIC1. + default SOC_EXYNOS4212 || SOC_EXYNOS4412 config PHY_EXYNOS5250_USB2 - bool "Support for Exynos 5250" + bool depends on PHY_SAMSUNG_USB2 - depends on SOC_EXYNOS5250 - help - Enable USB PHY support for Exynos 5250. This option requires that - Samsung USB 2.0 PHY driver is enabled and means that support for this - particular SoC is compiled in the driver. In case of Exynos 5250 four - phys are available - device, host, HSIC0 and HSIC. + default SOC_EXYNOS5250 || SOC_EXYNOS5420 config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 2/2] phy: Kconfig: Update config for Exynos USB DRD
USB DWC3 driver on Exynos platform does not work without its corresponding phy driver. Hence make the PHY driver depend on Exynos DWC3 driver and default it to yes to make things easier for the end user. Signed-off-by: Sachin Kamat --- No changes since v1. --- drivers/phy/Kconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 128f8b92b55c..ee6c80a5392a 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -152,8 +152,10 @@ config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" depends on ARCH_EXYNOS5 && OF depends on HAS_IOMEM + depends on USB_DWC3_EXYNOS select GENERIC_PHY select MFD_SYSCON + default y help Enable USB DRD PHY support for Exynos 5 SoC series. This driver provides PHY interface for USB 3.0 DRD controller -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs
Hi Tomasz, On Tue, Jul 8, 2014 at 9:15 PM, Tomasz Figa wrote: > On 30.06.2014 10:56, Sachin Kamat wrote: >> Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers, > > That's not true. They are also required for USB gadget controller > supported by the DWC2 gadget driver (formerly s3c-hsotg). Otherwise the > change makes sense to me. Do you propose I amend just the patch description or also add a dependency on USB_DWC2 along with EHCI and OHCI. I do not have anything to test this. Based on your input I will re-spin the patch. -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO
On Tue, Jul 8, 2014 at 10:49 AM, Shawn Guo wrote: > On Tue, Jul 08, 2014 at 09:18:56AM +0530, Sachin Kamat wrote: >> Hi Shawn, >> >> On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo wrote: >> > On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote: >> >> replace IS_ERR/PTR_ERR >> >> >> >> Cc: Shawn Guo >> >> Cc: Sascha Hauer >> >> Cc: linux-arm-ker...@lists.infradead.org >> >> Signed-off-by: Fabian Frederick >> > >> > Applied, thanks. >> >> >> I had sent a similar series [1] in May which you rejected. Just >> curious if something >> changed between then and now? > > The main difference is this is the second attempt from a different > person to "clean up" the code. I'm still not fond of the change, but > I'm getting tied to tell people about that, so just applied the change, > since after all it at least gives some good diffstat. > > I would prefer Fabian's patch over yours because it's really good > enough to have one patch than 5 patches in a series to do the change for > IMX platform. Doesn't really matter whose patches are in. I was just curious to know the change in logic at this point of time. Thanks for clarification. -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs
On Mon, Jun 30, 2014 at 2:26 PM, Sachin Kamat wrote: > Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers, > make it depend on them and default to ARCH_EXYNOS as they are meant > for Exynos platforms. Also, make the sub-drivers silent options enabling > them based on the SoC platforms that they are meant to work with. This > will make life easier for end users who do not have any way knowing the > dependencies. > > Signed-off-by: Sachin Kamat > --- > drivers/phy/Kconfig | 35 +++ > 1 file changed, 11 insertions(+), 24 deletions(-) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 16a2f067c242..9aab5dfb0adf 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -122,43 +122,30 @@ config PHY_SUN4I_USB > > config PHY_SAMSUNG_USB2 > tristate "Samsung USB 2.0 PHY driver" > + depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS > select GENERIC_PHY > select MFD_SYSCON > + default ARCH_EXYNOS > help > Enable this to support the Samsung USB 2.0 PHY driver for Samsung > - SoCs. This driver provides the interface for USB 2.0 PHY. Support > for > - particular SoCs has to be enabled in addition to this driver. Number > - and type of supported phys depends on the SoC. > + SoCs. This driver provides the interface for USB 2.0 PHY. Support > + for particular PHYs will be enabled based on the SoC type in > addition > + to this driver. > > config PHY_EXYNOS4210_USB2 > - bool "Support for Exynos 4210" > + bool > depends on PHY_SAMSUNG_USB2 > - depends on CPU_EXYNOS4210 > - help > - Enable USB PHY support for Exynos 4210. This option requires that > - Samsung USB 2.0 PHY driver is enabled and means that support for > this > - particular SoC is compiled in the driver. In case of Exynos 4210 > four > - phys are available - device, host, HSIC0 and HSIC1. > + default CPU_EXYNOS4210 > > config PHY_EXYNOS4X12_USB2 > - bool "Support for Exynos 4x12" > + bool > depends on PHY_SAMSUNG_USB2 > - depends on (SOC_EXYNOS4212 || SOC_EXYNOS4412) > - help > - Enable USB PHY support for Exynos 4x12. This option requires that > - Samsung USB 2.0 PHY driver is enabled and means that support for > this > - particular SoC is compiled in the driver. In case of Exynos 4x12 > four > - phys are available - device, host, HSIC0 and HSIC1. > + default SOC_EXYNOS4212 || SOC_EXYNOS4412 > > config PHY_EXYNOS5250_USB2 > - bool "Support for Exynos 5250" > + bool > depends on PHY_SAMSUNG_USB2 > - depends on SOC_EXYNOS5250 > - help > - Enable USB PHY support for Exynos 5250. This option requires that > - Samsung USB 2.0 PHY driver is enabled and means that support for > this > - particular SoC is compiled in the driver. In case of Exynos 5250 > four > - phys are available - device, host, HSIC0 and HSIC. > + default SOC_EXYNOS5250 || SOC_EXYNOS5420 > > config PHY_EXYNOS5_USBDRD > tristate "Exynos5 SoC series USB DRD PHY driver" > -- > 1.7.9.5 Kishon, Any comments on these patches? -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO
Hi Shawn, On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo wrote: > On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote: >> replace IS_ERR/PTR_ERR >> >> Cc: Shawn Guo >> Cc: Sascha Hauer >> Cc: linux-arm-ker...@lists.infradead.org >> Signed-off-by: Fabian Frederick > > Applied, thanks. I had sent a similar series [1] in May which you rejected. Just curious if something changed between then and now? [1] http://patchwork.ozlabs.org/patch/353653/ -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: Tree for Jul 4
On Sat, Jul 5, 2014 at 6:18 AM, J. Bruce Fields wrote:
> On Sat, Jul 05, 2014 at 01:10:58AM +1000, Stephen Rothwell wrote:
>> Hi Sachin,
>>
>> On Fri, 4 Jul 2014 14:12:11 +0530 Sachin Kamat wrote:
>> >
>> > Was bisecting a kernel crash on Arndale octa board (Exynos5420). It
>> > points to a merge
>> > commit:
>> > 40556a4c485d12d324f1ea196cc30f590e564237 is the first bad commit
>> > ("Merge remote-tracking branch 'nfsd/nfsd-next'").
>> >
>> > How do I proceed with this?
>>
>> I guess we get the owner of the tree (possibly) in question involved
>> (cc'd).
>
> Looking at the total diffstat for that branch, it's almost all contained
> in fs/nfsd with a little in include/linux/sunrpc/ and net/sunrpc. So
> it's extremely unlikely that it would be causing a problem unless you're
> actually testing nfsd.
I found it surprising too as I do not use nfsd. I will try out the things
suggested by Stephen and update.
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: Tree for Jul 4
On Fri, Jul 4, 2014 at 8:40 PM, Stephen Rothwell wrote:
> Hi Sachin,
>
> On Fri, 4 Jul 2014 14:12:11 +0530 Sachin Kamat wrote:
>>
>> Was bisecting a kernel crash on Arndale octa board (Exynos5420). It
>> points to a merge
>> commit:
>> 40556a4c485d12d324f1ea196cc30f590e564237 is the first bad commit
>> ("Merge remote-tracking branch 'nfsd/nfsd-next'").
>>
>> How do I proceed with this?
>
> I guess we get the owner of the tree (possibly) in question involved
> (cc'd).
>
>> Bisect log as follows:
>>
>> git bisect start
>> # good: [4c834452aad01531db949414f94f817a86348d59] Linux 3.16-rc3
>> git bisect good 4c834452aad01531db949414f94f817a86348d59
>> # bad: [bb62c798798659624c53e3727bbc18cf47eb7ae8] Add linux-next
>> specific files for 20140704
>> git bisect bad bb62c798798659624c53e3727bbc18cf47eb7ae8
>> # bad: [de5ea10b7647b299d27a40511772f024629b466d] Merge
>> remote-tracking branch 'md/for-next'
>> git bisect bad de5ea10b7647b299d27a40511772f024629b466d
>> # bad: [3ca365b4451d1bab28adc72a985d9bbdf535df0e] Merge
>> remote-tracking branch 'dmaengine/next'
>> git bisect bad 3ca365b4451d1bab28adc72a985d9bbdf535df0e
>> # good: [d72d4e47cb1e8ac1259a5f5935320ae1e7022066] Merge
>> remote-tracking branch 'renesas/next'
>> git bisect good d72d4e47cb1e8ac1259a5f5935320ae1e7022066
>> # good: [fdb82f0a3d19eaa0661d799b980d0a9b689fcf75] Merge
>> remote-tracking branch 'nfs/linux-next'
>> git bisect good fdb82f0a3d19eaa0661d799b980d0a9b689fcf75
>> # bad: [fc48eed8cd350e4be1227ff3c990d48906afd00a] Merge
>> remote-tracking branch 'hwmon-staging/hwmon-next'
>> git bisect bad fc48eed8cd350e4be1227ff3c990d48906afd00a
>> # bad: [7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9] Merge
>> remote-tracking branch 'ubifs/linux-next'
>> git bisect bad 7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9
>> # good: [8cdb8b21b1d00856b885734c514821627c8078bc] NFSD: Avoid warning
>> message when compile at i686 arch
>> git bisect good 8cdb8b21b1d00856b885734c514821627c8078bc
>> # good: [da575690c01993471e38faf3eee1991ee69d7b20] nfsd: clean up
>> nfsd4_close_open_stateid
>> git bisect good da575690c01993471e38faf3eee1991ee69d7b20
>> # good: [95217c1e686bdd7c27b8483bbdda1c09d6fa9a92] nfsd: Don't get a
>> session reference without a client reference
>> git bisect good 95217c1e686bdd7c27b8483bbdda1c09d6fa9a92
>> # good: [bdd79ee31bf842051365c798effaffe0e647b501] nfsd: Allow struct
>> nfsd4_compound_state to cache the nfs4_client
>> git bisect good bdd79ee31bf842051365c798effaffe0e647b501
>> # good: [e9110361a9a4e258b072b14bd44eb78cf11453cb] UBI: fix the
>> volumes tree sorting criteria
>> git bisect good e9110361a9a4e258b072b14bd44eb78cf11453cb
>> # bad: [40556a4c485d12d324f1ea196cc30f590e564237] Merge
>> remote-tracking branch 'nfsd/nfsd-next'
>> git bisect bad 40556a4c485d12d324f1ea196cc30f590e564237
>>
>> Regards,
>> Sachin.
>
> Can you please double check that commit bdd79ee31bf8 is good and commit
> 40556a4c485d is bad. Also check that commit fdb82f0a3d19 is good.
>
> In that case we have the unlikely event that the (automated) git merge
> is not correct or patches on each side of the merge semantically
> interact badly.
>
> I guess the next thing to try is just Linus' tree (commit 5170a3b24a91)
> merged with the nfsd tree (commit 2fc193cf924e).
>
> You should also post your information about the crash you are
> diagnosing as others may have seen it as well - or know what may cause
> it.
Thanks Stephen. I will give it a try on Monday.
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] iommu/exynos: Select ARM_DMA_USE_IOMMU
Hi Tushar, On Fri, Jul 4, 2014 at 3:01 PM, Tushar Behera wrote: > For IOMMU to use on Exynos platforms, we need to enable ARM_DMA_USE_IOMMU. It > would be better to select it by default when EXYNOS_IOMMU is enabled. > > Signed-off-by: Tushar Behera > --- > drivers/iommu/Kconfig |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index d260605..54f3ad1a 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -180,6 +180,7 @@ config EXYNOS_IOMMU > bool "Exynos IOMMU Support" > depends on ARCH_EXYNOS > select IOMMU_API > + select ARM_DMA_USE_IOMMU > help > Support for the IOMMU (System MMU) of Samsung Exynos application > processor family. This enables H/W multimedia accelerators to see > -- Reviewed-by: Sachin Kamat -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: Tree for Jul 4
Hi Stephen,
Was bisecting a kernel crash on Arndale octa board (Exynos5420). It
points to a merge
commit:
40556a4c485d12d324f1ea196cc30f590e564237 is the first bad commit
("Merge remote-tracking branch 'nfsd/nfsd-next'").
How do I proceed with this?
Bisect log as follows:
git bisect start
# good: [4c834452aad01531db949414f94f817a86348d59] Linux 3.16-rc3
git bisect good 4c834452aad01531db949414f94f817a86348d59
# bad: [bb62c798798659624c53e3727bbc18cf47eb7ae8] Add linux-next
specific files for 20140704
git bisect bad bb62c798798659624c53e3727bbc18cf47eb7ae8
# bad: [de5ea10b7647b299d27a40511772f024629b466d] Merge
remote-tracking branch 'md/for-next'
git bisect bad de5ea10b7647b299d27a40511772f024629b466d
# bad: [3ca365b4451d1bab28adc72a985d9bbdf535df0e] Merge
remote-tracking branch 'dmaengine/next'
git bisect bad 3ca365b4451d1bab28adc72a985d9bbdf535df0e
# good: [d72d4e47cb1e8ac1259a5f5935320ae1e7022066] Merge
remote-tracking branch 'renesas/next'
git bisect good d72d4e47cb1e8ac1259a5f5935320ae1e7022066
# good: [fdb82f0a3d19eaa0661d799b980d0a9b689fcf75] Merge
remote-tracking branch 'nfs/linux-next'
git bisect good fdb82f0a3d19eaa0661d799b980d0a9b689fcf75
# bad: [fc48eed8cd350e4be1227ff3c990d48906afd00a] Merge
remote-tracking branch 'hwmon-staging/hwmon-next'
git bisect bad fc48eed8cd350e4be1227ff3c990d48906afd00a
# bad: [7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9] Merge
remote-tracking branch 'ubifs/linux-next'
git bisect bad 7d3f94ee2f2808b13dd3a96f6e6ca754a954d4b9
# good: [8cdb8b21b1d00856b885734c514821627c8078bc] NFSD: Avoid warning
message when compile at i686 arch
git bisect good 8cdb8b21b1d00856b885734c514821627c8078bc
# good: [da575690c01993471e38faf3eee1991ee69d7b20] nfsd: clean up
nfsd4_close_open_stateid
git bisect good da575690c01993471e38faf3eee1991ee69d7b20
# good: [95217c1e686bdd7c27b8483bbdda1c09d6fa9a92] nfsd: Don't get a
session reference without a client reference
git bisect good 95217c1e686bdd7c27b8483bbdda1c09d6fa9a92
# good: [bdd79ee31bf842051365c798effaffe0e647b501] nfsd: Allow struct
nfsd4_compound_state to cache the nfs4_client
git bisect good bdd79ee31bf842051365c798effaffe0e647b501
# good: [e9110361a9a4e258b072b14bd44eb78cf11453cb] UBI: fix the
volumes tree sorting criteria
git bisect good e9110361a9a4e258b072b14bd44eb78cf11453cb
# bad: [40556a4c485d12d324f1ea196cc30f590e564237] Merge
remote-tracking branch 'nfsd/nfsd-next'
git bisect bad 40556a4c485d12d324f1ea196cc30f590e564237
Regards,
Sachin.
On Fri, Jul 4, 2014 at 12:12 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20140703:
>
> My fixes tree contains:
> powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
>
> The net tree gained a build failure for which I reverted a commit.
>
> The usb-gadget tree gained a conflict against the usb.current tree.
>
> The staging tree still had its build failure for which I disabled a driver.
>
> The akpm-current tree still had its build failure for which I applied a
> patch.
>
> Non-merge commits (relative to Linus' tree): 3478
> 3383 files changed, 134181 insertions(+), 185822 deletions(-)
>
>
>
> I have created today's linux-next tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> (patches at http://www.kernel.org/pub/linux/kernel/next/ ). If you
> are tracking the linux-next tree using git, you should not use "git pull"
> to do so as that will try to merge the new linux-next release with the
> old one. You should use "git fetch" and checkout or reset to the new
> master.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] irq_work: Implement remote queueing
On Wed, Jun 25, 2014 at 10:08 PM, Peter Zijlstra wrote:
> On Wed, Jun 25, 2014 at 10:23:21AM -0600, Stephen Warren wrote:
>> On 06/25/2014 04:19 AM, Peter Zijlstra wrote:
>> > On Wed, Jun 25, 2014 at 03:24:11PM +0530, Srivatsa S. Bhat wrote:
>> >> Wait, that was a stupid idea. hotplug_cfd() already invokes irq_work_run
>> >> indirectly via flush_smp_call_function_queue(). So irq_work_cpu_notify()
>> >> doesn't need to invoke it again, AFAIU. So perhaps we can get rid of
>> >> irq_work_cpu_notify() altogether?
>> >
>> > Just so...
>> >
>> > getting up at 6am and sitting in an airport terminal doesn't seem to
>> > agree with me; any more silly fail here?
>> >
>> > ---
>> > Subject: irq_work: Remove BUG_ON in irq_work_run()
>> > From: Peter Zijlstra
>> > Date: Wed Jun 25 07:13:07 CEST 2014
>> >
>> > Because of a collision with 8d056c48e486 ("CPU hotplug, smp: flush any
>> > pending IPI callbacks before CPU offline"), which ends up calling
>> > hotplug_cfd()->flush_smp_call_function_queue()->irq_work_run(), which
>> > is not from IRQ context.
>> >
>> > And since that already calls irq_work_run() from the hotplug path,
>> > remove our entire hotplug handling.
>>
>> Tested-by: Stephen Warren
>>
>> [with the s/static// already mentioned in this thread, obviously:-)]
>
> Right; I pushed out a fixed version right before loosing my tubes at the
> airport :-)
>
> https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/commit/?h=timers/nohz&id=921d8b81281ecdca686369f52165d04fa3505bd7
This patch fixes boot issue on Exynos5420/5800 based boards with bL
switcher enabled.
FWIW,
Tested-by: Sachin Kamat
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 09/16] MAINTAINERS: Update Samsunt MFD drivers pattern
On Fri, Jul 4, 2014 at 5:23 AM, Sangbeom Kim wrote: > On Friday, July 04, 2014 7:08 AM, Joe Perches wrote: > >> F: drivers/regulator/s2m*.c >> F: drivers/regulator/s5m*.c >> -F: drivers/rtc/rtc-sec.c >> F: include/linux/mfd/samsung/ >> > > Yes, You are right. > There is no rtc-sec.c > Instead, rtc-s5m.c was upstreamed. > I will post update patch. Joe, In any case, if this patch is going to be appled, please fix typo in subject s/Samsunt/Samsung -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO
On Thu, Jun 12, 2014 at 3:27 PM, Kishon Vijay Abraham I wrote:
>
>
> On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote:
>> Hi Kishon,
>>
>> On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han wrote:
>>> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>>>
>>>> PTR_ERR_OR_ZERO simplifies the code.
>>>>
>>>> Signed-off-by: Sachin Kamat
>>>> Cc: Jingoo Han
>>>
>>> Acked-by: Jingoo Han
>>>
>>> Best regards,
>>> Jingoo Han
>>>
>>>> ---
>>>> drivers/phy/phy-exynos-dp-video.c |5 ++---
>>>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/phy/phy-exynos-dp-video.c
>>>> b/drivers/phy/phy-exynos-dp-video.c
>>>> index 0786fef842e7..098f822a2fa4 100644
>>>> --- a/drivers/phy/phy-exynos-dp-video.c
>>>> +++ b/drivers/phy/phy-exynos-dp-video.c
>>>> @@ -9,6 +9,7 @@
>>>> * published by the Free Software Foundation.
>>>> */
>>>>
>>>> +#include
>>>> #include
>>>> #include
>>>> #include
>>>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct
>>>> platform_device *pdev)
>>>> phy_set_drvdata(phy, state);
>>>>
>>>> phy_provider = devm_of_phy_provider_register(dev,
>>>> of_phy_simple_xlate);
>>>> - if (IS_ERR(phy_provider))
>>>> - return PTR_ERR(phy_provider);
>>>>
>>>> - return 0;
>>>> + return PTR_ERR_OR_ZERO(phy_provider);
>>>> }
>>>>
>>>> static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>>>> --
>>>> 1.7.9.5
>>>
>>>
>>
>> ping on this series.
>
> I'll queue to -next once -rc1 is tagged.
Gentle ping..
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250
On Wed, Jul 2, 2014 at 5:22 AM, Chanwoo Choi wrote:
> On 07/01/2014 01:10 PM, Sachin Kamat wrote:
>> Hi Chanwoo,
>>
>> On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi wrote:
>>> Hi Sachin,
>>>
>>> On 07/01/2014 12:33 PM, Sachin Kamat wrote:
>>>> Hi Chanwoo,
>>>>
>>>> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi wrote:
>>>>> This patch add TMU (Thermal Management Unit) dt node to monitor the high
>>>>> temperature for Exynos3250.
>>>>>
>>>>> Signed-off-by: Chanwoo Choi
>>>>> Acked-by: Kyungmin Park
>>>>> ---
>>>>> This patch has a dependency on following patch [1]:
>>>>> [1] https://lkml.org/lkml/2014/6/30/805
>>>>>
>>>>> arch/arm/boot/dts/exynos3250.dtsi | 10 ++
>>>>> 1 file changed, 10 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
>>>>> b/arch/arm/boot/dts/exynos3250.dtsi
>>>>> index 3660cab..1e566af 100644
>>>>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>>>>> @@ -192,6 +192,16 @@
>>>>> status = "disabled";
>>>>> };
>>>>>
>>>>> + tmu: tmu@100C {
>>>>> + compatible = "samsung,exynos3250-tmu";
>>>>> + interrupt-parent = <&gic>;
>>>>> + reg = <0x100C 0x100>;
>>>>> + interrupts = <0 216 0>;
>>>>> + clocks = <&cmu CLK_TMU_APBIF>;
>>>>> + clock-names = "tmu_apbif";
>>>>> + status = "disabled";
>>>>
>>>> I don't think there would be any board specific properties needed. Hence
>>>> leave the status as enabled (by deleting the above line).
>>>>
>>>
>>> I think that if specific board need TMU feature, dts file for specific board
>>> should include tmu dt node with 'okay' status. The specific board based on
>>> Exynos3250 might not need TMU feature.
>>
>> The status field in DT node is not meant for stating the build configuration
>> but
>> represents the readiness of the hardware for usage on the platform. If
>> a particular
>> board does not need this feature it needs to be disabled in the build
>> config and only
>> for any special requirements disable it in board file.
>
> TMU (Thermal Management Unit) needs specific regulator for TMU power as
> following:
> The regulator for TMU is dependent on board.
In this case it makes sense to leave it disabled in dtsi.
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 1/1] clk: Fix build warnings
‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined.
Thus, make their compilation conditional to fix the below warnings introduced
by commit 27b8d5f723 ("clk: flatten clk tree in debugfs"):
drivers/clk/clk.c:40:27: warning: ‘all_lists’ defined but not used
[-Wunused-variable]
drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used
[-Wunused-variable]
Signed-off-by: Sachin Kamat
Cc: Peter De Schrijver
---
Changes since v1:
Moved the definitions under already existing #ifdefs.
---
drivers/clk/clk.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 7dfb2f308b35..958967d141ee 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -36,17 +36,6 @@ static HLIST_HEAD(clk_root_list);
static HLIST_HEAD(clk_orphan_list);
static LIST_HEAD(clk_notifier_list);
-static struct hlist_head *all_lists[] = {
- &clk_root_list,
- &clk_orphan_list,
- NULL,
-};
-
-static struct hlist_head *orphan_list[] = {
- &clk_orphan_list,
- NULL,
-};
-
/*** locking ***/
static void clk_prepare_lock(void)
{
@@ -111,6 +100,17 @@ static void clk_enable_unlock(unsigned long flags)
static struct dentry *rootdir;
static int inited = 0;
+static struct hlist_head *all_lists[] = {
+ &clk_root_list,
+ &clk_orphan_list,
+ NULL,
+};
+
+static struct hlist_head *orphan_list[] = {
+ &clk_orphan_list,
+ NULL,
+};
+
static void clk_summary_show_one(struct seq_file *s, struct clk *c, int level)
{
if (!c)
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] clk: Fix build warnings
On Mon, Jun 30, 2014 at 7:07 PM, Peter De Schrijver
wrote:
> On Mon, Jun 30, 2014 at 11:40:54AM +0200, Sachin Kamat wrote:
>> ‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined.
>> Thus, make their compilation conditional to fix the below warnings introduced
>> by commit 27b8d5f723 ("clk: flatten clk tree in debugfs"):
>> drivers/clk/clk.c:40:27: warning: ‘all_lists’ defined but not used
>> [-Wunused-variable]
>> drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used
>> [-Wunused-variable]
>>
>
> Maybe just move them inside the existing #ifdef CONFIG_DEBUG_FS / #endif?
That makes sense. Thanks for the hint. Will re-spin.
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250
Hi Chanwoo,
On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi wrote:
> Hi Sachin,
>
> On 07/01/2014 12:33 PM, Sachin Kamat wrote:
>> Hi Chanwoo,
>>
>> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi wrote:
>>> This patch add TMU (Thermal Management Unit) dt node to monitor the high
>>> temperature for Exynos3250.
>>>
>>> Signed-off-by: Chanwoo Choi
>>> Acked-by: Kyungmin Park
>>> ---
>>> This patch has a dependency on following patch [1]:
>>> [1] https://lkml.org/lkml/2014/6/30/805
>>>
>>> arch/arm/boot/dts/exynos3250.dtsi | 10 ++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
>>> b/arch/arm/boot/dts/exynos3250.dtsi
>>> index 3660cab..1e566af 100644
>>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>>> @@ -192,6 +192,16 @@
>>> status = "disabled";
>>> };
>>>
>>> + tmu: tmu@100C {
>>> + compatible = "samsung,exynos3250-tmu";
>>> + interrupt-parent = <&gic>;
>>> + reg = <0x100C 0x100>;
>>> + interrupts = <0 216 0>;
>>> + clocks = <&cmu CLK_TMU_APBIF>;
>>> + clock-names = "tmu_apbif";
>>> + status = "disabled";
>>
>> I don't think there would be any board specific properties needed. Hence
>> leave the status as enabled (by deleting the above line).
>>
>
> I think that if specific board need TMU feature, dts file for specific board
> should include tmu dt node with 'okay' status. The specific board based on
> Exynos3250 might not need TMU feature.
The status field in DT node is not meant for stating the build configuration but
represents the readiness of the hardware for usage on the platform. If
a particular
board does not need this feature it needs to be disabled in the build
config and only
for any special requirements disable it in board file.
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250
Hi Chanwoo,
On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi wrote:
> This patch add TMU (Thermal Management Unit) dt node to monitor the high
> temperature for Exynos3250.
>
> Signed-off-by: Chanwoo Choi
> Acked-by: Kyungmin Park
> ---
> This patch has a dependency on following patch [1]:
> [1] https://lkml.org/lkml/2014/6/30/805
>
> arch/arm/boot/dts/exynos3250.dtsi | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
> b/arch/arm/boot/dts/exynos3250.dtsi
> index 3660cab..1e566af 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -192,6 +192,16 @@
> status = "disabled";
> };
>
> + tmu: tmu@100C {
> + compatible = "samsung,exynos3250-tmu";
> + interrupt-parent = <&gic>;
> + reg = <0x100C 0x100>;
> + interrupts = <0 216 0>;
> + clocks = <&cmu CLK_TMU_APBIF>;
> + clock-names = "tmu_apbif";
> + status = "disabled";
I don't think there would be any board specific properties needed. Hence
leave the status as enabled (by deleting the above line).
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] clk: Fix build warnings
‘all_lists’ and ‘orphan_list’ is accessed only when DEBUG_FS is defined.
Thus, make their compilation conditional to fix the below warnings introduced
by commit 27b8d5f723 ("clk: flatten clk tree in debugfs"):
drivers/clk/clk.c:40:27: warning: ‘all_lists’ defined but not used
[-Wunused-variable]
drivers/clk/clk.c:46:27: warning: ‘orphan_list’ defined but not used
[-Wunused-variable]
Signed-off-by: Sachin Kamat
Cc: Peter De Schrijver
---
drivers/clk/clk.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 7dfb2f308b35..a95233c14f86 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -36,6 +36,7 @@ static HLIST_HEAD(clk_root_list);
static HLIST_HEAD(clk_orphan_list);
static LIST_HEAD(clk_notifier_list);
+#ifdef CONFIG_DEBUG_FS
static struct hlist_head *all_lists[] = {
&clk_root_list,
&clk_orphan_list,
@@ -46,6 +47,7 @@ static struct hlist_head *orphan_list[] = {
&clk_orphan_list,
NULL,
};
+#endif
/*** locking ***/
static void clk_prepare_lock(void)
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] phy: Kconfig: Update config for Exynos USB DRD
USB DWC3 driver on Exynos platform does not work without its corresponding phy driver. Hence make the PHY driver depend on Exynos DWC3 driver and default it to yes to make things easier for the end user. Signed-off-by: Sachin Kamat --- drivers/phy/Kconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 9aab5dfb0adf..6f90ee3c7ed1 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -151,8 +151,10 @@ config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" depends on ARCH_EXYNOS5 && OF depends on HAS_IOMEM + depends on USB_DWC3_EXYNOS select GENERIC_PHY select MFD_SYSCON + default y help Enable USB DRD PHY support for Exynos 5 SoC series. This driver provides PHY interface for USB 3.0 DRD controller -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs
Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers, make it depend on them and default to ARCH_EXYNOS as they are meant for Exynos platforms. Also, make the sub-drivers silent options enabling them based on the SoC platforms that they are meant to work with. This will make life easier for end users who do not have any way knowing the dependencies. Signed-off-by: Sachin Kamat --- drivers/phy/Kconfig | 35 +++ 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 16a2f067c242..9aab5dfb0adf 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -122,43 +122,30 @@ config PHY_SUN4I_USB config PHY_SAMSUNG_USB2 tristate "Samsung USB 2.0 PHY driver" + depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS select GENERIC_PHY select MFD_SYSCON + default ARCH_EXYNOS help Enable this to support the Samsung USB 2.0 PHY driver for Samsung - SoCs. This driver provides the interface for USB 2.0 PHY. Support for - particular SoCs has to be enabled in addition to this driver. Number - and type of supported phys depends on the SoC. + SoCs. This driver provides the interface for USB 2.0 PHY. Support + for particular PHYs will be enabled based on the SoC type in addition + to this driver. config PHY_EXYNOS4210_USB2 - bool "Support for Exynos 4210" + bool depends on PHY_SAMSUNG_USB2 - depends on CPU_EXYNOS4210 - help - Enable USB PHY support for Exynos 4210. This option requires that - Samsung USB 2.0 PHY driver is enabled and means that support for this - particular SoC is compiled in the driver. In case of Exynos 4210 four - phys are available - device, host, HSIC0 and HSIC1. + default CPU_EXYNOS4210 config PHY_EXYNOS4X12_USB2 - bool "Support for Exynos 4x12" + bool depends on PHY_SAMSUNG_USB2 - depends on (SOC_EXYNOS4212 || SOC_EXYNOS4412) - help - Enable USB PHY support for Exynos 4x12. This option requires that - Samsung USB 2.0 PHY driver is enabled and means that support for this - particular SoC is compiled in the driver. In case of Exynos 4x12 four - phys are available - device, host, HSIC0 and HSIC1. + default SOC_EXYNOS4212 || SOC_EXYNOS4412 config PHY_EXYNOS5250_USB2 - bool "Support for Exynos 5250" + bool depends on PHY_SAMSUNG_USB2 - depends on SOC_EXYNOS5250 - help - Enable USB PHY support for Exynos 5250. This option requires that - Samsung USB 2.0 PHY driver is enabled and means that support for this - particular SoC is compiled in the driver. In case of Exynos 5250 four - phys are available - device, host, HSIC0 and HSIC. + default SOC_EXYNOS5250 || SOC_EXYNOS5420 config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice
Hi Krzysztof,
On Thu, Jun 26, 2014 at 5:16 PM, Krzysztof Kozlowski
wrote:
> Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT
> bindings") introduced local variable boot_reg where boot address from
> cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg()
> again.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
Thanks for the patch.
Reviewed-by: Sachin Kamat
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits
Hi Naveen,
On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi
wrote:
> This patch removes an extra line and fixes a styling nit
> in exynos5_i2c_message_start()
>
> Signed-off-by: Naveen Krishna Chatradhi
> ---
> drivers/i2c/busses/i2c-exynos5.c |3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-exynos5.c
> b/drivers/i2c/busses/i2c-exynos5.c
> index 0d1a7bc..4c2e6f3 100644
> --- a/drivers/i2c/busses/i2c-exynos5.c
> +++ b/drivers/i2c/busses/i2c-exynos5.c
> @@ -525,7 +525,7 @@ static void exynos5_i2c_message_start(struct exynos5_i2c
> *i2c, int stop)
> if (i2c->msg->flags & I2C_M_RD) {
> i2c_ctl |= HSI2C_RXCHON;
>
> - i2c_auto_conf = HSI2C_READ_WRITE;
> + i2c_auto_conf |= HSI2C_READ_WRITE;
This change looks more than just a styling nit. Please update the commit message
accordingly.
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] mfd: pm8921-core: Remove unused variable
‘irq_bit’ is unused in the function. Remove it.
Signed-off-by: Sachin Kamat
---
Compile tested.
---
drivers/mfd/pm8921-core.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
index 959513803542..39904f77c049 100644
--- a/drivers/mfd/pm8921-core.c
+++ b/drivers/mfd/pm8921-core.c
@@ -186,11 +186,9 @@ static void pm8xxx_irq_mask_ack(struct irq_data *d)
{
struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
unsigned int pmirq = irqd_to_hwirq(d);
- int irq_bit;
u8 block, config;
block = pmirq / 8;
- irq_bit = pmirq % 8;
config = chip->config[pmirq] | PM_IRQF_MASK_ALL | PM_IRQF_CLR;
pm8xxx_config_irq(chip, block, config);
@@ -200,11 +198,9 @@ static void pm8xxx_irq_unmask(struct irq_data *d)
{
struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
unsigned int pmirq = irqd_to_hwirq(d);
- int irq_bit;
u8 block, config;
block = pmirq / 8;
- irq_bit = pmirq % 8;
config = chip->config[pmirq];
pm8xxx_config_irq(chip, block, config);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] regulator: s5m8767: Remove unused variable
'size' is not used in the function. Remove it.
Signed-off-by: Sachin Kamat
---
drivers/regulator/s5m8767.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index c79af943a5c0..0ab5cbeeb797 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -686,7 +686,7 @@ static int s5m8767_pmic_probe(struct platform_device *pdev)
struct sec_platform_data *pdata = iodev->pdata;
struct regulator_config config = { };
struct s5m8767_info *s5m8767;
- int i, ret, size, buck_init;
+ int i, ret, buck_init;
if (!pdata) {
dev_err(pdev->dev.parent, "Platform data not supplied\n");
@@ -725,8 +725,6 @@ static int s5m8767_pmic_probe(struct platform_device *pdev)
if (!s5m8767)
return -ENOMEM;
- size = sizeof(struct regulator_dev *) * (S5M8767_REG_MAX - 2);
-
s5m8767->dev = &pdev->dev;
s5m8767->iodev = iodev;
s5m8767->num_regulators = pdata->num_regulators;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] regulator: tps65217: Fix build warnings
rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:
drivers/regulator/tps65217-regulator.c:73:10: warning: comparison of unsigned
expression < 0 is always false [-Wtype-limits]
drivers/regulator/tps65217-regulator.c:87:10: warning: comparison of unsigned
expression < 0 is always false [-Wtype-limits]
Signed-off-by: Sachin Kamat
---
Series compile tested.
---
drivers/regulator/tps65217-regulator.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/tps65217-regulator.c
b/drivers/regulator/tps65217-regulator.c
index f7ed20a5a8b9..d58db72a63b0 100644
--- a/drivers/regulator/tps65217-regulator.c
+++ b/drivers/regulator/tps65217-regulator.c
@@ -68,7 +68,7 @@ static const struct regulator_linear_range
tps65217_uv2_ranges[] = {
static int tps65217_pmic_enable(struct regulator_dev *dev)
{
struct tps65217 *tps = rdev_get_drvdata(dev);
- unsigned int rid = rdev_get_id(dev);
+ int rid = rdev_get_id(dev);
if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
return -EINVAL;
@@ -82,7 +82,7 @@ static int tps65217_pmic_enable(struct regulator_dev *dev)
static int tps65217_pmic_disable(struct regulator_dev *dev)
{
struct tps65217 *tps = rdev_get_drvdata(dev);
- unsigned int rid = rdev_get_id(dev);
+ int rid = rdev_get_id(dev);
if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
return -EINVAL;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] regulator: tps65218: Fix build warnings
rdev_get_id() returns an int. Convert rid to type int to avoid the
following warnings:
drivers/regulator/tps65218-regulator.c:132:10: warning: comparison of unsigned
expression < 0 is always false [-Wtype-limits]
drivers/regulator/tps65218-regulator.c:146:10: warning: comparison of unsigned
expression < 0 is always false [-Wtype-limits]
Signed-off-by: Sachin Kamat
---
drivers/regulator/tps65218-regulator.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/tps65218-regulator.c
b/drivers/regulator/tps65218-regulator.c
index 69b4b7750410..8b24404be0bd 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -127,7 +127,7 @@ static int tps65218_pmic_set_voltage_sel(struct
regulator_dev *dev,
static int tps65218_pmic_enable(struct regulator_dev *dev)
{
struct tps65218 *tps = rdev_get_drvdata(dev);
- unsigned int rid = rdev_get_id(dev);
+ int rid = rdev_get_id(dev);
if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
return -EINVAL;
@@ -141,7 +141,7 @@ static int tps65218_pmic_enable(struct regulator_dev *dev)
static int tps65218_pmic_disable(struct regulator_dev *dev)
{
struct tps65218 *tps = rdev_get_drvdata(dev);
- unsigned int rid = rdev_get_id(dev);
+ int rid = rdev_get_id(dev);
if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
return -EINVAL;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization
'name' field was re-initialized and getting overwritten in some
cases possibly due to a typo. Code inspection says the second time
it should be 'sname' instead of 'name'. Replace it.
Signed-off-by: Sachin Kamat
---
Compile tested only.
---
drivers/regulator/as3722-regulator.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/as3722-regulator.c
b/drivers/regulator/as3722-regulator.c
index ad9e0c9b7daf..b68f05f38537 100644
--- a/drivers/regulator/as3722-regulator.c
+++ b/drivers/regulator/as3722-regulator.c
@@ -219,7 +219,7 @@ static const struct as3722_register_mapping
as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO3,
.name = "as3722-ldo3",
- .name = "vin-ldo3-4",
+ .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO3_VOLTAGE_REG,
.vsel_mask = AS3722_LDO3_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
@@ -231,7 +231,7 @@ static const struct as3722_register_mapping
as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO4,
.name = "as3722-ldo4",
- .name = "vin-ldo3-4",
+ .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO4_VOLTAGE_REG,
.vsel_mask = AS3722_LDO_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe
Hi Sherman, On Mon, Jun 23, 2014 at 11:35 PM, Sherman Yin wrote: > Hi Sachin, > > Looks good, thanks. How did you come across the need for this change? Thanks for the review. Sparse threw up a warning while doing a regular build. Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe
bcm281xx_pinctrl_probe is local to this file. Make it static.
Signed-off-by: Sachin Kamat
---
drivers/pinctrl/pinctrl-bcm281xx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c
b/drivers/pinctrl/pinctrl-bcm281xx.c
index 3bed792b2c03..c5ca9e633fff 100644
--- a/drivers/pinctrl/pinctrl-bcm281xx.c
+++ b/drivers/pinctrl/pinctrl-bcm281xx.c
@@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
.owner = THIS_MODULE,
};
-int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
+static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
{
struct bcm281xx_pinctrl_data *pdata = &bcm281xx_pinctrl;
struct resource *res;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] spmi: Remove duplicate inclusion of module.h
module.h was included twice. Signed-off-by: Sachin Kamat --- drivers/spmi/spmi.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index 3b5780710d50..1d92f5103ebf 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -18,7 +18,6 @@ #include #include #include -#include #include #include -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] serial: samsung: Remove redundant label
On Mon, Jun 23, 2014 at 11:32 AM, Tushar Behera wrote:
> probe_err label only returns the error code. This label can be removed
> and the error code can be returned directly.
>
> Signed-off-by: Tushar Behera
> ---
> drivers/tty/serial/samsung.c |5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index c1d3ebd..bf93010 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1303,7 +1303,7 @@ static int s3c24xx_serial_probe(struct platform_device
> *pdev)
>
> ret = s3c24xx_serial_init_port(ourport, pdev);
> if (ret < 0)
> - goto probe_err;
> + return ret;
>
> if (!s3c24xx_uart_drv.state) {
> ret = uart_register_driver(&s3c24xx_uart_drv);
> @@ -1335,9 +1335,6 @@ static int s3c24xx_serial_probe(struct platform_device
> *pdev)
> dev_err(&pdev->dev, "failed to add cpufreq notifier\n");
>
> return 0;
> -
> - probe_err:
> - return ret;
> }
>
> static int s3c24xx_serial_remove(struct platform_device *dev)
> --
Looks good.
Reviewed-by: Sachin Kamat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] Documentation: devicetree: Fix s2mps11 example syntax
On Mon, Jun 23, 2014 at 6:51 AM, Andreas Färber wrote:
> It's <1>, not 1.
>
> Signed-off-by: Andreas Färber
> ---
> Documentation/devicetree/bindings/mfd/s2mps11.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> index 55ab4f4..99a0c52 100644
> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> @@ -96,7 +96,7 @@ Example:
>
> s2m_osc: clocks {
> compatible = "samsung,s2mps11-clk";
> - #clock-cells = 1;
> + #clock-cells = <1>;
> clock-output-names = "xx", "yy", "zz";
> };
>
> --
> 1.9.3
>
Reviewed-by: Sachin Kamat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/4] Documentation: devicetree: Fix s2mps11 and s5m8767 typos
On Mon, Jun 23, 2014 at 6:51 AM, Andreas Färber wrote: > It's LDO2, not LD02. > > Signed-off-by: Andreas Färber > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 2 +- > Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt > b/Documentation/devicetree/bindings/mfd/s2mps11.txt > index d81ba30..55ab4f4 100644 > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > @@ -81,7 +81,7 @@ as per the datasheet of s2mps11. > - valid values for n are: > - S2MPS11: 1 to 38 > - S2MPS14: 1 to 25 > - - Example: LDO1, LD02, LDO28 > + - Example: LDO1, LDO2, LDO28 > - BUCKn > - valid values for n are: > - S2MPS11: 1 to 10 > diff --git > a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt > b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt > index d290988..2019131 100644 > --- a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt > @@ -86,7 +86,7 @@ as per the datasheet of s5m8767. > > - LDOn > - valid values for n are 1 to 28 > - - Example: LDO1, LD02, LDO28 > + - Example: LDO1, LDO2, LDO28 > - BUCKn > - valid values for n are 1 to 9. > - Example: BUCK1, BUCK2, BUCK9 > -- Very keen observation :) Reviewed-by: Sachin Kamat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH Resend 1/1] regulator: ltc3589: Staticize ltc3589_reg_defaults
'ltc3589_reg_defaults' is local to this file. Make it static.
Signed-off-by: Sachin Kamat
---
drivers/regulator/ltc3589.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/ltc3589.c b/drivers/regulator/ltc3589.c
index c8105182b8b8..c756955bfcc5 100644
--- a/drivers/regulator/ltc3589.c
+++ b/drivers/regulator/ltc3589.c
@@ -377,7 +377,7 @@ static bool ltc3589_volatile_reg(struct device *dev,
unsigned int reg)
return false;
}
-struct reg_default ltc3589_reg_defaults[] = {
+static struct reg_default ltc3589_reg_defaults[] = {
{ LTC3589_SCR1, 0x00 },
{ LTC3589_OVEN, 0x00 },
{ LTC3589_SCR2, 0x00 },
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/6] thunderbolt: Fix build error in switch.c
Fixes the below error: drivers/thunderbolt/switch.c:347:2: error: implicit declaration of function ‘kzalloc’ [-Werror=implicit-function-declaration] drivers/thunderbolt/switch.c:381:2: error: implicit declaration of function ‘kcalloc’ [-Werror=implicit-function-declaration] Signed-off-by: Sachin Kamat --- drivers/thunderbolt/switch.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index 0d50e7e7b29b..26e76e4aa835 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -5,6 +5,7 @@ */ #include +#include #include "tb.h" -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 6/6] thunderbolt: Staticize nhi_ids
'nhi_ids' is local to this file.
Signed-off-by: Sachin Kamat
---
drivers/thunderbolt/nhi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
index 0fc137af89f5..2054fbf8b382 100644
--- a/drivers/thunderbolt/nhi.c
+++ b/drivers/thunderbolt/nhi.c
@@ -632,7 +632,7 @@ static const struct dev_pm_ops nhi_pm_ops = {
.restore_noirq = nhi_resume_noirq,
};
-struct pci_device_id nhi_ids[] = {
+static struct pci_device_id nhi_ids[] = {
/*
* We have to specify class, the TB bridges use the same device and
* vendor (sub)id.
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 4/6] thunderbolt: Use NULL instead of 0 in ctl.c
The function returns a pointer. Hence return NULL instead of 0.
Signed-off-by: Sachin Kamat
---
drivers/thunderbolt/ctl.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index d04fee4acb2e..4c6da92edcb4 100644
--- a/drivers/thunderbolt/ctl.c
+++ b/drivers/thunderbolt/ctl.c
@@ -305,13 +305,13 @@ static struct ctl_pkg *tb_ctl_pkg_alloc(struct tb_ctl
*ctl)
{
struct ctl_pkg *pkg = kzalloc(sizeof(*pkg), GFP_KERNEL);
if (!pkg)
- return 0;
+ return NULL;
pkg->ctl = ctl;
pkg->buffer = dma_pool_alloc(ctl->frame_pool, GFP_KERNEL,
&pkg->frame.buffer_phy);
if (!pkg->buffer) {
kfree(pkg);
- return 0;
+ return NULL;
}
return pkg;
}
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3/6] thunderbolt: Use NULL instead of 0 in switch.c
The function returns a pointer. Hence return NULL instead of 0. Signed-off-by: Sachin Kamat --- drivers/thunderbolt/switch.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index 26e76e4aa835..aeb982969629 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -260,11 +260,11 @@ struct tb_switch *get_switch_at_route(struct tb_switch *sw, u64 route) if (route == 0) return sw; if (next_port > sw->config.max_port_number) - return 0; + return NULL; if (tb_is_upstream_port(&sw->ports[next_port])) - return 0; + return NULL; if (!sw->ports[next_port].remote) - return 0; + return NULL; return get_switch_at_route(sw->ports[next_port].remote->sw, route >> TB_ROUTE_SHIFT); } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 5/6] thunderbolt: Use NULL instead of 0 in nhi.c
'descriptors' is a pointer. Use NULL isntead of 0. Signed-off-by: Sachin Kamat --- drivers/thunderbolt/nhi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index 346b41e7d5d1..0fc137af89f5 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -416,7 +416,7 @@ void ring_free(struct tb_ring *ring) ring->size * sizeof(*ring->descriptors), ring->descriptors, ring->descriptors_dma); - ring->descriptors = 0; + ring->descriptors = NULL; ring->descriptors_dma = 0; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/6] thunderbolt: Fix build error in eeprom.c
Fixes the below error: drivers/thunderbolt/eeprom.c:407:2: error: implicit declaration of function ‘kzalloc’ [-Werror=implicit-function-declaration] drivers/thunderbolt/eeprom.c:444:2: error: implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration] Signed-off-by: Sachin Kamat --- drivers/thunderbolt/eeprom.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thunderbolt/eeprom.c b/drivers/thunderbolt/eeprom.c index 0d5a80b2d07a..bc0449f581c2 100644 --- a/drivers/thunderbolt/eeprom.c +++ b/drivers/thunderbolt/eeprom.c @@ -5,6 +5,7 @@ */ #include +#include #include "tb.h" /** -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Build error - vmlinux.lds [Re: linux-next: Tree for Jun 18]
On Wed, Jun 18, 2014 at 5:50 PM, Russell King - ARM Linux
wrote:
> On Wed, Jun 18, 2014 at 05:38:14PM +0530, Sachin Kamat wrote:
>> On Wed, Jun 18, 2014 at 5:26 PM, Russell King - ARM Linux
>> wrote:
>> > On Wed, Jun 18, 2014 at 04:50:43PM +0530, Sachin Kamat wrote:
>> >> Hi,
>> >>
>> >> I observe the following build error while building uImage for ARM.
>> >>
>> >> Kernel: arch/arm/boot/Image is ready
>> >> make[2]: *** No rule to make target
>> >> `arch/arm/boot/compressed/vmlinux.lds', needed by
>> >> `arch/arm/boot/compressed/vmlinux'. Stop.
>> >> make[1]: *** [arch/arm/boot/compressed/vmlinux] Error 2
>> >> make: *** [uImage] Error 2
>> >
>> > Works fine here against an empty object tree:
>> >
>> > http://www.arm.linux.org.uk/developer/build/file.php?lid=9591
>> >
>> > Are you building into an already-built object tree or rebuilding an
>> > already built tree?
>>
>> I did a clean build after updating the tree to next-20140618.
>> git status show me the following after doing make clean
>>
>> # On branch master
>> # Changes not staged for commit:
>> # (use "git add/rm ..." to update what will be committed)
>> # (use "git checkout -- ..." to discard changes in working directory)
>> #
>> #deleted:arch/arm/boot/compressed/vmlinux.lds.S
>>
>>
>> My tip of kernel points to commit 4ca1fbc122fcb ("Add linux-next specific
>> files for 20140618")
>>
>> >
>> > This is likely caused by make getting confused over the dependencies.
>> > I suggest making clean to recover from this error.
>>
>> I get this error when I do a clean build too.
>
> Hmm. Please try removing vmlinux.lds.S from extra-y in
> arch/arm/boot/compressed/Makefile and restoring the deleted file.
The above steps work for me. I do not get the aforementioned build
error now.
Thanks.
Regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Build error - vmlinux.lds [Re: linux-next: Tree for Jun 18]
On Wed, Jun 18, 2014 at 5:26 PM, Russell King - ARM Linux
wrote:
> On Wed, Jun 18, 2014 at 04:50:43PM +0530, Sachin Kamat wrote:
>> Hi,
>>
>> I observe the following build error while building uImage for ARM.
>>
>> Kernel: arch/arm/boot/Image is ready
>> make[2]: *** No rule to make target
>> `arch/arm/boot/compressed/vmlinux.lds', needed by
>> `arch/arm/boot/compressed/vmlinux'. Stop.
>> make[1]: *** [arch/arm/boot/compressed/vmlinux] Error 2
>> make: *** [uImage] Error 2
>
> Works fine here against an empty object tree:
>
> http://www.arm.linux.org.uk/developer/build/file.php?lid=9591
>
> Are you building into an already-built object tree or rebuilding an
> already built tree?
I did a clean build after updating the tree to next-20140618.
git status show me the following after doing make clean
# On branch master
# Changes not staged for commit:
# (use "git add/rm ..." to update what will be committed)
# (use "git checkout -- ..." to discard changes in working directory)
#
#deleted:arch/arm/boot/compressed/vmlinux.lds.S
My tip of kernel points to commit 4ca1fbc122fcb ("Add linux-next specific
files for 20140618")
>
> This is likely caused by make getting confused over the dependencies.
> I suggest making clean to recover from this error.
I get this error when I do a clean build too.
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Build error - vmlinux.lds [Re: linux-next: Tree for Jun 18]
Hi, I observe the following build error while building uImage for ARM. Kernel: arch/arm/boot/Image is ready make[2]: *** No rule to make target `arch/arm/boot/compressed/vmlinux.lds', needed by `arch/arm/boot/compressed/vmlinux'. Stop. make[1]: *** [arch/arm/boot/compressed/vmlinux] Error 2 make: *** [uImage] Error 2 Regards, Sachin. On Wed, Jun 18, 2014 at 9:33 AM, Stephen Rothwell wrote: > Hi all, > > The powerpc allyesconfig is again broken more than usual. > > Changes since 20140617: > > Non-merge commits (relative to Linus' tree): 868 > 1021 files changed, 24269 insertions(+), 14775 deletions(-) > > > > I have created today's linux-next tree at > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > (patches at http://www.kernel.org/pub/linux/kernel/next/ ). If you > are tracking the linux-next tree using git, you should not use "git pull" > to do so as that will try to merge the new linux-next release with the > old one. You should use "git fetch" and checkout or reset to the new > master. > > You can see which trees have been included by looking in the Next/Trees > file in the source. There are also quilt-import.log and merge.log files > in the Next directory. Between each merge, the tree was built with > a ppc64_defconfig for powerpc and an allmodconfig for x86_64 and a > multi_v7_defconfig for arm. After the final fixups (if any), it is also > built with powerpc allnoconfig (32 and 64 bit), ppc44x_defconfig and > allyesconfig (this fails its final link) and i386, sparc, sparc64 and arm > defconfig. > > Below is a summary of the state of the merge. > > I am currently merging 219 trees (counting Linus' and 29 trees of patches > pending for Linus' tree). > > Stats about the size of the tree over time can be seen at > http://neuling.org/linux-next-size.html . > > Status of my local build tests will be at > http://kisskb.ellerman.id.au/linux-next . If maintainers want to give > advice about cross compilers/configs that work, we are always open to add > more builds. > > Thanks to Randy Dunlap for doing many randconfig builds. And to Paul > Gortmaker for triage and bug fixes. > > -- > Cheers, > Stephen Rothwells...@canb.auug.org.au -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Boot warnings on exynos5420 based boards
Hi Srivatsa, On Tue, Jun 17, 2014 at 3:24 PM, Srivatsa S. Bhat wrote: > On 06/17/2014 03:03 PM, Sachin Kamat wrote: > >>> Below is an updated patch, please let me know how it goes. (You'll have to >>> revert c47a9d7cca first, and then 56e692182, before trying this patch). >> >> I am unable to apply your below patch on top of the above 2 reverts. >> Applying: CPU hotplug, smp: Execute any pending IPI callbacks before CPU >> offline >> fatal: corrupt patch at line 106 >> Patch failed at 0001 CPU hotplug, smp: Execute any pending IPI >> callbacks before CPU offline >> >> Even with 'patch' I get the below failures: >> patching file kernel/smp.c >> Hunk #2 FAILED at 53. >> Hunk #3 FAILED at 179. >> 2 out of 3 hunks FAILED -- saving rejects to file kernel/smp.c.rej >> > > Hmm, weird. My mailer must have screwed it up. > > Let's try again: > > [In case this also doesn't work for you, please use this git tree in which > I have reverted the 2 old commits and added this updated patch. > > git://github.com/srivatsabhat/linux.git ipi-offline-fix-v3 > ] Unfortunately the attached patch did not apply either. Nevertheless, I applied the patch from your above mentioned tree. With that patch I do not see the warnings that I mentioned in my first mail. Thanks for fixing it. Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Boot warnings on exynos5420 based boards
Hi Srivatsa,
Thanks for your prompt reply.
On Tue, Jun 17, 2014 at 2:48 PM, Srivatsa S. Bhat
wrote:
> Hi Sachin,
>
> On 06/17/2014 01:39 PM, Sachin Kamat wrote:
>> Hi,
>>
>> I observe the below warnings while trying to boot Exynos5420 based boards
>> since yesterday's linux-next (next-20140616) using multi_v7_defconfig. Looks
>
> I guess you meant next-20140617.
I meant I started observing this warning next-20140616 onwards
(next-20140617 as well).
>
>> like it is triggered by the commit 56e6921829 ("CPU hotplug, smp:
>> flush any pending IPI callbacks before CPU offline"). Any ideas?
>>
>>
>> *
>> [0.046521] Exynos MCPM support installed
>> [0.048939] CPU1: Booted secondary processor
>> [0.065005] CPU1: update cpu_capacity 1535
>> [0.065011] CPU1: thread -1, cpu 1, socket 0, mpidr 8001
>> [0.065660] CPU2: Booted secondary processor
>> [0.085005] CPU2: update cpu_capacity 1535
>> [0.085012] CPU2: thread -1, cpu 2, socket 0, mpidr 8002
>> [0.085662] CPU3: Booted secondary processor
>> [0.105005] CPU3: update cpu_capacity 1535
>> [0.105011] CPU3: thread -1, cpu 3, socket 0, mpidr 8003
>> [1.105031] CPU4: failed to come online
>> [1.105081] [ cut here ]
>> [1.105104] WARNING: CPU: 0 PID: 1 at kernel/smp.c:228
>> flush_smp_call_function_queue+0xc0/0x178()
>> [1.105112] Modules linked in:
>> [1.105129] CPU: 0 PID: 1 Comm: swapper/0 Not tainted
>> 3.15.0-next-20140616-2-g38f9385a061b #2035
>> [1.105157] [] (unwind_backtrace) from []
>> (show_stack+0x10/0x14)
>> [1.105179] [] (show_stack) from []
>> (dump_stack+0x8c/0x9c)
>> [1.105198] [] (dump_stack) from []
>> (warn_slowpath_common+0x70/0x8c)
>> [1.105216] [] (warn_slowpath_common) from []
>> (warn_slowpath_null+0x1c/0x24)
>> [1.105235] [] (warn_slowpath_null) from []
>> (flush_smp_call_function_queue+0xc0/0x178)
>> [1.105253] [] (flush_smp_call_function_queue) from
>> [] (hotplug_cfd+0x98/0xd8)
>> [1.105269] [] (hotplug_cfd) from []
>> (notifier_call_chain+0x44/0x84)
>> [1.105285] [] (notifier_call_chain) from []
>> (_cpu_up+0x120/0x170)
>> [1.105302] [] (_cpu_up) from [] (cpu_up+0x70/0x94)
>> [1.105319] [] (cpu_up) from [] (smp_init+0xac/0xb0)
>> [1.105337] [] (smp_init) from []
>> (kernel_init_freeable+0x90/0x1dc)
>> [1.105353] [] (kernel_init_freeable) from []
>> (kernel_init+0xc/0xe8)
>> [1.105368] [] (kernel_init) from []
>> (ret_from_fork+0x14/0x3c)
>> [1.105389] ---[ end trace bc66942e4ab63168 ]---
>
> Argh! I had put the switch-case handling for CPU_DYING at the 'wrong' place,
> since I hadn't noticed that CPU_UP_CANCELED silently falls-through to
> CPU_DEAD.
> This is what happens when people don't explicitly write "fall-through" in the
> comments in a switch-case statement :-(
>
> Below is an updated patch, please let me know how it goes. (You'll have to
> revert c47a9d7cca first, and then 56e692182, before trying this patch).
I am unable to apply your below patch on top of the above 2 reverts.
Applying: CPU hotplug, smp: Execute any pending IPI callbacks before CPU offline
fatal: corrupt patch at line 106
Patch failed at 0001 CPU hotplug, smp: Execute any pending IPI
callbacks before CPU offline
Even with 'patch' I get the below failures:
patching file kernel/smp.c
Hunk #2 FAILED at 53.
Hunk #3 FAILED at 179.
2 out of 3 hunks FAILED -- saving rejects to file kernel/smp.c.rej
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Boot warnings on exynos5420 based boards
Hi,
I observe the below warnings while trying to boot Exynos5420 based boards
since yesterday's linux-next (next-20140616) using multi_v7_defconfig. Looks
like it is triggered by the commit 56e6921829 ("CPU hotplug, smp:
flush any pending IPI callbacks before CPU offline"). Any ideas?
*
[0.046521] Exynos MCPM support installed
[0.048939] CPU1: Booted secondary processor
[0.065005] CPU1: update cpu_capacity 1535
[0.065011] CPU1: thread -1, cpu 1, socket 0, mpidr 8001
[0.065660] CPU2: Booted secondary processor
[0.085005] CPU2: update cpu_capacity 1535
[0.085012] CPU2: thread -1, cpu 2, socket 0, mpidr 8002
[0.085662] CPU3: Booted secondary processor
[0.105005] CPU3: update cpu_capacity 1535
[0.105011] CPU3: thread -1, cpu 3, socket 0, mpidr 8003
[1.105031] CPU4: failed to come online
[1.105081] [ cut here ]
[1.105104] WARNING: CPU: 0 PID: 1 at kernel/smp.c:228
flush_smp_call_function_queue+0xc0/0x178()
[1.105112] Modules linked in:
[1.105129] CPU: 0 PID: 1 Comm: swapper/0 Not tainted
3.15.0-next-20140616-2-g38f9385a061b #2035
[1.105157] [] (unwind_backtrace) from []
(show_stack+0x10/0x14)
[1.105179] [] (show_stack) from []
(dump_stack+0x8c/0x9c)
[1.105198] [] (dump_stack) from []
(warn_slowpath_common+0x70/0x8c)
[1.105216] [] (warn_slowpath_common) from []
(warn_slowpath_null+0x1c/0x24)
[1.105235] [] (warn_slowpath_null) from []
(flush_smp_call_function_queue+0xc0/0x178)
[1.105253] [] (flush_smp_call_function_queue) from
[] (hotplug_cfd+0x98/0xd8)
[1.105269] [] (hotplug_cfd) from []
(notifier_call_chain+0x44/0x84)
[1.105285] [] (notifier_call_chain) from []
(_cpu_up+0x120/0x170)
[1.105302] [] (_cpu_up) from [] (cpu_up+0x70/0x94)
[1.105319] [] (cpu_up) from [] (smp_init+0xac/0xb0)
[1.105337] [] (smp_init) from []
(kernel_init_freeable+0x90/0x1dc)
[1.105353] [] (kernel_init_freeable) from []
(kernel_init+0xc/0xe8)
[1.105368] [] (kernel_init) from []
(ret_from_fork+0x14/0x3c)
[1.105389] ---[ end trace bc66942e4ab63168 ]---
[2.105047] CPU5: failed to come online
[2.105073] [ cut here ]
[2.105091] WARNING: CPU: 0 PID: 1 at kernel/smp.c:228
flush_smp_call_function_queue+0xc0/0x178()
[2.105099] Modules linked in:
[2.105114] CPU: 0 PID: 1 Comm: swapper/0 Tainted: GW
3.15.0-next-20140616-2-g38f9385a061b #2035
[2.105135] [] (unwind_backtrace) from []
(show_stack+0x10/0x14)
[2.105153] [] (show_stack) from []
(dump_stack+0x8c/0x9c)
[2.105170] [] (dump_stack) from []
(warn_slowpath_common+0x70/0x8c)
[2.105187] [] (warn_slowpath_common) from []
(warn_slowpath_null+0x1c/0x24)
[2.105205] [] (warn_slowpath_null) from []
(flush_smp_call_function_queue+0xc0/0x178)
[2.105222] [] (flush_smp_call_function_queue) from
[] (hotplug_cfd+0x98/0xd8)
[2.105237] [] (hotplug_cfd) from []
(notifier_call_chain+0x44/0x84)
[2.105252] [] (notifier_call_chain) from []
(_cpu_up+0x120/0x170)
[2.105268] [] (_cpu_up) from [] (cpu_up+0x70/0x94)
[2.105285] [] (cpu_up) from [] (smp_init+0xac/0xb0)
[2.105301] [] (smp_init) from []
(kernel_init_freeable+0x90/0x1dc)
[2.105316] [] (kernel_init_freeable) from []
(kernel_init+0xc/0xe8)
[2.105330] [] (kernel_init) from []
(ret_from_fork+0x14/0x3c)
[2.105339] ---[ end trace bc66942e4ab63169 ]---
[3.105064] CPU6: failed to come online
[3.105089] [ cut here ]
[3.105107] WARNING: CPU: 0 PID: 1 at kernel/smp.c:228
flush_smp_call_function_queue+0xc0/0x178()
[3.105115] Modules linked in:
[3.105131] CPU: 0 PID: 1 Comm: swapper/0 Tainted: GW
3.15.0-next-20140616-2-g38f9385a061b #2035
[3.105150] [] (unwind_backtrace) from []
(show_stack+0x10/0x14)
[3.105168] [] (show_stack) from []
(dump_stack+0x8c/0x9c)
[3.105185] [] (dump_stack) from []
(warn_slowpath_common+0x70/0x8c)
[3.105202] [] (warn_slowpath_common) from []
(warn_slowpath_null+0x1c/0x24)
[3.105220] [] (warn_slowpath_null) from []
(flush_smp_call_function_queue+0xc0/0x178)
[3.105237] [] (flush_smp_call_function_queue) from
[] (hotplug_cfd+0x98/0xd8)
[3.105252] [] (hotplug_cfd) from []
(notifier_call_chain+0x44/0x84)
[3.105267] [] (notifier_call_chain) from []
(_cpu_up+0x120/0x170)
[3.105283] [] (_cpu_up) from [] (cpu_up+0x70/0x94)
[3.105299] [] (cpu_up) from [] (smp_init+0xac/0xb0)
[3.105315] [] (smp_init) from []
(kernel_init_freeable+0x90/0x1dc)
[3.105330] [] (kernel_init_freeable) from []
(kernel_init+0xc/0xe8)
[3.105344] [] (kernel_init) from []
(ret_from_fork+0x14/0x3c)
[3.105353] ---[ end trace bc66942e4ab6316a ]---
[4.105081] CPU7: failed to come online
[4.105106] [ cut here ]
[4.105124] WARNING: CPU: 0 PID: 1 at kernel/smp.c:228
flush_smp_call_function_queue+0xc0/0x178()
[4.1051
Re: [PATCH] checkpatch: Warn on unnecessary void function return statements
On Tue, Jun 17, 2014 at 8:55 AM, Joe Perches wrote:
> On Tue, 2014-06-17 at 08:46 +0530, Sachin Kamat wrote:
>> On Tue, Jun 17, 2014 at 7:30 AM, Joe Perches wrote:
>> > On Mon, 2014-06-16 at 17:44 -0700, Anish Bhatt wrote:
>> >> My code has multiple exit lables:
>> >> void function(void)
>> >> {
>> >> ...
>> >>
>> >> if (err1)
>> >> goto exit1;
>> >> ...
>> >> if (err2)
>> >> goto exit2;
>> >>
>> >> ...
>> >> return; /* Good return, no errors */
>> >> exit1:
>> >> printk(err1);
>> >> return;
>> >> exit2:
>> >> printk(err2);
>> >> }
>> >>
>> >> The single tabbed return was required to prevent the good return & err1
>> >> messages cascading down. The extra exit label with a noop looks weird,
>> >> but is passing checkpatch.pl --strict, so I will go with that, thanks.
>> >> -Anish
>> >>
>> >
>> > Hmm, those return uses seem reasonable
>> > to me.
>> >
>> > Perhaps the test should warn only on
>> > this specific 3 line sequence:
>> >
>> > [any line but a label]
>> > return;
>> > }
>> >
>> > Andrew? Anyone else? Opinions?
>>
>> It should warn only if the return is followed by a value like
>> return 0; or return -EERROR_CODE; etc. and not just 'return;'
>
> No. The compiler gets to warn on those.
> checkpatch isn't a compiler.
Right. I misunderstood the context of the discussion.
Sorry for the noise.
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] checkpatch: Warn on unnecessary void function return statements
On Tue, Jun 17, 2014 at 7:30 AM, Joe Perches wrote:
> On Mon, 2014-06-16 at 17:44 -0700, Anish Bhatt wrote:
>> My code has multiple exit lables:
>> void function(void)
>> {
>> ...
>>
>> if (err1)
>> goto exit1;
>> ...
>> if (err2)
>> goto exit2;
>>
>> ...
>> return; /* Good return, no errors */
>> exit1:
>> printk(err1);
>> return;
>> exit2:
>> printk(err2);
>> }
>>
>> The single tabbed return was required to prevent the good return & err1
>> messages cascading down. The extra exit label with a noop looks weird,
>> but is passing checkpatch.pl --strict, so I will go with that, thanks.
>> -Anish
>>
>
> Hmm, those return uses seem reasonable
> to me.
>
> Perhaps the test should warn only on
> this specific 3 line sequence:
>
> [any line but a label]
> return;
> }
>
> Andrew? Anyone else? Opinions?
It should warn only if the return is followed by a value like
return 0; or return -EERROR_CODE; etc. and not just 'return;'
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG
On Sun, Jun 15, 2014 at 2:03 AM, Joe Perches wrote: > Greg? Can you please apply this soon? A similar patch has already been posted [1]. Probably Greg will apply it once 3.16-rc1 is out. [1] http://www.spinics.net/lists/linux-serial/msg12843.html Regards, Sachin. > > Thanks. > > On Sat, 2014-06-14 at 22:07 +0200, Christian Engelmayer wrote: >> Commit e4ac92d (serial: samsung: Neaten dbg uses) contains a typo in the >> changed dbg() function regarding the name of the used character buffer. >> This breaks the build if actually compiled with CONFIG_SERIAL_SAMSUNG_DEBUG. >> >> Signed-off-by: Christian Engelmayer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO
On Thu, Jun 12, 2014 at 3:27 PM, Kishon Vijay Abraham I wrote:
>
>
> On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote:
>> Hi Kishon,
>>
>> On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han wrote:
>>> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>>>
>>>> PTR_ERR_OR_ZERO simplifies the code.
>>>>
>>>> Signed-off-by: Sachin Kamat
>>>> Cc: Jingoo Han
>>>
>>> Acked-by: Jingoo Han
>>>
>>> Best regards,
>>> Jingoo Han
>>>
>>>> ---
>>>> drivers/phy/phy-exynos-dp-video.c |5 ++---
>>>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/phy/phy-exynos-dp-video.c
>>>> b/drivers/phy/phy-exynos-dp-video.c
>>>> index 0786fef842e7..098f822a2fa4 100644
>>>> --- a/drivers/phy/phy-exynos-dp-video.c
>>>> +++ b/drivers/phy/phy-exynos-dp-video.c
>>>> @@ -9,6 +9,7 @@
>>>> * published by the Free Software Foundation.
>>>> */
>>>>
>>>> +#include
>>>> #include
>>>> #include
>>>> #include
>>>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct
>>>> platform_device *pdev)
>>>> phy_set_drvdata(phy, state);
>>>>
>>>> phy_provider = devm_of_phy_provider_register(dev,
>>>> of_phy_simple_xlate);
>>>> - if (IS_ERR(phy_provider))
>>>> - return PTR_ERR(phy_provider);
>>>>
>>>> - return 0;
>>>> + return PTR_ERR_OR_ZERO(phy_provider);
>>>> }
>>>>
>>>> static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>>>> --
>>>> 1.7.9.5
>>>
>>>
>>
>> ping on this series.
>
> I'll queue to -next once -rc1 is tagged.
Thanks Kishon.
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO
Hi Kishon,
On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han wrote:
> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>
>> PTR_ERR_OR_ZERO simplifies the code.
>>
>> Signed-off-by: Sachin Kamat
>> Cc: Jingoo Han
>
> Acked-by: Jingoo Han
>
> Best regards,
> Jingoo Han
>
>> ---
>> drivers/phy/phy-exynos-dp-video.c |5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/phy/phy-exynos-dp-video.c
>> b/drivers/phy/phy-exynos-dp-video.c
>> index 0786fef842e7..098f822a2fa4 100644
>> --- a/drivers/phy/phy-exynos-dp-video.c
>> +++ b/drivers/phy/phy-exynos-dp-video.c
>> @@ -9,6 +9,7 @@
>> * published by the Free Software Foundation.
>> */
>>
>> +#include
>> #include
>> #include
>> #include
>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct
>> platform_device *pdev)
>> phy_set_drvdata(phy, state);
>>
>> phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>> - if (IS_ERR(phy_provider))
>> - return PTR_ERR(phy_provider);
>>
>> - return 0;
>> + return PTR_ERR_OR_ZERO(phy_provider);
>> }
>>
>> static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>> --
>> 1.7.9.5
>
>
ping on this series.
--
Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build
Hi Guillaume, On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet wrote: > Hi, > > please find in attachment a patch which fixes a typo in > drivers/phy/phy-exynos5250-sata.c module license. > It fixes the following build error: > FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses > GPL-only symbol 'platform_driver_unregister' > > Please keep me in CC since I am not subscribed to the > linux-kernel@vger.kernel.org ML. > > Signed-off-by: Guillaume GARDET A similar patch has already been submitted by Arnd. Please see below: https://lkml.org/lkml/2014/3/15/40 In general, sending an attachment is not the right way to submit a patch. Please refer Documentation/SubmittingPatches in the kernel source for the correct procedure. Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH Resend] mfd: asic3: Fix potential null pointer dereference
We previously assumed 'mem_sdio' could be null but it is
dereferenced in ioremap(). Add a check to avoid a potential
null pointer dereference error.
Signed-off-by: Sachin Kamat
---
drivers/mfd/asic3.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index 9f6294f2a070..9fc4186d4132 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -899,13 +899,15 @@ static int __init asic3_mfd_probe(struct platform_device
*pdev,
ds1wm_resources[0].end >>= asic->bus_shift;
/* MMC */
- asic->tmio_cnf = ioremap((ASIC3_SD_CONFIG_BASE >> asic->bus_shift) +
+ if (mem_sdio) {
+ asic->tmio_cnf = ioremap((ASIC3_SD_CONFIG_BASE >>
asic->bus_shift) +
mem_sdio->start,
ASIC3_SD_CONFIG_SIZE >> asic->bus_shift);
- if (!asic->tmio_cnf) {
- ret = -ENOMEM;
- dev_dbg(asic->dev, "Couldn't ioremap SD_CONFIG\n");
- goto out;
+ if (!asic->tmio_cnf) {
+ ret = -ENOMEM;
+ dev_dbg(asic->dev, "Couldn't ioremap SD_CONFIG\n");
+ goto out;
+ }
}
asic3_mmc_resources[0].start >>= asic->bus_shift;
asic3_mmc_resources[0].end >>= asic->bus_shift;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] regulator: ltc3589: Staticize ltc3589_reg_defaults
'ltc3589_reg_defaults' is local to this file. Make it static.
Signed-off-by: Sachin Kamat
---
drivers/regulator/ltc3589.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/ltc3589.c b/drivers/regulator/ltc3589.c
index 110a99e..217d10d6 100644
--- a/drivers/regulator/ltc3589.c
+++ b/drivers/regulator/ltc3589.c
@@ -377,7 +377,7 @@ static bool ltc3589_volatile_reg(struct device *dev,
unsigned int reg)
return false;
}
-struct reg_default ltc3589_reg_defaults[] = {
+static struct reg_default ltc3589_reg_defaults[] = {
{ LTC3589_SCR1, 0x00 },
{ LTC3589_OVEN, 0x00 },
{ LTC3589_SCR2, 0x00 },
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] serial: samsung: fix typo in debug code
Hi Arnd,
On Tue, Jun 3, 2014 at 3:23 PM, Arnd Bergmann wrote:
> commit e4ac92df2791 ("serial: samsung: Neaten dbg uses") introduced
> a regression in the conversion from vsprintf to vsnprintf.
>
> This fixes the build error by passing the correct variable name.
I submitted a similar patch sometime back.
http://www.spinics.net/lists/linux-serial/msg12843.html
Regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ARM: Remove ARCH_HAS_CPUFREQ config option
On Tue, Jun 3, 2014 at 3:37 AM, Stephen Boyd wrote: > This config exists entirely to hide the cpufreq menu from the > kernel configuration unless a platform has selected it. Nothing > is actually built if this config is 'Y' and it just leads to > more patches that add a select under a platform Kconfig so that > some other CPUfreq option can be chosen. Let's remove the > option so that we can always enable CPUfreq drivers on ARM > platforms. > > Signed-off-by: Stephen Boyd > --- > arch/arm/Kconfig | 18 -- > arch/arm/mach-davinci/Kconfig | 1 - > arch/arm/mach-highbank/Kconfig | 1 - > arch/arm/mach-imx/Kconfig | 3 --- > arch/arm/mach-mvebu/Kconfig| 1 - > arch/arm/mach-omap2/Kconfig| 1 - > arch/arm/mach-shmobile/Kconfig | 2 -- > arch/arm/mach-spear/Kconfig| 1 - > arch/arm/mach-tegra/Kconfig| 1 - > arch/arm/mach-ux500/Kconfig| 1 - > arch/arm/mach-vexpress/Kconfig | 1 - > arch/arm/mach-vt8500/Kconfig | 1 - > arch/arm/mach-zynq/Kconfig | 1 - > 13 files changed, 33 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 5e91e40c1d22..3fdae40d5114 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -179,13 +179,6 @@ config ARCH_HAS_ILOG2_U32 > config ARCH_HAS_ILOG2_U64 > bool > > -config ARCH_HAS_CPUFREQ > - bool > - help > - Internal node to signify that the ARCH has CPUFREQ support > - and that the relevant menu configurations are displayed for > - it. > - > config ARCH_HAS_BANDGAP > bool > > @@ -321,7 +314,6 @@ config ARCH_MULTIPLATFORM > > config ARCH_INTEGRATOR > bool "ARM Ltd. Integrator family" > - select ARCH_HAS_CPUFREQ > select ARM_AMBA > select ARM_PATCH_PHYS_VIRT > select AUTO_ZRELADDR > @@ -540,7 +532,6 @@ config ARCH_DOVE > > config ARCH_KIRKWOOD > bool "Marvell Kirkwood" > - select ARCH_HAS_CPUFREQ > select ARCH_REQUIRE_GPIOLIB > select CPU_FEROCEON > select GENERIC_CLOCKEVENTS > @@ -639,7 +630,6 @@ config ARCH_LPC32XX > config ARCH_PXA > bool "PXA2xx/PXA3xx-based" > depends on MMU > - select ARCH_HAS_CPUFREQ > select ARCH_MTD_XIP > select ARCH_REQUIRE_GPIOLIB > select ARM_CPU_SUSPEND if PM > @@ -709,7 +699,6 @@ config ARCH_RPC > > config ARCH_SA1100 > bool "SA1100-based" > - select ARCH_HAS_CPUFREQ > select ARCH_MTD_XIP > select ARCH_REQUIRE_GPIOLIB > select ARCH_SPARSEMEM_ENABLE > @@ -727,7 +716,6 @@ config ARCH_SA1100 > > config ARCH_S3C24XX > bool "Samsung S3C24XX SoCs" > - select ARCH_HAS_CPUFREQ > select ARCH_REQUIRE_GPIOLIB > select ATAGS > select CLKDEV_LOOKUP > @@ -748,7 +736,6 @@ config ARCH_S3C24XX > > config ARCH_S3C64XX > bool "Samsung S3C64XX" > - select ARCH_HAS_CPUFREQ > select ARCH_REQUIRE_GPIOLIB > select ARM_AMBA > select ARM_VIC > @@ -811,7 +798,6 @@ config ARCH_S5PC100 > > config ARCH_S5PV210 > bool "Samsung S5PV210/S5PC110" > - select ARCH_HAS_CPUFREQ > select ARCH_HAS_HOLES_MEMORYMODEL > select ARCH_SPARSEMEM_ENABLE > select ATAGS > @@ -831,7 +817,6 @@ config ARCH_S5PV210 > > config ARCH_EXYNOS > bool "Samsung EXYNOS" > - select ARCH_HAS_CPUFREQ > select ARCH_HAS_HOLES_MEMORYMODEL > select ARCH_REQUIRE_GPIOLIB > select ARCH_SPARSEMEM_ENABLE I think this patch is not based on the latest code base as ARCH_EXYNOS symbol is now defined in arch/arm/mach-exynos/Kconfig file. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] pinctrl: sunxi: Fix potential null pointer dereference
kzalloc can fail. Add a null check to avoid null pointer
dereference error while accessing the pointer later.
Signed-off-by: Sachin Kamat
---
drivers/pinctrl/sunxi/pinctrl-sunxi.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index f1ca75e6d7b1..5f38c7f67834 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -211,6 +211,10 @@ static int sunxi_pctrl_dt_node_to_map(struct pinctrl_dev
*pctldev,
configlen++;
pinconfig = kzalloc(configlen * sizeof(*pinconfig), GFP_KERNEL);
+ if (!pinconfig) {
+ kfree(*map);
+ return -ENOMEM;
+ }
if (!of_property_read_u32(node, "allwinner,drive", &val)) {
u16 strength = (val + 1) * 10;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] mfd: asic3: Fix potential null pointer dereference
We previously assumed 'mem_sdio' could be null but it is
dereferenced in ioremap(). Add a check to avoid a potential
null pointer dereference error.
Signed-off-by: Sachin Kamat
---
drivers/mfd/asic3.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index 9f6294f2a070..9fc4186d4132 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -899,13 +899,15 @@ static int __init asic3_mfd_probe(struct platform_device
*pdev,
ds1wm_resources[0].end >>= asic->bus_shift;
/* MMC */
- asic->tmio_cnf = ioremap((ASIC3_SD_CONFIG_BASE >> asic->bus_shift) +
+ if (mem_sdio) {
+ asic->tmio_cnf = ioremap((ASIC3_SD_CONFIG_BASE >>
asic->bus_shift) +
mem_sdio->start,
ASIC3_SD_CONFIG_SIZE >> asic->bus_shift);
- if (!asic->tmio_cnf) {
- ret = -ENOMEM;
- dev_dbg(asic->dev, "Couldn't ioremap SD_CONFIG\n");
- goto out;
+ if (!asic->tmio_cnf) {
+ ret = -ENOMEM;
+ dev_dbg(asic->dev, "Couldn't ioremap SD_CONFIG\n");
+ goto out;
+ }
}
asic3_mmc_resources[0].start >>= asic->bus_shift;
asic3_mmc_resources[0].end >>= asic->bus_shift;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V4 2/8] opp: call of_node_{get|put}() from of_init_opp_table()
Hi Viresh,
On 27 May 2014 17:20, Viresh Kumar wrote:
> All callers of of_init_opp_table() are required to take reference of
> dev->of_node, by initiating calls to of_node_{get|put}(), before and after
> calling of_init_opp_table().
>
> Its better to call these from within of_init_opp_table(), no fun adding
> redundant code to every caller.
>
> Signed-off-by: Viresh Kumar
> ---
> drivers/base/power/opp.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
> index faae9cf..2b615b9 100644
> --- a/drivers/base/power/opp.c
> +++ b/drivers/base/power/opp.c
> @@ -622,6 +622,9 @@ int of_init_opp_table(struct device *dev)
> const __be32 *val;
> int nr;
>
> + if (!of_node_get(dev->of_node))
> + return -ENODEV;
> +
> prop = of_find_property(dev->of_node, "operating-points", NULL);
> if (!prop)
> return -ENODEV;
What about of_node_put before returning here and other places in this function?
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] mfd: menelaus: Use module_i2c_driver
module_i2c_driver simplifies the code by eliminating
boilerplate code.
Signed-off-by: Sachin Kamat
---
drivers/mfd/menelaus.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
index ad25bfa3fb02..5e2667afe2bc 100644
--- a/drivers/mfd/menelaus.c
+++ b/drivers/mfd/menelaus.c
@@ -1287,29 +1287,8 @@ static struct i2c_driver menelaus_i2c_driver = {
.id_table = menelaus_id,
};
-static int __init menelaus_init(void)
-{
- int res;
-
- res = i2c_add_driver(&menelaus_i2c_driver);
- if (res < 0) {
- pr_err(DRIVER_NAME ": driver registration failed\n");
- return res;
- }
-
- return 0;
-}
-
-static void __exit menelaus_exit(void)
-{
- i2c_del_driver(&menelaus_i2c_driver);
-
- /* FIXME: Shutdown menelaus parts that can be shut down */
-}
+module_i2c_driver(menelaus_i2c_driver);
MODULE_AUTHOR("Texas Instruments, Inc. (and others)");
MODULE_DESCRIPTION("I2C interface for Menelaus.");
MODULE_LICENSE("GPL");
-
-module_init(menelaus_init);
-module_exit(menelaus_exit);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3/3] phy: sun4i-usb: Use PTR_ERR_OR_ZERO
PTR_ERR_OR_ZERO simplifies the code.
Signed-off-by: Sachin Kamat
Cc: Hans de Goede
Cc: Maxime Ripard
---
drivers/phy/phy-sun4i-usb.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
index 115d8d5190d5..7a4ea552f621 100644
--- a/drivers/phy/phy-sun4i-usb.c
+++ b/drivers/phy/phy-sun4i-usb.c
@@ -22,6 +22,7 @@
*/
#include
+#include
#include
#include
#include
@@ -306,10 +307,8 @@ static int sun4i_usb_phy_probe(struct platform_device
*pdev)
dev_set_drvdata(dev, data);
phy_provider = devm_of_phy_provider_register(dev, sun4i_usb_phy_xlate);
- if (IS_ERR(phy_provider))
- return PTR_ERR(phy_provider);
- return 0;
+ return PTR_ERR_OR_ZERO(phy_provider);
}
static const struct of_device_id sun4i_usb_phy_of_match[] = {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO
PTR_ERR_OR_ZERO simplifies the code.
Signed-off-by: Sachin Kamat
Cc: Jingoo Han
---
drivers/phy/phy-exynos-dp-video.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/phy-exynos-dp-video.c
b/drivers/phy/phy-exynos-dp-video.c
index 0786fef842e7..098f822a2fa4 100644
--- a/drivers/phy/phy-exynos-dp-video.c
+++ b/drivers/phy/phy-exynos-dp-video.c
@@ -9,6 +9,7 @@
* published by the Free Software Foundation.
*/
+#include
#include
#include
#include
@@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device
*pdev)
phy_set_drvdata(phy, state);
phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
- if (IS_ERR(phy_provider))
- return PTR_ERR(phy_provider);
- return 0;
+ return PTR_ERR_OR_ZERO(phy_provider);
}
static const struct of_device_id exynos_dp_video_phy_of_match[] = {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/3] phy: exynos-mipi-video: Use PTR_ERR_OR_ZERO
PTR_ERR_OR_ZERO simplifies the code.
Signed-off-by: Sachin Kamat
Cc: Sylwester Nawrocki
---
drivers/phy/phy-exynos-mipi-video.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/phy-exynos-mipi-video.c
b/drivers/phy/phy-exynos-mipi-video.c
index ff026689358c..6d6bcf52a10e 100644
--- a/drivers/phy/phy-exynos-mipi-video.c
+++ b/drivers/phy/phy-exynos-mipi-video.c
@@ -9,6 +9,7 @@
* published by the Free Software Foundation.
*/
+#include
#include
#include
#include
@@ -149,10 +150,8 @@ static int exynos_mipi_video_phy_probe(struct
platform_device *pdev)
phy_provider = devm_of_phy_provider_register(dev,
exynos_mipi_video_phy_xlate);
- if (IS_ERR(phy_provider))
- return PTR_ERR(phy_provider);
- return 0;
+ return PTR_ERR_OR_ZERO(phy_provider);
}
static const struct of_device_id exynos_mipi_video_phy_of_match[] = {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] ARM: ux500: Staticize local symbols in cpu-db8500.c
Symbols local to this file are made static.
Signed-off-by: Sachin Kamat
---
arch/arm/mach-ux500/cpu-db8500.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-ux500/cpu-db8500.c b/arch/arm/mach-ux500/cpu-db8500.c
index fa308f07fae5..6f63954c8bde 100644
--- a/arch/arm/mach-ux500/cpu-db8500.c
+++ b/arch/arm/mach-ux500/cpu-db8500.c
@@ -33,11 +33,11 @@
#include "db8500-regs.h"
#include "id.h"
-struct ab8500_platform_data ab8500_platdata = {
+static struct ab8500_platform_data ab8500_platdata = {
.regulator = &ab8500_regulator_plat_data,
};
-struct prcmu_pdata db8500_prcmu_pdata = {
+static struct prcmu_pdata db8500_prcmu_pdata = {
.ab_platdata= &ab8500_platdata,
.version_offset = DB8500_PRCMU_FW_VERSION_OFFSET,
.legacy_offset = DB8500_PRCMU_LEGACY_OFFSET,
@@ -82,7 +82,7 @@ static struct map_desc u9540_io_desc[] __initdata = {
__IO_DEV_DESC(U8500_PRCMU_TCDM_BASE, SZ_4K + SZ_8K),
};
-void __init u8500_map_io(void)
+static void __init u8500_map_io(void)
{
/*
* Map the UARTs early so that the DEBUG_LL stuff continues to work.
@@ -119,7 +119,7 @@ static irqreturn_t db8500_pmu_handler(int irq, void *dev,
irq_handler_t handler)
return ret;
}
-struct arm_pmu_platdata db8500_pmu_platdata = {
+static struct arm_pmu_platdata db8500_pmu_platdata = {
.handle_irq = db8500_pmu_handler,
};
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] ARM: ux500: Staticize ab8505_regulators
'ab8505_regulators' is used only in this file.
Signed-off-by: Sachin Kamat
---
arch/arm/mach-ux500/board-mop500-regulators.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/board-mop500-regulators.c
b/arch/arm/mach-ux500/board-mop500-regulators.c
index a4e139aa2441..32d744e91ec2 100644
--- a/arch/arm/mach-ux500/board-mop500-regulators.c
+++ b/arch/arm/mach-ux500/board-mop500-regulators.c
@@ -796,7 +796,7 @@ static struct ab8500_regulator_reg_init ab8505_reg_init[] =
{
INIT_REGULATOR_REGISTER(AB8505_CTRLVAUX6, 0x00, 0x00),
};
-struct regulator_init_data ab8505_regulators[AB8505_NUM_REGULATORS] = {
+static struct regulator_init_data ab8505_regulators[AB8505_NUM_REGULATORS] = {
/* supplies to the display/camera */
[AB8505_LDO_AUX1] = {
.constraints = {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr
Hi Lee, On 28 May 2014 14:06, Lee Jones wrote: > On Wed, 28 May 2014, Sachin Kamat wrote: > >> 'ux500_soc_attr' is local to this file. While at it also make it >> const to match the argument list of device_create_file. > > What's going on Sachin? I Acked v2 of this patch an hour ago, yet > you've resent it as a v1 and without the Ack? Actually I posted v2 twice almost immediately. The first time I forgot to CC LKML as requested by you. Sorry for the confusion. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr
'ux500_soc_attr' is local to this file. While at it also make it const to match the argument list of device_create_file. Signed-off-by: Sachin Kamat --- arch/arm/mach-ux500/cpu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c index db16b5a04ad5..dbb2970ee7da 100644 --- a/arch/arm/mach-ux500/cpu.c +++ b/arch/arm/mach-ux500/cpu.c @@ -125,7 +125,7 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr, soc_dev_attr->revision = ux500_get_revision(); } -struct device_attribute ux500_soc_attr = +static const struct device_attribute ux500_soc_attr = __ATTR(process, S_IRUGO, ux500_get_process, NULL); struct device * __init ux500_soc_device_init(const char *soc_id) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] bus: vexpress-config: Export devm_regmap_init_vexpress_config
Export this symbol to avoid build error when built as module. ERROR: "devm_regmap_init_vexpress_config" [drivers/regulator/vexpress.ko] undefined! Signed-off-by: Sachin Kamat --- drivers/bus/vexpress-config.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c index 27a07dfcd626..2af2227874af 100644 --- a/drivers/bus/vexpress-config.c +++ b/drivers/bus/vexpress-config.c @@ -118,6 +118,7 @@ struct regmap *devm_regmap_init_vexpress_config(struct device *dev) return regmap; } +EXPORT_SYMBOL(devm_regmap_init_vexpress_config); struct device *vexpress_config_bridge_register(struct device *parent, -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay
On 26 May 2014 13:56, Krzysztof Kozlowski wrote:
> Fix the register for ramp delay of buck1 regulator. Buck1 and buck6
> share the field (offset 4) in ramp delay register S2MPA01_REG_RAMP2.
>
> The driver used the same register and field for ramp delay of buck3 and
> buck1. This lead to updating of ramp delay of buck3 when setting buck1
> and actually the ramp delay of buck1 was never set.
>
> Cc:
> Fixes: f18792714608 ("regulator: Add support for S2MPA01 regulator")
> Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Sachin Kamat
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay
Hi Krzysztof Apologies for the delay. I was on vacation during the early part of this month and got busy with some other stuff later and this mail fell through the cracks. On 23 May 2014 19:49, Krzysztof Kozlowski wrote: > Hi Sachin, > > The s2mpa01 regulator driver uses wrong registers for ramp delay (buck1 > and buck3 in RAMP1, buck6 in RAMP2) but I am not sure which layout is > proper (it seems that that buck1 should be in RAMP2 register). > > Could you check in S2MPA01 datasheet the registers for ramp delay for > buck1, buck3 and buck6? I checked the datasheet available with me and according to it buck 1 and 6 share the ramp register 0x11 (RAMP2) (bit 4 and 5) and buck 3 uses bit 4 and 5 of register 0x10 (RAMP1). -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] input: gpio_keys: Add IRQF_NO_SUSPEND flag to wake-up from freeze state
Hi Chanwoo, On 26 May 2014 10:27, Chanwoo Choi wrote: > This patch add IRQF_NO_SUSPEND flag before requesting interrupt handler > if button->wakeup is true. If ther interrupt of gpio-keys hasn't included > IRQF_NO_SUSPEND, wouldn't wake-up from freeze state when pressing button. Please refer to the below thread. Looks like it was similar to what you are proposing. http://www.spinics.net/lists/linux-input/msg28780.html -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] cpufreq: s5pv210: drop check for CONFIG_PM_VERBOSE
Hi Paul, On 23 May 2014 20:35, Paul Bolle wrote: > A pr_err() was added in v3.1. It was guarded by a check for > CONFIG_PM_VERBOSE. The Kconfig symbol PM_VERBOSE was removed in v3.0. So > this pr_err() has never been used. Drop that check and clean up the > message a bit. > > Signed-off-by: Paul Bolle Reviewed-by: Sachin Kamat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] cpufreq: s5pv210: remove unused call of pr_err()
Hi Paul,
On 22 May 2014 12:11, Paul Bolle wrote:
> Sachin,
>
> On Thu, 2014-05-22 at 08:52 +0530, Sachin Kamat wrote:
>> The config symbol itself is not defined and hence could be removed.
>> However I feel, the
>> error message could be retained after trimming down the arguments a bit.
>
> My reasoning is, of course, that never used code can simply be dropped.
Yes, I agree. However the error message in this case should have been outside
the ifdefs to begin with as it is not an extra information but an
essential message
reporting error condition.
>
> But you want to print an error here. That's fine with me. I prefer if
> you'd submit a patch that does that, as I have no idea whatsoever why an
> error is needed here nor what that error should say.
You may just remove the __FILE__ and __LINE__ thing and leave the message as is.
pr_err("Denied access to %s as it is disabled temporarily\n", __func__);
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] cpufreq: s5pv210: remove unused call of pr_err()
On 22 May 2014 09:44, Viresh Kumar wrote:
> On 22 May 2014 08:52, Sachin Kamat wrote:
>> On 22 May 2014 01:23, Paul Bolle wrote:
>>> A call of pr_err() was added in v3.1. It was guarded by a check for
>>> CONFIG_PM_VERBOSE. The Kconfig symbol PM_VERBOSE was removed in v3.0. So
>>> this call of pr_err() has never been used. Remove it.
>>>
>>> Signed-off-by: Paul Bolle
>>> ---
>>> Untested.
>>>
>>> drivers/cpufreq/s5pv210-cpufreq.c | 4
>>> 1 file changed, 4 deletions(-)
>>>
>>> diff --git a/drivers/cpufreq/s5pv210-cpufreq.c
>>> b/drivers/cpufreq/s5pv210-cpufreq.c
>>> index ab2c1a40d437..0873729135df 100644
>>> --- a/drivers/cpufreq/s5pv210-cpufreq.c
>>> +++ b/drivers/cpufreq/s5pv210-cpufreq.c
>>> @@ -175,10 +175,6 @@ static int s5pv210_target(struct cpufreq_policy
>>> *policy, unsigned int index)
>>> mutex_lock(&set_freq_lock);
>>>
>>> if (no_cpufreq_access) {
>>> -#ifdef CONFIG_PM_VERBOSE
>>> - pr_err("%s:%d denied access to %s as it is disabled"
>>> - "temporarily\n", __FILE__, __LINE__,
>>> __func__);
>>> -#endif
>>
>> The config symbol itself is not defined and hence could be removed.
>
> What do you meant by this? He already got rid of CONFIG_PM_VERBOSE..
Yes, my ack for that change :)
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] cpufreq: s5pv210: remove unused call of pr_err()
On 22 May 2014 01:23, Paul Bolle wrote:
> A call of pr_err() was added in v3.1. It was guarded by a check for
> CONFIG_PM_VERBOSE. The Kconfig symbol PM_VERBOSE was removed in v3.0. So
> this call of pr_err() has never been used. Remove it.
>
> Signed-off-by: Paul Bolle
> ---
> Untested.
>
> drivers/cpufreq/s5pv210-cpufreq.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/s5pv210-cpufreq.c
> b/drivers/cpufreq/s5pv210-cpufreq.c
> index ab2c1a40d437..0873729135df 100644
> --- a/drivers/cpufreq/s5pv210-cpufreq.c
> +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> @@ -175,10 +175,6 @@ static int s5pv210_target(struct cpufreq_policy *policy,
> unsigned int index)
> mutex_lock(&set_freq_lock);
>
> if (no_cpufreq_access) {
> -#ifdef CONFIG_PM_VERBOSE
> - pr_err("%s:%d denied access to %s as it is disabled"
> - "temporarily\n", __FILE__, __LINE__,
> __func__);
> -#endif
The config symbol itself is not defined and hence could be removed.
However I feel, the
error message could be retained after trimming down the arguments a bit.
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 4/4] ARM: dts: Add usb 2.0 support on exynos5420
On 30 April 2014 14:25, Vivek Gautam wrote:
> Add required device node for ehci and ohci controllers to
> enable USB 2.0 support.
>
> Signed-off-by: Vivek Gautam
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 36 +++-
> 1 file changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi
> index 16b860a..392d340 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -738,7 +738,41 @@
> samsung,power-domain = <&g2d_pd>;
> };
>
> - phy@1213 {
> + usb@1211 {
> + compatible = "samsung,exynos4210-ehci";
> + reg = <0x1211 0x100>;
> + interrupts = <0 71 0>;
> +
> + clocks = <&clock CLK_USBH20>;
> + clock-names = "usbhost";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + phys = <&usb2_phy_gen 1>;
> + phy-names = "host";
> + status = "ok";
s/ok/okay
> + };
> + };
> +
> + usb@1212 {
> + compatible = "samsung,exynos4210-ohci";
> + reg = <0x1212 0x100>;
> + interrupts = <0 71 0>;
> +
> + clocks = <&clock CLK_USBH20>;
> + clock-names = "usbhost";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + phys = <&usb2_phy_gen 1>;
> + phy-names = "host";
> + status = "ok";
ditto
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/4] ARM: dts: Add usb2phy to Exynos 5250
Hi Vivek,
On 30 April 2014 14:25, Vivek Gautam wrote:
> From: Kamil Debski
>
> Add support to PHY of USB2 of the Exynos 5250 SoC.
>
> Signed-off-by: Kamil Debski
> [gautam.vi...@samsung.com: Split the usb phy entries from
> syscon entries from earlier patch: dts: Add usb2phy to Exynos 5250]
> [gautam.vi...@samsung.com: Added phy entry for OHCI also along with EHCI]
> Signed-off-by: Vivek Gautam
> ---
>
> Changes from v7:
> None
>
> arch/arm/boot/dts/exynos5250.dtsi | 26 ++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 70f0cd5..51e554c 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -563,6 +563,14 @@
>
> clocks = <&clock CLK_USB2>;
> clock-names = "usbhost";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + phys = <&usb2_phy_gen 1>;
> + phy-names = "host";
> + status = "ok";
This should be "okay".
> + };
> };
>
> usb@1212 {
> @@ -572,6 +580,14 @@
>
> clocks = <&clock CLK_USB2>;
> clock-names = "usbhost";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + phys = <&usb2_phy_gen 1>;
> + phy-names = "host";
> + status = "ok";
ditto.
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Idea: regulator: Merge s2mpa01 with s2mps11
Hi Krzysztof, On 30 April 2014 18:56, Krzysztof Kozlowski wrote: > Dear Sachin, > > > The S2MPA01 and S2MPS1X PMICs regulator drivers look quite similar to > each other. Most of the S2MPA01 driver is the same as S2MPS11 (except > changes added for supporting S2MPS14). > > I would like to merge these drivers into one. However I do not have > neither any board with S2MPA01 nor S2MPA01 datasheet. > > What do you think about merging them? It is a good idea to merge them. That was my initial plan too. I appreciate your offer to do the same. >Could you test it later when I will finish the development? I will not be able to do it immediately though as currently I am involved with some other activity on a different h/w and will be on vacation for some time later next week onwards. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
