Re: [PATCH v3 05/12] ARM: EXYNOS: Remove file path from comment section

2014-04-30 Thread Sachin Kamat
Reviewed-by: Tomasz Figa t.f...@samsung.com --- The change is sensible. However Kukjin had refused to accept such patches when I had submitted patches doing such cleanup for all Samsung platform files. Anyway, FWIW Reviewed-by: Sachin Kamat sachin.ka...@linaro.org -- With warm regards, Sachin

Re: Idea: regulator: Merge s2mpa01 with s2mps11

2014-04-30 Thread Sachin Kamat
Hi Krzysztof, On 30 April 2014 18:56, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Dear Sachin, The S2MPA01 and S2MPS1X PMICs regulator drivers look quite similar to each other. Most of the S2MPA01 driver is the same as S2MPS11 (except changes added for supporting S2MPS14). I would

Re: [PATCH 2/4] ARM: dts: Add usb2phy to Exynos 5250

2014-04-30 Thread Sachin Kamat
Hi Vivek, On 30 April 2014 14:25, Vivek Gautam gautam.vi...@samsung.com wrote: From: Kamil Debski k.deb...@samsung.com Add support to PHY of USB2 of the Exynos 5250 SoC. Signed-off-by: Kamil Debski k.deb...@samsung.com [gautam.vi...@samsung.com: Split the usb phy entries from syscon

Re: [PATCH 4/4] ARM: dts: Add usb 2.0 support on exynos5420

2014-04-30 Thread Sachin Kamat
On 30 April 2014 14:25, Vivek Gautam gautam.vi...@samsung.com wrote: Add required device node for ehci and ohci controllers to enable USB 2.0 support. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 36 +++- 1

Re: [PATCH 5/5] devfreq: exynos5: Use devm_devfreq_* function using device resource management

2014-04-29 Thread Sachin Kamat
Hi Chanwoo, On 25 April 2014 14:38, Chanwoo Choi wrote: > This patch uses devm_devfreq_add_device()/devm_devfreq_register_opp_notifier() > to control automatically the resource of devfreq. > > Signed-off-by: Chanwoo Choi > Cc: Kukjin Kim > Cc: Sachin Kamat > Cc: Bart

Re: [PATCH 5/5] devfreq: exynos5: Use devm_devfreq_* function using device resource management

2014-04-29 Thread Sachin Kamat
@samsung.com Cc: Sachin Kamat sachin.ka...@linaro.org Cc: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Cc: Manish Badarkhe badarkhe.man...@gmail.com Cc: Abhilash Kesavan a.kesa...@samsung.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org --- drivers/devfreq

Re: [PATCH 0/2] Support cpufreq driver for Exynos3250

2014-04-19 Thread Sachin Kamat
Hi Tomasz, On 19 April 2014 19:21, Tomasz Figa wrote: > Hi Chanwoo, Sachin, > > > On 19.04.2014 15:43, Chanwoo Choi wrote: >> >> Hi Sachin, >> >> On Fri, Apr 18, 2014 at 5:14 PM, Sachin Kamat >> wrote: >>> >>> Hi

Re: [PATCH 0/2] Support cpufreq driver for Exynos3250

2014-04-19 Thread Sachin Kamat
Hi Tomasz, On 19 April 2014 19:21, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Chanwoo, Sachin, On 19.04.2014 15:43, Chanwoo Choi wrote: Hi Sachin, On Fri, Apr 18, 2014 at 5:14 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Chanwoo, On 18 April 2014 07:50, Chanwoo Choi cw00.c

Re: [PATCH 0/2] Support cpufreq driver for Exynos3250

2014-04-18 Thread Sachin Kamat
Hi Chanwoo, On 18 April 2014 07:50, Chanwoo Choi wrote: > This patchset support cpufreq driver for Exynos3250 which uses the Cortex-A7 > dual cores and has a target speed of 1.0 GHz and code clean using dev_err/info > instead of pr_err/info function. Per SoC cpufreq driver which does not use

Re: [PATCH 0/2] Support cpufreq driver for Exynos3250

2014-04-18 Thread Sachin Kamat
Hi Chanwoo, On 18 April 2014 07:50, Chanwoo Choi cw00.c...@samsung.com wrote: This patchset support cpufreq driver for Exynos3250 which uses the Cortex-A7 dual cores and has a target speed of 1.0 GHz and code clean using dev_err/info instead of pr_err/info function. Per SoC cpufreq driver

Re: [PATCHv2 1/2] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-04-15 Thread Sachin Kamat
Hi Chanwoo, On 16 April 2014 10:25, Chanwoo Choi wrote: > Hi Sachin, > > On 04/16/2014 01:44 PM, Chanwoo Choi wrote: >> Hi Sachin, >> >> On 04/16/2014 12:48 PM, Sachin Kamat wrote: >>> Hi Chanwoo, >>> >>> On 14 April 2014 14:37, Chanwoo Choi

Re: [PATCHv2 1/2] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-04-15 Thread Sachin Kamat
Hi Chanwoo, On 14 April 2014 14:37, Chanwoo Choi wrote: > This patch control special clock for ADC in Exynos series's FSYS block. > If special clock of ADC is registerd on clock list of common clk framework, > Exynos ADC drvier have to control this clock. > > Exynos3250/Exynos4/Exynos5 has 'adc'

Re: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11

2014-04-15 Thread Sachin Kamat
On 15 April 2014 14:25, Krzysztof Kozlowski wrote: > On wto, 2014-04-15 at 14:02 +0530, Sachin Kamat wrote: >> On 15 April 2014 13:42, Krzysztof Kozlowski wrote: >> > On wto, 2014-04-15 at 13:26 +0530, Sachin Kamat wrote: >> >> On 15 April 2014 02:41, Mark Brown

Re: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11

2014-04-15 Thread Sachin Kamat
On 15 April 2014 13:42, Krzysztof Kozlowski wrote: > On wto, 2014-04-15 at 13:26 +0530, Sachin Kamat wrote: >> On 15 April 2014 02:41, Mark Brown wrote: >> > On Mon, Apr 14, 2014 at 10:09:09AM +0200, Krzysztof Kozlowski wrote: >> > >> >> - - s5m8767,

Re: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11

2014-04-15 Thread Sachin Kamat
On 15 April 2014 02:41, Mark Brown wrote: > On Mon, Apr 14, 2014 at 10:09:09AM +0200, Krzysztof Kozlowski wrote: > >> - - s5m8767,pmic-ext-control-gpios: (optional) GPIO specifier for one >> + - samsung,ext-control-gpios: (optional) GPIO specifier for one >> GPIO controlling

Re: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11

2014-04-15 Thread Sachin Kamat
On 15 April 2014 02:41, Mark Brown broo...@kernel.org wrote: On Mon, Apr 14, 2014 at 10:09:09AM +0200, Krzysztof Kozlowski wrote: - - s5m8767,pmic-ext-control-gpios: (optional) GPIO specifier for one + - samsung,ext-control-gpios: (optional) GPIO specifier for one GPIO

Re: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11

2014-04-15 Thread Sachin Kamat
On 15 April 2014 13:42, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On wto, 2014-04-15 at 13:26 +0530, Sachin Kamat wrote: On 15 April 2014 02:41, Mark Brown broo...@kernel.org wrote: On Mon, Apr 14, 2014 at 10:09:09AM +0200, Krzysztof Kozlowski wrote: - - s5m8767,pmic-ext

Re: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11

2014-04-15 Thread Sachin Kamat
On 15 April 2014 14:25, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On wto, 2014-04-15 at 14:02 +0530, Sachin Kamat wrote: On 15 April 2014 13:42, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On wto, 2014-04-15 at 13:26 +0530, Sachin Kamat wrote: On 15 April 2014 02:41, Mark

Re: [PATCHv2 1/2] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-04-15 Thread Sachin Kamat
Hi Chanwoo, On 14 April 2014 14:37, Chanwoo Choi cw00.c...@samsung.com wrote: This patch control special clock for ADC in Exynos series's FSYS block. If special clock of ADC is registerd on clock list of common clk framework, Exynos ADC drvier have to control this clock.

Re: [PATCHv2 1/2] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-04-15 Thread Sachin Kamat
Hi Chanwoo, On 16 April 2014 10:25, Chanwoo Choi cw00.c...@samsung.com wrote: Hi Sachin, On 04/16/2014 01:44 PM, Chanwoo Choi wrote: Hi Sachin, On 04/16/2014 12:48 PM, Sachin Kamat wrote: Hi Chanwoo, On 14 April 2014 14:37, Chanwoo Choi cw00.c...@samsung.com wrote: This patch control

Re: [PATCH 01/27] ARM: EXYNOS: Add Exynos3250 SoC ID

2014-04-10 Thread Sachin Kamat
Hi Chanwoo, On 11 April 2014 11:24, Chanwoo Choi wrote: > Hi Sachin, > > On 04/11/2014 12:56 PM, Sachin Kamat wrote: >> Hi Chanwoo, >> >> On 10 April 2014 15:07, Chanwoo Choi wrote: >>> This patch add Exynos3250's SoC ID. Exynos 3250 is System-On-Chip(SoC)

Re: [PATCH 15/27] ARM: dts: exynos3250: Add uart dt node to support seiral ports

2014-04-10 Thread Sachin Kamat
On 10 April 2014 15:36, Chanwoo Choi wrote: > This patch add UART dt node for Exynos3250. Exynos3250 uses same UART IP > of Exynos4 SoC and has only two independent channels. > > Signed-off-by: Chanwoo Choi > [Fix incorrect clock id by Tomasz Figa] > Signed-off-by: Tomasz Figa > Signed-off-by:

Re: [PATCH 10/27] ARM: dts: exynos3250: Add new exynos3250.dtsi file

2014-04-10 Thread Sachin Kamat
Hi Chanwoo, On 10 April 2014 15:36, Chanwoo Choi wrote: > From: Tomasz Figa > > This patch add new exynos3250.dtsi to support Exynos3250 SoC and includes > chipid/sys_reg dt node. > > Signed-off-by: Tomasz Figa > Signed-off-by: Chanwoo Choi > Signed-off-by: Kyungmin Park > --- >

Re: [PATCH 01/27] ARM: EXYNOS: Add Exynos3250 SoC ID

2014-04-10 Thread Sachin Kamat
Hi Chanwoo, On 10 April 2014 15:07, Chanwoo Choi wrote: > This patch add Exynos3250's SoC ID. Exynos 3250 is System-On-Chip(SoC) that > is based on the 32-bit RISC processor for Smartphone. Exynos3250 uses > Cortex-A7 > dual cores and has a target speed of 1.0GHz. > > Signed-off-by: Chanwoo

Re: [PATCH 01/27] ARM: EXYNOS: Add Exynos3250 SoC ID

2014-04-10 Thread Sachin Kamat
Hi Chanwoo, On 10 April 2014 15:07, Chanwoo Choi cw00.c...@samsung.com wrote: This patch add Exynos3250's SoC ID. Exynos 3250 is System-On-Chip(SoC) that is based on the 32-bit RISC processor for Smartphone. Exynos3250 uses Cortex-A7 dual cores and has a target speed of 1.0GHz.

Re: [PATCH 10/27] ARM: dts: exynos3250: Add new exynos3250.dtsi file

2014-04-10 Thread Sachin Kamat
Hi Chanwoo, On 10 April 2014 15:36, Chanwoo Choi cw00.c...@samsung.com wrote: From: Tomasz Figa t.f...@samsung.com This patch add new exynos3250.dtsi to support Exynos3250 SoC and includes chipid/sys_reg dt node. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Chanwoo Choi

Re: [PATCH 15/27] ARM: dts: exynos3250: Add uart dt node to support seiral ports

2014-04-10 Thread Sachin Kamat
On 10 April 2014 15:36, Chanwoo Choi cw00.c...@samsung.com wrote: This patch add UART dt node for Exynos3250. Exynos3250 uses same UART IP of Exynos4 SoC and has only two independent channels. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com [Fix incorrect clock id by Tomasz Figa]

Re: [PATCH 01/27] ARM: EXYNOS: Add Exynos3250 SoC ID

2014-04-10 Thread Sachin Kamat
Hi Chanwoo, On 11 April 2014 11:24, Chanwoo Choi cw00.c...@samsung.com wrote: Hi Sachin, On 04/11/2014 12:56 PM, Sachin Kamat wrote: Hi Chanwoo, On 10 April 2014 15:07, Chanwoo Choi cw00.c...@samsung.com wrote: This patch add Exynos3250's SoC ID. Exynos 3250 is System-On-Chip(SoC

Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

2014-04-01 Thread Sachin Kamat
Hi Axel, On 21 March 2014 13:45, Axel Lin wrote: > Current code misses updating the register when enable_shift is 0. > e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. > > Signed-off-by: Axel Lin Acked-by: Sachin Kamat -- With warm regards, Sachin -- To unsubscribe from this list: s

Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

2014-04-01 Thread Sachin Kamat
Hi Axel, On 21 March 2014 13:45, Axel Lin axel@ingics.com wrote: Current code misses updating the register when enable_shift is 0. e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Sachin Kamat sachin.ka...@linaro.org -- With warm regards

[PATCH 1/1] regulator: max8660: Fix brace alignment

2014-03-19 Thread Sachin Kamat
Move the "};" to next line as is the general coding practice. Signed-off-by: Sachin Kamat --- drivers/regulator/max8660.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/max8660.c b/drivers/regulator/max8660.c index aabfb3b2407c..2fc411188

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-19 Thread Sachin Kamat
On 19 March 2014 14:29, Cho KyongHo wrote: > On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: >> On 18.03.2014 12:09, Cho KyongHo wrote: >> > On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: >> >> Hi KyongHo, >> >> >> >> On 14 M

Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-03-19 Thread Sachin Kamat
mfd/sec-core.c:342:45: warning: 'regmap_rtc' may be used > uninitialized in this function [-Wuninitialized] > > Signed-off-by: Krzysztof Kozlowski >From the point of suppressing this warning and considering how it is done for S2MPS11, Acked-by: Sachin Kamat However, shouldn't

Re: [PATCH 2/4] regulator: max8660: Silence checkpatch warnings

2014-03-19 Thread Sachin Kamat
On 18 March 2014 18:09, Mark Brown wrote: > On Tue, Mar 18, 2014 at 03:53:02PM +0530, Sachin Kamat wrote: >> Silences the following type of error/warnings: >> ERROR: that open brace { should be on the previous line >> WARNING: Missing a blank line after dec

Re: [PATCH 2/4] regulator: max8660: Silence checkpatch warnings

2014-03-19 Thread Sachin Kamat
On 18 March 2014 18:09, Mark Brown broo...@kernel.org wrote: On Tue, Mar 18, 2014 at 03:53:02PM +0530, Sachin Kamat wrote: Silences the following type of error/warnings: ERROR: that open brace { should be on the previous line WARNING: Missing a blank line after declarations Applied

Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-03-19 Thread Sachin Kamat
/mfd/sec-core.c:342:45: warning: 'regmap_rtc' may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com From the point of suppressing this warning and considering how it is done for S2MPS11, Acked-by: Sachin Kamat sachin.ka

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-19 Thread Sachin Kamat
On 19 March 2014 14:29, Cho KyongHo pullip@samsung.com wrote: On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: On 18.03.2014 12:09, Cho KyongHo wrote: On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 10:35, Cho KyongHo pullip@samsung.com

[PATCH 1/1] regulator: max8660: Fix brace alignment

2014-03-19 Thread Sachin Kamat
Move the }; to next line as is the general coding practice. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max8660.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/max8660.c b/drivers/regulator/max8660.c index aabfb3b2407c

Re: [PATCH] mfd: sec-core: Fix I2C dummy device resource leak on probe failure

2014-03-18 Thread Sachin Kamat
On 18 March 2014 18:27, Krzysztof Kozlowski wrote: > Dummy I2C device allocated in sec_pmic_probe() leaked if > devm_regmap_init_i2c() failed. Unregister it before returning from > probe. > > Signed-off-by: Krzysztof Kozlowski Looks good. Reviewed-by: Sachin Kamat -- Wi

Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-18 Thread Sachin Kamat
On 18 March 2014 16:33, Cho KyongHo wrote: > On Fri, 14 Mar 2014 22:27:59 +0530, Sachin Kamat wrote: >> Hi KyongHo, >> >> On 14 March 2014 19:13, Tomasz Figa wrote: >> > Hi KyongHo, >> > >> > >> > On 14.03.2014 06:09, Cho KyongHo wrote:

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-18 Thread Sachin Kamat
On 18 March 2014 16:44, Cho KyongHo wrote: > On Fri, 14 Mar 2014 20:57:42 +0530, Sachin Kamat wrote: >> Hi KyongHo, >> >> On 14 March 2014 10:39, Cho KyongHo wrote: >> > >> > -static struct platform_driver exynos_sysmmu_driver = { >> &g

[PATCH 3/4] regulator: max8925: Silence checkpatch warning

2014-03-18 Thread Sachin Kamat
Silences the following type of checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Sachin Kamat --- drivers/regulator/max8925-regulator.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/max8925-regulator.c b/drivers/regulator/max8925

[PATCH 4/4] regulator: max8952: Silence checkpatch warning

2014-03-18 Thread Sachin Kamat
Silences the following type of checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Sachin Kamat --- drivers/regulator/max8952.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c index c5ee3cc048ee

[PATCH 1/4] regulator: dbx500-prcmu: Silence checkpatch warnings

2014-03-18 Thread Sachin Kamat
Silences the following warning type: WARNING: Missing a blank line after declarations Signed-off-by: Sachin Kamat --- drivers/regulator/dbx500-prcmu.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500-prcmu.c index f111dfb8d2d7

[PATCH 2/4] regulator: max8660: Silence checkpatch warnings

2014-03-18 Thread Sachin Kamat
Silences the following type of error/warnings: ERROR: that open brace { should be on the previous line WARNING: Missing a blank line after declarations Signed-off-by: Sachin Kamat --- drivers/regulator/max8660.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff

[PATCH 2/4] regulator: max8660: Silence checkpatch warnings

2014-03-18 Thread Sachin Kamat
Silences the following type of error/warnings: ERROR: that open brace { should be on the previous line WARNING: Missing a blank line after declarations Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max8660.c | 15 +++ 1 file changed, 11 insertions(+), 4

[PATCH 1/4] regulator: dbx500-prcmu: Silence checkpatch warnings

2014-03-18 Thread Sachin Kamat
Silences the following warning type: WARNING: Missing a blank line after declarations Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/dbx500-prcmu.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500

[PATCH 4/4] regulator: max8952: Silence checkpatch warning

2014-03-18 Thread Sachin Kamat
Silences the following type of checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max8952.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c

[PATCH 3/4] regulator: max8925: Silence checkpatch warning

2014-03-18 Thread Sachin Kamat
Silences the following type of checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max8925-regulator.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/max8925-regulator.c b

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-18 Thread Sachin Kamat
On 18 March 2014 16:44, Cho KyongHo pullip@samsung.com wrote: On Fri, 14 Mar 2014 20:57:42 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 10:39, Cho KyongHo pullip@samsung.com wrote: -static struct platform_driver exynos_sysmmu_driver = { - .probe

Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-18 Thread Sachin Kamat
On 18 March 2014 16:33, Cho KyongHo pullip@samsung.com wrote: On Fri, 14 Mar 2014 22:27:59 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 19:13, Tomasz Figa t.f...@samsung.com wrote: Hi KyongHo, On 14.03.2014 06:09, Cho KyongHo wrote: exynos-iommu driver must care

Re: [PATCH] mfd: sec-core: Fix I2C dummy device resource leak on probe failure

2014-03-18 Thread Sachin Kamat
-by: Sachin Kamat sachin.ka...@linaro.org -- With warm regards, Sachin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] drm/exynos: Fix (more) freeing issues in exynos_drm_drv.c

2014-03-16 Thread Sachin Kamat
rv.c > > Signed-off-by: Daniel Kurtz Acked-by: Sachin Kamat -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordom

Re: [PATCH] drm/exynos: Fix (more) freeing issues in exynos_drm_drv.c

2014-03-16 Thread Sachin Kamat
in exynos_drm_drv.c Signed-off-by: Daniel Kurtz djku...@chromium.org Acked-by: Sachin Kamat sachin.ka...@linaro.org -- With warm regards, Sachin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-14 Thread Sachin Kamat
Hi KyongHo, On 14 March 2014 19:13, Tomasz Figa wrote: > Hi KyongHo, > > > On 14.03.2014 06:09, Cho KyongHo wrote: >> >> exynos-iommu driver must care about master H/W's gate clock as well as >> System MMU's gate clock. To enhance readability of the source code, >> macros to gate/ungate those

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-14 Thread Sachin Kamat
Hi KyongHo, On 14 March 2014 10:39, Cho KyongHo wrote: > This commit adds device tree support for System MMU. > > Signed-off-by: Cho KyongHo > --- > drivers/iommu/Kconfig|5 ++--- > drivers/iommu/exynos-iommu.c | 21 + > 2 files changed, 19 insertions(+), 7

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-14 Thread Sachin Kamat
Hi KyongHo, On 14 March 2014 10:35, Cho KyongHo wrote: > This patch uses managed device helper functions in the probe(). > > Signed-off-by: Cho KyongHo > --- [snip] > + data->clk = devm_clk_get(dev, "sysmmu"); > + if (IS_ERR(data->clk)) { > + dev_info(dev, "No gate

Re: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-14 Thread Sachin Kamat
On 14 March 2014 17:19, Cho KyongHo wrote: >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] >> Sent: Friday, March 14, 2014 7:00 PM >> >> On 14 March 2014 10:31, Cho KyongHo wrote: >> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from &

[PATCH v4 3/3] Documentation: mfd: Add binding document for S2MPA01

2014-03-14 Thread Sachin Kamat
Added initial binding documentation for S2MPA01 MFD. Signed-off-by: Sachin Kamat Acked-by: Mark Brown --- No changes since v3. --- Documentation/devicetree/bindings/mfd/s2mpa01.txt | 90 + 1 file changed, 90 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v4 1/3] mfd: Add support for S2MPA01 device

2014-03-14 Thread Sachin Kamat
Add the necessary entries required for S2MPA01 multi-function device. While at it also convert whitespaces to tabs in core.h. Signed-off-by: Sachin Kamat Acked-by: Lee Jones --- No change since v3 --- drivers/mfd/sec-core.c | 49 - include/linux/mfd/samsung/core.h

[PATCH v4 2/3] regulator: Add support for S2MPA01 regulator

2014-03-14 Thread Sachin Kamat
Add support for S2MPA01 voltage and current regulator. Signed-off-by: Sachin Kamat Acked-by: Mark Brown --- Changes since v3: Removed a redundant array and instead used a simple variable to check return value of devm_regulator_register. --- drivers/regulator/Kconfig |7 + drivers

Re: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-14 Thread Sachin Kamat
On 14 March 2014 10:31, Cho KyongHo wrote: > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without > removing remaining use of it from exynos-iommu driver, thus causing a > compilation error. > > This patch

Re: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-14 Thread Sachin Kamat
On 14 March 2014 10:31, Cho KyongHo pullip@samsung.com wrote: Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without removing remaining use of it from exynos-iommu driver, thus causing a compilation

[PATCH v4 2/3] regulator: Add support for S2MPA01 regulator

2014-03-14 Thread Sachin Kamat
Add support for S2MPA01 voltage and current regulator. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Mark Brown broo...@linaro.org --- Changes since v3: Removed a redundant array and instead used a simple variable to check return value of devm_regulator_register. --- drivers

[PATCH v4 1/3] mfd: Add support for S2MPA01 device

2014-03-14 Thread Sachin Kamat
Add the necessary entries required for S2MPA01 multi-function device. While at it also convert whitespaces to tabs in core.h. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Lee Jones lee.jo...@linaro.org --- No change since v3 --- drivers/mfd/sec-core.c | 49

[PATCH v4 3/3] Documentation: mfd: Add binding document for S2MPA01

2014-03-14 Thread Sachin Kamat
Added initial binding documentation for S2MPA01 MFD. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Mark Brown broo...@linaro.org --- No changes since v3. --- Documentation/devicetree/bindings/mfd/s2mpa01.txt | 90 + 1 file changed, 90 insertions(+) create

Re: [PATCH v11 01/27] iommu/exynos: do not include removed header

2014-03-14 Thread Sachin Kamat
On 14 March 2014 17:19, Cho KyongHo pullip@samsung.com wrote: From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: Friday, March 14, 2014 7:00 PM On 14 March 2014 10:31, Cho KyongHo pullip@samsung.com wrote: Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-14 Thread Sachin Kamat
Hi KyongHo, On 14 March 2014 10:35, Cho KyongHo pullip@samsung.com wrote: This patch uses managed device helper functions in the probe(). Signed-off-by: Cho KyongHo pullip@samsung.com --- [snip] + data-clk = devm_clk_get(dev, sysmmu); + if (IS_ERR(data-clk)) { +

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-14 Thread Sachin Kamat
Hi KyongHo, On 14 March 2014 10:39, Cho KyongHo pullip@samsung.com wrote: This commit adds device tree support for System MMU. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/Kconfig|5 ++--- drivers/iommu/exynos-iommu.c | 21 + 2

Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-14 Thread Sachin Kamat
Hi KyongHo, On 14 March 2014 19:13, Tomasz Figa t.f...@samsung.com wrote: Hi KyongHo, On 14.03.2014 06:09, Cho KyongHo wrote: exynos-iommu driver must care about master H/W's gate clock as well as System MMU's gate clock. To enhance readability of the source code, macros to gate/ungate

Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

2014-03-10 Thread Sachin Kamat
On 10 March 2014 16:09, Lee Jones wrote: >> > >> >> Add support for S2MPA01 voltage and current regulator. >> > >> >> > >> >> + >> > >> >> +struct s2mpa01_info { >> > >> >> + struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX]; >> > >> > >> > >> > Hi, >> > >> > >> > >> > It seems that

[PATCH Resend 2/2] regulator: s2mps11: Add missing of_node_put

2014-03-10 Thread Sachin Kamat
Add of_node_put to decrement the ref count. Signed-off-by: Sachin Kamat --- drivers/regulator/s2mps11.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 0f6177b..6eaf69b 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers

[PATCH Resend 1/2] regulator: s2mps11: Use of_get_child_by_name

2014-03-10 Thread Sachin Kamat
of_find_node_by_name walks the allnodes list, and can thus walk outside of the parent node. Use of_get_child_by_name instead. Signed-off-by: Sachin Kamat --- drivers/regulator/s2mps11.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/s2mps11.c b/drivers

Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

2014-03-10 Thread Sachin Kamat
Hi Lee, On 10 March 2014 15:05, Lee Jones wrote: >> >> Add support for S2MPA01 voltage and current regulator. >> >> >> + >> >> +struct s2mpa01_info { >> >> + struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX]; >> > >> > Hi, >> > >> > It seems that s2mpa01_info->rdev is not used anywhere,

Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

2014-03-10 Thread Sachin Kamat
Hi Lee, On 10 March 2014 15:05, Lee Jones lee.jo...@linaro.org wrote: Add support for S2MPA01 voltage and current regulator. + +struct s2mpa01_info { + struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX]; Hi, It seems that s2mpa01_info-rdev is not used anywhere, except as

[PATCH Resend 1/2] regulator: s2mps11: Use of_get_child_by_name

2014-03-10 Thread Sachin Kamat
of_find_node_by_name walks the allnodes list, and can thus walk outside of the parent node. Use of_get_child_by_name instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/s2mps11.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH Resend 2/2] regulator: s2mps11: Add missing of_node_put

2014-03-10 Thread Sachin Kamat
Add of_node_put to decrement the ref count. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/s2mps11.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 0f6177b..6eaf69b 100644 --- a/drivers/regulator

Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

2014-03-10 Thread Sachin Kamat
On 10 March 2014 16:09, Lee Jones lee.jo...@linaro.org wrote: Add support for S2MPA01 voltage and current regulator. + +struct s2mpa01_info { + struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX]; Hi, It seems that s2mpa01_info-rdev is not used anywhere, except

Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

2014-03-06 Thread Sachin Kamat
Hi Krzysztof, On 6 March 2014 16:10, Krzysztof Kozlowski wrote: > On Thu, 2014-03-06 at 15:30 +0530, Sachin Kamat wrote: >> Add support for S2MPA01 voltage and current regulator. >> + >> +struct s2mpa01_info { >> + struct regulator_dev *rdev[S2MPA01_REGULATOR

Re: [PATCH v3 3/3] Documentation: mfd: Add binding document for S2MPA01

2014-03-06 Thread Sachin Kamat
On 6 March 2014 09:55, Mark Brown wrote: > On Wed, Mar 05, 2014 at 06:24:42PM +0800, Lee Jones wrote: > >> This document has been sitting on the MLs for nearly a month now. It >> seems well written and doesn't add any new bindings. With that in mind >> I'm inclined to take it though. However, as

[PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

2014-03-06 Thread Sachin Kamat
Add support for S2MPA01 voltage and current regulator. Signed-off-by: Sachin Kamat Acked-by: Mark Brown --- drivers/regulator/Kconfig |7 + drivers/regulator/Makefile |1 + drivers/regulator/s2mpa01.c | 483 +++ 3 files changed, 491

[PATCH v3 Resend 3/3] Documentation: mfd: Add binding document for S2MPA01

2014-03-06 Thread Sachin Kamat
Added initial binding documentation for S2MPA01 MFD. Signed-off-by: Sachin Kamat Acked-by: Mark Brown --- Documentation/devicetree/bindings/mfd/s2mpa01.txt | 90 + 1 file changed, 90 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/s2mpa01.txt diff

[PATCH v3 Resend 1/3] mfd: Add support for S2MPA01 device

2014-03-06 Thread Sachin Kamat
Add the necessary entries required for S2MPA01 multi-function device. While at it also convert whitespaces to tabs in core.h. Signed-off-by: Sachin Kamat Acked-by: Lee Jones --- Rebased on latest MFD tree and added the accumulated Acks. --- drivers/mfd/sec-core.c | 49

[PATCH v3 Resend 3/3] Documentation: mfd: Add binding document for S2MPA01

2014-03-06 Thread Sachin Kamat
Added initial binding documentation for S2MPA01 MFD. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Mark Brown broo...@linaro.org --- Documentation/devicetree/bindings/mfd/s2mpa01.txt | 90 + 1 file changed, 90 insertions(+) create mode 100644 Documentation

[PATCH v3 Resend 1/3] mfd: Add support for S2MPA01 device

2014-03-06 Thread Sachin Kamat
Add the necessary entries required for S2MPA01 multi-function device. While at it also convert whitespaces to tabs in core.h. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Lee Jones lee.jo...@linaro.org --- Rebased on latest MFD tree and added the accumulated Acks. --- drivers

[PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

2014-03-06 Thread Sachin Kamat
Add support for S2MPA01 voltage and current regulator. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Mark Brown broo...@linaro.org --- drivers/regulator/Kconfig |7 + drivers/regulator/Makefile |1 + drivers/regulator/s2mpa01.c | 483

Re: [PATCH v3 3/3] Documentation: mfd: Add binding document for S2MPA01

2014-03-06 Thread Sachin Kamat
On 6 March 2014 09:55, Mark Brown broo...@kernel.org wrote: On Wed, Mar 05, 2014 at 06:24:42PM +0800, Lee Jones wrote: This document has been sitting on the MLs for nearly a month now. It seems well written and doesn't add any new bindings. With that in mind I'm inclined to take it though.

Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

2014-03-06 Thread Sachin Kamat
Hi Krzysztof, On 6 March 2014 16:10, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On Thu, 2014-03-06 at 15:30 +0530, Sachin Kamat wrote: Add support for S2MPA01 voltage and current regulator. + +struct s2mpa01_info { + struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX]; Hi

Re: [PATCH 3/3] Documentation: mfd: s2mps11: Document support for S2MPS14

2014-03-05 Thread Sachin Kamat
1, LD02, LDO28 > - BUCKn > - - valid values for n are 1 to 10. > + - valid values for n are: > + - S2MPS11: 1 to 10 > + - S2MPS14: 1 to 5 > - Example: BUCK1, BUCK2, BUCK9 > > Ex

Re: [PATCH 3/3] Documentation: mfd: s2mps11: Document support for S2MPS14

2014-03-05 Thread Sachin Kamat
-by: Sachin Kamat sachin.ka...@linaro.org -- With warm regards, Sachin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH 1/1] mfd: vexpress: Staticize vexpress_config_bridges

2014-03-04 Thread Sachin Kamat
vexpress_config_bridges is local to this file. Signed-off-by: Sachin Kamat --- drivers/mfd/vexpress-config.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/vexpress-config.c b/drivers/mfd/vexpress-config.c index 84ce6b9daa3d..0876de04ed4d 100644 --- a/drivers

[PATCH 1/1] mfd: vexpress: Staticize vexpress_config_bridges

2014-03-04 Thread Sachin Kamat
vexpress_config_bridges is local to this file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mfd/vexpress-config.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/vexpress-config.c b/drivers/mfd/vexpress-config.c index 84ce6b9daa3d

[PATCH 2/2] regulator: s2mps11: Add missing of_node_put

2014-03-03 Thread Sachin Kamat
Add of_node_put to decrement the ref count. Signed-off-by: Sachin Kamat --- drivers/regulator/s2mps11.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 0f6177b..6eaf69b 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers

[PATCH 1/2] regulator: s2mps11: Use of_get_child_by_name

2014-03-03 Thread Sachin Kamat
of_find_node_by_name walks the allnodes list, and can thus walk outside of the parent node. Use of_get_child_by_name instead. Signed-off-by: Sachin Kamat --- drivers/regulator/s2mps11.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/s2mps11.c b/drivers

[PATCH 2/2] regulator: s2mps11: Add missing of_node_put

2014-03-03 Thread Sachin Kamat
Add of_node_put to decrement the ref count. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/s2mps11.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 0f6177b..6eaf69b 100644 --- a/drivers/regulator

[PATCH 1/2] regulator: s2mps11: Use of_get_child_by_name

2014-03-03 Thread Sachin Kamat
of_find_node_by_name walks the allnodes list, and can thus walk outside of the parent node. Use of_get_child_by_name instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/s2mps11.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] clk: samsung: remove parentheses from return statements

2014-02-25 Thread Sachin Kamat
Hi Pankaj, On 26 February 2014 08:14, Pankaj Dubey wrote: > fixed following checkpatch warning message > "return is not a function, parentheses are not required" > > Signed-off-by: Pankaj Dubey Similar patch has already been submitted:

[PATCH 1/1] regulator: mc13xxx: Fix NULL pointer error in non-DT mode

2014-02-25 Thread Sachin Kamat
Add a check to avoid NULL pointer dereference error when booted in non-DT mode. While at it also remove the additional of_node_get which is no longer needed for of_get_child_by_name and fix the node pointer. Signed-off-by: Sachin Kamat Reported-by: Philippe Rétornaz --- drivers/regulator

Re: [PATCH 1/1] regulator: mc13xxx: check if DT is enabled

2014-02-25 Thread Sachin Kamat
On 25 February 2014 15:39, Philippe Rétornaz wrote: > Le 25/02/2014 10:12, Sachin Kamat a écrit : > >> On 25 February 2014 14:17, Philippe Rétornaz >> wrote: >> >> Thanks for the patch. I was about to send a similar patch which also >> does a little more cl

Re: [PATCH] regulator: core: allow enabling without enable op

2014-02-25 Thread Sachin Kamat
disable already does. > > Signed-off-by: Alexandre Courbot This patch fixes the fixed regulator registration failure on Exynos5420 board. Tested-by: Sachin Kamat -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

<    1   2   3   4   5   6   7   8   9   10   >