Re: [PATCH] x86: Don't clobber top of pt_regs in nested NMI

2012-09-24 Thread Salman Qazi
On Mon, Sep 24, 2012 at 6:27 AM, Steven Rostedt rost...@goodmis.org wrote: On Tue, Sep 18, 2012 at 06:29:35PM -0700, Salman Qazi wrote: The nested NMI modifies the place (instruction, flags and stack) that the first NMI will iret to. However, the copy of registers modified is exactly the one

[PATCH] crypto: Make VMAC work when blocks aren't aligned

2012-10-05 Thread Salman Qazi
size. I also added test cases for unaligned blocks. Signed-off-by: Salman Qazi sq...@google.com --- crypto/testmgr.h | 33 - crypto/vmac.c | 47 +++ include/crypto/vmac.h |2 ++ 3 files changed, 77

[PATCH] x86: Don't clobber top of pt_regs in nested NMI

2012-09-18 Thread Salman Qazi
. Signed-off-by: Salman Qazi sq...@google.com --- arch/x86/kernel/entry_64.S | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S index 69babd8..40ddb6d 100644 --- a/arch/x86/kernel/entry_64.S +++ b/arch/x86

[PATCH] The nested NMI modifies the place (instruction, flags and stack)

2012-10-01 Thread Salman Qazi
of the preserved copy of the iret registers (saved) and the copy subject to being trampled by nested NMI (copied). Signed-off-by: Salman Qazi sq...@google.com --- arch/x86/kernel/entry_64.S | 41 +++-- 1 files changed, 27 insertions(+), 14 deletions(-) diff --git

[PATCH] [PATCH] x86: Don't clobber top of pt_regs in nested NMI

2012-10-01 Thread Salman Qazi
output. We solve this problem by interchanging the position of the preserved copy of the iret registers (saved) and the copy subject to being trampled by nested NMI (copied). Signed-off-by: Salman Qazi sq...@google.com --- arch/x86/kernel/entry_64.S | 41 +++-- 1

Re: [BUG] mm: direct I/O (using GUP) can write to COW anonymous pages

2018-09-17 Thread Salman Qazi
On Mon, Sep 17, 2018 at 5:05 PM Hugh Dickins wrote: > > Hi Jann, > > On Mon, 17 Sep 2018, Jann Horn wrote: > > > [I'm not sure who the best people to ask about this are, I hope the > > recipient list resembles something reasonable...] > > > > I have noticed that the dup_mmap() logic on fork()

Re: [PATCH] x86: Don't clobber top of pt_regs in nested NMI

2012-09-24 Thread Salman Qazi
On Mon, Sep 24, 2012 at 6:27 AM, Steven Rostedt wrote: > On Tue, Sep 18, 2012 at 06:29:35PM -0700, Salman Qazi wrote: >> The nested NMI modifies the place (instruction, flags and stack) >> that the first NMI will iret to. However, the copy of registers >> modifi

[PATCH] crypto: Make VMAC work when blocks aren't aligned

2012-10-05 Thread Salman Qazi
size. I also added test cases for unaligned blocks. Signed-off-by: Salman Qazi --- crypto/testmgr.h | 33 - crypto/vmac.c | 47 +++ include/crypto/vmac.h |2 ++ 3 files changed, 77 insertions(+), 5

[PATCH] x86: Don't clobber top of pt_regs in nested NMI

2012-09-18 Thread Salman Qazi
. Signed-off-by: Salman Qazi --- arch/x86/kernel/entry_64.S | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S index 69babd8..40ddb6d 100644 --- a/arch/x86/kernel/entry_64.S +++ b/arch/x86/kernel/entry_64

[PATCH] The nested NMI modifies the place (instruction, flags and stack)

2012-10-01 Thread Salman Qazi
of the preserved copy of the iret registers ("saved") and the copy subject to being trampled by nested NMI ("copied"). Signed-off-by: Salman Qazi --- arch/x86/kernel/entry_64.S | 41 +++-- 1 files changed, 27 insertions(+), 14 deletions(-) d

[PATCH] [PATCH] x86: Don't clobber top of pt_regs in nested NMI

2012-10-01 Thread Salman Qazi
output. We solve this problem by interchanging the position of the preserved copy of the iret registers ("saved") and the copy subject to being trampled by nested NMI ("copied"). Signed-off-by: Salman Qazi --- arch/x86/kernel/entry_64.S | 41 +++---

Re: [PATCH] fs, ipc: Use an asynchronous version of kern_unmount in IPC

2019-02-13 Thread Salman Qazi
Do you have any additional concerns? On Thu, Feb 7, 2019 at 10:43 AM Salman Qazi wrote: > > On Wed, Feb 6, 2019 at 8:14 PM Al Viro wrote: > > > > On Wed, Feb 06, 2019 at 11:53:54AM -0800, Salman Qazi wrote: > > > > > This patch solves the issue by removin

icache_is_aliasing and big.LITTLE

2019-05-08 Thread Salman Qazi
Hi, What is the intention behind icache_is_aliasing on big.LITTLE systems where some icaches are VIPT and others are PIPT? Is it meant to be conservative in some sense or should it be made per-CPU? Thanks for your help, Salman

Re: icache_is_aliasing and big.LITTLE

2019-05-09 Thread Salman Qazi
Thank you. On Thu, May 9, 2019 at 1:50 AM Catalin Marinas wrote: > > Hi, > > On Wed, May 08, 2019 at 11:45:03AM -0700, Salman Qazi wrote: > > What is the intention behind icache_is_aliasing on big.LITTLE systems > > where some icaches are VIPT and othe

[PATCH RESENT] fs, ipc: Use an asynchronous version of kern_unmount in IPC

2019-03-04 Thread Salman Qazi
n 0; } assert(waitpid(pid, , 0) == pid); } } Before: $ time ./unshare2 real0m9.784s user0m0.428s sys 0m0.000s After: $ time ./unshare2 real0m0.368s user0m0.226s sys 0m0.122s Signed-off-by: Salman Qazi Reviewed-by: E

Re: [BUG] mm: direct I/O (using GUP) can write to COW anonymous pages

2018-09-17 Thread Salman Qazi
On Mon, Sep 17, 2018 at 5:05 PM Hugh Dickins wrote: > > Hi Jann, > > On Mon, 17 Sep 2018, Jann Horn wrote: > > > [I'm not sure who the best people to ask about this are, I hope the > > recipient list resembles something reasonable...] > > > > I have noticed that the dup_mmap() logic on fork()

[tip:x86/asm] x86: Don't clobber top of pt_regs in nested NMI

2012-11-02 Thread tip-bot for Salman Qazi
Commit-ID: 28696f434fef0efa97534b59986ad33b9c4df7f8 Gitweb: http://git.kernel.org/tip/28696f434fef0efa97534b59986ad33b9c4df7f8 Author: Salman Qazi sq...@google.com AuthorDate: Mon, 1 Oct 2012 17:29:25 -0700 Committer: Steven Rostedt rost...@goodmis.org CommitDate: Fri, 2 Nov 2012 11:29

[tip:x86/asm] x86: Don't clobber top of pt_regs in nested NMI

2012-11-02 Thread tip-bot for Salman Qazi
Commit-ID: 28696f434fef0efa97534b59986ad33b9c4df7f8 Gitweb: http://git.kernel.org/tip/28696f434fef0efa97534b59986ad33b9c4df7f8 Author: Salman Qazi AuthorDate: Mon, 1 Oct 2012 17:29:25 -0700 Committer: Steven Rostedt CommitDate: Fri, 2 Nov 2012 11:29:36 -0400 x86: Don't clobber top