Re: [PATCH 0/4] dm verity: add support for error correction

2015-11-05 Thread Sami Tolvanen
On Thu, Nov 05, 2015 at 08:34:04AM +0100, Milan Broz wrote: > could you please elaborate why is all this needed? To extend support > of some faulty flash chips? This makes dm-verity more robust against corruption caused by either hardware or software bugs, both of which we have seen in the past

Re: [PATCH 0/4] dm verity: add support for error correction

2015-11-05 Thread Sami Tolvanen
On Thu, Nov 05, 2015 at 08:34:04AM +0100, Milan Broz wrote: > could you please elaborate why is all this needed? To extend support > of some faulty flash chips? This makes dm-verity more robust against corruption caused by either hardware or software bugs, both of which we have seen in the past

[PATCH 2/4] dm verity: separate function for parsing opt args

2015-11-04 Thread Sami Tolvanen
Move optional argument parsing into a separate function to make it easier to add more of them without making verity_ctr even longer. Signed-off-by: Sami Tolvanen --- drivers/md/dm-verity.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git

[PATCH 0/4] dm verity: add support for error correction

2015-11-04 Thread Sami Tolvanen
. Sami Tolvanen (4): dm verity: clean up duplicate hashing code dm verity: separate function for parsing opt args dm verity: add support for forward error correction dm verity: ignore zero blocks Documentation/device-mapper/verity.txt | 34 ++ drivers/md/dm-verity.c

[PATCH 4/4] dm verity: ignore zero blocks

2015-11-04 Thread Sami Tolvanen
Add ignore_zero_blocks option, which returns zeros for blocks matching a zero hash without validating the content. Signed-off-by: Sami Tolvanen --- Documentation/device-mapper/verity.txt | 5 ++ drivers/md/dm-verity.c | 88 ++ 2 files changed, 83

[PATCH 1/4] dm verity: clean up duplicate hashing code

2015-11-04 Thread Sami Tolvanen
Handle dm-verity salting in one place to simplify the code. Signed-off-by: Sami Tolvanen --- drivers/md/dm-verity.c | 262 +++-- 1 file changed, 147 insertions(+), 115 deletions(-) diff --git a/drivers/md/dm-verity.c b/drivers/md/dm-verity.c index

[PATCH 3/4] dm verity: add support for forward error correction

2015-11-04 Thread Sami Tolvanen
blocks need to corrected. For a 2 GiB partition, RS(255, 253) (two parity bytes for each 253-byte block) can correct up to 16 MiB of consecutive corrupted blocks if erasures can be located, and 8 MiB if they cannot, with 16 MiB space overhead. Signed-off-by: Sami Tolvanen --- Documentation/device

[PATCH 3/4] dm verity: add support for forward error correction

2015-11-04 Thread Sami Tolvanen
blocks need to corrected. For a 2 GiB partition, RS(255, 253) (two parity bytes for each 253-byte block) can correct up to 16 MiB of consecutive corrupted blocks if erasures can be located, and 8 MiB if they cannot, with 16 MiB space overhead. Signed-off-by: Sami Tolvanen <samitolva...@google.

[PATCH 1/4] dm verity: clean up duplicate hashing code

2015-11-04 Thread Sami Tolvanen
Handle dm-verity salting in one place to simplify the code. Signed-off-by: Sami Tolvanen <samitolva...@google.com> --- drivers/md/dm-verity.c | 262 +++-- 1 file changed, 147 insertions(+), 115 deletions(-) diff --git a/drivers/md/dm-veri

[PATCH 4/4] dm verity: ignore zero blocks

2015-11-04 Thread Sami Tolvanen
Add ignore_zero_blocks option, which returns zeros for blocks matching a zero hash without validating the content. Signed-off-by: Sami Tolvanen <samitolva...@google.com> --- Documentation/device-mapper/verity.txt | 5 ++ drivers/md/dm-verity.c

[PATCH 0/4] dm verity: add support for error correction

2015-11-04 Thread Sami Tolvanen
. Sami Tolvanen (4): dm verity: clean up duplicate hashing code dm verity: separate function for parsing opt args dm verity: add support for forward error correction dm verity: ignore zero blocks Documentation/device-mapper/verity.txt | 34 ++ drivers/md/dm-verity.c

[PATCH 2/4] dm verity: separate function for parsing opt args

2015-11-04 Thread Sami Tolvanen
Move optional argument parsing into a separate function to make it easier to add more of them without making verity_ctr even longer. Signed-off-by: Sami Tolvanen <samitolva...@google.com> --- drivers/md/dm-verity.c | 31 ++- 1 file changed, 22 insertions

<    5   6   7   8   9   10