Re: irda rmmod lockdep trace.

2007-03-10 Thread Samuel Ortiz
Hi Dave, On Thu, Mar 08, 2007 at 05:54:36PM -0500, Dave Jones wrote: modprobe irda ; rmmod irda in 2.6.21rc3 gets me the spew below.. Well it seems that we call __irias_delete_object() from hashbin_delete(). Then __irias_delete_object() calls itself hashbin_delete() again. We're trying to get

Re: irda rmmod lockdep trace.

2007-03-11 Thread Samuel Ortiz
Hi Dave, On Sat, Mar 10, 2007 at 07:43:26PM +0200, Samuel Ortiz wrote: Hi Dave, On Thu, Mar 08, 2007 at 05:54:36PM -0500, Dave Jones wrote: modprobe irda ; rmmod irda in 2.6.21rc3 gets me the spew below.. Well it seems that we call __irias_delete_object() from hashbin_delete

Re: irda rmmod lockdep trace.

2007-03-13 Thread Samuel Ortiz
On 3/12/2007, David Miller [EMAIL PROTECTED] wrote: From: Samuel Ortiz [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 02:38:43 +0200 On Sat, Mar 10, 2007 at 07:43:26PM +0200, Samuel Ortiz wrote: Hi Dave, On Thu, Mar 08, 2007 at 05:54:36PM -0500, Dave Jones wrote: modprobe irda ; rmmod irda

Re: irda rmmod lockdep trace.

2007-03-13 Thread Samuel Ortiz
On Mon, Mar 12, 2007 at 04:49:21PM -0700, David Miller wrote: I would strongly caution against adding any run-time overhead just to cure a false lockdep warning. Even adding a new function argument is too much IMHO. Make the cost show up for lockdep only, perhaps by putting each hashbin

[PATCH 6/6] IrDA: Lockdep annotation for hashbin locks

2007-03-14 Thread Samuel Ortiz
Rmmoding irda triggers a lockdep false positive. We can fix that by assigning each hashbin lock to a separate class. Reported-by: Dave Jones [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- include/net/irda/irqueue.h |1 + net/irda/irqueue.c |1 + 2 files

Re: irda rmmod lockdep trace.

2007-03-16 Thread Samuel Ortiz
On Tue, Mar 13, 2007 at 07:22:37PM -0700, David Miller wrote: From: Samuel Ortiz [EMAIL PROTECTED] Date: Wed, 14 Mar 2007 02:50:03 +0200 On Mon, Mar 12, 2007 at 04:49:21PM -0700, David Miller wrote: I would strongly caution against adding any run-time overhead just to cure a false

Re: [git patches] net driver fixes

2007-03-30 Thread Samuel Ortiz
On 3/30/2007, Guennadi Liakhovetski [EMAIL PROTECTED] wrote: On Thu, 29 Mar 2007, Jeff Garzik wrote: Guennadi Liakhovetski wrote: Jeff, might be worth getting the sk_buff leak fix in ppp from http://www.spinics.net/lists/netdev/msg27706.html in 2.6.21 too? Don't know how important it is

Re: [PATCH] net/irda/parameters.c: Trivial fixes

2007-11-25 Thread Samuel Ortiz
Hi Richard, On Sat, Nov 24, 2007 at 09:44:05PM +0100, Richard Knutsson wrote: Make a single va_start() - va_end() path + fixing: Ok, this should be 2 separate patches then. The warning fixes are all good, but I fail to see the point of the va_end() one. That doesn't seem to bring any sort of

[RFC] [PATCH -mm] ASIC3 driver

2007-10-18 Thread Samuel Ortiz
and accepted. [1] http://lkml.org/lkml/2007/5/1/46 Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/mfd/Kconfig |6 drivers/mfd/Makefile |1 drivers/mfd/asic3.c | 572 ++ include/linux/mfd/asic3.h | 463

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-19 Thread Samuel Ortiz
On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote: On Thu, 18 Oct 2007 11:12:41 +0200 Samuel Ortiz [EMAIL PROTECTED] wrote: You're not a big fan of checkpatch, I see. Well, now I am :-) I fixed all the errors, there are only a couple lines being more than 80 characters left

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-18 Thread Samuel Ortiz
On Fri, Oct 19, 2007 at 12:15:47AM +0200, Thomas Gleixner wrote: On Thu, 18 Oct 2007, Andrew Morton wrote: + +#include linux/module.h +#include linux/version.h +#include linux/irq.h Please see the large comment at the top of linux/irq.h. I believe this driver will fial to

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-20 Thread Samuel Ortiz
On Fri, Oct 19, 2007 at 11:00:34AM -0700, Andrew Morton wrote: On Fri, 19 Oct 2007 12:53:00 +0200 Samuel Ortiz [EMAIL PROTECTED] wrote: On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote: On Thu, 18 Oct 2007 11:12:41 +0200 Samuel Ortiz [EMAIL PROTECTED] wrote

Re: [PATCH 1/1] mfd: Provide the PRCMU with its own IRQ domain

2012-09-24 Thread Samuel Ortiz
it as an interrupt controller as and when they are DT enabled. CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Lee Jones lee.jo...@linaro.org This is good stuff. Acked-by: Linus Walleij linus.wall...@linaro.org Sam, please pick this up, IRQdomains are a pathway to many good

Re: linux-next: build failure after merge of the mfd tree

2012-09-25 Thread Samuel Ortiz
Hi Stephen, On Tue, Sep 25, 2012 at 01:47:35PM +1000, Stephen Rothwell wrote: Hi Samuel, After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) failed like this: FATAL: modpost: GPL-incompatible module tps65217_bl.ko uses GPL-only symbol 'platform_driver_unregister'

Re: [PATCH] mfd: viperboard driver added

2012-09-25 Thread Samuel Ortiz
Hi Lars, On Mon, Sep 24, 2012 at 06:46:19PM +0200, Lars Poeschel wrote: Hi Samuel, Thanks for your review. Am 19.09.2012 17:29, schrieb Samuel Ortiz: Hi Lars, On Mon, Aug 27, 2012 at 03:08:38PM +0200, la...@wh2.tu-dresden.de wrote: From: Lars Poeschel poesc...@lemonage.de First

Re: [PATCH 4/4] mfd: max8907: remove regulator-compatible from DT docs

2012-09-25 Thread Samuel Ortiz
Hi Stephen, On Mon, Sep 24, 2012 at 01:25:03PM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Commit regulator: deprecate regulator-compatible DT property deprecated the use of the regulator-compatible DT property. Update the DT example in the MAX8907 binding

Re: [PATCH 1/3] mfd: dbx500: Export prmcu_request_ape_opp_100_voltage

2012-10-04 Thread Samuel Ortiz
Hi Ulf, On Mon, Sep 24, 2012 at 04:43:17PM +0200, Ulf Hansson wrote: From: Ulf Hansson ulf.hans...@linaro.org This function needs to be exported to let clients be able to request the ape opp 100 voltage. Cc: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Ulf Hansson ulf.hans

Re: [PATCH 0/7] Add support for Freescale's mc34708 to mc13xxx driver

2012-10-04 Thread Samuel Ortiz
Hi Fabio, On Thu, Oct 04, 2012 at 10:01:21AM -0300, Fabio Estevam wrote: Hi Samuel, On Wed, Sep 5, 2012 at 11:22 AM, Fabio Estevam feste...@gmail.com wrote: Hi Samuel, On Thu, Jul 12, 2012 at 8:02 PM, Marc Reilly m...@cpdesign.com.au wrote: Hi Uwe, This series was tested on a

Re: [PATCH RESEND 0/8] TI Touchscreen driver updates and Support for TSC/ADC MFD driver

2012-11-05 Thread Samuel Ortiz
Hi Rachna, On Tue, Oct 16, 2012 at 12:55:37PM +0530, Patil, Rachna wrote: This patch set is a cumulative set of [1] and [2] sent earlier. I have merged the patch set so that the MFD patches apply without any issues. Also Note that there are no code changes in either of the patch set, only

Re: [PATCH 0/7] Add support for Freescale's mc34708 to mc13xxx driver

2012-11-06 Thread Samuel Ortiz
Hi Fabio, On Sat, Oct 27, 2012 at 05:19:11PM -0200, Fabio Estevam wrote: Hi Samuel, On Thu, Oct 4, 2012 at 10:51 AM, Samuel Ortiz samuel.or...@intel.com wrote: I want to add mc34708 support to mx53qsb and need this series to be applied. I understand. I'll queue it to my for-next

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-11-08 Thread Samuel Ortiz
Hi Wei, On Mon, Oct 29, 2012 at 01:49:28PM +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG wei_w...@realsil.com.cn Support for Realtek PCI-Express driver-based card readers including rts5209, rts5229 and rtl8411. All 3 patches applied now, thanks a lot. I also fixed the Kconfig entry

Re: [PATCH 176/193] net/nfc: remove CONFIG_EXPERIMENTAL

2012-10-24 Thread Samuel Ortiz
Almeida Jr aloisio.alme...@openbossa.org CC: Samuel Ortiz sa...@linux.intel.com CC: David S. Miller da...@davemloft.net Signed-off-by: Kees Cook keesc...@chromium.org --- net/nfc/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Cheers, Samuel. -- Intel

Re: [PATCH 177/193] net/nfc/llcp: remove CONFIG_EXPERIMENTAL

2012-10-24 Thread Samuel Ortiz
Almeida Jr aloisio.alme...@openbossa.org CC: Samuel Ortiz sa...@linux.intel.com CC: David S. Miller da...@davemloft.net CC: John W. Linville linvi...@tuxdriver.com Signed-off-by: Kees Cook keesc...@chromium.org --- net/nfc/llcp/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 178/193] net/nfc/nci: remove CONFIG_EXPERIMENTAL

2012-10-24 Thread Samuel Ortiz
Almeida Jr aloisio.alme...@openbossa.org CC: Samuel Ortiz sa...@linux.intel.com CC: David S. Miller da...@davemloft.net Signed-off-by: Kees Cook keesc...@chromium.org --- net/nfc/nci/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Cheers, Samuel

Re: [PATCH] mfd: rtsx_pcr: Include linux/slab.h to fix build error

2012-11-09 Thread Samuel Ortiz
Hi Axel, On Fri, Nov 09, 2012 at 01:16:41PM +0800, Axel Lin wrote: Fix below build error: I already pushed a similar patch, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 0/8] mfd: Batch together MFD related patches

2012-11-11 Thread Samuel Ortiz
Hi Lee, On Mon, Nov 05, 2012 at 04:10:28PM +0100, Lee Jones wrote: Hi Sam, I know you've been busy giving NFC presentations at ELC, but ... :) All these patches have been on the list in various other patch-sets for some time and have been reviewed by some key people already. All other

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-11-11 Thread Samuel Ortiz
Hi Chris, On Fri, Nov 09, 2012 at 10:34:48AM -0500, Chris Ball wrote: Hi, On Fri, Nov 09 2012, wwang wrote: I have noticed that the file rtsx_pci_sdmmc.c in your mmc-next branch is still v6 patch. In v7 patch, this MMC part has also been modified to comply with my MFD portion. So

Re: [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks

2012-11-11 Thread Samuel Ortiz
Hi Geert, On Mon, Oct 15, 2012 at 10:44:45PM +0200, Geert Uytterhoeven wrote: Older gcc ( 4.4) doesn't like files starting with Unicode BOMs: include/linux/mfd/da9055/core.h:1: error: stray ‘\357’ in program include/linux/mfd/da9055/core.h:1: error: stray ‘\273’ in program

Re: [PATCH 0/6] MFD: twl6040: Conversion to use regmap_irq

2012-11-13 Thread Samuel Ortiz
On Thu, Oct 11, 2012 at 01:55:27PM +0200, Peter Ujfalusi wrote: Hello, This series will convert the twl6040 MFD core driver to use regmap_irq instead of the custom interrupt code it used. In this way considerable amount of code can be removed and we are going to use common, well tested code

Re: [PATCH] MFD: twl-core: Fix chip ID for the twl6030-pwm module

2012-11-13 Thread Samuel Ortiz
Hi Peter, On Wed, Oct 31, 2012 at 03:54:37PM +0100, Peter Ujfalusi wrote: The correct chip id is 1 since the PWM module is on address 0x49. With the current TWL6030_MODULE_ID1 the kernel will crash early since: #define TWL6030_MODULE_ID1 0x0E and static struct twl_client twl_modules[4];

Re: [PATCH RESEND 0/3] mfd: tps6586x: Convert to irq domain

2012-11-13 Thread Samuel Ortiz
Hi Laxman, On Tue, Nov 13, 2012 at 07:18:04PM +0530, Laxman Dewangan wrote: This patch series convert the irq implementation to use the irq domain. Accordingly, gpio driver and rtc registration is updated. Reposting the series and adding the reviwed by Mark and acked by Linus W for the

Re: [PATCH V3 RESEND 0/4] mfd: tps65910: use regmap irq framework for interrupt

2012-11-13 Thread Samuel Ortiz
Hi Laxman, On Tue, Nov 13, 2012 at 07:33:55PM +0530, Laxman Dewangan wrote: This patch series has following change: - Use regmap irq framework for interrupt registration. Corrected the register bit definition for interrupts. - Move the irq table to tps65910.c and get rid of tps65910-irq.c.

[PATCH -mm] VT ioctl race fix

2007-09-27 Thread Samuel Ortiz
-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/char/vt_ioctl.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: linux-2.6.22/drivers/char/vt_ioctl.c === --- linux-2.6.22.orig/drivers/char/vt_ioctl.c 2007-07-09

[PATCH -mm] IrCOMM discovery indication simplification

2007-09-30 Thread Samuel Ortiz
] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/ircomm/ircomm_tty_attach.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) Index: net-2.6.24-quilt/net/irda/ircomm/ircomm_tty_attach.c === --- net

Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-26 Thread Samuel Ortiz
have taken care of it earlier... Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- include/linux/sysctl.h | 20 net/irda/irsysctl.c| 34 ++ 2 files changed, 34 insertions(+), 20

Re: [PATCH 2/2] sysctl: For irda update sysctl_checks list of binary paths.

2007-08-26 Thread Samuel Ortiz
to the list of valid binary sysctl paths. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- kernel/sysctl_check.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/kernel/sysctl_check.c b/kernel

Re: [irda-users] [PATCH] mcs7780 needs to free allocated rx buffer

2007-10-12 Thread Samuel Ortiz
Hi Hinko, On Fri, Oct 12, 2007 at 02:36:46PM +0200, [EMAIL PROTECTED] wrote: Hi, While testing the mcs7780 based IrDA USB dongle I've stumbled upon memory leak in mcs_net_close(). Patch below fixes it. Thanks for the fix. Applied to my local git, will push forward. Cheers, Samuel.

Re: [irda-users] [PATCH] irlmp_unregister_link needs to free lsaps hashbin

2007-10-14 Thread Samuel Ortiz
Hi Hinko, On Fri, Oct 12, 2007 at 02:56:27PM +0200, [EMAIL PROTECTED] wrote: Hi, While testing the mcs7780 based IrDA USB dongle I've stumbled upon memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in irlmp_register_link and should probably be freed in

Re: [PATCH V3 0/7] Initial release of Samsung S2MPS11 pmic driver

2012-07-16 Thread Samuel Ortiz
HiSangbeom, On Wed, Jul 11, 2012 at 09:06:24PM +0900, Sangbeom Kim wrote: The S2MPS11 is comprised of high efficient Buck converters, various LDOs, and an RTC and tightly coupled with Multi Core Samsung Application Processors, which is used in a wide variety of mobile applications such as

Re: [PATCH 1/1] mfd: ab8500: Clean-up the last two ab8500 related DT match tables

2012-07-16 Thread Samuel Ortiz
Hi Lee, On Tue, Jul 10, 2012 at 08:19:26PM +0200, Lee Jones wrote: On 10/07/12 18:55, Samuel Ortiz wrote: Hi Lee, On Tue, Jul 10, 2012 at 05:28:35PM +0200, Lee Jones wrote: On 10/07/12 11:13, Samuel Ortiz wrote: Hi Lee, On Fri, Jul 06, 2012 at 01:43:18PM +0100, Lee Jones wrote: A patch

Re: [PATCH 1/2] mfd: wm5110: Add data tables for the WM5110

2012-07-16 Thread Samuel Ortiz
Hi Mark, On Tue, Jul 10, 2012 at 12:37:57PM +0100, Mark Brown wrote: The WM5110 is a highly integrated low power audio subsystem for smartphones, tablets and other portable audio devices. It combines an advanced DSP feature set with a flexible, high performance audio hub CODEC. This patch

Re: [PATCH] mfd: Remove unneeded io_mutex from struct twl6040

2012-07-16 Thread Samuel Ortiz
Hi Axel, On Wed, Jul 11, 2012 at 10:06:34AM +0800, Axel Lin wrote: Current code has been converted to use regmap APIs, the io_mutex is not needed. Thus remove the io_mutex. Signed-off-by: Axel Lin axel@gmail.com --- drivers/mfd/twl6040-core.c | 23 +++

Re: [PATCH v2] mfd: Remove __devexit annotation for pm80x_deinit

2012-07-16 Thread Samuel Ortiz
Hi Axel, On Wed, Jul 11, 2012 at 10:01:10AM +0800, Axel Lin wrote: This fixes below section mismatch warning: LD drivers/mfd/built-in.o WARNING: drivers/mfd/built-in.o(.devinit.text+0x46c): Section mismatch in reference from the function pm800_probe() to the function

Re: [PATCH] mfd: Fix checking return value of regmap_read()

2012-07-16 Thread Samuel Ortiz
Hi Axel, On Wed, Jul 11, 2012 at 09:27:54AM +0800, Axel Lin wrote: Check the return value of regmap_read() rather than the read value. Signed-off-by: Axel Lin axel@gmail.com --- drivers/mfd/88pm800.c | 16 +--- drivers/mfd/88pm805.c |5 +++-- 2 files changed, 12

Re: [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe

2012-07-16 Thread Samuel Ortiz
Hi Uwe, On Wed, Jul 11, 2012 at 01:36:48PM +0200, Uwe Kleine-König wrote: This was introduced in commit 876989d (mfd: Add device tree probe support for mc13xxx) for spi and later while introducing support for i2c copied to the i2c driver. Modifying driver details is very strange,

Re: [PATCH] mfd: add tps65910 32-kHz-crystal-input init

2012-07-16 Thread Samuel Ortiz
Hi Johan, On Wed, Jul 11, 2012 at 03:44:33PM +0200, Johan Hovold wrote: Replace tps65910_misc_init with a dedicated init function for the 32-kHz-crystal input. Signed-off-by: Johan Hovold jhov...@gmail.com --- Hi Samuel, How about something like this? My thought with misc_init was

Re: [PATCH] mfd: anatop: matches should be NULL when populate child devices

2012-07-17 Thread Samuel Ortiz
Hi Richard, On Mon, Jul 16, 2012 at 04:55:57PM +0800, Richard Zhao wrote: Signed-off-by: Richard Zhao richard.z...@freescale.com --- drivers/mfd/anatop-mfd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied, thanks. Cheers, Samuel. -- Intel Open Source Technology

Re: [PATCH: v2]: Mfd-Initial-support-for-Texas-Instruments-AIC-family-Codecs

2013-04-15 Thread Samuel Ortiz
On Mon, Apr 15, 2013 at 05:41:55PM +0530, x0172184 wrote: On Friday 05 April 2013 09:21 PM, Samuel Ortiz wrote: Hi Mehar, On Sun, Feb 17, 2013 at 05:15:38AM +, BAJWA, MEHAR wrote: Hi Samuel, I am re-sending the MFD support for AIC family of Audio CODECs from Texas Instruments

Re: linux-next: manual merge of the mfd tree with the v4l-dvb tree

2013-04-16 Thread Samuel Ortiz
Hi Mauro, On Wed, Apr 10, 2013 at 06:48:28AM -0300, Mauro Carvalho Chehab wrote: Em Wed, 10 Apr 2013 08:42:53 +0200 Samuel Ortiz sa...@linux.intel.com escreveu: Hi Stephen, On Wed, Apr 10, 2013 at 01:48:13PM +1000, Stephen Rothwell wrote: Hi Samuel, Today's linux-next merge

Re: linux-next: manual merge of the mfd tree with the v4l-dvb tree

2013-04-16 Thread Samuel Ortiz
On Tue, Apr 16, 2013 at 09:25:45AM -0700, Andrey Smirnov wrote: On Tue, Apr 16, 2013 at 6:51 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Mauro, On Wed, Apr 10, 2013 at 06:48:28AM -0300, Mauro Carvalho Chehab wrote: Em Wed, 10 Apr 2013 08:42:53 +0200 Samuel Ortiz sa

Re: [PATCH v9 00/12] Driver for Si476x series of chips

2013-04-18 Thread Samuel Ortiz
On Thu, Apr 18, 2013 at 02:28:00PM -0300, Mauro Carvalho Chehab wrote: Em Thu, 18 Apr 2013 09:58:26 -0700 Andrey Smirnov andrew.smir...@gmail.com escreveu: Driver for Si476x series of chips This is a eight version of the patchset originaly posted here:

Re: [PATCH 11/12] si476x: Fix some config dependencies and a compile warnings

2013-04-18 Thread Samuel Ortiz
On Thu, Apr 18, 2013 at 09:58:37AM -0700, Andrey Smirnov wrote: From: Hans Verkuil hverk...@xs4all.nl radio-si476x depends on SND and SND_SOC, the mfd driver should select REGMAP_I2C. Also fix a small compile warning in a debug message: drivers/mfd/si476x-i2c.c: In function

Re: [PATCH v9 00/12] Driver for Si476x series of chips

2013-04-18 Thread Samuel Ortiz
On Thu, Apr 18, 2013 at 02:57:53PM -0300, Mauro Carvalho Chehab wrote: Em Thu, 18 Apr 2013 19:45:47 +0200 Samuel Ortiz sa...@linux.intel.com escreveu: On Thu, Apr 18, 2013 at 02:28:00PM -0300, Mauro Carvalho Chehab wrote: Em Thu, 18 Apr 2013 09:58:26 -0700 Andrey Smirnov andrew.smir

Re: [PATCH v9 00/12] Driver for Si476x series of chips

2013-04-18 Thread Samuel Ortiz
On Thu, Apr 18, 2013 at 08:17:18PM +0200, Samuel Ortiz wrote: On Thu, Apr 18, 2013 at 02:57:53PM -0300, Mauro Carvalho Chehab wrote: Em Thu, 18 Apr 2013 19:45:47 +0200 Samuel Ortiz sa...@linux.intel.com escreveu: On Thu, Apr 18, 2013 at 02:28:00PM -0300, Mauro Carvalho Chehab wrote

Re: [PATCH 09/12] v4l2: Add a V4L2 driver for SI476X MFD

2013-04-18 Thread Samuel Ortiz
Hi Andrey, On Thu, Apr 18, 2013 at 09:58:35AM -0700, Andrey Smirnov wrote: diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index ead9928..170460d 100644 --- a/drivers/media/radio/Kconfig +++ b/drivers/media/radio/Kconfig @@ -18,6 +18,23 @@ config RADIO_SI470X

Re: [PATCH] input: Export matrix_keypad_parse_of_params()

2013-04-18 Thread Samuel Ortiz
Hi Marek, On Tue, Apr 16, 2013 at 10:50:54AM +0200, Michal Marek wrote: Couple of input drivers depend on this symbol: ERROR: matrix_keypad_parse_of_params [drivers/input/keyboard/tca8418_keypad.ko] undefined! ERROR: matrix_keypad_parse_of_params [drivers/input/keyboard/cros_ec_keyb.ko]

Re: [PATCH v3] MFD: ab8500: pass AB8500 IRQ to debugfs code by resource

2013-04-18 Thread Samuel Ortiz
Hi Linus, On Mon, Apr 15, 2013 at 09:47:01AM +0200, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org The AB8500 debug code which was merged in parallel with the multiplatform work incidentally introduced a new instance using the mach/irqs.h header which is now deleted,

Re: [PATCH 1/2] mfd: wm8994: Add device ID data to WM8994 OF device IDs

2013-04-18 Thread Samuel Ortiz
Hi Mark, On Thu, Apr 11, 2013 at 06:11:50PM +0100, Mark Brown wrote: We can actually read this back from the device but we use this when registered using standard I2C board data registration so make sure it's there for OF too. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com

Re: [PATCH v2] UCB1400: Pass ucb1400-gpio data through ac97 bus

2013-04-18 Thread Samuel Ortiz
On Sun, Apr 14, 2013 at 08:35:48PM +0200, Marek Vasut wrote: Cc: Linus Walleij linus.wall...@linaro.org Cc: Jean Delvare jdelv...@suse.de Cc: Samuel Ortiz sa...@linux.intel.com Cc: Mark Brown broo...@opensource.wolfsonmicro.com Cc: Guenter Roeck li...@roeck-us.net Cc: linux-kernel linux

Re: [PATCH v2] mfd:rtsx: Support RTS5249

2013-04-18 Thread Samuel Ortiz
Hi Wei, On Thu, Apr 11, 2013 at 10:43:40AM +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG wei_w...@realsil.com.cn Support new model: RTS5249 Could you please provide me with a more detailled changelog (What's so different with this model that the current driver does not support ?)

Re: [PATCH v2] mfd:rtsx: Support RTS5249

2013-04-19 Thread Samuel Ortiz
Hi Wei, On Fri, Apr 19, 2013 at 09:50:33AM +0800, wwang wrote: 于 2013年04月19日 06:50, Samuel Ortiz 写道: Hi Wei, On Thu, Apr 11, 2013 at 10:43:40AM +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG wei_w...@realsil.com.cn Support new model: RTS5249 Could you please provide me with a more

Re: [PATCH v9 00/12] Driver for Si476x series of chips

2013-04-19 Thread Samuel Ortiz
Hi Andrey, On Thu, Apr 18, 2013 at 09:58:26AM -0700, Andrey Smirnov wrote: Driver for Si476x series of chips This is a eight version of the patchset originaly posted here: https://lkml.org/lkml/2012/9/13/590 Second version of the patch was posted here: https://lkml.org/lkml/2012/10/5/598

Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion

2013-04-04 Thread Samuel Ortiz
Hi Pali, On Sat, Mar 02, 2013 at 11:23:05PM +0100, Pali Rohár wrote: On Friday 15 February 2013 23:56:49 Pali Rohár wrote: Driver twl4030-madc has hardcoded channel types (10 - battery current, 1 - battery temperature) and also conversation data in variable twl4030_divider_ratios. These

Re: [RESEND: PATCH]: Mfd-Initial-support-for-Texas-Instruments-AIC-family-Codecs

2013-04-05 Thread Samuel Ortiz
Hi Mehar, On Sun, Feb 17, 2013 at 05:15:38AM +, BAJWA, MEHAR wrote: Hi Samuel, I am re-sending the MFD support for AIC family of Audio CODECs from Texas Instruments. The patch was tested on mfd-for-linus-3.8-1. I would like to request that this be considered for inclusion in the

Re: [PATCH 2/4] mfd: palmas: Change the DT node property names to follow the convention

2013-04-05 Thread Samuel Ortiz
Hi, On Mon, Feb 18, 2013 at 10:42:44AM +0530, J Keerthy wrote: DT node properties should not have _. Replacing them by -. Signed-off-by: J Keerthy j-keer...@ti.com --- drivers/mfd/palmas.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Applied, thanks. Cheers, Samuel.

Re: [PATCH v7 1/2] mfd: syscon: Removed unneeded field dev from private driver structure

2013-04-05 Thread Samuel Ortiz
Hi Alexander, On Wed, Mar 13, 2013 at 09:34:19PM +0400, Alexander Shiyan wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- drivers/mfd/syscon.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) Both patches applied, thanks. Cheers, Samuel. -- Intel Open Source

Re: [PATCH 1/2] mfd: stmpe: DT: Enable no-irq mode configuration

2013-04-05 Thread Samuel Ortiz
Hi Linus, On Fri, Mar 01, 2013 at 01:07:16PM +0100, Linus Walleij wrote: From: Gabriel Fernandez gabriel.fernan...@stericsson.com If there is no interrupt property into stmpe node then activate the no-irq mode by setting the irq value to -1. Cc: devicetree-disc...@lists.ozlabs.org

Re: [PATCH 2/2] mfd: stmpe: DT: Add stmpe-i2c dt alias to get id device

2013-04-05 Thread Samuel Ortiz
Hi Linus, On Fri, Mar 01, 2013 at 01:07:26PM +0100, Linus Walleij wrote: From: Gabriel Fernandez gabriel.fernan...@stericsson.com This patch augments the STMP driver to read the device id from the stmpe-i2c dt alias if present. Cc: devicetree-disc...@lists.ozlabs.org Signed-off-by:

Re: [PATCH 1/3] mfd: ab3100-otp: use module_platform_driver_probe()

2013-04-05 Thread Samuel Ortiz
Hi Jingoo, On Tue, Mar 05, 2013 at 01:47:06PM +0900, Jingoo Han wrote: This patch uses module_platform_driver_probe() macro which makes the code smaller and simpler. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/mfd/ab3100-otp.c | 14 +- 1 files changed, 1

Re: [PATCH] mfd: abx500 move the AB8500 Kconfig fragment

2013-04-05 Thread Samuel Ortiz
Hi Linus, On Thu, Mar 14, 2013 at 03:54:24PM +0100, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org Move the AB8500 Kconfig fragment below the AB3100 so the menuconfig menu gets hierarchically nested and looks nice. Having the EZX PCAP in the middle disturbs the nice

Re: [PATCH v10 0/12] Palmas updates

2013-04-05 Thread Samuel Ortiz
Hi Ian, On Fri, Mar 22, 2013 at 02:55:10PM +, Ian Lartey wrote: This patchset adds to the support for the Palmas series of PMIC chips. Some of the patches have previously been submitted individually. The DT bindings doc has been added first due to comments that it was missing. Patches

Re: [PATCH v10 03/12] mfd: palmas add variant and OTP detection

2013-04-05 Thread Samuel Ortiz
Hi Ian, On Fri, Mar 22, 2013 at 02:55:13PM +, Ian Lartey wrote: @@ -278,20 +329,20 @@ static void palmas_dt_to_pdata(struct i2c_client *i2c, int ret; u32 prop; - ret = of_property_read_u32(node, ti,mux_pad1, prop); + ret = of_property_read_u32(node, ti,mux-pad1,

Re: [PATCH] MFD: rtsx_pcr, fix probe fail path

2013-04-05 Thread Samuel Ortiz
Hi Jiry, On Thu, Apr 04, 2013 at 09:34:11PM +0200, Jiri Slaby wrote: When rtsx_pci_acquire_irq fails in rtsx_pci_probe, we forget to disable an MSI (if we enabled it). This results in this warning on the next attempt to load the module: WARNING: at drivers/pci/msi.c:834

Re: [GIT PULL] AB8500 Power and MFD related updates

2013-04-08 Thread Samuel Ortiz
Hi Lee, On Thu, Mar 07, 2013 at 12:38:59PM +0800, Lee Jones wrote: The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8: Linux 3.9-rc1 (2013-03-03 15:11:05 -0800) are available in the git repository at: git://git.linaro.org/people/ljones/linux-3.0-ux500.git

Re: [PATCH 1/1] mfd: adp5520: Use module_i2c_driver()

2013-04-08 Thread Samuel Ortiz
On Mon, Apr 08, 2013 at 02:05:37PM +0530, Sachin Kamat wrote: On 27 March 2013 14:50, Hennerich, Michael michael.henner...@analog.com wrote: Von: Sachin Kamat [sachin.ka...@linaro.org] Gesendet: Mittwoch, 27. März 2013 09:59 An:

Re: linux-next: build failure after merge of the mfd tree

2013-04-08 Thread Samuel Ortiz
Hi Alexander, On Mon, Apr 08, 2013 at 08:45:51AM +0400, Alexander Shiyan wrote: Hello. After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':

Re: [PATCH 0/15] arizona updates for v3.10

2013-04-08 Thread Samuel Ortiz
Hi Mark, On Wed, Apr 03, 2013 at 07:04:23PM +0100, Mark Brown wrote: On Mon, Apr 01, 2013 at 06:27:48PM +0100, Mark Brown wrote: mfd: arizona: Updates for v3.10 This is really a few separate topics which I can split out if required: - WM5102 updates to improve robustness -

Re: [PATCH] mfd: Add device tree bindings for Arizona class devices

2013-04-08 Thread Samuel Ortiz
Hi Mark, On Tue, Apr 02, 2013 at 10:38:48PM +0100, Mark Brown wrote: Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- Documentation/devicetree/bindings/mfd/arizona.txt | 62 drivers/mfd/arizona-core.c| 64

Re: [PATCH 0/15] arizona updates for v3.10

2013-04-08 Thread Samuel Ortiz
On Mon, Apr 08, 2013 at 11:25:56AM +0200, Samuel Ortiz wrote: On Wed, Apr 03, 2013 at 07:04:23PM +0100, Mark Brown wrote: On Mon, Apr 01, 2013 at 06:27:48PM +0100, Mark Brown wrote: mfd: arizona: Updates for v3.10 This is really a few separate topics which I can split out

Re: [GIT PULL] AB8500 Power and MFD related updates

2013-04-08 Thread Samuel Ortiz
On Mon, Apr 08, 2013 at 10:33:03AM +0100, Lee Jones wrote: The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8: Linux 3.9-rc1 (2013-03-03 15:11:05 -0800) are available in the git repository at:

Re: [PATCH 1/1] mfd: max77686: Use NULL instead of 0

2013-04-08 Thread Samuel Ortiz
Hi Sachin, On Tue, Mar 26, 2013 at 10:13:36AM +0530, Sachin Kamat wrote: 'data' is a pointer and hence use NULL instead of 0. Silences the following warning: drivers/mfd/max77686.c:49:50: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc:

Re: [PATCH] mfd: support stmpe1801 18 bits enhanced port expander

2013-04-08 Thread Samuel Ortiz
Hi Jean-Nicolas, On Mon, Feb 18, 2013 at 05:50:22PM +0100, Jean-Nicolas Graux wrote: Provides support for 1801 variant of stmpe gpio port expanders. This chip has 18 gpios configurable as GPI, GPO, keypad matrix, special key or dedicated key function. Note that special/dedicated key

Re: [PATCH v2] mfd: wm8994: silence bogus warning in wm8994_device_init()

2013-04-08 Thread Samuel Ortiz
Hi Jingoo, On Wed, Feb 20, 2013 at 11:53:36AM +0900, Jingoo Han wrote: 'patch_regs' cannot be used uninitialized in wm8994_device_init(), because 'patch_regs' was already guarded by 'regmap_patch'. Thus, that's a bogus warning. Without this patch, the build warning happens as below:

Re: [PATCH v8 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-04-08 Thread Samuel Ortiz
Hi Andrey, On Tue, Mar 26, 2013 at 07:47:18PM -0700, Andrey Smirnov wrote: From: Andrey Smirnov andreysm@charmander.(none) This patch adds all the functions used for exchanging commands with the chip. Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Andrey Smirnov

Re: [PATCH] mfd: Add device tree bindings for Arizona class devices

2013-04-08 Thread Samuel Ortiz
Hi Mark, On Tue, Apr 02, 2013 at 10:38:48PM +0100, Mark Brown wrote: Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- Documentation/devicetree/bindings/mfd/arizona.txt | 62 drivers/mfd/arizona-core.c| 64

Re: [PATCH 0/15] arizona updates for v3.10

2013-04-08 Thread Samuel Ortiz
Hi Mark, On Mon, Apr 08, 2013 at 11:19:51AM +0100, Mark Brown wrote: On Mon, Apr 08, 2013 at 11:04:10AM +0100, Mark Brown wrote: patch series... I'm just re-tagging and re-pushing but were you testing both serieses together? OK, the mirrors seem to have the rebase now. New pull

Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion

2013-04-08 Thread Samuel Ortiz
Hi Pali, On Fri, Feb 15, 2013 at 11:56:49PM +0100, Pali Rohár wrote: Driver twl4030-madc has hardcoded channel types (10 - battery current, 1 - battery temperature) and also conversation data in variable twl4030_divider_ratios. These hardcoded channels are incorrect for Nokia RX-51 board

Re: [PATCH] mfd: support stmpe1801 18 bits enhanced port expander

2013-04-08 Thread Samuel Ortiz
Hi Jean-Nicolas, On Mon, Apr 08, 2013 at 12:04:18PM +0200, Jean-Nicolas GRAUX wrote: On 04/08/2013 11:56 AM, Samuel Ortiz wrote: Hi Jean-Nicolas, On Mon, Feb 18, 2013 at 05:50:22PM +0100, Jean-Nicolas Graux wrote: Provides support for 1801 variant of stmpe gpio port expanders. This chip

Re: [PATCH] mfd:adp5520: Restore mode bits on resume

2013-04-08 Thread Samuel Ortiz
Hi Michael, Lars, On Tue, Feb 19, 2013 at 02:10:04PM +0100, Michael Hennerich wrote: On 02/19/2013 11:51 AM, Lars-Peter Clausen wrote: The adp5520 unfortunately also clears the BL_EN bit when the nSTNDBY bit is cleared. So we need to make sure to restore it during resume if it was set before

Re: [PATCH RFC v2 1/2] max77693: added device tree support

2013-04-08 Thread Samuel Ortiz
Hi Andrzej, On Tue, Feb 19, 2013 at 04:36:16PM +0100, Andrzej Hajda wrote: max77693 mfd main device uses only wakeup field from max77693_platform_data. This field is mapped to wakeup-source property in device tree. Device tree bindings doc will be added in max77693-led patch.

Re: [PATCH V2 1/9] mfd: 88pm860x: drop devm_kfree of devm_kzalloc'd data

2013-04-08 Thread Samuel Ortiz
Hi Jingoo, On Wed, Feb 20, 2013 at 06:27:21PM +0900, Jingoo Han wrote: devm_kfree() allocates memory that is released when a driver detaches. Thus, there is no reason to explicitly call devm_kfree() in probe or remove functions. Signed-off-by: Jingoo Han jg1@samsung.com --- No changes

Re: [PATCH] mfd: trivially fix build warning in sta2x11-mfd

2013-04-08 Thread Samuel Ortiz
Hi Alessandro, On Fri, Feb 22, 2013 at 10:39:59AM +0100, Alessandro Rubini wrote: This driver cannot be a module, so remove is never called. The mishap is mine, and back then there was no warning due to __devexit(). Signed-off-by: Alessandro Rubini rub...@gnudd.com Acked-by: Giancarlo

Re: [PATCH v10 02/12] mfd: palmas: is_palmas_charger needed by multiple drivers

2013-04-08 Thread Samuel Ortiz
Hi Ian, On Fri, Mar 22, 2013 at 02:55:12PM +, Ian Lartey wrote: is_palmas_charger checks for the presence of charging functionality in the device Signed-off-by: Graeme Gregory g...@slimlogic.co.uk Signed-off-by: Ian Lartey i...@slimlogic.co.uk Acked-by: Laxman Dewangani

Re: [Patch V4 1/2] mfd: tps65090: Fix enum in header file

2013-04-08 Thread Samuel Ortiz
Hi Rhyland, On Thu, Mar 21, 2013 at 04:30:41PM -0400, Rhyland Klein wrote: The enum is missing the definition for the first bit, which makes all the rest off by one. Add definition for the TPS65090_IRQ_INTERRUPT bit which at 0. Signed-off-by: Rhyland Klein rkl...@nvidia.com --- v4: - no

Re: [Patch V4 2/2] mfd: tps65090: Add resources for charger

2013-04-08 Thread Samuel Ortiz
Hi Rhyland, On Thu, Mar 21, 2013 at 04:30:42PM -0400, Rhyland Klein wrote: Add irq resources to pass to the charger mfd sub dev so the charger can listen for interrupts. Signed-off-by: Rhyland Klein rkl...@nvidia.com --- v4: - Added of_compatible string to resources for tps65090-charger

Re: [PATCH v10 0/12] Palmas updates

2013-04-08 Thread Samuel Ortiz
Hi Graeme, On Mon, Apr 08, 2013 at 04:55:58PM +0100, Graeme Gregory wrote: On 05/04/13 17:30, Samuel Ortiz wrote: Hi Ian, On Fri, Mar 22, 2013 at 02:55:10PM +, Ian Lartey wrote: This patchset adds to the support for the Palmas series of PMIC chips. Some of the patches have

Re: [PATCH] mfd: palmas: initialise client-of_node for dummy created client

2013-04-08 Thread Samuel Ortiz
Hi Laxman, On Tue, Mar 19, 2013 at 02:28:20PM +0530, Laxman Dewangan wrote: Palmas device have three different i2c addresses. The device creates the two new dummy i2c clients for accessing the register by using primary client adapter. This new dummy i2c client have their of_node as NULL.

Re: [PATCH v8 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-04-08 Thread Samuel Ortiz
Hi Andrey, On Mon, Apr 08, 2013 at 11:34:43AM -0700, Andrey Smirnov wrote: On Mon, Apr 8, 2013 at 3:16 AM, Samuel Ortiz sa...@linux.intel.com wrote: This file doesn't exist yet, which breaks bisectability. I'm fine with you including it with the first patch. I will prepare a branch

Re: [PATCH] mfd: drop select PMIC_DA9055

2013-04-09 Thread Samuel Ortiz
Hi Paul, On Sat, Mar 09, 2013 at 05:32:34PM +0100, Paul Bolle wrote: The Kconfig entry for DA9055 PMIC Support selects PMIC_DA9055. That was probably inspired by the similar select statement in the entry for DA9052/53 PMIC with I2C. But the DA9055 PMIC only comes in an I2C variant and its

Re: [PATCH v8 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-04-09 Thread Samuel Ortiz
On Mon, Apr 08, 2013 at 01:40:40PM -0700, Andrey Smirnov wrote: On Mon, Apr 8, 2013 at 1:09 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Mon, Apr 08, 2013 at 11:34:43AM -0700, Andrey Smirnov wrote: On Mon, Apr 8, 2013 at 3:16 AM, Samuel Ortiz sa...@linux.intel.com wrote: This file

  1   2   3   4   5   6   7   8   9   10   >