Re: [PATCH 1/2] acpi: Fail GED probe when not on hardware-reduced

On Fri, Oct 11, 2019 at 12:38:49PM +0200, Rafael J. Wysocki wrote: > On Wed, Oct 9, 2019 at 3:04 PM Samuel Ortiz wrote: > > > > The Generic Event Device (GED) is a hardware-reduced platform device. > > No, it is not AFAICS. It's a little confusing, I was not sure what's the

[PATCH 2/2] acpi: Always build evged in

is hardware-reduced. For that, the driver must be unconditionally built in. Signed-off-by: Arjan van de Ven Signed-off-by: Samuel Ortiz --- drivers/acpi/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile index 5d361e4e3405

[PATCH 1/2] acpi: Fail GED probe when not on hardware-reduced

The Generic Event Device (GED) is a hardware-reduced platform device. Probing this driver on fixed platforms should fail. Signed-off-by: Samuel Ortiz --- drivers/acpi/evged.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c index aba0d0027586

[PATCH 0/2] acpi: Unconditional GED build

platforms. - The second one disable the conditional evged build. Arjan van de Ven (1): acpi: Always build evged in Samuel Ortiz (1): acpi: Fail GED probe when not on hardware-reduced drivers/acpi/Makefile | 2 +- drivers/acpi/evged.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion

Re: [PATCH] nfc: st21nfca: use setup_timer instead of init_timer

Hi Colin, On Fri, Nov 24, 2017 at 01:37:41PM +, Colin King wrote: > From: Colin Ian King > > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Colin Ian King > --- > drivers/nfc/st21nfca/se.c | 10 -- > 1 file changed,

Re: [PATCH] nfc: st21nfca: use setup_timer instead of init_timer

Hi Colin, On Fri, Nov 24, 2017 at 01:37:41PM +, Colin King wrote: > From: Colin Ian King > > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Colin Ian King > --- > drivers/nfc/st21nfca/se.c | 10 -- > 1 file changed,

Re: [PATCH] NFC: fdp: make struct nci_ops static

On Thu, Oct 05, 2017 at 10:47:12AM +0100, Colin King wrote: > From: Colin Ian King > > The structure nci_ops is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'nci_ops' was not declared. Should

Re: [PATCH] NFC: fdp: make struct nci_ops static

On Thu, Oct 05, 2017 at 10:47:12AM +0100, Colin King wrote: > From: Colin Ian King > > The structure nci_ops is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'nci_ops' was not declared. Should it be static? > >

Re: [PATCH] nfc: s3fwrn5: make array match static const, reduces object code size

Hi Colin, On Tue, Sep 19, 2017 at 03:25:15PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the read-only array match on the stack, instead make > it static const. Makes the object code smaller by over 310 bytes: > > Before: >text

Re: [PATCH] nfc: s3fwrn5: make array match static const, reduces object code size

Hi Colin, On Tue, Sep 19, 2017 at 03:25:15PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the read-only array match on the stack, instead make > it static const. Makes the object code smaller by over 310 bytes: > > Before: >text data bss dec hex

Re: [PATCH 0/8] constify nfc i2c_device_id

Hi Arvind, On Mon, Aug 21, 2017 at 10:33:52PM +0530, Arvind Yadav wrote: > i2c_device_id are not supposed to change at runtime. All functions > working with i2c_device_id provided by work with > const i2c_device_id. So mark the non-const structs as const. > > Arvind Yadav (8): > [PATCH 1/8]

Re: [PATCH 0/8] constify nfc i2c_device_id

Hi Arvind, On Mon, Aug 21, 2017 at 10:33:52PM +0530, Arvind Yadav wrote: > i2c_device_id are not supposed to change at runtime. All functions > working with i2c_device_id provided by work with > const i2c_device_id. So mark the non-const structs as const. > > Arvind Yadav (8): > [PATCH 1/8]

Re: [PATCH v4] NFC: trf7970a: Correct register settings for 27MHz clock

Hi Geoff, On Thu, Apr 27, 2017 at 05:28:46PM -0400, Geoff Lansberry wrote: > In prior commits the selected clock frequency does not propagate > correctly to what is written to the TRF7970A_MODULATOR_SYS_CLK_CTRL > register. > > Signed-off-by: Geoff Lansberry > --- >

Re: [PATCH v4] NFC: trf7970a: Correct register settings for 27MHz clock

Hi Geoff, On Thu, Apr 27, 2017 at 05:28:46PM -0400, Geoff Lansberry wrote: > In prior commits the selected clock frequency does not propagate > correctly to what is written to the TRF7970A_MODULATOR_SYS_CLK_CTRL > register. > > Signed-off-by: Geoff Lansberry > --- > drivers/nfc/trf7970a.c | 7

Re: [PATCH] nfc: Add sockaddr length checks before accessing sa_family in bind handlers

On Tue, Jun 13, 2017 at 06:44:28PM +0200, Mateusz Jurczyk wrote: > Verify that the caller-provided sockaddr structure is large enough to > contain the sa_family field, before accessing it in bind() handlers of the > AF_NFC socket. Since the syscall doesn't enforce a minimum size of the >

Re: [PATCH] nfc: Add sockaddr length checks before accessing sa_family in bind handlers

On Tue, Jun 13, 2017 at 06:44:28PM +0200, Mateusz Jurczyk wrote: > Verify that the caller-provided sockaddr structure is large enough to > contain the sa_family field, before accessing it in bind() handlers of the > AF_NFC socket. Since the syscall doesn't enforce a minimum size of the >

Re: [PATCH] NFC: add NULL checks to avoid potential NULL pointer dereference

On Tue, May 30, 2017 at 03:43:07PM -0500, Gustavo A. R. Silva wrote: > NULL checks at line 457: if (!link0 || !link1) {, implies that both > pointers link0 and link1 might be NULL. > Function nfcsim_link_free() dereference pointers link0 and link1. > Add NULL checks before calling

Re: [PATCH] NFC: add NULL checks to avoid potential NULL pointer dereference

On Tue, May 30, 2017 at 03:43:07PM -0500, Gustavo A. R. Silva wrote: > NULL checks at line 457: if (!link0 || !link1) {, implies that both > pointers link0 and link1 might be NULL. > Function nfcsim_link_free() dereference pointers link0 and link1. > Add NULL checks before calling

Re: [PATCH] nfc: nci: remove unnecessary null check

Hi Gustavo, On Tue, Jun 13, 2017 at 11:37:18AM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary NULL check for pointer conn_info. > conn_info is set in list_for_each_entry() using container_of(), > which is never NULL. > > Addresses-Coverity-ID: 1362349 > Cc: Guenter Roeck

Re: [PATCH] nfc: nci: remove unnecessary null check

Hi Gustavo, On Tue, Jun 13, 2017 at 11:37:18AM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary NULL check for pointer conn_info. > conn_info is set in list_for_each_entry() using container_of(), > which is never NULL. > > Addresses-Coverity-ID: 1362349 > Cc: Guenter Roeck >

Re: [PATCH] nfc: Ensure presence of required attributes in the activate_target netlink handler

Hi Mateusz, On Wed, May 24, 2017 at 12:42:26PM +0200, Mateusz Jurczyk wrote: > Check that the NFC_ATTR_TARGET_INDEX and NFC_ATTR_PROTOCOLS attributes (in > addition to NFC_ATTR_DEVICE_INDEX) are provided by the netlink client > prior to accessing them. This prevents potential unhandled NULL

Re: [PATCH] nfc: Ensure presence of required attributes in the activate_target netlink handler

Hi Mateusz, On Wed, May 24, 2017 at 12:42:26PM +0200, Mateusz Jurczyk wrote: > Check that the NFC_ATTR_TARGET_INDEX and NFC_ATTR_PROTOCOLS attributes (in > addition to NFC_ATTR_DEVICE_INDEX) are provided by the netlink client > prior to accessing them. This prevents potential unhandled NULL

Re: [PATCH] nfc: Fix the sockaddr length sanitization in llcp_sock_connect

Hi Mateusz, On Wed, May 24, 2017 at 12:26:20PM +0200, Mateusz Jurczyk wrote: > Fix the sockaddr length verification in the connect() handler of NFC/LLCP > sockets, to compare against the size of the actual structure expected on > input (sockaddr_nfc_llcp) instead of its shorter version

Re: [PATCH] nfc: Fix the sockaddr length sanitization in llcp_sock_connect

Hi Mateusz, On Wed, May 24, 2017 at 12:26:20PM +0200, Mateusz Jurczyk wrote: > Fix the sockaddr length verification in the connect() handler of NFC/LLCP > sockets, to compare against the size of the actual structure expected on > input (sockaddr_nfc_llcp) instead of its shorter version

Re: [PATCH 0/2] NFC-digital: Adjustments for four function implementations

Hi Markus, On Mon, May 22, 2017 at 02:57:42PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 14:50:05 +0200 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Improve

Re: [PATCH 0/2] NFC-digital: Adjustments for four function implementations

Hi Markus, On Mon, May 22, 2017 at 02:57:42PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 14:50:05 +0200 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Improve a size determination in four

Re: [PATCH] NFC: trf7970a: fix check of clock frequencies, use && instead of ||

Hi Colin, On Mon, Apr 24, 2017 at 02:36:02PM +0100, Colin King wrote: > From: Colin Ian King > > The "or" condition (clk_freq != TRF7970A_27MHZ_CLOCK_FREQUENCY) || > (clk_freq != TRF7970A_13MHZ_CLOCK_FREQUE) will always be true because > clk_freq cannot be equal to two

Re: [PATCH] NFC: trf7970a: fix check of clock frequencies, use && instead of ||

Hi Colin, On Mon, Apr 24, 2017 at 02:36:02PM +0100, Colin King wrote: > From: Colin Ian King > > The "or" condition (clk_freq != TRF7970A_27MHZ_CLOCK_FREQUENCY) || > (clk_freq != TRF7970A_13MHZ_CLOCK_FREQUE) will always be true because > clk_freq cannot be equal to two different values at the

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

Hi Johan, On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote: > This started out with the observation that the nfcmrvl_uart driver > unconditionally dereferenced the tty class device despite the fact that > not every tty has an associated struct device (Unix98 ptys). Some > further

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

Hi Johan, On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote: > This started out with the observation that the nfcmrvl_uart driver > unconditionally dereferenced the tty class device despite the fact that > not every tty has an associated struct device (Unix98 ptys). Some > further

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

Hi Johan, On Tue, Apr 18, 2017 at 12:09:16PM +0200, Johan Hovold wrote: > On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote: > > This started out with the observation that the nfcmrvl_uart driver > > unconditionally dereferenced the tty class device despite the fact that > > not every

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

Hi Johan, On Tue, Apr 18, 2017 at 12:09:16PM +0200, Johan Hovold wrote: > On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote: > > This started out with the observation that the nfcmrvl_uart driver > > unconditionally dereferenced the tty class device despite the fact that > > not every

Re: [PATCH] nfc: fix get_unaligned_...() misuses

On Thu, Apr 06, 2017 at 05:58:59PM +0100, Al Viro wrote: > On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote: > > * use unaligned.h, not unaligned/access_ok.h > > ... which got misspelled in that patch, sorry... Fixed variant follows: > > commit b3e79ba1708c9b74781079c9f8617448fce36b51 >

Re: [PATCH] nfc: fix get_unaligned_...() misuses

On Thu, Apr 06, 2017 at 05:58:59PM +0100, Al Viro wrote: > On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote: > > * use unaligned.h, not unaligned/access_ok.h > > ... which got misspelled in that patch, sorry... Fixed variant follows: > > commit b3e79ba1708c9b74781079c9f8617448fce36b51 >

Re: [PATCH v3 1/3] NFC: trf7970a: add device tree option for 27MHz clock

Hi Geoff, On Wed, Dec 21, 2016 at 11:18:32PM -0500, Geoff Lansberry wrote: > The TRF7970A has configuration options to support hardware designs > which use a 27.12MHz clock. This commit adds a device tree option > 'clock-frequency' to support configuring the this chip for default > 13.56MHz clock

Re: [PATCH v3 1/3] NFC: trf7970a: add device tree option for 27MHz clock

Hi Geoff, On Wed, Dec 21, 2016 at 11:18:32PM -0500, Geoff Lansberry wrote: > The TRF7970A has configuration options to support hardware designs > which use a 27.12MHz clock. This commit adds a device tree option > 'clock-frequency' to support configuring the this chip for default > 13.56MHz clock

Re: [PATCH] nfc: fdp: fix NULL pointer dereference

Hi Sudip, On Tue, Dec 20, 2016 at 09:09:04PM +, Sudip Mukherjee wrote: > We are checking phy after dereferencing it. We can print the debug > information after checking it. If phy is NULL then we will get a good > stack trace to tell us that we are in this irq handler. > > Signed-off-by:

Re: [PATCH] nfc: fdp: fix NULL pointer dereference

Hi Sudip, On Tue, Dec 20, 2016 at 09:09:04PM +, Sudip Mukherjee wrote: > We are checking phy after dereferencing it. We can print the debug > information after checking it. If phy is NULL then we will get a good > stack trace to tell us that we are in this irq handler. > > Signed-off-by:

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

Hi Heiko, On Tue, Feb 07, 2017 at 06:22:04AM +0100, Heiko Schocher wrote: > From: Guan Ben > > Make the EN2 pin optional. This is useful for boards, > which have this pin fix wired, for example to ground. > > Signed-off-by: Guan Ben >

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

Hi Heiko, On Tue, Feb 07, 2017 at 06:22:04AM +0100, Heiko Schocher wrote: > From: Guan Ben > > Make the EN2 pin optional. This is useful for boards, > which have this pin fix wired, for example to ground. > > Signed-off-by: Guan Ben > Signed-off-by: Mark Jonas > Signed-off-by: Heiko Schocher

Re: [PATCH] nfc: nxp-nci: use msleep for long delays

Hi Nicholas, On Sun, Jan 22, 2017 at 01:28:39PM +0100, Nicholas Mc Guire wrote: > ulseep_range() uses hrtimers and provides no advantage over msleep() > for larger delays. For this large delay msleep() is preferable. > > Fixes: commit 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI

Re: [PATCH] nfc: nxp-nci: use msleep for long delays

Hi Nicholas, On Sun, Jan 22, 2017 at 01:28:39PM +0100, Nicholas Mc Guire wrote: > ulseep_range() uses hrtimers and provides no advantage over msleep() > for larger delays. For this large delay msleep() is preferable. > > Fixes: commit 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI

Re: [PATCH v2] nfc: don't be making arch specific unaligned decisions at driver level.

uot;kernel: add common infrastructure for > unaligned access") as a reference. > > Cc: Lauro Ramos Venancio <lauro.venan...@openbossa.org> > Cc: Aloisio Almeida Jr <aloisio.alme...@openbossa.org> > Cc: Samuel Ortiz <sa...@linux.intel.com> > Cc: T

Re: [PATCH v2] nfc: don't be making arch specific unaligned decisions at driver level.

unaligned access to use needs to be > left to the arch level and not used at the driver level. Since not > all arch will have sourced asm/unaligned.h already, we need to call > it out and then the arch can give us just the one definition that > is needed. > > See commit 064106a91be5 (&

Re: [PATCH] NFC: st21nfca: Fix potential memory leak

Hi Christophe, On Sun, Feb 19, 2017 at 10:58:47AM +0100, Christophe JAILLET wrote: > If all bits of 'dev_mask' are already set, there is a memory leak because > 'info' should be freed before returning. > > While fixing it, 'return -ENOMEM' directly if the first kzalloc fails. > This makes the

Re: [PATCH] NFC: st21nfca: Fix potential memory leak

Hi Christophe, On Sun, Feb 19, 2017 at 10:58:47AM +0100, Christophe JAILLET wrote: > If all bits of 'dev_mask' are already set, there is a memory leak because > 'info' should be freed before returning. > > While fixing it, 'return -ENOMEM' directly if the first kzalloc fails. > This makes the

Re: [PATCH 1/3] nfc: nxp-nci: Remove unneeded linux/miscdevice.h include

Hi Corentin, On Thu, Dec 15, 2016 at 03:22:44PM +0100, Corentin Labbe wrote: > drivers/nfc/nxp-nci/i2c.c does not use any miscdevice, so this patch > remove this unnecessary inclusion. > > Signed-off-by: Corentin Labbe > --- > drivers/nfc/nxp-nci/i2c.c | 1 - > 1

Re: [PATCH 1/3] nfc: nxp-nci: Remove unneeded linux/miscdevice.h include

Hi Corentin, On Thu, Dec 15, 2016 at 03:22:44PM +0100, Corentin Labbe wrote: > drivers/nfc/nxp-nci/i2c.c does not use any miscdevice, so this patch > remove this unnecessary inclusion. > > Signed-off-by: Corentin Labbe > --- > drivers/nfc/nxp-nci/i2c.c | 1 - > 1 file changed, 1 deletion(-)

Re: [PATCH] NFC: nfcmrvl: Include unaligned.h instead of access_ok.h

Hi Tobias, On Wed, Oct 26, 2016 at 11:00:12AM +0200, Tobias Klauser wrote: > Including linux/unaligned/access_ok.h causes the allmodconfig build on > ia64 (and maybe others) to fail with the following warnings: > > include/linux/unaligned/access_ok.h:7:19: error: redefinition of >

Re: [PATCH] NFC: nfcmrvl: Include unaligned.h instead of access_ok.h

Hi Tobias, On Wed, Oct 26, 2016 at 11:00:12AM +0200, Tobias Klauser wrote: > Including linux/unaligned/access_ok.h causes the allmodconfig build on > ia64 (and maybe others) to fail with the following warnings: > > include/linux/unaligned/access_ok.h:7:19: error: redefinition of >

Re: [PATCH] NFC: nfcmrvl: drop duplicate header gpio.h

Hi Geliang, On Thu, Nov 24, 2016 at 09:58:34PM +0800, Geliang Tang wrote: > Drop duplicate header gpio.h from nfcmrvl/spi.c. > > Signed-off-by: Geliang Tang > --- > drivers/nfc/nfcmrvl/spi.c | 1 - > 1 file changed, 1 deletion(-) Patch applied, thanks. Cheers, Samuel.

Re: [PATCH] NFC: nfcmrvl: drop duplicate header gpio.h

Hi Geliang, On Thu, Nov 24, 2016 at 09:58:34PM +0800, Geliang Tang wrote: > Drop duplicate header gpio.h from nfcmrvl/spi.c. > > Signed-off-by: Geliang Tang > --- > drivers/nfc/nfcmrvl/spi.c | 1 - > 1 file changed, 1 deletion(-) Patch applied, thanks. Cheers, Samuel.

Re: [PATCH v2] nfc: don't be making arch specific unaligned decisions at driver level.

Hi Paul, On Tue, Mar 28, 2017 at 06:55:26PM -0400, Paul Gortmaker wrote: > On Mon, Jan 9, 2017 at 12:52 PM, Paul Gortmaker > wrote: > > Currently ia64 fails building allmodconfig with variations of: > > > >In file included from drivers/nfc/nxp-nci/i2c.c:39:0: >

Re: [PATCH v2] nfc: don't be making arch specific unaligned decisions at driver level.

Hi Paul, On Tue, Mar 28, 2017 at 06:55:26PM -0400, Paul Gortmaker wrote: > On Mon, Jan 9, 2017 at 12:52 PM, Paul Gortmaker > wrote: > > Currently ia64 fails building allmodconfig with variations of: > > > >In file included from drivers/nfc/nxp-nci/i2c.c:39:0: > >

Re: [PATCH resend 1/4] nfc: Add support RC-S380P to port100

Hi Hirofumi, On Sat, Feb 04, 2017 at 10:15:22AM +0900, OGAWA Hirofumi wrote: > > > Signed-off-by: OGAWA Hirofumi > --- > > drivers/nfc/port100.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) All 4 patches applied, thanks. Cheers, Samuel.

Re: [PATCH resend 1/4] nfc: Add support RC-S380P to port100

Hi Hirofumi, On Sat, Feb 04, 2017 at 10:15:22AM +0900, OGAWA Hirofumi wrote: > > > Signed-off-by: OGAWA Hirofumi > --- > > drivers/nfc/port100.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) All 4 patches applied, thanks. Cheers, Samuel.

Re: [PATCH] NFC: remove TI nfcwilink driver

Ilan Elias <il...@ti.com> > Cc: Marcel Holtmann <mar...@holtmann.org> > Cc: Samuel Ortiz <sa...@linux.intel.com> > Cc: Lauro Ramos Venancio <lauro.venan...@openbossa.org> > Cc: Aloisio Almeida Jr <aloisio.alme...@openbossa.org> > Cc: linux-wirel...@vger.ker

Re: [PATCH] NFC: remove TI nfcwilink driver

n Elias > Cc: Marcel Holtmann > Cc: Samuel Ortiz > Cc: Lauro Ramos Venancio > Cc: Aloisio Almeida Jr > Cc: linux-wirel...@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/nfc/Kconfig | 11 - > drivers

Re: [PATCH] NFC: remove TI nfcwilink driver

Hi Rob, On Fri, Feb 24, 2017 at 02:56:48PM -0600, Rob Herring wrote: > On Wed, Jan 25, 2017 at 11:54 PM, Marcel Holtmann wrote: > > Hi Rob, > > > >> It appears that TI WiLink devices including NFC (WL185x/WL189x) never > >> shipped. The only information I found were

Re: [PATCH] NFC: remove TI nfcwilink driver

Hi Rob, On Fri, Feb 24, 2017 at 02:56:48PM -0600, Rob Herring wrote: > On Wed, Jan 25, 2017 at 11:54 PM, Marcel Holtmann wrote: > > Hi Rob, > > > >> It appears that TI WiLink devices including NFC (WL185x/WL189x) never > >> shipped. The only information I found were announcements in Feb > >>

Re: [PATCH] NFC: nfcmrvl: constify nfcmrvl_if_ops structures

Hi Julia, On Tue, Aug 09, 2016 at 07:03:50PM +0200, Julia Lawall wrote: > The nfcmrvl_if_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/nfc/nfcmrvl/i2c.c |2 +-

Re: [PATCH] NFC: pn533: constify pn533_phy_ops structures

Hi Julia, On Tue, Aug 09, 2016 at 06:11:02PM +0200, Julia Lawall wrote: > The pn533_phy_ops are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/nfc/pn533/i2c.c |2 +- >

Re: [PATCH] NFC: nfcmrvl: constify nfcmrvl_if_ops structures

Hi Julia, On Tue, Aug 09, 2016 at 07:03:50PM +0200, Julia Lawall wrote: > The nfcmrvl_if_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/nfc/nfcmrvl/i2c.c |2 +- >

Re: [PATCH] NFC: pn533: constify pn533_phy_ops structures

Hi Julia, On Tue, Aug 09, 2016 at 06:11:02PM +0200, Julia Lawall wrote: > The pn533_phy_ops are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/nfc/pn533/i2c.c |2 +- > drivers/nfc/pn533/pn533.c |2 +-

Re: [PATCH] NFC: Delete owner assignment

Hi Markus, On Mon, Aug 15, 2016 at 09:12:29AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 15 Aug 2016 09:00:26 +0200 > > The field "owner" is set by core. Thus delete an extra initialisation. > > Generated by:

Re: [PATCH] NFC: Delete owner assignment

Hi Markus, On Mon, Aug 15, 2016 at 09:12:29AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 15 Aug 2016 09:00:26 +0200 > > The field "owner" is set by core. Thus delete an extra initialisation. > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci >

Re: [PATCH] NFC: null-ify info->ram_patch when firmware is released

Hi Colin, On Fri, Jul 15, 2016 at 02:00:33PM +0100, Colin King wrote: > From: Colin Ian King > > When the firmware is released for info->ram_patch currently > info->otp_patch is being nullified and not info->ram_patch. > This looks like a cut-n-paste coding error. Fix

Re: [PATCH] NFC: null-ify info->ram_patch when firmware is released

Hi Colin, On Fri, Jul 15, 2016 at 02:00:33PM +0100, Colin King wrote: > From: Colin Ian King > > When the firmware is released for info->ram_patch currently > info->otp_patch is being nullified and not info->ram_patch. > This looks like a cut-n-paste coding error. Fix this by > nullifing the

Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status

Hi Marcel, On Wed, Jul 13, 2016 at 11:56:02AM +0100, Marcel Holtmann wrote: > Hi Mauro, > > >> On mips and parisc: > >> > >>drivers/bluetooth/btwilink.c: In function 'ti_st_open': > >>drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit > >> constant conversion

Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status

Hi Marcel, On Wed, Jul 13, 2016 at 11:56:02AM +0100, Marcel Holtmann wrote: > Hi Mauro, > > >> On mips and parisc: > >> > >>drivers/bluetooth/btwilink.c: In function 'ti_st_open': > >>drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit > >> constant conversion

Re: [PATCH 08/11] NFC: pn533: reduce output when stopping poll

Hi Michael, On Thu, Apr 21, 2016 at 04:43:56PM +0200, Michael Thalmeier wrote: > @@ -1259,7 +1259,8 @@ static int pn533_rf_complete(struct pn533 *dev, void > *arg, > if (IS_ERR(resp)) { > rc = PTR_ERR(resp); > > - nfc_err(dev->dev, "RF setting error %d\n", rc);

Re: [PATCH 07/11] NFC: pn533: improve cmd queue handling

Hi Michael, On Thu, Apr 21, 2016 at 04:43:55PM +0200, Michael Thalmeier wrote: > Make sure cmd is set before a frame is passed to the transport layer for > sending. In addition pn533_send_async_complete checks if cmd is set before > accessing its members. > > Signed-off-by: Michael Thalmeier

Re: [PATCH 06/11] NFC: pn533: usb: fix errors when poll is stopped

Hi Michael, On Thu, Apr 21, 2016 at 04:43:54PM +0200, Michael Thalmeier wrote: > When a poll ist stopped we need to kill the out_urb request too before > starting a new request. > > Additionally check if cmd is set in pn533_recv_ack befor accessing its struct > members. I understand those 2

Re: [PATCH 08/11] NFC: pn533: reduce output when stopping poll

Hi Michael, On Thu, Apr 21, 2016 at 04:43:56PM +0200, Michael Thalmeier wrote: > @@ -1259,7 +1259,8 @@ static int pn533_rf_complete(struct pn533 *dev, void > *arg, > if (IS_ERR(resp)) { > rc = PTR_ERR(resp); > > - nfc_err(dev->dev, "RF setting error %d\n", rc);

Re: [PATCH 07/11] NFC: pn533: improve cmd queue handling

Hi Michael, On Thu, Apr 21, 2016 at 04:43:55PM +0200, Michael Thalmeier wrote: > Make sure cmd is set before a frame is passed to the transport layer for > sending. In addition pn533_send_async_complete checks if cmd is set before > accessing its members. > > Signed-off-by: Michael Thalmeier >

Re: [PATCH 06/11] NFC: pn533: usb: fix errors when poll is stopped

Hi Michael, On Thu, Apr 21, 2016 at 04:43:54PM +0200, Michael Thalmeier wrote: > When a poll ist stopped we need to kill the out_urb request too before > starting a new request. > > Additionally check if cmd is set in pn533_recv_ack befor accessing its struct > members. I understand those 2

Re: [PATCH 09/11] NFC: pn533: use nfc_alloc_recv_skb for skb allocation

Hi Michael, On Thu, Apr 21, 2016 at 04:43:57PM +0200, Michael Thalmeier wrote: > When multiple receive frames need to be put together in pn533_build_response > we need to use nfc_alloc_recv_skb instead of the normal alloc_skb. Otherwise > the nfc core causes an skb error when it tries to push the

Re: [PATCH 09/11] NFC: pn533: use nfc_alloc_recv_skb for skb allocation

Hi Michael, On Thu, Apr 21, 2016 at 04:43:57PM +0200, Michael Thalmeier wrote: > When multiple receive frames need to be put together in pn533_build_response > we need to use nfc_alloc_recv_skb instead of the normal alloc_skb. Otherwise > the nfc core causes an skb error when it tries to push the

Re: [RESEND] nfc: Drop owner assignment from i2c_driver

Hi Krzysztof, On Wed, Mar 30, 2016 at 09:51:04AM +0900, Krzysztof Kozlowski wrote: > i2c_driver does not need to set an owner because i2c_register_driver() > will set it. > > Signed-off-by: Krzysztof Kozlowski > > --- > > The coccinelle script which generated the

Re: [RESEND] nfc: Drop owner assignment from i2c_driver

Hi Krzysztof, On Wed, Mar 30, 2016 at 09:51:04AM +0900, Krzysztof Kozlowski wrote: > i2c_driver does not need to set an owner because i2c_register_driver() > will set it. > > Signed-off-by: Krzysztof Kozlowski > > --- > > The coccinelle script which generated the patch was sent here: >

Re: [PATCH] nfc: pn533: Add device tree documentation for i2c phy

Hi Michael, On Mon, Apr 11, 2016 at 04:36:02PM +0200, Michael Thalmeier wrote: > Add pn533-i2c phy devicetree documentation > > Signed-off-by: Michael Thalmeier > --- > .../devicetree/bindings/net/nfc/pn533-i2c.txt | 31 > ++ > 1 file

Re: [PATCH] nfc: pn533: Add device tree documentation for i2c phy

Hi Michael, On Mon, Apr 11, 2016 at 04:36:02PM +0200, Michael Thalmeier wrote: > Add pn533-i2c phy devicetree documentation > > Signed-off-by: Michael Thalmeier > --- > .../devicetree/bindings/net/nfc/pn533-i2c.txt | 31 > ++ > 1 file changed, 31 insertions(+) >

Re: [RFC 0/4] NFC: pn533: support for pn532 via I2C

Hi Michael, On Fri, Mar 25, 2016 at 03:46:50PM +0100, Michael Thalmeier wrote: > Michael Thalmeier (4): > NFC: pn533: Send ATR_REQ only if NFC_PROTO_NFC_DEP bit is set in > poll_protocols > NFC: pn533: fix deadlock when socket is closed while processing > command > NFC: pn533:

Re: [RFC 4/4] NFC: pn533: add I2C phy driver

Hi Michael, On Fri, Mar 25, 2016 at 03:46:54PM +0100, Michael Thalmeier wrote: > This adds the I2C phy interface for the pn533 driver. This way the driver can > be used to interact with I2C connected pn532. > > Signed-off-by: Michael Thalmeier > --- >

Re: [RFC 0/4] NFC: pn533: support for pn532 via I2C

Hi Michael, On Fri, Mar 25, 2016 at 03:46:50PM +0100, Michael Thalmeier wrote: > Michael Thalmeier (4): > NFC: pn533: Send ATR_REQ only if NFC_PROTO_NFC_DEP bit is set in > poll_protocols > NFC: pn533: fix deadlock when socket is closed while processing > command > NFC: pn533:

Re: [RFC 4/4] NFC: pn533: add I2C phy driver

Hi Michael, On Fri, Mar 25, 2016 at 03:46:54PM +0100, Michael Thalmeier wrote: > This adds the I2C phy interface for the pn533 driver. This way the driver can > be used to interact with I2C connected pn532. > > Signed-off-by: Michael Thalmeier > --- > drivers/nfc/pn533/Kconfig | 11 ++ >

Re: [PATCH] MAINTAINERS: nfc: s3fwrn5: Add second maintainer

Hi Robert, On Thu, Mar 10, 2016 at 03:22:43PM +0100, Robert Baldyga wrote: > Add Krzysztof Opasiak as maintainer of S3FWRN5 driver. > > Signed-off-by: Robert Baldyga > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Applied to nfc-next. Cheers, Samuel.

Re: [PATCH] MAINTAINERS: nfc: s3fwrn5: Add second maintainer

Hi Robert, On Thu, Mar 10, 2016 at 03:22:43PM +0100, Robert Baldyga wrote: > Add Krzysztof Opasiak as maintainer of S3FWRN5 driver. > > Signed-off-by: Robert Baldyga > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Applied to nfc-next. Cheers, Samuel.

Re: [PATCH 2/3] NFC: trf7970a: use to_spi_device

Hi Tang, On Wed, Dec 23, 2015 at 12:18:42AM +0800, Geliang Tang wrote: > Use to_spi_device() instead of open-coding it. > > Signed-off-by: Geliang Tang > --- > drivers/nfc/trf7970a.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Applied and pushed, thanks. Cheers, Samuel.

Re: [PATCH 2/3] NFC: trf7970a: use to_spi_device

Hi Tang, On Wed, Dec 23, 2015 at 12:18:42AM +0800, Geliang Tang wrote: > Use to_spi_device() instead of open-coding it. > > Signed-off-by: Geliang Tang > --- > drivers/nfc/trf7970a.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Applied and pushed,

Re: [PATCH] NFC: added the rx delay parameter for nfcsim workqueue

Hi Saurabh, On Mon, Dec 21, 2015 at 12:29:30AM +0530, Saurabh Sengar wrote: > added the rx delay parameter as a device tunable parameter. > > Signed-off-by: Saurabh Sengar > --- > This is a follow up patch after the review comments by Samuel Ortiz > on the initial patch. &

Re: [PATCH] nfc: s3fwrn5: constify s3fwrn5_phy_ops structures

Hi Julia, On Fri, Nov 13, 2015 at 01:04:41PM +0100, Julia Lawall wrote: > The s3fwrn5_phy_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. Applied to nfc-next, thanks. Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe

Re: [RESEND PATCH] NFC: added the sysfs entry for nfcsim workqueue delay

Hi Saurabh, On Sun, Dec 13, 2015 at 01:34:35PM +0530, Saurabh Sengar wrote: > added the sysfs entry for nfcsim workqueue delay, as tx_delay > > Signed-off-by: Saurabh Sengar > --- > In case this TODO is not expected to be done, please let me know. > I wonder after my repeated attempts since

Re: [PATCH] NFC: added the rx delay parameter for nfcsim workqueue

Hi Saurabh, On Mon, Dec 21, 2015 at 12:29:30AM +0530, Saurabh Sengar wrote: > added the rx delay parameter as a device tunable parameter. > > Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> > --- > This is a follow up patch after the review comments by Samuel Ortiz &

Re: [RESEND PATCH] NFC: added the sysfs entry for nfcsim workqueue delay

Hi Saurabh, On Sun, Dec 13, 2015 at 01:34:35PM +0530, Saurabh Sengar wrote: > added the sysfs entry for nfcsim workqueue delay, as tx_delay > > Signed-off-by: Saurabh Sengar > --- > In case this TODO is not expected to be done, please let me know. > I wonder after my

Re: [PATCH] nfc: s3fwrn5: constify s3fwrn5_phy_ops structures

Hi Julia, On Fri, Nov 13, 2015 at 01:04:41PM +0100, Julia Lawall wrote: > The s3fwrn5_phy_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. Applied to nfc-next, thanks. Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] NFC: nfcmrvl: fix SPI driver dependencies

Hi Arnd, On Tue, Nov 03, 2015 at 03:03:33PM +0100, Arnd Bergmann wrote: > The newly added nfcmrvl_spi driver uses the spi_nci > infrastructure, but does not have a Kconfig dependency on > that, so we can get a link-time error: > > drivers/built-in.o: In function `nfcmrvl_spi_nci_send': >

Re: [PATCH] NFC: nfcmrvl: fix SPI driver dependencies

Hi Arnd, On Tue, Nov 03, 2015 at 03:03:33PM +0100, Arnd Bergmann wrote: > The newly added nfcmrvl_spi driver uses the spi_nci > infrastructure, but does not have a Kconfig dependency on > that, so we can get a link-time error: > > drivers/built-in.o: In function `nfcmrvl_spi_nci_send': >

Re: [PATCH 1/2] NFC: delete null dereference

Hi Julia, On Sat, Oct 17, 2015 at 11:32:19AM +0200, Julia Lawall wrote: > The exit label performs device_unlock(>dev);, which will fail when dev > is NULL, and nfc_put_device(dev);, which is not useful when dev is NULL, so > just exit the function immediately. > > Problem found using

Re: [PATCH] NFC: nfcwilink: Drop a useless static qualifier

Hi Christophe, On Tue, Oct 13, 2015 at 08:31:04AM +0200, Christophe JAILLET wrote: > There is no need to have the 'struct nfcwilink *drv' variable static in the > probe function. > It only wastes a few bytes of memory. > > Signed-off-by: Christophe JAILLET > --- > drivers/nfc/nfcwilink.c | 2

  1   2   3   4   5   6   7   8   9   10   >