Re: [PATCH] nfc: netlink: avoid NULL pointer dereference on error

gt; > ./net/nfc/netlink.c:1175:21-24: ERROR: dev is NULL but dereferenced. > > Signed-off-by: Vincent Stehlé > Cc: Thierry Escande > Cc: Samuel Ortiz > --- > net/nfc/netlink.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/n

Re: [PATCH] NFC: nxp-nci: constify nxp_nci_phy_ops structure

Hi Julia, On Sun, Oct 11, 2015 at 01:24:13PM +0200, Julia Lawall wrote: > The only instance of a nxp_nci_phy_ops structure is never modified. Thus > the declaration of the structure and all references to the structure type > can be made const. > > Done with the help of Coccinelle. > >

Re: [RESEND PATCH] NFC: trf7970a: Add OF match table

Hi Javier, On Wed, Sep 16, 2015 at 11:08:42AM +0200, Javier Martinez Canillas wrote: > The Documentation/devicetree/bindings/net/nfc/trf7970a.txt DT binding doc > lists "ti,trf7970a" as a compatible string but the corresponding driver > does not have an OF match table. Add the table to the driver

Re: [PATCH 1/2] NFC: delete null dereference

Hi Julia, On Sat, Oct 17, 2015 at 11:32:19AM +0200, Julia Lawall wrote: > The exit label performs device_unlock(>dev);, which will fail when dev > is NULL, and nfc_put_device(dev);, which is not useful when dev is NULL, so > just exit the function immediately. > > Problem found using

Re: [PATCH] NFC: nfcwilink: Drop a useless static qualifier

Hi Christophe, On Tue, Oct 13, 2015 at 08:31:04AM +0200, Christophe JAILLET wrote: > There is no need to have the 'struct nfcwilink *drv' variable static in the > probe function. > It only wastes a few bytes of memory. > > Signed-off-by: Christophe JAILLET > --- >

Re: [PATCH] nfc: netlink: avoid NULL pointer dereference on error

gt; > ./net/nfc/netlink.c:1175:21-24: ERROR: dev is NULL but dereferenced. > > Signed-off-by: Vincent Stehlé <vincent.ste...@laposte.net> > Cc: Thierry Escande <thierry.esca...@linux.intel.com> > Cc: Samuel Ortiz <sa...@linux.intel.com> > --- > net/nf

Re: [PATCH] NFC: nxp-nci: constify nxp_nci_phy_ops structure

Hi Julia, On Sun, Oct 11, 2015 at 01:24:13PM +0200, Julia Lawall wrote: > The only instance of a nxp_nci_phy_ops structure is never modified. Thus > the declaration of the structure and all references to the structure type > can be made const. > > Done with the help of Coccinelle. > >

Re: [RESEND PATCH] NFC: trf7970a: Add OF match table

Hi Javier, On Wed, Sep 16, 2015 at 11:08:42AM +0200, Javier Martinez Canillas wrote: > The Documentation/devicetree/bindings/net/nfc/trf7970a.txt DT binding doc > lists "ti,trf7970a" as a compatible string but the corresponding driver > does not have an OF match table. Add the table to the driver

Re: [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags

Hi Robert, On Mon, Aug 31, 2015 at 10:02:40AM +0200, Robert Baldyga wrote: > [ +cc Samuel Ortiz and ] > > Hi Samuel, > > Could you please apply this patch? Applied, thanks. Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags

Hi Robert, On Mon, Aug 31, 2015 at 10:02:40AM +0200, Robert Baldyga wrote: > [ +cc Samuel Ortiz and <linux-...@lists.01.org> ] > > Hi Samuel, > > Could you please apply this patch? Applied, thanks. Cheers, Samuel. -- To unsubscribe from this list: send the line &quo

Re: [PATCH v3 0/3] nfc: Add driver for Samsung S3FWRN5 NFC Chip

etup() > callback. > > Best regards, > Robert Baldyga > > Changelog: > > v3: > - Addressed comments from Samuel Ortiz: > - Used nci_prop_cmd and nci_prop_ops to handle proprietary requests > - Refactorized s3fwrn5_i2c_nci_read and s3fwrn5_i2c_fw_read > - Mis

Re: [PATCH v3 0/3] nfc: Add driver for Samsung S3FWRN5 NFC Chip

Changelog: v3: - Addressed comments from Samuel Ortiz: - Used nci_prop_cmd and nci_prop_ops to handle proprietary requests - Refactorized s3fwrn5_i2c_nci_read and s3fwrn5_i2c_fw_read - Miscellaneous minor fixes - Added patch NFC: nci: Add post_setup handler - Added patch NFC: nci

Re: [PATCH v2] nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip

Hi Robert, On Thu, Jul 30, 2015 at 04:26:16PM +0200, Robert Baldyga wrote: > +static int s3fwrn5_firmware_update(struct s3fwrn5_info *info) > +{ > + u32 version; > + bool need_update; > + int ret; > + > + ENTER(); We have many tracing tools and frameworks in the kernel, I don't

Re: [PATCH v2] nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip

Hi Robert, On Thu, Jul 30, 2015 at 04:26:16PM +0200, Robert Baldyga wrote: +static int s3fwrn5_firmware_update(struct s3fwrn5_info *info) +{ + u32 version; + bool need_update; + int ret; + + ENTER(); We have many tracing tools and frameworks in the kernel, I don't think

Re: [PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

Hi Joe, On Sun, May 31, 2015 at 05:44:45PM -0700, Joe Perches wrote: > Several of these goto exit; uses should be direct returns > as skb is not yet initialized by nci_hci_get_param(). > > Miscellanea: > > o Use !memcmp instead of memcmp() == 0 > o Remove unnecessary goto from if () {... goto

Re: [char-misc-next] NFC: microread: drop unused variable

Hi Tomas, On Thu, May 07, 2015 at 04:38:30PM +0300, Tomas Winkler wrote: > In microread_i2c_irq_thread_fn 'client' set but not used > > Cc: Lauro Ramos Venancio > Cc: Aloisio Almeida Jr > Signed-off-by: Tomas Winkler > --- > drivers/nfc/microread/i2c.c | 3 --- > 1 file changed, 3

Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG

Hi Valentin, On Tue, Apr 28, 2015 at 11:08:47AM +0200, Valentin Rothberg wrote: > The CPP identifier 'DEBUG' is not used in the source code of nfc at all, > so we can safely remove setting it in both Makefiles. > > Signed-off-by: Valentin Rothberg > --- > I detected this issue with

Re: [PATCH] Doc:nfc: Fix typo in nfc-hci.txt

Hi Msanari, On Fri, Jun 05, 2015 at 09:38:19PM +0900, Masanari Iida wrote: > This patch fix a spelling typo in nfc-hci.txt > > Signed-off-by: Masanari Iida > --- > Documentation/nfc/nfc-hci.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Cheers, Samuel. -- To

Re: [PATCH] Doc:nfc: Fix typo in nfc-hci.txt

Hi Msanari, On Fri, Jun 05, 2015 at 09:38:19PM +0900, Masanari Iida wrote: This patch fix a spelling typo in nfc-hci.txt Signed-off-by: Masanari Iida standby2...@gmail.com --- Documentation/nfc/nfc-hci.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Cheers,

Re: [PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

Hi Joe, On Sun, May 31, 2015 at 05:44:45PM -0700, Joe Perches wrote: Several of these goto exit; uses should be direct returns as skb is not yet initialized by nci_hci_get_param(). Miscellanea: o Use !memcmp instead of memcmp() == 0 o Remove unnecessary goto from if () {... goto exit;}

Re: [char-misc-next] NFC: microread: drop unused variable

Hi Tomas, On Thu, May 07, 2015 at 04:38:30PM +0300, Tomas Winkler wrote: In microread_i2c_irq_thread_fn 'client' set but not used Cc: Lauro Ramos Venancio lauro.venan...@openbossa.org Cc: Aloisio Almeida Jr aloisio.alme...@openbossa.org Signed-off-by: Tomas Winkler tomas.wink...@intel.com

Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG

Hi Valentin, On Tue, Apr 28, 2015 at 11:08:47AM +0200, Valentin Rothberg wrote: The CPP identifier 'DEBUG' is not used in the source code of nfc at all, so we can safely remove setting it in both Makefiles. Signed-off-by: Valentin Rothberg valentinrothb...@gmail.com --- I detected this

Re: [linux-nfc] [PATCH 1/8] NFC: NCI: Allow connection close with dev down

Hi Robert, On Tue, Mar 31, 2015 at 05:03:42PM +0300, Robert Dolca wrote: > On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz wrote: > > Hi Robert, > > > > On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote: > >> By calling __nci_request instead of nci_re

Re: [linux-nfc] [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

Hi Robert, On Wed, Apr 01, 2015 at 06:35:31PM +0300, Robert Dolca wrote: > On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz wrote: > >> + /* If a patch was applied the new version is checked */ > >> + if (patched) { > >> + r = nci_init(n

Re: [linux-nfc] [PATCH 3/8] NFC: NCI: Adds NCI init and reset API for drivers

Hi Robert, On Tue, Mar 31, 2015 at 05:05:53PM +0300, Robert Dolca wrote: > On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz wrote: > > Hi Robert, > > > > On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote: > >> In order to communicate with the devi

Re: [linux-nfc] [PATCH 3/8] NFC: NCI: Adds NCI init and reset API for drivers

Hi Robert, On Tue, Mar 31, 2015 at 05:05:53PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote: In order to communicate with the device during the setup phase

Re: [linux-nfc] [PATCH 1/8] NFC: NCI: Allow connection close with dev down

Hi Robert, On Tue, Mar 31, 2015 at 05:03:42PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote: By calling __nci_request instead of nci_request allows the driver

Re: [linux-nfc] [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

Hi Robert, On Wed, Apr 01, 2015 at 06:35:31PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz sa...@linux.intel.com wrote: + /* If a patch was applied the new version is checked */ + if (patched) { + r = nci_init(ndev); + if (r

Re: [resend PATCH] nfc: logging neatening

Hi Joe, On Tue, Apr 07, 2015 at 12:17:00AM -0700, Joe Perches wrote: > Add missing terminating newlines to nfc_info and nfc_err > to avoid possible interleaving from other messages. > > Miscellanea: > > o typo fix of "unknonwn" in message > o remove unnecessary OOM messages as there's a generic

Re: [resend PATCH] nfc: logging neatening

Hi Joe, On Tue, Apr 07, 2015 at 12:17:00AM -0700, Joe Perches wrote: Add missing terminating newlines to nfc_info and nfc_err to avoid possible interleaving from other messages. Miscellanea: o typo fix of unknonwn in message o remove unnecessary OOM messages as there's a generic

Re: [PATCH 16/16] NFC: pn533: fix error return code

Hi Julia, On Sun, Apr 05, 2015 at 02:06:36PM +0200, Julia Lawall wrote: > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier ret; expression e1,e2; > @@ > ( > if

Re: [PATCH 16/16] NFC: pn533: fix error return code

Hi Julia, On Sun, Apr 05, 2015 at 02:06:36PM +0200, Julia Lawall wrote: Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

Robert, Another comment: On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote: > +static struct i2c_device_id fdp_nci_i2c_id_table[] = { > + {"INT339A", 0}, > + {} > +}; > + > +MODULE_DEVICE_TABLE(i2c, fdp_nci_i2c_id_table); > + > + > +static const struct acpi_device_id

Re: [PATCH v2 0/3] NFC: nxp-nci: Add support for NXP-NCI NFC controllers

Hi Clément, On Mon, Mar 09, 2015 at 11:12:02AM +0100, clement.perroch...@effinnov.com wrote: > From: Clément Perrochaud > > This patch brings support for the NXP-NCI NFC controllers family. > > It has been successfully tested on the following SoC boards: > - BeagleBone > - BeagleBone Black >

Re: [PATCH v2 0/3] NFC: nxp-nci: Add support for NXP-NCI NFC controllers

Hi Clément, On Mon, Mar 09, 2015 at 11:12:02AM +0100, clement.perroch...@effinnov.com wrote: From: Clément Perrochaud clement.perroch...@effinnov.com This patch brings support for the NXP-NCI NFC controllers family. It has been successfully tested on the following SoC boards: -

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

Robert, Another comment: On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote: +static struct i2c_device_id fdp_nci_i2c_id_table[] = { + {INT339A, 0}, + {} +}; + +MODULE_DEVICE_TABLE(i2c, fdp_nci_i2c_id_table); + + +static const struct acpi_device_id

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

Hi Robert, On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote: > The device can be enumerated using ACPI using the id INT339A. Please give us some more details about the device. NCI ? HCI ? Features ? What does the initial patchset support ? > +config NFC_FDP > + tristate "Intel

Re: [PATCH 5/8] NFC: NCI: Don't call setup if previous NCI request failed

Hi Robert, On Tue, Feb 24, 2015 at 12:01:49PM +0200, Robert Dolca wrote: > If the previous nci_request (NCI reset) failed the setup function > was being called anyway. It shouldn't be called if the reset failed. > > The result of the setup function is taken into consideration. If it > fails the

Re: [PATCH 4/8] NFC: NCI: Add a special nci_request for driver

Hi Robert, On Tue, Feb 24, 2015 at 12:01:48PM +0200, Robert Dolca wrote: > This patch adds nci_request_driver and nci_req_complete_driver > as a wrapper for __nci_request. When nci_req_complete_driver is > called it also sets cmd_cnt to 1. This is done because the response is not > sent to the

Re: [PATCH 3/8] NFC: NCI: Adds NCI init and reset API for drivers

Hi Robert, On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote: > In order to communicate with the device during the setup > phase, the driver may need to initialize the device. After > the setup is done the driver should reset the device to leave > it in the same state that it was

Re: [PATCH 1/8] NFC: NCI: Allow connection close with dev down

Hi Robert, On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote: > By calling __nci_request instead of nci_request allows the driver to use > the function while initializing the device (setup stage) > > Signed-off-by: Robert Dolca > --- > net/nfc/nci/core.c | 2 +- > 1 file changed, 1

Re: [PATCH 1/8] NFC: NCI: Allow connection close with dev down

Hi Robert, On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote: By calling __nci_request instead of nci_request allows the driver to use the function while initializing the device (setup stage) Signed-off-by: Robert Dolca robert.do...@intel.com --- net/nfc/nci/core.c | 2 +- 1

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

Hi Robert, On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote: The device can be enumerated using ACPI using the id INT339A. Please give us some more details about the device. NCI ? HCI ? Features ? What does the initial patchset support ? +config NFC_FDP + tristate Intel FDP

Re: [PATCH 4/8] NFC: NCI: Add a special nci_request for driver

Hi Robert, On Tue, Feb 24, 2015 at 12:01:48PM +0200, Robert Dolca wrote: This patch adds nci_request_driver and nci_req_complete_driver as a wrapper for __nci_request. When nci_req_complete_driver is called it also sets cmd_cnt to 1. This is done because the response is not sent to the NFC

Re: [PATCH 3/8] NFC: NCI: Adds NCI init and reset API for drivers

Hi Robert, On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote: In order to communicate with the device during the setup phase, the driver may need to initialize the device. After the setup is done the driver should reset the device to leave it in the same state that it was before

Re: [PATCH 5/8] NFC: NCI: Don't call setup if previous NCI request failed

Hi Robert, On Tue, Feb 24, 2015 at 12:01:49PM +0200, Robert Dolca wrote: If the previous nci_request (NCI reset) failed the setup function was being called anyway. It shouldn't be called if the reset failed. The result of the setup function is taken into consideration. If it fails the init

Re: [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips

Hi Clement, On Thu, Jan 22, 2015 at 04:27:38PM +0100, clement.perroch...@effinnov.com wrote: > @@ -686,7 +686,7 @@ L:alsa-de...@alsa-project.org (moderated for > non-subscribers) > W: http://blackfin.uclinux.org/ > S: Supported > F: sound/soc/blackfin/* > - > + Unneeded change,

Re: [PATCH 4/4] NFC: nxp-nci: Allow module removal during download

Hi Clement, On Thu, Jan 22, 2015 at 04:27:40PM +0100, clement.perroch...@effinnov.com wrote: > From: Clément Perrochaud > > Signed-off-by: Clément Perrochaud > Signed-off-by: Clément Perrochaud > --- > drivers/nfc/nxp-nci/core.c | 7 +++ > drivers/nfc/nxp-nci/firmware.c | 9 ++---

Re: [PATCH 3/4] NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver

Hi Clement, On Thu, Jan 22, 2015 at 04:27:39PM +0100, clement.perroch...@effinnov.com wrote: > From: Clément Perrochaud > > Signed-off-by: Clément Perrochaud > Signed-off-by: Clément Perrochaud Are you sure you want both S-O-B lines ? > +static int nxp_nci_i2c_fw_read(struct nxp_nci_i2c_phy

Re: [PATCH 1/4] NFC: nci: Add FWDL support

Hi Clement, On Thu, Jan 22, 2015 at 04:27:37PM +0100, clement.perroch...@effinnov.com wrote: > From: Clément Perrochaud - It really is not obvious that FWDL actually means firmware download - A small commit message explaining why you need this (Mostly for the NXP chipset for now) would be

Re: [PATCH 4/4] NFC: nxp-nci: Allow module removal during download

Hi Clement, On Thu, Jan 22, 2015 at 04:27:40PM +0100, clement.perroch...@effinnov.com wrote: From: Clément Perrochaud clement.perroch...@nxp.com Signed-off-by: Clément Perrochaud clement.perroch...@nxp.com Signed-off-by: Clément Perrochaud clement.perroch...@effinnov.com ---

Re: [PATCH 1/4] NFC: nci: Add FWDL support

Hi Clement, On Thu, Jan 22, 2015 at 04:27:37PM +0100, clement.perroch...@effinnov.com wrote: From: Clément Perrochaud clement.perroch...@nxp.com - It really is not obvious that FWDL actually means firmware download - A small commit message explaining why you need this (Mostly for the NXP

Re: [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips

Hi Clement, On Thu, Jan 22, 2015 at 04:27:38PM +0100, clement.perroch...@effinnov.com wrote: @@ -686,7 +686,7 @@ L:alsa-de...@alsa-project.org (moderated for non-subscribers) W: http://blackfin.uclinux.org/ S: Supported F: sound/soc/blackfin/* - + Unneeded change, please

Re: [PATCH 3/4] NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver

Hi Clement, On Thu, Jan 22, 2015 at 04:27:39PM +0100, clement.perroch...@effinnov.com wrote: From: Clément Perrochaud clement.perroch...@nxp.com Signed-off-by: Clément Perrochaud clement.perroch...@nxp.com Signed-off-by: Clément Perrochaud clement.perroch...@effinnov.com Are you sure you

Re: [PATCH v2 0/2] Add ACPI support for NXP PN544

Hi Robert, On Mon, Jan 26, 2015 at 01:13:35PM +0200, Robert Dolca wrote: > This patch set introduces ACPI support for PN544. > > gpio_set_value was replaced with gpio_set_value_cansleep in order > to allow GPIO access that may sleep. This is particularelly useful > when GPIO is accessed using

Re: [PATCH v2 2/2] NFC: Add ACPI support for NXP PN544

Hi Robert, On Mon, Jan 26, 2015 at 01:13:37PM +0200, Robert Dolca wrote: > @@ -1022,9 +1127,12 @@ static int pn544_hci_i2c_probe(struct i2c_client > *client, > PN544_I2C_FRAME_HEADROOM, PN544_I2C_FRAME_TAILROOM, > PN544_HCI_I2C_LLC_MAX_PAYLOAD,

Re: [PATCH v2 0/2] Add ACPI support for NXP PN544

Hi Robert, On Mon, Jan 26, 2015 at 01:13:35PM +0200, Robert Dolca wrote: This patch set introduces ACPI support for PN544. gpio_set_value was replaced with gpio_set_value_cansleep in order to allow GPIO access that may sleep. This is particularelly useful when GPIO is accessed using busses

Re: [PATCH v2 2/2] NFC: Add ACPI support for NXP PN544

Hi Robert, On Mon, Jan 26, 2015 at 01:13:37PM +0200, Robert Dolca wrote: @@ -1022,9 +1127,12 @@ static int pn544_hci_i2c_probe(struct i2c_client *client, PN544_I2C_FRAME_HEADROOM, PN544_I2C_FRAME_TAILROOM, PN544_HCI_I2C_LLC_MAX_PAYLOAD,

Re: [PATCHv2] pinctrl: baytrail: Clear DIRECT_IRQ bit

Hi Mika, On Thu, Sep 18, 2014 at 10:49:43AM +0300, Mika Westerberg wrote: > On Wed, Sep 17, 2014 at 03:47:01PM +0200, Loic Poulain wrote: > > Direct Irq En bit can be initialized to a bad value. > > This bit has to be cleared for io access mode. > > +Eric > > I would like to have a bit better

Re: [PATCHv2] pinctrl: baytrail: Clear DIRECT_IRQ bit

Hi Mika, On Thu, Sep 18, 2014 at 10:49:43AM +0300, Mika Westerberg wrote: On Wed, Sep 17, 2014 at 03:47:01PM +0200, Loic Poulain wrote: Direct Irq En bit can be initialized to a bad value. This bit has to be cleared for io access mode. +Eric I would like to have a bit better

Re: [PATCH RESEND 0/3] mmc: rtsx: fix bug and support nonblocking request

Hi Micky, On Mon, Feb 17, 2014 at 10:00:54AM +0800, micky_ch...@realsil.com.cn wrote: > From: Micky Ching > > First we fix the card poweroff bug: the card power is not shutdown when sd/mmc > card removed, this will make UHS-card failed to running in high speed mode if > we > insert the card

Re: [PATCH RESEND 0/3] mmc: rtsx: fix bug and support nonblocking request

Hi Micky, On Mon, Feb 17, 2014 at 10:00:54AM +0800, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn First we fix the card poweroff bug: the card power is not shutdown when sd/mmc card removed, this will make UHS-card failed to running in high speed mode if we

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi Francis, On Fri, Jan 10, 2014 at 08:26:13AM +0100, Francis Moreau wrote: > Hi. > > On 12/10/2013 09:29 AM, Samuel Ortiz wrote: > > Hi Micky, > > > > On Tue, Dec 10, 2013 at 09:56:48AM +0800, micky wrote: > >> Hi Francis: > >> On 12/10/201

[GIT] [3.13] MFD fix

Hi Linus, This is the 2nd MFD pull request for 3.13 It only contains one fix for the rtsx_pcr driver. Without it we see a kernel panic on some machines, when resuming from suspend to RAM. Thanks in advance for pulling it in. The following changes since commit

[GIT] [3.13] MFD fix

Hi Linus, This is the 2nd MFD pull request for 3.13 It only contains one fix for the rtsx_pcr driver. Without it we see a kernel panic on some machines, when resuming from suspend to RAM. Thanks in advance for pulling it in. The following changes since commit

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi Francis, On Fri, Jan 10, 2014 at 08:26:13AM +0100, Francis Moreau wrote: Hi. On 12/10/2013 09:29 AM, Samuel Ortiz wrote: Hi Micky, On Tue, Dec 10, 2013 at 09:56:48AM +0800, micky wrote: Hi Francis: On 12/10/2013 09:39 AM, wwang wrote: which is based on Thomas' patch. Can

Re: [PATCH] NFC: port100: fix leak of usb_device

Hi Alexey, On Sun, Jan 05, 2014 at 12:08:05AM +0400, Alexey Khoroshilov wrote: > port100_probe() calls usb_get_dev(), but there is no usb_put_dev() > in port100_disconnect(). The patch adds one. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey

Re: [PATCH] NFC: port100: fix leak of usb_device

Hi Alexey, On Sun, Jan 05, 2014 at 12:08:05AM +0400, Alexey Khoroshilov wrote: port100_probe() calls usb_get_dev(), but there is no usb_put_dev() in port100_disconnect(). The patch adds one. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi Micky, On Tue, Dec 10, 2013 at 09:56:48AM +0800, micky wrote: > Hi Francis: > On 12/10/2013 09:39 AM, wwang wrote: > >which is based on Thomas' patch. > > Can you help us test this patch, we disable irq while suspend here. I already pushed a patch from Thomas to mfd-fixes that seems to fix

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi Micky, On Tue, Dec 10, 2013 at 09:56:48AM +0800, micky wrote: Hi Francis: On 12/10/2013 09:39 AM, wwang wrote: which is based on Thomas' patch. Can you help us test this patch, we disable irq while suspend here. I already pushed a patch from Thomas to mfd-fixes that seems to fix the

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi Francis, On Mon, Dec 09, 2013 at 08:33:32PM +0100, Francis Moreau wrote: > On 12/03/2013 09:14 AM, Francis Moreau wrote: > > Hello Thomas, > > > > On 12/02/2013 12:20 PM, Thomas Gleixner wrote: > >> On Mon, 2 Dec 2013, Thomas Gleixner wrote: > >>> On Sat, 30 Nov 2013, Francis Moreau wrote: >

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi Francis, Adding Lee to the Cc list. On Tue, Dec 03, 2013 at 09:14:14AM +0100, Francis Moreau wrote: > Now that you did the hard work, I hope driver's maintainer/developper > will care about this issue. I applied Thomas' patch to mfd-fixes. Thanks a lot to you and Thomas for that. Cheers,

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi Francis, Adding Lee to the Cc list. On Tue, Dec 03, 2013 at 09:14:14AM +0100, Francis Moreau wrote: Now that you did the hard work, I hope driver's maintainer/developper will care about this issue. I applied Thomas' patch to mfd-fixes. Thanks a lot to you and Thomas for that. Cheers,

Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi Francis, On Mon, Dec 09, 2013 at 08:33:32PM +0100, Francis Moreau wrote: On 12/03/2013 09:14 AM, Francis Moreau wrote: Hello Thomas, On 12/02/2013 12:20 PM, Thomas Gleixner wrote: On Mon, 2 Dec 2013, Thomas Gleixner wrote: On Sat, 30 Nov 2013, Francis Moreau wrote: Hello Thomas,

[GIT] [3.13] MFD fixes

Samuel Ortiz (1): Merge tag 'mfd-lee-3.13-fixes-1' of git://git.linaro.org/people/ljones/mfd drivers/mfd/Kconfig | 2 +- drivers/mfd/lpc_ich.c | 2 +- drivers/mfd/ti-ssp.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- Intel Open Source Technology Centre http://oss.intel.com

[GIT] [3.13] MFD fixes

Samuel Ortiz (1): Merge tag 'mfd-lee-3.13-fixes-1' of git://git.linaro.org/people/ljones/mfd drivers/mfd/Kconfig | 2 +- drivers/mfd/lpc_ich.c | 2 +- drivers/mfd/ti-ssp.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- Intel Open Source Technology Centre http://oss.intel.com

Re: [PATCH] mfd: ti-ssp: Fix build

Hi Geert, On Sun, Nov 17, 2013 at 07:53:55PM +0100, Geert Uytterhoeven wrote: > drivers/mfd/ti-ssp.c: In function 'ti_ssp_run': > drivers/mfd/ti-ssp.c:286:2: error: implicit declaration of function > 'set_current_state' [-Werror=implicit-function-declaration] >

Re: [PATCH] mfd: ti-ssp: Fix build

Hi Geert, On Sun, Nov 17, 2013 at 07:53:55PM +0100, Geert Uytterhoeven wrote: drivers/mfd/ti-ssp.c: In function 'ti_ssp_run': drivers/mfd/ti-ssp.c:286:2: error: implicit declaration of function 'set_current_state' [-Werror=implicit-function-declaration]

[GIT] [3.13] MFD pull request

: Include linux/of.h header mfd: max77693: Include linux/of.h header Documentation: mfd: Update s2mps11.txt Samuel Ortiz (3): Merge tag 'range-macro' of git://git.kernel.org/.../broonie/regmap Merge tag 'mfd-lee-3.13-1' of git://git.linaro.org/people/ljones/mfd Merge tag

[GIT] [3.13] MFD pull request

: Include linux/of.h header mfd: max77693: Include linux/of.h header Documentation: mfd: Update s2mps11.txt Samuel Ortiz (3): Merge tag 'range-macro' of git://git.kernel.org/.../broonie/regmap Merge tag 'mfd-lee-3.13-1' of git://git.linaro.org/people/ljones/mfd Merge tag

Re: [GIT PULL] mfd: Patches due for v3.13 merge window

Hi Lee, On Mon, Nov 11, 2013 at 11:33:08AM +, Lee Jones wrote: > Hi Sam, > > The following changes since commit 61e6cfa80de5760bbe406f4e815b7739205754d2: > > Linux 3.12-rc5 (2013-10-13 15:41:28 -0700) > > are available in the git repository at: > >

Re: [GIT PULL] mfd: Patches due for v3.13 merge window

Hi Lee, On Mon, Nov 11, 2013 at 11:33:08AM +, Lee Jones wrote: Hi Sam, The following changes since commit 61e6cfa80de5760bbe406f4e815b7739205754d2: Linux 3.12-rc5 (2013-10-13 15:41:28 -0700) are available in the git repository at: git://git.linaro.org/people/ljones/mfd.git

Re: [PATCH 4/4] lpc_ich: Add Device IDs for Intel Wildcat Point-LP PCH

Hi James, On Mon, Nov 04, 2013 at 09:31:20AM -0800, James Ralston wrote: > This patch adds the TCO Watchdog Device IDs for the Intel Wildcat Point-LP > PCH. > > Signed-off-by: James Ralston > --- > drivers/mfd/lpc_ich.c | 13 + > 1 file changed, 13 insertions(+) Applied, right on

Re: [PATCH] mfd: max77693: Fix up bug of wrong interrupt number

Hi Chanwoo, On Mon, Nov 04, 2013 at 10:58:20AM +0900, Chanwoo Choi wrote: > Ping! > > Thanks, > Chanwoo Choi > > On 10/10/2013 10:05 AM, Chanwoo Choi wrote: > > The max77693 MFD device use irq domain method which has hardware interrupt > > number > > and virtual interrupt number getting

Re: [PATCH 4/4] lpc_ich: Add Device IDs for Intel Wildcat Point-LP PCH

Hi James, On Mon, Nov 04, 2013 at 09:31:20AM -0800, James Ralston wrote: This patch adds the TCO Watchdog Device IDs for the Intel Wildcat Point-LP PCH. Signed-off-by: James Ralston james.d.rals...@intel.com --- drivers/mfd/lpc_ich.c | 13 + 1 file changed, 13 insertions(+)

Re: [PATCH] mfd: max77693: Fix up bug of wrong interrupt number

Hi Chanwoo, On Mon, Nov 04, 2013 at 10:58:20AM +0900, Chanwoo Choi wrote: Ping! Thanks, Chanwoo Choi On 10/10/2013 10:05 AM, Chanwoo Choi wrote: The max77693 MFD device use irq domain method which has hardware interrupt number and virtual interrupt number getting through irq domain

Re: [PATCH] NFC: mei_phy: using kfree_skb() instead of kfree()

Hi Salil, On Thu, Oct 31, 2013 at 11:17:46PM +0530, Salil Kapur wrote: > using kfree_skb() instead of kfree() for struct sk_buff > > Signed-off-by: Salil Kapur > --- > drivers/nfc/mei_phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to nfc-next, thanks. Cheers, Samuel.

Re: [PATCH] NFC: mei_phy: using kfree_skb() instead of kfree()

Hi Salil, On Thu, Oct 31, 2013 at 11:17:46PM +0530, Salil Kapur wrote: using kfree_skb() instead of kfree() for struct sk_buff Signed-off-by: Salil Kapur salilkapu...@gmail.com --- drivers/nfc/mei_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to nfc-next, thanks.

Re: [PATCH] mfd: as3722: Don't export the regmap config

Hi Mark, On Fri, Oct 25, 2013 at 09:10:00PM +0100, Mark Brown wrote: > From: Mark Brown > > It's not used outside this file so can be static. > > Signed-off-by: Mark Brown > --- > drivers/mfd/as3722.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Cheers, Samuel.

Re: [PATCH] mfd: as3722: Don't export the regmap config

Hi Mark, On Fri, Oct 25, 2013 at 09:10:00PM +0100, Mark Brown wrote: From: Mark Brown broo...@linaro.org It's not used outside this file so can be static. Signed-off-by: Mark Brown broo...@linaro.org --- drivers/mfd/as3722.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [GIT PULL] MFD patches due for v3.13

Hi Lee, On Wed, Oct 23, 2013 at 04:35:10PM +0100, Lee Jones wrote: > The following changes since commit 61e6cfa80de5760bbe406f4e815b7739205754d2: > > Linux 3.12-rc5 (2013-10-13 15:41:28 -0700) > > are available in the git repository at: > > git://git.linaro.org/people/ljones/mfd.git

Re: [GIT PULL] MFD patches due for v3.13

Hi Lee, On Wed, Oct 23, 2013 at 04:35:10PM +0100, Lee Jones wrote: The following changes since commit 61e6cfa80de5760bbe406f4e815b7739205754d2: Linux 3.12-rc5 (2013-10-13 15:41:28 -0700) are available in the git repository at: git://git.linaro.org/people/ljones/mfd.git

Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

Hi Laxman, On Wed, Sep 26, 2012 at 06:18:04PM +0530, Laxman Dewangan wrote: > Driver throw the warning message if dt node does not > have the info for VMBCH-Threshold and VMBCH2-Threshold. > These properties are optional property and hence it > is not mandatory to have these on DT node and in

Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

Hi Olof, On Wed, Oct 09, 2013 at 05:51:14PM -0700, Olof Johansson wrote: > Hi, > > On Wed, Sep 26, 2012 at 5:48 AM, Laxman Dewangan wrote: > > Driver throw the warning message if dt node does not > > have the info for VMBCH-Threshold and VMBCH2-Threshold. > > These properties are optional

Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

Hi Olof, On Wed, Oct 09, 2013 at 05:51:14PM -0700, Olof Johansson wrote: Hi, On Wed, Sep 26, 2012 at 5:48 AM, Laxman Dewangan ldewan...@nvidia.com wrote: Driver throw the warning message if dt node does not have the info for VMBCH-Threshold and VMBCH2-Threshold. These properties are

Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

Hi Laxman, On Wed, Sep 26, 2012 at 06:18:04PM +0530, Laxman Dewangan wrote: Driver throw the warning message if dt node does not have the info for VMBCH-Threshold and VMBCH2-Threshold. These properties are optional property and hence it is not mandatory to have these on DT node and in this

Re: [PATCH v2 6/9] mfd: wm8994: convert to use I2C core runtime PM

On Thu, Sep 12, 2013 at 12:24:47PM +0300, Mika Westerberg wrote: > On Wed, Sep 11, 2013 at 06:12:43PM +0200, Samuel Ortiz wrote: > > I think it would make more sense for you to merge that one together with > > the related i2c changes. If you prefer that I take it through MFD, &g

Re: [PATCH v2 6/9] mfd: wm8994: convert to use I2C core runtime PM

On Thu, Sep 12, 2013 at 12:24:47PM +0300, Mika Westerberg wrote: On Wed, Sep 11, 2013 at 06:12:43PM +0200, Samuel Ortiz wrote: I think it would make more sense for you to merge that one together with the related i2c changes. If you prefer that I take it through MFD, please let me know

Re: [PATCH v2 6/9] mfd: wm8994: convert to use I2C core runtime PM

8994 driver to use this model. > > Signed-off-by: Mika Westerberg Acked-by: Samuel Ortiz I think it would make more sense for you to merge that one together with the related i2c changes. If you prefer that I take it through MFD, please let me know. Cheers, Samuel. -- Intel Open Sourc

Re: [PATCH v2 6/9] mfd: wm8994: convert to use I2C core runtime PM

. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Acked-by: Samuel Ortiz sa...@linux.intel.com I think it would make more sense for you to merge that one together with the related i2c changes. If you prefer that I take it through MFD, please let me know. Cheers, Samuel

<    1   2   3   4   5   6   7   8   9   10   >