Re: [PATCH] staging: nvec: adjust for mfd_add_devices() API change

2012-09-14 Thread Samuel Ortiz
Hi Stephen, On Wed, Sep 12, 2012 at 10:26:00AM -0600, Stephen Warren wrote: > From: Stephen Warren > > Commit 6607bad "mfd: core: Push irqdomain mapping out into devices" > added a new parameter to mfd_add_devices(), but missed updating the > nvec driver in staging. > > Cc: Mark Brown > Cc: Ma

Re: linux-next: build failure after merge of the staging tree

2012-09-14 Thread Samuel Ortiz
Hi Stephen, On Wed, Sep 12, 2012 at 04:07:19PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the staging tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/hid/hid-sensor-hub.c: In function 'sensor_hub_probe': > drivers/hid/hid-sensor-hub.c:599:3:

Re: [PATCH 1/2] mfd/janz-cmodio: fix MODULBus number sysfs entry

2012-09-13 Thread Samuel Ortiz
s_num (int_enable) register. Mask off > > the unused bits so that the correct value is displayed in sysfs. > > > > Cc: Samuel Ortiz > > Signed-off-by: Ira W. Snyder > > Who will take care of this patch? I will. Cheers, Samuel. -- Intel Open Source Technology Cent

Re: [PATCH] mfd/ab3100: split ab3100 headers out of abx500.h

2012-09-12 Thread Samuel Ortiz
Hi Linus, On Fri, Aug 10, 2012 at 10:32:35AM +0200, Linus Walleij wrote: > From: Marcus Cooper > > The U8500 has its own set of separate header, so the abx500 > becomes completely abstract. Do the same split for the AB3100 > legacy ASIC. > > Signed-off-by: Marcus Cooper > Signed-off-by: Linus

Re: [PATCH v2 0/2] mfd: dt: add power off support for Tegra20/Tegra30

2012-09-11 Thread Samuel Ortiz
On Tue, Sep 11, 2012 at 10:26:55AM -0600, Stephen Warren wrote: > On 09/11/2012 10:08 AM, Samuel Ortiz wrote: > > Hi Stephen, > > > > On Tue, Sep 11, 2012 at 09:15:07AM -0600, Stephen Warren wrote: > >> On 09/11/2012 04:46 AM, Thierry Reding wrote: > >>>

Re: [PATCH v2 0/2] mfd: dt: add power off support for Tegra20/Tegra30

2012-09-11 Thread Samuel Ortiz
Hi Stephen, On Tue, Sep 11, 2012 at 09:15:07AM -0600, Stephen Warren wrote: > On 09/11/2012 04:46 AM, Thierry Reding wrote: > > On Tue, Sep 11, 2012 at 06:25:14PM +0800, Bill Huang wrote: > >> Hi all, > >> > >> Could somebody review this? > > > > Given that I haven't been able to test yet (due t

Re: [PATCH v2 0/2] mfd: dt: add power off support for Tegra20/Tegra30

2012-09-11 Thread Samuel Ortiz
Hi Bill, On Sun, Aug 19, 2012 at 06:07:54PM -0700, Bill Huang wrote: > This patch series add new property into regulator DT for telling whether or > not > to hook pmic's power off routine to system call "pm_power_off". > > Patch 1 add power off support for Tegra20 boards using TPS6586x > Patch 2

Re: [PATCH] mfd: ab8500: Make ab8500_irq_get_virq() static

2012-09-11 Thread Samuel Ortiz
Hi Lee, On Mon, Aug 20, 2012 at 11:53:36AM +0100, Lee Jones wrote: > MFD core now takes care of HWIRQ <-> VIRQ mapping, so the helper > ab8500_irq_get_virq() is no longer used by ab8500 subordinate devices > to obtain a Linux wide Virtual IRQ. The AB8500 IRQ controller still > uses it internally

Re: [PATCH] gpio-ich: Share ownership of GPIO groups

2012-09-11 Thread Samuel Ortiz
for ACPI resource conflict on the whole I/O > range, check on a per-group basis, and consider it a success if at > least one of the groups is available for the OS to use. > > Signed-off-by: Jean Delvare > Cc: Peter Tyser > Cc: Aaron Sierra > Cc: Grant Likely > Cc: Sam

Re: [PATCH] mfd: arizona: Remove unused variable

2012-09-11 Thread Samuel Ortiz
Hi Mark, On Sat, Sep 08, 2012 at 09:00:59AM +0800, Mark Brown wrote: > Left over as bitrot from previous changes. > > Signed-off-by: Mark Brown > --- > drivers/mfd/arizona-irq.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied now. Cheers, Samuel. -- Intel Open Sour

Re: [PATCH] mfd: wm8994: Update WM1811 register patches for latest evaluation

2012-09-11 Thread Samuel Ortiz
Hi Mark, On Thu, Aug 23, 2012 at 04:10:29PM +0100, Mark Brown wrote: > Further evaluation of the device has yielded some improvements to the > device configuration. > > Signed-off-by: Mark Brown > --- > drivers/mfd/wm8994-core.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied

Re: [PATCH] mfd: wm8994: Implement support for WM1811 devices with higher cust_ids

2012-09-11 Thread Samuel Ortiz
Hi Mark, On Thu, Aug 23, 2012 at 03:47:52PM +0100, Mark Brown wrote: > Higher cust_ids have had the device revision field reset so need different > handling of GPIO6. > > Signed-off-by: Mark Brown > --- > drivers/mfd/wm8994-regmap.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Pat

Re: [PATCH] mfd: arizona: Suppress needless calls to the primary IRQ

2012-09-11 Thread Samuel Ortiz
Hi Mark, On Tue, Aug 21, 2012 at 08:02:03PM +0100, Mark Brown wrote: > We can read back if the primary IRQ is asserted from the register map, > meaning that we can suppress polling of the interrupt status registers > when only the AoD IRQ domain is asserting. > > Signed-off-by: Mark Brown > ---

Re: [PATCH] mfd: core: Push irqdomain mapping out into devices

2012-09-11 Thread Samuel Ortiz
Hi Mark, Lee, On Tue, Sep 11, 2012 at 03:16:36PM +0800, Mark Brown wrote: > Currently the MFD core supports remapping MFD cell interrupts using an > irqdomain but only if the MFD is being instantiated using device tree > and only if the device tree bindings use the pattern of registering IPs > in

Re: [PATCH] mfd: arizona: Disable control interface error reporting for early devices

2012-09-11 Thread Samuel Ortiz
Hi Mark, On Tue, Aug 07, 2012 at 07:57:53PM +0100, Mark Brown wrote: > Early revisions of the initial Arizona-based devices can generate spurious > control interface errors in certain circumstances. Avoid causing confusion > by disabling the control interface error reporting on these devices. > >

Re: [PATCH 1/7] mfd: max8925: Move _IO resources out of ioport_ioresource

2012-09-11 Thread Samuel Ortiz
Hi Mark, On Tue, Aug 07, 2012 at 07:42:43PM +0100, Mark Brown wrote: > The removal of mach/io.h from most ARM platforms also set the range of > valid IO ports to be empty for most platforms when previously any 32 > bit integer had been valid. This makes it impossible to add IO resources > as the a

Re: [PATCH] nfc: use system_nrt_wq instead of custom ones

2012-08-23 Thread Samuel Ortiz
Hi Tejun, On Wed, Aug 22, 2012 at 04:22:16PM -0700, Tejun Heo wrote: > NFC is using a number of custom ordered workqueues w/ WQ_MEM_RECLAIM. > WQ_MEM_RECLAIM is unnecessary unless NFC is gonna be used as transport > for storage device, and all use cases match one work item to one > ordered workque

Re: [PATCH] lpc_ich: Fix a 3.5 kernel regression for iTCO_wdt driver

2012-08-23 Thread Samuel Ortiz
Hi Feng, On Thu, Aug 23, 2012 at 01:08:14PM +0800, Feng Tang wrote: > On Wed, 22 Aug 2012 22:55:43 +0100 > Matthew Garrett wrote: > > > On Wed, Aug 22, 2012 at 09:55:12PM +0200, Wim Van Sebroeck wrote: > > > > > Any idea why the acpi_check_resource_conflict() check gives a conflict? > > > > Be

Re: Serious regression in 3.5's iTCO_wdt, does anyone care?

2012-08-23 Thread Samuel Ortiz
Hi Thomas, On Thu, Aug 23, 2012 at 04:15:46PM +0200, Thomas Bächler wrote: > This regards the following commit in the Linus tree: > > commit 887c8ec7219fc8eba78bb8f44a74c660934e9b98 > Author: Aaron Sierra > Date: Fri Apr 20 14:14:11 2012 -0500 > > watchdog: Convert iTCO_wdt driver to mfd

Re: [PATCH] drivers: net: irda: bfin_sir: fix compile error

2012-08-06 Thread Samuel Ortiz
Hi Bob, On Mon, 2012-08-06 at 17:29 +0800, Bob Liu wrote: > Hi Samuel, > > Would you please take a look at this patch? > Since without this patch, regression test for blackfin will fail: > http://kisskb.ellerman.id.au/kisskb/matrix/ > > Thank you! The patch looks fine to

Re: [PATCH] gpio-ich: Share ownership of GPIO groups

2012-08-01 Thread Samuel Ortiz
e. > > > > Signed-off-by: Jean Delvare > > Cc: Peter Tyser > > Cc: Aaron Sierra > > Cc: Grant Likely > > Cc: Samuel Ortiz > > --- > > That's probably not the nicest code you've seen, but everything else I > > could think of either c

Re: [PATCH 4/7] mfd: ab8500-core: Apply the AB8500 CODEC's compatible string to its MFD cell

2012-07-30 Thread Samuel Ortiz
On Sun, Jul 29, 2012 at 09:28:07PM +0100, Mark Brown wrote: > On Fri, Jul 27, 2012 at 03:36:33PM +0200, Samuel Ortiz wrote: > > On Fri, Jul 27, 2012 at 01:38:51PM +0100, Lee Jones wrote: > > > > Provide a compatible string for the AB8500 CODEC to aid in > > > confi

Re: [PATCH 4/7] mfd: ab8500-core: Apply the AB8500 CODEC's compatible string to its MFD cell

2012-07-27 Thread Samuel Ortiz
Hi Lee, On Fri, Jul 27, 2012 at 01:38:51PM +0100, Lee Jones wrote: > Provide a compatible string for the AB8500 CODEC to aid in > configuration property look-up from its associated Device Tree > node. > > Signed-off-by: Lee Jones > --- > drivers/mfd/ab8500-core.c |1 + > 1 file changed, 1 i

Re: [PATCH 3/7] mfd: db8500-prcmu: Ensure AB8500 platform data is passed through MFD Core

2012-07-27 Thread Samuel Ortiz
Hi Lee, On Fri, Jul 27, 2012 at 01:38:50PM +0100, Lee Jones wrote: > When booting via platform code the AB8500 platform data is now passed > in though the DB8500. However, if pdata_size is not set it will not be > subsequently passed onto subordinate devices. This patch correctly > populates pdata

Re: [PATCH] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC

2012-07-27 Thread Samuel Ortiz
, 374 insertions(+), 0 deletions(-) > create mode 100644 drivers/rtc/rtc-tps65910.c For the MFD parts: Acked-by: Samuel Ortiz Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: linux-next: Tree for July 25 (mfd/arizona)

2012-07-27 Thread Samuel Ortiz
Hi Randy On Wed, Jul 25, 2012 at 11:19:59AM -0700, Randy Dunlap wrote: > On 07/24/2012 09:30 PM, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20120724: > > > > > > The mfd tree gained a conflict against Linus' tree. > > > > on i386 and x86_64: > > CONFIG_MFD_ARIZONA=y >

Re: [PATCH 2/2] mfd: wm8994: Flag the interrupt block as requiring runtime PM be enabled

2012-07-24 Thread Samuel Ortiz
Hi Mark, On Tue, Jul 24, 2012 at 03:42:45PM +0100, Mark Brown wrote: > It's only required in a few circumstances but better to be safe. > > Signed-off-by: Mark Brown > --- > > Seems most sensible to merge via regmap? Yep, definitely. Cheers, Samuel. -- Intel Open Source Technology Centre htt

Re: [PATCH -next] mfd: fix arizona-irq.c build by selecting REGMAP_IRQ

2012-07-24 Thread Samuel Ortiz
rizona-irq.c:(.text+0xb2d47): undefined reference to `regmap_irq_get_virq' > (.text+0xb2fe3): undefined reference to `regmap_add_irq_chip' > (.text+0xb3173): undefined reference to `regmap_del_irq_chip' > > Signed-off-by: Randy Dunlap > Cc: Samuel Ortiz > Cc:

Re: [PATCH] mfd: arizona: Add debug trace on entering and leaving runtime suspend

2012-07-24 Thread Samuel Ortiz
Hi Mark, On Fri, Jul 20, 2012 at 05:09:12PM +0100, Mark Brown wrote: > There doesn't appear to be any useful diagnostic information from the > core. > > Signed-off-by: Mark Brown > --- > drivers/mfd/arizona-core.c |4 > 1 file changed, 4 insertions(+) Applied, thanks. Cheers, Samuel.

Re: [PATCH V3 0/6] mfd: tp6586x: enhancements in the driver

2012-07-24 Thread Samuel Ortiz
Hi Laxman, On Wed, Jul 18, 2012 at 11:50:44AM +0530, Laxman Dewangan wrote: > Doing some enhancements in the tps6586x core driver which is > based on some recent driver framework enhancements. > Following are highlights of changes: > - Use devm for allocation to remove the code for freeing it. > -

Re: [PATCH 0/2] MFD: twl6040: Version support fixes, additions

2012-07-24 Thread Samuel Ortiz
Hi Peter, On Mon, Jul 16, 2012 at 11:49:42AM +0200, Peter Ujfalusi wrote: > Hello, > > The following series fixes the revision information for twl6040 and adds > support > for twl6041. > Both patches applied to my for-next branch, thanks. Cheers, Samuel. -- Intel Open Source Technology Centr

Re: [PATCH] mfd: anatop: matches should be NULL when populate child devices

2012-07-17 Thread Samuel Ortiz
Hi Richard, On Mon, Jul 16, 2012 at 04:55:57PM +0800, Richard Zhao wrote: > Signed-off-by: Richard Zhao > --- > drivers/mfd/anatop-mfd.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.co

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-16 Thread Samuel Ortiz
Hi Lee, On Mon, Jul 16, 2012 at 08:35:37AM +0100, Lee Jones wrote: > > I think it would be best if this got merged through whatever tree that > > was used to introduce ab8500_irq_get_virq(); otherwise it will have to > > wait till I resync with mainline sometime in the middle of the next > > relea

Re: [PATCH] mfd: add tps65910 32-kHz-crystal-input init

2012-07-16 Thread Samuel Ortiz
Hi Johan, On Wed, Jul 11, 2012 at 03:44:33PM +0200, Johan Hovold wrote: > Replace tps65910_misc_init with a dedicated init function for the > 32-kHz-crystal input. > > Signed-off-by: Johan Hovold > --- > > Hi Samuel, > > How about something like this? My thought with misc_init was that it coul

Re: [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe

2012-07-16 Thread Samuel Ortiz
Hi Uwe, On Wed, Jul 11, 2012 at 01:36:48PM +0200, Uwe Kleine-König wrote: > This was introduced in commit > > 876989d (mfd: Add device tree probe support for mc13xxx) > > for spi and later while introducing support for i2c copied to the i2c > driver. > > Modifying driver details is very s

Re: [PATCH] mfd: Fix checking return value of regmap_read()

2012-07-16 Thread Samuel Ortiz
Hi Axel, On Wed, Jul 11, 2012 at 09:27:54AM +0800, Axel Lin wrote: > Check the return value of regmap_read() rather than the read value. > > Signed-off-by: Axel Lin > --- > drivers/mfd/88pm800.c | 16 +--- > drivers/mfd/88pm805.c |5 +++-- > 2 files changed, 12 insertions(+),

Re: [PATCH v2] mfd: Remove __devexit annotation for pm80x_deinit

2012-07-16 Thread Samuel Ortiz
Hi Axel, On Wed, Jul 11, 2012 at 10:01:10AM +0800, Axel Lin wrote: > This fixes below section mismatch warning: > > LD drivers/mfd/built-in.o > WARNING: drivers/mfd/built-in.o(.devinit.text+0x46c): Section mismatch in > reference from the function pm800_probe() to the function > .devexit

Re: [PATCH] mfd: Remove unneeded io_mutex from struct twl6040

2012-07-16 Thread Samuel Ortiz
Hi Axel, On Wed, Jul 11, 2012 at 10:06:34AM +0800, Axel Lin wrote: > Current code has been converted to use regmap APIs, the io_mutex is not > needed. > Thus remove the io_mutex. > > Signed-off-by: Axel Lin > --- > drivers/mfd/twl6040-core.c | 23 +++ > include/linux/mfd

Re: [PATCH 1/2] mfd: wm5110: Add data tables for the WM5110

2012-07-16 Thread Samuel Ortiz
Hi Mark, On Tue, Jul 10, 2012 at 12:37:57PM +0100, Mark Brown wrote: > The WM5110 is a highly integrated low power audio subsystem for > smartphones, tablets and other portable audio devices. It combines > an advanced DSP feature set with a flexible, high performance audio > hub CODEC. > > This p

Re: [PATCH 1/1] mfd: ab8500: Clean-up the last two ab8500 related DT match tables

2012-07-16 Thread Samuel Ortiz
Hi Lee, On Tue, Jul 10, 2012 at 08:19:26PM +0200, Lee Jones wrote: > On 10/07/12 18:55, Samuel Ortiz wrote: > >Hi Lee, > > > >On Tue, Jul 10, 2012 at 05:28:35PM +0200, Lee Jones wrote: > >>On 10/07/12 11:13, Samuel Ortiz wrote: > >>>Hi Lee, > >>&

Re: [PATCH V3 0/7] Initial release of Samsung S2MPS11 pmic driver

2012-07-16 Thread Samuel Ortiz
HiSangbeom, On Wed, Jul 11, 2012 at 09:06:24PM +0900, Sangbeom Kim wrote: > The S2MPS11 is comprised of high efficient Buck converters, > various LDOs, and an RTC and tightly coupled with Multi Core Samsung > Application Processors, which is used in a wide variety of mobile applications > such as

[GIT] [3.5] MFD fixes

2012-07-12 Thread Samuel Ortiz
Hi Linus, This is a pull request for the 3.5 MFD fixes. With this one we have: - 3 Palmas fixes, 1 of them being a build error fix. - 2 mc13xx fixes. 1 for fixing an SPI regmap configuration and another one for working around an i.Mx hardware bug. - 1 omap-usb regression fix. - 1 twl6040 build

Re: [PATCH 1/1] mfd: ab8500: Clean-up the last two ab8500 related DT match tables

2012-07-10 Thread Samuel Ortiz
Hi Lee, On Tue, Jul 10, 2012 at 05:28:35PM +0200, Lee Jones wrote: > On 10/07/12 11:13, Samuel Ortiz wrote: > >Hi Lee, > > > >On Fri, Jul 06, 2012 at 01:43:18PM +0100, Lee Jones wrote: > >>A patch was recently submitted to stop all ab8500 devices from > >&

Re: linux-next: build failure after merge of the mfd tree

2012-07-10 Thread Samuel Ortiz
Hi Stephen, On Mon, Jul 09, 2012 at 01:57:19PM +1000, Stephen Rothwell wrote: > Hi Samuel, > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > ERROR: "arizona_dai_ops" [sound/soc/codecs/snd-soc-wm5102.ko] undefined! > ERROR: "wm5102_aod" [driver

Re: [PATCH 1/1] mfd: ab8500: Clean-up the last two ab8500 related DT match tables

2012-07-10 Thread Samuel Ortiz
always were. > > Two patches have recently been applied which enable Device Tree > probing; one for rtc-ab8500 and the other for ponkey-ab8500. > These two need to be removed to prevent double-probing these > devices with Device Tree is enabled. > > Cc: Samuel

Re: [PATCH 1/2] mfd: arizona: Add support for multiple PDM speaker outputs

2012-07-10 Thread Samuel Ortiz
Hi Mark, On Mon, Jul 09, 2012 at 07:33:14PM +0100, Mark Brown wrote: > The registers have stride 2 so we can write the loop properly now. > > Signed-off-by: Mark Brown > --- > drivers/mfd/arizona-core.c|5 ++--- > include/linux/mfd/arizona/pdata.h |2 +- > 2 files changed, 3 ins

Re: [PATCH] mfd: Export pm80x_regmap_config

2012-07-10 Thread Samuel Ortiz
Hi Axel, On Mon, Jul 09, 2012 at 10:44:21PM +0800, Axel Lin wrote: > This fixes below build error when CONFIG_MFD_88PM800=m. > > ERROR: "pm80x_regmap_config" [drivers/mfd/88pm800.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > Signed-off-by: Axel Lin > --- >

Re: [PATCH] mfd: Guard max77686_pmic_dt_match with CONFIG_OF

2012-07-10 Thread Samuel Ortiz
Hi Axel, On Mon, Jul 09, 2012 at 10:29:00PM +0800, Axel Lin wrote: > This fixes below build warning if CONFIG_OF is not set. > > CC drivers/mfd/max77686.o > drivers/mfd/max77686.c:37:42: warning: 'max77686_pmic_dt_match' defined but > not used [-Wunused-variable] > > Signed-off-by: Axel

Re: [PATCH] mfd: arizona: Error out if initial boot fails

2012-07-09 Thread Samuel Ortiz
Hi Mark, On Mon, Jul 09, 2012 at 11:56:43AM +0100, Mark Brown wrote: > Signed-off-by: Mark Brown > --- > drivers/mfd/arizona-core.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Applied, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ --

Re: [PATCH 1/6] mfd: max77686: Use pmic regmap to read pmic interrupt register.

2012-07-09 Thread Samuel Ortiz
Hi Yadwinder, On Thu, Jul 05, 2012 at 09:28:20AM +0530, Yadwinder Singh Brar wrote: > PMIC's regmap should be used to read pmic interrupt registers. > > Signed-off-by: Yadwinder Singh Brar > --- > drivers/mfd/max77686-irq.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) This one

Re: [PATCH] MFD: twl-core: move device_init_wakeup to after platform_device_add.

2012-07-09 Thread Samuel Ortiz
Hi Neil, On Sat, Jul 07, 2012 at 08:51:03AM +1000, NeilBrown wrote: > > > device_init_wakeup uses the dev_name() of the device to set the > name of the wakeup_source which appears in > /sys/kernel/debug/wakeup_sources. > > For a platform device, that name is not set until platform_device_add >

Re: [PATCH V2 0/7] Initial release of Samsung S2MPS11 pmic driver

2012-07-09 Thread Samuel Ortiz
Hi Sangbeom, On Sat, Jul 07, 2012 at 06:39:12PM +0900, Sangbeom Kim wrote: > The S2MPS11 is comprised of high efficient Buck converters, > various LDOs, and an RTC and tightly coupled with Multi Core Samsung > Application Processors, which is used in a wide variety of mobile applications > such a

Re: linux-next: build failure after merge of the mfd tree

2012-07-09 Thread Samuel Ortiz
Hi Stephen, Mark, On Mon, Jul 09, 2012 at 01:57:19PM +1000, Stephen Rothwell wrote: > Hi Samuel, > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > ERROR: "arizona_dai_ops" [sound/soc/codecs/snd-soc-wm5102.ko] undefined! > ERROR: "wm5102_aod" [

Re: [PATCH 1/6] mfd: arizona: Add more register definitions

2012-07-08 Thread Samuel Ortiz
Hi Mark, On Thu, Jul 05, 2012 at 08:35:28PM +0100, Mark Brown wrote: > These registers will be used in future devices. > > Signed-off-by: Mark Brown > --- > include/linux/mfd/arizona/registers.h | 163 > + > 1 file changed, 163 insertions(+) This patch and the

Re: [PATCH] mfd: arizona: Move digital core supply management to the regulator API

2012-07-08 Thread Samuel Ortiz
Hi Mark, On Wed, Jul 04, 2012 at 08:09:12PM +0100, Mark Brown wrote: > Rather than open coding the enable GPIO control in the MFD core use the > API to push the management on to the regulator driver. The immediate > advantage is slight for most systems but this will in future allow device > config

Re: [PATCH] mfd: arizona: Force on REGMAP for the core

2012-07-08 Thread Samuel Ortiz
Hi Mark, On Tue, Jul 03, 2012 at 12:45:39PM +0100, Mark Brown wrote: > While the core isn't useful by itself it does depend on regmap so try to > force that on. > > Reported-by: MyungJoo Ham > Signed-off-by: Mark Brown > --- > drivers/mfd/Kconfig |1 + > 1 file changed, 1 insertion(+) Patc

Re: [PATCH 2/2] mfd: wm8994: Also restore GPIO IRQ masks after reset

2012-07-08 Thread Samuel Ortiz
Hi Mark, On Fri, Jun 29, 2012 at 02:55:40PM +0100, Mark Brown wrote: > This ensures that if we are using a GPIO as a wake source it continues to > function while we're suspended. > > Signed-off-by: Mark Brown > --- > drivers/mfd/wm8994-core.c |7 +++ > 1 file changed, 7 insertions(+) Ap

Re: [PATCH 1/2] mfd: wm8994: Use regcache_sync_region() to sync GPIO registers on suspend

2012-07-08 Thread Samuel Ortiz
Hi Mark, On Fri, Jun 29, 2012 at 02:55:39PM +0100, Mark Brown wrote: > Now we have regcache sync region we can use it to do a more efficient > sync of the pin configuration after we reset the device during suspend. > > Signed-off-by: Mark Brown > --- > drivers/mfd/wm8994-core.c | 13 -

Re: [PATCH 0/7] mfd: Wolfson Arizona and WM5102 support

2012-07-08 Thread Samuel Ortiz
Hi Mark, On Sat, Jun 23, 2012 at 01:54:47PM +0100, Mark Brown wrote: > This patch series adds the MFD core driver for the WM5102 and other > Wolfson Arizona class devices. > > The series has a dependency on a new regmap feature, support for wake > IRQs. Assuming the code is OK I don't know how

Re: [PATCH] net/irda/parameters.c: Trivial fixes

2007-11-25 Thread Samuel Ortiz
Hi Richard, On Sat, Nov 24, 2007 at 09:44:05PM +0100, Richard Knutsson wrote: > Make a single va_start() -> va_end() path + fixing: Ok, this should be 2 separate patches then. The warning fixes are all good, but I fail to see the point of the va_end() one. That doesn't seem to bring any sort of im

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-20 Thread Samuel Ortiz
On Fri, Oct 19, 2007 at 11:00:34AM -0700, Andrew Morton wrote: > On Fri, 19 Oct 2007 12:53:00 +0200 Samuel Ortiz <[EMAIL PROTECTED]> wrote: > > > On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote: > > > On Thu, 18 Oct 2007 11:12:41 +0200 > > > Sa

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-19 Thread Samuel Ortiz
On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote: > On Thu, 18 Oct 2007 11:12:41 +0200 > Samuel Ortiz <[EMAIL PROTECTED]> wrote: > You're not a big fan of checkpatch, I see. Well, now I am :-) I fixed all the errors, there are only a couple lines being more tha

Re: [RFC] [PATCH -mm] ASIC3 driver

2007-10-18 Thread Samuel Ortiz
On Fri, Oct 19, 2007 at 12:15:47AM +0200, Thomas Gleixner wrote: > On Thu, 18 Oct 2007, Andrew Morton wrote: > > > + > > > +#include > > > +#include > > > +#include > > > > Please see the large comment at the top of linux/irq.h. I believe this > > driver will fial to compile on at least arm. >

[RFC] [PATCH -mm] ASIC3 driver

2007-10-18 Thread Samuel Ortiz
d and accepted. [1] http://lkml.org/lkml/2007/5/1/46 Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> --- drivers/mfd/Kconfig |6 drivers/mfd/Makefile |1 drivers/mfd/asic3.c | 572 ++ include/linux/mfd/asi

Re: [irda-users] [PATCH] irlmp_unregister_link needs to free lsaps hashbin

2007-10-14 Thread Samuel Ortiz
Hi Hinko, On Fri, Oct 12, 2007 at 02:56:27PM +0200, [EMAIL PROTECTED] wrote: > Hi, > > While testing the mcs7780 based IrDA USB dongle I've stumbled upon > memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in > irlmp_register_link and should probably be freed in irlmp_unregiste

Re: [irda-users] [PATCH] mcs7780 needs to free allocated rx buffer

2007-10-12 Thread Samuel Ortiz
Hi Hinko, On Fri, Oct 12, 2007 at 02:36:46PM +0200, [EMAIL PROTECTED] wrote: > Hi, > > While testing the mcs7780 based IrDA USB dongle I've stumbled upon > memory leak in mcs_net_close(). Patch below fixes it. Thanks for the fix. Applied to my local git, will push forward. Cheers, Samuel. > Si

[PATCH -mm] IrCOMM discovery indication simplification

2007-09-30 Thread Samuel Ortiz
ROTECTED]> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> --- net/irda/ircomm/ircomm_tty_attach.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) Index: net-2.6.24-quilt/net/irda/ircomm/ircomm_tty_attach.c ==

[PATCH -mm] VT ioctl race fix

2007-09-27 Thread Samuel Ortiz
-by: Samuel Ortiz <[EMAIL PROTECTED]> --- drivers/char/vt_ioctl.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: linux-2.6.22/drivers/char/vt_ioctl.c === --- linux-2.6.22.orig/drivers/char/vt_ioctl.c 2

Re: [PATCH 2/2] sysctl: For irda update sysctl_checks list of binary paths.

2007-08-26 Thread Samuel Ortiz
hs in the kernel. So add them to > the list of valid binary sysctl paths. > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> > --- > kernel/sysctl_check.c | 19 +++ > 1 files changed, 19

Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-26 Thread Samuel Ortiz
for that, I should have taken care of it earlier... > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> > --- > include/linux/sysctl.h | 20 > net/irda/irsysctl.c| 34 ++---

Re: RFC: removing DONGLE_OLD drivers?

2007-07-12 Thread Samuel Ortiz
Hi Adrian, On Mon, Jul 09, 2007 at 07:25:39PM +0200, Adrian Bunk wrote: > With one exception, all DONGLE_OLD drivers have newer counterparts. > > The DONGLE_OLD drivers depend on BROKEN_ON_SMP which e.g. implies that > the many distributions shipping only SMP-kernels will never offer them. > >

Re: 2.6.22-rc: regression: no irda0 interface (2.6.21 was OK), smsc does not find chip

2007-06-07 Thread Samuel Ortiz
Hi Bjorn, On 6/7/2007, "Bjorn Helgaas" <[EMAIL PROTECTED]> wrote: >On Wednesday 06 June 2007 02:45:01 pm Andrey Borzenkov wrote: >> On Wednesday 06 June 2007, Bjorn Helgaas wrote: >> > On Tuesday 05 June 2007 09:29:11 pm Andrey Borzenkov wrote: >> > > On Wednesday 06 June 2007, Bjorn Helgaas wrot

RE: 2.6.22-rc: regression: no irda0 interface (2.6.21 was OK), smsc does not find chip

2007-06-05 Thread Samuel Ortiz
On 6/5/2007, "Linus Walleij (LD/EAB)" <[EMAIL PROTECTED]> wrote: >Sam wrote: > >> Andrey, in addition to Bjorn's patch, could you also apply >> this one and try again: >> >> diff --git a/drivers/net/irda/smsc-ircc2.c >> b/drivers/net/irda/smsc-ircc2.c index 31c6233..800562a 100644 >> --- a/dri

RE: 2.6.22-rc: regression: no irda0 interface (2.6.21 was OK), smsc does not find chip

2007-06-05 Thread Samuel Ortiz
Hi Linus, On 6/5/2007, "Linus Walleij (LD/EAB)" <[EMAIL PROTECTED]> wrote: >> > Ok, FIR and SIR are definitey mixed up. So, now could you please >try >> > Bjorn's patch ? >> >> does not work. > >It looks like the purpose of the patch is to provide more printouts >not to fix the problem, pleas

Re: 2.6.22-rc: regression: no irda0 interface (2.6.21 was OK), smsc does not find chip

2007-06-04 Thread Samuel Ortiz
(Adding Linus Walleij, who wrote part of the smsc driver, to Cc:) On Mon, Jun 04, 2007 at 06:33:56AM +0400, Andrey Borzenkov wrote: > On Monday 04 June 2007, Samuel Ortiz wrote: > > It seems that PnP tells us that the FIR port is at 0x2e8 while we're > > expecting it at 0x2f8.

Re: 2.6.22-rc: regression: no irda0 interface (2.6.21 was OK), smsc does not find chip

2007-06-03 Thread Samuel Ortiz
Hi Andrey, On Sun, Jun 03, 2007 at 12:16:05PM +0400, Andrey Borzenkov wrote: > > Adding "nopnp" parameters finds device just fine so it is apparently result > of > this commit: > > commit d0d4f69bb65a8c1c1430c577a583632709b874c6 > Author: Bjorn Helgaas <[EMAIL PROTECTED]> > Date: Tue May 8 0

Re: [git patches] net driver fixes

2007-03-29 Thread Samuel Ortiz
On 3/30/2007, "Guennadi Liakhovetski" <[EMAIL PROTECTED]> wrote: >On Thu, 29 Mar 2007, Jeff Garzik wrote: > >> Guennadi Liakhovetski wrote: >>> Jeff, might be worth getting the sk_buff leak fix in ppp from >>> http://www.spinics.net/lists/netdev/msg27706.html in 2.6.21 too? >>> >>> Don't know how

Re: irda rmmod lockdep trace.

2007-03-16 Thread Samuel Ortiz
On Tue, Mar 13, 2007 at 07:22:37PM -0700, David Miller wrote: > From: Samuel Ortiz <[EMAIL PROTECTED]> > Date: Wed, 14 Mar 2007 02:50:03 +0200 > > > On Mon, Mar 12, 2007 at 04:49:21PM -0700, David Miller wrote: > > > I would strongly caution against adding any run-ti

[PATCH 6/6] IrDA: Lockdep annotation for hashbin locks

2007-03-14 Thread Samuel Ortiz
Rmmoding irda triggers a lockdep false positive. We can fix that by assigning each hashbin lock to a separate class. Reported-by: Dave Jones <[EMAIL PROTECTED]> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> --- include/net/irda/irqueue.h |1 + net/irda/irqueue.c |

Re: irda rmmod lockdep trace.

2007-03-13 Thread Samuel Ortiz
On Mon, Mar 12, 2007 at 04:49:21PM -0700, David Miller wrote: > I would strongly caution against adding any run-time overhead just to > cure a false lockdep warning. Even adding a new function argument > is too much IMHO. > > Make the cost show up for lockdep only, perhaps by putting each > hashb

Re: irda rmmod lockdep trace.

2007-03-13 Thread Samuel Ortiz
On 3/12/2007, "David Miller" <[EMAIL PROTECTED]> wrote: >From: Samuel Ortiz <[EMAIL PROTECTED]> >Date: Mon, 12 Mar 2007 02:38:43 +0200 > >> On Sat, Mar 10, 2007 at 07:43:26PM +0200, Samuel Ortiz wrote: >> > Hi Dave, >> > >>

Re: irda rmmod lockdep trace.

2007-03-11 Thread Samuel Ortiz
Hi Dave, On Sat, Mar 10, 2007 at 07:43:26PM +0200, Samuel Ortiz wrote: > Hi Dave, > > On Thu, Mar 08, 2007 at 05:54:36PM -0500, Dave Jones wrote: > > modprobe irda ; rmmod irda in 2.6.21rc3 gets me the spew below.. > Well it seems that we call __irias_delete_object() from hash

Re: irda rmmod lockdep trace.

2007-03-10 Thread Samuel Ortiz
Hi Dave, On Thu, Mar 08, 2007 at 05:54:36PM -0500, Dave Jones wrote: > modprobe irda ; rmmod irda in 2.6.21rc3 gets me the spew below.. Well it seems that we call __irias_delete_object() from hashbin_delete(). Then __irias_delete_object() calls itself hashbin_delete() again. We're trying to get th

Re: [2.6 patch] drivers/net/irda/vlsi_ir.{h,c}: remove kernel 2.4 code

2007-01-21 Thread Samuel Ortiz
On Thu, Jan 18, 2007 at 10:56:13PM +0100, Adrian Bunk wrote: > This patch removes kernel 2.4 compatibility code. Looks correct to me, thanks. > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Samuel Ortiz <[EMAIL PROTECTED]> > --- > > driver

Re: [2.6 patch] net/irda/: proper prototypes

2006-12-19 Thread Samuel Ortiz
Hi Adrian, On Mon, Dec 18, 2006 at 04:46:26AM +0100, Adrian Bunk wrote: > This patch adds proper prototypes for some functions in > include/net/irda/irda.h > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> looks good to me, thanks. Signed-off-by: Samuel Ortiz <[EMAI

<    2   3   4   5   6   7