parenthesis around it to avoid static
type checker warnings is kind of missing the point.
Your patch does apply fine with git-am, so don't worry about the line
endings. Can you please move the assignment into the loop and resubmit
this patch?
Sarah Sharp
--
To unsubscribe from this list: send the line
.
Alex, can you make a new patch that fixes this?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
(xhci, prev);
+ prev = next;
+ }
Is it just
for (prev = *first; prev; prev = prev-next)
xhci_segment_free(xhci, prev);
?
Yeah, that seems cleaner.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux
-in,
will the EHCI driver compile? I'll have to double check this...
Thanks for catching this!
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
will help you, if you want to just try
that:
http://git.kernel.org/?p=linux/kernel/git/sarah/xhci.git;a=commit;h=ae8963adb4ad8c5f2a89ca1d99fb7bb721e7599f
Sarah Sharp
On Tue, Oct 09, 2012 at 09:51:55AM +0800, WANG Siyuan wrote:
hi, Daniel
my usb 3.0 hard drive doesn't have external power
On Thu, Nov 01, 2012 at 01:28:46PM -0700, Julius Werner wrote:
Is it just
for (prev = *first; prev; prev = prev-next)
xhci_segment_free(xhci, prev);
?
Yeah, that seems cleaner.
Sarah Sharp
I can submit it that way if you want, but I would advise against it. This way
a git bisect? Because that commit only applies to
when the system is suspended, not when the USB device is suspended.
Sarah Sharp
commit ee537508bdc0c00b96ac497f3d82a68f820e6182
Author: Michael Spang sp...@chromium.org
Date: Fri Sep 14 13:05:49 2012 -0400
Increase XHCI suspend timeout
, not when they are moved. That causes the user to sit
there, frustrated, as they move their mouse and wonder why their screen
doesn't unblank. Other keyboards also lose keystrokes, which means if
you pause to compose your thoughts, the first couple letters you type
gets dropped.
Sarah Sharp
. System Model: Z1
Signed-off-by: Alexis R. Cortes alexis.cor...@ti.com
Sarah, if you don't mind, I can take this one now, it's trivial enough.
Want to give me your ack?
Sure, looks fine.
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Also, I'm guessing that backporting it would
;
+
No, this fix is not acceptable. You won't get USB 3.0 speeds if the
ports are not switched over. Now, we can add a quirk to the xHCI
shutdown function to switch the ports back to EHCI on shutdown. That
might not trigger the BIOS bug.
Sarah Sharp
--
To unsubscribe from this list: send
On Wed, Jul 18, 2012 at 09:57:30AM +0300, Denis Turischev wrote:
On 07/17/2012 07:54 AM, Sarah Sharp wrote:
On Mon, Jul 16, 2012 at 07:46:06PM +0300, Denis Turischev wrote:
Intense-PC is Compulab's mini-desktop with Intel Panther Point
chipset.
Unconditional ports switching provided
Add a sub-heading, and emphasize reproducibility.
Suggest taking a picture of the oops message. (Did no one have cameras
in 2006?)
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
REPORTING-BUGS | 26 ++
1 files changed, 14 insertions(+), 12 deletions
, and get_maintainer.pl.
More will be added/modified in upcoming patches.
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
REPORTING-BUGS | 65 +++
1 files changed, 46 insertions(+), 19 deletions(-)
diff --git a/REPORTING-BUGS b
if these
bugs are ignored during the merge window.
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: Linus Torvalds torva...@linux-foundation.org
---
REPORTING-BUGS | 42 +-
1 files changed, 41 insertions(+), 1 deletions(-)
diff --git a/REPORTING-BUGS b
in, and direct bug reporters to their Linux distribution or
embedded vendor if the bug is in an unsupported kernel.
Suggest that bug reporters should reproduce their bugs on the latest -rc
kernel.
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
REPORTING-BUGS | 22
The document is largely not the same as the original that was crafted
from Frohwalt Egerer's document, but leave it in as a historical thank
you footnote.
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
REPORTING-BUGS |3 ++-
1 files changed, 2 insertions(+), 1 deletions
to 8d874c1030e1ae4c174d8f947841ee3ee196f898:
Docs: Move ref to Frohwalt Egerer to end of REPORTING-BUGS (2013-04-15
10:10:23 -0700)
Sarah Sharp (7):
Trivial: docs: Remove six-space indentation in REPORTING-BUGS.
Docs: Step-by-step
Other paragraph format docs in Documentation don't use paragraph
indentations, so conform REPORTING-BUGS to that.
Re-wrap the paragraphs, keeping the doc to a 74-character line length,
since that's what the original seemed to use.
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
something to point to.
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
REPORTING-BUGS | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/REPORTING-BUGS b/REPORTING-BUGS
index 327b33b..d397e918 100644
--- a/REPORTING-BUGS
+++ b/REPORTING-BUGS
@@ -64,6
instead of Endpoint 0x80 OUT Context? There are input
contexts and output contexts in xHCI, and I want to imply the endpoint
is either IN or OUT, not the context.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
Thanks Ted!
On Mon, Apr 15, 2013 at 09:47:42PM -0400, Theodore Ts'o wrote:
Sarah,
Thanks so much for improving the REPORTING-BUGS file. With your
changes it looks way better!
- Ted
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
On Tue, Apr 16, 2013 at 09:15:06PM -0500, Rob Landley wrote:
On 04/15/2013 12:33:34 PM, Sarah Sharp wrote:
Outline how often it's polite to ping kernel maintainers about
bugs, and
suggest that kernel maintainers should respond to bugs in 1 to 5
business days.
Is there anything in here
On Wed, Apr 17, 2013 at 06:49:40PM -0500, Rob Landley wrote:
On 04/17/2013 01:23:28 PM, Sarah Sharp wrote:
On Tue, Apr 16, 2013 at 09:15:06PM -0500, Rob Landley wrote:
On 04/15/2013 12:33:34 PM, Sarah Sharp wrote:
Outline how often it's polite to ping kernel maintainers about
bugs
On Thu, Apr 04, 2013 at 01:02:45PM +0530, Vivek Gautam wrote:
On Thu, Apr 4, 2013 at 12:40 PM, Felipe Balbi ba...@ti.com wrote:
On Thu, Apr 04, 2013 at 10:34:57AM +0530, Vivek Gautam wrote:
Hi Sarah,
On Wed, Apr 3, 2013 at 10:57 PM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote
the USB formatted endpoint numbers. Having macros for later use
would be helpful.
Also, this patch is too late for the 3.10 merge window, so it will
have to wait for 3.11.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
dhowe...@redhat.com
cc: Sarah Sharp sarah.a.sh...@linux.intel.com
cc: Greg Kroah-Hartman gre...@linuxfoundation.org
cc: linux-...@vger.kernel.org
...
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1234,8 +1234,8 @@ union xhci_trb {
#define TRBS_PER_SEGMENT 64
/* Allow
On Thu, Mar 28, 2013 at 10:32:53PM +, David Howells wrote:
Sarah Sharp sarah.a.sh...@linux.intel.com wrote:
I'm a little bit confused about your description for the second one.
Did you need to change the #defines names because they could conflict
with other drivers when the xHCI
not reporting the USB 2.0
port connect at all.
Maybe if we completely disable PCI runtime PM for your host, we can work
around this bug?
Can you send me the output of `sudo lspci -vvv -n` again?
Sarah Sharp
[ 1760.576768] hub 3-0:1.0: hub_suspend
[ 1760.576774] usb usb3: bus auto-suspend, wakeup 1
On Tue, Apr 02, 2013 at 07:07:36PM +0100, David Howells wrote:
Sarah Sharp sarah.a.sh...@linux.intel.com wrote:
I guess my question is a deeper one: do we need to rename all the xHCI
macros to have the XHCI_ prefix, in order to avoid future collision?
For example, one of the macros
Question: Do you still need this patch for 3.10?
http://marc.info/?l=linux-usbm=136057666911621w=2
Does this patchset build on top of that?
I'm really behind on my patches for 3.10, sorry.
Sarah Sharp
On Mon, Apr 01, 2013 at 07:23:59PM +0530, Vivek Gautam wrote:
This patch-series enables
EVENT_TRB_LEN(p)((p) 0xff)
+
/** Transfer Event bit fields **/
#define TRB_TO_EP_ID(p) (((p) 16) 0x1f)
--
1.7.6.5
Can you correct these and resubmit? Thanks!
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
that bit to check whether or
not the device has signalled wakeup.
For this reason, make pci_acpi_wake_dev() always attempt to resume
the device it is called for regardless of the device's PME Status bit
value (that bit still has to be cleared if set at this point,
though).
Reported-by: Sarah
On Fri, Mar 01, 2013 at 08:48:39AM -0800, Greg KH wrote:
On Wed, Feb 13, 2013 at 02:12:50PM -0800, Sarah Sharp wrote:
On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote:
On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote:
On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias
=132972894117916w=2
(Apparently we had this issue around the same time last year, but we
thought the BIOS bug had been resolved.)
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Looks fine on the xHCI portion. Thanks for catching the XHCI_BROKEN_MSI
case.
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
On Mon, Mar 04, 2013 at 05:14:43PM +0100, Thomas Renninger wrote:
From: Hannes Reinecke h...@suse.de
xhci has its own interrupt enabling routine, which will try
with it.
Sarah Sharp
On Mon, Jan 28, 2013 at 12:46:39PM -0800, Jonathan Nieder wrote:
Hi Holger,
Holger Hoffstaette wrote:
On Mon, Jan 28, 2013 at 12:42:16PM +0100, Holger Hoffstaette wrote:
Apologies for being late but I'm afraid I just found at least one
regression in this release.
I have
On Tue, Feb 12, 2013 at 11:35:29AM +0100, Holger Hoffstätte wrote:
On 02/12/13 01:40, Sarah Sharp wrote:
Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING,
recompile the 3.7.5 kernel, and send me dmesg starting from the point
you unmount the device and then power it off
On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote:
On 13.02.2013 09:28, Holger Hoffstätte wrote:
On 12.02.2013 21:42, Sarah Sharp wrote:
[..]
There was a further set of patches queued for 3.9 to deal with connected
devices going to the Inactive state
sending it to Greg today after I test it (and the rest of my queue)
out. It will be in the stable trees after it hits Linus' tree.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Hi Nickolai,
Thanks for catching this. Don't worry about sending a new patch with
the short description for the commit, I'll fix that when I send it off.
Sarah Sharp
On Mon, Jan 07, 2013 at 10:39:31PM -0500, Nickolai Zeldovich wrote:
Fix incorrect bit test that originally showed up
On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote:
On 13.02.2013 11:33, Sarah Sharp wrote:
On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote:
On 13.02.2013 09:28, Holger Hoffstätte wrote:
On 12.02.2013 21:42, Sarah Sharp wrote
On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote:
On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote:
On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote:
On 13.02.2013 11:33, Sarah Sharp wrote:
On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias
Hmm, your patch got corrupted:
sarah@xanatos:~/git/kernels/xhci$ git am -s -3
~/Maildir.fetchmail/.to-apply-next/
Applying: USB: XHCI: xhci-ring: Remove unused dma address calculation in
inc_enq and inc_deq function
fatal: corrupt patch at line 18
Repository lacks necessary blobs to fall back
,
because patch will truncate the subject line after that. Make it short,
sweet, and easy to read in a glance, like Remove unused variable in
inc_enq and inq_deq.
Sarah Sharp
On Fri, Sep 07, 2012 at 12:38:04AM +0530, Girish Verma wrote:
Signed-off-by: Girish Verma gir...@circuitsutra.com
On Fri, Sep 14, 2012 at 01:05:49PM -0400, Michael Spang wrote:
The Intel XHCI specification says that after clearing the run/stop bit
the controller may take up to 16ms to halt. We've seen a device take
14ms, which with the current timeout of 10ms causes the kernel to
abort the suspend.
applying this patch to the usb-next branch?
No objections for the xHCI changes.
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index 9981984..f70c1a1 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
Hi Daniel,
I already have a patch in my queue for this. However, it keys off the
PCI_DEVICE_ID_ASROCK_P67 PCI device ID. Do you have another Etron
device with a different device ID that needs this quirk?
Sarah Sharp
On Fri, Jul 27, 2012 at 12:03:44PM +0800, Daniel J Blueman wrote:
When
On Fri, Jul 27, 2012 at 02:40:56PM +0800, Daniel J Blueman wrote:
On 27 July 2012 14:14, Sarah Sharp sarah.a.sh...@linux.intel.com wrote:
On Fri, Jul 27, 2012 at 12:03:44PM +0800, Daniel J Blueman wrote:
When various USB3 devices with Etron XHCI controllers, we see a bunch of
warnings
Hi Denis,
Can you send me the output of `sudo dmidecode`? I'd like to see if I
can make a more general patch apply to the Intense-PC.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Tue, Jul 31, 2012 at 06:49:50AM +0200, Oliver Neukum wrote:
On Monday 30 July 2012 15:34:06 Sarah Sharp wrote:
Hi Denis,
Can you send me the output of `sudo dmidecode`? I'd like to see if I
can make a more general patch apply to the Intense-PC.
As this is for shutdown, why not all
On Tue, Jul 31, 2012 at 10:06:34AM -0700, Sarah Sharp wrote:
On Tue, Jul 31, 2012 at 06:49:50AM +0200, Oliver Neukum wrote:
On Monday 30 July 2012 15:34:06 Sarah Sharp wrote:
Hi Denis,
Can you send me the output of `sudo dmidecode`? I'd like to see if I
can make a more general
inclination is to queue it for stable as well.
Greg, any objections?
Sarah Sharp
On Tue, Sep 04, 2012 at 01:40:42PM -0500, Alexis R. Cortes wrote:
Hi Sarah/Greg,
Sorry to bother you, but I was wondering if you have some news concerning my
patch for the Compliance Mode issue of our re-driver. Should
Hi Girish,
Sorry for taking a really long time to respond! This is a good idea,
but your patch doesn't apply any more. Can you update it against the
latest kernel and resend it?
Sarah Sharp
On Sun, May 13, 2012 at 08:59:02PM +0530, Girish Verma wrote:
In xhci-ring.c, function inc_enq
the BIOS and chipset folks that this quirk needs to
be more broadly applied. I'll send you a revised patch. Can you test
it and make sure it works for you?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Reported-by: Denis Turischev de...@compulab.co.il
Cc: sta...@vger.kernel.org
---
drivers/usb/host/pci-quirks.c |7 +++
drivers/usb/host/pci-quirks.h |1 +
drivers/usb/host/xhci-pci.c |9 +
drivers/usb/host/xhci.c |3
for them later.
+
/* Write XUSB2PR, the xHC USB 2.0 Port Routing Register, to
* switch the USB 2.0 power and data lines over to the xHCI
* host.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Fri, Aug 10, 2012 at 12:13:19AM +0800, Keng-Yu Lin wrote:
On Thu, Aug 9, 2012 at 10:24 PM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
On Thu, Aug 09, 2012 at 05:31:51PM +0800, Keng-Yu Lin wrote:
With a previous patch to enable the EHCI/XHCI port switching, it switches
all
On Mon, Aug 13, 2012 at 01:59:00PM +0800, Alex Shi wrote:
On 06/12/2012 05:14 AM, gregkh wrote:
On Mon, Jun 11, 2012 at 01:47:09PM -0700, Sarah Sharp wrote:
Hi Alex,
This got lost in the 3.5 push, but I think it's a good candidate for
3.6. I think Greg is accepting 3.6 patches now
patches have been
applied in the past.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Recovery Timer
Deleted.\n);
}
}
}
Then you can call that new function in the ugly long indent-heavy function
in xhci-hub.c.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
port_status_u0;
+/* Compliance Mode Timer Triggered every 2 seconds */
+#define COMP_MODE_RCVRY_MSECS 2000
};
/* convert between an HCD pointer and the corresponding EHCI_HCD */
--
1.7.1
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
;
+ u32 port_status_u0;
+/* Compliance Mode Timer Triggered every 2 seconds */
+#define COMP_MODE_RCVRY_MSECS 2000
};
/* convert between an HCD pointer and the corresponding EHCI_HCD */
(END)
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux
around in BIOS. So I might
edit your description on the first patch a bit when I submit it to Greg.
Sarah Sharp
On Mon, Jul 23, 2012 at 02:46:32PM +0300, Denis Turischev wrote:
Intense-PC is Compulab's mini-desktop with Intel Panther Point
chipset.
Unconditional switchover to xHCI provided
On Tue, Jul 24, 2012 at 11:50:42AM +0300, Denis Turischev wrote:
On 07/23/2012 08:44 PM, Sarah Sharp wrote:
Did you try disabling the wake on bits in the port status registers? I
would prefer that solution if it works.
No, I didn't. Why we need to disable wake on capabilities?
My theory
:
http://marc.info/?l=linux-usbm=134886294107752w=2
But LPM was added in 3.4, so I don't know why 3.4.x kernels worked.
Gabor, does the patch in that mail fix your issue with the WD drive?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Heinz and Frantisek,
I believe your issue should be fixed by this patch:
http://marc.info/?l=linux-usbm=137476546506888w=2
Please let me know if it doesn't.
Sarah Sharp
On Sat, May 11, 2013 at 04:09:25PM +0200, Heinz Diehl wrote:
On 11.05.2013, Frantisek Hrbata wrote:
I haven't tried
: drivers/usb/host/xhci-trace.h:47:
+#define TRACE_INCLUDE_FILE xhci-trace
total: 3 errors, 0 warnings, 169 lines checked
The macros have to be defined that way for trace events to work.
Can you fix checkpatch not to complain about trace event macros?
Thanks,
Sarah Sharp
--
To unsubscribe from
On Mon, Jul 29, 2013 at 01:02:44PM -0700, Joe Perches wrote:
On Mon, 2013-07-29 at 12:52 -0700, Sarah Sharp wrote:
Hi Andy and Joe,
Hi Sarah.
Checkpatch is complaining when code adds new trace events macros:
sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply
been well-tested?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Dmitry,
This patch looks fine, and applies ok. I'll send it off to Greg with a
couple more bug fixes shortly.
Sarah Sharp
On Tue, Aug 27, 2013 at 05:52:33PM +0300, Dmitry Kasatkin wrote:
Used vim = as Sarah suggested.
- Dmitry
On Tue, Aug 27, 2013 at 5:47 PM, Dmitry Kasatkin d.kasat
cloned it) and will
send again.
Yeah, this doesn't apply against Greg's usb-next tree, so I can't take
it. If you're sending non-bug fixes in, you need to base your patches
against that tree, or linux-next.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
Please trim your replies.
On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote:
That change seems to cause the problems:
commit 0730d52a86919300a39a2be37f6c140997dfb82f
xhci:prevent callbacks suppressed when debug is not enabled
- Sedat -
[1]
On Wed, Aug 28, 2013 at 10:45:48PM +0530, Kumar Gaurav wrote:
On Wednesday 28 August 2013 10:31 PM, Sarah Sharp wrote:
On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote:
On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote:
On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav
On Wed, Aug 28, 2013 at 10:18:24AM -0700, Greg Kroah-Hartman wrote:
On Wed, Aug 28, 2013 at 09:59:38AM -0700, Sarah Sharp wrote:
Please trim your replies.
On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote:
That change seems to cause the problems:
commit
through checkpatch.pl.
Sarah Sharp
On Tue, Aug 27, 2013 at 05:47:34PM +0300, Dmitry Kasatkin wrote:
When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data
structures even when CONFIG_DYNAMIC_DEBUG is not defined.
It leads to build break.
For example, when I try to use
Any objections to queuing this patch through Greg's usb-next tree? I've
already sent the 2/2 patch, which will cause build breakage without this
patch.
Changes since v2:
- Fixed a checkpatch warning caused by a comment in a macro.
Sarah Sharp
8
Hi Kumar,
This patch is much better, but it still needs a few improvements. :)
Please make sure there's a space between xHCI: and the rest of your
subject line. Also, when you revise a patch, you typically want to
change the subject line to have a version. So in this case, your
subject line
Hi Julius,
Thanks for the patch! Did you test with a USB analyzer to see if the
device was actually going into USB 2.0 Link PM? I'd like to confirm we
really aren't breaking anything for DW3 hosts by enabling this.
Sarah Sharp
On Tue, Aug 20, 2013 at 04:21:49PM -0700, Julius Werner wrote
mess for documentation on USB 2.0
Link PM.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wed, Aug 14, 2013 at 10:04:10AM -0700, Greg KH wrote:
On Wed, Aug 14, 2013 at 09:51:54AM -0700, Joe Perches wrote:
On Wed, 2013-08-14 at 09:40 -0700, Sarah Sharp wrote:
Hi Xenia,
I'm a bit confused. I thought that debugging messages would be turned
off by default for a module
, let me know if it's ok
or not.
It doesn't conflict with the trace debug patches, because those only
effect debugging with xhci_dbg with the host device, not dev_dbg with
the USB device. This should apply fine to usb-next.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe
On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote:
On Thu, Aug 15, 2013 at 05:17:16PM -0700, Greg KH wrote:
On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote:
When debug is not enabled and dev_dbg() will expand to nothing,
log might be flooded with callbacks
On Fri, Aug 16, 2013 at 10:30:35AM -0700, Greg KH wrote:
On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote:
On Thu, Aug 15, 2013 at 05:17:16PM -0700, Greg KH wrote:
On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote:
When debug is not enabled and dev_dbg
On Fri, Aug 16, 2013 at 10:45:16AM -0700, Greg KH wrote:
On Fri, Aug 16, 2013 at 08:38:12PM +0300, Dmitry Kasatkin wrote:
On Fri, Aug 16, 2013 at 8:30 PM, Sarah Sharp sarah.a.sh...@intel.com
wrote:
On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote:
On Thu, Aug 15, 2013 at 05
is called if MSI is
disabled and legacy PCI interrupts are used.
I'm trying to figure out whether to put the calls to local_irq_save()
and local_irq_restore() in xhci_msi_irq() or xhci_irq().
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
, just try yelling at me about this. I'll roar
right back, louder, for all the people who lose their voice when they
get yelled at by top maintainers. I won't be the nice girl anymore.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
On Mon, Jul 15, 2013 at 10:08:13AM -0700, Linus Torvalds wrote:
On Mon, Jul 15, 2013 at 8:52 AM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
I'll roar
right back, louder, for all the people who lose their voice when
On Mon, Jul 15, 2013 at 10:50:52AM -0700, Linus Torvalds wrote:
On Mon, Jul 15, 2013 at 10:46 AM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
But, but, the light side has brownies. Pot brownies that will make
everyone feel sleepy and peaceful and possibly hungry. For more pot
On Mon, Jul 15, 2013 at 11:17:06AM -0700, Linus Torvalds wrote:
On Mon, Jul 15, 2013 at 11:04 AM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
However, I am serious about this. Linus, you're one of the worst
offenders when it comes to verbally abusing people and publicly tearing
On Mon, Jul 15, 2013 at 12:07:56PM -0700, Linus Torvalds wrote:
On Mon, Jul 15, 2013 at 11:46 AM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
Bullshit. I've seen you be polite, and explain to clueless maintainers
why there's no way you can revert their merge that caused regressions
On Mon, Jul 15, 2013 at 12:53:16PM -0700, Sarah Sharp wrote:
Good lord. So anyone that is one of your top maintainers could be
exposed to your verbal abuse just because they should have known
better?
You know what the definition of an abuser is? Someone that seeks out
victims
On Mon, Jul 15, 2013 at 06:08:29PM -0400, Steven Rostedt wrote:
On Mon, 2013-07-15 at 14:50 -0700, Linus Torvalds wrote:
On Mon, Jul 15, 2013 at 1:41 PM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
Oh, FFS, I just called out on private email for playing the victim
card. I
serious, although we might want
to limit the size of the fruit to smaller berries ;)
Sarah will bring the brownies.
Peace pot brownies! I love it!
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
and over,
expecting the result to be different. Linus keeps repeating the same
mantras over and over to maintainers that forget rules like, No
regressions.
Why aren't we trying different tactics? Why aren't we improving our
documentation so maintainers don't have to repeat themselves?
Sarah
On Tue, Jul 16, 2013 at 11:14:51AM +0200, Olivier Galibert wrote:
On Tue, Jul 16, 2013 at 9:32 AM, David Lang da...@lang.hm wrote:
On Mon, 15 Jul 2013, Sarah Sharp wrote:
The people who want to work together in a civil manner should get
together and create a Kernel maintainer's code
On Wed, Jul 17, 2013 at 12:18:21AM +0200, Willy Tarreau wrote:
On Tue, Jul 16, 2013 at 02:12:35PM -0700, Sarah Sharp wrote:
I *hate* both direct personal insults and indirect personal insults.
Neither should be acceptable in our community.
As I stated in an email to Rusty, what I'm
On Tue, Jul 16, 2013 at 05:27:04PM -0400, Theodore Ts'o wrote:
On Tue, Jul 16, 2013 at 02:12:35PM -0700, Sarah Sharp wrote:
Your code is crap is considered unprofessional, while
Let's leverage my fifth grade nephew's capabilities to assist you in
fixing the code is perfectly professional
On Tue, Jul 16, 2013 at 06:54:59PM -0400, Steven Rostedt wrote:
On Tue, 2013-07-16 at 15:43 -0700, Sarah Sharp wrote:
Yes, that's true. Some kernel developers are better at moderating their
comments and tone towards individuals who are sensitive. Others
simply don't give a shit. So we
On Tue, Jul 16, 2013 at 04:46:33PM -0700, Casey Schaufler wrote:
On 7/16/2013 3:39 PM, Sarah Sharp wrote:
On Wed, Jul 17, 2013 at 12:18:21AM +0200, Willy Tarreau wrote:
On Tue, Jul 16, 2013 at 02:12:35PM -0700, Sarah Sharp wrote:
I *hate* both direct personal insults and indirect personal
credit before the maintainer.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
1 - 100 of 418 matches
Mail list logo
