RE: [PATCH 11/34] benet: Use pci_enable_msix_range()

to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by: Alexander Gordeev agord...@redhat.com Acked-by: Sathya Perla sathya.pe...@emulex.com --- drivers/net/ethernet/emulex/benet/be_main.c | 31 +++--- 1 files changed, 13

RE: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet

-Original Message- From: Li, Zhen-Hua [mailto:zhen-h...@hp.com] In benet driver, netif_device_detach and netif_device_attach should be called between rtnl_lock and rtnl_unlock. Zhen, it's not clear to me why rtnl_lock is needed around netif_device_attach(). Can you pls explain what

RE: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet

-Original Message- From: Li, ZhenHua [mailto:zhen-h...@hp.com] Because netif_running() is called in netif_device_detach and netif_device_attach. To avoid dev status changed while netif_device_detach/attach is not finished, I think a rtnl_lock and unlock should be called to avoid

RE: be2net crash on next-20140730 (Driver probe function unexpectedly returned 1966082)

-Original Message- From: Eduardo Habkost [mailto:ehabk...@redhat.com] Hi, When running next-20140730 form linux-next, I get the following on dmesg: be2net :02:00.0: PCIe error reporting enabled be2net :02:00.0: adapter not in advanced mode be2net :02:00.0: Emulex

RE: [PATCHv2 net 2/4] be2net: Implement ndo_gso_check()

-Original Message- From: Joe Stringer [mailto:joestrin...@nicira.com] Use vxlan_gso_check() to advertise offload support for this NIC. Signed-off-by: Joe Stringer joestrin...@nicira.com Acked-by: Sathya Perla spe...@emulex.com Thanks! --- v2: Refactor out vxlan helper

sparse warning about endianness mismatch on 0xffff assignment

Hi, The following code causes a sparse warning about incorrect type in assignment (different base types) __le16 var = 0x; What would be the best way of fixing this warning? a) __le16 var = cpu_to_le16(0x); b) __le16 var = (__force __le16) 0x; c) Ignore the warning and/or fix the

Re: [PATCH] benet:Make the function be_get_sriov_config have a return type of void

this particular function has failed and the error is unrecoverable from. Signed-off-by: Nicholas Krause xerofo...@gmail.com Hi, you should have prefixed the subject line with net-next as this is a cleanup fix and so must go to the net-next tree. Thanks! Acked-by: Sathya Perla sathya.pe

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

On Thu, Jul 27, 2017 at 1:18 PM, Arnd Bergmann wrote: [...] > > On today's linux-next: > > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_register': > bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc' > bnxt_vfr.c:(.text+0x14c0): undefined

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

On Wed, Jul 26, 2017 at 2:35 PM, Arnd Bergmann wrote: [...] >> Sathya already sent 3 patches to fix some of these issues. But I need >> to rework one of his patch and resend. > > Ok, thanks. I just ran into one more issue, and don't know if that's included > as well. If not,

RE: [PATCH 11/34] benet: Use pci_enable_msix_range()

hese two interfaces need to be updated to use the > new pci_enable_msi_range() and pci_enable_msix_range() > interfaces. > > Signed-off-by: Alexander Gordeev Acked-by: Sathya Perla < sathya.pe...@emulex.com> > --- > drivers/net/ethernet/emulex/benet/be_main.c | 31 +

RE: be2net crash on next-20140730 ("Driver probe function unexpectedly returned 1966082")

> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > > Hi, > > When running next-20140730 form linux-next, I get the following on dmesg: > > be2net :02:00.0: PCIe error reporting enabled > be2net :02:00.0: adapter not in advanced mode > be2net

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

On Wed, Jul 26, 2017 at 2:35 PM, Arnd Bergmann wrote: [...] >> Sathya already sent 3 patches to fix some of these issues. But I need >> to rework one of his patch and resend. > > Ok, thanks. I just ran into one more issue, and don't know if that's included > as well. If not, please also add the

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

On Thu, Jul 27, 2017 at 1:18 PM, Arnd Bergmann wrote: [...] > > On today's linux-next: > > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_register': > bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc' > bnxt_vfr.c:(.text+0x14c0): undefined reference to

RE: [PATCHv2 net 2/4] be2net: Implement ndo_gso_check()

> -Original Message- > From: Joe Stringer [mailto:joestrin...@nicira.com] > > Use vxlan_gso_check() to advertise offload support for this NIC. > > Signed-off-by: Joe Stringer Acked-by: Sathya Perla Thanks! > --- > v2: Refactor out vxlan helper. > --- >

Re: [PATCH] benet:Make the function be_get_sriov_config have a return type of void

s particular function has failed > and the error is unrecoverable from. > > Signed-off-by: Nicholas Krause Hi, you should have prefixed the subject line with "net-next" as this is a cleanup fix and so must go to the net-next tree. Thanks! Acked-by: Sathya Perla -- To unsubscrib

sparse warning about endianness mismatch on 0xffff assignment

Hi, The following code causes a sparse warning about " incorrect type in assignment (different base types)" __le16 var = 0x; What would be the best way of fixing this warning? a) __le16 var = cpu_to_le16(0x); b) __le16 var = (__force __le16) 0x; c) Ignore the warning and/or fix

RE: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet

> -Original Message- > From: Li, Zhen-Hua [mailto:zhen-h...@hp.com] > > In benet driver, netif_device_detach and netif_device_attach should be > called between rtnl_lock and rtnl_unlock. Zhen, it's not clear to me why rtnl_lock is needed around netif_device_attach(). Can you pls explain

RE: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet

> -Original Message- > From: Li, ZhenHua [mailto:zhen-h...@hp.com] > > Because netif_running() is called in netif_device_detach and > netif_device_attach. To avoid dev status changed while > netif_device_detach/attach is not finished, I think a rtnl_lock and > unlock should be called to