Re: [BUG 2.6.21-rc2] divide error: 0000

On Fri, Mar 02, 2007 at 10:19:17AM +0100, Thomas Gleixner wrote: On Fri, 2007-03-02 at 07:11 +0100, Willy Tarreau wrote: Call Trace: [c0127d49] posix_cpu_clock_get+0x47/0xdc [c0125bf3] sys_clock_gettime+0x80/0x82 [c0103bfc] syscall_call+0x7/0xb [c02f] svc_ioctl+0xc2/0x261

[PATCH] Revert tty/8250_pnp: serial port detection regression since v3.7

://bugzilla.redhat.com/show_bug.cgi?id=928246 Signed-off-by: Sean Young s...@mess.org Cc: stable sta...@kernel.org --- drivers/tty/serial/8250/8250_pnp.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pnp.c b/drivers/tty/serial/8250

Re: [PATCH 2/5] MEDIA: ttusbir, fix double free

to NULL resulting in rc_free_device being a noop. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Sean Young s...@mess.org Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: linux-me...@vger.kernel.org --- drivers/media/rc/ttusbir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: Stable kernel 3.8.4/3.9-rc3 breaks PNP serial port

On Tue, Apr 02, 2013 at 09:23:36AM -0700, Greg Kroah-Hartman wrote: On Tue, Apr 02, 2013 at 11:53:44AM -0400, Josh Boyer wrote: Hi All, We've had a report [1] that the 3.8.4 stable kernel makes a PNP serial port stop working. After testing 3.8.3, the reporter narrowed it down to

Re: Stable kernel 3.8.4/3.9-rc3 breaks PNP serial port

On Tue, Apr 02, 2013 at 05:34:35PM +0100, Sean Young wrote: On Tue, Apr 02, 2013 at 09:23:36AM -0700, Greg Kroah-Hartman wrote: On Tue, Apr 02, 2013 at 11:53:44AM -0400, Josh Boyer wrote: Hi All, We've had a report [1] that the 3.8.4 stable kernel makes a PNP serial port stop

Re: 8250.nr_uarts broken in 3.7

On Sat, Mar 09, 2013 at 03:14:18PM +0100, Jiri Slaby wrote: This is so disgusting that I will do the following: * ack your patch after you change the above (if that works) * rename 8250.c to 8250_core.c * change 8250_core.ko back to 8250.ko (ie. bring back the old module name) * thus switch

Re: [PATCH] tty/8250_pnp: serial port detection regression since v3.7

Greg, On Fri, Feb 22, 2013 at 04:27:19PM +, Sean Young wrote: The InsydeH2O BIOS (version dated 09/12/2011) has the following in its pnp resouces for its serial ports: $ cat /sys/bus/pnp/devices/00:0b/resources state = active io disabled irq disabled We do not check

Re: [ 061/128] 8250: blacklist Winbond CIR port

On Sun, Feb 03, 2013 at 03:47:45PM +0100, Ben Hutchings wrote: 3.2-stable review patch. If anyone has any objections, please let me know. -- From: Sean Young s...@mess.org commit 65ecc9c02dbad033a73a32916d17c107c5b25031 upstream. The legacy serial driver will detect

[PATCH] tty/8250_pnp: serial port detection regression since v3.7

(8250_pnp: do pnp probe before legacy probe) we get a bogus ttyS0, which prevents the legacy probe from detecting it. Reported-by: Vincent Deffontaines vinc...@gryzor.com Tested-by: Vincent Deffontaines vinc...@gryzor.com Signed-off-by: Sean Young s...@mess.org Cc: sta...@vger.kernel.org

[LOCKDEP] Possible recursive locking detected

.config: http://www.msxnet.org/config-2.6.20-rc5 = [ INFO: possible recursive locking detected ] 2.6.20-rc5 #1 - swapper/0 is trying to acquire lock: (q-lock){++..}, at: [c0114dc0] __wake_up+0x18/0x43 but

[PATCH][STABLE 2.6.19] Fix oops in PhidgetServo

From: Sean Young [EMAIL PROTECTED] The PhidgetServo causes an Oops when any of its sysfs attributes are read or written too, making the driver useless. Signed-off-by: Sean Young [EMAIL PROTECTED] --- Please consider this for inclusion in the next -stable, this issue is affecting users

Re: [RFC PATCH] [media] rc: filter out not allowed protocols when decoding

On Sat, Sep 01, 2012 at 09:57:09AM +0800, Du, Changbin wrote: From: Du, Changbin changbin...@gmail.com Each rc-raw device has a property allowed_protos stored in structure ir_raw_event_ctrl. But it didn't work because all decoders would be called when decoding. This path makes only allowed

Re: [RFC PATCH] [media] rc: filter out not allowed protocols when decoding

On Tue, Sep 04, 2012 at 11:06:07AM +0800, Changbin Du wrote: mutex_lock(ir_raw_handler_lock); - list_for_each_entry(handler, ir_raw_handler_list, list) - handler-decode(raw-dev, ev); + list_for_each_entry(handler,

Re: [PATCH RFC] media: lirc: Allow lirc dev to talk to rc device

On Fri, Jul 12, 2013 at 09:55:28AM +0100, Srinivas KANDAGATLA wrote: From: Srinivas Kandagatla srinivas.kandaga...@st.com The use case is simple, if any rc device has allowed protocols = RC_TYPE_LIRC and map_name = RC_MAP_LIRC set, the driver open will be never called. The reason for this

Re: [PATCH v1 1/2] media: rc: Add user count to rc dev.

On Fri, Jul 19, 2013 at 09:39:27AM +0100, Srinivas KANDAGATLA wrote: From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch adds user count to rc_dev structure, the reason to add this new member is to allow other code like lirc to open rc device directly. In the existing code, rc

Re: [PATCH] [media] mceusb: fix usbdev leak

On Tue, Sep 09, 2014 at 02:10:43AM +0400, Alexey Khoroshilov wrote: mceusb_init_rc_dev() does usb_get_dev(), but there is no any usb_put_dev() in the driver. drivers/media/rc/imon.c suffers from the same problem. Thanks Sean -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 2/3] media: rc: add driver for Amlogic Meson IR remote receiver

On Sun, Nov 09, 2014 at 09:32:07AM +0100, Beniamino Galvani wrote: Amlogic Meson SoCs include a infrared remote control receiver that can operate in two modes: NEC mode in which the hardware decodes frames using the NEC IR protocol, and general mode in which the receiver simply reports the

Re: [PATCH] rc: correctly handling failed allocation

On Mon, Feb 15, 2016 at 09:33:11PM -0500, Insu Yun wrote: > Since rc_allocate_device() uses kmalloc, > it can returns NULL, so need to check, > otherwise, NULL derefenrece can be happened. Thanks for catching that. > Signed-off-by: Insu Yun > --- >

Re: [RFC 5/7] [media] ir-lirc-codec: do not handle any buffer for raw transmitters

Hi Andi, On Thu, Jul 21, 2016 at 09:48:12AM +0900, Andi Shyti wrote: > > > Raw transmitters receive the data which need to be sent to > > > receivers from userspace as stream of bits, they don't require > > > any handling from the lirc framework. > > > > No drivers of type RC_DRIVER_IR_RAW_TX

Re: [RFC 7/7] [media] rc: add support for IR LEDs driven through SPI

Hi Andi, On Thu, Jul 21, 2016 at 10:09:26AM +0900, Andi Shyti wrote: > > > + ret = regulator_enable(idata->regulator); > > > + if (ret) > > > + return ret; > > > + > > > + mutex_lock(>mutex); > > > + idata->xfer.len = n; > > > + idata->xfer.tx_buf = buffer; > > > + mutex_unlock(>mutex); >

Re: [RFC 7/7] [media] rc: add support for IR LEDs driven through SPI

On Wed, Jul 20, 2016 at 12:56:58AM +0900, Andi Shyti wrote: > The ir-spi is a simple device driver which supports the > connection between an IR LED and the MOSI line of an SPI device. > > The driver, indeed, uses the SPI framework to stream the raw data > provided by userspace through a

Re: [RFC 1/7] [media] rc-main: assign driver type during allocation

ere lots of issues that checkpatch.pl would pick in these series. > > Suggested-by: Sean Young <s...@mess.org> > Signed-off-by: Andi Shyti <andi.sh...@samsung.com> > --- > drivers/media/rc/rc-main.c | 4 +++- > include/media/rc-core.h| 2 +- > 2 files changed, 4 inse

Re: [RFC 3/7] [media] rc-core: add support for IR raw transmitters

ce applications, therefore they > don't need any input device allocation, but still they need to be > registered as raw devices. > > Suggested-by: Sean Young <s...@mess.org> > Signed-off-by: Andi Shyti <andi.sh...@samsung.com> > --- > drivers/media/rc/rc-main.c | 35

Re: [RFC 5/7] [media] ir-lirc-codec: do not handle any buffer for raw transmitters

On Wed, Jul 20, 2016 at 12:56:56AM +0900, Andi Shyti wrote: > Raw transmitters receive the data which need to be sent to > receivers from userspace as stream of bits, they don't require > any handling from the lirc framework. No drivers of type RC_DRIVER_IR_RAW_TX should handle tx just like any

Re: [PATCH] media: rc: nuvoton: decrease size of raw event fifo

On Tue, Jul 05, 2016 at 07:48:34PM +0200, Heiner Kallweit wrote: > Am 05.07.2016 um 11:17 schrieb Sean Young: > > On Tue, Jul 05, 2016 at 08:05:16AM +0200, Heiner Kallweit wrote: > >> Am 04.07.2016 um 23:06 schrieb Sean Young: > >>> On Mon, Jul 04, 2016 at 10:51:50P

Re: [PATCH v2 15/15] [media] include: lirc: add LIRC_GET_LENGTH command

On Fri, Jul 01, 2016 at 05:01:38PM +0900, Andi Shyti wrote: > Added the get length command to allow userspace users to check on > the data length. So what does LIRC_GET_LENGTH do? If you want to add an ioctl, it need justification, documenting in

Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected with SPI

On Fri, Jul 01, 2016 at 05:33:42PM +0900, Andi Shyti wrote: > The ir-spi is a simple device driver which supports the > connection between an IR LED and the MOSI line of an SPI device. > > The driver, indeed, uses the SPI framework to stream the raw data > provided by userspace through a

Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected with SPI

On Fri, Jul 01, 2016 at 09:30:35PM +0900, Andi Shyti wrote: > Hi Sean, > > > > The ir-spi is a simple device driver which supports the > > > connection between an IR LED and the MOSI line of an SPI device. > > > > > > The driver, indeed, uses the SPI framework to stream the raw data > > >

Re: [PATCH 15/15] include: lirc: add set length and frequency ioctl options

On Wed, Jun 29, 2016 at 10:20:44PM +0900, Andi Shyti wrote: > The Lirc framework works mainly with receivers, but there is > nothing that prevents us from using it for transmitters as well. The lirc interface already provides for transmitting IR. > For that we need to have more control on the

Re: [PATCH v2 02/15] [media] lirc_dev: allow bufferless driver registration

On Fri, Jul 01, 2016 at 05:01:25PM +0900, Andi Shyti wrote: > Some drivers don't necessarily need to have a FIFO managed buffer > for their transfers. Drivers now should call > lirc_register_bufferless_driver in order to handle the buffer > themselves. > > The function works exaclty like

Re: [PATCH RESEND] staging: media: lirc: use new parport device model

On Sat, Jan 21, 2017 at 12:55:54AM +, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Modify lirc_parallel driver to use the new parallel port device model. > > Signed-off-by: Sudip Mukherjee > --- > > Resending after

Re: [PATCH] Staging: media: lirc: style fix, using octal file permissions

On Sat, Jan 07, 2017 at 04:02:55PM +1300, Derek Robson wrote: > Change file permissions to octal style. > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/media/lirc/lirc_imon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [WARNING: A/V UNSCANNABLE][Merge tag 'media/v4.11-1' of git] ff58d005cd: BUG: unable to handle kernel NULL pointer dereference at 0000039c

On Fri, Feb 24, 2017 at 11:15:51AM -0800, Linus Torvalds wrote: > Added more relevant people. I've debugged the immediate problem below, > but I think there's another problem that actually triggered this. > > On Fri, Feb 24, 2017 at 10:28 AM, kernel test robot > wrote: >

[PATCH] [media] serial_ir: ensure we're ready to receive interrupts

: <sta...@vger.kernel.org> # 4.10 Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/rc/serial_ir.c | 243 +-- 1 file changed, 118 insertions(+), 125 deletions(-) diff --git a/drivers/media/rc/serial_ir.c b/drivers/media/rc/serial_ir.c i

Re: [PATCH 1/5] [media] ir-rx51: port to rc-core

Hi Ivo, On Fri, Dec 30, 2016 at 03:50:42PM +0200, Ivaylo Dimitrov wrote: > On 30.12.2016 15:30, Sean Young wrote: > > > >On Fri, Dec 30, 2016 at 01:07:52PM +0000, Sean Young wrote: > >>Hi Ivo,, > >> > >>On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivayl

Re: [PATCH v2 3/7] [media] rc-core: add support for IR raw transmitters

ce applications, therefore they > don't need any input device allocation, but still they need to be > registered as raw devices. > > Suggested-by: Sean Young <s...@mess.org> > Signed-off-by: Andi Shyti <andi.sh...@samsung.com> > --- > drivers/media/rc/rc-main.c | 39 ++

Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

Thanks Andi, this is looking great! On Fri, Sep 02, 2016 at 02:16:29AM +0900, Andi Shyti wrote: > The ir-spi is a simple device driver which supports the > connection between an IR LED and the MOSI line of an SPI device. > > The driver, indeed, uses the SPI framework to stream the raw data >

Re: [PATCH v2 1/7] [media] rc-main: assign driver type during allocation

be > set as RC_DRIVER_SCANCODE which was the default '0' value. > > Suggested-by: Sean Young <s...@mess.org> > Signed-off-by: Andi Shyti <andi.sh...@samsung.com> > --- ... > diff --git a/drivers/media/pci/cx88/cx88-input.c > b/drivers/media/pci/cx88/cx88-input.c

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

On Fri, Sep 02, 2016 at 02:16:27AM +0900, Andi Shyti wrote: > Transmitters do not need to wait until the data has been sent > (and of course received). Return before waiting. > > Signed-off-by: Andi Shyti > --- > drivers/media/rc/ir-lirc-codec.c | 2 +- > 1 file changed,

Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

On Fri, Sep 02, 2016 at 02:27:08PM +0900, Andi Shyti wrote: > > Thanks Andi, this is looking great! > > Thanks Sean! With your reviews the whole thing looks much better > now :) > > I agree with all your points here, I will fix them. Can I add > your reviewd-by? Yes, please add it to this

Re: console issue since 3.6, console=ttyS1 hangs

On Mon, Oct 24, 2016 at 04:49:25PM -0500, Nathan Zimmer wrote: > [0.974874] system 00:03: Plug and Play ACPI device, IDs PNP0c02 (active) > [0.975038] pnp 00:04: parse resource options > [0.975048] pnp 00:04: dependent set 0 (acceptable) io min 0x2f8 max > 0x2f8 align 1 size 8

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

On Thu, Oct 27, 2016 at 04:44:01PM +0900, Andi Shyti wrote: > Hi Sean, > > it's been a while :) > > I was going through your review fixing what needs to be fixed, > but... > > > > @@ -153,7 +153,7 @@ static ssize_t ir_lirc_transmit_ir(struct file *file, > > > const char __user *buf, > > > }

Re: console issue since 3.6, console=ttyS1 hangs

On Wed, Oct 26, 2016 at 01:16:16PM -0500, Nathan Zimmer wrote: > On 10/25/2016 03:41 PM, Sean Young wrote: > >On Mon, Oct 24, 2016 at 04:49:25PM -0500, Nathan Zimmer wrote: > >>[1.565062] serial8250: ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A > >The isa probe dri

Re: console issue since 3.6, console=ttyS1 hangs

On Fri, Oct 28, 2016 at 02:42:25PM -0500, Nathan Zimmer wrote: > On Thu, Oct 27, 2016 at 09:19:16PM +0100, Sean Young wrote: > > On Wed, Oct 26, 2016 at 01:16:16PM -0500, Nathan Zimmer wrote: > > > On 10/25/2016 03:41 PM, Sean Young wrote: > > > >On Mon, Oct 24, 20

Re: [PATCH] media: fix uninitialized variable warning in dib0700_rc_urb_completion()

On Mon, Nov 07, 2016 at 08:41:12AM -0700, Shuah Khan wrote: > Fix the following uninitialized variable compiler warning: > > drivers/media/usb/dvb-usb/dib0700_core.c: In function > ‘dib0700_rc_urb_completion’: > drivers/media/usb/dvb-usb/dib0700_core.c:763:2: warning: ‘protocol’ may be > used

Re: console issue since 3.6, console=ttyS1 hangs

On Tue, Oct 18, 2016 at 11:40:04AM -0500, Nathan Zimmer wrote: > 3.7.0 > cat /sys/bus/pnp/drivers/serial/*/resources > state = active > io 0x2f8-0x2ff > irq 12 > dma disabled > > 3.6.0 > :~ # cat /sys/bus/pnp/drivers/serial/*/resources > cat: /sys/bus/pnp/drivers/serial/*/resources: No such file

Re: console issue since 3.6, console=ttyS1 hangs

On Fri, Oct 21, 2016 at 10:55:40AM -0500, Nathan Zimmer wrote: > It didn't seem to make a difference as far as output. > Did I miss a config option? or something else? > > [0.00] Linux version 3.6.0 (root@r1i2n0) (gcc version 4.3.4 > [gcc-4_3-branch revision 152973] (SUSE Linux) ) #3 SMP

Re: console issue since 3.6, console=ttyS1 hangs

On Wed, Oct 19, 2016 at 05:13:41PM -0500, Nathan Zimmer wrote: > On 10/19/2016 04:07 AM, Sean Young wrote: > >So with 3.6.0: > > > >>[2.079980] Serial: 8250/16550 driver, 8 ports, IRQ sharing disabled > >>[2.100887] serial8250: ttyS1 at I/O 0x2f8 (irq =

Re: console issue since 3.6, console=ttyS1 hangs

On Tue, Oct 18, 2016 at 02:29:30PM -0500, Nathan Zimmer wrote: > On Tue, Oct 18, 2016 at 07:05:18PM +0100, Sean Young wrote: > > On Tue, Oct 18, 2016 at 11:40:04AM -0500, Nathan Zimmer wrote: > > > 3.7.0 > > > cat /sys/bus/pnp/drivers/serial/*/resources > > >

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

Hi Andi, On Tue, Nov 01, 2016 at 03:51:11PM +0900, Andi Shyti wrote: > > Andi, it would be good to know what the use-case for the original change is. > > the use case is the ir-spi itself which doesn't need the lirc to > perform any waiting on its behalf. Here is the crux of the problem: in

Re: console issue since 3.6, console=ttyS1 hangs

On Sun, Oct 30, 2016 at 10:33:02AM -0500, Nathan wrote: > I think this should be PNP0501 instead of PNP0c02. > Once I alter that then when I boot the serial comes up on irq 3. However it > still hangs. > I'll keep digging. Well that's that theory out of the window. I'm not sure where to look now,

Re: [PATCH v3 0/6] Add support for IR transmitters

s currently ongoing. Looks great! For the whole series: Reviewed-by: Sean Young <s...@mess.org> Thanks, Sean

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

Hi David, Andi, On Mon, Oct 31, 2016 at 02:31:52PM +, David Härdeman wrote: > October 27, 2016 4:36 PM, "Sean Young" <s...@mess.org> wrote: > > Since we have to be able to switch between waiting and not waiting, > > we need some sort of ABI for this. I think thi

Re: [PATCH] [media] dib0700: fix nec repeat handling

On Sat, Oct 29, 2016 at 11:04:32PM +0200, Arnd Bergmann wrote: > On Thursday, October 13, 2016 10:28:44 PM CEST Sean Young wrote: > > When receiving a nec repeat, ensure the correct scancode is repeated > > rather than a random value from the stack. This removes the need &g

Re: [PATCH] [media] rc: Fix uninitialized variable in debug print

mediate "toggle" variable, like is done in > other branches. > > Fixes: 00bb820755ed8ee9 ("[media] rc: Hauppauge z8f0811 can decode RC6") > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Thanks for finding this and writing a patch. Acked-by: Sean Young &l

Re: [PATCH] [media] dib0700: Fix uninitialized protocol for NEC repeat codes

On Thu, Oct 13, 2016 at 03:51:39PM +0200, Geert Uytterhoeven wrote: > drivers/media/usb/dvb-usb/dib0700_core.c: In function > ‘dib0700_rc_urb_completion’: > drivers/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be > used uninitialized in this function > > When receiving

[PATCH] [media] dib0700: fix nec repeat handling

/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be used uninitialized in this function Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/usb/dvb-usb/dib0700_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/d

Re: [PATCH 12/18] [media] RedRat3: Move a variable assignment in redrat3_init_rc_dev()

On Thu, Oct 13, 2016 at 06:39:23PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 13 Oct 2016 14:50:05 +0200 > > Move the assignment for the local variable "prod" behind the source code > for a memory allocation by this function. The redrat3

Re: console issue since 3.6, console=ttyS1 hangs

d in here: > > commit 835d844d1a28efba81d5aca7385e24c29d3a6db2 > Author: Sean Young <s...@mess.org> > Date: Fri Sep 7 19:06:23 2012 +0100 > > 8250_pnp: do pnp probe before legacy probe > > > I found I can revert the part of the patch in 8250.c (now 8250_core.c

Re: [PATCH 04/18] [media] RedRat3: One function call less in redrat3_transmit_ir() after error detection

On Thu, Oct 13, 2016 at 06:24:46PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 13 Oct 2016 10:50:24 +0200 > > The kfree() function was called in one case by the > redrat3_transmit_ir() function during error handling > even if the passed

Re: [PATCH 4/5] [media] winbond-cir: One variable and its check less in wbcir_shutdown() after error detection

On Fri, Oct 14, 2016 at 01:44:02PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 12:48:41 +0200 > > The local variable "do_wake" was set to "false" after an invalid system > setting was detected so that a bit of error handling was

Re: [PATCH v5 2/6] [media] rc-main: split setup and unregister functions

ctions. > > Signed-off-by: Andi Shyti <andi.sh...@samsung.com> > Reviewed-by: Sean Young <s...@mess.org> > --- > drivers/media/rc/rc-main.c | 143 > + > 1 file changed, 81 insertions(+), 62 deletions(-) > > diff --git

Re: [PATCH v4 2/6] [media] rc-main: split setup and unregister functions

yti <andi.sh...@samsung.com> > Reviewed-by: Sean Young <s...@mess.org> > --- > drivers/media/rc/rc-main.c | 143 > + > 1 file changed, 81 insertions(+), 62 deletions(-) > > diff --git a/drivers/media/rc/rc-main.c b/drivers/media

Re: [PATCH v5 2/6] [media] rc-main: split setup and unregister functions

Hi Andi, On Fri, Dec 16, 2016 at 12:10:26PM +, Sean Young wrote: > Sorry to add to your woes, but there are some checkpatch warnings and > errors. Please can you correct these. One is below. Actually, the changes are pretty minor, I can fix them up before sending them to Mauro.

Re: [PATCH v2 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

Hi Sean, The driver is looking very good, we are looking at minor details now. On Tue, Jan 10, 2017 at 09:59:49PM +0800, Sean Wang wrote: > On Tue, 2017-01-10 at 11:09 +0000, Sean Young wrote: > > > > +#include > > > +#include > > > +#include > > > +

Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

Hi Sean, Some review comments. On Fri, Jan 06, 2017 at 12:06:24AM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > This patch adds driver for IR controller on > Mediatek MT7623 SoC. Currently testing successfully > on NEC and SONY remote controller only but it

Re: [PATCH 1/5] [media] ir-rx51: port to rc-core

Hi Ivo,, On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivaylo Dimitrov wrote: > On 20.12.2016 19:50, Sean Young wrote: > >This driver was written using lirc since rc-core did not support > >transmitter-only hardware at that time. Now that it does, port > >this driver. >

Re: [PATCH 1/5] [media] ir-rx51: port to rc-core

On Fri, Dec 30, 2016 at 01:07:52PM +, Sean Young wrote: > Hi Ivo,, > > On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivaylo Dimitrov wrote: > > On 20.12.2016 19:50, Sean Young wrote: > > >This driver was written using lirc since rc-core did not support > > >trans

Re: [PATCH 1/5] [media] ir-rx51: port to rc-core

Hi Ivo, On Fri, Dec 30, 2016 at 03:50:42PM +0200, Ivaylo Dimitrov wrote: > On 30.12.2016 15:30, Sean Young wrote: > >On Fri, Dec 30, 2016 at 01:07:52PM +0000, Sean Young wrote: > >Speaking of which, if you would please test this, that would be great. My > >N900 died many ye

Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

On Mon, Jan 09, 2017 at 11:13:21AM +0800, Sean Wang wrote: > I had another question. I found multiple and same IR messages being > received when using SONY remote controller. Should driver needs to > report each message or only one of these to the upper layer ? In general the driver shouldn't try

Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

Hi Sean, On Fri, Jan 06, 2017 at 03:31:25PM +0800, Sean Wang wrote: > On Thu, 2017-01-05 at 17:12 +0000, Sean Young wrote: > > On Fri, Jan 06, 2017 at 12:06:24AM +0800, sean.w...@mediatek.com wrote: > > > + /* Handle pulse and space until end of message */ > > > + for

Re: [PATCH v2 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

testing successfully on NEC and SONY remote controller > only but it should work on others (lirc, rc-5 and rc-6). > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> > Reviewed-by: Sean Young <s...@mess.org> > --- > drivers/media/rc/Kconfig | 11 ++ > drivers/me

[PATCH 0/5] Lirc staging drivers

drivers were merged in 2010, and other than trival patches, they have not made any progress towards mainline. ir-rx51 is not a staging driver, but it should not rely on the lirc in-kernel API like the staging drivers do. Sean Young (5): [media] ir-rx51: port to rc-core [media] staging: lirc_sir

[PATCH 1/5] [media] ir-rx51: port to rc-core

This driver was written using lirc since rc-core did not support transmitter-only hardware at that time. Now that it does, port this driver. Compile tested only. Signed-off-by: Sean Young <s...@mess.org> Cc: Timo Kokkonen <timo.t.kokko...@iki.fi> Cc: Ivaylo Dimitrov <ivo.g.dimitr

[PATCH 3/5] [media] staging: lirc_parallel: remove

The lirc_parallel driver was merged in 2010 and noone has attempted to do the work necessary to get it out of staging (i.e. port it to rc-core). I have not been able to find one of these devices, and a machine with a parallel port is pretty rare too. Signed-off-by: Sean Young <s...@mess.org&

[PATCH 4/5] [media] staging: lirc_bt829: remove

. Signed-off-by: Sean Young <s...@mess.org> Cc: Jarod Wilson <ja...@redhat.com> Cc: Leonid Froenchenko <lfr...@galileo.co.il> --- drivers/staging/media/lirc/Kconfig | 6 - drivers/staging/media/lirc/Makefile | 1 - drivers/staging/media/lirc/

[PATCH 2/5] [media] staging: lirc_sir: port to rc-core

Before this driver can be moved out of staging, it should be ported to rc-core. I've tried to make the minimum changes possible without upsetting checkpatch. Compile tested only. Signed-off-by: Sean Young <s...@mess.org> Cc: Jarod Wilson <ja...@redhat.com> Cc: Christoph

[PATCH 5/5] [media] staging: lirc_imon: port remaining usb ids to imon and remove

staging to mainline imon. Now that mainline imon can handle these four devices, lirc_imon is no longer needed. Compile tested only. Signed-off-by: Sean Young <s...@mess.org> Cc: Venky Raju <d...@venky.ws> Cc: Jarod Wilson <ja...@redhat.com> Cc: Alexey Khoroshilov <

Re: linux-next: manual merge of the staging tree with the v4l-dvb tree

On Thu, Apr 06, 2017 at 09:19:22PM +0200, Greg KH wrote: > On Thu, Apr 06, 2017 at 07:58:57PM +0100, Sean Young wrote: > > On Thu, Apr 06, 2017 at 01:34:20PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > Today's linux-next mer

Re: linux-next: manual merge of the staging tree with the v4l-dvb tree

On Thu, Apr 06, 2017 at 01:34:20PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the staging tree got conflicts in: > > drivers/staging/media/lirc/lirc_sasem.c > drivers/staging/media/lirc/lirc_sir.c > > between commits: > > e66267161971 ("[media] rc: promote

Re: [PATCH 4.10 084/110] [media] rx51: broken build

On Mon, Apr 10, 2017 at 06:43:15PM +0200, Greg Kroah-Hartman wrote: > 4.10-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Sean Young <s...@mess.org> > > [ Upstream commit 922ee72da7c739157ed02ea04a5c100d

Re: [PATCH v1 0/4] media: rc: add support for IR receiver on MT7622 SoC

Hi Sean, On Wed, Aug 02, 2017 at 10:24:07AM +0800, Sean Wang wrote: > Hi, Mauro and Sean > > Just a gentle ping on the whole patchset porting MediaTek CIR to another > platform. I'm creating the rc-core pull request, should be done by the end of the week. Sean

Re: [PATCH 2/3] [media] rc: constify usb_device_id

v <arvind.yadav...@gmail.com> Acked-by: Sean Young <s...@mess.org> Thanks for spotting that. Sean > --- > drivers/media/rc/ati_remote.c | 2 +- > drivers/media/rc/igorplugusb.c | 2 +- > drivers/media/rc/imon.c| 2 +- > drivers/media/rc/mceusb.c |

Re: [PATCH] imon: constify attribute_group structures

On Fri, Aug 04, 2017 at 09:51:38PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. I'm afraid the exact same patch has already been

[PATCH v4.13 REGRESSION] Revert "serial: Delete dead code for CIR serial ports"

) is a CIR port lirc lirc0: lirc_dev: driver ir-lirc-codec (winbond-cir) registered at minor = 0 winbond-cir 00:03: Region 0x2f8-0x2ff already in use! winbond-cir: probe of 00:03 failed with error -16 Signed-off-by: Sean Young <s...@mess.org> --- drivers/tty/serial/8250/8250_core.

[PATCH] [media] sir_ir: infinite loop in interrupt handler

Since this driver does no detection of hardware, it might be used with a non-sir port. Escape out if we are spinning. Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/rc/sir_ir.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/rc/sir_ir.c b/drivers/me

Re: [[media] rc] e662671619: BUG: kernel hang in test stage

756b4e17f2f2f82b9f842 > Author: Sean Young <s...@mess.org> > AuthorDate: Tue Mar 7 17:07:59 2017 -0300 > Commit: Mauro Carvalho Chehab <mche...@s-opensource.com> > CommitDate: Wed Apr 5 14:50:57 2017 -0300 > > [media] rc: promote lirc_sir out of staging &g

[PATCH v3 26/26] kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit

returns EINVAL. So, ensure that __is_kfifo_ptr() compares to the right structure. Signed-off-by: Sean Young <s...@mess.org> Acked-by: Stefani Seibold <stef...@seibold.net> --- include/linux/kfifo.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/lin

Re: [PATCH] media: default for RC_CORE should be n

On Fri, Sep 08, 2017 at 09:39:29AM -0700, Stephen Hemminger wrote: > The Linus policy on Kconfig is that the default should be no > for all new devices. I.e the user rebuild a new kernel from an > old config should not by default get a larger kernel. That might make sense for new config, but

[PATCH v3 26/26] kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit

returns EINVAL. So, ensure that __is_kfifo_ptr() compares to the right structure. Signed-off-by: Sean Young <s...@mess.org> --- include/linux/kfifo.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h index 41eb6f

Re: [PATCH 1/2] [media] rc/keymaps: add support for RC of hisilicon TV demo boards

On Wed, Oct 18, 2017 at 06:54:56AM -0400, Jiancheng Xue wrote: > From: Younian Wang > > This is a NEC protocol type remote controller distributed with > hisilicon TV demo boards. > > Signed-off-by: Younian Wang > Signed-off-by: Jiancheng

Re: [PATCH v4 06/12] [media] cxd2880: Add integration layer for the driver

On Fri, Oct 13, 2017 at 03:08:34PM +0900, yasunari.takigu...@sony.com wrote: > From: Yasunari Takiguchi > > These functions monitor the driver and watch for task completion. > This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. > > Signed-off-by:

Re: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Hello, Many thanks for the driver. The ./scripts/checkpatch.pl with --strict has many warnings, some of which might be nice to have cleaned up. There are some very minor comments below. Similar constructs are in other files too. After reading and understanding through all the code, I think

Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

On Sun, Dec 17, 2017 at 11:45:43PM +0100, Philipp Rossak wrote: > This patch updates the sunxi-ir driver to set the base clock frequency from > devicetree. > > This is neccessary since there are different ir recievers on the > market, that operate with different frequencys. So this value could be

Re: 4.14 regression from commit d57ea877af38 media: rc: per-protocol repeat period

On Thu, Nov 16, 2017 at 04:27:01PM +0100, Matthias Reichl wrote: > The following commit introduced a regression > > commit d57ea877af38057b0ef31758cf3b99765dc33695 > Author: Sean Young <s...@mess.org> > Date: Wed Aug 9 13:19:16 2017 -0400 > > media: rc:

Re: [PATCH] media: rc: double keypresses due to timeout expiring to early

On Fri, Nov 17, 2017 at 03:52:50PM +0100, Matthias Reichl wrote: > Hi Sean! > > On Thu, Nov 16, 2017 at 09:54:51PM +0000, Sean Young wrote: > > Since commit d57ea877af38 ("media: rc: per-protocol repeat period"), > > double keypresses are reported on the ite-

Re: [PATCH 2/6] media: rc keymaps: add SPDX identifiers to the code I wrote

On Fri, Nov 17, 2017 at 08:21:29AM -0200, Mauro Carvalho Chehab wrote: > As we're now using SPDX identifiers, on the several > RC keymap files I wrote, add the proper SPDX, identifying > the license I meant. > > As we're now using the short license, it doesn't make sense to > keep the original

[PATCH] media: rc: double keypresses due to timeout expiring to early

. So, add the IR timeout to the keyup timeout. Cc: <sta...@vger.kernel.org> # 4.14 Reported-by: Matthias Reichl <h...@horus.com> Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/rc/rc-main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH] media: ttpci: remove autorepeat handling and use timer_setup

Leave the autorepeat handling up to the input layer, and move to the new timer API. Compile tested only. Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/pci/ttpci/av7110.h| 2 +- drivers/media/pci/ttpci/av7110_ir.c | 54 ++--- 2 files chang

Re: [PATCH] media: av7110: switch to useing timer_setup()

On Tue, Oct 24, 2017 at 05:40:05PM -0700, Dmitry Torokhov wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Also stop poking into input core

  1   2   3   4   >