review.
Link: https://clang.llvm.org/docs/LanguageExtensions.html#extended-integer-types
Link: https://reviews.llvm.org/D93103
Signed-off-by: Sean Young
---
Documentation/bpf/btf.rst | 4 +--
include/uapi/linux/btf.h | 2 +-
kernel/bpf/btf.c | 54
review.
Link: https://clang.llvm.org/docs/LanguageExtensions.html#extended-integer-types
Link: https://reviews.llvm.org/D93103
Signed-off-by: Sean Young
changes since v2:
- split patches into 4 distinct patches
changes since v1:
- added tests as suggested by Yonghong Song
- added kernel
-types
Link: https://reviews.llvm.org/D93103
Signed-off-by: Sean Young
---
tools/lib/bpf/btf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c
index 3c3f2bc6c652..a676373f052b 100644
--- a/tools/lib/bpf/btf.c
+++ b/tools/lib/bpf/btf.c
On Thu, Nov 26, 2020 at 05:54:52PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> On Wed, 18 Nov 2020 16:29:34 +1100 Stephen Rothwell
> wrote:
> >
> > After merging the v4l-dvb tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > Documentation/output/lirc.h.rst:6: WARNING:
On Tue, Sep 09, 2014 at 02:10:43AM +0400, Alexey Khoroshilov wrote:
> mceusb_init_rc_dev() does usb_get_dev(), but there is no any
> usb_put_dev() in the driver.
drivers/media/rc/imon.c suffers from the same problem.
Thanks
Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-k
On Sun, Nov 09, 2014 at 09:32:07AM +0100, Beniamino Galvani wrote:
> Amlogic Meson SoCs include a infrared remote control receiver that can
> operate in two modes: "NEC" mode in which the hardware decodes frames
> using the NEC IR protocol, and "general" mode in which the receiver
> simply reports
On Mon, Feb 15, 2016 at 09:33:11PM -0500, Insu Yun wrote:
> Since rc_allocate_device() uses kmalloc,
> it can returns NULL, so need to check,
> otherwise, NULL derefenrece can be happened.
Thanks for catching that.
> Signed-off-by: Insu Yun
> ---
> drivers/media/rc/igorplugusb.c | 3 +++
> 1 f
On Tue, Aug 20, 2019 at 02:19:16PM -0400, Hui Peng wrote:
> In the while loop of technisat_usb2_get_ir, it scans through
> a fix-sized buffer read from the device side, the termination
> condition of the loop is `*b == 0xff`. If no `0xff` byte is read
> from the device side, OOB access happens.
>
On Mon, Aug 19, 2019 at 01:54:53PM +0200, Marc Gonzalez wrote:
> On 15/07/2019 11:50, Marc Gonzalez wrote:
>
> > Use cmd_init() to fill a struct si2168_cmd command.
> >
> > Signed-off-by: Marc Gonzalez
> > ---
> > Changes from v1:
> > - Use a real function to populate struct si2168_cmd *cmd, and
On Mon, Jul 22, 2019 at 10:13:56AM +0200, Marc Gonzalez wrote:
> On 21/07/2019 17:02, Ezequiel Garcia wrote:
>
> > On Thu, 2019-07-18 at 15:03 +0200, Marc Gonzalez wrote:
> >
> >> Provide devm variants for automatic resource release on device removal.
> >> Makes error-handling in probe() simpler,
On Wed, Oct 02, 2019 at 04:13:59PM +0200, Gon Solo wrote:
You need a message and a Signed-off-by: here.
> ---
> drivers/media/tuners/si2157.c | 68 +--
> drivers/media/tuners/si2157_priv.h| 1 +
> drivers/media/usb/dvb-usb-v2/af9035.c | 47 ++
On Wed, Oct 02, 2019 at 04:44:24PM +0200, Gonsolo wrote:
> Hi!
>
> > You need a message and a Signed-off-by: here.
>
> Ok, I'll try to get that right the next time.
>
> > > + ret = si2157_power_up(dev, client);
> > > + if (ret)
> > > + goto err;
> > > + /* query chip revi
Hi,
On Fri, Sep 06, 2019 at 12:14:49AM +0800, zhong jiang wrote:
> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
> but is perhaps more readable.
>
> Signed-off-by: zhong jiang
> ---
> drivers/media/dvb-frontends/mt312.c | 2 +-
> 1 file changed, 1 insertion(+), 1 del
or the series (both 1/2 and 2.2):
Reviewed-by: Sean Young
How's tree should this go through?
Thanks
Sean
>
> ---
>
> Changes from v1:
> - Update the list of valid RC map name
> ---
> .../devicetree/bindings/media/rc.txt | 118 +-
> .
On Tue, Aug 20, 2019 at 10:52:29AM -0500, Rob Herring wrote:
> On Tue, Aug 20, 2019 at 4:50 AM Maxime Ripard wrote:
> > On Tue, Aug 20, 2019 at 09:15:26AM +0100, Sean Young wrote:
> > > On Mon, Aug 19, 2019 at 08:26:18PM +0200, Maxime Ripard wrote:
> > > > From: Maxi
Hi Valentin,
Thank you for your patch.
On Tue, Oct 15, 2019 at 10:03:15PM +0200, Valentin Vidic wrote:
> Make sure ircode does not contain random values if the call to
> cxusb_ctrl_msg fails for some reason.
>
> Reported-by: syzbot+98730b985cad4931a...@syzkaller.appspotmail.com
> Signed-off-by:
Hi,
On Wed, Jan 30, 2019 at 11:32:12AM +0100, Gonsolo wrote:
> Hi!
>
> The following patch adds support for the Logilink VG0022A DVB-T2 stick.
> After patching and building the kernel it shows up with lsusb and I
> used w_scan to scan for channels and vlc for watching.
> The original patches were
On Mon, Feb 18, 2019 at 09:59:36PM +, Jonas Karlman wrote:
> This RC map is based on remote key schema at [1], the mouse button key
> did not have an obvious target and was mapped to KEY_CONTEXT_MENU.
How about BTN_LEFT ?
Thanks,
Sean
>
> [1] http://files.pine64.org/doc/Pine%20A64%20Schema
Hi Stefan,
On Fri, Apr 12, 2019 at 03:12:58AM +0200, Stefan Brüns wrote:
> actual_length != wlen is the only error path which does not generate an
> error message. Adding an error message here allows to report a more
> specific error and to remove the error reporting from the call sites.
>
> Also
au0828_usb_disconnect() gets the au0828_dev struct via usb_get_intfdata,
so it needs to set up for the error paths.
Reported-by: syzbot+357d86bcb4cca1a2f...@syzkaller.appspotmail.com
Signed-off-by: Sean Young
---
drivers/media/usb/au0828/au0828-core.c | 12 ++--
1 file changed, 6
Hi Tobias,
On Sun, May 12, 2019 at 04:53:06PM +0200, Tobias Klausmann wrote:
> Ping,
>
> comments for this patch are appreciated!
Sorry for not back to you earlier.
Please run script/checkpatch.pl --strict on your patch. There are several
cosmetic changes needed.
>
> Thanks,
>
> Tobias
>
>
On Sun, Jul 14, 2019 at 04:32:22PM +0200, Clément Péron wrote:
> Hi Sean,
>
> You acked the whole v3 series but this patch has been introduced in v5
> could you ack this one too?
Acked-by: Sean Young
Thanks
Sean
>
> Thanks,
> Clément
>
>
>
>
> On Mon,
teus-2309"
> - * "rc-purpletv"
> - * "rc-pv951"
> - * "rc-hauppauge"
> - * "rc-rc5-tv"
> - * "rc-rc6-mce"
> - * "rc-real-audio-220-32-keys"
> - * "rc-reddo"
> - * "rc-snapstream
On Wed, Jul 24, 2019 at 06:36:35AM +0100, Sean Young wrote:
> On Sat, Jul 20, 2019 at 11:43:02AM +0530, Vandana BN wrote:
> > Syzbot reported global-out-of-bounds Read in dvb_pll_attach, while
> > accessing id[dvb_pll_devcount], because dvb_pll_devcount was 65,
> > that is
On Mon, Jul 22, 2019 at 07:26:31PM +0200, Wolfram Sang wrote:
> i2c_new_dummy() can fail returning a NULL pointer. The code does not
> bail out in this case and the returned pointer is blindly used.
I don't see how. The existing code tries to set up the tx part; if
i2c_new_dummy() return NULL then
Hi Wolfram,
On Thu, Jul 25, 2019 at 09:55:38AM +0200, Wolfram Sang wrote:
> Hi Sean,
>
> thanks for the review!
>
> On Thu, Jul 25, 2019 at 06:12:02AM +0100, Sean Young wrote:
> > On Mon, Jul 22, 2019 at 07:26:31PM +0200, Wolfram Sang wrote:
> > > i2c_new_dum
On Fri, Aug 02, 2019 at 12:20:19PM +0530, Vandana BN wrote:
>
> On 01/08/19 2:31 PM, Michael Ira Krufky wrote:
> > Sean,
> >
> > Please pardon the late reply. See my responses inline below:
> >
> > On Wed, Jul 24, 2019 at 1:36 AM Sean Young wrote:
> >
On Sat, Aug 03, 2019 at 01:17:49PM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 30 Jul 2019 19:55:54 +0200
> Wolfram Sang escreveu:
>
> > Convert this driver to use the new i2c_new_dummy_device() call and bail
> > out if the dummy device cannot be registered to make failure more
> > visible to t
Hi,
On Mon, Jul 15, 2019 at 01:12:45PM +0100, Sean Young wrote:
> On Sun, Jul 14, 2019 at 04:32:22PM +0200, Clément Péron wrote:
> > Hi Sean,
> >
> > You acked the whole v3 series but this patch has been introduced in v5
> > could you ack this one too?
>
> Ack
On Sat, Jul 20, 2019 at 11:43:02AM +0530, Vandana BN wrote:
> Syzbot reported global-out-of-bounds Read in dvb_pll_attach, while
> accessing id[dvb_pll_devcount], because dvb_pll_devcount was 65,
> that is more than size of 'id' which is DVB_PLL_MAX(64).
>
> Fix would be to check if DVB_PLL_MAX de
On Tue, Jul 23, 2019 at 09:04:40AM +0200, Maxime Ripard wrote:
> Hi Sean,
>
> On Tue, Jul 23, 2019 at 07:25:57AM +0100, Sean Young wrote:
> > On Mon, Jul 15, 2019 at 01:12:45PM +0100, Sean Young wrote:
> > > On Sun, Jul 14, 2019 at 04:32:22PM +0200, Clément Péro
On Mon, Jun 17, 2019 at 01:16:53PM +0200, Arnd Bergmann wrote:
> The ttpci driver now uses the rc-core, so we need to ensure it
> is enabled:
>
> ERROR: "rc_unregister_device" [drivers/media/pci/ttpci/dvb-ttpci.ko]
> undefined!
> ERROR: "rc_allocate_device" [drivers/media/pci/ttpci/dvb-ttpci.ko]
On Sat, Jun 15, 2019 at 10:47:28AM +0300, Andrei Koshkosh wrote:
> ---
> drivers/media/usb/dvb-usb-v2/dvbsky.c | 18 ++
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
Missing signed-off-by. Please read:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Ensure we do not access the buffer beyond the end if no 0xff byte
is encountered.
Reported-by: syzbot+eaaaf38a95427be88...@syzkaller.appspotmail.com
Signed-off-by: Sean Young
---
drivers/media/usb/dvb-usb/technisat-usb2.c | 22 ++
1 file changed, 10 insertions(+), 12
On Mon, Jun 17, 2019 at 04:38:01PM +0200, Geert Uytterhoeven wrote:
> "git diff" says:
>
> \ No newline at end of file
>
> after modifying the file.
git diff says this because after patching using the diff output, files
should be byte-for-byte identifical. It does not mean there necessarily
On Fri, Dec 21, 2018 at 09:24:46AM +0100, Matthias Schwarzott wrote:
> Am 21.12.18 um 05:54 schrieb Kangjie Lu:
> > si2165_readreg8() may fail. Looking into si2165_readreg8(), we will find
> > that "val_tmp" will be an uninitialized value when regmap_read() fails.
> > "val_tmp" is then assigned to
On Tue, Dec 25, 2018 at 02:03:07AM -0600, Kangjie Lu wrote:
> write16() could fail. The fix inserts a check for its return value
> in case it fails.
>
> Signed-off-by: Kangjie Lu
Unless it is tested on the actual hardware we can't apply this. This could
introduce regressions.
Sean
> ---
> dri
On Fri, Mar 02, 2018 at 01:11:34PM +0100, Philipp Rossak wrote:
> On 13.02.2018 13:29, Philipp Rossak wrote:
> > This patch series adds support for the sunxi A83T ir module and enhances
> > the sunxi-ir driver. Right now the base clock frequency for the ir driver
> > is a hard coded define and is s
On Fri, Apr 20, 2018 at 11:47:47AM -0700, Vladislav Zhurba wrote:
> From: Jun Yan
>
> Add keymap with NEC and SONY12 protocol for NVIDIA IR
>
> Signed-off-by: Jun Yan
> Signed-off-by: marting
> Signed-off-by: Daniel Fu
> Signed-off-by: Vladislav Zhurba
> ---
> drivers/media/rc/keymaps/Makef
On Fri, Apr 20, 2018 at 11:51:39AM -0700, Vladislav Zhurba wrote:
> From: Daniel Fu
>
> Remove STATE_TRAILER_SPACE from state machine.
> Causing 2 issue:
> - can not decode the keycode, if it didn't following with
> another keycode/repeat code
> - will generate one more code in current logic.
>
Hi Sean,
Some review comments.
On Fri, Jan 06, 2017 at 12:06:24AM +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> This patch adds driver for IR controller on
> Mediatek MT7623 SoC. Currently testing successfully
> on NEC and SONY remote controller only but it should
> work on others
Hi Ivo,
On Fri, Dec 30, 2016 at 03:50:42PM +0200, Ivaylo Dimitrov wrote:
> On 30.12.2016 15:30, Sean Young wrote:
> >
> >On Fri, Dec 30, 2016 at 01:07:52PM +0000, Sean Young wrote:
> >>Hi Ivo,,
> >>
> >>On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivayl
On Sat, Jan 07, 2017 at 04:02:55PM +1300, Derek Robson wrote:
> Change file permissions to octal style.
> Found using checkpatch
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/media/lirc/lirc_imon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/stagin
On Sat, Jan 21, 2017 at 12:55:54AM +, Sudip Mukherjee wrote:
> From: Sudip Mukherjee
>
> Modify lirc_parallel driver to use the new parallel port device model.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> Resending after more than one year.
> Prevoius patch is at https://patchwork.kernel.o
Hi Sean,
On Fri, Jan 06, 2017 at 03:31:25PM +0800, Sean Wang wrote:
> On Thu, 2017-01-05 at 17:12 +0000, Sean Young wrote:
> > On Fri, Jan 06, 2017 at 12:06:24AM +0800, sean.w...@mediatek.com wrote:
> > > + /* Handle pulse and space until end of message */
> > > + for
On Mon, Jan 09, 2017 at 11:13:21AM +0800, Sean Wang wrote:
> I had another question. I found multiple and same IR messages being
> received when using SONY remote controller. Should driver needs to
> report each message or only one of these to the upper layer ?
In general the driver shouldn't try
and SONY remote controller
> only but it should work on others (lirc, rc-5 and rc-6).
>
> Signed-off-by: Sean Wang
> Reviewed-by: Sean Young
> ---
> drivers/media/rc/Kconfig | 11 ++
> drivers/media/rc/Makefile | 1 +
> drivers/media/rc/mtk-cir.c | 326
>
Hi Sean,
The driver is looking very good, we are looking at minor details now.
On Tue, Jan 10, 2017 at 09:59:49PM +0800, Sean Wang wrote:
> On Tue, 2017-01-10 at 11:09 +0000, Sean Young wrote:
>
> > > +#include
> > > +#include
> > > +#include
> > > +
On Tue, Jul 05, 2016 at 07:48:34PM +0200, Heiner Kallweit wrote:
> Am 05.07.2016 um 11:17 schrieb Sean Young:
> > On Tue, Jul 05, 2016 at 08:05:16AM +0200, Heiner Kallweit wrote:
> >> Am 04.07.2016 um 23:06 schrieb Sean Young:
> >>> On Mon, Jul 04, 2016 at 10:51:50P
On Fri, Jul 01, 2016 at 05:01:38PM +0900, Andi Shyti wrote:
> Added the get length command to allow userspace users to check on
> the data length.
So what does LIRC_GET_LENGTH do? If you want to add an ioctl, it
need justification, documenting in
Documentatoin/DocBook/media/v4l/lirc_device_interf
On Fri, Jul 01, 2016 at 05:33:42PM +0900, Andi Shyti wrote:
> The ir-spi is a simple device driver which supports the
> connection between an IR LED and the MOSI line of an SPI device.
>
> The driver, indeed, uses the SPI framework to stream the raw data
> provided by userspace through a character
On Fri, Jul 01, 2016 at 09:30:35PM +0900, Andi Shyti wrote:
> Hi Sean,
>
> > > The ir-spi is a simple device driver which supports the
> > > connection between an IR LED and the MOSI line of an SPI device.
> > >
> > > The driver, indeed, uses the SPI framework to stream the raw data
> > > provide
On Fri, Jul 01, 2016 at 05:01:25PM +0900, Andi Shyti wrote:
> Some drivers don't necessarily need to have a FIFO managed buffer
> for their transfers. Drivers now should call
> lirc_register_bufferless_driver in order to handle the buffer
> themselves.
>
> The function works exaclty like lirc_regi
On Thu, Oct 27, 2016 at 04:44:01PM +0900, Andi Shyti wrote:
> Hi Sean,
>
> it's been a while :)
>
> I was going through your review fixing what needs to be fixed,
> but...
>
> > > @@ -153,7 +153,7 @@ static ssize_t ir_lirc_transmit_ir(struct file *file,
> > > const char __user *buf,
> > > }
>
On Wed, Oct 26, 2016 at 01:16:16PM -0500, Nathan Zimmer wrote:
> On 10/25/2016 03:41 PM, Sean Young wrote:
> >On Mon, Oct 24, 2016 at 04:49:25PM -0500, Nathan Zimmer wrote:
> >>[1.565062] serial8250: ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A
> >The isa probe dri
On Fri, Oct 28, 2016 at 02:42:25PM -0500, Nathan Zimmer wrote:
> On Thu, Oct 27, 2016 at 09:19:16PM +0100, Sean Young wrote:
> > On Wed, Oct 26, 2016 at 01:16:16PM -0500, Nathan Zimmer wrote:
> > > On 10/25/2016 03:41 PM, Sean Young wrote:
> > > >On Mon, Oct 24, 20
On Mon, Nov 07, 2016 at 08:41:12AM -0700, Shuah Khan wrote:
> Fix the following uninitialized variable compiler warning:
>
> drivers/media/usb/dvb-usb/dib0700_core.c: In function
> ‘dib0700_rc_urb_completion’:
> drivers/media/usb/dvb-usb/dib0700_core.c:763:2: warning: ‘protocol’ may be
> used u
mediate "toggle" variable, like is done in
> other branches.
>
> Fixes: 00bb820755ed8ee9 ("[media] rc: Hauppauge z8f0811 can decode RC6")
> Signed-off-by: Geert Uytterhoeven
Thanks for finding this and writing a patch.
Acked-by: Sean Young
> ---
> drivers/media/i2c
On Wed, Oct 19, 2016 at 05:13:41PM -0500, Nathan Zimmer wrote:
> On 10/19/2016 04:07 AM, Sean Young wrote:
> >So with 3.6.0:
> >
> >>[2.079980] Serial: 8250/16550 driver, 8 ports, IRQ sharing disabled
> >>[2.100887] serial8250: ttyS1 at I/O 0x2f8 (irq =
Hi David, Andi,
On Mon, Oct 31, 2016 at 02:31:52PM +, David Härdeman wrote:
> October 27, 2016 4:36 PM, "Sean Young" wrote:
> > Since we have to be able to switch between waiting and not waiting,
> > we need some sort of ABI for this. I think this warrants a new io
On Sun, Oct 30, 2016 at 10:33:02AM -0500, Nathan wrote:
> I think this should be PNP0501 instead of PNP0c02.
> Once I alter that then when I boot the serial comes up on irq 3. However it
> still hangs.
> I'll keep digging.
Well that's that theory out of the window. I'm not sure where to look now,
Hi Andi,
On Tue, Nov 01, 2016 at 03:51:11PM +0900, Andi Shyti wrote:
> > Andi, it would be good to know what the use-case for the original change is.
>
> the use case is the ir-spi itself which doesn't need the lirc to
> perform any waiting on its behalf.
Here is the crux of the problem: in the
On Sat, Oct 29, 2016 at 11:04:32PM +0200, Arnd Bergmann wrote:
> On Thursday, October 13, 2016 10:28:44 PM CEST Sean Young wrote:
> > When receiving a nec repeat, ensure the correct scancode is repeated
> > rather than a random value from the stack. This removes the need
&g
support is currently ongoing.
Looks great! For the whole series:
Reviewed-by: Sean Young
Thanks,
Sean
drivers were merged in 2010, and
other than trival patches, they have not made any progress towards
mainline.
ir-rx51 is not a staging driver, but it should not rely on the lirc
in-kernel API like the staging drivers do.
Sean Young (5):
[media] ir-rx51: port to rc-core
[media] staging: lirc_sir
This driver was written using lirc since rc-core did not support
transmitter-only hardware at that time. Now that it does, port
this driver.
Compile tested only.
Signed-off-by: Sean Young
Cc: Timo Kokkonen
Cc: Ivaylo Dimitrov
---
arch/arm/mach-omap2/pdata-quirks.c | 8 +-
drivers
The lirc_parallel driver was merged in 2010 and noone has attempted
to do the work necessary to get it out of staging (i.e. port it to
rc-core). I have not been able to find one of these devices, and
a machine with a parallel port is pretty rare too.
Signed-off-by: Sean Young
Cc: Jarod Wilson
.
Signed-off-by: Sean Young
Cc: Jarod Wilson
Cc: Leonid Froenchenko
---
drivers/staging/media/lirc/Kconfig | 6 -
drivers/staging/media/lirc/Makefile | 1 -
drivers/staging/media/lirc/lirc_bt829.c | 401
3 files changed, 408 deletions(-)
delete mode
Before this driver can be moved out of staging, it should be ported
to rc-core. I've tried to make the minimum changes possible without
upsetting checkpatch.
Compile tested only.
Signed-off-by: Sean Young
Cc: Jarod Wilson
Cc: Christoph Bartelmus
Cc: Milan Pikula
Cc: Frank Przyb
code from staging to mainline imon.
Now that mainline imon can handle these four devices, lirc_imon is no
longer needed.
Compile tested only.
Signed-off-by: Sean Young
Cc: Venky Raju
Cc: Jarod Wilson
Cc: Alexey Khoroshilov
---
drivers/media/rc/imon.c| 133 -
drivers/sta
On Fri, Oct 21, 2016 at 10:55:40AM -0500, Nathan Zimmer wrote:
> It didn't seem to make a difference as far as output.
> Did I miss a config option? or something else?
>
> [0.00] Linux version 3.6.0 (root@r1i2n0) (gcc version 4.3.4
> [gcc-4_3-branch revision 152973] (SUSE Linux) ) #3 SMP M
On Mon, Oct 24, 2016 at 04:49:25PM -0500, Nathan Zimmer wrote:
> [0.974874] system 00:03: Plug and Play ACPI device, IDs PNP0c02 (active)
> [0.975038] pnp 00:04: parse resource options
> [0.975048] pnp 00:04: dependent set 0 (acceptable) io min 0x2f8 max
> 0x2f8 align 1 size 8 flags
Hi Ivo,,
On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivaylo Dimitrov wrote:
> On 20.12.2016 19:50, Sean Young wrote:
> >This driver was written using lirc since rc-core did not support
> >transmitter-only hardware at that time. Now that it does, port
> >this driver.
>
On Fri, Dec 30, 2016 at 01:07:52PM +, Sean Young wrote:
> Hi Ivo,,
>
> On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivaylo Dimitrov wrote:
> > On 20.12.2016 19:50, Sean Young wrote:
> > >This driver was written using lirc since rc-core did not support
> > >trans
Hi Ivo,
On Fri, Dec 30, 2016 at 03:50:42PM +0200, Ivaylo Dimitrov wrote:
> On 30.12.2016 15:30, Sean Young wrote:
> >On Fri, Dec 30, 2016 at 01:07:52PM +0000, Sean Young wrote:
> >Speaking of which, if you would please test this, that would be great. My
> >N900 died many ye
Hi Andi,
This patch breaks all rc devices, none of them have input devices any
more (see below).
On Wed, Dec 14, 2016 at 11:00:26PM +0900, Andi Shyti wrote:
> Move the input device allocation, map and protocol handling to
> different functions.
>
> Signed-off-by: Andi Shyti
> Re
ctions.
>
> Signed-off-by: Andi Shyti
> Reviewed-by: Sean Young
> ---
> drivers/media/rc/rc-main.c | 143
> +
> 1 file changed, 81 insertions(+), 62 deletions(-)
>
> diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/r
Hi Andi,
On Fri, Dec 16, 2016 at 12:10:26PM +, Sean Young wrote:
> Sorry to add to your woes, but there are some checkpatch warnings and
> errors. Please can you correct these. One is below.
Actually, the changes are pretty minor, I can fix them up before sending
them to Mauro. Sor
On Fri, Feb 24, 2017 at 11:15:51AM -0800, Linus Torvalds wrote:
> Added more relevant people. I've debugged the immediate problem below,
> but I think there's another problem that actually triggered this.
>
> On Fri, Feb 24, 2017 at 10:28 AM, kernel test robot
> wrote:
> >
> > 0day kernel testing
: # 4.10
Signed-off-by: Sean Young
---
drivers/media/rc/serial_ir.c | 243 +--
1 file changed, 118 insertions(+), 125 deletions(-)
diff --git a/drivers/media/rc/serial_ir.c b/drivers/media/rc/serial_ir.c
index 923fb22..22144b4 100644
--- a/drivers/media/rc
On Wed, Jun 29, 2016 at 10:20:44PM +0900, Andi Shyti wrote:
> The Lirc framework works mainly with receivers, but there is
> nothing that prevents us from using it for transmitters as well.
The lirc interface already provides for transmitting IR.
> For that we need to have more control on the dev
. I've spent the morning going
through them and it looks good. Of the all the dvb ioctl, only the
FE_SET_PROPERTY and FE_GET_PROPERTY ioctls need special handling and this
series fixes that.
Belated,
Reviewed-by: Sean Young
Sean
On Sat, Jun 06, 2020 at 12:17:28AM +0800, Chuhong Yuan wrote:
> budget_register() has no error handling after its failure.
> Add the missed undo functions for error handling to fix it.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Changes look good, but the Fixes: points to the first import of lin
On Mon, Oct 05, 2020 at 08:36:39AM -0500, Rob Herring wrote:
> On Sat, Oct 3, 2020 at 3:46 AM Sean Young wrote:
> >
> > On Tue, Sep 29, 2020 at 10:52:01AM -0500, Rob Herring wrote:
> > > On Wed, Sep 23, 2020 at 03:08:06AM +0800, Joakim Zhang wrote:
> > > > A
On Tue, Sep 29, 2020 at 10:52:01AM -0500, Rob Herring wrote:
> On Wed, Sep 23, 2020 at 03:08:06AM +0800, Joakim Zhang wrote:
> > Add linux,autosuspend-period property for gpio ir receiver. Some cpuidle
> > systems wake from idle may take a bit long time, for such case, need
> > disable cpuidle temp
On Wed, May 13, 2020 at 10:16:46AM +0200, Greg KH wrote:
> On Tue, May 12, 2020 at 10:07:24AM +0100, Sean Young wrote:
> > So this device is the infrared kind which rc-core (in drivers/media/rc/)
> > supports, remotes and such things (not for serial IR). So by using a
> > r
On Tue, May 12, 2020 at 10:37:27AM -0700, Dmitry Torokhov wrote:
> On Tue, May 12, 2020 at 10:07:24AM +0100, Sean Young wrote:
> > Now it would be nice to have a discussion about this rather than being
> > dismissed with:
> >
> > > > > Ummm, serial protocol d
data[0] is assigned to a local variable, which
> replaces the use of data[0].
See the discussion here:
https://lkml.org/lkml/2020/8/31/479
It does not seem worthwhile merging to the stable trees.
Thanks
Sean
>
> Signed-off-by: Jia-Ju Bai
> Signed-off-by: Sean Young
> Signed-
s is causing random errors in the transmitted
> > IR. Remove the usleep_range() in favour of busy-looping with udelay().
> >
> > Signed-off-by: Sean Young
>
> I don't believe this should be in stable.
>
> Yes, it probably fixes someone's remote cont
On Sat, Aug 29, 2020 at 08:16:00PM +0300, Laurent Pinchart wrote:
> On Sat, Aug 29, 2020 at 02:10:20PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > > The value av7110->debi_virt is stored in DMA memory, and it is assigned
> > > to data, and thus data[0] can be modified at any time by malicious
> > >
On Tue, Jul 28, 2020 at 02:57:17PM +0530, Vaibhav Gupta wrote:
> The .suspend() and .resume() callbacks are not defined for this driver.
> Still, their power management structure follows the legacy framework. To
> bring it under the generic framework, simply remove the binding of
> callbacks from "
On Sun, Aug 30, 2020 at 04:20:42PM +0800, Jia-Ju Bai wrote:
> In debiirq(), data_0 stores the value of data[0], but it can be dropped
> by compiler optimization. Thus, data[0] is read through READ_ONCE().
>
> Fixes: 6499a0db9b0f ("media: pci: ttpci: av7110: fix possible buffer overflow
> caused b
Hi Joakim,
Thanks for your patch, I think it looks good in principle but needs a
few small fixes.
On Tue, Sep 15, 2020 at 11:02:02PM +0800, Joakim Zhang wrote:
> GPIO IR receive is much rely on interrupt response, uneven interrupt
> latency will lead to incorrect timing, so the decoder fails to
Hi Joakim,
On Fri, Sep 18, 2020 at 01:42:15AM +, Joakim Zhang wrote:
> > -Original Message-
> > From: Sean Young
> > Sent: 2020年9月18日 4:44
> > To: Joakim Zhang
> > Cc: mche...@kernel.org; linux-me...@vger.kernel.org;
> > linux-kernel@vger.kerne
Hi Joakim,
On Thu, Sep 17, 2020 at 09:12:32AM +, Joakim Zhang wrote:
>
> > -Original Message-
> > From: Sean Young
> > Sent: 2020年9月15日 17:34
> > To: Joakim Zhang
> > Cc: mche...@kernel.org; linux-me...@vger.kernel.org;
> > linux-kernel@vge
Hi Joakim,
Thanks for your updated patch.
On Sat, Sep 19, 2020 at 02:17:17AM +0800, Joakim Zhang wrote:
> GPIO IR receive is much rely on interrupt response, uneven interrupt
> latency will lead to incorrect timing, so the decoder fails to decode
> it. The issue is particularly acute on some syst
On Wed, Sep 23, 2020 at 03:08:05AM +0800, Joakim Zhang wrote:
> Add QoS support for cpuidle system.
Reviewed-by: Sean Young
Rob, would you be able to review the device tree bindings please?
Thanks,
Sean
>
> Joakim Zhang (2):
> bindings: media: gpio-ir-receiver: add linux
On Tue, Sep 15, 2020 at 04:36:08PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Currently the LIRC_GET_MIN_TIMEOUT is checking for a null dev->max_timeout
> and then accessing dev->min_timeout, hence we may have a potential null
> pointer dereference issue. This looks like a cut-n-paste t
Hi Joakim,
On Tue, Sep 15, 2020 at 10:55:17AM +, Joakim Zhang wrote:
>
> Hi Sean,
>
> Thanks a lot for your review.
>
> > -Original Message-
> > From: Sean Young
> > Sent: 2020年9月15日 17:34
> > To: Joakim Zhang
> > Cc: mche...@kerne
Hi Joakim,
On Wed, Sep 16, 2020 at 10:22:11AM +, Joakim Zhang wrote:
>
> Hi Sean,
>
> Thanks for your hint, I will send a V2 soon according to your suggestions.
>
> We also have a concern, since you are a IR expert, may you can give us
> answers. With this patch, the first frame once press
101 - 200 of 235 matches
Mail list logo
