Re: IB on s390 broken with commit 99db94940 "IB/core: Remove ib_device.dma_device"

2017-02-28 Thread Sebastian Ott
On Mon, 27 Feb 2017, Bart Van Assche wrote: > On Mon, 2017-02-27 at 21:17 +0100, Sebastian Ott wrote: > > commit 99db94940 "IB/core: Remove ib_device.dma_device" > > breaks infiniband on s390 (and I think also other archs that do something > > like to_pci_d

Re: IB on s390 broken with commit 99db94940 "IB/core: Remove ib_device.dma_device"

2017-02-28 Thread Sebastian Ott
On Tue, 28 Feb 2017, Sebastian Ott wrote: > On Mon, 27 Feb 2017, Bart Van Assche wrote: > > On Mon, 2017-02-27 at 21:17 +0100, Sebastian Ott wrote: > > > commit 99db94940 "IB/core: Remove ib_device.dma_device" > > > breaks infiniband on s390 (and I thi

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-19 Thread Sebastian Ott
On Thu, 18 Feb 2016, Kirill A. Shutemov wrote: > I worth minimizing kernel config on which you can see the bug. Things like > CONFIG_DEBUG_PAGEALLOC used to interfere with THP before. I disabled all debugging options (using arch/s390/configs/performance_defconfig) - we still chrashed. Sebastian

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Sebastian Ott
On Fri, 12 Feb 2016, Will Deacon wrote: > On Thu, Feb 11, 2016 at 08:57:02PM +0100, Gerald Schaefer wrote: > > On Thu, 11 Feb 2016 21:09:42 +0200 > > "Kirill A. Shutemov" wrote: > > > On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote: > >

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-12 Thread Sebastian Ott
On Thu, 11 Feb 2016, Kirill A. Shutemov wrote: > On Thu, Feb 11, 2016 at 09:09:42PM +0200, Kirill A. Shutemov wrote: > > On Thu, Feb 11, 2016 at 07:22:23PM +0100, Gerald Schaefer wrote: > > > Hi, > > > > > > Sebastian Ott reported random kernel crashes begin

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-13 Thread Sebastian Ott
On Sat, 13 Feb 2016, Kirill A. Shutemov wrote: > Could you check if revert of fecffad25458 helps? I reverted fecffad25458 on top of 721675fcf277cf - it oopsed with: ¢ 1851.721062! Unable to handle kernel pointer dereference in virtual kernel address space ¢ 1851.721075! failing address: 000

[PATCH] input/arc_ps2: add HAS_IOMEM dependency

2015-06-29 Thread Sebastian Ott
Fix this compile error: drivers/built-in.o: In function `arc_ps2_probe': /mnt/linux/drivers/input/serio/arc_ps2.c:206: undefined reference to `devm_ioremap_resource' Signed-off-by: Sebastian Ott --- drivers/input/serio/Kconfig |1 + 1 file changed, 1 insertion(+) --- a/dri

[PATCH] phy/pxa: add HAS_IOMEM dependency

2015-06-29 Thread Sebastian Ott
nce to 'devm_ioremap_resource' Signed-off-by: Sebastian Ott --- drivers/phy/Kconfig |2 ++ 1 file changed, 2 insertions(+) --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -56,6 +56,7 @@ config PHY_EXYNOS_MIPI_VIDEO config PHY_PXA_28NM_HSIC tristate "Marvell

Re: [PATCH 16/31] s390: handle page-less SG entries

2015-08-12 Thread Sebastian Ott
On Wed, 12 Aug 2015, Christoph Hellwig wrote: > Use sg_phys() instead of page_to_phys(sg_page(sg)) so that we don't > require a page structure for all DMA memory. > > Signed-off-by: Christoph Hellwig Acked-by: Sebastian Ott > --- > arch/s390/pci/pci_dma.c | 20 ++

Re: [RFC Patch V1 04/12] s390/pci: Use for_pci_msi_entry() to access MSI device list

2015-07-13 Thread Sebastian Ott
On Thu, 9 Jul 2015, Jiang Liu wrote: > Use accessor for_pci_msi_entry() to access MSI device list, so we could > easily move msi_list from struct pci_dev into struct device later. > > Signed-off-by: Jiang Liu Acked-by: Sebastian Ott Regards, Sebastian > --- > arch/s39

too large sg segments with commit 09324d32d2a08

2019-06-05 Thread Sebastian Ott
Hi, this warning turned up on s390: [7.041512] [ cut here ] [7.041518] DMA-API: nvme :00:00.0: mapping sg segment longer than device claims to support [len=106496] [max=65536] [7.041531] WARNING: CPU: 1 PID: 229 at kernel/dma/debug.c:1233 debug_dma_map_sg

Re: [PATCH] s390/cio: introduce driver_override on the css bus

2019-06-21 Thread Sebastian Ott
r pci). > > Note that unlike pci we still require a driver override to > match the subchannel type; matching more than one subchannel > type is probably not useful anyway. > > Signed-off-by: Cornelia Huck Reviewed-by: Sebastian Ott Should I take that via our git tree or do you have other patches depending on this one?

Re: [RFC PATCH 01/57] drivers: s390/cio: Use driver_for_each_device

2019-06-17 Thread Sebastian Ott
On Mon, 3 Jun 2019, Suzuki K Poulose wrote: > The cio driver use driver_find_device() to find all devices > to release them before the driver is unregistered. Instead, > it could easily use a lighter driver_for_each_device() helper > to iterate over all the devices. > > Cc: S

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-01-30 Thread Sebastian Ott
that function from module code. As an unrelated question, just to be sure: ap_bus.c is compiled as built-in even with ZCRYPT=m, right? Reviewed-by: Sebastian Ott Regards, Sebastian

Re: [RFC PATCH 0/2] iommu/s390: Fix iommu-groups and add sysfs support

2017-04-28 Thread Sebastian Ott
On Fri, 28 Apr 2017, Joerg Roedel wrote: > On Fri, Apr 28, 2017 at 02:46:34PM +0200, Gerald Schaefer wrote: > > On Thu, 27 Apr 2017 23:03:25 +0200 > > Joerg Roedel wrote: > > > > > > Well, there is a separate zpci_dev for each pci_dev on s390, > > > > and each of those has its own separate dma-ta

[PATCH] kvm: fix warning for non-x86 builds

2018-02-22 Thread Sebastian Ott
7; was not declared. Should it be static? Signed-off-by: Sebastian Ott --- arch/x86/include/asm/kvm_host.h | 3 --- include/linux/kvm_host.h| 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index dd

[PATCH] kvm: fix warning for CONFIG_HAVE_KVM_EVENTFD builds

2018-02-22 Thread Sebastian Ott
Move the kvm_arch_irq_routing_update() prototype outside of ifdef CONFIG_HAVE_KVM_EVENTFD guards to fix the following sparse warning: arch/s390/kvm/../../../virt/kvm/irqchip.c:171:28: warning: symbol 'kvm_arch_irq_routing_update' was not declared. Should it be static? Signed-off-by:

[bisected] system hang after boot

2017-11-22 Thread Sebastian Ott
Hi, One of my test systems (s390) hangs after boot. One of the cpus is idle the other is in arch_spin_relax. Bisect pointed to this one: a8a217c22116eff6c120d753c9934089fb229af0 is the first bad commit commit a8a217c22116eff6c120d753c9934089fb229af0 Author: Will Deacon Date: Tue Oct 3 19:25:27

Re: [bisected] system hang after boot

2017-11-22 Thread Sebastian Ott
Hello Will, On Wed, 22 Nov 2017, Will Deacon wrote: > Now, I can't see what the break_lock is doing here other than causing > problems. Is there a good reason for it, or can you just try removing it > altogether? Patch below. With your patch applied the system is able to boot again. I did some qu

Re: [PATCH v3] iommu/s390: Add support for iommu_device handling

2017-08-10 Thread Sebastian Ott
On Wed, 9 Aug 2017, Joerg Roedel wrote: > From: Joerg Roedel > > Add support for the iommu_device_register interface to make > the s390 hardware iommus visible to the iommu core and in > sysfs. > With this patch pci hot-unplug fails with a use after free or refcounting issue - I'm currently try

Re: [PATCH v3] iommu/s390: Add support for iommu_device handling

2017-08-11 Thread Sebastian Ott
Hello Joerg, On Fri, 11 Aug 2017, Joerg Roedel wrote: > Hey Sebastian, > > On Thu, Aug 10, 2017 at 09:07:06PM +0200, Sebastian Ott wrote: > > With this patch pci hot-unplug fails with a use after free or refcounting > > issue - I'm currently trying to understand what

Re: [PATCH v3] iommu/s390: Add support for iommu_device handling

2017-08-11 Thread Sebastian Ott
On Fri, 11 Aug 2017, Sebastian Ott wrote: > * iommu_release_device must not release the struct device but the > structure it is embedded in: struct iommu_device (I'll send a patch > for that) --->8 >From 2839c92e038af47b8cb569f84d571878c54d1815 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH v3] iommu/s390: Add support for iommu_device handling

2017-08-11 Thread Sebastian Ott
On Fri, 11 Aug 2017, Sebastian Ott wrote: > * That patch embedded a struct iommu_device within struct zpci_dev but > the iommu_device has a release function (via its class) - so when > the release function gets called it frees memory that was never allocated. > The fix is to not e

Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-31 Thread Sebastian Ott
Hi, A system running v4.12-rc3-11-gf511c0b on s390 hangs after boot with no messages on the console. The message buffer obtained via a system dump looked like this: [...] [ 17.870712] virbr0: port 1(virbr0-nic) entered disabled state [ 19.618523] Unable to handle kernel pointer dereference in

Re: Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-06-01 Thread Sebastian Ott
On Thu, 1 Jun 2017, Xin Long wrote: > On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott > wrote: > > [...] > I couldn't see any bridge-related thing here, and it couldn't be reproduced > with virbr0 (stp=1) on my box (on both s390x and x86_64), I guess there > i

Re: linux-next: manual merge of the block tree with the s390 tree

2017-06-13 Thread Sebastian Ott
Hi, On Tue, 13 Jun 2017, Christoph Hellwig wrote: > Btw, scm_blk.c blk-mq conversion seems odd if not broken. It should > always call blk_mq_complete_request from scm_request_finish and > then pass the error to blk_mq_end_request frin > there. OK. I had added that because rq->errors went away. W

Re: [PATCH] s390: qdio: Convert timers to use timer_setup()

2017-10-05 Thread Sebastian Ott
On Wed, 4 Oct 2017, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > -void qdio_outbound_timer(unsigned long data) > +void qdio_outb

Re: [PATCH] s390: qdio: Convert timers to use timer_setup()

2017-10-05 Thread Sebastian Ott
On Thu, 5 Oct 2017, Kees Cook wrote: > On Thu, Oct 5, 2017 at 2:13 AM, Sebastian Ott > wrote: > > On Wed, 4 Oct 2017, Kees Cook wrote: > >> In preparation for unconditionally passing the struct timer_list pointer to > >> all timer callbacks, switch to using the ne

Re: lockdep warning: console vs. mem hotplug

2017-07-24 Thread Sebastian Ott
Hello Sergey, On Tue, 21 Mar 2017, Sergey Senozhatsky wrote: > // I kept only lockdep splats from the original report and cut off .configs > // full version: > // lkml.kernel.org/r/alpine.LFD.2.20.1703201736070.1753@schleppi > > On (03/20/17 17:43), Sebastian Ott wrote: &

Re: [PATCH v3] iommu/s390: Add support for iommu_device handling

2017-08-15 Thread Sebastian Ott
On Mon, 14 Aug 2017, Joerg Roedel wrote: > I attach the patch I wrote to fix this, can you please test it together > with the initial patch in this thread? I did and can confirm that everything worked as expected! Thanks, Sebastian

Re: [PATCH v3] iommu/s390: Add support for iommu_device handling

2017-08-15 Thread Sebastian Ott
On Tue, 15 Aug 2017, Joerg Roedel wrote: > On Tue, Aug 15, 2017 at 06:02:20PM +0200, Sebastian Ott wrote: > > On Mon, 14 Aug 2017, Joerg Roedel wrote: > > > I attach the patch I wrote to fix this, can you please test it together > > > with the initial patch in this thr

Re: linux-next: build failure after merge of the block tree

2017-06-15 Thread Sebastian Ott
On Tue, 13 Jun 2017, Stephen Rothwell wrote: > After merging the block tree, today's linux-next build (s390x > s390-defconfig) failed like this: > > drivers/s390/block/scm_blk.c:293:10: error: 'BLK_MQ_RQ_QUEUE_BUSY' undeclared > (first use in this function) > drivers/s390/block/scm_blk.c:327:9: e

[PATCH] genirq/debugfs: fix build for !CONFIG_IRQ_DOMAIN

2017-07-04 Thread Sebastian Ott
ned-off-by: Sebastian Ott --- kernel/irq/internals.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h index 9da14d1..dbfba99 100644 --- a/kernel/irq/internals.h +++ b/kernel/irq/internals.h @@ -437,7 +437,9 @@ static i

Re: linux-next: build failure after merge of the block tree

2017-06-19 Thread Sebastian Ott
On Thu, 15 Jun 2017, Sebastian Ott wrote: > On Tue, 13 Jun 2017, Stephen Rothwell wrote: > > After merging the block tree, today's linux-next build (s390x > > s390-defconfig) failed like this: > > > > drivers/s390/block/scm_blk.c:293:10: error: 'BLK_MQ_RQ_QUEU

Re: [bisected] system hang after boot

2017-11-27 Thread Sebastian Ott
On Mon, 27 Nov 2017, Will Deacon wrote: > Sebastian: could you try the diff below, please? If that fixes s390, then > we can debate the merits of GENERIC_LOCKBREAK independently of fixing this > issue. > > Thanks, > > Will > > --->8 > > diff --git a/kernel/locking/spinlock.c b/kernel/locking/sp

[PATCH] misc/genwqe: ensure zero initialization

2016-09-12 Thread Sebastian Ott
guaranteed. Simply switch to dma_zalloc_coherent. Signed-off-by: Sebastian Ott --- drivers/misc/genwqe/card_ddcb.c | 2 -- drivers/misc/genwqe/card_utils.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c index

Re: [PATCH 25/28] s390: pci: don't print uninitialized data for debugging

2016-10-18 Thread Sebastian Ott
unsigned long pa = 0; > > int ret; > > > > size = PAGE_ALIGN(size); > > The compiler is right. pa is set in the for-loop. If "dma_addr < > dma_addr_base + size" > is never true and __dma_purge_tlb() returns with an error, pa *is* > uninitialized. > The fix seems sensible to me. Although that could only happen if map_sg is called with zero length sg list entries I'm in favor getting rid of that warning. Acked-by: Sebastian Ott Regards, Sebastian

mlx4: panic during shutdown

2016-10-19 Thread Sebastian Ott
Hi, After a userspace update (fedora 23->24) I reproducibly run into the following oops during shutdown (on s390): [ 71.054832] Unable to handle kernel pointer dereference in virtual kernel address space [ 71.054835] Failing address: 6b6b6b6b6b6b6000 TEID: 6b6b6b6b6b6b6803 [ 71.054838] Fau

[tip:irq/urgent] genirq/debugfs: Fix build for !CONFIG_IRQ_DOMAIN

2017-07-04 Thread tip-bot for Sebastian Ott
Commit-ID: e5682b4eecb2b73282853d0ef314d3164b986997 Gitweb: http://git.kernel.org/tip/e5682b4eecb2b73282853d0ef314d3164b986997 Author: Sebastian Ott AuthorDate: Tue, 4 Jul 2017 11:25:15 +0200 Committer: Thomas Gleixner CommitDate: Tue, 4 Jul 2017 12:36:43 +0200 genirq/debugfs: Fix

<    1   2