Re: [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code

2019-04-10 Thread Shawn Guo
On Mon, Apr 01, 2019 at 06:07:08AM +, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang Applied both, thanks.

Re: [PATCH] clk: imx: use devm_platform_ioremap_resource() to simplify code

2019-04-10 Thread Shawn Guo
On Mon, Apr 01, 2019 at 05:13:02AM +, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang Applied, thanks.

Re: [PATCH v5 0/5] PCIE support for i.MX8MQ (DT changes)

2019-04-10 Thread Shawn Guo
On Fri, Apr 05, 2019 at 10:29:59AM -0700, Andrey Smirnov wrote: > Andrey Smirnov (5): > arm64: dts: imx8mq: Mark iomuxc_gpr as i.MX6Q compatible > arm64: dts: imx8mq: Add a node for SRC IP block > arm64: dts: imx8mq: Combine PCIE power domains > arm64: dts: imx8mq: Add nodes for PCIe IP

Re: [PATCH] arm64: dts: imx8qxp: Add lpuart1/lpuart2/lpuart3 nodes

2019-04-10 Thread Shawn Guo
On Sat, Mar 30, 2019 at 05:07:44PM +, Daniel Baluta wrote: > lpuart nodes are part of the ADMA subsystem. See Audio DMA > memory map in iMX8 QXP RM [1] > > This patch is based on the dtsi file initially submitted by > Teo Hall in i.MX NXP internal tree. > > [1]

Re: [PATCH 1/4] ARM: dts: imx6: RDU2: Use new CODEC reset pin name

2019-04-10 Thread Shawn Guo
On Fri, Mar 29, 2019 at 01:13:10PM -0500, Andrew F. Davis wrote: > The correct DT property for specifying a GPIO used for reset > is "reset-gpios", the driver now accepts this name, use it here. > > Note the GPIO polarity in the driver was ignored before and always > assumed to be active low,

Re: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA

2019-04-10 Thread Shawn Guo
gus Ainslie (Purism) > Cc: Chris Healy > Cc: Lucas Stach > Cc: Fabio Estevam > Cc: Shawn Guo > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/imx6qdl.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [v7 1/3] dt-bindings: ahci-fsl-qoriq: add lx2160a chip name to the list

2019-04-10 Thread Shawn Guo
On Tue, Mar 12, 2019 at 09:50:17AM +0800, Peng Ma wrote: > Add lx2160a compatible to bindings documentation. > > Signed-off-by: Peng Ma > Reviewed-by: Rob Herring I assume that the bindings will go via AHCI tree. Otherwise, please let me know. Shawn

Re: [PATCH 1/3] dt-bindings: ahci-fsl-qoriq: add ls1028a chip name to the list

2019-04-10 Thread Shawn Guo
On Mon, Mar 11, 2019 at 03:20:12PM +0800, Peng Ma wrote: > Add ls1028a compatible to bindings documentation. > > Signed-off-by: Peng Ma I assume that the bindings will be picked up by Axboe. Otherwise, please let me know. Shawn

Re: [PATCH 2/3] arm64: dts: ls1028a: Corrected the SATA ecc address.

2019-04-10 Thread Shawn Guo
On Mon, Mar 11, 2019 at 03:20:13PM +0800, Peng Ma wrote: > Ls1028a SATA ecc address with more than 32 bit, so we should corrrect the > address. > > Signed-off-by: Peng Ma Applied, thanks.

Re: [v7 2/3] arm64: dts: lx2160a: add sata node support

2019-04-10 Thread Shawn Guo
On Tue, Mar 12, 2019 at 09:50:18AM +0800, Peng Ma wrote: > Add SATA device nodes for fsl-lx2160a and enable support > for QDS and RDB boards. > > Signed-off-by: Peng Ma Applied, thanks.

Re: [PATCH v2 3/3] arm64: dts: imx8mq: Change ahb clock for imx8mq

2019-04-03 Thread Shawn Guo
On Fri, Mar 29, 2019 at 08:21:30AM -0700, Angus Ainslie (Purism) wrote: > Set ahb clock on sdma1 to get rid of "Timeout waiting for CH0" > on the imx8mq. > > Signed-off-by: Angus Ainslie (Purism) Applied, thanks.

Re: [PATCH v2 1/3] arm64: dts: imx8mq: Fix the fsl,imx8mq-sdma compatible string

2019-04-03 Thread Shawn Guo
On Fri, Mar 29, 2019 at 08:21:28AM -0700, Angus Ainslie (Purism) wrote: > Fix a typo in the compatible string > > Signed-off-by: Angus Ainslie (Purism) Applied, thanks.

Re: [PATCH 1/2] ARM: dts: imx7d: Specify viewport count for PCIE block

2019-04-03 Thread Shawn Guo
On Tue, Mar 26, 2019 at 11:38:40PM -0700, Andrey Smirnov wrote: > i.MX7D comes with 4 viewports, so configure PCIE node accordingly so > that the driver won't assume we only have 2. > > Signed-off-by: Andrey Smirnov > Cc: Richard Zhu > Cc: Chris Healy > Cc: Lucas Stach > Cc: Fabio Estevam >

Re: [PATCH v2 0/2] clk: imx5: Fix i.MX50 clock registers

2019-04-03 Thread Shawn Guo
On Tue, Mar 26, 2019 at 07:22:56PM +0100, Jonathan Neuschäfer wrote: > There are a few differences between the i.MX50 clock tree and those of > i.MX51 and i.MX53 that are not yet handled in clk-imx51-imx53.c. This > series handles two of them. > > Jonathan Neuschäfer (2): > clk: imx5: Fix

Re: [PATCH V9 1/4] dt-bindings: watchdog: add i.MX system controller watchdog

2019-04-03 Thread Shawn Guo
On Fri, Mar 29, 2019 at 07:44:21AM +, Anson Huang wrote: > Hi, Guenter/Shawn > Since DT has been acked, would you pick up this patch series if no > additional comments? > Applied patch #3 and #4, thanks.

Re: [PATCH V5 2/4] firmware: imx: enable imx scu general irq function

2019-04-03 Thread Shawn Guo
On Mon, Mar 18, 2019 at 03:09:55AM +, Anson Huang wrote: > The System Controller Firmware (SCFW) controls RTC, thermal > and WDOG etc., these resources' interrupt function are managed > by SCU. When any IRQ pending, SCU will notify Linux via MU general > interrupt channel #3, and Linux kernel

Re: [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X*

2019-04-03 Thread Shawn Guo
Hi Linus, I assume this will go via your tree. Let me know if you think differently. Shawn On Wed, Mar 13, 2019 at 03:20:40PM +0100, Christina Quast wrote: > In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from > the documentation. > > Changes since v2: > * Changed patch title

Re: [PATCH] ARM: dts: vf610-zii-cfu1: Disable NOR flash/SPI controller

2019-03-28 Thread Shawn Guo
t; this node. > > Signed-off-by: Andrey Smirnov > Cc: Shawn Guo > Cc: Chris Healy > Cc: Andrew Lunn > Cc: Fabio Estevam > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org Applied, thanks.

Re: [PATCH v3 1/3] dt-bindings: arm: fsl: Add supported ZII VF610 boards to DT schema

2019-03-28 Thread Shawn Guo
On Mon, Mar 25, 2019 at 11:22:41AM -0700, Andrey Smirnov wrote: > Add already supported ZII VF610 boards to DT schema. > > Signed-off-by: Andrey Smirnov > Cc: Shawn Guo > Cc: Chris Healy > Cc: Andrew Lunn > Cc: Fabio Estevam > Cc: Rob Herring > Cc: linux-arm-ker.

Re: [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS

2019-03-28 Thread Shawn Guo
On Tue, Mar 26, 2019 at 05:26:53PM +0100, Jonathan Neuschäfer wrote: > Hi, thanks for your comments. I'll address them in v2. > > On Fri, Mar 22, 2019 at 09:31:53AM +0800, Shawn Guo wrote: > > On Tue, Mar 19, 2019 at 04:24:17PM +0100, Jonathan Neuschäfer wrote: > > > Th

Re: [PATCH] ARM: dts: imx7ulp: add ocotp support

2019-03-26 Thread Shawn Guo
On Fri, Mar 22, 2019 at 06:31:56AM +, Anson Huang wrote: > Add i.MX7ULP OCOTP support, its clock source is from > M4 BUS clock which is NOT available in Linux clock tree, > but M4 BUS clock is always ON when A7 (Linux) is alive, > so just use dummy clock here. > > Signed-off-by: Anson Huang

Re: [PATCH] clk: imx: Remove unused imx_get_clk_hw_fixed

2019-03-26 Thread Shawn Guo
On Thu, Mar 21, 2019 at 03:25:54PM +, Abel Vesa wrote: > This is never used and the imx_clk_hw_fixed does the same thing. > > Signed-off-by: Abel Vesa Applied, thanks.

Re: [PATCH 1/2] ARM: dts: ls1021a: Remove unused properties from QSPI node

2019-03-21 Thread Shawn Guo
On Wed, Mar 20, 2019 at 02:38:02PM +, Schrempf Frieder wrote: > From: Frieder Schrempf > > After switching to the new FSL QSPI driver the properties > 'fsl,qspi-has-second-chip' and 'big-endian' are not used anymore. > > The driver now uses the 'reg' property to determine the bus and > the

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Shawn Guo
On Thu, Mar 21, 2019 at 11:00:18PM -0300, Fabio Estevam wrote: > Hi Shawn, > > On Thu, Mar 21, 2019 at 10:12 PM Shawn Guo wrote: > > > > So yes, we currently have lots of broken dtb's in mainline and I am > > > wondering what is the proper fix here. > > >

Re: [PATCH v4] arm64: dts: fsl: imx8mq: enable the multi sensor TMU

2019-03-21 Thread Shawn Guo
On Thu, Mar 21, 2019 at 05:52:52AM -0700, Angus Ainslie (Purism) wrote: > Add the imx8mq TMU (Thermal management unit) nodes for CPU, > GPU, and VPU. > > Signed-off-by: Angus Ainslie (Purism) Subject prefix 'arm64: dts: imx8mq:' would be good enough. I changed it and applied patch. Shawn >

Re: [PATCH 5/5] ARM: dts: imx50: Fix the numbering of the I2C controllers

2019-03-21 Thread Shawn Guo
On Tue, Mar 19, 2019 at 04:24:20PM +0100, Jonathan Neuschäfer wrote: > Ensure that the i2c buses are reported to userspace (for example to > i2cdetect) in the same order as they are numbered in the SoC's > documentation by adding aliases to the devicetree. > > Signed-off-by: Jonathan Neuschäfer

Re: [PATCH 3/5] ARM: dts: imx50: Add PHY node for usbotg and adjust clocks

2019-03-21 Thread Shawn Guo
On Tue, Mar 19, 2019 at 04:24:18PM +0100, Jonathan Neuschäfer wrote: > Even though the ChipIdea USB controller binding[1] doesn't specify the > properties that reference a PHY as required, the Linux driver > requires[2] such a reference. > > The clock situation is like on i.MX53: The USB

Re: [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS

2019-03-21 Thread Shawn Guo
On Tue, Mar 19, 2019 at 04:24:17PM +0100, Jonathan Neuschäfer wrote: > The Kobo Aura is an e-book reader released in 2013. > > With the devicetree in its current state, the kernel will boot and run > for about ten seconds. To solve this, the embedded controller needs to > be told that the system

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Shawn Guo
On Thu, Mar 21, 2019 at 08:17:01AM -0300, Fabio Estevam wrote: > Hi Abel, > > On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa wrote: > > > > It seems we have other boards that need to be fixed and we can not > > > have an old dtb with functional Ethernet with a new kernel. > > > > > > Does anyone

Re: [PATCH] ARM: dts: imx6qdl: Fix typo in imx6qdl-icore-rqs.dtsi

2019-03-21 Thread Shawn Guo
On Tue, Mar 19, 2019 at 01:30:09AM +0900, Masanari Iida wrote: > This patch fixes a spelling typo. > > Signed-off-by: Masanari Iida Applied, thanks.

Re: [PATCH] arm64: dts: imx8qxp: add lsio_mu2 node

2019-03-21 Thread Shawn Guo
On Wed, Mar 13, 2019 at 09:24:42AM +, Peng Fan wrote: > Add lsio_mu2 node which could be used communicate with SCU. > > Signed-off-by: Peng Fan Applied, thanks.

Re: [PATCH] arm64: dts: imx8qxp: fix mbox-cells

2019-03-21 Thread Shawn Guo
On Wed, Mar 13, 2019 at 09:24:19AM +, Peng Fan wrote: > Currently lsio_mu1 is used by Linux Kernel with mbox-cells as 2, but > actually mu0-4 could be used to communicate with SCU. So fix the > mbox-cells. > > Signed-off-by: Peng Fan Applied, thanks.

Re: [PATCH 1/2] ARM: imx: drop uneccessary of_platform_default_populate

2019-03-21 Thread Shawn Guo
On Mon, Mar 18, 2019 at 02:31:34AM +, Peng Fan wrote: > > > > -Original Message- > > From: Aisheng Dong > > Sent: 2019年3月15日 21:39 > > To: Peng Fan ; shawn...@kernel.org; > > s.ha...@pengutronix.de; ker...@pengutronix.de; feste...@gmail.com; > > dl-linux-imx ; Anson Huang ; > >

Re: [PATCH 1/2] ARM: imx: drop uneccessary of_platform_default_populate

2019-03-21 Thread Shawn Guo
On Wed, Mar 13, 2019 at 09:05:52AM +, Peng Fan wrote: > "arch_initcall_sync(of_platform_default_populate_init);" could be The code change looks good. But can you please mention commit 44a7185c2ae6 ("of/platform: Add common method to populate default bus") in the commit log, so that we will

Re: [PATCH v2] ARM: dts: vf610: Add ZII SPB4 board

2019-03-21 Thread Shawn Guo
On Wed, Mar 13, 2019 at 12:02:24AM -0700, Andrey Smirnov wrote: > Add Device Tree for VF610 based Zodiac Seat Power Box. > > Signed-off-by: Andrey Smirnov > Cc: Shawn Guo > Cc: Chris Healy > Cc: Andrew Lunn > Cc: Heiner Kallweit > Cc: Fabio Estevam > Cc: linux-arm

Re: [PATCH V5 1/4] dt-bindings: memory-controllers: freescale: add MMDC binding doc

2019-03-20 Thread Shawn Guo
On Tue, Mar 12, 2019 at 02:24:08AM +, Anson Huang wrote: > Freescale MMDC (Multi Mode DDR Controller) driver is supported > since i.MX6Q, but not yet documented, this patch adds binding > doc for MMDC module driver. > > Signed-off-by: Anson Huang Applied all, thanks.

Re: [PATCH] ARM: dts: imx6ull: Use the correct style for SPDX License Identifier

2019-03-20 Thread Shawn Guo
On Mon, Mar 11, 2019 at 07:57:04PM +0530, Nishad Kamdar wrote: > This patch corrects the SPDX License Identifier style > in imx6ull-pinfunc-snvs.h. > > Changes made by using a script provided by Joe Perches here: > https://lkml.org/lkml/2019/2/7/46 > and making some manual changes. > >

Re: [PATCH v3] arm64: dts: ls1088a: add one more thermal zone node

2019-03-20 Thread Shawn Guo
On Mon, Mar 04, 2019 at 03:50:50PM +0800, Yuantian Tang wrote: > Ls1088a has 2 thermal sensors, core cluster and SoC platform. Core cluster > sensor is used to monitor the temperature of core and SoC platform is for > platform. The current dts only support the first sensor. > This patch adds the

Re: [PATCH 2/3] ARM: DTS: imx6q-logicpd: Reduce inrush current on start

2019-03-20 Thread Shawn Guo
On Wed, Mar 20, 2019 at 08:41:27AM -0500, Adam Ford wrote: > On Wed, Mar 20, 2019 at 7:45 AM Shawn Guo wrote: > > > > On Wed, Mar 06, 2019 at 08:04:00AM -0600, Adam Ford wrote: > > > The main 3.3V regulator sources a series of additional regulators. > > > This

Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node

2019-03-20 Thread Shawn Guo
On Wed, Mar 20, 2019 at 08:44:18AM +, Andy Tang wrote: > > > Sensor ID placement > > > 1 DDR controller 1 > > > 2 DDR controller 2 > > > 3 DDR controller 3 > > > 4 core cluster 1 > > > 5 core cluster 2 > >

Re: [PATCH] arm64: dts: freescale: Enable PCI-E controller for Oxalis board

2019-03-20 Thread Shawn Guo
On Sat, Mar 09, 2019 at 08:02:09AM +0530, Manivannan Sadhasivam wrote: > Enable PCI-E controller for Oxalis board based on NXP/Freescale LS1012a > SoC available as the Mini PCI-E connector on the bottom side. > > Signed-off-by: Manivannan Sadhasivam Applied, thanks.

Re: [PATCH 3/3] ARM: DTS: imx6q-logicpd: Fix Analog audio capture

2019-03-20 Thread Shawn Guo
On Wed, Mar 06, 2019 at 08:04:01AM -0600, Adam Ford wrote: > The original submission had functional audio out and was based > on reviewing other boards using the same wm8962 codec. However, > the Logic PD board uses an analog microphone which was being > disabled for a digital mic. This patch

Re: [PATCH 2/3] ARM: DTS: imx6q-logicpd: Reduce inrush current on start

2019-03-20 Thread Shawn Guo
On Wed, Mar 06, 2019 at 08:04:00AM -0600, Adam Ford wrote: > The main 3.3V regulator sources a series of additional regulators. > This patch adds a small delay, so when the 3.3V regulator comes > on it delays a bit before the subsequent regulators can come on. > This reduces the inrush current a

Re: [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend

2019-03-20 Thread Shawn Guo
On Wed, Mar 06, 2019 at 08:03:59AM -0600, Adam Ford wrote: > The LCD power sequencer is very finicky. The backlight cannot > be driven until after the sequencer is done. Until now, the > regulators were marked with 'regulator-always-on' to make sure > it came up before the backlight. This patch

Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node

2019-03-20 Thread Shawn Guo
On Fri, Mar 08, 2019 at 09:57:09AM +, Andy Tang wrote: > > > > -Original Message- > > From: Daniel Lezcano > > Sent: 2019年3月8日 17:28 > > To: Andy Tang ; Shawn Guo > > Cc: Leo Li ; robh...@kernel.org; mark.rutl...@arm.com; > > lin

Re: [PATCH] ARM: dts: imx7s-warp: PMIC swbst boot-on/always-on

2019-03-20 Thread Shawn Guo
On Sat, Mar 02, 2019 at 11:32:29PM +0100, Pierre-Jean Texier wrote: > PMIC swbst regulator is used for the MikroBUS socket (pin +5V). > > We have to set the regulator to "boot-on" and "always-on" > to output a voltage of 5V on this socket. > > Signed-off-by: Pierre-Jean Texier Applied, thanks.

Re: [PATCH 1/2] clk: imx7ulp: remove snvs clock

2019-03-20 Thread Shawn Guo
On Thu, Feb 28, 2019 at 08:56:00AM +, Anson Huang wrote: > Since i.MX7ULP B0 chip, the SNVS module is moved into M4 > domain and its clock is also moved into PCC0 which is > contorlled by M4, Linux kernel should NOT add it into > clock tree. > > Signed-off-by: Anson Huang Applied both,

Re: [PATCH v7 0/4] Enable wm8524 on i.MX8MQ-EVK

2019-03-20 Thread Shawn Guo
On Tue, Mar 19, 2019 at 05:48:35PM +, Daniel Baluta wrote: > On i.MX8MQ EVK we can start the party using the wm8524 codec > which gets it's data through the SAI2 interface. > > In order to make it work this patch series enables the SDMA nodes, > sets the correct pinctrl configuration and uses

Re: [PATCH v6 4/4] arm64: dts: imx8mq-evk: Enable audio codec wm8952

2019-03-19 Thread Shawn Guo
On Fri, Mar 08, 2019 at 12:02:28PM +, Daniel Baluta wrote: > The main Audio DAC used on the EVK board is wm8952. > The EVK provides the MCLK to wm8952. > > Digital interface is SAI2 which includes three signals: > SYNC_CLK, BCLK and DACDAT. > > This patch sets: > * SAI2 pinctrl

Re: [PATCH v6 1/4] arm64: dts: imx8mq: Add SDMA nodes

2019-03-19 Thread Shawn Guo
On Fri, Mar 08, 2019 at 12:02:22PM +, Daniel Baluta wrote: > SDMA1 is part of AIPS-3 region and SDMA2 is part > of AIPS-1 region. > > Reviewed-by: Fabio Estevam Reviewed-by tag should go after your SoB, since that's the sequence of how they come. > Signed-off-by: Anson Huang > [initial

Re: [PATCH RESEND V2 2/2] arm64: dts: freescale: imx8mq: add clock for GPIO node

2019-03-19 Thread Shawn Guo
On Wed, Feb 27, 2019 at 01:28:32AM +, Anson Huang wrote: > i.MX8MQ has clock gate for each GPIO bank, add clock info > to GPIO node for clock management. > > Signed-off-by: Anson Huang Prefix 'arm64: dts: imx8mq: ...' is good enough. Dropped 'freescale: ' and applied the patch. Shawn

Re: [PATCH v2 05/15] ARM: imx51: fix a leaked reference by adding missing of_node_put

2019-03-05 Thread Shawn Guo
mx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired > a node pointer with refcount incremented on line 57, but without a > corresponding object release within this function. > > Signed-off-by: Wen Yang > Reviewed-by: Florian Fainelli > Cc: Russell King >

Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node

2019-03-03 Thread Shawn Guo
On Mon, Mar 04, 2019 at 06:46:32AM +, Andy Tang wrote: > > > > -Original Message- > > From: Shawn Guo > > Sent: 2019年3月4日 14:21 > > To: Andy Tang > > Cc: Leo Li ; robh...@kernel.org; mark.rutl...@arm.com; > > linux-arm-ker...@lists

Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node

2019-03-03 Thread Shawn Guo
On Mon, Mar 04, 2019 at 11:21:11AM +0800, Yuantian Tang wrote: > Ls1088a has 2 thermal sensors, core cluster and SoC platform. Core cluster > sensor is used to monitor the temperature of core and SoC platform is for > platform. The current dts only support the first sensor. > This patch adds the

Re: [PATCH] ARM: imx_v6_v7_defconfig: Add GPIO_PCF857X

2019-03-03 Thread Shawn Guo
On Sun, Mar 03, 2019 at 08:32:30PM -0600, Adam Ford wrote: > The imx6q-logicpd board has a PCF8575 connected to it, so this > patch turns it on my default now. > > Signed-off-by: Adam Ford Applied, thanks.

Re: [PATCH 05/15] ARM: imx51: fix a leaked reference by addingmissing of_node_put

2019-03-03 Thread Shawn Guo
On Fri, Mar 01, 2019 at 04:56:46PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: >

Re: [PATCH v3] arm64: dts: ls1028a: Add Audio DT nodes

2019-03-03 Thread Shawn Guo
On Fri, Mar 01, 2019 at 03:46:32PM +0800, Alison Wang wrote: > This patch adds Audio DT nodes for LS1028ARDB and LS1028AQDS boards. > > Signed-off-by: Alison Wang Applied, thanks.

Re: [PATCH v2] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port

2019-03-03 Thread Shawn Guo
On Fri, Mar 01, 2019 at 08:26:42AM +0100, Michal Vokáč wrote: > Use rgmii-id phy mode for the CPU port (MAC0) of the QCA8334 switch > to add delays to both Tx and Rx clock. > > It worked with the rgmii mode before because the qca8k driver > (incorrectly) enabled delays in that mode and rgmii-id

Re: [PATCH v3 0/3] arm: dts: imx8mq: Add cpufreq support

2019-03-03 Thread Shawn Guo
On Thu, Feb 28, 2019 at 09:42:43PM +, Abel Vesa wrote: > Changes since v2: > * renamed the regulator > * removed the useless enable-active-high from the regulator > * renamed a53_0_opp_table to a53_opp_table > > Abel Vesa (3): > arm64: dts: imx8mq: Add the clocks and the latencies for

Re: [PATCH] arm64: dts: ls1028a: add pmu dt nodes

2019-03-03 Thread Shawn Guo
On Wed, Feb 27, 2019 at 09:57:52AM +0800, Alison Wang wrote: > This patch adds pmu dt nodes for LS1028A. > > Signed-off-by: Alison Wang > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git

Re: [PATCH RESEND V4 1/2] dt-bindings: firmware: imx-scu: remove unused resources from scu resource table

2019-03-03 Thread Shawn Guo
On Wed, Feb 27, 2019 at 12:53:04AM +, Anson Huang wrote: > Removes below resources which were defined during > pre-silicon phase and the real silicons do NOT have > them, they have never been used, latest system > controller firmware also removed them: > > IMX_SC_R_DC_0_CAPTURE0 >

Re: [PATCH v2] ls1021aqds: enable esdhc controller

2019-03-03 Thread Shawn Guo
On Tue, Feb 26, 2019 at 08:40:22AM +, Yinbo Zhu wrote: > From: Yinbo Zhu > > This patch is to enable esdhc controller in ls1021aqds > > Signed-off-by: Yinbo Zhu Changed the subject prefix to 'ARM: dts: ls1021a-qds: ...' and applied the patch. Shawn > --- > Change in v2: >

Re: [PATCH] arm64: dts: ls1088a: add one more thermal zone node

2019-03-01 Thread Shawn Guo
On Mon, Feb 25, 2019 at 11:00:49AM +0800, Yuantian Tang wrote: > Ls1088a has 2 thermal sensors. This patch adds the second node > to dts to enable it. Can you elaborate on these 2 thermal sensors/zones, ccu and plt? Shawn > > Signed-off-by: Yuantian Tang > --- >

Re: [PATCH v2] arm64: dts: ls1028a: Add Audio DT nodes

2019-02-28 Thread Shawn Guo
On Wed, Feb 20, 2019 at 04:44:57PM +0800, Alison Wang wrote: > This patch adds Audio DT nodes for LS1028ARDB and LS1028AQDS boards. > > Signed-off-by: Alison Wang > --- > Changes in v2: > - Modify some nodes' names. > - Use GIC_SPI and IRQ_TYPE_LEVEL_HIGH. > >

Re: [PATCH] soc: imx: gpcv2: Make use of regmap_read_poll_timeout()

2019-02-28 Thread Shawn Guo
On Tue, Feb 19, 2019 at 06:14:29PM -0800, Andrey Smirnov wrote: > Replace explicit polling loop with a call to > regmap_read_poll_timeout() to avoid code repetition. Also fix > misspelled "failed" while at it. > > Signed-off-by: Andrey Smirnov > Cc: Lucas Stach > Cc: Chris Healy > Cc:

Re: [PATCH] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port

2019-02-28 Thread Shawn Guo
On Tue, Feb 19, 2019 at 02:37:00PM +0100, Michal Vokáč wrote: > The PHY must add delays to both Tx and Rx clock on the cpu port > to work propperly. > > It worked with the rgmii mode before beacause the qca8k driver > (incorrecly) enabled delays in that mode. > > Signed-off-by: Michal Vokáč >

Re: [PATCH v2 3/3] arm64: dts: imx8mq: Add the opp table and cores opp properties

2019-02-28 Thread Shawn Guo
On Fri, Feb 15, 2019 at 06:07:24PM +, Abel Vesa wrote: > Add the 0.8GHz and 1GHz opps. According to the datasheet: > https://www.nxp.com/docs/en/data-sheet/IMX8MDQLQIEC.pdf > section 3.1.3 Operating ranges. > > The 0.8GHz opp runs in nominal mode with the regulator set to 0.9V. > The 1GHz

Re: [PATCH v2 2/3] arm64: dts: imx8mq: Add the buck vdd_arm regulator

2019-02-28 Thread Shawn Guo
On Fri, Feb 15, 2019 at 06:07:23PM +, Abel Vesa wrote: > According to the schematics, this is a MP2147 switch converter > which is controlled by GPIO1_IO13. When set the gpio is set to > high the regulator output is set to 0.9V. When the gpio is set > to low the regulator output is set to 1V.

Re: [PATCH V7 1/2] arm64: dts: freescale: imx8qxp: add cpu opp table

2019-02-27 Thread Shawn Guo
On Thu, Feb 28, 2019 at 06:18:30AM +, Anson Huang wrote: > Hi, Shawn > > Best Regards! > Anson Huang > > > -Original Message----- > > From: Shawn Guo [mailto:shawn...@kernel.org] > > Sent: 2019年2月28日 11:19 > > To: Anson Huang > > Cc: r

Re: [PATCH V7 1/2] arm64: dts: freescale: imx8qxp: add cpu opp table

2019-02-27 Thread Shawn Guo
On Tue, Feb 26, 2019 at 05:17:31AM +, Anson Huang wrote: > Add i.MX8QXP CPU opp table to support cpufreq. > > Signed-off-by: Anson Huang > Acked-by: Viresh Kumar Prefix 'arm64: dts: imx8qxp: ' would already be clear enough. I dropped 'freescale' from there and applied patch. > --- > No

Re: [PATCH 4/4] arm64: dts: freescale: imx8qxp: add watchdog support

2019-02-17 Thread Shawn Guo
On Thu, Feb 14, 2019 at 11:45:14AM +, Anson Huang wrote: > Add i.MX8QXP system controller watchdog support. > > Signed-off-by: Anson Huang > --- > Note: this patch is based on my thermal patch series: > https://patchwork.kernel.org/patch/10800699/ > --- >

Re: [PATCH 0/2] Adding DTS to support STMPE811 ADC on Toradex Boards

2019-02-12 Thread Shawn Guo
On Fri, Feb 01, 2019 at 11:36:34AM +0800, Shawn Guo wrote: > On Tue, Jan 22, 2019 at 02:21:33PM +0100, Philippe Schenker wrote: > > Philippe Schenker (2): > > ARM: dts: Add stmpe-adc DT node to Toradex iMX6 modules > > ARM: dts: Add stmpe-adc DT node to Toradex T30 modu

Re: [PATCH V3] ARM: dts: imx: Add support for Logic PD i.MX6QD EVM

2019-02-10 Thread Shawn Guo
On Sun, Feb 10, 2019 at 02:57:23PM -0600, Adam Ford wrote: > The EVM consists of a system on module (SOM) and baseboard, and LCD. > This patch adds a DTSI file for the SOM and baseboard separately, > then a wrapper to combine them and specify processor type and a > LCD information. > >

Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

2019-02-10 Thread Shawn Guo
On Mon, Feb 11, 2019 at 02:53:18AM +, Peng Ma wrote: > > > >-Original Message----- > >From: Shawn Guo > >Sent: 2019年2月1日 14:30 > >To: Peng Ma > >Cc: ax...@kernel.dk; robh...@kernel.org; mark.rutl...@arm.com; Leo Li > >; linux-...@vger.kernel

Re: [PATCH 1/4] ARM: dts: imx6qdl-sabresd: add regulator control for isl29023 sensor

2019-02-10 Thread Shawn Guo
On Thu, Feb 07, 2019 at 03:18:30PM +, Anson Huang wrote: > The isl29023 light sensor driver has supported regulator control, > assign the power supply for isl29023 to enable the control. > > Signed-off-by: Anson Huang Applied all, thanks.

Re: [PATCH] arm64: dts: imx8mq: Add RTC support

2019-02-10 Thread Shawn Guo
On Thu, Jan 31, 2019 at 03:01:22PM +, Abel Vesa wrote: > Add RTC support for i.MX8MQ. > > Signed-off-by: Abel Vesa Applied, thanks.

Re: [PATCH v3] firmware: imx: Add support to start/stop a CPU

2019-02-10 Thread Shawn Guo
On Wed, Jan 30, 2019 at 01:30:22PM +, Daniel Baluta wrote: > This is done via RPC call to SCU. > > Signed-off-by: Daniel Baluta Applied, thanks.

Re: [PATCH 2/2] ARM: dts: imx7: add DMA properties for ECSPI

2019-02-10 Thread Shawn Guo
On Thu, Feb 07, 2019 at 09:00:44PM +, Trent Piepho wrote: > On Mon, 2019-01-07 at 14:22 +0100, Stefan Agner wrote: > > Allow to use DMA for SPI by adding the appropriate DMA properites > > to the ecspi nodes. > > > > Signed-off-by: Stefan Agner > > --- > > arch/arm/boot/dts/imx7s.dtsi | 8

Re: [v5 2/2] arm64: dts: lx2160a: add sata node support

2019-01-31 Thread Shawn Guo
On Fri, Jan 25, 2019 at 08:10:13AM +, Peng Ma wrote: > Add SATA device nodes for fsl-lx2160a and enable support > for QDS and RDB boards. > > Signed-off-by: Peng Ma > --- > changed for V5: > - no change > > arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 16 +++ >

Re: [PATCH V3] ARM: dts: imx: Add support for Logic PD i.MX6QD EVM

2019-01-31 Thread Shawn Guo
On Wed, Jan 23, 2019 at 08:10:17AM -0600, Adam Ford wrote: > The EVM consists of a system on module (SOM) and baseboard, and LCD. > This patch adds a DTSI file for the SOM and baseboard separately, > then a wrapper to combine them and specify processor type and a > LCD information. > >

Re: [PATCH] arm64: dts: ls1028a: Add Audio DT nodes

2019-01-31 Thread Shawn Guo
On Wed, Jan 23, 2019 at 01:21:35PM +0800, Alison Wang wrote: > This patch adds Audio DT nodes for LS1028ARDB and LS1028AQDS boards. > > Signed-off-by: Alison Wang > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 62 >

Re: [PATCH v7 5/5] arm64: dts: lx2160a: update fspi node

2019-01-31 Thread Shawn Guo
On Tue, Jan 15, 2019 at 10:05:35AM +, Yogesh Narayan Gaur wrote: > Flash mt35xu512aba connected to FlexSPI controller supports > 1-1-8/1-8-8 protocol. > Added flag spi-rx-bus-width and spi-tx-bus-width with values as > 8 and 8 respectively for both flashes connected at CS0 and CS1. > >

Re: [PATCH 0/2] Adding DTS to support STMPE811 ADC on Toradex Boards

2019-01-31 Thread Shawn Guo
On Tue, Jan 22, 2019 at 02:21:33PM +0100, Philippe Schenker wrote: > Philippe Schenker (2): > ARM: dts: Add stmpe-adc DT node to Toradex iMX6 modules > ARM: dts: Add stmpe-adc DT node to Toradex T30 modules Applied both, thanks.

Re: [PATCH v3 0/5] Add Oxalis board support

2019-01-31 Thread Shawn Guo
On Tue, Jan 22, 2019 at 09:51:42AM +0530, Manivannan Sadhasivam wrote: > Manivannan Sadhasivam (5): > dt-bindings: arm: fsl: Fix bindings for LS1012A and LS1021A based > boards > ARM: dts: Add devicetree compatibles for LS1021A based boards > dt-bindings: vendor-prefixes: Add EBS-SYSTART

Re: [PATCH v8 4/5] arm64: defconfig: enable NXP FlexSPI driver

2019-01-31 Thread Shawn Guo
On Tue, Jan 15, 2019 at 12:00:31PM +, Yogesh Narayan Gaur wrote: > Enable driver support of NXP FlexSPI controller. > > Signed-off-by: Yogesh Narayan Gaur Applied, thanks.

Re: [PATCH v8 3/5] arm64: dts: lx2160a: add FlexSPI node property

2019-01-31 Thread Shawn Guo
On Tue, Jan 15, 2019 at 12:00:26PM +, Yogesh Narayan Gaur wrote: > Add fspi node property for LX2160A SoC for FlexSPI driver. > Property added for the FlexSPI controller and for the connected > slave device for the LX2160ARDB target. > This is having two SPI-NOR flash device, mt35xu512aba,

Re: [PATCH] ARM: dts: colibri: use valid range configuration for weim

2019-01-21 Thread Shawn Guo
On Mon, Jan 21, 2019 at 04:53:27PM +0100, Stefan Agner wrote: > A valid WEIM range configuration must specify range entries for > all four chip selects. This fixes an error on boot: > imx-weim: probe of 21b8000.weim failed with error -22 > > Signed-off-by: Stefan Agner Applied, thanks.

Re: [PATCH v3 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

2019-01-21 Thread Shawn Guo
On Mon, Jan 21, 2019 at 09:57:04AM +, Martyn Welch wrote: > Add vendor prefix "catalyst" for Catalyst Semiconductor which is > already in use but undocumented. > > Signed-off-by: Martyn Welch > Reviewed-by: Rob Herring Applied both, thanks.

Re: [v3] arm64: dts: lx2160a: add sata node support

2019-01-21 Thread Shawn Guo
On Thu, Jan 17, 2019 at 02:12:24AM +, Peng Ma wrote: > Add SATA device nodes for fsl-lx2160a and enable support > for QDS and RDB boards. > > Signed-off-by: Peng Ma > --- > changed for V3: > - updated the commit log > > arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 16

Re: [PATCH] ARM: dts: imx6*-apalis/-colibri: mark I2C recovery GPIOs as open drain

2019-01-21 Thread Shawn Guo
On Fri, Jan 18, 2019 at 02:31:13PM +0100, Stefan Agner wrote: > Since commit d2d0ad2aec4a ("i2c: imx: use open drain for recovery > GPIO") GPIO lib expects this GPIO to be configured as open drain. > Make sure we define this GPIO as open drain in the device tree. > This gets rid of the following

Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis

2019-01-21 Thread Shawn Guo
On Mon, Jan 21, 2019 at 07:57:20PM +, Leo Li wrote: > > > So it seems the compatible of the boards below are missing there. > > > > > > ls1021a-moxa-uc-8410a.dts > > > ls1021a-qds.dts > > > ls1021a-twr.dts > > > > So how should we proceed here? The above mentioned boards are lacking > >

Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms

2019-01-21 Thread Shawn Guo
On Wed, Jan 16, 2019 at 05:31:46PM +, Ioana Ciornei wrote: > > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 > > > platforms > > > > > > On Wed, Jan 16, 2019 at 10:02:01AM +, Ioana Ciornei wrote: > > > > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console

Re: [PATCH 2/3] Documentation: DT: Add entry for DPAA2 console

2019-01-21 Thread Shawn Guo
On Fri, Dec 21, 2018 at 03:31:11PM +, Ioana Ciornei wrote: > This patch adds a devicetree binding documentation for > FSL's DPAA2 console. > > Signed-off-by: Ioana Ciornei > --- > Documentation/devicetree/bindings/misc/dpaa2-console.txt | 11 +++ > MAINTAINERS

Re: linux-next: Fixes tag needs some work in the imx-mxs tree

2019-01-16 Thread Shawn Guo
On Thu, Jan 17, 2019 at 07:54:59AM +1100, Stephen Rothwell wrote: > Hi Shawn, > > Commit > > fde7ed930ca2 ("arm64: dts: imx8qxp: Fix MU4_INT number") > > has a malformed Fixes tag. > > The SHA1 should be at least 12 digits long. Fixed. Thanks for spotting it, Stephen. Shawn

Re: [PATCH v2] dt-bindings: imx8mq: Number clocks consecutively

2019-01-16 Thread Shawn Guo
On Wed, Jan 16, 2019 at 09:41:22AM +0100, Guido Günther wrote: > This fixes a duplicate use of 232 and numbers the clocks without holes. > > Fixes: 1cf3817bf1f5 ("dt-bindings: Add binding for i.MX8MQ CCM") > > Signed-off-by: Guido Günther Applied, thanks.

Re: [PATCH v2] arm64: dts: imx8qxp: Fix MU4_INT number

2019-01-16 Thread Shawn Guo
On Wed, Jan 16, 2019 at 01:21:36PM +, Daniel Baluta wrote: > MU4_INT correct number is 180, while 179 is for MU3_INT. > > Fixes: 3d91ba65fec ("arm64: dts: imx: add imx8qxp support") > Reviewed-by: Fabio Estevam > Reviewed-by: Dong Aisheng > Signed-off-by: Daniel Baluta Applied, thanks.

Re: [PATCH v3] arm64: defconfig: Add i.MX8MQ boot necessary configs

2019-01-16 Thread Shawn Guo
On Wed, Jan 16, 2019 at 09:41:59AM +, Abel Vesa wrote: > Enable all the i.MX8MQ configs necessary to boot. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Fabio Estevam > Signed-off-by: Abel Vesa Applied, thanks.

Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms

2019-01-16 Thread Shawn Guo
On Wed, Jan 16, 2019 at 10:02:01AM +, Ioana Ciornei wrote: > > Subject: Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 > > platforms > > > > On Fri, Dec 21, 2018 at 03:31:09PM +, Ioana Ciornei wrote: > > > Add the dpaa2-console device tree node for the following > > > DPAA2

Re: [PATCH shawn/for-next v4 1/2] dt-bindings: arm: Add Y Soft IOTA Draco, Hydra and Ursa boards

2019-01-16 Thread Shawn Guo
On Tue, Jan 15, 2019 at 02:22:44PM +, Vokáč Michal wrote: > These are i.MX6DualLite/Solo based single board computers used > in various Y Soft products. > > Cc: Andrew Lunn > Signed-off-by: Michal Vokáč Applied both, thanks.

Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis

2019-01-16 Thread Shawn Guo
On Tue, Jan 15, 2019 at 10:07:12PM -0600, Rob Herring wrote: > On Tue, Jan 15, 2019 at 8:21 PM Shawn Guo wrote: > > > > On Mon, Jan 14, 2019 at 12:02:47PM -0600, Rob Herring wrote: > > > On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam > > > wrote: >

<    5   6   7   8   9   10   11   12   13   14   >